From 7ce12a4b0696f22ca52c2d43c8ca6426c054965a Mon Sep 17 00:00:00 2001 From: chenyu Date: Tue, 22 Oct 2024 10:01:33 -0400 Subject: [PATCH] fix typing in simplify_valid [pr] (#7216) --- tinygrad/codegen/uopgraph.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tinygrad/codegen/uopgraph.py b/tinygrad/codegen/uopgraph.py index b43fa214e3..e9ceb3fc5c 100644 --- a/tinygrad/codegen/uopgraph.py +++ b/tinygrad/codegen/uopgraph.py @@ -133,7 +133,7 @@ def simplify_valid(valid:UOp) -> Optional[UOp]: ret:List[UOp] = [] something_changed = False for stmt in split_uop(valid, BinaryOps.AND): - ret.append(stmt if not ret else uop_given_valid(functools.reduce(operator.and_, ret), stmt)) + ret.append(newstmt if ret and (newstmt:=uop_given_valid(functools.reduce(operator.and_, ret), stmt)) is not None else stmt) if ret[-1] is not stmt: something_changed = True return functools.reduce(operator.and_, ret) if something_changed else None