From 88661cd96f3f0fafea1139ec32e9078823a5d5eb Mon Sep 17 00:00:00 2001 From: chenyu Date: Thu, 9 Jan 2025 18:58:36 -0500 Subject: [PATCH] fix checking DiskBuffer is opened [pr] (#8547) `assert self.device.mem is not None` did not assert because `.mem` triggers AttributeError first --- tinygrad/runtime/ops_disk.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tinygrad/runtime/ops_disk.py b/tinygrad/runtime/ops_disk.py index ba9590436c..0a01e22a08 100644 --- a/tinygrad/runtime/ops_disk.py +++ b/tinygrad/runtime/ops_disk.py @@ -67,7 +67,7 @@ class DiskBuffer: self.device, self.size, self.offset = device, size, offset def __repr__(self): return f"" def _buf(self) -> memoryview: - assert self.device.mem is not None, "DiskBuffer wasn't opened" + assert hasattr(self.device, "mem"), "DiskBuffer wasn't opened" return memoryview(self.device.mem)[self.offset:self.offset+self.size] MAP_LOCKED, MAP_POPULATE = 0 if OSX else 0x2000, getattr(mmap, "MAP_POPULATE", 0 if OSX else 0x008000)