From b2e2ace85b0f1861c4cb0cd5f8651e72bccb24a1 Mon Sep 17 00:00:00 2001 From: qazal <77887910+Qazalin@users.noreply.github.com> Date: Mon, 26 Jan 2026 06:36:23 -0500 Subject: [PATCH] viz: remove ci check, it's VIZ=-1/-2 (#14343) --- .github/workflows/test.yml | 5 ++--- tinygrad/uop/ops.py | 4 ++-- 2 files changed, 4 insertions(+), 5 deletions(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 3cce312e07..f67a9f6b97 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -650,8 +650,7 @@ jobs: run: TRANSCENDENTAL=2 python -m pytest -n=auto test/test_ops.py::TestOps::test_sin test/test_ops.py::TestOps::test_cos test/test_ops.py::TestOps::test_tan test/test_ops.py::TestOps::test_exp test/test_ops.py::TestOps::test_log --durations=20 - name: Run TestOps.test_add with SQTT run: | - VIZ=1 PMC=1 DEBUG=5 python3 test/test_ops.py TestOps.test_add - VIZ=1 SQTT=1 DEBUG=5 python3 test/test_ops.py TestOps.test_add + VIZ=-2 DEBUG=5 python3 test/test_ops.py TestOps.test_add extra/sqtt/rgptool.py create "/tmp/profile.pkl.$USER" -o /tmp/gpu0.rgp - name: Run process replay tests uses: ./.github/actions/process-replay @@ -732,7 +731,7 @@ jobs: # skip multitensor because it's slow run: python -m pytest -n=auto test/ --ignore=test/models --ignore=test/unit --ignore test/test_gc.py --ignore test/test_multitensor.py --durations=20 - name: Run TestOps.test_add with PMA - run: VIZ=1 PMA=1 DEBUG=5 python3 test/test_ops.py TestOps.test_add + run: VIZ=-1 PMA=1 DEBUG=5 python3 test/test_ops.py TestOps.test_add - name: Run process replay tests uses: ./.github/actions/process-replay diff --git a/tinygrad/uop/ops.py b/tinygrad/uop/ops.py index 5d9acec8d3..e7b14b4ac8 100644 --- a/tinygrad/uop/ops.py +++ b/tinygrad/uop/ops.py @@ -6,7 +6,7 @@ from enum import Enum, auto from tinygrad.uop import Ops, GroupOp from tinygrad.dtype import ConstType, ImageDType, dtypes, DType, truncate, PtrDType, least_upper_dtype, Invalid, InvalidType, AddrSpace, ConstFloat from tinygrad.helpers import ContextVar, all_int, prod, getenv, all_same, Context, partition, temp, unwrap, T, argfix, Metadata, flatten, TRACEMETA -from tinygrad.helpers import PROFILE, dedup, cdiv, cmod, diskcache_put, to_function_name, cpu_profile, TracingKey, VIZ, SPEC, CI +from tinygrad.helpers import PROFILE, dedup, cdiv, cmod, diskcache_put, to_function_name, cpu_profile, TracingKey, VIZ, SPEC from tinygrad.helpers import strip_parens, colored, ansilen, printable, panic if TYPE_CHECKING: from tinygrad.device import Buffer, MultiBuffer @@ -1175,7 +1175,7 @@ if TRACK_MATCH_STATS or PROFILE: def launch_viz(env_str:str, data:str): os.environ[env_str] = "0" os.environ[f"{env_str}_DATA"] = data - if not int(os.getenv("VIZ", "0")) and not int(os.getenv("PROFILE", "0")) and not CI: + if not int(os.getenv("VIZ", "0")) and not int(os.getenv("PROFILE", "0")): args = ['--kernels', getenv("VIZ_DATA", "")] if getenv("VIZ_DATA", "") else [] args += ['--profile', getenv("PROFILE_DATA", "")] if getenv("PROFILE_DATA", "") else [] viz_path = pathlib.Path(__file__).resolve().parent.parent / "viz" / "serve.py"