github/tinygrad
1
1
Fork 0
mirror of https://github.com/tinygrad/tinygrad.git synced 2026-01-09 15:08:02 -05:00
Code Issues Packages Projects Releases Wiki Activity

viz: add kernel walltime to pmc scoreboard (#13638)

Browse Source 
* viz: add kernel walltime to pmc scoreboard

* fix typing

* tiny TracingKey refactor

* key on kernel name
This commit is contained in:
qazal
2025-12-10 07:16:42 -05:00
committed by GitHub
parent 1666c4aaab
commit be6d538351
2 changed files with 6 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
tinygrad/viz/js/index.js
View File

@@ -787,7 +787,7 @@ async function main() {
} }
const td = tr.append("td").classed(ret.cols[i], true); const td = tr.append("td").classed(ret.cols[i], true);
// string format scalar values // string format scalar values
if (!Array.isArray(value)) { td.text(typeof value === "string" ? value : formatUnit(value)); continue; } if (!Array.isArray(value)) { td.text(typeof value === "string" ? value : ret.cols[i] === "Duration" ? formatMicroseconds(value) : formatUnit(value)); continue; }
// display arrays in a bar graph // display arrays in a bar graph
td.classed("pct-row", true); td.classed("pct-row", true);
const bar = td.append("div"); const bar = td.append("div");

7
tinygrad/viz/serve.py
View File

@@ -223,8 +223,11 @@ def row_tuple(row:str) -> tuple[int, ...]: return tuple(int(x.split(":")[1]) for
def load_sqtt(profile:list[ProfileEvent]) -> None: def load_sqtt(profile:list[ProfileEvent]) -> None:
from tinygrad.runtime.ops_amd import ProfileSQTTEvent, ProfilePMCEvent from tinygrad.runtime.ops_amd import ProfileSQTTEvent, ProfilePMCEvent
counter_events:dict[tuple[str, int], list[ProfileSQTTEvent|ProfilePMCEvent]] = {} counter_events:dict[tuple[str, int], list[ProfileSQTTEvent|ProfilePMCEvent]] = {}
durations:dict[str, list[float]] = {}
for e in profile: for e in profile:
if isinstance(e, (ProfilePMCEvent, ProfileSQTTEvent)): counter_events.setdefault((e.kern, e.exec_tag), []).append(e) if isinstance(e, (ProfilePMCEvent, ProfileSQTTEvent)): counter_events.setdefault((e.kern, e.exec_tag), []).append(e)
if isinstance(e, ProfileRangeEvent) and e.device.startswith("AMD") and e.en is not None:
durations.setdefault(str(e.name), []).append(float(e.en-e.st))
if not counter_events: return if not counter_events: return
# ** init decoder # ** init decoder
from extra.sqtt.roc import decode from extra.sqtt.roc import decode
@@ -281,7 +284,7 @@ def load_sqtt(profile:list[ProfileEvent]) -> None:
ptr += 1 ptr += 1
rows.append(row) rows.append(row)
steps.append(create_step("PMC", ("/pmc", len(ctxs), len(steps)), {"rows":rows, "cols":agg_cols}, depth=1)) steps.append(create_step("PMC", ("/pmc", len(ctxs), len(steps)), {"rows":rows, "cols":agg_cols}, depth=1))
all_runs["rows"].append((key[0], *[r[1] for r in rows])) all_runs["rows"].append((key[0], durations[key[0]].pop(0), *[r[1] for r in rows]))
for cu in prg_cu: for cu in prg_cu:
events = [ProfilePointEvent(unit, "start", unit, ts=Decimal(0)) for unit in units]+cu_events[cu] events = [ProfilePointEvent(unit, "start", unit, ts=Decimal(0)) for unit in units]+cu_events[cu]
steps.append(create_step(f"{cu} {len(cu_events[cu])}", ("/counters", len(ctxs), len(steps)), steps.append(create_step(f"{cu} {len(cu_events[cu])}", ("/counters", len(ctxs), len(steps)),
@@ -289,7 +292,7 @@ def load_sqtt(profile:list[ProfileEvent]) -> None:
for k in sorted(wave_insts.get(cu, []), key=row_tuple): for k in sorted(wave_insts.get(cu, []), key=row_tuple):
data = wave_insts[cu][k] data = wave_insts[cu][k]
steps.append(create_step(k.replace(cu, ""), ("/sqtt-insts", len(ctxs), len(steps)), data, loc=data["loc"], depth=2)) steps.append(create_step(k.replace(cu, ""), ("/sqtt-insts", len(ctxs), len(steps)), data, loc=data["loc"], depth=2))
all_runs["cols"] = ["Kernel", *all_runs["cols"]] all_runs["cols"] = ["Kernel", "Duration", *all_runs["cols"]]
ctxs.append({"name":"Counters", "steps":steps}) ctxs.append({"name":"Counters", "steps":steps})
def device_sort_fn(k:str) -> tuple[int, str, int]: def device_sort_fn(k:str) -> tuple[int, str, int]: