github/tinygrad
1
1
Fork 0
mirror of https://github.com/tinygrad/tinygrad.git synced 2026-04-29 03:00:14 -04:00
Code Issues Packages Projects Releases Wiki Activity

unify negative shape creation to raise ValueError (#5817)

Browse Source 
[run_process_replay]
This commit is contained in:
chenyu
2024-07-30 13:42:59 -04:00
committed by GitHub
parent 6742a4789a
commit defd89e8e0
3 changed files with 12 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
test/test_ops.py
View File

@@ -113,24 +113,24 @@ class TestOps(unittest.TestCase):
]
for method in creation_methods:
with self.assertRaises(RuntimeError): method(-3, 2)
with self.assertRaises(RuntimeError): method((2, -3))
with self.assertRaises(RuntimeError): method((2, -3, 0))
with self.assertRaises(ValueError): method(-3, 2)
with self.assertRaises(ValueError): method((2, -3))
with self.assertRaises(ValueError): method((2, -3, 0))
def test_negative_dims_full(self):
with self.assertRaises(RuntimeError): Tensor.full(-3, 2)
with self.assertRaises(RuntimeError): Tensor.full((2, -3), 4)
with self.assertRaises(RuntimeError): Tensor.full((2, -3, 0), 4)
with self.assertRaises(ValueError): Tensor.full(-3, 2)
with self.assertRaises(ValueError): Tensor.full((2, -3), 4)
with self.assertRaises(ValueError): Tensor.full((2, -3, 0), 4)
def test_negative_dims_eye(self):
with self.assertRaises(RuntimeError): Tensor.eye(-3, 3)
with self.assertRaises(AssertionError): Tensor.eye(3, -3)
with self.assertRaises(RuntimeError): Tensor.eye(-3, -3)
with self.assertRaises(ValueError): Tensor.eye(-3, 3)
with self.assertRaises(ValueError): Tensor.eye(3, -3)
with self.assertRaises(ValueError): Tensor.eye(-3, -3)
def test_negative_dims_kaiming(self):
creation_methods = [Tensor.kaiming_uniform, Tensor.kaiming_normal]
for method in creation_methods:
with self.assertRaises(RuntimeError): method(-3, 3)
with self.assertRaises(ValueError): method(-3, 3)
with self.assertRaises(ValueError): method((-3, 3), 3)
with self.assertRaises(ValueError): method((-3, -3), 3)