From eac046ea55d5360c10aa61e7503ca8a9b1aa5b82 Mon Sep 17 00:00:00 2001 From: nimlgen <138685161+nimlgen@users.noreply.github.com> Date: Wed, 11 Sep 2024 23:13:13 +0300 Subject: [PATCH] hcq check queue size before submit (#6481) --- tinygrad/device.py | 2 +- tinygrad/runtime/ops_nv.py | 2 -- 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/tinygrad/device.py b/tinygrad/device.py index 171d5ade32..4f0a3d7ebe 100644 --- a/tinygrad/device.py +++ b/tinygrad/device.py @@ -315,7 +315,7 @@ class HWCommandQueue: Args: device: The device to submit the queue to """ - self._submit(device) + if self.q: self._submit(device) return self def _submit(self, device:HCQCompiled): raise NotImplementedError("backend should overload this function") diff --git a/tinygrad/runtime/ops_nv.py b/tinygrad/runtime/ops_nv.py index ac5c23ab47..a29b0bd6e6 100644 --- a/tinygrad/runtime/ops_nv.py +++ b/tinygrad/runtime/ops_nv.py @@ -109,8 +109,6 @@ class NVCommandQueue(HWCommandQueue): # pylint: disable=abstract-method self.q = hw_view # type: ignore def _submit_to_gpfifo(self, dev, gpfifo:GPFifo): - if len(self.q) == 0: return - if dev == self.binded_device: cmdq_addr = self.hw_page.va_addr else: if dev.cmdq_wptr + len(self.q) * 4 > dev.cmdq_page.size: