From ff60dab6221d441a76e61f35e1ac195d1eefe215 Mon Sep 17 00:00:00 2001 From: George Hotz <72895+geohot@users.noreply.github.com> Date: Tue, 17 Feb 2026 19:18:06 +0800 Subject: [PATCH] Revert "big sink is on base (#14819)" (#14825) This reverts commit 5fc3d8109f89a06559708e6d0f2ddcdd47164c29. --- test/backend/test_multitensor.py | 10 +++++----- tinygrad/tensor.py | 2 +- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/test/backend/test_multitensor.py b/test/backend/test_multitensor.py index 54347a1a97..9bb05c737b 100644 --- a/test/backend/test_multitensor.py +++ b/test/backend/test_multitensor.py @@ -752,7 +752,7 @@ class TestMultiTensor(unittest.TestCase): # test no left join with self.assertRaises((AssertionError, ValueError)): - t0.reshape((26*15,7)).contiguous().schedule() + t0.reshape((26*15,7)).schedule() @unittest.skip("no longer supports uneven shard") def test_reshape_on_axis_uneven(self): @@ -982,18 +982,18 @@ class TestShrinkMultiTensorShardedAxis(unittest.TestCase): with self.assertRaises(AssertionError): # sharded axis shrink on non-device boundry is not allowed a = t.shrink(((0, 3), (0, 8))) - a.contiguous().schedule() + a.schedule() with self.assertRaises(AssertionError): # cannot shrink sharded and non-sharded axis at the same time a = t.shrink(((0, 2), (2, 4))) - a.contiguous().schedule() + a.schedule() a = t.shrink(((0, 2), (0, 8))) - a.contiguous().schedule() + a.schedule() assert a.shape == (2, 8) p = a.pad(((0, 6), (0, 0))) - p.contiguous().schedule() + p.schedule() assert p.shape == (8, 8) @given(strat.sampled_from([dtypes.float, dtypes.int, dtypes.int64, dtypes.int16])) diff --git a/tinygrad/tensor.py b/tinygrad/tensor.py index 8be37a026e..f52228a0cd 100644 --- a/tinygrad/tensor.py +++ b/tinygrad/tensor.py @@ -255,7 +255,7 @@ class Tensor(OpMixin): NOTE: A Tensor can only be scheduled once. """ - big_sink = UOp.sink(*[x.uop.base for x in (self,)+lst]) + big_sink = UOp.sink(*[x.uop for x in (self,)+lst]) # this is where the schedule cache should go becomes_map, schedule, var_vals = complete_create_schedule_with_vars(big_sink)