fix group issue in send_invite #303

New Issue

AtHeartEngineer · 2025-07-08T08:45:54-04:00

AtHeartEngineer commented

2025-07-08 08:45:54 -04:00

Originally created by @stefan0xC on 12/22/2024

As pointed out in #5320 we have a small bug in this call:

For example I noticed that we are passing the wrong id here:

ed4ad67e73/src/api/core/organizations.rs (L910)

Because in contrast to CollectionUser the GroupUser::new actually expects a different id:

ed4ad67e73/src/db/models/group.rs (L122)
This was probably overlooked because it's not a major issue when a user is not correctly invited to a group and it only shows up as a small warning in the logs:
[2024-12-22 21:23:47.022][request][INFO] POST /api/organizations/152bd996-19f9-40ee-b991-e52333a7e719/users/invite
[2024-12-22 21:23:47.031][vaultwarden::db::models::group][WARN] User could not be found!
[2024-12-22 21:23:48.082][response][INFO] (send_invite) POST /api/organizations/<org_id>/users/invite => 200 OK

Since reviewing my other PR will probably take a while this is a separate fix to address this one issue I found and remembered.

*Originally created by @stefan0xC on 12/22/2024* As pointed out in #5320 we have a small bug in this call: > For example I noticed that we are passing the wrong id here: > > https://github.com/dani-garcia/vaultwarden/blob/ed4ad67e732c213beaec78970cdb68e48bee3dc1/src/api/core/organizations.rs#L910 > > Because in contrast to `CollectionUser` the `GroupUser::new` actually expects a different id: > > https://github.com/dani-garcia/vaultwarden/blob/ed4ad67e732c213beaec78970cdb68e48bee3dc1/src/db/models/group.rs#L122 > This was probably overlooked because it's not a major issue when a user is not correctly invited to a group and it only shows up as a small warning in the logs: > > ``` > [2024-12-22 21:23:47.022][request][INFO] POST /api/organizations/152bd996-19f9-40ee-b991-e52333a7e719/users/invite > [2024-12-22 21:23:47.031][vaultwarden::db::models::group][WARN] User could not be found! > [2024-12-22 21:23:48.082][response][INFO] (send_invite) POST /api/organizations/<org_id>/users/invite => 200 OK > ``` Since reviewing my other PR will probably take a while this is a separate fix to address this one issue I found and remembered.

AtHeartEngineer closed this issue

2025-07-08 08:45:55 -04:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github/vaultwarden#303