From 16965f64e5274e6f43150d878050d84706d2da8d Mon Sep 17 00:00:00 2001 From: Jim Blandy Date: Tue, 14 Nov 2023 09:55:35 -0800 Subject: [PATCH] [naga wgsl-out] Correctly include width in matrix constructions. When generating WGSL for an `Expression::Compose` constructing a matrix, consult `TypeInner::Matrix::width` when writing the type name in the construction expression, rather than just always writing `matNxM`. Fixes #4681. --- naga/src/back/wgsl/writer.rs | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/naga/src/back/wgsl/writer.rs b/naga/src/back/wgsl/writer.rs index 2a398e8845..cd9ae076f3 100644 --- a/naga/src/back/wgsl/writer.rs +++ b/naga/src/back/wgsl/writer.rs @@ -524,14 +524,14 @@ impl Writer { TypeInner::Matrix { columns, rows, - width: _, + width, } => { write!( self.out, - //TODO: Can matrix be other than f32? - "mat{}x{}", + "mat{}x{}<{}>", back::vector_size_str(columns), back::vector_size_str(rows), + scalar_kind_str(crate::Scalar::float(width)) )?; } TypeInner::Pointer { base, space } => {