github/wgpu
1
1
Fork 0
mirror of https://github.com/gfx-rs/wgpu.git synced 2026-04-22 03:02:01 -04:00
Code Issues Packages Projects Releases Wiki Activity

[wgsl-in] Don't double-initialize variables local to loops.

Browse Source
This commit is contained in:
Jim Blandy
2023-10-11 17:17:01 -07:00
committed by Teodor Tanasoaia
parent f7e15bf391
commit 1b485ea925
3 changed files with 151 additions and 139 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
src/front/wgsl/lower/mod.rs
View File

@@ -1181,10 +1181,20 @@ impl<'source, 'temp> Lowerer<'source, 'temp> {
let (const_initializer, initializer) = {
match initializer {
Some(init) if ctx.expression_constness.is_const(init) => {
(Some(init), is_inside_loop.then_some(init))
Some(init) => {
// It's not correct to hoist the initializer up
// to the top of the function if:
// - the initialization is inside a loop, and should
// take place on every iteration, or
// - the initialization is not a constant
// expression, so its value depends on the
// state at the point of initialization.
if is_inside_loop || !ctx.expression_constness.is_const(init) {
(None, Some(init))
} else {
(Some(init), None)
}
}
Some(init) => (None, Some(init)),
None => (None, None),
}
};