github/wgpu
1
1
Fork 0
mirror of https://github.com/gfx-rs/wgpu.git synced 2026-01-09 19:48:47 -05:00
Code Issues Packages Projects Releases Wiki Activity

naga: Correct spelling in wgsl parsing rg11b10float -> rg11b10ufloat (#8219)

Browse Source
This commit is contained in:
EriKWDev
2025-09-21 12:41:17 +02:00
committed by GitHub
parent f6005a16c8
commit 3efd640178
4 changed files with 4 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
CHANGELOG.md
View File

@@ -196,6 +196,7 @@ By @cwfitzgerald in [#8162](https://github.com/gfx-rs/wgpu/pull/8162).
- If the shader source contains control characters, naga now replaces them with U+FFFD ("replacement character") in diagnostic output. By @andyleiserson in [#8049](https://github.com/gfx-rs/wgpu/pull/8049). - If the shader source contains control characters, naga now replaces them with U+FFFD ("replacement character") in diagnostic output. By @andyleiserson in [#8049](https://github.com/gfx-rs/wgpu/pull/8049).
- Add f16 IO polyfill on Vulkan backend to enable SHADER_F16 use without requiring `storageInputOutput16`. By @cryvosh in [#7884](https://github.com/gfx-rs/wgpu/pull/7884). - Add f16 IO polyfill on Vulkan backend to enable SHADER_F16 use without requiring `storageInputOutput16`. By @cryvosh in [#7884](https://github.com/gfx-rs/wgpu/pull/7884).
- For custom Naga backend authors: `naga::proc::Namer` now accepts reserved keywords using two new dedicated types, `proc::{KeywordSet, CaseInsensitiveKeywordSet}`. By @kpreid in [#8136](https://github.com/gfx-rs/wgpu/pull/8136). - For custom Naga backend authors: `naga::proc::Namer` now accepts reserved keywords using two new dedicated types, `proc::{KeywordSet, CaseInsensitiveKeywordSet}`. By @kpreid in [#8136](https://github.com/gfx-rs/wgpu/pull/8136).
- **BREAKING**: Previously the WGSL storage-texture format `rg11b10float` was incorrectly accepted and generated by naga, but now only accepts the the correct name `rg11b10ufloat` instead. By @ErikWDev in [#8219](https://github.com/gfx-rs/wgpu/pull/8219).
#### DX12 #### DX12

2
naga/src/common/wgsl/to_wgsl.rs
View File

@@ -244,7 +244,7 @@ impl ToWgsl for crate::StorageFormat {
Sf::Bgra8Unorm => "bgra8unorm", Sf::Bgra8Unorm => "bgra8unorm",
Sf::Rgb10a2Uint => "rgb10a2uint", Sf::Rgb10a2Uint => "rgb10a2uint",
Sf::Rgb10a2Unorm => "rgb10a2unorm", Sf::Rgb10a2Unorm => "rgb10a2unorm",
Sf::Rg11b10Ufloat => "rg11b10float", Sf::Rg11b10Ufloat => "rg11b10ufloat",
Sf::R64Uint => "r64uint", Sf::R64Uint => "r64uint",
Sf::Rg32Uint => "rg32uint", Sf::Rg32Uint => "rg32uint",
Sf::Rg32Sint => "rg32sint", Sf::Rg32Sint => "rg32sint",

2
naga/src/front/wgsl/parse/conv.rs
View File

@@ -115,7 +115,7 @@ pub fn map_storage_format(word: &str, span: Span) -> Result<'_, crate::StorageFo
"rgba8sint" => Sf::Rgba8Sint, "rgba8sint" => Sf::Rgba8Sint,
"rgb10a2uint" => Sf::Rgb10a2Uint, "rgb10a2uint" => Sf::Rgb10a2Uint,
"rgb10a2unorm" => Sf::Rgb10a2Unorm, "rgb10a2unorm" => Sf::Rgb10a2Unorm,
"rg11b10float" => Sf::Rg11b10Ufloat, "rg11b10ufloat" => Sf::Rg11b10Ufloat,
"r64uint" => Sf::R64Uint, "r64uint" => Sf::R64Uint,
"rg32uint" => Sf::Rg32Uint, "rg32uint" => Sf::Rg32Uint,
"rg32sint" => Sf::Rg32Sint, "rg32sint" => Sf::Rg32Sint,

2
naga/src/front/wgsl/tests.rs
View File

@@ -627,7 +627,7 @@ fn parse_texture_load_store_expecting_four_args() {
for (func, texture) in [ for (func, texture) in [
( (
"textureStore", "textureStore",
"texture_storage_2d_array<rg11b10float, write>", "texture_storage_2d_array<rg11b10ufloat, write>",
), ),
("textureLoad", "texture_2d_array<i32>"), ("textureLoad", "texture_2d_array<i32>"),
] { ] {