From 71a52bdba4cfcb1cd6198d7f100daf0f2ce39641 Mon Sep 17 00:00:00 2001 From: Jim Blandy Date: Sat, 22 Jun 2024 23:11:53 -0700 Subject: [PATCH] [naga spv-out] Use `HandleSet` in `ExpressionConstnessTracker`. Change `naga::back::spv::ExpressionConstnessTracker::inner` from a `BitSet` to a `HandleSet`. Adjust uses. --- naga/src/back/spv/mod.rs | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/naga/src/back/spv/mod.rs b/naga/src/back/spv/mod.rs index 03f4bbef00..91407561ab 100644 --- a/naga/src/back/spv/mod.rs +++ b/naga/src/back/spv/mod.rs @@ -537,32 +537,32 @@ struct FunctionArgument { /// - OpConstantComposite /// - OpConstantNull struct ExpressionConstnessTracker { - inner: bit_set::BitSet, + inner: crate::arena::HandleSet, } impl ExpressionConstnessTracker { fn from_arena(arena: &crate::Arena) -> Self { - let mut inner = bit_set::BitSet::new(); + let mut inner = crate::arena::HandleSet::for_arena(arena); for (handle, expr) in arena.iter() { let insert = match *expr { crate::Expression::Literal(_) | crate::Expression::ZeroValue(_) | crate::Expression::Constant(_) => true, crate::Expression::Compose { ref components, .. } => { - components.iter().all(|h| inner.contains(h.index())) + components.iter().all(|&h| inner.contains(h)) } - crate::Expression::Splat { value, .. } => inner.contains(value.index()), + crate::Expression::Splat { value, .. } => inner.contains(value), _ => false, }; if insert { - inner.insert(handle.index()); + inner.insert(handle); } } Self { inner } } fn is_const(&self, value: Handle) -> bool { - self.inner.contains(value.index()) + self.inner.contains(value) } }