mirror of
https://github.com/gfx-rs/wgpu.git
synced 2026-04-22 03:02:01 -04:00
37724102a3
Better errors for Unexpected, BadInteger, BadFloat, BadTexture, BadTypeCast, UnknownScalarType, UnknownStorageClass, UnknownAttribute, UnknownBuiltin, UnknownShaderStage, UnknownStorageFormat and UnknownConservativeDepth, ZeroStride, ZeroSizeOrAlign and UnknownType. Also adds lexer::capture_span. Also fixes some validation for texture sample types and and issue that cauld cause e.g. the type `f33` to be parsed as `f32`.
317 lines
8.4 KiB
Rust
317 lines
8.4 KiB
Rust
//! Tests for the WGSL front end.
|
|
#![cfg(feature = "wgsl-in")]
|
|
|
|
fn check(input: &str, snapshot: &str) {
|
|
let output = naga::front::wgsl::parse_str(input)
|
|
.expect_err("expected parser error")
|
|
.emit_to_string(input);
|
|
if output != snapshot {
|
|
for diff in diff::lines(&output, snapshot) {
|
|
match diff {
|
|
diff::Result::Left(l) => println!("-{}", l),
|
|
diff::Result::Both(l, _) => println!(" {}", l),
|
|
diff::Result::Right(r) => println!("+{}", r),
|
|
}
|
|
}
|
|
panic!("Error snapshot failed");
|
|
}
|
|
}
|
|
|
|
#[test]
|
|
fn function_without_identifier() {
|
|
check(
|
|
"fn () {}",
|
|
r###"error: expected identifier, found '('
|
|
┌─ wgsl:1:4
|
|
│
|
|
1 │ fn () {}
|
|
│ ^ expected identifier
|
|
|
|
"###,
|
|
);
|
|
}
|
|
|
|
#[test]
|
|
fn invalid_integer() {
|
|
check(
|
|
"fn foo([location(1.)] x: i32) {}",
|
|
r###"error: expected identifier, found '['
|
|
┌─ wgsl:1:8
|
|
│
|
|
1 │ fn foo([location(1.)] x: i32) {}
|
|
│ ^ expected identifier
|
|
|
|
"###,
|
|
);
|
|
}
|
|
|
|
#[test]
|
|
fn invalid_float() {
|
|
check(
|
|
"let scale: f32 = 1.1.;",
|
|
r###"error: expected floating-point literal, found `1.1.`
|
|
┌─ wgsl:1:18
|
|
│
|
|
1 │ let scale: f32 = 1.1.;
|
|
│ ^^^^ expected floating-point literal
|
|
│
|
|
= note: invalid float literal
|
|
|
|
"###,
|
|
);
|
|
}
|
|
|
|
#[test]
|
|
fn invalid_scalar_width() {
|
|
check(
|
|
"let scale: f32 = 1.1f1000;",
|
|
r###"error: invalid width of `1000` for literal
|
|
┌─ wgsl:1:18
|
|
│
|
|
1 │ let scale: f32 = 1.1f1000;
|
|
│ ^^^^^^^^ invalid width
|
|
│
|
|
= note: valid widths are 8, 16, 32, 64
|
|
|
|
"###,
|
|
);
|
|
}
|
|
|
|
#[test]
|
|
fn invalid_texture_sample_type() {
|
|
check(
|
|
"let x: texture_2d<f16>;",
|
|
r###"error: texture sample type must be one of f32, i32 or u32, but found f16
|
|
┌─ wgsl:1:19
|
|
│
|
|
1 │ let x: texture_2d<f16>;
|
|
│ ^^^ must be one of f32, i32 or u32
|
|
|
|
"###,
|
|
);
|
|
}
|
|
|
|
#[test]
|
|
fn unknown_identifier() {
|
|
check(
|
|
r###"
|
|
fn f(x: f32) -> f32 {
|
|
return x * schmoo;
|
|
}
|
|
"###,
|
|
r###"error: no definition in scope for identifier: 'schmoo'
|
|
┌─ wgsl:3:30
|
|
│
|
|
3 │ return x * schmoo;
|
|
│ ^^^^^^ unknown identifier
|
|
|
|
"###,
|
|
);
|
|
}
|
|
|
|
macro_rules! check_validation_error {
|
|
// We want to support an optional guard expression after the pattern, so
|
|
// that we can check values we can't match against, like strings.
|
|
// Unfortunately, we can't simply include `$( if $guard:expr )?` in the
|
|
// pattern, because Rust treats `?` as a repetition operator, and its count
|
|
// (0 or 1) will not necessarily match `$source`.
|
|
( $( $source:literal ),* : $pattern:pat ) => {
|
|
check_validation_error!( @full $( $source ),* : $pattern if true ; "");
|
|
};
|
|
|
|
( $( $source:literal ),* : $pattern:pat if $guard:expr ) => {
|
|
check_validation_error!( @full $( $source ),* : $pattern if $guard ; stringify!( $guard ) );
|
|
};
|
|
|
|
( @full $( $source:literal ),* : $pattern:pat if $guard:expr ; $guard_string:expr ) => {
|
|
$(
|
|
let error = validation_error($source);
|
|
if ! matches!(&error, $pattern if $guard) {
|
|
eprintln!("validation error does not match pattern:\n\
|
|
{:#?}\n\
|
|
\n\
|
|
expected match for pattern:\n\
|
|
{}{}",
|
|
error,
|
|
stringify!($pattern),
|
|
$guard_string);
|
|
panic!("validation error does not match pattern");
|
|
}
|
|
)*
|
|
};
|
|
}
|
|
|
|
fn validation_error(source: &str) -> Result<naga::valid::ModuleInfo, naga::valid::ValidationError> {
|
|
let module = naga::front::wgsl::parse_str(source).expect("expected WGSL parse to succeed");
|
|
naga::valid::Validator::new(
|
|
naga::valid::ValidationFlags::all(),
|
|
naga::valid::Capabilities::empty(),
|
|
)
|
|
.validate(&module)
|
|
}
|
|
|
|
#[test]
|
|
fn invalid_arrays() {
|
|
check_validation_error! {
|
|
"type Bad = array<array<f32>, 4>;",
|
|
"type Bad = array<sampler, 4>;",
|
|
"type Bad = array<texture_2d<f32>, 4>;":
|
|
Err(naga::valid::ValidationError::Type {
|
|
error: naga::valid::TypeError::InvalidArrayBaseType(_),
|
|
..
|
|
})
|
|
}
|
|
|
|
check_validation_error! {
|
|
r#"
|
|
[[block]] struct Block { value: f32; };
|
|
type Bad = array<Block, 4>;
|
|
"#:
|
|
Err(naga::valid::ValidationError::Type {
|
|
error: naga::valid::TypeError::NestedTopLevel,
|
|
..
|
|
})
|
|
}
|
|
|
|
check_validation_error! {
|
|
r#"
|
|
type Bad = [[stride(2)]] array<f32, 4>;
|
|
"#:
|
|
Err(naga::valid::ValidationError::Type {
|
|
error: naga::valid::TypeError::InsufficientArrayStride { stride: 2, base_size: 4 },
|
|
..
|
|
})
|
|
}
|
|
|
|
check_validation_error! {
|
|
"type Bad = array<f32, true>;",
|
|
r#"
|
|
let length: f32 = 2.718;
|
|
type Bad = array<f32, length>;
|
|
"#:
|
|
Err(naga::valid::ValidationError::Type {
|
|
error: naga::valid::TypeError::InvalidArraySizeConstant(_),
|
|
..
|
|
})
|
|
}
|
|
}
|
|
|
|
#[test]
|
|
fn invalid_structs() {
|
|
check_validation_error! {
|
|
"struct Bad { data: sampler; };",
|
|
"struct Bad { data: texture_2d<f32>; };":
|
|
Err(naga::valid::ValidationError::Type {
|
|
error: naga::valid::TypeError::InvalidData(_),
|
|
..
|
|
})
|
|
}
|
|
|
|
check_validation_error! {
|
|
"[[block]] struct Bad { data: ptr<storage, f32>; };":
|
|
Err(naga::valid::ValidationError::Type {
|
|
error: naga::valid::TypeError::InvalidBlockType(_),
|
|
..
|
|
})
|
|
}
|
|
|
|
check_validation_error! {
|
|
"struct Bad { data: array<f32>; other: f32; };":
|
|
Err(naga::valid::ValidationError::Type {
|
|
error: naga::valid::TypeError::InvalidDynamicArray(_, _),
|
|
..
|
|
})
|
|
}
|
|
}
|
|
|
|
#[test]
|
|
fn invalid_functions() {
|
|
check_validation_error! {
|
|
"fn bogus(data: array<f32>) -> f32 { return data[0]; }":
|
|
Err(naga::valid::ValidationError::Function {
|
|
name: function_name,
|
|
error: naga::valid::FunctionError::InvalidArgumentType {
|
|
index: 0,
|
|
name: argument_name,
|
|
},
|
|
..
|
|
})
|
|
if function_name == "bogus" && argument_name == "data"
|
|
}
|
|
}
|
|
|
|
#[test]
|
|
fn missing_bindings() {
|
|
check_validation_error! {
|
|
"
|
|
[[stage(vertex)]]
|
|
fn vertex(input: vec4<f32>) -> [[location(0)]] vec4<f32> {
|
|
return input;
|
|
}
|
|
":
|
|
Err(naga::valid::ValidationError::EntryPoint {
|
|
stage: naga::ShaderStage::Vertex,
|
|
error: naga::valid::EntryPointError::Argument(
|
|
0,
|
|
naga::valid::VaryingError::MissingBinding,
|
|
),
|
|
..
|
|
})
|
|
}
|
|
|
|
check_validation_error! {
|
|
"
|
|
[[stage(vertex)]]
|
|
fn vertex([[location(0)]] input: vec4<f32>, more_input: f32) -> [[location(0)]] vec4<f32> {
|
|
return input + more_input;
|
|
}
|
|
":
|
|
Err(naga::valid::ValidationError::EntryPoint {
|
|
stage: naga::ShaderStage::Vertex,
|
|
error: naga::valid::EntryPointError::Argument(
|
|
1,
|
|
naga::valid::VaryingError::MissingBinding,
|
|
),
|
|
..
|
|
})
|
|
}
|
|
|
|
check_validation_error! {
|
|
"
|
|
[[stage(vertex)]]
|
|
fn vertex([[location(0)]] input: vec4<f32>) -> vec4<f32> {
|
|
return input;
|
|
}
|
|
":
|
|
Err(naga::valid::ValidationError::EntryPoint {
|
|
stage: naga::ShaderStage::Vertex,
|
|
error: naga::valid::EntryPointError::Result(
|
|
naga::valid::VaryingError::MissingBinding,
|
|
),
|
|
..
|
|
})
|
|
}
|
|
|
|
check_validation_error! {
|
|
"
|
|
struct VertexIn {
|
|
[[location(0)]] pos: vec4<f32>;
|
|
uv: vec2<f32>;
|
|
};
|
|
|
|
[[stage(vertex)]]
|
|
fn vertex(input: VertexIn) -> [[location(0)]] vec4<f32> {
|
|
return input.pos;
|
|
}
|
|
":
|
|
Err(naga::valid::ValidationError::EntryPoint {
|
|
stage: naga::ShaderStage::Vertex,
|
|
error: naga::valid::EntryPointError::Argument(
|
|
0,
|
|
naga::valid::VaryingError::MemberMissingBinding(1),
|
|
),
|
|
..
|
|
})
|
|
}
|
|
}
|