build - Refactor Besu custom error prone dependency (#6692)

Move Besu custom error-prone checks into its own repository and use it as an external dependency. This allows to move to a newer version of Google errorprone checks as well while cleaning up build.gradle file.

Key changes resulted due to this change:

* String toLowerCase and toUpperCase to use Locale.ROOT as argument
* Use interface such as List,Map or NavigatableMap instead of concrete class where appropriate.
* Simplify StringBuilder to plain String
* Suppress warnings where appropriate.
-----
Signed-off-by: Usman Saleem <usman@usmans.info>
This commit is contained in:
Usman Saleem
2024-03-27 06:17:40 +10:00
committed by GitHub
parent 56e1844415
commit e954537fcc
109 changed files with 325 additions and 2011 deletions

View File

@@ -165,9 +165,7 @@ public class Subscribers<T> {
}
@Override
public void forEach(final Consumer<T> action) {
return;
}
public void forEach(final Consumer<T> action) {}
@Override
public int getSubscriberCount() {

View File

@@ -114,6 +114,7 @@ public class LogUtilTest {
return lines;
}
@SuppressWarnings("InfiniteRecursion")
private void recurseTimesAndThrow(final int times) {
if (times < 1) {
throw new RuntimeException("FakeStackOverflowError");