From b1f65c97ae2eeb48c6c2f38463f28e5323b32302 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?rich=CE=9Brd?= <info@richardramos.me>
Date: Thu, 3 Apr 2025 15:33:08 -0400
Subject: [PATCH] fix: unsafe string usage (#1308)

---
 libp2p/transports/tls/certificate.nim | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/libp2p/transports/tls/certificate.nim b/libp2p/transports/tls/certificate.nim
index 758769a7a..30539b459 100644
--- a/libp2p/transports/tls/certificate.nim
+++ b/libp2p/transports/tls/certificate.nim
@@ -113,7 +113,7 @@ func makeIssuerDN(identityKeyPair: KeyPair): string {.inline.} =
 
   return issuerDN
 
-proc makeASN1Time(time: Time): cstring {.inline.} =
+proc makeASN1Time(time: Time): string {.inline.} =
   let str =
     try:
       let f = initTimeFormat("yyyyMMddhhmmss")
@@ -121,7 +121,7 @@ proc makeASN1Time(time: Time): cstring {.inline.} =
     except TimeFormatParseError:
       raiseAssert "time format is const and checked with test"
 
-  return (str & "Z").cstring
+  return str & "Z"
 
 proc makeExtValues(
     identityKeypair: KeyPair, certKey: cert_key_t
@@ -217,8 +217,8 @@ proc generateX509*(
 
   ret = cert_generate(
     cert_ctx, certKey, certificate.addr, libp2pExtension.signature.unsafeAddr,
-    libp2pExtension.pubkey.unsafeAddr, issuerDN.cstring, validFromAsn1, validToAsn1,
-    encodingFormat.cert_format_t,
+    libp2pExtension.pubkey.unsafeAddr, issuerDN.cstring, validFromAsn1.cstring,
+    validToAsn1.cstring, encodingFormat.cert_format_t,
   )
   if ret != CERT_SUCCESS:
     raise