fix(KarmaRLN): remove userTier, minmalKarma, tierSize, undo changes in Verifier.verifyProof call

This commit is contained in:
Ricardo Guilherme Schmidt
2025-05-28 07:24:24 -03:00
parent 88584bb4b1
commit 67d1211ffc

View File

@@ -2,33 +2,24 @@
pragma solidity 0.8.26; pragma solidity 0.8.26;
import "../Karma.sol"; import "../Karma.sol";
import {IVerifier} from "./IVerifier.sol"; import { IVerifier } from "./IVerifier.sol";
/// @title Rate-Limiting Nullifier registry contract /// @title Rate-Limiting Nullifier registry contract
/// @dev This contract allows you to register RLN commitment and withdraw/slash. /// @dev This contract allows you to register RLN commitment and withdraw/slash.
contract KarmaRLN { contract KarmaRLN {
/// @dev User metadata struct. /// @dev User metadata struct.
/// @param userAddress: address of depositor; /// @param userAddress: address of depositor;
/// @param userTier: user's message limit (karmaBalance / MINIMAL_KARMA).
struct User { struct User {
address userAddress; address userAddress;
uint256 userTier;
uint256 index; uint256 index;
} }
/// @dev Minimal membership deposit (stake amount) value - cost of 1 message.
uint256 public immutable MINIMAL_KARMA;
/// @dev Maximal rate. /// @dev Maximal rate.
uint256 public immutable TIER_SIZE; uint256 public immutable TIER_SIZE;
/// @dev Registry set size (1 << DEPTH). /// @dev Registry set size (1 << DEPTH).
uint256 public immutable SET_SIZE; uint256 public immutable SET_SIZE;
/// @dev Fee percentage.
uint8 public immutable FEE_PERCENTAGE;
/// @dev Current index where identityCommitment will be stored. /// @dev Current index where identityCommitment will be stored.
uint256 public identityCommitmentIndex; uint256 public identityCommitmentIndex;
@@ -44,9 +35,8 @@ contract KarmaRLN {
/// @dev Emmited when a new member registered. /// @dev Emmited when a new member registered.
/// @param identityCommitment: `identityCommitment`; /// @param identityCommitment: `identityCommitment`;
/// @param userTier: user's tier;
/// @param index: idCommitmentIndex value. /// @param index: idCommitmentIndex value.
event MemberRegistered(uint256 identityCommitment, uint256 userTier, uint256 index); event MemberRegistered(uint256 identityCommitment, uint256 index);
/// @dev Emmited when a member was withdrawn. /// @dev Emmited when a member was withdrawn.
/// @param index: index of `identityCommitment`; /// @param index: index of `identityCommitment`;
@@ -57,21 +47,10 @@ contract KarmaRLN {
/// @param slasher: address of slasher (msg.sender). /// @param slasher: address of slasher (msg.sender).
event MemberSlashed(uint256 index, address slasher); event MemberSlashed(uint256 index, address slasher);
/// @param minimalKarma: minimal membership deposit;
/// @param tierSize: tier sizee;
/// @param depth: depth of the merkle tree; /// @param depth: depth of the merkle tree;
/// @param _token: address of the ERC20 contract; /// @param _token: address of the ERC20 contract;
/// @param _verifier: address of the Groth16 Verifier. /// @param _verifier: address of the Groth16 Verifier.
constructor( constructor(uint256 depth, address _verifier, address _token) {
uint256 minimalKarma,
uint256 tierSize,
uint256 depth,
address _token,
address _verifier
) {
MINIMAL_KARMA = minimalKarma;
TIER_SIZE = tierSize;
SET_SIZE = 1 << depth; SET_SIZE = 1 << depth;
karma = Karma(_token); karma = Karma(_token);
@@ -87,13 +66,10 @@ contract KarmaRLN {
uint256 index = identityCommitmentIndex; uint256 index = identityCommitmentIndex;
uint256 amount = karma.balanceOf(msg.sender); uint256 amount = karma.balanceOf(msg.sender);
require(index < SET_SIZE, "RLN, register: set is full"); require(index < SET_SIZE, "RLN, register: set is full");
require(amount >= MINIMAL_KARMA, "RLN, register: amount is lower than minimal deposit");
require(members[identityCommitment].userAddress == address(0), "RLN, register: idCommitment already registered"); require(members[identityCommitment].userAddress == address(0), "RLN, register: idCommitment already registered");
uint256 userTier = amount / TIER_SIZE; members[identityCommitment] = User(msg.sender, index);
emit MemberRegistered(identityCommitment, index);
members[identityCommitment] = User(msg.sender, userTier, index);
emit MemberRegistered(identityCommitment, userTier, index);
unchecked { unchecked {
identityCommitmentIndex = index + 1; identityCommitmentIndex = index + 1;
@@ -106,7 +82,7 @@ contract KarmaRLN {
function exit(uint256 identityCommitment, uint256[8] calldata proof) external { function exit(uint256 identityCommitment, uint256[8] calldata proof) external {
User memory member = members[identityCommitment]; User memory member = members[identityCommitment];
require(member.userAddress != address(0), "RLN, withdraw: member doesn't exist"); require(member.userAddress != address(0), "RLN, withdraw: member doesn't exist");
require(_verifyProof(identityCommitment, member.userAddress, proof), "RLN, withdraw: invalid proof"); require(_verifyProof(identityCommitment, proof), "RLN, withdraw: invalid proof");
delete members[identityCommitment]; delete members[identityCommitment];
emit MemberExited(member.index); emit MemberExited(member.index);
@@ -114,30 +90,25 @@ contract KarmaRLN {
/// @dev Slashes identity with identityCommitment. /// @dev Slashes identity with identityCommitment.
/// @param identityCommitment: `identityCommitment`; /// @param identityCommitment: `identityCommitment`;
/// @param receiver: stake receiver;
/// @param proof: snarkjs's format generated proof (without public inputs) packed consequently. /// @param proof: snarkjs's format generated proof (without public inputs) packed consequently.
function slash(uint256 identityCommitment, uint256[8] calldata proof) external { function slash(uint256 identityCommitment, uint256[8] calldata proof) external {
User memory member = members[identityCommitment]; User memory member = members[identityCommitment];
require(member.userAddress != address(0), "RLN, slash: member doesn't exist"); require(member.userAddress != address(0), "RLN, slash: member doesn't exist");
require(_verifyProof(identityCommitment, proof), "RLN, slash: invalid proof"); require(_verifyProof(identityCommitment, proof), "RLN, slash: invalid proof");
karma.slash(member.userAddress); //karma.slash(member.userAddress);
delete members[identityCommitment]; delete members[identityCommitment];
emit MemberSlashed(member.index, receiver); emit MemberSlashed(member.index, msg.sender);
} }
/// @dev Groth16 proof verification /// @dev Groth16 proof verification
function _verifyProof(uint256 identityCommitment, uint256[8] calldata proof) function _verifyProof(uint256 identityCommitment, uint256[8] calldata proof) internal view returns (bool) {
internal
view
returns (bool)
{
return verifier.verifyProof( return verifier.verifyProof(
[proof[0], proof[1]], [proof[0], proof[1]],
[[proof[2], proof[3]], [proof[4], proof[5]]], [[proof[2], proof[3]], [proof[4], proof[5]]],
[proof[6], proof[7]], [proof[6], proof[7]],
[identityCommitment] [identityCommitment, uint256(0)]
); );
} }
} }