Update eslint (#2348)

* Update eslint

* Check for missing semicolons with eslint and fix those

.eslintrc

@@ -48,6 +48,7 @@
       "last"
     ],
     "dot-notation": "off",
+    "semi": "error",
     "valid-jsdoc": "error",
     "no-global-getComputedStyle": "error",
     "jsdoc/check-tag-names": 1,

feature-detects/audio.js

@@ -27,7 +27,7 @@ define(['Modernizr', 'createElement'], function(Modernizr, createElement) {
     var bool = false;
 
     try {
-      bool = !!elem.canPlayType
+      bool = !!elem.canPlayType;
       if (bool) {
         bool      = new Boolean(bool);
         bool.ogg  = elem.canPlayType('audio/ogg; codecs="vorbis"') .replace(/^no$/, '');

feature-detects/css/columns.js

@@ -15,7 +15,7 @@ define(['Modernizr', 'testAllProps'], function(Modernizr, testAllProps) {
       var bool = false;
       var test = testAllProps('columnCount');
       try {
-        bool = !!test
+        bool = !!test;
         if (bool) {
           bool = new Boolean(bool);
         }
@@ -38,8 +38,5 @@ define(['Modernizr', 'testAllProps'], function(Modernizr, testAllProps) {
 
       Modernizr.addTest('csscolumns.' + name, test);
     }
-
-
   })();
-
 });

feature-detects/css/focuswithin.js

@@ -9,7 +9,7 @@
 define(['Modernizr'], function(Modernizr) {
   Modernizr.addTest('focuswithin', function() {
     try {
-      document.querySelector(':focus-within')
+      document.querySelector(':focus-within');
     } catch (error) {
       return false;
     }

feature-detects/video.js

@@ -41,7 +41,7 @@ define(['Modernizr', 'createElement'], function(Modernizr, createElement) {
 
     // IE9 Running on Windows Server SKU can cause an exception to be thrown, bug #224
     try {
-      bool = !!elem.canPlayType
+      bool = !!elem.canPlayType;
       if (bool) {
         bool = new Boolean(bool);
         bool.ogg = elem.canPlayType('video/ogg; codecs="theora"').replace(/^no$/, '');

feature-detects/websockets/binary.js

@@ -16,7 +16,7 @@ define(['Modernizr'], function(Modernizr) {
       protoBin;
 
     if ('WebSocket' in window) {
-      protoBin = 'binaryType' in WebSocket.prototype
+      protoBin = 'binaryType' in WebSocket.prototype;
       if (protoBin) {
         return protoBin;
       }

package.json

@@ -17,7 +17,7 @@
   },
   "devDependencies": {
     "@alrra/travis-scripts": "^3.0.1",
-    "eslint": "^5.0.1",
+    "eslint": "^5.1.0",
     "eslint-plugin-jsdoc": "^3.7.1",
     "expect.js": "^0.3.1",
     "grunt": "^1.0.3",