AtHeartEngineer/icicle
1
0
Fork 0
mirror of https://github.com/pseXperiments/icicle.git synced 2026-01-09 15:37:58 -05:00
Code Issues Packages Projects Releases Wiki Activity

pr comments

Browse Source
This commit is contained in:
VitaliiH
2024-07-25 11:40:46 +02:00
parent 15d9cd1a1b
commit 0fcbb58b13
2 changed files with 3 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
icicle/src/ntt/kernel_ntt.cu
View File

@@ -703,11 +703,8 @@ namespace mxntt {
CHK_INIT_IF_RETURN();
if (log_size < 4) {
// TODO: should throw exception
// TODO: fast twiddles should be used only with mixed radix ntt
// THROW_ICICLE_ERR(IcicleError_t::InvalidArgument, "log_size must be >= 4");
printf("warning: when using fast twiddles, log_size must be at least 4, got %d\n", log_size); // TODO: logging
return cudaSuccess;
THROW_ICICLE_ERR(IcicleError_t::InvalidArgument, "when using fast twiddles, log_size must be at least 4");
}
S* w6_table;

2
icicle/src/ntt/ntt.cu
View File

@@ -469,6 +469,8 @@ namespace ntt {
CHK_IF_RETURN(mxntt::generate_external_twiddles_generic(
primitive_root, domain.twiddles, domain.internal_twiddles, domain.basic_twiddles, domain.max_log_size,
ctx.stream));
fast_twiddles_mode &= domain.max_log_size >= 4; // fast twiddles cannot be built for smaller domain
if (fast_twiddles_mode) {
// generating fast-twiddles (note that this cost 4N additional memory)