AtHeartEngineer/linea-monorepo
1
0
Fork 0
mirror of https://github.com/vacp2p/linea-monorepo.git synced 2026-01-09 15:38:06 -05:00
Code Issues Packages Projects Releases Wiki Activity

fix don't assume zero-padded lanes (#267)

Browse Source 
Co-authored-by: Arya Tabaie <15056835+Tabaie@users.noreply.github.com>
This commit is contained in:
Arya Tabaie
2024-10-30 11:37:58 -05:00
committed by GitHub
parent 36959fb21b
commit a306bcb78b
2 changed files with 11 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
prover/circuits/pi-interconnection/keccak/snark.go
View File

@@ -2,6 +2,7 @@ package keccak
import (
"errors"
"github.com/consensys/linea-monorepo/prover/circuits/internal"
"math/big"
"github.com/consensys/gnark/frontend"
@@ -264,15 +265,9 @@ func pad(api frontend.API, inputLanes []frontend.Variable, length frontend.Varia
}
//inInputRange := frontend.Variable(1)
inputRange := internal.NewRange(api, length, len(lanes))
for i := range lanes {
iEqualsLen := api.IsZero(api.Sub(length, i))
/*inInputRange = api.Sub(inInputRange, iEqualsLen)
lanes[i] = api.Mul(inInputRange, lanes[i]) // technically unnecessary if we say input must be zero-padded */
lanes[i] = api.Add(lanes[i], api.Mul(dstLane, iEqualsLen)) // first padding byte contribution
lanes[i] = api.Add(api.Mul(lanes[i], inputRange.InRange[i]), api.Mul(dstLane, inputRange.IsFirstBeyond[i])) // first padding byte contribution
if i%lanesPerBlock == lanesPerBlock-1 { // if it's the last byte of ANY block
isLastBlock := api.IsZero(api.Sub(i+1, api.Mul(nbBlocks, lanesPerBlock))) // TODO check the slice to IsZero involves one constraint only

8
prover/circuits/pi-interconnection/keccak/snark_test.go
View File

@@ -2,6 +2,7 @@ package keccak
import (
"fmt"
"github.com/consensys/linea-monorepo/prover/circuits/internal/test_utils"
"math/big"
"testing"
@@ -303,3 +304,10 @@ func (c *testCreateColsBoundaryChecks) Define(api frontend.API) error {
hsh.createColumns()
return nil
}
func TestPadDirtyLanes(t *testing.T) {
test_utils.SnarkFunctionTest(func(api frontend.API) []frontend.Variable {
padded, _ := pad(api, []frontend.Variable{1, 0x123456}, 1)
return padded
}, 1, 0x100000000000000, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0x80)(t)
}