fix(tests): Correct misleading variable names and expressions in test files (#14292)

Co-authored-by: Radosław Kapka <rkapka@wp.pl>
This commit is contained in:
Jun Song
2024-08-03 06:32:53 +09:00
committed by GitHub
parent 85f334b663
commit ff3e0856a1
2 changed files with 11 additions and 11 deletions

View File

@@ -1029,7 +1029,7 @@ func TestServer_ListValidators_FromOldEpoch(t *testing.T) {
ctx := context.Background()
slot := primitives.Slot(0)
epochs := 10
epochs := primitives.Epoch(10)
numVals := uint64(10)
beaconDB := dbTest.SetupDB(t)
@@ -1065,7 +1065,7 @@ func TestServer_ListValidators_FromOldEpoch(t *testing.T) {
}
res, err := bs.ListValidators(context.Background(), req)
require.NoError(t, err)
assert.Equal(t, epochs, len(res.ValidatorList))
assert.Equal(t, int(numVals), len(res.ValidatorList))
vals := st.Validators()
want := make([]*ethpb.Validators_ValidatorContainer, 0)
@@ -1077,7 +1077,7 @@ func TestServer_ListValidators_FromOldEpoch(t *testing.T) {
}
req = &ethpb.ListValidatorsRequest{
QueryFilter: &ethpb.ListValidatorsRequest_Epoch{
Epoch: 10,
Epoch: epochs,
},
}
res, err = bs.ListValidators(context.Background(), req)

View File

@@ -43,17 +43,17 @@ func TestBeaconStateMerkleProofs_altair(t *testing.T) {
t.Run("current sync committee", func(t *testing.T) {
cscp, err := altair.CurrentSyncCommitteeProof(ctx)
require.NoError(t, err)
require.Equal(t, len(cscp), 5)
require.Equal(t, 5, len(cscp))
for i, bytes := range cscp {
require.Equal(t, hexutil.Encode(bytes), results[i])
require.Equal(t, results[i], hexutil.Encode(bytes))
}
})
t.Run("next sync committee", func(t *testing.T) {
nscp, err := altair.NextSyncCommitteeProof(ctx)
require.NoError(t, err)
require.Equal(t, len(nscp), 5)
require.Equal(t, 5, len(nscp))
for i, bytes := range nscp {
require.Equal(t, hexutil.Encode(bytes), results[i])
require.Equal(t, results[i], hexutil.Encode(bytes))
}
})
t.Run("finalized root", func(t *testing.T) {
@@ -112,17 +112,17 @@ func TestBeaconStateMerkleProofs_bellatrix(t *testing.T) {
t.Run("current sync committee", func(t *testing.T) {
cscp, err := bellatrix.CurrentSyncCommitteeProof(ctx)
require.NoError(t, err)
require.Equal(t, len(cscp), 5)
require.Equal(t, 5, len(cscp))
for i, bytes := range cscp {
require.Equal(t, hexutil.Encode(bytes), results[i])
require.Equal(t, results[i], hexutil.Encode(bytes))
}
})
t.Run("next sync committee", func(t *testing.T) {
nscp, err := bellatrix.NextSyncCommitteeProof(ctx)
require.NoError(t, err)
require.Equal(t, len(nscp), 5)
require.Equal(t, 5, len(nscp))
for i, bytes := range nscp {
require.Equal(t, hexutil.Encode(bytes), results[i])
require.Equal(t, results[i], hexutil.Encode(bytes))
}
})
t.Run("finalized root", func(t *testing.T) {