Fix join to avoid recursive call

beacon-chain/core/helpers/randao.go

@@ -29,10 +29,13 @@ func Seed(state state.ReadOnlyBeaconState, epoch primitives.Epoch, domain [bls.D
 	if err != nil {
 		return [32]byte{}, err
 	}
-	seed := append(domain[:], bytesutil.Bytes8(uint64(epoch))...)
-	seed = append(seed, randaoMix...)
 
-	seed32 := hash.Hash(seed)
+	var seed [bls.DomainByteLength + 8 + 32]byte
+	copy(seed[0:], domain[:])
+	copy(seed[bls.DomainByteLength:], bytesutil.Bytes8(uint64(epoch)))
+	copy(seed[bls.DomainByteLength+8:], randaoMix)
+
+	seed32 := hash.Hash(seed[:])
 
 	return seed32, nil
 }

beacon-chain/core/signing/signing_root.go

@@ -247,7 +247,7 @@ func ComputeDomain(domainType [DomainByteLength]byte, forkVersion, genesisValida
 
 // This returns the bls domain given by the domain type and fork data root.
 func domain(domainType [DomainByteLength]byte, forkDataRoot []byte) []byte {
-	var b []byte
+	b := make([]byte, 0, 32)
 	b = append(b, domainType[:4]...)
 	b = append(b, forkDataRoot[:28]...)
 	return b

beacon-chain/state/stateutil/participation_bit_root.go

@@ -32,7 +32,7 @@ func ParticipationBitsRoot(bits []byte) ([32]byte, error) {
 // it does not have length bytes per chunk.
 func packParticipationBits(bytes []byte) ([][32]byte, error) {
 	numItems := len(bytes)
-	chunks := make([][32]byte, 0, numItems/32)
+	chunks := make([][32]byte, 0, (numItems+31)/32)
 	for i := 0; i < numItems; i += 32 {
 		j := i + 32
 		// We create our upper bound index of the chunk, if it is greater than numItems,

beacon-chain/sync/validate_aggregate_proof.go

@@ -2,6 +2,7 @@ package sync
 
 import (
 	"context"
+	"encoding/binary"
 	"fmt"
 
 	"github.com/OffchainLabs/prysm/v6/beacon-chain/blockchain"
@@ -265,7 +266,10 @@ func (s *Service) hasSeenAggregatorIndexEpoch(epoch primitives.Epoch, aggregator
 func (s *Service) setAggregatorIndexEpochSeen(epoch primitives.Epoch, aggregatorIndex primitives.ValidatorIndex) {
 	s.seenAggregatedAttestationLock.Lock()
 	defer s.seenAggregatedAttestationLock.Unlock()
-	b := append(bytesutil.Bytes32(uint64(epoch)), bytesutil.Bytes32(uint64(aggregatorIndex))...)
+
+	b := make([]byte, 64)
+	binary.LittleEndian.PutUint64(b, uint64(epoch))
+	binary.LittleEndian.PutUint64(b[32:], uint64(aggregatorIndex))
 	s.seenAggregatedAttestationCache.Add(string(b), true)
 }
 

changelog/tt_bread.md

@@ -0,0 +1,3 @@
+### Ignored
+
+- Pre allocate slices if we can to avoid grow slice.

crypto/bls/signature_batch.go

@@ -32,6 +32,14 @@ func NewSet() *SignatureBatch {
 
 // Join merges the provided signature batch to out current one.
 func (s *SignatureBatch) Join(set *SignatureBatch) *SignatureBatch {
+	if cap(s.Signatures)-len(s.Signatures) < cap(set.Signatures)-len(set.Signatures) {
+		set.Signatures = append(set.Signatures, s.Signatures...)
+		set.PublicKeys = append(set.PublicKeys, s.PublicKeys...)
+		set.Messages = append(set.Messages, s.Messages...)
+		set.Descriptions = append(set.Descriptions, s.Descriptions...)
+		return set
+	}
+
 	s.Signatures = append(s.Signatures, set.Signatures...)
 	s.PublicKeys = append(s.PublicKeys, set.PublicKeys...)
 	s.Messages = append(s.Messages, set.Messages...)