mirror of
https://github.com/OffchainLabs/prysm.git
synced 2026-01-09 13:28:01 -05:00
14c67376c3
**What type of PR is this?** Other **What does this PR do? Why is it needed?** This pull request modifies the `PULL_REQUEST_TEMPLATE.md` to ensure the developer checked that their PR works as expected. Some contributors push some changes, without even running the modified client once to see if their changes work as expected. Avoidable back-and-forth trips between the contributor and the reviewers could be prevented thanks to running the modified client. **Acknowledgements** - [x] I have read [CONTRIBUTING.md](https://github.com/prysmaticlabs/prysm/blob/develop/CONTRIBUTING.md). - [x] I have included a uniquely named [changelog fragment file](https://github.com/prysmaticlabs/prysm/blob/develop/CONTRIBUTING.md#maintaining-changelogmd). - [x] I have added a description to this PR with sufficient context for reviewers to understand this PR. --------- Co-authored-by: Preston Van Loon <pvanloon@offchainlabs.com>
39 lines
1.7 KiB
Markdown
39 lines
1.7 KiB
Markdown
<!-- Thanks for sending a PR! Before submitting:
|
|
|
|
1. If this is your first PR, check out our contribution guide here https://docs.prylabs.network/docs/contribute/contribution-guidelines
|
|
You will then need to sign our Contributor License Agreement (CLA), which will show up as a comment from a bot in this pull request after you open it. We cannot review code without a signed CLA.
|
|
2. Please file an associated tracking issue if this pull request is non-trivial and requires context for our team to understand. All features and most bug fixes should have
|
|
an associated issue with a design discussed and decided upon. Small bug
|
|
fixes and documentation improvements don't need issues.
|
|
3. New features and bug fixes must have tests. Documentation may need to
|
|
be updated. If you're unsure what to update, send the PR, and we'll discuss
|
|
in review.
|
|
4. Note that PRs updating dependencies and new Go versions are not accepted.
|
|
Please file an issue instead.
|
|
5. A changelog entry is required for user facing issues.
|
|
-->
|
|
|
|
**What type of PR is this?**
|
|
|
|
> Uncomment one line below and remove others.
|
|
>
|
|
> Bug fix
|
|
> Feature
|
|
> Documentation
|
|
> Other
|
|
|
|
**What does this PR do? Why is it needed?**
|
|
|
|
**Which issues(s) does this PR fix?**
|
|
|
|
Fixes #
|
|
|
|
**Other notes for review**
|
|
|
|
**Acknowledgements**
|
|
|
|
- [ ] I have read [CONTRIBUTING.md](https://github.com/prysmaticlabs/prysm/blob/develop/CONTRIBUTING.md).
|
|
- [ ] I have included a uniquely named [changelog fragment file](https://github.com/prysmaticlabs/prysm/blob/develop/CONTRIBUTING.md#maintaining-changelogmd).
|
|
- [ ] I have added a description with sufficient context for reviewers to understand this PR.
|
|
- [ ] I have tested that my changes work as expected and I added a testing plan to the PR description (if applicable).
|