mirror of
https://github.com/OffchainLabs/prysm.git
synced 2026-01-09 13:28:01 -05:00
* Ran gopls modernize to fix everything go run golang.org/x/tools/gopls/internal/analysis/modernize/cmd/modernize@latest -fix -test ./... * Override rules_go provided dependency for golang.org/x/tools to v0.38.0. To update this, checked out rules_go, then ran `bazel run //go/tools/releaser -- upgrade-dep -mirror=false org_golang_x_tools` and copied the patches. * Fix buildtag violations and ignore buildtag violations in external * Introduce modernize analyzer package. * Add modernize "any" analyzer. * Fix violations of any analyzer * Add modernize "appendclipped" analyzer. * Fix violations of appendclipped * Add modernize "bloop" analyzer. * Add modernize "fmtappendf" analyzer. * Add modernize "forvar" analyzer. * Add modernize "mapsloop" analyzer. * Add modernize "minmax" analyzer. * Fix violations of minmax analyzer * Add modernize "omitzero" analyzer. * Add modernize "rangeint" analyzer. * Fix violations of rangeint. * Add modernize "reflecttypefor" analyzer. * Fix violations of reflecttypefor analyzer. * Add modernize "slicescontains" analyzer. * Add modernize "slicessort" analyzer. * Add modernize "slicesdelete" analyzer. This is disabled by default for now. See https://go.dev/issue/73686. * Add modernize "stringscutprefix" analyzer. * Add modernize "stringsbuilder" analyzer. * Fix violations of stringsbuilder analyzer. * Add modernize "stringsseq" analyzer. * Add modernize "testingcontext" analyzer. * Add modernize "waitgroup" analyzer. * Changelog fragment * gofmt * gazelle * Add modernize "newexpr" analyzer. * Disable newexpr until go1.26 * Add more details in WORKSPACE on how to update the override * @nalepae feedback on min() * gofmt * Fix violations of forvar
57 lines
1.4 KiB
Go
57 lines
1.4 KiB
Go
// Package ineffassign implements a static analyzer to ensure that there are no ineffectual
|
|
// assignments in source code.
|
|
package ineffassign
|
|
|
|
import (
|
|
"errors"
|
|
"go/ast"
|
|
"sort"
|
|
|
|
"golang.org/x/tools/go/analysis"
|
|
"golang.org/x/tools/go/analysis/passes/inspect"
|
|
"golang.org/x/tools/go/ast/inspector"
|
|
)
|
|
|
|
// Doc explaining the tool.
|
|
const Doc = "Tool to make sure there are no ineffectual assignments in source code"
|
|
|
|
// Analyzer runs static analysis.
|
|
var Analyzer = &analysis.Analyzer{
|
|
Name: "ineffassign",
|
|
Doc: Doc,
|
|
Requires: []*analysis.Analyzer{inspect.Analyzer},
|
|
Run: run,
|
|
}
|
|
|
|
func run(pass *analysis.Pass) (any, error) {
|
|
insp, ok := pass.ResultOf[inspect.Analyzer].(*inspector.Inspector)
|
|
if !ok {
|
|
return nil, errors.New("analyzer is not type *inspector.Inspector")
|
|
}
|
|
|
|
nodeFilter := []ast.Node{
|
|
(*ast.File)(nil),
|
|
}
|
|
insp.Preorder(nodeFilter, func(node ast.Node) {
|
|
f, ok := node.(*ast.File)
|
|
if !ok {
|
|
return
|
|
}
|
|
bld := &builder{vars: map[*ast.Object]*variable{}}
|
|
bld.walk(f)
|
|
chk := &checker{vars: bld.vars, seen: map[*block]bool{}}
|
|
for _, b := range bld.roots {
|
|
chk.check(b)
|
|
}
|
|
sort.Sort(chk.ineff)
|
|
// Report ineffectual assignments if any.
|
|
for _, id := range chk.ineff {
|
|
if id.Name != "ctx" { // We allow ineffectual assignment to ctx (to override ctx).
|
|
pass.Reportf(id.Pos(), "ineffectual assignment to %q", id.Name)
|
|
}
|
|
}
|
|
})
|
|
|
|
return nil, nil
|
|
}
|