delete vulnerable AS::SafeBuffer#[]

This commit is contained in:
Akira Matsuda
2012-02-13 17:58:01 +09:00
committed by Aaron Patterson
parent 42fabd2366
commit dfa33fa3da
2 changed files with 0 additions and 12 deletions

View File

@@ -98,12 +98,6 @@ module ActiveSupport #:nodoc:
end
end
def[](*args)
new_safe_buffer = super
new_safe_buffer.instance_eval { @dirty = false }
new_safe_buffer
end
def safe_concat(value)
raise SafeConcatError if dirty?
original_concat(value)

View File

@@ -111,12 +111,6 @@ class SafeBufferTest < ActiveSupport::TestCase
assert_kind_of NilClass, @buffer.slice("chipchop")
end
test "Should initialize @dirty to false for new instance when sliced" do
dirty = @buffer[0,0].send(:dirty?)
assert_not_nil dirty
assert !dirty
end
test "clone_empty returns an empty buffer" do
assert_equal '', ActiveSupport::SafeBuffer.new('foo').clone_empty
end