Chad Fowler
b6f9932561
fix bad logic in determining if in rails app subdir
...
Signed-off-by: David Heinemeier Hansson <david@loudthinking.com >
2010-07-26 16:40:46 -05:00
David Heinemeier Hansson
d283ca34a9
Fix deprecation message on info screen
2010-07-26 16:35:27 -05:00
Nick Sieger
f427fdd13a
JRuby should not need system_timer, and cannot install it either
...
Signed-off-by: Santiago Pastorino <santiago@wyeworks.com >
2010-07-26 18:18:11 -03:00
David Heinemeier Hansson
f79f9a74a4
Add install script for testing gems locally
2010-07-26 16:09:10 -05:00
David Heinemeier Hansson
06b95314db
Spaces, people, spaces!
2010-07-26 15:43:22 -05:00
David Heinemeier Hansson
3bdaa099ad
Make Rails 3 RC depend on Bundler RC
2010-07-26 15:30:23 -05:00
Santiago Pastorino
4ac3ae0685
missing requires added
2010-07-26 16:26:07 -03:00
David Heinemeier Hansson
e71815b988
Rails version update
2010-07-26 13:51:47 -05:00
David Heinemeier Hansson
856fc4bbc3
Prep for RC
2010-07-26 12:53:25 -05:00
José Valim
dd61a817de
Move runtime back to the Thread.current
2010-07-26 19:14:56 +02:00
Aaron Patterson
32844cbc02
fixing space errors
2010-07-26 09:58:35 -07:00
Wincent Colaiuta
c819c131f2
doc: cleanup respond_to documentation
...
Signed-off-by: Wincent Colaiuta <win@wincent.com >
2010-07-26 18:55:51 +02:00
Santiago Pastorino
fd589db863
Changed returning with tap on guides
2010-07-26 18:55:51 +02:00
Leigh Caplan
37d82f2ca0
Test to ensure that falsy objects aren't wrapped by deprecation proxies
2010-07-26 09:53:42 -07:00
Leigh Caplan
e56c9ef08d
Override new on proxy objects so that they never wrap nil or false.
2010-07-26 09:53:42 -07:00
Bernerd Schaefer
e87e3db200
XmlMini.rename_key emits valid xml with dasherize
...
This resolves issues for libraries which use '_' prefixed keys in their
attributes hash, such as Mongoid. A key like "_id" or "_type" will no
longer be converted to "<-id>" and "<-type>".
Signed-off-by: wycats <wycats@gmail.com >
2010-07-26 09:48:22 -07:00
Santiago Pastorino
4ea1753fc2
This is for making sure const_missing is triggered without warnings
2010-07-26 12:51:52 -03:00
Santiago Pastorino
514624e53c
Fixes usage message when running rails without --dev on a cloned rails repo
2010-07-26 12:51:48 -03:00
Neeraj Singh
a44652baed
No need to check for :uniq
...
[#5170 state:resolved]
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-07-26 17:41:04 +02:00
Łukasz Strzałkowski
da845275dd
Removed deprecated APIs in text and number helpers [ #5156 state:resolved]
...
They're deprecated since 2008. It's time to get rid of them.
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-07-26 17:26:59 +02:00
Thiago Pradi
f70c0b348d
Removing unnecessary code [ #5192 state:resolved]
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-07-26 17:13:52 +02:00
Josef Reidinger
0e969bdaf8
fix escaping id and parameters in path [ #5137 state:resolved]
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-07-26 16:59:47 +02:00
Neeraj Singh
78c8242d2f
strengthening the test suite for rescue_from
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-07-26 16:48:50 +02:00
Neeraj Singh
a5bb1f511f
strengthening the rescue_from test suites
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-07-26 16:48:45 +02:00
José Valim
9789d22137
Update to latest thor.
2010-07-26 11:41:52 +02:00
wycats
1b97701e51
Fix a bug where requires inside of autoloads were being added to the autoloaded_constants list, causing mayhem. [ #5165 state:resolved]
2010-07-26 00:59:54 -07:00
Aaron Patterson
13df581ec7
using AREL from the environment if it exists
2010-07-25 16:44:14 -07:00
Aaron Patterson
53fbbf4b83
fisting warning
2010-07-25 16:28:21 -07:00
Santiago Pastorino
2c4fcec44d
Gemfile now makes use of platforms calls with blocks instead of elsif logic to define dependencies over specific platforms
2010-07-26 06:42:44 +08:00
Santiago Pastorino
8abcd49995
Bump up bundler
2010-07-26 06:42:44 +08:00
Santiago Pastorino
963c71edfa
Don't interpolate a blank string, avoid warnings
2010-07-26 06:42:44 +08:00
Xavier Noria
6aa1253588
Merge remote branch 'docrails/master'
2010-07-26 00:23:57 +02:00
Aaron Patterson
df95948d45
do not execute the session tests within transactions
2010-07-25 15:17:03 -07:00
Xavier Noria
dcb7832ed5
APIs for individual components are no longer published
2010-07-26 00:05:14 +02:00
Xavier Noria
06853cb0a9
AS guide: Object#returning is gone
2010-07-25 23:42:24 +02:00
Santiago Pastorino
9a32af96d1
CHANGELOG updated Object#returning removed
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-07-25 23:30:36 +02:00
Santiago Pastorino
b0b9bf3204
Object#returning removed
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-07-25 23:30:27 +02:00
José Valim
f4200b0cd5
Cache instrumenter again as per Aaron's patch.
2010-07-25 23:00:15 +02:00
Carlos Antonio da Silva
751f89b8b2
Add assertion to link_to_function test with block and capture, and more expressive test name [ #5179 state:resolved]
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-07-25 23:00:15 +02:00
Xavier Noria
92669b8320
application generation: --skip-testunit and --skip-activerecord renamed to --skip-test-unit and --skip-active-record respectively
...
Reason is their proper spellings are "Test::Unit" and "Active Record".
Option names and descriptions have been revised, as well as some method
names and minor details here and there.
2010-07-25 22:55:38 +02:00
José Valim
331df84cc9
Cache connection access.
2010-07-25 21:01:49 +02:00
José Valim
304c49b146
Move runtime back to connection.
2010-07-25 20:59:37 +02:00
José Valim
ff0d842454
Revert the previous three commits.
...
* AS::Notifications#instrument should not measure anything, it is not its responsibility;
* Adding another argument to AS::Notifications#instrument API needs to be properly discussed;
2010-07-25 20:46:42 +02:00
Aaron Patterson
0d0e793983
look up connection once
2010-07-25 11:16:13 -07:00
Aaron Patterson
fc088d4e8f
cache the instrumentor for a speed gain
2010-07-25 11:11:51 -07:00
Aaron Patterson
b7e0408ca9
use a hash to collect optional statistics about the instrumentation
2010-07-25 11:11:23 -07:00
José Valim
d02f2d2fb2
runtime should be properly initialized.
2010-07-25 18:26:42 +02:00
José Valim
82c7ef837d
Move runtime to log subscriber.
2010-07-25 16:42:05 +02:00
Santiago Pastorino
b1cfcedc8f
Change returning with tap
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-07-25 16:33:04 +02:00
Sebastian A. Espindola
8d5b792e7d
Fixed output_buffer encoding problem [ #5179 ]
...
Signed-off-by: Santiago Pastorino <santiago@wyeworks.com >
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-07-25 16:33:04 +02:00
Arkadiusz Holko
7fb7a2bd69
Fixes syntax error in "with_scope" example
2010-07-25 05:29:40 -07:00
Santiago Pastorino
749948a264
Removing one AS/lib ruby and rake adds to $LOAD_PATH
2010-07-25 08:27:00 +08:00
Jack Dempsey
9a9fb12623
Fix small middlewares typo
2010-07-24 15:28:45 -04:00
José Valim
834bd23a07
Get rid of instrumenter.elapsed.
2010-07-24 10:22:22 +02:00
Neeraj Singh
082ca51d65
bringing consistency in comments
2010-07-24 00:45:53 -04:00
Santiago Pastorino
85980852a0
make a throwaway value equals to _ to avoid warnings
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-07-24 01:19:55 +02:00
Santiago Pastorino
8289661903
Make this test, test again
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-07-24 01:19:47 +02:00
Santiago Pastorino
e1d4e78b15
Removes unused vars
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-07-24 01:19:44 +02:00
Santiago Pastorino
80cf6559ed
Makes restore previosly saved warnings_on_first_load value and avoid warning
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-07-24 01:19:43 +02:00
José Valim
7a7cbab1f4
Merge branch 'master' of github.com:rails/rails
2010-07-24 00:49:16 +02:00
José Valim
76b6136b00
Clean up AM and AC railties.
2010-07-24 00:48:12 +02:00
José Valim
2af8fd2829
Also move asset_path to AbstractController.
2010-07-24 00:47:48 +02:00
Xavier Noria
728ba209e7
include the root README.rdoc as main page
2010-07-24 00:35:22 +02:00
Jeroen van Dijk and Josh Kalderimis
affeb51569
Move config_accessor :asset_host from ActionController::Base to AbstractController which fixes issues with asset_host in ActionMailer
...
Including:
- Moved mailer objects in separate directory
- Added two tests for asset_host configuration option
2010-07-24 00:27:25 +02:00
Neeraj Singh
8429e7b45b
making comments sentence more concise
2010-07-23 16:22:17 -04:00
Neeraj Singh
46c7a991a2
fixing typo
2010-07-23 16:14:16 -04:00
Aaron Patterson
b50635a59f
update Rakefiles for RDoc 2.5
2010-07-23 21:11:29 +02:00
Neeraj Singh
4bf6c1c0c0
adding proper markup in comments
2010-07-23 14:27:14 -04:00
Neeraj Singh
34165176cf
shortening the sentences and removing fluff
2010-07-23 14:21:03 -04:00
Neeraj Singh
8f638d8cc1
reformatting sentence
2010-07-23 14:11:14 -04:00
Aaron Patterson
5ebc1d88d3
testing sqlbypass destroy. caching connection during destroy
2010-07-23 08:36:58 -07:00
Aaron Patterson
9b48a94c0a
brrrrr! freeze is not needed
2010-07-23 08:30:14 -07:00
Aaron Patterson
5e6382e607
fixing space error
2010-07-22 23:45:07 -07:00
Aaron Patterson
34ff74f448
refactoring more methods to a class methods module
2010-07-22 23:44:58 -07:00
Aaron Patterson
da37716c35
refactoring class methods to a module
2010-07-22 23:40:39 -07:00
Santiago Pastorino
b378b19430
Makes Rakefile activate rdoc >= 2.5.9
...
Signed-off-by: Xavier Noria <fxn@hashref.com >
2010-07-23 00:04:06 +02:00
Xavier Noria
2944a79452
bump required RDoc to >= 2.5.9, and replace the 2.2 horo.rb with Aaron's gem
2010-07-22 23:19:01 +02:00
Santiago Pastorino
227680f415
session_id is a VARCHAR
2010-07-22 13:34:27 -07:00
Jeremy Kemper
3ec6759552
Session data will exceed 255 bytes. Use TEXT.
2010-07-22 13:34:07 -07:00
Andrew Kaspick
cf5c2bacb0
update remote_function docs referencing link_to_remote
2010-07-22 14:59:52 -05:00
José Valim
64ca80e523
Merge remote branch 'spastorino/master'
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-07-22 21:46:01 +02:00
Santiago Pastorino
24f303b677
Makes current adapter decide the syntax of PRIMARY KEY column definition
2010-07-22 15:49:05 -03:00
Santiago Pastorino
7113f207c3
This is a VARCHAR not a TEXT
2010-07-22 15:48:57 -03:00
Santiago Pastorino
1b8cd5fb53
MySQL can't index a TEXT column
2010-07-22 15:48:55 -03:00
Santiago Pastorino
21c4b0942f
Don't shadow outer local variables
2010-07-22 15:48:52 -03:00
Carlhuda
ba8d89c4c8
Performance optimizations to handle cases of instrumentors that are not listened to. Also, fix a possible concurrency issue.
2010-07-22 11:36:16 -07:00
Aaron Patterson
97f3c7387e
refactor to use instance methods and be kind to subclasses
2010-07-22 09:38:56 -07:00
Aaron Patterson
38734aff20
adding a test for session save
2010-07-22 09:35:50 -07:00
Ivan Torres
2d2bde9f54
[PATCH] Update guides after Jeremy Kemper's changes on fieldWithErrors
...
to field_with_errors [#157 state:resolved]
2010-07-22 10:10:38 -05:00
Mislav Marohnić
3e196db6ad
improve Active Model README
...
- fix indentation problems
- revised introductory text to state right away what the library is
- improved examples: reduce heavy usage of ellipsis,
don't mark paragraphs of text as code
2010-07-22 10:03:55 +02:00
Mislav Marohnić
6b11d0bf68
remove unneeded "Dependencies" section from Action Mailer README
...
Other READMEs don't have dependencies indicated, and installing a gem
takes care of dependencies automatically. For developers, dependencies
are indicated in the Gemfile.
2010-07-22 10:03:55 +02:00
Mislav Marohnić
d5ee17ed20
improve Active Record README
...
- revise introductory text
- improve examples
- don't claim that Oracle, SQL Server, or DB2 are supported
- remove lengthy "simple example"
2010-07-22 10:03:55 +02:00
Mislav Marohnić
a1023b0bf0
improve Action Pack README
...
- revise introductory text
- list modules contained in the package
- improve examples
- remove obsolete `scaffold` and `form` examples
2010-07-22 10:03:49 +02:00
Mislav Marohnić
89b5e79632
revise download/installation/support sections in READMEs
...
- don't reference ancient gem versions
- don't link to old API doc subdomains
- point to GitHub instead of RubyForge
- point to Lighthouse account for support
2010-07-22 09:17:19 +02:00
Bobby Wilson
4ed9bd6431
Changed code style that was incorrectly rendering block style instead of inline.
2010-07-21 20:34:00 -07:00
Santiago Pastorino
30df88ae06
These tests are trusting in the order of the elements so use OrderedHash instead of Hash
2010-07-21 17:34:43 -07:00
Santiago Pastorino
a1e795f554
options could be of any kind of Hash (Hash, HashWithIndifferentAccess or OrderedHash) this way we keep the properties of the options passed as an argument
2010-07-21 17:34:02 -07:00
Aaron Patterson
a78547a9c6
testing loaded? method and reducing funcalls
2010-07-21 16:59:23 -07:00
Aaron Patterson
87a319cd0c
testing new_record? and converting to an attribute
2010-07-21 16:55:04 -07:00
Aaron Patterson
f5de56f537
reducing function calls in the session store
2010-07-21 16:52:15 -07:00
Aaron Patterson
4e6cf429a1
readability is hip
2010-07-21 16:45:38 -07:00
Aaron Patterson
ba0d2a9ce3
starting sql bypass test, fixing create_table and drop_table!
2010-07-21 16:36:28 -07:00
Aaron Patterson
bdbe390a98
initializing instance variables
2010-07-21 16:36:28 -07:00
Aaron Patterson
1f8edb996b
adding tests for sessions and clearing up warnings
2010-07-21 16:36:28 -07:00
Xavier Noria
919eb200a9
Merge remote branch 'rails/master'
2010-07-22 01:29:18 +02:00
Xavier Noria
b456877cfb
camelize and underscore are sort of inverse of each other, but not in a mathematical sense [ #5174 state:resolved]
2010-07-22 01:28:31 +02:00
Xavier Noria
b72cc472f7
routing guide: say "path" when you mean path
2010-07-22 01:28:31 +02:00
Xavier Noria
e9127ce7e8
routing guide: a "photo" resource has by convention paths under "photos", in plural
2010-07-22 01:28:31 +02:00
Wincent Colaiuta
198975ecee
doc: form_for does return output rather than merely evaluate its block
2010-07-22 01:28:31 +02:00
Jeroen van Dijk
ab62aa1c43
Mention that ActionMailer::Base.default_url_options is now deprecated
2010-07-22 01:28:31 +02:00
Jaime Iniesta
6f7402d32b
non-singleton true and false should go on regular font
2010-07-22 01:28:31 +02:00
Jaime Iniesta
402aaa56f5
Active Record Validations and Callbacks guide: Fixed typos and rephrased some paragraphs for clarity
2010-07-22 01:28:30 +02:00
Neeraj Singh
5c137939a7
expanded comment for update_attribute method
2010-07-22 01:28:30 +02:00
Mislav Marohnić
efdfcf1325
correct typos in Routing examples
2010-07-22 01:28:30 +02:00
Neeraj Singh
aa2235be7b
replacing around with for in the comments for callbacks
2010-07-22 01:28:30 +02:00
Xavier Noria
56669ec304
camelize and underscore are sort of inverse of each other, but not in a mathematical sense [ #5174 state:resolved]
2010-07-22 01:27:02 +02:00
Xavier Noria
5cba663578
routing guide: say "path" when you mean path
2010-07-22 00:32:39 +02:00
Santiago Pastorino
6cbd085f69
Test Hash#to_param escapes keys and values
...
[#5175 ]
2010-07-22 06:29:59 +08:00
Santiago Pastorino
5c85822008
Hash#to_param is doesn't use sort anymore, some tests added for Hash#to_param
2010-07-22 06:23:13 +08:00
Xavier Noria
b2818b2472
routing guide: a "photo" resource has by convention paths under "photos", in plural
2010-07-22 00:16:26 +02:00
Subba Rao Pasupuleti
b0c7dee4f2
removing unused models from tests
...
[#5153 state:resolved]
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-07-21 22:08:07 +02:00
Brian Rose
622092d33e
Fixed a globbed route issue where slashes were being escaped, causing assert_routing to fail. [ #5135 state:resolved]
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-07-21 22:07:40 +02:00
Santiago Pastorino
d16c5cc99b
Change some missing README -> README.rdoc
2010-07-22 01:47:06 +08:00
Wincent Colaiuta
680f0459a3
doc: form_for does return output rather than merely evaluate its block
2010-07-21 19:21:05 +02:00
Andrew Kaspick
a1a41a3939
remote_function patch with more detailed test
...
Signed-off-by: wycats <wycats@gmail.com >
2010-07-21 10:04:55 -07:00
Santiago Pastorino
ef5ae60a07
Make use of tap to return a previously used var
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-07-21 17:17:23 +02:00
Santiago Pastorino
e107c208f0
Make config.generators accept string namespaces, you can do now config.generators.test_framework 'rspec' for instance
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-07-21 17:17:23 +02:00
Santiago Pastorino
79d6f314c6
We are doing the same in this conditions
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-07-21 17:17:22 +02:00
Jeroen van Dijk
24c0bc52d2
Mention that ActionMailer::Base.default_url_options is now deprecated
2010-07-21 17:10:24 +02:00
Neeraj Singh
659e3b02ab
renaming tests by removing proxy_options from names
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-07-21 15:25:39 +02:00
José Valim
e13e8dcf44
Use capture instead of yield in link_to_unless.
...
[#5162 state:resolved]
2010-07-21 15:23:14 +02:00
José Valim
9dfe9fa693
Ensure insert_before in middleware stack raises a meaningful error message [ #3679 state:resolved]
2010-07-21 15:17:04 +02:00
José Valim
7131244313
Ensure default_scope can be overwriten by association conditions.
2010-07-21 15:06:23 +02:00
Subba Rao Pasupuleti
d77c3b669c
eagerly loaded association records should respect default_scope [ #2931 state:resolved]
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-07-21 15:01:40 +02:00
Neeraj Singh
992711a86b
update_attribute should not update readonly attributes
...
[#5106 state:resolved]
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-07-21 14:55:57 +02:00
Thiago Pradi
c96a505391
rake db:seed should check if the database have pending migrations [ #5163 state:resolved]
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-07-21 14:55:26 +02:00
José Valim
f3e42292a5
Ensure all join table attributes will be in the same timestamp.
2010-07-21 14:51:15 +02:00
Neeraj Singh
8bb3b634c0
Timestamp columns of HABTM join table should record timestamps
...
[#5161 state:resolved]
2010-07-21 14:45:36 +02:00
José Valim
01add55d6a
Revert "save on parent should not cascade to child unless child changed [ #3353 state:open]"
...
Please check Lighthouse for more information.
This reverts commit 4a0d7c1a43 .
2010-07-21 14:44:46 +02:00
Subba Rao Pasupuleti
96b2516c3c
Strengthening the test for nested_attribute
...
Loading the associate target in nested_attributes
should load most recent attributes for child
records marked for destruction
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-07-21 14:25:34 +02:00
Szetobo
0057d2df71
association load target shouldn't replace records
...
from db if it is already loaded by nested attributes assignment
[#5053 state:resolved]
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-07-21 14:25:27 +02:00
Subba Rao Pasupuleti
c0bfa0bfc1
In nested_attributes when association is not loaded and association
...
record is saved and then in memory record attributes should be saved
[#5053 state:resolved]
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-07-21 14:25:19 +02:00
Neeraj Singh
6ba7d5e654
- without the id test is passing even if I change :allow_destroy from 'false' - adding more tests to strengthen the test suite
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-07-21 14:25:13 +02:00
José Valim
0a729b0a91
Fix failing railties tests.
2010-07-21 14:16:37 +02:00
José Valim
53310614d7
Reuse already existing classes for ActiveModel tests.
2010-07-21 13:00:56 +02:00
José Valim
508fba9e07
Add .rdoc extension to README files.
2010-07-21 12:51:14 +02:00
José Valim
b70062f1e7
Rework a bit README files.
2010-07-21 12:37:05 +02:00
José Valim
cd1536887b
Improve contribuition guide.
2010-07-21 12:30:38 +02:00
José Valim
f1082bd51e
Remove old install.rb files.
2010-07-21 11:56:28 +02:00
José Valim
c565f0060a
No need to delegate. Simply include the whole RecordIdentifier module.
2010-07-21 11:46:38 +02:00
Piotr Sarnacki
6807b08099
Moved a few methods from RecordIdentifier to ActiveModel::Naming
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-07-21 11:29:58 +02:00
Santiago Pastorino
fa8b290496
id is a public method
2010-07-21 08:19:53 +08:00
Neeraj Singh
f576d7cf84
Ensure that primary_keys of HABTM records is not double quoted
...
[#5152 state:reslved]
2010-07-20 16:45:42 -07:00
Piotr Sarnacki
a63566dda8
Moved PolymorphicRoutes to ActionDispatch::Routing
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-07-20 23:12:46 +02:00
Santiago Pastorino
978c49ea6a
Make use of severity levels
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-07-20 23:10:59 +02:00
Santiago Pastorino
6ce761c8d9
This example is better for guides and gem/plugins docs
2010-07-20 13:08:03 -07:00
José Valim
d4151d7f0a
Fix a failing test in Railtie and properly define all severity levels in MockLogger for LogSubscriber.
2010-07-20 21:21:14 +02:00
Jaime Iniesta
6914d67ed1
non-singleton true and false should go on regular font
2010-07-20 18:17:29 +02:00
Aaron Patterson
e1df4b9568
adding a reader for loaded, initializing @loaded to false
2010-07-20 09:15:09 -07:00
José Valim
9df9c4bac0
Add a test for elapsed and require missing benchmark file.
2010-07-20 17:07:18 +02:00
Jaime Iniesta
0f991786ee
Merge branch 'master' of github.com:lifo/docrails
2010-07-20 14:22:30 +02:00
Jaime Iniesta
2e4b741111
Active Record Validations and Callbacks guide: Fixed typos and rephrased some paragraphs for clarity
2010-07-20 14:22:19 +02:00
Neeraj Singh
767de13ff4
expanded comment for update_attribute method
2010-07-20 06:56:20 -04:00
José Valim
51d2db0a63
Add missing require to metal/streaming.rb
2010-07-20 09:56:16 +02:00
José Valim
325592038e
Fix typo on CHANGELOG.
2010-07-20 00:22:34 -07:00
Kouhei Sutou
a6e95ba554
fix mixed encoding logs can't be logged.
...
[#4807 state:committed]
Signed-off-by: Kouhei Sutou <kou@cozmixng.org >
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2010-07-19 14:55:58 -07:00
Bryan Helmkamp
e466354edb
Extract ParameterFilter class from FilterParameters mixin
...
Signed-off-by: wycats <wycats@gmail.com >
2010-07-19 13:44:43 -07:00
Aaron Patterson
202fb79e86
reusing the time instrumentation from the instrumenter rather than Benchmark. [ #5098 state:open]
2010-07-19 13:44:11 -07:00
José Valim
c3c349ec3e
Remove assert_valid. It was already deprecated on Rails 2.3.
2010-07-19 22:35:17 +02:00
Santiago Pastorino
17600eb435
Remove unused orig_handler and unneeded parentheses
2010-07-20 04:32:08 +08:00
Santiago Pastorino
d39c3b179c
Test added, we shouldn't log sql calls when logger is not on debug? mode
2010-07-20 04:32:08 +08:00
Aaron Patterson
1b26c66ce4
mocking out debing? call in the MockLogger
2010-07-19 13:19:28 -07:00
Daniel Guettler
38f0161aab
Minor performance improvment in notifications/fanout and active_record/log_subscriber [ #5098 state:open]
2010-07-19 11:45:50 -07:00
Aaron Patterson
ad4ef4226f
avoid const lookup. we know what these constants are in advance
2010-07-19 10:31:24 -07:00
Aaron Patterson
dd4e81df86
avoid call to Array#first
2010-07-19 10:21:45 -07:00
Łukasz Strzałkowski
bd4b3d8b2f
Added missing require of remove_method
2010-07-19 23:44:50 +08:00
Łukasz Strzałkowski
661fd98aad
Make use of redefine_method, removed some more redefining warnings
2010-07-19 23:44:50 +08:00
Łukasz Strzałkowski
7637b7184a
Test for behaviour of befeore_type_cast when operating on datetime colmun
2010-07-19 23:44:49 +08:00
Łukasz Strzałkowski
010eda2eb5
Removed warnings about method redefining
2010-07-19 23:44:48 +08:00
Łukasz Strzałkowski
fc71d59219
Introduced redefine_method
2010-07-19 23:44:46 +08:00
Łukasz Strzałkowski
247886e1b4
Removed warnings when a variable is shadowed
2010-07-19 23:44:45 +08:00
José Valim
b22c11fa53
Add missing entries and tidy up CHANGELOG.
2010-07-19 15:14:26 +02:00
José Valim
70f7ba3e3b
There is absolutely no need to use __send__ here.
2010-07-19 14:56:09 +02:00
José Valim
ab6ff85906
No need to create a new module in the previous commit.
2010-07-19 14:50:38 +02:00
Neeraj Singh
33c5689e2d
Exceptions from views should be rescued based on the original exception. If a handler for original exception is missing then apply ActiveView::TemplateError
...
[#2034 state:resolved]
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-07-19 14:50:38 +02:00
Mislav Marohnić
bcec0f6528
correct typos in Routing examples
2010-07-19 14:01:32 +02:00
Aaron Patterson
ad8f4dfc50
avoid proc activation every time a log message is made
2010-07-18 17:37:39 -07:00
Aaron Patterson
8cbb89c0bf
subscriber does not need to be a block, but an object that responds to #call
2010-07-18 17:20:20 -07:00
Aaron Patterson
b2c8a5fd3e
Notifier API == Fanout API, so replace Notifier with Fanout as they quack the same
2010-07-18 16:49:29 -07:00
Aaron Patterson
234b969946
tap the subscriber for easier return value
2010-07-18 15:39:32 -07:00
Aaron Patterson
2cbef6996c
bind method is not needed, so goodbye! <3 <3 <3
2010-07-18 15:37:23 -07:00
Neeraj Singh
d1037a473b
replacing around with for in the comments for callbacks
2010-07-18 18:02:40 -04:00
Santiago Pastorino
3870366092
Float comparison adjustment
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-07-18 19:28:46 +02:00
Neeraj Singh
0fce4ae57f
expected value should come first in assert_equal
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-07-18 15:13:38 +02:00
Neeraj Singh
6caf943ace
primary_keys_test reads better than pk_test
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-07-18 15:13:29 +02:00
Neeraj Singh
b58e1c52f7
fixing typo
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-07-18 15:13:21 +02:00
Neeraj Singh
df6aa8e246
removing extra whitespaces
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-07-18 15:13:14 +02:00
José Valim
291adcd588
Set session options id to nil is respected and cancels lazy loading.
2010-07-18 12:51:03 +02:00
Ivan Torres
cdfa11409c
select :include_blank or :prompt should return escaped string [ #5099 state:resolved]
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-07-18 11:32:00 +02:00
Neeraj Singh
1f499e6d4c
fixing the ternary operation where the logic is very confusing.
...
[#5136 state:resolved]
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-07-18 11:31:54 +02:00
Subba Rao Pasupuleti
4a0d7c1a43
save on parent should not cascade to child unless child changed [ #3353 state:resolved]
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-07-18 11:31:29 +02:00
José Valim
e210895ba9
Avoid uneeded queries in session stores if sid is not given.
2010-07-18 11:02:08 +02:00
José Valim
fa98eca75b
Add console hook to force ActiveRecord::Base to be loaded when console starts avoiding reference loops.
2010-07-18 11:02:07 +02:00
Aaron Patterson
cfca55949f
convert duration to an attr_reader
2010-07-17 16:03:56 -07:00
Santiago Pastorino
cebe5c2fac
It's not needed to initialize the attr when calling mattr_writer
2010-07-18 06:06:58 +08:00
Nick Quaranto
7aec9f9c02
Removing ActionDispatch::Http::FilterParameters#fitered_parameters alias
2010-07-18 06:04:55 +08:00
Aaron Patterson
606d8fdfc8
drained? is never called
2010-07-17 14:45:59 -07:00
Aaron Patterson
fa73e777a1
private method is not needed
2010-07-17 14:44:29 -07:00
Aaron Patterson
4226c93779
removing Binding class
2010-07-17 14:35:44 -07:00
Aaron Patterson
9c80f5b391
use === to avoid regular expression creation, and speed up string comparison
2010-07-17 13:14:38 -07:00
Xavier Noria
631b9564d2
Merge remote branch 'docrails/master'
2010-07-17 20:00:48 +02:00
Xavier Noria
caddee253c
new guide: API Documentation Guidelines, ported and revised from the docrails github wiki
2010-07-17 19:42:44 +02:00
José Valim
c6e2058637
Add skip_eager_load!, skip_autoload! and friends to path objects.
2010-07-17 09:55:11 +02:00
Santiago Pastorino
38f1ea8fe2
Makes test use the new config.action_view.javascript_expansions[:defaults] initialization syntax
2010-07-17 05:53:18 +08:00
Aaron Patterson
42be67e8d4
unfactoring clear_stale_cached_connections!
2010-07-16 14:48:50 -07:00
Aaron Patterson
8d17f53318
adding a test for clearing stale connections
2010-07-16 14:39:40 -07:00
Aaron Patterson
7ba54ff711
fixing test file name
2010-07-16 13:54:14 -07:00
Aaron Patterson
2244bb0013
fixing whitespace errors
2010-07-16 13:50:58 -07:00
Xavier Noria
ef165b355d
minor pass to generated code in application.rb related to :defaults
2010-07-16 21:54:13 +02:00
Aaron Patterson
04ef434b21
only test for existence of +pool+ once
2010-07-16 11:44:29 -07:00
Aaron Patterson
b952470cc2
use an attr_reader for performance
2010-07-16 11:44:29 -07:00
Santiago Pastorino
79d9e0f155
Makes this test don't trust on the speed of execution
2010-07-17 02:39:26 +08:00
Santiago Pastorino
114fa4d431
Adds application.js when app is generated with -J and clear javascript_expansions[:defaults]
2010-07-17 01:59:51 +08:00
Nick Sieger
ea7f1fb026
Don't rely on implementation-specific order-dependence of array comparisons in unit tests
...
Signed-off-by: Santiago Pastorino <santiago@wyeworks.com >
2010-07-17 01:59:51 +08:00
Santiago Pastorino
041e47b326
Explain how to change javascript default files
2010-07-17 01:59:50 +08:00
Aaron Patterson
1b2824b659
fixing typeo. thanks bamnet!
2010-07-16 09:13:51 -07:00
Neeraj Singh
1f2a5199cb
moving persistence related tests to a new file
...
Before refactoring test result from AR:
2291 tests, 7180 assertions, 0 failures, 0 errors
After the refactoring test result from AR:
2291 tests, 7180 assertions, 0 failures, 0 errors
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-07-16 17:26:06 +02:00
Neeraj Singh
c9630d9d87
adding proper markup to comment
2010-07-16 09:58:01 -04:00
Pratik Naik
130bf3c9ed
Fix data loading from the performance script
2010-07-16 08:28:49 +01:00
David Genord II
1fcf4e8ecb
JoinDependency#graft does not properly set parent join [ #5124 state:resolved]
...
Signed-off-by: Pratik Naik <pratiknaik@gmail.com >
2010-07-16 08:28:49 +01:00
Xavier Noria
181e0d326d
AS guide: revised the docs of class_attribute and cattr_* macros
2010-07-16 00:48:08 +02:00
Santiago Pastorino
ea0bf4e664
CI should bundle update instead of install so gems are properly updated
2010-07-16 05:52:34 +08:00
Carlos Antonio da Silva
c09cd192aa
Small fix in cookie docs and trailing whitespaces
2010-07-15 18:41:29 -03:00
Łukasz Strzałkowski
06c74cf5fe
Bump bundler to 1.0.0.beta.5
...
[#5102 state:committed]
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2010-07-15 13:52:59 -07:00
Santiago Pastorino
fcb230144b
Bump up nokogiri, memcache-client, sqlite3-ruby, fcgi, mail and tzinfo
2010-07-15 13:18:47 -07:00
Santiago Pastorino
3952268929
Bump up to rack-mount 0.6.9 and rack-mount-0.6.6.pre removed from action_dispatch vendor
2010-07-15 13:18:44 -07:00
Jaime Iniesta
5543e8bd6b
Migrations guide: minor typos corrected
2010-07-15 17:42:41 +02:00
Pratik Naik
0c2c893434
Revert "Style fixes"
...
This reverts commit 3c300b3121 .
2010-07-15 13:17:35 +01:00
Xavier Noria
c7d79a4ce1
Merge remote branch 'docrails/master'
2010-07-15 10:19:31 +02:00
Xavier Noria
897f86a974
layouts and rendering guide: use content_for? instead of the yield or yield idiom
2010-07-15 09:47:22 +02:00
Aaron Patterson
62dd1d8d23
clean up ||= with an initialized variable and attr_reader
2010-07-14 17:53:20 -07:00
wycats
3c300b3121
Style fixes
2010-07-14 17:33:07 -07:00
Aaron Patterson
955b26ac6e
primary_key_name already checks for the model_class
2010-07-14 17:11:52 -07:00
Aaron Patterson
d41a28bcca
use array intersection for dry / faster code
2010-07-14 17:09:14 -07:00
Aaron Patterson
1db8ed0f4b
activerecord tests should inherit from ActiveRecord::TestCase
2010-07-14 16:35:52 -07:00
Aaron Patterson
6a534455f6
remove useless ternary in PostgreSQL adapter
2010-07-14 15:44:15 -07:00
Aaron Patterson
8ba14c238e
PostgreSQLAdapter#query string interpolation calls to_s for us
2010-07-14 15:18:48 -07:00
Aaron Patterson
51c9b666e6
PostgreSQLAdapter#query bail early if there is no column and dry up our conditionals
2010-07-14 15:10:45 -07:00
Aaron Patterson
36150c902b
Let's initialize instance variables in the postgres adapter.
2010-07-14 15:04:14 -07:00
Pratik Naik
d5921cdb7a
Remove unintentional API changes. [ #1108 ]
2010-07-14 18:32:28 +01:00
Pratik Naik
4a06489525
Style fixes
2010-07-14 16:50:26 +01:00
Xavier Noria
b7944e1b21
revises the rdoc of update_attributes and update_attributes! to document they are wrapped in a transaction, and adds code comments explaining why
2010-07-14 17:42:57 +02:00
Xavier Noria
5994567839
AR queying guide: let limit and offset be different numbers to help making clear what is what in the explanation, rewords also a bit
2010-07-14 13:18:07 +02:00
Andrew Kaspick
684fb5e7d5
upgrade prototype to be compatible with rails.js [ #5109 state:committed]
...
Signed-off-by: Xavier Noria <fxn@hashref.com >
2010-07-14 12:47:27 +02:00
Michael Hutchinson
438bff6ccd
Active Record Query Interface Guide: Corrected the explanation for the OFFSET example.
2010-07-14 03:36:55 -07:00
Michael Hutchinson
6de6fa8010
Active Record Query Interface Guide: Fixed a few typos and made minor changes to improve readability.
2010-07-14 02:30:12 -07:00
Michael Hutchinson
981258cf5e
Active Record Query Interface Guide: Fixed minor typos.
2010-07-14 01:39:00 -07:00
Jacob Lewallen
d10ecfefb8
Set destroyed=true in opt locking's destroy [ #5058 state:resolved]
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-07-14 08:02:17 +02:00
wycats
16bae77c56
Revert "Improve performance of MessageVerifier while keeping it constant time"
...
This reverts commit 8b05c5207d .
2010-07-13 16:13:54 -07:00
Xavier Noria
00f49c74e8
AS guides: reword the docs of Enumerable#group_by
2010-07-13 23:36:29 +02:00
Neeraj Singh
edb5401039
count method should not take options if it is operated on has_many association which has finder_sql or counter_sql
...
[#2395 state:resolved]
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-07-13 22:03:35 +02:00
Neeraj Singh
f4fbc2c1f9
update_attributes and update_attributes! are now wrapped in a transaction
...
[#922 state:resovled]
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-07-13 22:02:00 +02:00
Aaron Patterson
e35e6171bb
reducing range comparisons when converting types to sql
2010-07-13 11:56:00 -07:00
Aaron Patterson
35e304193b
only loop through all rows and columns once in the postgres adapter
2010-07-13 10:57:22 -07:00
Aaron Patterson
bc35631dc7
use constants instead of magic numbers. meow
2010-07-13 10:57:22 -07:00
Santiago Pastorino
2b22d1240b
Makes CI builder install --pre version of Bundler, now that bundle install works again
2010-07-13 10:35:04 -07:00
Xavier Noria
6d2e4ee96c
Merge remote branch 'docrails/master'
2010-07-13 18:41:09 +02:00
Benjamin Quorning
7e075e6247
Fixed many references to the old config/environment.rb and Rails::Initializer
2010-07-13 13:00:21 +02:00
Vitalii Khustochka
b75fca9e57
Added reorder delegation for ActiveRecord::Base(to be able to overwrite the default_scope ordering in the named scope [ #5093 state:resolved]
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-07-13 08:31:55 +02:00
Miles Egan
d2fae5f78e
remove size attribute from tag generated by file_field helper [ #5084 state:resolved]
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-07-13 08:30:08 +02:00
Will St. Clair + Neeraj Singh
b520d602ff
string IDs are now quoted correctly [ #5064 state:resolved]
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-07-13 08:14:52 +02:00
Subba Rao Pasupuleti
44e7fba59e
renaming test name to fix accidently override
...
[#5076 state:resolved]
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-07-13 08:09:57 +02:00
Mislav Marohnić
571cb1ddc6
enable AS::JSON.encode to encode AR::Relation by providing as_json method
...
[#5073 state:resolved]
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-07-13 08:09:28 +02:00
José Valim
3401311562
Tidying up a bit, so update_attribute is not called twice on touch.
2010-07-13 08:05:09 +02:00
Neeraj Singh
1d45ea0814
with this fix touch method - does not call validations - doest not call callbacks - updates updated_at/on along with attribute if attribute is provided - marks udpated_at/on and attribute as NOT changed
...
[#2520 state:resolved]
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-07-13 07:03:42 +02:00
Aaron Patterson
2aed63eb52
our method is modifying the original array, so refactor to use destructive methods
2010-07-12 17:58:48 -07:00
Aaron Patterson
2c3aab32dd
PostgreSQLAdapter#select_raw removing dead code
2010-07-12 17:52:53 -07:00
Aaron Patterson
79e9f4a318
PostgreSQLAdapter#select_raw use each_with_index to avoid multiple array lookups
2010-07-12 17:49:12 -07:00
Aaron Patterson
8521cdf03d
PostgreSQLAdapter#select_raw fields and results are empty even if ntuples is 0
2010-07-12 17:44:15 -07:00
Aaron Patterson
c9710a43ff
refactor PostgreSQLAdapter#result_as_array to create fewer Range objects
2010-07-12 17:00:29 -07:00
Aaron Patterson
7c4e0401d2
cleaning up PostgreSQLAdapter#select
2010-07-12 16:54:00 -07:00
Aaron Patterson
cee2ff2768
these strings do not need to be frozen
2010-07-12 16:43:20 -07:00
Aaron Patterson
8fb838ed16
use Hash#each to avoid a second hash lookup
2010-07-12 16:32:45 -07:00
José Valim
6b29dc876f
Just add connection management middleware if running in a concurrent environment.
2010-07-12 20:18:54 +02:00
José Valim
da84c9d0d2
Remove old rubygems require.
2010-07-12 20:18:04 +02:00
Santiago Pastorino
d030f830cf
Fixes a regression caused by having mapping options controller and action as blank
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-07-12 19:47:28 +02:00
Jaime Iniesta
4209cb97e3
Merge branch 'master' of github.com:lifo/docrails
2010-07-12 18:24:56 +02:00
Jaime Iniesta
cf69a01079
Getting started guide: typos and changelog
2010-07-12 18:23:13 +02:00
José Valim
3d7e411953
Routes should respect namespace even if action is a regexp and just controller is given to to.
2010-07-12 15:11:53 +02:00
Steven Hancock
1a35b6215f
Removed deprecated |map| block argument from routing docs since it is no longer generated in edge Rails config/routes.rb
...
Didn't touch plugins guide since I'm not too clear on how routes work in plugins.
2010-07-11 23:57:26 -07:00
Santiago Pastorino
725090942f
We shouldn't rely on float comparison, delta added just in case float representation of this values aren't equal
2010-07-12 09:59:52 +08:00
Santiago Pastorino
913aeaef81
We need to wait for the final release of bundler for this to make sense
2010-07-11 18:04:00 -03:00
Jaime Iniesta
1dddc79fee
Getting started guide: Post validation example is clearer if we do p=Post.new;p.save better than p=Post.create;p.save
2010-07-11 21:47:31 +02:00
Jaime Iniesta
b0fab0c5c4
Getting started guide: rephrase the paragraph about the root route for better understanding
2010-07-11 19:17:36 +02:00
Santiago Pastorino
060ca6abce
Add missing require to use Set
2010-07-11 02:55:47 -03:00
Santiago Pastorino
16c14f7465
Avoid interpreted as grouped expression warnings
2010-07-11 02:55:38 -03:00
Aaron Patterson
f33ee69d59
reducing funcalls, cleaning up primary key methods for sqlite adapter
2010-07-10 13:30:49 -07:00
Aaron Patterson
0bac4c7e02
primary key behavioral tests
2010-07-10 13:29:12 -07:00
Aaron Patterson
51783c0298
behavioral tests for sqlite adapter
2010-07-10 13:21:56 -07:00
Jeremy Kemper
80e47d7b88
Revert "Revert "Bump bundler to 1.0.0.beta.3""
...
It's out for reals!
This reverts commit 951dbf06b4 .
2010-07-09 20:55:59 -07:00
Aaron Patterson
1e1af8f612
adding more behavioral tests for the sqlite adapter
2010-07-09 17:12:29 -07:00
Xavier Noria
c81e476d6d
missing article, only seen in github's colored diff by the beard of the prophet
2010-07-10 00:56:17 +02:00
Xavier Noria
86d5c728fb
revises recent commit related to :uniq => true
2010-07-10 00:50:59 +02:00
Neeraj Singh
44b752bea1
expanding on :uniq option in has_many
2010-07-09 16:39:34 -04:00
Xavier Noria
2f04c87855
Merge remote branch 'docrails/master'
2010-07-09 22:08:24 +02:00
Xavier Noria
c9ae2c11eb
application.rb: revises the comment for autoload_paths so that is assumes less from the user, and unifies punctuation
2010-07-09 19:09:47 +02:00
Jaime Iniesta
c6f4c5916e
Minor typos: 'built-in' instead of 'built in', 'built into' instead of 'built in to'
2010-07-09 17:53:47 +02:00
Norman Clarke
d7ffa3c077
Describe recent changes in Multibyte::Chars.
2010-07-08 19:24:44 -03:00
José Valim
d9ebc76d70
Refactor previous commits a bit.
2010-07-08 23:45:10 +02:00
David Trasbo
786342e17f
Return from ActiveRecord::Base#attributes= unless value is a hash [ #4070 state:committed]
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-07-08 23:24:20 +02:00
Neeraj Singh
1e53404fe9
reset_counter should work with non-traditional belongs_to and polymorphic belongs_to
...
[#4984 state:resolved]
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-07-08 23:24:12 +02:00
José Valim
87f64ef05e
Improve a bit the code in latest commits.
2010-07-08 22:59:41 +02:00
Norman Clarke
6f83a57ac7
Improve bang method defs, make slice! operate in-place. [ #5028 state:resolved]
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-07-08 22:59:24 +02:00
Neeraj Singh
01629d1804
This patch changes update_attribute implementatino so:
...
- it will only save the attribute it has been asked to save and not all dirty attributes
- it does not invoke callbacks
- it does change updated_at/on
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-07-08 22:43:18 +02:00
Neeraj Singh
690352dce4
consolidating updated_at and updated_on
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-07-08 22:41:58 +02:00
Grant Ammons
17650e394f
Eager loading :through associations will join the :source model if there are :conditions. [ #2362 state:resolved]
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-07-08 22:36:26 +02:00
Sudara
e848ab527c
Allow a PID file to be specified to rails server [ #5031 state:resolved]
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-07-08 22:35:02 +02:00
Ken Collins
0e9bc23c0e
Fix the #using_limitable_reflections? helper to work correctly by not examining the length of an array which contains false/true, hence always passing. [ #4869 state:resolved]
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-07-08 22:34:34 +02:00
Thiago Pradi
8b2330ebc3
Tests to specify the behaviour of ActiveRecord::Migrator.get_all_versions() [ #5066 state:resolved]
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-07-08 22:29:08 +02:00
Łukasz Strzałkowski
4a26a292a0
Removing method before redefining it. It was causing warnings. [ #5072 state:resolved]
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-07-08 22:29:08 +02:00
Josh Kalderimis
b09fd9ccbb
removed an old unused method in AR which removed readonly attributes
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-07-08 22:29:08 +02:00
Neeraj Singh
a4f5f0547f
removing unused method
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-07-08 22:29:08 +02:00
Aaron Patterson
7b0f8534c7
moving parse_sqlite_config to the sqlite3_connection method (where it belongs) [ #5071 state:resolved]
...
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2010-07-08 11:52:38 -07:00
Aaron Patterson
9ac9c35117
removing useless code. [ #5070 state:resolved]
...
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2010-07-08 11:45:42 -07:00
Mislav Marohnić
00f1cd71a9
fix ActiveRecord destroy_all so it returns destroyed records
...
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2010-07-08 11:35:17 -07:00
Jeremy Kemper
951dbf06b4
Revert "Bump bundler to 1.0.0.beta.3"
...
(It's not out yet)
This reverts commit 64cee90c0f .
2010-07-08 10:59:05 -07:00
Jeremy Kemper
64cee90c0f
Bump bundler to 1.0.0.beta.3
2010-07-08 10:53:06 -07:00
José Valim
c285f07a92
Change documentation for ActiveModel::MassAssignmentSecurity a bit and make debug always be called since some people may overwrite warn! to add extra behavior even if logger is not available.
2010-07-08 19:02:34 +02:00
Josh Kalderimis
4b66aab00f
mass_assignment_security moved from AR to AMo, and minor test cleanup
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-07-08 18:28:45 +02:00
Josh Kalderimis
7c86e8e21b
minor changes to mass assignment security patch to bring it in line with rails standards
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-07-08 18:28:38 +02:00
Eric Chapweske
606088df3f
Mass assignment security refactoring
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-07-08 18:28:32 +02:00
Neeraj Singh
723a0bbe3a
This test never runs and it has never run. Since the day this file
...
was created this test has name not beginning with test_. Also this
test is trying to use has_many on another has_many which is not
supported.
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-07-08 18:02:07 +02:00
Xavier Noria
a9587935de
copy-edits some docs
2010-07-08 16:53:37 +02:00
Neeraj Singh
4a1207d540
Merge branch 'master' of github.com:lifo/docrails
2010-07-08 10:09:39 -04:00
Neeraj Singh
f6fa6cf611
clarifying how to create non standard primary key
2010-07-08 10:09:20 -04:00
Rohit Arondekar
dc364fdc59
API Docs: Fixes to the Routing docs
2010-07-07 22:15:15 -07:00
Akira Matsuda
bf5d154567
Print proper "Usage:" messages for "rails plugin" command
...
* suppress outputting "Unknown command:" when no command were specified
* output the "Usage:" message when no plugin names were given
[#5043 state:committed]
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2010-07-07 16:20:56 -07:00
Akira Matsuda
ff44cc2844
whitespace
...
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2010-07-07 16:20:51 -07:00
Ben Somers
de51cbccf8
Fixed gruoped_by_title spelling [ #5063 state:committed]
...
Signed-off-by: Xavier Noria <fxn@hashref.com >
2010-07-08 00:26:25 +02:00
Aaron Patterson
c58e7a71b5
adding some behavioral tests for the sqlite adapter. [ #5065 state:resolved]
...
Signed-off-by: wycats <wycats@gmail.com >
2010-07-07 14:25:22 -07:00
Jeremy Kemper
81f398b804
Fix setting helpers_path to a string or pathname
2010-07-07 12:03:08 -07:00
Xavier Noria
64c75d6618
Merge remote branch 'docrails/master'
2010-07-07 12:58:46 +02:00
José Valim
8735d15e61
Add a test to ensure url helpers are not action methods in ActionMailer.
2010-07-07 12:50:38 +02:00
Andrew White
0f96cea322
Add note about incompatibility of namespace and :controller
2010-07-07 05:32:26 +01:00
Andrew White
b802a0d4c7
When a dynamic :controller segment is present in the path add a Regexp constraint that allow matching on multiple path segments.
...
Using a namespace block isn't compatible with dynamic routes so we
raise an ArgumentError if we detect a :module present in the scope.
[#5052 state:resolved]
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-07-07 00:11:13 +02:00
Andrew White
f4be0041c6
Refactor handling of :only and :except options. The rules are:
...
1. Don't inherit when specified as an option on a resource
2. Don't push into scope when specified as an option on a resource
2. Resources pull in :only or :except options from scope
3. Either :only or :except in nested scope overwrites parent scope
[#5048 state:resolved]
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-07-06 20:46:20 +02:00
Xavier Noria
92ff71bb14
documents automatic management of join models in hmt associations, in particular the gotcha that deletion is direct
2010-07-06 17:29:34 +02:00
Neeraj Singh
ffdbe56d99
Merge branch 'master' of github.com:lifo/docrails
2010-07-06 10:10:05 -04:00
Neeraj Singh
c1fc59c7ac
added more info about << operation in associations
2010-07-06 10:09:54 -04:00
l4u
e5c95b1871
Fixed minor typo app/view to app/views
2010-07-06 21:15:14 +08:00
Mark Hayes
db0530e4ba
Fixed typo in Rails::Generators::Base [ #5051 state:resolved]
2010-07-06 14:52:20 +05:30
José Valim
8079484b11
Recognize should also work with route is wrapped in a constraint.
2010-07-06 00:39:13 +02:00
José Valim
6671d9cdc1
RouteSet should also handle anonymous classes.
2010-07-05 21:44:49 +02:00
José Valim
a5dda97602
Define a convention for descendants and subclasses.
...
The former should be symmetric with ancestors and include all children. However, it should not include self since ancestors + descendants should not have duplicated. The latter is symmetric to superclass in the sense it only includes direct children.
By adopting a convention, we expect to have less conflict with other frameworks, as Datamapper. For this moment, to ensure ActiveModel::Validations can be used with Datamapper, we should always call ActiveSupport::DescendantsTracker.descendants(self) internally instead of self.descendants avoiding conflicts.
2010-07-05 13:01:27 +02:00
Santiago Pastorino
5bf3294c8b
Move Date#xmlschema to conversions and add a missing require
2010-07-04 14:10:28 -07:00
Santiago Pastorino
8a09ea6d6d
Avoids deprecation warning running tests
2010-07-04 13:52:48 -07:00
Patrik Stenmark
7f7480f6fc
Adds tests for content negotiation change introduced in dc5300adb6
...
Signed-off-by: wycats <wycats@gmail.com >
2010-07-04 11:17:16 -07:00
Madjo DIAPENA
3cb5375832
ARGV.empty? is useless. If ARGV is empty, ARGV.first != "new" will always be true
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-07-04 18:49:28 +02:00
Andrew White
aa31a255c8
Fix syntax of routing tests so they actually run
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-07-04 18:49:26 +02:00
Andrew White
c6843e2337
Refactor resource options and scoping. Resource classes are now only responsible for controlling how they are named. All other options passed to resources are pushed out to the scope.
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-07-04 13:20:48 +02:00
Andrew White
7d04a4be6b
Reword routing guide so that we talk about prefixing as a use of :as rather than as a specific prefixing option (which :name_prefix used to be).
2010-07-04 08:05:58 +01:00
Jeff Dean
a7988fcf41
Added release notes for 3 changes to helpers
2010-07-04 00:35:34 -04:00
Wincent Colaiuta
75b32a69a1
Fixes for "router" and "routes" terminology
...
Commit f7ba614c2d improved the internal consistency of the different
means of accessing routes, but it introduced some problems at the level
of code comments and user-visible strings.
This commit applies fixes on three levels:
Firstly, we remove or replace grammatically invalid constructs such as
"a routes" or "a particular routes".
Secondly, we make sure that we always use "the router DSL" or "the
router syntax", because this has always been the official terminology.
Finally, we make sure that we only use "routes" when referring to the
application-specific set of routes that are defined in the
"config/routes.rb" file, we use "router" when referring on a more
abstract level to "the code in Rails used to handle routing", and we use
"routing" when we need an adjective to apply to nouns such as
"url_helpers. Again this is consistent with historical practice and
other places in the documentation.
Note that this is not a sweep over the entire codebase to ensure
consistent usage of language; it is just a revision of the changes
introduced in commit f7ba614c2d .
Signed-off-by: Wincent Colaiuta <win@wincent.com >
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-07-03 22:42:31 +02:00
Jeremy Kemper
070c24232f
Merge remote branch 'spastorino/master'
2010-07-03 12:46:38 -07:00
Santiago Pastorino
075f8b7241
Add a missing require to allow the usage of Array#to_xml
2010-07-03 09:59:51 -03:00
Andrew White
547199ee4a
Updated routing guide to reflect the fact that :name_prefix is now :as
2010-07-03 09:18:02 +01:00
Andrew White
54250a5bfe
Refactor recall parameter normalization [ #5021 state:resolved]
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-07-03 10:06:07 +02:00
Andrew White
52e526a8e3
:singular is no longer a valid option for resources [ #5037 state:resolved]
2010-07-03 09:01:01 +01:00
Santiago Pastorino
f6d7a4d251
Removes the dependency that AMo has on tzinfo
...
[#4979 state:committed]
2010-07-03 02:26:18 -03:00
Santiago Pastorino
201f373e7a
Refactor move some date, time and date_time methods to */zones and fixed some requires
2010-07-03 02:13:44 -03:00
Santiago Pastorino
8cc746331c
Time#formatted_offset is defined in core_ext/time/conversions
...
[#4979 ]
2010-07-02 20:22:35 -07:00
Uģis Ozols
5360014a5d
Changed passed argument to :validate => false in validation skipping section.
2010-07-03 03:16:04 +03:00
Geoff Buesing
227e1caea5
Time#as_json: use Time#formatted_offset instead of strftime %z directive, which is non-standard and inaccurate on some platforms (e.g., Mac OS X).
...
[#4979 ]
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2010-07-02 11:50:16 -07:00
Jeremy Kemper
aeaa4687ea
Fix indent
2010-07-02 11:32:18 -07:00
José Valim
9e6e648732
Fix routes with :controller segment when namespaced [ #5034 state:resolved]
2010-07-02 19:13:00 +02:00
José Valim
0189fb76e3
reload_routes! was still referencing old Rails::Application.
2010-07-02 08:13:52 +02:00
Neeraj Singh
d10aaefcfd
clarifying the comments regarding base_class declaration
2010-07-01 23:06:58 -04:00
Santiago Pastorino
2ef8a2b403
bump erubis version to 2.6.6 and thor version to 0.13.7
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-07-02 01:51:03 +02:00
Santiago Pastorino
cb321546b7
Time has it own implementation of xmlschema, now AMo doesn't depend on TZInfo
...
[#4979 state:committed]
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-07-02 01:51:03 +02:00
Piotr Sarnacki
f7ba614c2d
Unify routes naming by renaming router to routes
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-07-02 01:51:03 +02:00
Aaron Patterson
f8720a04d1
porting session.clear fix to master branch. [ #5030 state:resolved]
...
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2010-07-01 15:17:19 -07:00
Santiago Pastorino
4a0c514eb4
AS json refactor, move to_json implementation to core_ext and a cleanup a bit the code
2010-07-01 12:04:11 -07:00
Rizwan Reza
a6913bf7eb
Added documentation for usage of associative resources with form_for
2010-07-01 23:07:24 +04:30
Jeremy Kemper
d7c1057652
Bump bundler dependency to 1.0.0.beta.2 or later
2010-07-01 10:44:53 -07:00
José Valim
53b34e8476
Avoid calls to Rails::Application since this is not the official API.
...
Your application should *always* reference your application const (as Blog::Application) and Rails.application should be used just internally.
2010-07-01 18:43:44 +02:00
Jaime Iniesta
d167cfd62b
Fixes README for generated apps with Rails 3 (rails *new* myapp, and Welcome aboard text)
2010-07-01 17:34:35 +05:30
Cyril Mougel
9024545a6b
fix failure if behavior is not define and try use the default
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-07-01 12:17:21 +02:00
José Valim
e596a8e14c
Add the possibility to have several behaviors in AS::Deprecation.
2010-07-01 10:26:45 +02:00
James Le Cuirot
f3fedd7f84
Don't remove scheduled destroys when loading an association. [ #4642 state:resolved]
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-07-01 01:06:58 +02:00
José Valim
57d750edf7
Make relation a private method.
2010-07-01 00:09:55 +02:00
Xavier Noria
c63cf7bf0d
Merge remote branch 'rails/master'
2010-06-30 20:47:26 +02:00
Jeremy Kemper
b07e6fdaa0
Support any mysql-like adapter
2010-06-30 10:38:49 -07:00
Wincent Colaiuta
52c56f9f7e
docs: note that mail() accepts arbitrary headers
...
The documentation makes it sound like mail() only accepts a limited
set of headers in the headers hash, but it in fact accepts any
arbitrary headers, and there is a test ("can pass random headers in
as a hash to mail") for it in the test suite.
Signed-off-by: Wincent Colaiuta <win@wincent.com >
2010-06-30 17:07:19 +02:00
bodhi
2eaae1f50b
add note of which configuration option to set in deprecation warning message [ #5012 state:resolved]
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-06-30 16:58:05 +02:00
José Valim
9ab8cfc21a
Improve the idiom used in multibyte chars a bit.
2010-06-30 15:01:23 +02:00
Alex Muntean
265b7c5edf
Fix ActiveSupport::Multibyte::Chars#slice for empty strings when starting offset is negative [ #4717 state:resolved]
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-06-30 15:00:55 +02:00
Norman Clarke
4dbb6e3ff0
Update Unicode database to 5.2.0. [ #5011 state:resolved]
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-06-30 13:22:35 +02:00
James MacAulay
16cef77d37
Fix AS::MB::Chars#+ to not alter self [ #4646 state:resolved]
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-06-30 13:22:28 +02:00
José Valim
13a3690271
Add missing CHANGELOG items.
2010-06-30 12:38:25 +02:00
José Valim
06681af518
A couple enhancements to the router:
...
* Allow to use the get :symbol shortcut outside resources scopes as well;
* Fix a bug where :action was not being picked from given options;
* Giving :as option inside a resource now changes just the relative name instead of the full name;
2010-06-30 12:34:15 +02:00
José Valim
ccbb3bb3d8
Clean up the logic to specify the name and path for action a bit.
2010-06-30 11:33:15 +02:00
Santiago Pastorino
7bd00fcb7f
We are trying to test that & escapes here not that & is being escaped, also added a cosmetic change to test_link_tag_with_query_and_no_name
...
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2010-06-29 18:01:32 -07:00
Gonçalo Silva
68bd46ffb9
performance tests now working accurately on 1.9, using Ruby with the GCdata patch
2010-06-29 17:12:37 -07:00
Aaron Patterson
3f563f1696
AssociationCollection#create_by_*, find_or_create_by_* work properly now. [ #1108 state:resolved]
...
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2010-06-29 16:13:40 -07:00
Tekin
d7c2e52c6c
migrations.rb requires active_support/core_ext/module/aliasing [ #5008 state:committed]
...
Signed-off-by: Xavier Noria <fxn@hashref.com >
2010-06-30 00:53:23 +02:00
Xavier Noria
ec3bfa2ead
s/escape_once/html_escape/, since html safety is the contract that now says whether something has to be escaped
2010-06-30 00:32:26 +02:00
Xavier Noria
cba1460a2f
url_for no longer escapes HTML, the :escape option is also gone
...
Rationale: url_for is just a path/URL generator, it is the responsability of the caller to escape conveniently HTML needs it, JavaScript needs different escaping, a text mail needs no escaping at all, etc.
2010-06-30 00:23:13 +02:00
José Valim
0253bf425e
Change :notification to :notify (ht: m4n)
2010-06-29 14:07:54 -07:00
wycats
c1beeb4068
Add CHANGELOG for new deprecation style
2010-06-29 12:25:13 -07:00
wycats
b1cc63c10d
_snowman CHANGELOG (dobry pies)
2010-06-29 12:23:11 -07:00
wycats
d4c7d3fd94
Create a deprecation behavior that triggers a notification for deprecation notices, and make the behaviors independent of the environment names.
...
* In Rails 2.3 apps being upgraded, you will need to add the deprecation
configuration to each of your environments. Failing to do so will
result in the same behavior as Rails 2.3, but with an outputted warning
to provide information on how to set up the setting.
* New Rails 3 applications generate the setting
* The notification style will send deprecation notices using
ActiveSupport::Notifications. Third-party tools can listen in to
these notifications to provide a streamlined view of the
deprecation notices occurring in your app.
* The payload in the notification is the deprecation warning itself
as well as the callstack from the point that triggered the
notification.
2010-06-29 12:20:15 -07:00
J. Pablo Fernández
21957b72ea
Test that adding an index also doesn't raise an exception.
...
[#4809 state:resolved]
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-06-29 21:17:12 +02:00
Paul Barry
0baf83fa18
Replaced statement in comment with an assertion
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-06-29 21:17:08 +02:00
J. Pablo Fernández
ff22b9d451
Fixed error when removing an index from a table name values, which is a reserved word, with test.
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-06-29 21:17:07 +02:00
José Valim
af6ec607fa
No need to check if the attribute exists (this is the same behavior as in 2.3) [ #4994 state:resolved] and [ #5003 state:resolved]
2010-06-29 20:15:32 +02:00
José Valim
67582f08bf
Push a failing test for issues [ #4994 ] and [ #5003 ].
2010-06-29 19:50:09 +02:00
Jeremy Kemper
7ea85ff516
Revert "Revert "Name compiled render methods". This caused several failures on AP test suite for 1.9.2."
...
This reverts commit 9013227e00 .
minitest was 'running' compiled templates beginning with test!
2010-06-29 09:22:53 -07:00
José Valim
caab176116
Rename _snowman_ to _snowman to be in sync with _method and _csrf_token.
2010-06-29 18:02:39 +02:00
Neeraj Singh
dabf74b495
array subtraction should be faster than iterating over all the elements
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-06-29 17:57:06 +02:00
Neeraj Singh
e8f88a3298
splitting a really long line into multiple lines which is easy on eyes
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-06-29 17:57:01 +02:00
David Trasbo
735a4db685
Remove ActiveRecord::Base#class_name [ #379 state:committed]
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-06-29 17:54:51 +02:00
José Valim
417125e795
Tidy up deprecation message for with_exclusive_scope.
2010-06-29 17:42:20 +02:00
José Valim
bd1666ad1d
Add scoping and unscoped as the syntax to replace the old with_scope and with_exclusive_scope. A few examples:
...
* with_scope now should be scoping:
Before:
Comment.with_scope(:find => { :conditions => { :post_id => 1 } }) do
Comment.first #=> SELECT * FROM comments WHERE post_id = 1
end
After:
Comment.where(:post_id => 1).scoping do
Comment.first #=> SELECT * FROM comments WHERE post_id = 1
end
* with_exclusive_scope now should be unscoped:
class Post < ActiveRecord::Base
default_scope :published => true
end
Post.all #=> SELECT * FROM posts WHERE published = true
Before:
Post.with_exclusive_scope do
Post.all #=> SELECT * FROM posts
end
After:
Post.unscoped do
Post.all #=> SELECT * FROM posts
end
Notice you can also use unscoped without a block and it will return an anonymous scope with default_scope values:
Post.unscoped.all #=> SELECT * FROM posts
2010-06-29 17:18:55 +02:00
José Valim
9013227e00
Revert "Name compiled render methods". This caused several failures on AP test suite for 1.9.2.
...
This reverts commit 2c4f8aae5c .
2010-06-29 10:54:07 +02:00
Adam Meehan
8fbb5177a7
accepts_nested_attributes_for typo
2010-06-29 13:32:53 +10:00
Santiago Pastorino
093c4eedd0
Remove unneeded reject
2010-06-28 19:14:40 -07:00
Neeraj Singh
40e87ac669
with_exclusive_scope does not work properly if ARel is passed. It does work nicely if hash is passed. Blow up if user is attempting it pass ARel to with_exclusive_scope.
...
[#3838 state:resolved]
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-06-29 01:18:20 +02:00
Jeremy Kemper
f8011e67b0
Use caller for helpers_dir deprecation warnings
2010-06-28 14:48:44 -07:00
Jeremy Kemper
b3318bd937
Slice new buffer from beginning of old buffer to skip encoding special case
2010-06-28 14:46:23 -07:00
Jeremy Kemper
2c4f8aae5c
Name compiled render methods
2010-06-28 14:46:23 -07:00
Jeremy Kemper
198ec03f52
returning -> tap
2010-06-28 14:46:23 -07:00
Jeremy Kemper
ec18719b81
ETag: use body instead of @body since the method will always return a string
2010-06-28 14:46:22 -07:00
Santiago Pastorino
b2633f9f93
Don't store incorrect values in zones_map
...
[#4942 state:committed]
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-06-28 19:35:33 +02:00
Leigh Caplan
97a92a4cfd
test that unknown zones don't store mapping keys
...
[#4942 ]
Signed-off-by: Santiago Pastorino <santiago@wyeworks.com >
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-06-28 19:35:27 +02:00
Thiago Pradi
0175c470c0
Documentation for Array#sample
2010-06-28 13:31:57 -03:00
José Valim
b5b42af33f
Make the sentinel flag for route a bit more robust.
2010-06-28 17:09:09 +02:00
José Valim
6dfa8d8e95
Tidy up valid conditions in router a bit.
2010-06-28 16:57:14 +02:00
Andrew White
02a1a4edc8
Add :controller and :action to the list of valid conditions
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-06-28 16:51:39 +02:00
José Valim
e4f9132f6a
Do not trigger the old mapper to avoid deprecation messages.
2010-06-28 15:36:52 +02:00
Andrew White
0b6ce34223
Restores the escaping of urls generated from hashes. [ #4765 state:resolved]
...
HTML specifications recommend the escaping of urls in web pages,
which url_for does by default for string urls and consquently
urls generated by path helpers as these return strings.
Hashes passed to url_for are not escaped by default and this
commit reverses this default so that they are escaped.
Undoes the changes of this commit:
1b3195b63c
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-06-28 15:35:38 +02:00
Andrew White
e717631a84
Merge :constraints from scope into resource options [ #2694 state:resolved]
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-06-28 14:22:35 +02:00
rohit
ccb21f20d8
Convert instance_variables to symbols before excluding internal vars [ #4965 state:resolved]
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-06-28 13:27:06 +02:00
Andrew White
19ccd4628c
Remove invalid conditions from route [ #4989 state:resolved]
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-06-28 12:25:19 +02:00
José Valim
6d04fa6dc4
Deprecate the old router DSL. Since it is still used intensively across ActionPack test suite, patches that translates Rails internal tests to the new router DSL are welcome (note though that a few tests shouldn't be translated since they are testing exactly the old mapper API, like the ones in actionpack/test/controller/resource_test.rb and actionpack/test/controller/routing_test.rb)
2010-06-28 12:23:41 +02:00
Bruno Michel
2002e5877e
Strip_tags never ending attribute should not raise a TypeError [ #4870 state:resolved]
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-06-28 11:40:27 +02:00
José Valim
dd8b7417a9
Update CHANGELOGs.
2010-06-28 11:37:14 +02:00
Łukasz Strzałkowski
be994e2c50
Information about new rake task in CHANGELOG
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-06-28 11:27:15 +02:00
Paco Guzman
e7cc94a455
Revert commit 37c44c8e70 Need more research on disable-with and data-attributes
2010-06-28 10:50:56 +02:00
Paco Guzman
37c44c8e70
Added disable_with option description to button_to helper
2010-06-28 09:47:54 +02:00
wycats
6fe424aeca
Small typo
2010-06-27 21:50:33 -07:00
Santiago Pastorino
ab96c71a52
Add this rule to run common tests and specifics ones from adapters dir
2010-06-27 21:20:53 -07:00
Akira Matsuda
4f74d449ee
Avoid "no such table" exception when schema migrations table does not exist
...
[#4990 state:resolved]
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2010-06-27 21:16:34 -07:00
Akira Matsuda
0e5d7c6f64
Use ActiveRecord::Migrator.schema_migrations_table_name instead of hardcoding "schema_migrations"
...
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2010-06-27 21:16:09 -07:00
wycats
25215d7285
Fix several known web encoding issues:
...
* Specify accept-charset on all forms. All recent browsers,
as well as IE5+, will use the encoding specified for form
parameters
* Unfortunately, IE5+ will not look at accept-charset unless
at least one character in the form's values is not in the
page's charset. Since the user can override the default
charset (which Rails sets to UTF-8), we provide a hidden
input containing a unicode character, forcing IE to look
at the accept-charset.
* Now that the vast majority of web input is UTF-8, we set
the inbound parameters to UTF-8. This will eliminate many
cases of incompatible encodings between ASCII-8BIT and
UTF-8.
* You can safely ignore params[:_snowman_]
TODO:
* Validate inbound text to confirm it is UTF-8
* Combine the whole_form implementations in form_helper_test
and form_tag_helper_test
2010-06-27 21:13:55 -07:00
Santiago Pastorino
06b0d6e5cd
Add missing require, Base use deprecate method
2010-06-27 20:45:09 -07:00
Kevin Skoglund
8e3e117dbe
rake db:migrate:status displays status of migrations [ #4947 state:resolved]
...
Signed-off-by: Michael Koziarski <michael@koziarski.com >
2010-06-28 14:08:40 +12:00
Jeremy Kemper
fb7715b249
Warn that ActiveRecord::Base.reset_subclasses is gone in Rails 3 final.
2010-06-27 18:58:18 -07:00
Jeremy Kemper
f3bb185b03
Upgrade to Rack 1.2.1
2010-06-27 17:55:23 -07:00
Santiago Pastorino
6cc29ab65f
Implemented getbyte as an aliased method and RDoc added
...
Signed-off-by: Xavier Noria <fxn@hashref.com >
2010-06-28 01:45:57 +02:00
Jeremy Kemper
f61d923d28
Update to latest rails.js
...
[#4411 state:resolved]
2010-06-27 16:42:30 -07:00
Jeremy Kemper
6549291901
Vendor unreleased rack-mount 0.6.6.pre dependency
2010-06-27 16:28:04 -07:00
Jeremy Kemper
d15256af6c
Missing BigDecimal dependency
2010-06-27 16:28:04 -07:00
Santiago Pastorino
6c28959e86
Move sqlite to sqlite3 for this tests to be run only on sqlite3 adapter
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-06-28 01:26:25 +02:00
Santiago Pastorino
3ab296fd59
AV::logger returns AC::logger if it's defined, workaround meanwhile AV doesn't have it's own logger
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-06-28 01:26:17 +02:00
Santiago Pastorino
824da60ae8
Move Rails module to abstract_unit to make test in isolation work
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-06-28 01:26:07 +02:00
Santiago Pastorino
cfb38319bc
Makes more sense to ask about method_defined?
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-06-28 01:26:01 +02:00
José Valim
9b19a6f16c
A few changes were done in this commit:
...
* Added :autoload to engines path API and redefine usage to be in sync with 6f83a5036d8a9c3f8ed7;
* Do not autoload code in *lib* for applications (now you need to explicitly require them). This makes an application behave closer to an engine (code in lib is still autoloaded for plugins);
* Always autoload code in app/ for engines and plugins. This makes engines behave closer to an application and should allow us to get rid of the unloadable hack required when controllers inside engines inherit from ApplicationController;
2010-06-28 01:22:32 +02:00
Xavier Noria
4329f8133f
Merge remote branch 'rails/master'
2010-06-28 00:12:15 +02:00
Xavier Noria
c37f7d66e4
your beloved and infamuous typo only spottable in github colored diff, thank you
2010-06-28 00:04:38 +02:00
Xavier Noria
8de0939708
AS guide: documents String|conversions
2010-06-27 23:59:01 +02:00
Michael Lovitt
ebee77a28a
Fixed that an ArgumentError is thrown when request.session_options[:id] is read in the following scenario: when the cookie store is used, and the session contains a serialized object of an unloaded class, and no session data accesses have occurred yet. Pushed the stale_session_check responsibility out of the SessionHash and down into the session store, closer to where the deserialization actually occurs. Added some test coverage for this case and others related to deserialization of unloaded types.
...
[#4938 ]
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-06-27 22:39:06 +02:00
Santiago Pastorino
a822ce78b3
String#[] doesn't return the byte representation on 1.9.2, we should use getbyte that was already added as a Ruby < 1.9 core_ext
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-06-27 20:30:29 +02:00
Santiago Pastorino
fa96638bf2
Added getbyte as a core_ext to Ruby < 1.9
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-06-27 20:30:24 +02:00
George Montana Harkin
0c0b0aa0f2
Fixes #2415 by creating a new instance of the Model when saving attributes to that model and the associated attributes already exist. Tests included. [ #2415 state:resolved]
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-06-27 16:35:03 +02:00
Andrew White
91b52c795f
Normalize recall params when the route is not a standard route otherwise :controller and :action may appear in the generated url [ #4326 state:resolved]
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-06-27 09:23:36 +02:00
Aaron Patterson
abd568bf1c
removing useless code. [ #4988 state:resolved]
...
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2010-06-26 19:51:59 -07:00
Santiago Pastorino
8d9545389f
Refactor: metaprogramming here it's confusing and make use of tap
...
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2010-06-26 19:44:44 -07:00
David Trasbo
0abf4b0746
Change reference to Test::Unit::AssertionFailedError to the generic ActiveSupport::TestCase::Assertion [ #4987 state:commited]
...
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2010-06-26 18:45:20 -07:00
Santiago Pastorino
8f358f397f
Refactor of column_exists? method and this works with PostgreSQL
2010-06-26 17:09:46 -07:00
Santiago Pastorino
64fee27a55
Removes useless flatten
2010-06-26 17:09:40 -07:00
Evgeniy Dolzhenko
a39f2657b1
Add module_eval missing file_name and line_number args [ #4712 state:resolved]
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-06-26 22:38:54 +02:00
Aaron Patterson
100d2282e3
adding adapter tests, avoiding private apis, fixing code in 1.9 [ #4986 state:resolved]
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-06-26 22:37:45 +02:00
José Valim
5b91c97763
Create a little bit less objects in ARel.
2010-06-26 22:37:24 +02:00
Santiago Pastorino
926ca9c102
Load JSON additions (as to_json) on active_support/all.
...
[#4730 state:committed]
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-06-26 21:15:18 +02:00
Santiago Pastorino
51be8dbded
Move constantize from conversions to inflections.
...
This removes ActiveModel dependency on TZInfo.
[#4979 state:committed]
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-06-26 20:49:30 +02:00
David Trasbo
df083b482d
Make sure ActiveResource::Errors#from_json doesn't pass nil to #from_array [ #3650 state:commited]
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-06-26 19:23:10 +02:00
José Valim
7eb5766bd1
Small changes to responder:
...
* resources is always an array;
* Lazy retrieve request and formats;
* Alias api_location and navigation_location to resource_location, making easier to change its behavior without affecting each other and without a need to reimplement any of the behavior methods.
2010-06-26 15:48:47 +02:00
José Valim
3782010377
Oops. Make previous commit pass on 1.9.2.
2010-06-26 12:14:25 +02:00
José Valim
aa48ab05f4
Tidy up tests in previous commit since they did not assure an OrderedHash is returned (the test would pass for an array and would pass by chance for hashes).
...
[#4875 state:resolved]
2010-06-26 12:09:56 +02:00
chaitanyav
9958950f78
Add OrderedHash#invert to preserve order in ruby 1.8 [ #4875 ]
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-06-26 12:05:25 +02:00
Andrew White
d4e1a2ef0d
Support optional static segements as well [ #4832 state:resolved]
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-06-26 12:02:29 +02:00
Paul Barry
59b24ceb0c
Fixed normalize_path in Routing::Mapper to handle optional prefix segments with static and dynamic parts
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-06-26 12:02:24 +02:00
José Valim
7bd85a8fc2
Work around the fact the JSON gem was overwriting to_json implementation for all Ruby core classes.
...
This is required because the JSON gem is incompatible with Rails behavior and was not allowing ActiveModel::Errors to be serialized.
So we need to ensure Rails implementation is the one triggered. [#4890 state:resolved]
2010-06-26 12:01:13 +02:00
Norman Clarke
cfaaed3f40
Move some methods into 1.8.x-only proxy. [ #4978 state:resolved]
...
These methods had been overridden because they had bugs on 1.9.1. Since
Rails now supports only 1.9.2, and these methods now work properly on
that version, there's no longer any need to override them.
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-06-26 10:16:37 +02:00
Andrew White
9a6fc9a540
Don't force pluralization of controller name when defining a resource [ #4980 state:resolved]
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-06-26 10:16:30 +02:00
Andrew White
bba19603c2
URL fragments should not have safe characters escaped. Ref: Appendix A, http://tools.ietf.org/rfc/rfc3986.txt
...
[#4762 state:resolved]
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2010-06-25 18:05:40 -07:00
Trevor Turk
81e9627c7f
Provide example for working around that regexp anchors can't be in route constraints
2010-06-25 18:50:56 -05:00
Aaron Patterson
6e65573222
refactoring the postgres adapter index method to avoid inject and use values_at. [ #4976 state:resolved]
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-06-26 01:35:38 +02:00
Santiago Pastorino
47134a04bb
blocks removed from all the ActiveRelation query_methods, extend method added instead
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-06-26 01:35:23 +02:00
José Valim
026cec3390
Merge branch 'tago'
2010-06-26 01:08:57 +02:00
Andrew White
11ff3da5f4
Add column and index query methods to ActiveRecord::Schema
...
[#4219 state:resolved]
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-06-26 01:08:32 +02:00
Aaron Patterson
4464d10e68
index dump should not include full text indexes. Thanks Ken Mayer for the original patch! [ #4949 state:resolved]
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-06-26 00:59:38 +02:00
Santiago Pastorino
65aa6a7db1
reorder method added to ActiveRelation
...
[#4972 state:committed]
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-06-26 00:59:12 +02:00
Santiago Pastorino
a2513aea07
Test for concatenated orders added
...
[#4972 ]
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-06-26 00:59:11 +02:00
rohit
cae33c4158
Remove previously defined class method logger to supress warnings in Active Support test suites. [ #4618 state:open]
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-06-26 00:27:31 +02:00
Paul Mucur
158e22dae0
Alias ActiveSupport::OrderedHash#update to ActiveSupport::OrderedHash.merge!
...
This ensures that an OrderedHash's keys are set up appropriately when using update.
[#4973 state:committed]
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2010-06-25 15:02:20 -07:00
Aaron Patterson
5e2b473b47
reorganizing adapter specific tests. [ #4974 state:resolved]
...
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2010-06-25 14:47:14 -07:00
Santiago Pastorino
efbd0eb9f7
Order is not guaranteed here, ordering by id of people table makes it work
2010-06-25 12:44:57 -07:00
wycats
ccc8eba4dc
Change the generated Gemfile to resolve, via documentation, the issue of rspec generators being unavailable in development mode
2010-06-25 12:19:22 -07:00
Neeraj Singh and Santiago Pastorino
0ebb5bf659
Support for multiple selects added
...
[#4841 state:committed]
2010-06-25 15:57:04 -03:00
Neeraj Singh
dd5924d8ca
added to_xml section for controller
2010-06-25 14:13:47 -04:00
Santiago Pastorino
3d8ccb9240
Makes a build_select for the select part of build_arel
2010-06-25 15:06:32 -03:00
Santiago Pastorino
82dc16b7d2
Metaprogramming not needed here
2010-06-25 15:06:32 -03:00
Santiago Pastorino
3344c011da
Avoid a blank line before the add/remove columns
2010-06-25 15:06:32 -03:00
Andrew White
5f64bce10f
Failing test for whether glob parameters accept regexps
...
[#4970 state:committed]
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2010-06-25 10:17:28 -07:00
Andrew White
3d8200318a
Add failing test case for parameters with periods
...
[#2536 state:resolved]
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2010-06-25 10:12:11 -07:00
Jeremy Kemper
0883b2b0c3
Depend on unreleased rack-mount 0.6.6.pre
2010-06-25 10:11:46 -07:00
José Valim
01472b5217
Do not mark the session as loaded if an error happened while doing it.
2010-06-25 19:03:00 +02:00
Neeraj Singh
a2242a608e
regexp anchors can't be in route constraints
2010-06-25 10:07:09 -04:00
José Valim
21c99e9388
Calling exists? in the session store, without checking for stale sessions, was causing the cookie store to panic because we need to unpack the whole session to get its key. This commit fixes this issue and also caches exists calls for performance improvements.
2010-06-25 12:15:17 +02:00
Łukasz Strzałkowski
518b16d9ae
Line break in migration template and nicer code indentation
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-06-25 10:57:05 +02:00
Carlos Antonio da Silva
b01df28413
Do not wrap hidden fields with error proc [ #4962 state:resolved]
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-06-25 09:49:29 +02:00
Prem Sichanugrist
617e94658d
Make sure that Rails doesn't resent session_id cookie over and over again if it's already there [ #2485 state:resolved]
...
This apply to only Active Record store and Memcached store, as they both store only the session_id, which will be unchanged, in the cookie.
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-06-25 09:41:52 +02:00
José Valim
a12b76b09e
Just reading flash messages should not create a session if one does not exist yet.
2010-06-25 09:36:26 +02:00
David Heinemeier Hansson
6682cce038
Dont reload the environment, just not needed bro
2010-06-24 17:38:46 -05:00
Neeraj Singh
4e8ca7bc9a
adding missing assertion and fixing the test
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-06-24 20:34:51 +02:00
Neeraj Singh
0d2cebe338
fixing test by replacing assert with assert_equal
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-06-24 20:34:46 +02:00
José Valim
73682d016c
Merge remote branch 'miloops/fixes'
2010-06-24 20:19:19 +02:00
Prem Sichanugrist
67ee6c38b9
Remove the --singeleton option from scaffold generator.
...
It turned out to be that scaffold for singeleton resource will always depend on another model, and it's not possible at the moment to make the application tests pass after generate the singeleton scafold. So, it would be better to remove it for now and probably provide another generator, such as singeleton_scaffold, in which also require the depended model name.
[#4863 state:resolved]
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-06-24 20:17:59 +02:00
Santiago Pastorino
7a7c608a26
Your original TIME ZONE value on PostgreSQL is correctly restored now, after going through options :utc and then going back to :local
...
[#4950 state:committed]
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-06-24 20:12:22 +02:00
Santiago Pastorino
497a0c3b00
quotes are not necessary here
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-06-24 20:12:22 +02:00
Neeraj Singh
81c5684267
adding middleware test for RAILS_CACHE
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-06-24 20:08:50 +02:00
Prem Sichanugrist
974196b091
Remove obsolete test case, since we have move Rails::LogSubscriber to ActiveSupport::LogSubscriber in [ 6788db824a] [ #4816 state:resolved]
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-06-24 20:05:07 +02:00
José Valim
d69ebb849a
Avoid deserializing cookies too early, which causes session objects to not be available yet. Unfortunately, could not reproduce this in a test case.
2010-06-24 20:03:03 +02:00
Emilio Tagua
4b5f417e63
Only yield block if given.
2010-06-24 13:17:24 -03:00
Nick Sieger
b549d93d2f
AS::Isolation functional on Windows/JRuby.
...
Doesn't make up for the fact that it's slooooooooow, though.
Signed-off-by: wycats <wycats@gmail.com >
2010-06-24 09:10:58 -07:00
Emilio Tagua
2c203a9413
Remove block definitions in finder methods.
2010-06-24 13:07:39 -03:00
Emilio Tagua
4086ecea24
Remove block definition from method, is not needed since yield is used inside.
2010-06-24 12:02:00 -03:00
Emilio Tagua
d9f199e123
Don't define block, just yield if block is given.
2010-06-24 11:40:23 -03:00
Emilio Tagua
fdb7f84eb1
Remove deprecated block usage in composed_of.
2010-06-24 11:17:05 -03:00
José Valim
7710a8cb6b
Ops, this should be beta4.
2010-06-24 04:31:07 -07:00
Andrew White
df15ba7ead
Fix namespaced redirects [ #4389 state:resolved]
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-06-24 13:26:24 +02:00
Elomar França
176c386409
Fix bug where ActiveResource::HttpMock would overwrite Accept/Content-Type header to application/xml [ #4939 state:resolved]
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-06-24 13:25:10 +02:00
José Valim
6788db824a
Move Rails::LogSubscriber to ActiveSupport::LogSubscriber, allowing frameworks like ActiveRecord and ActiveResource to log outsude Rails::Application [ #4816 state:resolved]
2010-06-24 13:23:43 +02:00
Emilio Tagua
5441e082f9
Add tests for relation count. Fix other tests that were conceptually wrong.
...
[#4882 state:resolved]
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-06-24 11:41:55 +02:00
José Valim
e061a12a15
Remove run_initializers from class methods.
2010-06-24 11:40:22 +02:00
Jeremy Kemper
5eb3b4d9a7
Fix initializable tests
2010-06-24 02:16:59 -07:00
Jeremy Kemper
9f7874ac41
Move Collection responsibility from application to initializable
2010-06-24 02:13:08 -07:00
Jeremy Kemper
cdb8609c64
Speed up boot by tsorting as infrequently as possible
2010-06-24 02:04:00 -07:00
Jeremy Kemper
60ab9255f0
Don't halt railties tests on failures
2010-06-24 02:04:00 -07:00
Jeremy Kemper
0b3dd5718c
Array#sample now exists, so test for #forty_two instead
2010-06-24 02:04:00 -07:00
Jeremy Kemper
4883082ff1
Support an extra profile printer arg
2010-06-24 01:08:12 -07:00
rohit
0758d49300
Revert "Guides: Add :references to supported column types."
...
This reverts commit 41ed4db560 .
2010-06-24 09:55:49 +05:30
rohit
41ed4db560
Guides: Add :references to supported column types.
2010-06-24 09:41:44 +05:30
Jeremy Kemper
7b730a2f1b
Show GC time and # of runs too
2010-06-23 16:11:13 -07:00
José Valim
69abbe8934
Avoid using Pathname on Resolver and AS::Dependencies.
2010-06-24 01:06:37 +02:00
Xavier Noria
6f83a5036d
renames load_(once_)paths to autoload_(once_)paths in dependencies and config
2010-06-24 00:17:28 +02:00
Paul Gillard
4a0a640d33
Remove incorrect comment regarding #initialize_copy
...
Comment added in #3164 is incorrect after reading http://dev.rubyonrails.org/ticket/7191 .
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-06-23 22:42:17 +02:00
Michael Lovitt
49f52c3d91
Sessions should not be created until written to and session data should be destroyed on reset.
...
[#4938 ]
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2010-06-23 11:56:35 -07:00
Neeraj Singh
0bf3baa6b3
adding fix for to_xml for ActiveRecord relation object
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-06-23 18:00:32 +02:00
Neeraj Singh
eb04408a20
ActiveRecord's relation object should respond to to_json and to_yaml
...
[#4547 state:resolved]
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-06-23 18:00:25 +02:00
Neeraj Singh
a3ce6fcc56
adding column named 'group' to ensure that nothing breaks given that 'group' is sql reserved word
...
[#4945 state:resolved]
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-06-23 17:46:37 +02:00
David Chelimsky
32b8be9533
Expose view via the view() method in AV::TestCase::Behavior
...
- was exposed as _view, which suggested it was private
- left _view as an alias of view as not to break any extensions that are
relying on _view
[#4932 state:resolved]
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-06-23 17:45:48 +02:00
David Chelimsky
0e0df4b0c5
In ActionView::TestCase::Behavior, assign variables right before
...
rendering the view.
- Previously, _assigns were locked down the first time _view was
referenced.
[#4931 state:resolved]
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-06-23 15:07:44 +02:00
rohit
3ac5a53397
Guides: replace reference to hpricot with nokogiri [ #3290 state:resolved]
2010-06-23 18:22:02 +05:30
Josh Kalderimis
e8c064bbe0
Regression with how base errors messages are added to a model. Works correctly for both string error messages and symbol translated messages.
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-06-23 14:45:55 +02:00
Mohammed Siddick.E
7008911222
Patch for Namespace problem in Scaffold. [ #4763 state:resolved]
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-06-23 09:30:55 +02:00
Paul Gillard
d132dd3352
Don't clone associations [ #4894 state:resolved]
...
Cloning an active record object should be shallow in that it should copy attributes but not associations. This was no longer true as a result of #3164 .
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-06-23 09:27:15 +02:00
Santiago Pastorino
ef7a04ea85
Fixes encoding mistakes on old_base/mail_service tests
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-06-23 09:26:49 +02:00
Jeff Dean
ac8d3e3aca
make text_field and hidden_field omit the value attribute if the developer explicitly passes in :value => nil [ #4839 state:resolved]
...
Signed-off-by: Michael Koziarski <michael@koziarski.com >
2010-06-23 16:23:54 +12:00
Jeff Dean
e639536ea8
remove_column should raise an ArgumentError when no columns are passed [ #4803 state:resolved]
...
Signed-off-by: Michael Koziarski <michael@koziarski.com >
2010-06-23 16:21:29 +12:00
knapo
995b1a243c
Fix controller_name for non default controller paths [ #4901 state:resolved]
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-06-23 01:37:52 +02:00
José Valim
ed5c096d60
Tidy up asset tag a bit and make railties tests green again.
2010-06-23 01:34:25 +02:00
Josh Kalderimis
97b773303d
refactored the javascript asset tag helpers and moved the default scripts setup within the railtie
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-06-23 01:02:59 +02:00
José Valim
a6eeb0865e
Update CHANGELOG.
2010-06-23 00:52:20 +02:00
Carlos Antonio da Silva
9651ca751c
Add the :path option to match routes when given as symbols. This is specially useful in http helpers for generating routes in scenarios like:
...
resources :users, :path => 'usuarios' do
get :search, :on => :collection, :path => 'pesquisar'
end
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-06-23 00:49:15 +02:00
José Valim
61317b643a
Provive resources_path_names helpers in the router.
2010-06-23 00:43:25 +02:00
José Valim
e5444f84df
Stop filling the blocks scope array with nil.
2010-06-22 23:52:12 +02:00
Carlos Antonio da Silva
aacb83143f
Allow namespace accept options in routes [ #4936 state:resolved]
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-06-22 23:37:49 +02:00
José Valim
fef5cf92ed
Deprecate :name_prefix in the new router DSL.
2010-06-22 23:30:19 +02:00
Edgars Beigarts
62c4e4d385
Fix connection reloading in development mode. [ #4929 state:resolved]
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-06-22 21:48:43 +02:00
Neeraj Singh
c0fc084e93
should be able to run ActiveModel validations_test [ #4933 state:resolved]
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-06-22 21:38:27 +02:00
Santiago Pastorino
f61ac89947
Avoid method redefined warning
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-06-22 21:16:59 +02:00
Trevor Turk
64987d6711
Note that 'rails server' allows specifying mongrel, thin, etc [ #4845 state:resolved]
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-06-22 21:13:12 +02:00
James Harton
d0df7f1196
Fix small bug where ActiveRecord::PredicateBuilder#build_from_hash didn't test for Arel::Relation as right hand value. [ #4917 state:resolved]
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-06-22 18:05:27 +02:00
Neeraj Singh
7033be5f72
test for #4917
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-06-22 18:04:38 +02:00
Paco Guzman
ec37452f68
Remove unused variable on assert_recognizes [ #4912 state:resolved]
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-06-22 17:37:18 +02:00
Prem Sichanugrist
6c4bab306a
Missing require for the class/attribute.rb [4812 state:resolved]
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-06-22 17:18:28 +02:00
David Chelimsky
f29fb0dd9e
update the list of instance variables that are excluded from assigns in view tests
...
[#4930 state:resolved]
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-06-22 17:15:56 +02:00
Edgars Beigarts
9dda440c38
Improve documentation for assocations :autosave option.
2010-06-22 17:49:59 +03:00
Emilio Tagua
12a9e84799
Clean CHANGELOG whitespace.
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-06-22 16:44:10 +02:00
Emilio Tagua
7df105b1e6
Fix order method to accept relation attributes.
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-06-22 16:44:10 +02:00
Emilio Tagua
df595b577e
Use the new query API in AR performance script.
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-06-22 16:44:10 +02:00
David Calavera
b8330a2261
preventing memcached initialization errors with default servers list [ #4921 state:resolved]
...
As of this writing the JRuby client does not support a default port.
Signed-off-by: Xavier Noria <fxn@hashref.com >
2010-06-22 16:28:29 +02:00
David Calavera
256a33d0fb
defines ORIG_ARGV in Active Support's abstract_unit.rb (used in isolation.rb) [ #4922 state:resolved]
...
Signed-off-by: Xavier Noria <fxn@hashref.com >
2010-06-22 16:27:09 +02:00
rohit
40bf76165c
Rails Runner now sets $0 and $PROGRAM_NAME to name of file being run [ #2244 state:resolved]
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-06-22 15:20:29 +02:00
rohit
9be0b50962
Added 4 tests for Rails Runner. 2 failing tests for $0 and $PROGRAM_NAME [ #2244 state:open]
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-06-22 15:20:28 +02:00
RainerBlessing
70c932f794
adds minus to value part of id [ #4862 state:resolved]
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-06-22 15:10:56 +02:00
Neeraj Singh
dcfb9805f2
test for #4862
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-06-22 15:10:49 +02:00
Santiago Pastorino
6ea967729f
Avoid method redefined warning
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-06-22 15:09:01 +02:00
David Chelimsky
0576ec4ddd
Add support for specifying locals in view tests with assert template [ #4927 state:resolved]
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-06-22 14:51:22 +02:00
Jamison Dance
36d1e90e22
fixing some comma and grammar problems in the note about SQLite3 and other database configurations
2010-06-22 03:27:29 -06:00
José Valim
02399a1184
Ensure overwritten callbacks conditions in controllers work [ #4761 state:resolved] [ #3913 state:resolved]
2010-06-22 07:57:45 +02:00
Jeremy Kemper
1b369be02f
Bump rack-mount to 0.6.5 for tokenizer speedup
2010-06-21 18:28:00 -07:00
Josh Kalderimis
fd03f1738e
removed default Formatter in logger, not needed with 1.8.7 upwards
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-06-22 01:19:02 +02:00
Josh Kalderimis
dad71c6099
removed 'unless const_defined?' code smell
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-06-21 23:34:45 +02:00
Jaime Iniesta
23d277476a
Ignore file guides/output/layout.html on W3C validations
2010-06-21 12:39:27 +02:00
José Valim
0421fb7a91
Refactor previous commit a bit [ #4057 state:resolved]
2010-06-21 12:17:24 +02:00
Jeroen van Dijk
26392c4ac5
Make ActiveModel::Errors#add_on_blank and #add_on_empty accept an options hash and make various Validators pass their (filtered) options.
...
This makes it possible to pass additional options through Validators to message generation. E.g. plugin authors want to add validates_presence_of :foo, :format => "some format".
Also, cleanup the :default vs :message options confusion in ActiveModel validation message generation.
Also, deprecate ActiveModel::Errors#add_on_blank(attributes, custom_message) in favor of ActiveModel::Errors#add_on_blank(attributes, options).
Also, refactoring of ActiveModel and ActiveRecord Validation tests. Test are a lot more DRY now. Better test coverage as well now.
The first four points were reapplied from an older patch of Sven Fuchs which didn't apply cleanly anymore and was not complete yet.
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-06-21 11:55:21 +02:00
Jeff Kreeftmeijer
ead72b319f
Changed ruby /path/to/rails myapp --dev to ruby /path/to/rails new myapp --dev in the "Thor is not avalable" message. [ #4915 state:resolved]
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-06-21 11:10:25 +02:00
rohit
45b263cbf1
Initialize @last_update_at in file_update_checker to hide warnings in AS test suite.
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-06-21 11:10:19 +02:00
rohit
eaa973fc78
Guides: AS Core Extensions, minor type
2010-06-21 10:33:36 +05:30
rohit
94a7964a89
Guides: AS Core Extentions, fix warning message to display correctly.
2010-06-21 10:16:06 +05:30
rohit
9b7540bd92
Guides: AS Core Extentions, minor typos fixed.
2010-06-21 10:11:21 +05:30
rspeicher
0da754dc59
Generators Guide: Fix another typo I introduced
2010-06-20 21:21:44 -04:00
Xavier Noria
b311dbb0ba
Revert "files in the lib directory are no longer autoloaded"
...
This patch is not consistent since it leaves similar
directories in load_paths, needs more thought.
This reverts commit b5fe014fdc .
2010-06-21 01:46:24 +02:00
Emilio Tagua
7b7cedcb8d
Don't waste time building relations if there are no values presents. [ #4860 state:resolved]
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-06-21 01:10:33 +02:00
Hongli Lai (Phusion)
756d77622b
Allow instrumentation of cache hits and misses. [ #4888 state:resolved]
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-06-21 01:09:55 +02:00
José Valim
f81666698b
Alias app to build_middleware_stack for clarity.
2010-06-21 01:08:50 +02:00
José Valim
746a385678
Remove unused webrick_server file.
2010-06-21 01:03:48 +02:00
Xavier Noria
b5fe014fdc
files in the lib directory are no longer autoloaded
...
Conceptually, the lib directory is closer 3rd party libraries
than to the application itself. Thus, Rails adds it to Ruby's
load path ($LOAD_PATH, $:) but it is no longer included in
dependencies' load paths.
To enable autoloading back put this in your config/application.rb
config.load_paths += %W( #{config.root}/lib )
2010-06-21 00:40:00 +02:00
Xavier Noria
69fec3ab3f
adds parens to silence a warning in the test suite of AS
2010-06-20 23:29:37 +02:00
Xavier Noria
207fa59675
Merge remote branch 'rails/master'
...
Conflicts:
actionpack/lib/abstract_controller/base.rb
2010-06-20 23:13:19 +02:00
rspeicher
31cadc730a
Generators Guide: Typo of my own
2010-06-20 16:42:20 -04:00
rspeicher
cd54e610f4
Merge branch 'master' of github.com:lifo/docrails
2010-06-20 16:39:52 -04:00
rspeicher
1168d65237
Generators Guide: Style/grammar changes and minor typos
2010-06-20 16:39:44 -04:00
rspeicher
1cc71d7931
Generators Guide: Make titles conform to conventions
2010-06-20 16:38:05 -04:00
Rizwan Reza
c20cfe477a
Take out documentation from DeprecatedMapper to discourage its usage.
2010-06-21 01:02:25 +04:30
Rizwan Reza
3ec7b1cba3
Use h1 for titles.
2010-06-21 01:00:42 +04:30
Rizwan Reza
ab7830d66c
Final touches and fixes.
2010-06-21 00:56:31 +04:30
Rizwan Reza
96b927d9db
Action View is now titled.
2010-06-21 00:50:26 +04:30
Rizwan Reza
1a0dc267f1
Action View is now titled.
2010-06-21 00:50:08 +04:30
Rizwan Reza
3ef1d63a78
All scopes are now cross-referenced.
2010-06-21 00:45:34 +04:30
rspeicher
b083bf2410
Generators Guide: Remove semicolons from prologue, as none of the other guides had them
2010-06-20 16:15:11 -04:00
Paco Guzman
46dd8af179
Update integrated logging format
2010-06-20 19:36:46 +02:00
Rodrigo Rosenfeld Rosas
03216ae252
Fix comment in en.yml datime_select -> datetime_select
2010-06-20 10:41:47 -03:00
José Valim
50d37a7606
Update ActiveSupport CHANGELOG with latest changes.
2010-06-20 14:47:56 +02:00
José Valim
dad80ad786
I18n.reload! is only called if any of the locale files actually changed.
2010-06-20 14:44:38 +02:00
José Valim
772c2b0b86
Use the new ActiveSupport::FileUpdateChecker instead of RoutesReloader.
2010-06-20 13:37:58 +02:00
José Valim
71703c98ba
Add ActiveSupport::FileUpdateChecker.
2010-06-20 13:26:42 +02:00
José Valim
9e081caee7
Improve documentation for add_lib_to_load_paths!
2010-06-20 13:03:08 +02:00
Thibaud Guillaume-Gentil
5522578d16
Fixed date_select date_separator when discard_month and/or discard_day are true [ #4856 state:resolved]
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-06-20 12:33:02 +02:00
rohit
d061050638
Add test for migration generator with name not starting with add or remove. [ #4835 state:committed]
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-06-20 12:32:56 +02:00
Steve Abatangle
4515947845
Fix problem with migrations template that can cause bogus code to be created
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-06-20 12:32:51 +02:00
Carlos Antonio da Silva
f9abbf9a4d
Adding missing test to autolink with other protocols (file) [ #4886 state:resolved]
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-06-20 12:32:41 +02:00
Jan De Poorter
96f5e59a26
Make sure a namespaced <%= render form %> still renders the _form partial [ #4784 state:resolved]
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-06-20 00:58:10 +02:00
Ryan Duryea
73df48083a
Added absolute path for config.ru as well. Turns out this is also needed to fix the daemon issue under ruby 1.8.7
...
[#4531 state:resolved]
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-06-20 00:57:29 +02:00
Ryan Duryea
bb324693ab
Pass rack the absolute path of server's pid file
...
When running as a daemon, rack will cd to "/" and paths relative to the
root of the rails app aren't valid when rack is setting up. Because of
this, "rails server -d" was failing silently when trying to write it's
pid file
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-06-20 00:57:15 +02:00
Tarsoly András
bb6cd6d3ec
Use Rack::Utils.bytesize when calculating content-length of exception pages. [ #4727 state:resolved]
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-06-20 00:52:35 +02:00
Norman Clarke
667522ca98
Adds titleize/titlecase to AS::Multibyte::Chars
...
[#2794 state:resolved]
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-06-20 00:51:19 +02:00
rohit
95a8f252c0
remove executable permission from files that don't need it. [ #4802 state:resolved]
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-06-20 00:50:48 +02:00
Emilio Tagua
e061212e86
Refactor build_arel: move joins out and simplify havings. [ #4860 state:resolved]
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-06-20 00:37:55 +02:00
Sam Elliott and Santiago Pastorino
02ea1aa88c
<=> is defined twice on multibyte/chars.rb for Ruby < 1.9
...
[#4850 state:committed]
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-06-20 00:35:20 +02:00
James Le Cuirot
f664c57fe8
Don't overwrite unsaved updates when loading an association but preserve the order of the loaded records. Reapplied from before but now allows already-saved records to be refreshed.
...
[#4830 state:resolved]
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-06-20 00:32:06 +02:00
Chris Griego
98a5188f51
Strip trailing whitespace from generated applications [ #4905 state:resolved]
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-06-20 00:28:41 +02:00
David Chelimsky
86002a0dfe
Support render_template in view tests. Useful for specifying which
...
partials are rendered under different conditions.
[#4903 state:resolved]
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-06-20 00:26:42 +02:00
Andrew White
1f84061c5c
Don't use module to work out shallow name prefix and path as it may not accurately reflect the actual namespace [ #4899 state:resolved]
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-06-20 00:15:48 +02:00
Andrew White
ed3f042e99
Make polymorphic_url and scaffolding work with uncountable resources [ #3930 state:resolved]
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-06-20 00:15:41 +02:00
Andrew White
65ce3d1297
Accept an object for :constraints option [ #4904 state:resolved]
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-06-20 00:15:30 +02:00
José Valim
72725d7b7f
Merge branch 'master' of github.com:rails/rails
2010-06-20 00:12:54 +02:00
José Valim
0247995d05
ActiveModel::Validations::Callbacks should not be required by default.
2010-06-19 18:20:02 +02:00
Neeraj Singh
51739d3228
moving before_validation and after_validation functionality from ActiveRecord to ActiveModel
...
[#4653 state:resolved]
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-06-19 17:59:52 +02:00
José Valim
312f433241
Clear DescendantsTracker on each request.
2010-06-19 17:51:44 +02:00
Wincent Colaiuta
728b9eccad
option_groups_from_collection_for_select should return HTML-safe string [ #4879 state:resolved]
...
Signed-off-by: Xavier Noria <fxn@hashref.com >
2010-06-19 17:22:49 +02:00
wycats
f368b21cb6
Remove a relic of #request being in RackDelegation
2010-06-19 08:19:15 -07:00
José Valim
d430db9fd4
Remove descendants warning while executing tests.
2010-06-19 17:16:11 +02:00
José Valim
033e0a041f
ActiveRecord and ActionPack now use the new descendants implementation.
2010-06-19 17:15:21 +02:00
José Valim
a2b7fcb07c
Change callbacks to automatically include DescendantsTracker and rename descendents to descendants.
2010-06-19 16:58:15 +02:00
José Valim
8db8c6f4ce
Add ActiveSupport::DescendantsTracker.
2010-06-19 16:44:35 +02:00
Scott Taylor
4bfff05f37
add missing shebang to rails bin. LH [ #4885 state:resolved]
...
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2010-06-19 00:54:42 -07:00
Andrew White
bf59717b43
Custom resource routes should be scoped
...
[#3765 ]
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2010-06-19 00:15:06 -07:00
Maxime RETY
2c2a5fe829
Fix Yajl backend discovery in ActiveSupport::JSON
...
[#4897 state:committed]
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2010-06-18 20:12:31 -07:00
Master Lambaster
a7cae64104
Fix test which prevents connection reset on failing and remove hardcoded connection
...
[#4689 state:committed]
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2010-06-18 15:28:14 -07:00
Antonio Cangiano
bfc05e244c
Adds a few connection parameters for IBM databases.
...
[#3852 ]
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2010-06-18 15:27:11 -07:00
Brian Durand
237165feb3
Fix bug with rolling back frozen attributes.
...
[#2991 ]
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2010-06-18 15:11:17 -07:00
David Genord II
a186431414
form_for without :html and with :remote should not error
...
[#4902 state:committed]
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2010-06-18 13:59:28 -07:00
Josh Kalderimis
9d3eeb9053
fix for :shallow in router not generating helpers for create, update, and destroy actions when :only or :except are used
...
[#4900 state:committed]
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2010-06-18 13:59:14 -07:00
Jaime Iniesta
484b872972
Merge branch 'validate_dots'
2010-06-18 15:28:10 +02:00
Jaime Iniesta
6d222cb94e
cleaner output for rake validate_guides: dot-style, brief summary and detailed description below
2010-06-18 15:26:07 +02:00
Jeremy Kemper
a55d83292f
Credit for the heavy lifting!
2010-06-17 22:18:12 -07:00
Gonçalo Silva
113b0ec03c
enable_stats added back in since Benchmarker doesn't start RubyProf
...
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2010-06-17 22:15:16 -07:00
Gonçalo Silva
0cef199c8e
check if the profiler patch is applied, otherwise GC::Profiler doesn't have the 'data' method
2010-06-17 19:18:53 -07:00
Gonçalo Silva
c8019cd04a
added information about what is being used
2010-06-17 19:18:53 -07:00
Gonçalo Silva
b169d83787
heap_live_objects+heap_free_objects is broken, use heap_total_objects instead
2010-06-17 19:18:53 -07:00
Gonçalo Silva
5e5d1babb0
also use GC profiler extended patch to retrieve GC time on 1.9
2010-06-17 19:18:53 -07:00
Gonçalo Silva
f02d3f9eee
ruby's GC doesn't support the time method, removed support for it
2010-06-17 19:18:52 -07:00
Gonçalo Silva
175164397b
use GC profiler extended patch to retrieve GC runs on 1.9
2010-06-17 19:18:52 -07:00
Gonçalo Silva
555c3b5abe
ruby's GC doesn't support collections and heap_info, RubyProf can handle it
2010-06-17 19:18:52 -07:00
Gonçalo Silva
4813462eea
GC at 1.9.X doesn't have malloc_allocated_size, remove support for it
2010-06-17 19:18:52 -07:00
Gonçalo Silva
36f5d09692
removed support for 1.8's GC alternative hacks (railsbench and lloyd patches). RubyProf can handle it
2010-06-17 19:18:52 -07:00
Gonçalo Silva
cb74cfc9c1
check if the data method is defined (meaning it's correctly patched)
2010-06-17 19:18:52 -07:00
Gonçalo Silva
901452d06a
the official profiler (present in 1.9) should have the highest priority
2010-06-17 19:18:52 -07:00
Gonçalo Silva
381a30fbba
don't set cpu_frequency if RubyProf resolved it
2010-06-17 19:18:52 -07:00
Aaron Patterson
bf6661c5d7
setting the timezone in postgres to whatever ruby thinks the timezone is [ #4895 state:resolved]
...
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2010-06-17 16:49:21 -07:00
Aaron Patterson
5ae7a9d31d
when the timezone is nil, a TimeWithZone object should not be constructed. [ #4881 state:resolved]
...
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2010-06-17 14:14:30 -07:00
Santiago Pastorino
84d387bc0f
Make text_helpers methods which return valid html to return it as safe and sanitize the input always unless :sanitize => false is set
...
[#4825 state:committed]
Signed-off-by: David Heinemeier Hansson <david@loudthinking.com >
2010-06-17 13:34:10 -05:00
Xavier Noria
12eef93e89
documents how to run an individual test in AR
2010-06-17 17:41:39 +02:00
Andrew White
6db9558416
Add shallow routing option to new router [ #3765 status:committed]
...
Signed-off-by: David Heinemeier Hansson <david@loudthinking.com >
2010-06-17 09:52:55 -05:00
Santiago Pastorino
7240a960f2
excerpt shoudn't return safe output test added
...
[#4878 ]
Signed-off-by: David Heinemeier Hansson <david@loudthinking.com >
2010-06-17 09:41:04 -05:00
Wincent Colaiuta
a424808df9
truncate() should not try to produce HTML-safe output
...
As discussed in Lighthouse ticket #4825 and ticket #4878 , the truncate()
method cannot guarantee safe output for all possible inputs/offsets, so
it is best to leave the output unsafe so that it gets escaped when used
in a view.
Signed-off-by: Santiago Pastorino <santiago@wyeworks.com >
Signed-off-by: David Heinemeier Hansson <david@loudthinking.com >
2010-06-17 09:41:04 -05:00
Hongli Lai (Phusion)
6f5fb13928
Remove documentation reference to AS::Notifications::Event#result because it has been removed.
2010-06-17 15:47:37 +02:00
José Valim
69bc8b26a9
Merge branch 'master' of github.com:rails/rails
2010-06-17 13:49:27 +02:00
José Valim
7ba756281a
Add a failing test for ticket #4874
2010-06-17 13:48:02 +02:00
Malcolm Locke
1910c92395
Missing quote and indentation wrong
2010-06-17 14:26:13 +12:00
Xavier Noria
2aa4e5f3fa
pdoc tasks publishe APIs in api.rubyonrails.org
2010-06-16 22:39:13 +02:00
Xavier Noria
01f3f0dbae
use RDoc 2.2 to generate the documentation of individual components
2010-06-16 22:30:06 +02:00
Bryan Woods
5861fde01f
Merge remote branch 'origin/master'
2010-06-16 15:53:20 -04:00
Bryan Woods
c1ff781001
Guides: renaming to active_record_validations_callbacks for consistency and updating links to reflect new path
2010-06-16 15:50:32 -04:00
Rizwan Reza
35e3f72af2
Adds backslash to scope for cross-references.
2010-06-16 23:53:10 +04:30
Rizwan Reza
f09736bc0f
Added title to some other files in actionpack/lib/action_view
2010-06-16 22:57:50 +04:30
Rizwan Reza
324de1993b
Added titles and description.
2010-06-16 22:54:53 +04:30
Rizwan Reza
687282dd50
Merge branch 'master' of github.com:lifo/docrails
2010-06-16 22:48:16 +04:30
Rizwan Reza
5a0bc2c7bc
Adds title and description where needed.
2010-06-16 22:47:49 +04:30
kaygee
6509cebbf6
Merge branch 'master' of github.com:lifo/docrails
...
* 'master' of github.com:lifo/docrails:
Adds title to activerecord/lib/active_record/associations/*
Adds title to the rest of the files in activerecord/lib
Adds title and proper formatting to docs.
Adds title where needed.
Adds basic description and title.
Adds title and minor changes.
2010-06-16 13:07:19 -05:00
kaygee
9a4fc42071
Clarify language around list of finder methods.
...
Clarify that finder methods return an instance of class ActiveRecord::Relation.
2010-06-16 13:06:46 -05:00
Rizwan Reza
fde9504847
Adds title to activerecord/lib/active_record/associations/*
2010-06-16 22:28:20 +04:30
Rizwan Reza
6445441253
Adds title to the rest of the files in activerecord/lib
2010-06-16 22:25:15 +04:30
Rizwan Reza
4e3eec3d01
Adds title and proper formatting to docs.
2010-06-16 22:22:35 +04:30
Rizwan Reza
0ebdc26cae
Adds title where needed.
2010-06-16 22:17:05 +04:30
Rizwan Reza
2b7f08428c
Adds basic description and title.
2010-06-16 22:15:04 +04:30
Rizwan Reza
d8277804b2
Adds title and minor changes.
2010-06-16 22:08:14 +04:30
Xavier Noria
145fbdff67
removes the documentation group from the Gemfile, thus making RDoc 2.2 required in dev machines
...
In order to generate the API with that particular version we need to activate the gem
in the Rakefile before rake. Therefore the Rakefile does not honor --without for that
group now. Installing rdoc is no big deal anyway.
2010-06-16 19:28:23 +02:00
kaygee
317a75bf58
Fix incorrect pluralization in 'These methods allows you to pass arguments...'.
2010-06-16 12:10:50 -05:00
Aaron Patterson
8e56085817
use assert_in_delta() for floating point comparisons in tests [ #4871 state:resolved]
...
Signed-off-by: Carl Lerche <carllerche@mac.com >
2010-06-16 10:09:59 -07:00
rohit
746347d997
Guides: AS Core Extensions, behaviour => behavior
2010-06-16 12:52:21 +05:30
rohit
f103a75b48
Guides: AS Core Extensions, fixed a few typos.
2010-06-16 12:48:32 +05:30
Xavier Noria
07c6b7a6ad
migrates the Jamis template to RDoc 2.x, the root Rakefile requires RDoc 2.2
...
To understand the changes in horo.rb check rdoc/template.rb in a RDoc 2.x
2010-06-16 04:06:20 +02:00
Bryan Woods
74b4d3f521
Merge branch 'master' of github.com:lifo/docrails
2010-06-15 15:18:43 -04:00
Bryan Woods
33b46079bc
Fixing some minor typos, grammar, accuracy, and spacing issues in Active Record Validations Callbacks guide
2010-06-15 15:17:23 -04:00
Rizwan Reza
c86915450a
Adds title.
2010-06-15 23:11:30 +04:30
Rizwan Reza
cef442f92c
Added typewriter tag to code.
2010-06-15 23:03:54 +04:30
Rizwan Reza
c7f78b184d
Added description and title to Dynamic Scope Match
2010-06-15 23:02:51 +04:30
Rizwan Reza
de65c82bfa
Changes call backs to callbacks.
2010-06-15 22:48:10 +04:30
Rizwan Reza
4ad6103c4f
Adds title and basic description where needed.
2010-06-15 22:41:41 +04:30
Rizwan Reza
596300ac8a
Merge branch 'master' of github.com:lifo/docrails
2010-06-15 22:21:39 +04:30
Rizwan Reza
3ae67fbebb
Add titles to the rest of the files in active_model/validations/*
2010-06-15 22:20:19 +04:30
Rizwan Reza
d896d8fa20
Minor doc changes to active_model/validations/confirmation.rb
2010-06-15 22:17:06 +04:30
Rizwan Reza
6907bfe1ab
Minor doc changes to active_model/validations/acceptance.rb
2010-06-15 22:13:30 +04:30
Bryan Woods
89b96c0313
Active Model lint - fix minor typos
2010-06-15 13:38:22 -04:00
Bryan Woods
538b7b97bb
Active Record Associations - minor change of DeleteRestrictionError doc for clarity
2010-06-15 12:36:21 -04:00
Evgeniy Dolzhenko
ef404c771d
Fix a bunch of minor spelling mistakes
2010-06-15 12:04:22 +04:00
Neeraj Singh
3cc2d196c0
Revert "removing the extra \"
...
This reverts commit 51a9703b1e .
2010-06-15 00:48:22 -04:00
Neeraj Singh
5e60e65713
Merge branch 'master' of github.com:lifo/docrails
2010-06-15 00:46:44 -04:00
Neeraj Singh
51a9703b1e
removing the extra \
2010-06-15 00:46:35 -04:00
rspeicher
1a50cc3163
Routing guide - Minor typo/consistency changes
2010-06-14 18:46:30 -04:00
rspeicher
6f0eb4a098
Active Record Basics - Separate and clarify the explanations for created_at/on and updated_at/on
2010-06-14 18:19:01 -04:00
rspeicher
ef2798f018
Active Record Basics - Style and grammar edits
...
- "i.e." should be "e.g." in these cases, and include the comma
- Newline consistency before/after Ruby blocks
- Conform to the apparent guide standard of "Active Record" over "ActiveRecord"
2010-06-14 18:11:35 -04:00
Xavier Noria
5cd3c2a855
Merge remote branch 'rails/master'
2010-06-14 23:24:41 +02:00
Xavier Noria
f17159b029
edit pass: the names of Rails components have a space, ie, "Active Record", not "ActiveRecord"
2010-06-14 23:22:04 +02:00
rspeicher
b442edbfcc
Fix minor typos and inconsistencies, and one minor grammar change
2010-06-14 17:19:15 -04:00
Xavier Noria
94de5b8cb5
edit pass in #define_callbacks rdoc
2010-06-14 22:52:47 +02:00
Neeraj Singh
e4c8bc1b34
adding to the :kind documentation for ActiveSupport callbacks
2010-06-14 16:18:29 -04:00
Neeraj Singh
ed9a183ea4
clearer documentation of how scope applies to ActiveSupport callbacks
2010-06-14 15:48:09 -04:00
Xavier Noria
4a8c8804ff
refactors AR::Base#reset_table_name
2010-06-14 18:36:04 +02:00
Thiago Pradi
8d82bef58a
Documentation for #quoted_table_name method
...
Signed-off-by: Xavier Noria <fxn@hashref.com >
2010-06-14 17:32:45 +02:00
Neeraj Singh
f587dec2c9
truncate safe method description changes
2010-06-14 09:12:10 -04:00
Rizwan Reza
e67c28dfe0
Added headings to serializers.
2010-06-14 13:59:55 +04:30
Rizwan Reza
7d7d54fa1f
Revised the rest of the files from ActiveModel.
2010-06-14 13:56:51 +04:30
Rizwan Reza
2572af11ce
Revised and added headings.
2010-06-14 13:49:01 +04:30
Rizwan Reza
de12b5e616
Revised naming.rb and lint.rb
2010-06-14 13:44:49 +04:30
Rizwan Reza
c5db6450ec
Added headings and revised active_model.rb/lint.rb grammatically
2010-06-14 13:43:06 +04:30
Rizwan Reza
626586b8c7
Minor changes to active_model/errors.rb
2010-06-14 13:40:57 +04:30
Rizwan Reza
716c243def
Minor changes to active_model/callbacks.rb and dirty.rb
2010-06-14 13:38:29 +04:30
Rizwan Reza
97d6778c80
Minor changes to active_model/attribute_methods
2010-06-14 13:36:05 +04:30
Rizwan Reza
4523081317
Minor changes to callbacks and conversion API docs.
2010-06-14 13:28:00 +04:30
Rizwan Reza
bf7429041e
Merge branch 'master' of git://github.com/rails/rails
2010-06-14 13:13:13 +04:30
Derek Willis
4b05de19aa
updated active record querying guide to standardize on first_name for Client
2010-06-13 22:36:42 -04:00
Derek Willis
1c95b67857
updated active record querying guide to standardize on first_name for Client
2010-06-13 22:35:16 -04:00
Santiago Pastorino
2fadc1c5dd
Remove unneeded .rb suffix on require statements
2010-06-13 19:50:38 -03:00
David Chelimsky
c125116013
docfix (email instead of emai)
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-06-13 22:10:45 +02:00
Xavier Noria
50df162a2b
explains why AS::OrderedHash does not leverage inheritance
2010-06-13 22:02:29 +02:00
Josiah Ivey
52ed3404bc
Routing guide: Fix path
2010-06-13 10:29:32 -05:00
Neeraj Singh
e574ca920d
render(:inline) in a layout before yield replaces original content
...
[#4777 state:resolved]
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-06-13 13:56:08 +02:00
Santiago Pastorino
b514b4d696
removes spurious .rb in require
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-06-13 13:56:08 +02:00
José Valim
a12079df9f
Tidy up generators based on latest change on AM.
2010-06-13 13:56:08 +02:00
Rohit Arondekar
b7a305f0cb
Rails Guides: AR Querying, .count should be at the end as it returns a number. [ #4811 state:resolved]
2010-06-13 03:05:56 -07:00
Santiago Pastorino
27f337d54f
truncate documentation an examples added for :safe option
2010-06-13 06:11:23 -03:00
Santiago Pastorino
8d1b742979
gems versions bumped up
2010-06-13 05:48:25 -03:00
wycats
3b4a13b7a9
CI changes per Chad's request
2010-06-13 00:06:35 -07:00
Santiago Pastorino
6d19a4a664
Change implementation to do it without asking each time for block_given?
...
Signed-off-by: Xavier Noria <fxn@hashref.com >
2010-06-13 07:27:26 +02:00
Xavier Noria
36143d26cb
revises implementation of AS::OrderedHash#merge!
2010-06-13 06:37:54 +02:00
Xavier Noria
3359af63a5
Revert "hash merging with a block ignores non-existing keys altogether"
...
This reverts commit 72f9fec607 .
It is wrong, this feature is a little undocumented, doing some research.
2010-06-13 05:53:42 +02:00
Xavier Noria
72f9fec607
hash merging with a block ignores non-existing keys altogether
2010-06-13 05:09:31 +02:00
Paul Barry
9183eaebed
re-organized test for merge into separate tests
...
Signed-off-by: Xavier Noria <fxn@hashref.com >
2010-06-13 04:19:35 +02:00
Paul Mucur
58e21a4a0d
Support passing a block to ActiveSupport::OrderedHash's merge and merge! [ #4838 state:committed]
...
For better consistency with Ruby's own Hash implementation.
Signed-off-by: Xavier Noria <fxn@hashref.com >
2010-06-13 04:19:35 +02:00
wycats
a087bc85fd
Revert "Revert "Validators should at model level and not at AR:Base level [ Closes #4804 ]""
...
This reverts commit d675493065 .
2010-06-12 18:48:27 -07:00
Santiago Pastorino
6865b5e4eb
Bump rack-mount version to 0.6.4
2010-06-12 18:47:37 -07:00
Santiago Pastorino
f802eb2f00
require conversions to use String#ord
2010-06-12 18:47:37 -07:00
wycats
d675493065
Revert "Validators should at model level and not at AR:Base level [ Closes #4804 ]"
...
This reverts commit e11bb95d56 .
2010-06-12 18:47:37 -07:00
Xavier Noria
f28d5cfbe6
registers 4146a44 in CHANGELOG
2010-06-12 22:16:57 +02:00
Xavier Noria
d433c504b5
removes spurious .rb in require
2010-06-12 22:10:59 +02:00
David Chelimsky
d588bbd431
Move ActionMailer::TC to AV::TC::Behavior
...
[#4843 state:resolved]
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-06-12 15:34:31 +02:00
rohit
7508c0e9d3
Change sanitize to escape in test names of text_helper_test [ #4844 state:resolved]
2010-06-12 15:34:05 +02:00
José Valim
30eaecb3df
subject is automatically looked up on I18n using mailer_name and action_name as scope as in t('.subject')
2010-06-12 15:33:12 +02:00
José Valim
b308a6030e
Use load_paths on AR benchmarks so it uses the bundler setup instead of system gems.
2010-06-12 10:07:35 +02:00
José Valim
1eecd9483b
No need to call convert_key before except.
2010-06-12 09:54:18 +02:00
José Valim
50ec0d9b2e
Simplify and optimize callbacks superclass sync.
2010-06-12 09:54:18 +02:00
Lawrence Curtis
f0963e2ab0
Create mailers folder when starting a new rails app
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-06-12 09:54:18 +02:00
Damien Mathieu
b5ce2490c1
Test create mailers folder when starting a new app
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-06-12 09:54:18 +02:00
Pratik Naik
9a23a03505
Remove an unused method
2010-06-12 11:54:52 +05:30
Ryan Bigg
f453bb6d8a
There is no type="array" returned with errors. [#3691:resolved]
2010-06-12 12:13:21 +10:00
Jeremy Kemper
be43ad69af
Support ruby 1.8.7 and 1.9.2 (and development versions)
2010-06-11 16:40:04 -07:00
Xavier Noria
f2991fc9cc
Merge remote branch 'docrails/master'
2010-06-12 00:30:48 +02:00
Xavier Noria
b731948bda
AS guide: updates docs on date calculations to reflect a0a6cc2
2010-06-12 00:19:12 +02:00
Geoff Buesing
4146a443b6
Date#since, #ago, #beginning_of_day, #end_of_day, #xmlschema return TimeWithZone when Time.zone_default is set
...
Signed-off-by: Xavier Noria <fxn@hashref.com >
2010-06-12 00:19:12 +02:00
Jeremy Kemper
1a5654851e
Single ruby version requirement message
2010-06-11 11:02:47 -07:00
Jeremy Kemper
acad3ba848
Ruby 1.9.1 compat: constant lookup
2010-06-11 11:00:56 -07:00
Jeremy Kemper
ed61c3b640
Remove String#constantize deps
2010-06-11 10:33:43 -07:00
Jeremy Kemper
cfc9439454
Explicitly delegate Chars#<=> to work around Kernel#<=> possibly ignoring method_missing
2010-06-11 10:03:23 -07:00
José Valim
85cc1fa657
Revert "Don't overwrite unsaved updates when loading an association but preserve the order of the loaded records. [ #4642 state:open]"
...
This commit introduced a regression described in ticket [#4830 ].
This reverts commit 0265c708b9 .
2010-06-11 17:05:54 +02:00
Santiago Pastorino
b4976ce91b
text_helper now escape the unsafe input instead of sanitizing
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-06-11 16:34:53 +02:00
Rizwan Reza
51ad68367a
Added tests for cookies with domain option.
2010-06-11 16:34:53 +02:00
Rizwan Reza
132730d5db
Moved test/controller/cookie_test.rb to test/dispatch/cookies_test.rb
2010-06-11 16:34:53 +02:00
Rizwan Reza
b602ce6191
Refactored duplication into a separate method. Dropped class variable.
2010-06-11 16:34:53 +02:00
Rizwan Reza
6148b2dd73
Adding missing docs to delete cookies with :all which were added that way.
2010-06-11 16:34:53 +02:00
Rizwan Reza
f99132663b
Took out the domain option logic to cookies.rb.
2010-06-11 16:34:52 +02:00
Rizwan Reza
5609149d84
Moved Domain regexp to a constant and added comments.
2010-06-11 16:34:52 +02:00
Rizwan Reza
edbb78d6cc
The previous commit didn't work with complex domains, which is now fixed.
2010-06-11 16:34:52 +02:00
Rizwan Reza
44830ead1c
Add support for multi-subdomain session by setting cookie host in session cookie so you can share session between www.example.com, example.com and user.example.com. [ #4818 state:resolved]
...
This reverts commit 330a89072a .
2010-06-11 16:34:52 +02:00
Xavier Noria
4278e7f2b3
adds missing require for having ActiveSupport::InheritableOptions defined
2010-06-11 15:23:24 +02:00
Xavier Noria
b69a2db952
adds missing require for having ActiveSupport::InheritableOptions defined
2010-06-11 15:20:26 +02:00
Slobodan Kovacevic
5a745575be
Updated all number helpers with :locale option.
2010-06-11 14:04:38 +02:00
Evgeniy Dolzhenko
ed507300f0
Fix minor mistake in activemodel/README
2010-06-11 14:20:30 +04:00
Evgeniy Dolzhenko
ccf9577aee
Fix a bunch of minor spelling mistakes
2010-06-11 14:15:34 +04:00
Xavier Noria
2148e2cc94
grammar fixes
2010-06-11 07:00:08 +02:00
Neeraj Singh
54437f30f7
fixing typo
2010-06-10 21:49:09 -04:00
Pavel Gorbokon
835fd07b48
Fix spelling error in ActiveModel::Conversion docs. [ #4826 state:resolved]
2010-06-11 03:09:27 +03:00
Xavier Noria
6356066006
Merge remote branch 'rails/master'
2010-06-10 22:00:55 +02:00
Xavier Noria
61fc7a4550
abort generation/booting on Ruby 1.9.1
2010-06-10 21:49:45 +02:00
Santiago Pastorino
7cb49f551c
layout 'application' is not anymore on application_controller
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-06-10 20:52:55 +02:00
Chad Fowler
dcc758acb0
detect being inside a rails application even from a subdirectory
...
Signed-off-by: David Heinemeier Hansson <david@loudthinking.com >
2010-06-10 14:16:45 -04:00
José Valim
330a89072a
Revert "Add support for multi-subdomain session by setting cookie host in session cookie so you can share session between www.example.com, example.com and user.example.com. [ #4818 state:resolved]"
...
It does not work for domains like co.uk and com.br.
This reverts commit c4d6245e87 .
2010-06-10 20:08:01 +02:00
Jeff Kreeftmeijer
d93b45e8d3
Rails::Generators::GeneratedAttribute: tests, cleanups and a bugfix [ #4631 state:resolved]
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-06-10 20:04:49 +02:00
Alan Harper
566967eaf3
Missing method error doesn't specify which controller it is missing from [ #4436 state:resolved]
...
The error page shown when the method you are requesting on a controller
doesn't specify which controller the method is missing from
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-06-10 20:04:37 +02:00
José Valim
51590ad175
Remove punctuate_body! No code in lib was using it and it had no documentation.
2010-06-10 19:49:10 +02:00
José Valim
b67ec8ba20
class_attribute is not a direct replacement of class_inheritable_*.
...
If you are setting a hash or an array in class_attribute or you need
to freeze it, to ensure people won't modify it in place or you need
to dup it on inheritance.
2010-06-10 19:39:09 +02:00
Guillermo Álvarez
c4d6245e87
Add support for multi-subdomain session by setting cookie host in session cookie so you can share session between www.example.com, example.com and user.example.com. [ #4818 state:resolved]
...
Signed-off-by: David Heinemeier Hansson <david@loudthinking.com >
2010-06-10 12:05:12 -04:00
Neeraj Singh
e11bb95d56
Validators should at model level and not at AR:Base level [ Closes #4804 ]
...
[#4804 state:resolved]
Signed-off-by: David Heinemeier Hansson <david@loudthinking.com >
2010-06-10 11:50:42 -04:00
Slobodan Kovacevic
59e89facc2
Added :locale option explanation for number_to_currency
2010-06-10 14:58:02 +02:00
David Heinemeier Hansson
983815632c
Cut down even further on rake -T noise
2010-06-09 17:14:53 -04:00
José Valim
211799450d
Ensure show exceptions middleware properly filters backtrace before logging.
2010-06-09 22:49:14 +02:00
David Heinemeier Hansson
fa15111d30
Silence even more noisy rake task docs
2010-06-09 16:39:01 -04:00
David Heinemeier Hansson
29acc17c0f
Cut down on tasks shown in rake -T
2010-06-09 16:19:03 -04:00
David Heinemeier Hansson
c9d156f063
Remove outdated section on web servers that didnt really tell you much anyway
2010-06-09 15:50:48 -04:00
David Heinemeier Hansson
2f398f23d6
Remove needless links and search box and update doc links
2010-06-09 15:47:43 -04:00
David Heinemeier Hansson
5c5b73518a
You dont have to manually mention the application layout, its automatically used
2010-06-09 15:38:06 -04:00
James Le Cuirot
0265c708b9
Don't overwrite unsaved updates when loading an association but preserve the order of the loaded records. [ #4642 state:resolved]
...
Signed-off-by: Pratik Naik <pratiknaik@gmail.com >
2010-06-09 18:17:52 +05:30
Santiago Pastorino
6898c167c3
Make sure about which is the first element of the query, fixes a postgresql 8.4 failing test
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-06-09 10:06:41 +02:00
Santiago Pastorino
5b42acdadd
Should call configure! to initiliaze the application
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-06-09 10:06:34 +02:00
Santiago Pastorino
cfacae1a7d
SQLite2Adapter doesn't exist
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-06-09 10:06:24 +02:00
Santiago Pastorino
0919c0dbca
Removed textilize, textilize_without_paragraph and markdown helpers
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-06-09 10:06:14 +02:00
Neeraj Singh
f48aa14bf4
Better test for ticket [ #3914 state:resolved]
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-06-09 09:51:05 +02:00
wycats
df40dbe6f1
Merge branch 'master' of github.com:rails/rails
2010-06-08 18:10:27 -04:00
wycats
6ebc7c8ee6
Update bundler dependency
2010-06-08 18:10:18 -04:00
José Valim
5c9f27abaa
Add more cases to previous commit [ #4394 state:resolved]
2010-06-08 23:26:51 +02:00
Jan De Poorter
4560385fa4
Make sure namespaces are nested within resources
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-06-08 23:21:53 +02:00
Neeraj Singh
db23a95a61
cache_sweeper yields blank output
...
[#3914 state:open]
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-06-08 23:20:04 +02:00
Brian Durand
2500e6af66
Make logic for after_commit and after_rollback :on option work like it does for validation callbacks.
...
[#2991 state:committed]
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2010-06-08 17:05:29 -04:00
Jeremy Kemper
b070739240
Revert "Temporarily revert "Update after_commit and after_rollback docs and tests to use new style API with an :on options instead of on_* suffix." and "Add after_commit and after_rollback callbacks to ActiveRecord that are called after transactions either commit or rollback on all records saved or destroyed in the transaction.""
...
This reverts commit 1b2941cba1 .
[#2991 ]
2010-06-08 17:05:29 -04:00
Jeremy Kemper
87cc3d5569
Clarify Fixture#key_ and value_list
2010-06-08 17:05:29 -04:00
Xavier Noria
f1c0bcfbb6
Merge remote branch 'docrails/master'
2010-06-08 22:39:30 +02:00
José Valim
e50bf67ffa
Bring pg back.
2010-06-08 22:36:35 +02:00
Emilio Tagua
4b4a548a60
Avoid PostgreSQL and MySQL tests warnings.
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-06-08 22:36:19 +02:00
David Heinemeier Hansson
03be27092b
Revert "Add shallow routes to the new router" for now. Needs more work.
...
This reverts commit 67a60ee314 .
2010-06-08 16:20:46 -04:00
Andrew Bloomgarden
0e9b9d5985
Fix ActiveRecord::Base.compute_type swallowing NoMethodError. [ #4751 state:resolved]
...
Signed-off-by: David Heinemeier Hansson <david@loudthinking.com >
2010-06-08 15:34:47 -04:00
David Chelimsky
bdcf70cca8
Memoize the object returned by _view in ActionView::TestCase::Behavior
...
[#4799 state:resolved]
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-06-08 21:25:31 +02:00
Xavier Noria
751f79a033
Merge remote branch 'rails/master'
2010-06-08 21:23:29 +02:00
Emilio Tagua
ab2877cbe8
Add parentheses to avoid warnings when running AR tests.
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-06-08 21:16:19 +02:00
Emilio Tagua
d103c73d95
Bump Arel to 0.4.0
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-06-08 20:59:14 +02:00
Jeremy Kemper
1b2941cba1
Temporarily revert "Update after_commit and after_rollback docs and tests to use new style API with an :on options instead of on_* suffix." and "Add after_commit and after_rollback callbacks to ActiveRecord that are called after transactions either commit or rollback on all records saved or destroyed in the transaction."
...
This reverts commits d2a49e4b1f and da840d13da .
[#2991 ]
Conflicts:
activerecord/CHANGELOG
activerecord/lib/active_record/transactions.rb
activerecord/test/cases/transaction_callbacks_test.rb
2010-06-08 14:56:08 -04:00
David Heinemeier Hansson
32d4330b81
Get ready for beta 4
2010-06-08 14:47:02 -04:00
David Heinemeier Hansson
585f8f27b1
Fixed double output from cache in no caching mode
2010-06-08 14:47:02 -04:00
Aaron Patterson
eb69721c9b
forcing encoding on 1.9 when dealing with "binary" columns [ #4612 state:resolved]
...
Signed-off-by: wycats <wycats@gmail.com >
2010-06-08 14:33:28 -04:00
wycats
6b49a71ab7
Missing require restored
2010-06-08 14:24:35 -04:00
José Valim
68b4720fd1
Accept both regexps and strings for LOCALHOST.
2010-06-08 20:11:05 +02:00
Xavier Noria
e7e6ee3e7b
AS guide: documents datetime calculations
2010-06-08 20:10:39 +02:00
wycats
068f8d6e85
Require encoding.rb
2010-06-08 14:09:34 -04:00
Prem Sichanugrist
c6ad64394b
Make sure that rails recognized the full notation of IPv6 loopback address, and recognize 127.0.0.0/8 in IPv4
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-06-08 19:45:40 +02:00
Andrew White
a7edddf605
Fix resources ignoring scope options
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-06-08 19:33:27 +02:00
rohit
47bf19c848
Made markdown honor :safe option and handle safe input. Also added tests for markdown.
...
[#4794 state:resolved]
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-06-08 17:00:11 +02:00
José Valim
9d33c2ab6f
Fix generator test broken when rails new was added.
2010-06-08 16:05:19 +02:00
José Valim
aa8b56f5d6
Hide remaining generators hooks [ #4790 state:resolved]
2010-06-08 16:01:11 +02:00
Andrew White
4740fbac85
Add support for actions on a new resource to the new routing DSL [ #4328 state:resolved]
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-06-08 09:11:39 +02:00
rohit
67f411c57b
Fixed textilize_without_paragraph and added tests for it. [ #4792 state:resolved]
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-06-08 09:11:34 +02:00
Ernie Miller
a4eaa1fd39
Fix multiple self-referencing eager loads failing to join multiple times
...
[#4679 state:committed]
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2010-06-08 01:02:19 -04:00
Mikel Lindsaar
e404490f9b
Merge branch 'master' of git://github.com/rails/rails
2010-06-08 00:10:11 -04:00
wycats
8d576b51a1
Move the undef into the 1.9 only branch
2010-06-07 23:32:20 -04:00
Mikel Lindsaar
80a044edb6
Updating ActionMailer basics guide to have inline attachments
2010-06-07 23:25:49 -04:00
Mikel Lindsaar
3762362eab
Updating readme for ActionMailer::Base
2010-06-07 23:14:54 -04:00
wycats
b97a3f33a3
Merge remote branch 'rsim/oracle_enhanced_rails3'
2010-06-07 23:03:59 -04:00
wycats
0042f4166f
If we undef <=>, it solves a problem involving comparison. Please figure out the root cause.
2010-06-07 22:31:42 -04:00
Mikel Lindsaar
311d99eef0
Adding inline attachment support to ActionMailer
2010-06-07 21:54:53 -04:00
Mikel Lindsaar
21cc1ed437
Updating image_tag to support cid:content_id "URLs"
2010-06-07 21:53:31 -04:00
Santiago Pastorino and José Ignacio Costa
100f8b2dfc
update docs before_validation_on_create => before_validation(:on => :create)
2010-06-07 22:21:28 -03:00
Santiago Pastorino
94ed39d146
This test shouldn't rely on the order of the data returned by select
...
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2010-06-07 20:06:31 -04:00
Diego Carrion
67a60ee314
Add shallow routes to the new router [ Closes #3765 ]
2010-06-07 18:09:20 -05:00
José Valim
a04060fb6f
Really make include_root_in_json default to true [ #3770 state:resolved]
2010-06-08 01:02:45 +02:00
Mikel Lindsaar
a16fd96131
Merge branch 'master' of git://github.com/rails/rails
2010-06-07 18:30:18 -04:00
wycats
d6953cbfd3
regular expressions are usually ASCII-encoded, so force_encoding the content of a Node to the encoding of the regular expression is wrong.
2010-06-07 18:06:08 -04:00
José Valim
a210aff210
Add delete to middleware stack proxy.
2010-06-07 23:17:23 +02:00
José Valim
981f81275b
Fix case when rendering a partial inside RJS with inherited layout [ #4786 state:resolved]
2010-06-07 22:22:54 +02:00
Mikel Lindsaar
50031bf932
Updating ActionMailer to Mail 2.2.2 (fixing two tests to suit)
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-06-07 21:36:56 +02:00
Santiago Pastorino
ab764ecbfe
Makes text_helper methods sanitize the input if the input is not safe or :safe => true option is not provided
2010-06-07 15:31:21 -04:00
Santiago Pastorino
399b493cb4
content_tag_string shouldn't escape_html if escape param is false
2010-06-07 15:31:11 -04:00
Mikel Lindsaar
735027e58d
Updating ActionMailer to Mail 2.2.2 (fixing two tests to suit)
2010-06-07 15:30:08 -04:00
wycats
eebac02606
Make named helpers unprotected without becoming actions [ #4696 state:resolved]
2010-06-07 15:29:55 -04:00
Rizwan Reza
3adb395da4
Fixed Load Error failures in 1.9.2-head
2010-06-07 14:53:37 -04:00
Xavier Noria
73d8bf245c
getting started guide: mentions that last REE release does not have the bugs of MRI p248 and p249
2010-06-07 16:42:55 +02:00
Xavier Noria
9ff61917a3
getting started guide: mentions that last REE release does not have the bugs of MRI p248 and p249
2010-06-07 16:27:28 +02:00
Santiago Pastorino
ed16ec6344
bump sqlite version to 1.3.0
...
Signed-off-by: Xavier Noria <fxn@hashref.com >
2010-06-07 16:10:55 +02:00
Xavier Noria
9e065c6bc1
Merge remote branch 'rails/master'
2010-06-07 15:44:57 +02:00
José Valim
1a8f784a23
member on resource should not expect an ID.
2010-06-07 11:20:54 +02:00
José Valim
634c9310e3
Make the logic for nested_records_changed_for_autosave? simpler.
...
[#4648 state:resolved]
2010-06-07 11:01:10 +02:00
Carlos Antonio da Silva
7eedc3f397
Fixing test class names and refactor line in autosave association
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-06-07 10:45:47 +02:00
Tom Meier
3f1cdb85b8
Require active support/string/conversions so constantize can be used in associations.rb
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-06-07 10:29:26 +02:00
José Valim
5273bd97e6
Make AP test suite green once again and speed up performance in layouts lookup for some cases.
2010-06-07 10:13:41 +02:00
Santiago Pastorino
b3d2080278
Observing module is using constantize
2010-06-06 22:42:28 -07:00
Xavier Noria
8c7730db02
oops, two cancelling errors made a previous test pass, fixing it
2010-06-07 07:27:51 +02:00
Xavier Noria
d96efe6368
the order in which we apply deltas in Date#advance matters, add test coverage for that
2010-06-07 06:59:09 +02:00
Rizwan Reza
ac9f8e1b7b
Router accepts member routes on resource. [ #4624 state:resolved]
2010-06-06 21:27:52 -04:00
Jeremy Kemper
83729e2fe3
Formats should always be an array.
2010-06-06 19:59:52 -04:00
Jeremy Kemper
9f93de9d3d
Reset request.parameters after assigning params for functional tests
2010-06-06 12:07:40 -07:00
Xavier Noria
0dbc732995
AS guide: first complete draft covering date/calculations.rb
2010-06-06 18:26:42 +02:00
Jeremy Kemper
509f3d7d2f
Simplify middleware stack lazy compares using named const references
2010-06-05 22:09:16 -07:00
Jeremy Kemper
9d0d6f7d26
Clear const references all at once
2010-06-05 22:08:02 -07:00
Jeremy Kemper
fd1a504136
ActiveSupport::Dependencies.constantize shortcut for caching named constant lookups
2010-06-05 22:05:58 -07:00
Jeremy Kemper
35ae42be4f
Bump i18n to 0.4.1
2010-06-05 22:05:58 -07:00
Jeremy Kemper
7ace23abac
Restore flash sweep
2010-06-05 22:05:57 -07:00
Jeremy Kemper
a5f3f3ef7a
MySQL: require 2.7 or later so we can rely on result.each_hash
2010-06-05 14:59:51 -07:00
wycats
a6b3942843
Optimize LookupContext
2010-06-04 20:11:06 -07:00
wycats
16ee4b4d1b
Small optimization of 1.9 unescape. We should make sure that inbound ASCII always means UTF-8. It seems so based on a quick survey of common browsers, but let's be sure
2010-06-04 20:11:06 -07:00
wycats
b8af484476
No need to unescape params twice if we came from Rack::Mount
2010-06-04 20:11:06 -07:00
wycats
ff4c218095
Memoizing methods on request means we need to clear them out on recycle!
2010-06-04 20:11:05 -07:00
wycats
cb1b2a719a
Stop the flash middleware from forcibly loading sessions even if the user doesn't use sessions at all
2010-06-04 20:11:05 -07:00
wycats
a260e02fd3
Whoops. _run_*_callbacks is private
2010-06-04 20:11:05 -07:00
wycats
67a2d648d8
Improve performance of the Logger middleware by using simpler versions of methods
2010-06-04 20:11:05 -07:00
wycats
8b05c5207d
Improve performance of MessageVerifier while keeping it constant time
2010-06-04 20:11:05 -07:00
wycats
5fa3a2d123
Improve performance of the log subscriber by remembering the list of all loggers instead of trying to extract them each time
2010-06-04 20:11:05 -07:00
wycats
220603ee70
Eliminate the need to check for superclass changes to the callback stack each time through the callbacks
2010-06-04 20:11:05 -07:00
wycats
a87b627297
Use faster form of running callbacks
2010-06-04 20:11:05 -07:00
wycats
ab1407cc5b
Improve performance of commonly used request methods
2010-06-04 20:11:04 -07:00
Jeremy Kemper
bd9805871b
Include backtrace in failsafe log. Rescue possible exceptions in failsafe response.
2010-06-04 18:25:32 -07:00
Rizwan Reza
55a5c7068c
Readme file changes:
...
* Took out stuff that's not relevant (or useful) anymore.
* Some formatting.
* Added helpful links to get started with Rails.
* Took out Apache htaccess tutorial since we aren't teaching Apache here.
2010-06-05 04:26:01 +04:30
Rizwan Reza
e6f2102178
Merge branch 'master' of git://github.com/rails/rails
2010-06-05 04:04:49 +04:30
Matt Di Pasquale
1535b02a9f
Improve Rails README [ #4740 state:resolved]
...
Signed-off-by: Rizwan Reza <rizwanreza@gmail.com >
2010-06-05 04:04:08 +04:30
Xavier Noria
8e8cb1769f
AS guide: removes your spurious line
2010-06-05 01:19:23 +02:00
Xavier Noria
67a43554f1
removes Array#random_element and backports Array#sample from Ruby 1.9, thanks to Marc-Andre Lafortune
2010-06-05 01:15:17 +02:00
Mikel Lindsaar
6401ab5870
Missed fixing the banner on the Usage output for Thor
...
Signed-off-by: David Heinemeier Hansson <david@loudthinking.com >
2010-06-04 17:46:57 -05:00
Raimonds Simanovskis
acef8feafa
compare sorted arrays in relations_test
...
Oracle does not guarantee that SELECT will return records ordered by primary key
2010-06-04 22:58:55 +03:00
Raimonds Simanovskis
c51fa6bdfc
ignore raw_sql_ table alias that is used by Oracle adapter
2010-06-04 22:44:04 +03:00
Raimonds Simanovskis
b0fdd290f4
fix test_belongs_to_with_primary_key_joins_on_correct_column test on Oracle
2010-06-04 22:44:04 +03:00
Raimonds Simanovskis
edf79a7fe7
Downcase quoted table name in regex in count_aliases_from_table_joins
...
Oracle adapter's quote_table_name returns quoted table name in uppercase and therefore it should be downcased before scanning downcased join_sql
2010-06-04 22:44:03 +03:00
Raimonds Simanovskis
05ef038bb9
Fixed adapter tests not to assert LIMIT and OFFSET in SQL strings
...
Fixed adapter test cases that were failing in oracle because the asserts were looking for the presence of offset and limit which are not available in oracle. Changed the tests to check that the sql injection is not present in the output so that the tests are database adapter agnostic.
2010-06-04 22:44:03 +03:00
Raimonds Simanovskis
c6d6b50166
ignore selects from data dictionary views when running tests on Oracle
2010-06-04 22:44:03 +03:00
Raimonds Simanovskis
5fcaf91761
fix conditions when DateTime#to_date and DateTime#xmlschema methods are defined
2010-06-04 22:44:03 +03:00
Raimonds Simanovskis
a82e067091
assert log output match in case insensitive mode to avoid failure when quoted table name is in uppercase (when using Oracle)
2010-06-04 22:44:03 +03:00
Raimonds Simanovskis
a83e6b1b6a
downcase table names in aliased_table_name_for and references_eager_loaded_tables? methods (as Oracle quoted table names are in uppercase)
2010-06-04 22:44:03 +03:00
Raimonds Simanovskis
464b7f3ddc
test fixes for Oracle enhanced adapter:
...
latest oracle_enhanced adapter does automatic shortening of index names
ignore select from all_triggers table in assert_queries
2010-06-04 22:44:03 +03:00
Raimonds Simanovskis
9bf7b6334f
do order by id when finding first fixture to ensure that it is correct one
...
(as otherwise was failing under JRuby and oracle_enhanced adapter)
2010-06-04 22:44:02 +03:00
Raimonds Simanovskis
f12f377680
Oracle enhanced adapter now supports shortening of default generated index names, some additional tests now pass
2010-06-04 22:44:02 +03:00
Raimonds Simanovskis
6356a48faa
Reduced size of table name prefix and suffix in migrations test as in Oracle identifier name cannot be larger than 30 characters
2010-06-04 22:44:02 +03:00
Raimonds Simanovskis
8136230cca
Explicitly set Topic model last_read attribute as Date value when Oracle enhanced adapter is used
...
(otherwise some tests are failing which assume that this attribute will have Date value)
2010-06-04 22:44:02 +03:00
Raimonds Simanovskis
eec90bab28
create DateTime value with local offset as later it is compared to Time value with local offset
...
(otherwise test is failing for oracle_enhanced JDBC adapter)
2010-06-04 22:44:02 +03:00
Mikel Lindsaar
bf83c5709f
Updating guides to new rails initialization process
...
Signed-off-by: David Heinemeier Hansson <david@loudthinking.com >
2010-06-04 12:31:46 -05:00
Mikel Lindsaar
4774680405
Changing command line API from 'rails blog' to 'rails new blog'.
...
Also removed the limitation of not being able to call your new server any of
the rails commands (generate, server, dbconsole, console etc) as there is
no longer any ambiguity here.
http://rails.lighthouseapp.com/projects/8994/tickets/4665
Signed-off-by: David Heinemeier Hansson <david@loudthinking.com >
2010-06-04 12:30:03 -05:00
Mikel Lindsaar
4d23bdb04f
Missed fixing the banner on the Usage output for Thor
2010-06-04 16:36:38 +10:00
Pratik Naik
517f709b51
Properly cache association_collection#scopes calls having arguments
2010-06-04 00:53:45 +01:00
Mikel Lindsaar
54249b549b
Updating guides to new rails initialization process
2010-06-04 00:03:42 +10:00
Mikel Lindsaar
06892c3421
Changing command line API from 'rails blog' to 'rails new blog'.
...
Also removed the limitation of not being able to call your new server any of
the rails commands (generate, server, dbconsole, console etc) as there is
no longer any ambiguity here.
http://rails.lighthouseapp.com/projects/8994/tickets/4665
2010-06-03 23:47:44 +10:00
Mikel Lindsaar
ab34b7bde1
Merge branch 'master' of github.com:mikel/rails
2010-06-03 23:39:02 +10:00
José Valim
ee58876fcc
Add an asset_host accessor for consistency.
2010-06-03 23:32:12 +10:00
David Heinemeier Hansson
4a6290bb38
Missed the extraction
2010-06-03 23:32:12 +10:00
David Heinemeier Hansson
08baa343c8
Extract assets paths and make them available to Action Mailer as well
2010-06-03 23:32:12 +10:00
wycats
e57dbfe6af
Changes made while working on upgrading cells to Rails 3
2010-06-03 23:32:12 +10:00
Pratik Naik
a9753637f4
Special treatement for Relation#select { with block }
2010-06-03 23:32:12 +10:00
José Valim
8aca1c09db
Configure generators before invoking.
2010-06-03 23:32:12 +10:00
José Valim
44cb6dce62
Still copy application configuration to generator even if they are required earlier. Also tidy up the guide a little bit.
2010-06-03 23:32:12 +10:00
Xavier Noria
a73d6e7913
AS guide: documents String#truncate
2010-06-03 23:32:12 +10:00
eparreno
943c60d2e8
AR validations & callbacks: update callbacks list
2010-06-03 23:32:11 +10:00
eparreno
62fd6d8c59
add <%= to fields_for examples
2010-06-03 23:32:11 +10:00
Xavier Noria
f1fa3a3558
revises the documentation of String#truncate and the truncate helper
2010-06-03 23:32:11 +10:00
José Valim
83a58e0660
Add lib to load paths when application is inherited to be able to load lib code during configuration.
2010-06-03 23:32:11 +10:00
wycats
53efdc2eef
Update CHANGELOG
2010-06-03 23:32:11 +10:00
David Heinemeier Hansson
a22da40ac7
You need the ruby-debug available in your Gemfile for debugger to work
2010-06-03 23:32:11 +10:00
Xavier Noria
7edc6b00da
revises rdoc of AMo::Error#add [ #4738 state:resolved]
2010-06-03 23:32:11 +10:00
Santiago Pastorino
52f905715e
Unforce text-format from AM
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-06-03 23:32:11 +10:00
Santiago Pastorino
f50928db9c
Unforce memcache from AS
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-06-03 23:32:11 +10:00
Santiago Pastorino
9a53e02027
Unforce builder from AS
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-06-03 23:32:11 +10:00
Santiago Pastorino
c8e2ec07a2
Unforce tzinfo from AS
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-06-03 23:32:11 +10:00
David Heinemeier Hansson
bd7a27ac6b
Extracted String#truncate from TextHelper#truncate [DHH]
2010-06-03 23:32:11 +10:00
David Heinemeier Hansson
19d1d42daf
Base options cant live in lazy loaded helpers as they then wont be available to set for config
2010-06-03 23:32:10 +10:00
Santiago Pastorino
de50ba2238
Unforce i18n from AS
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-06-03 23:32:10 +10:00
Santiago Pastorino
f29a8a3f6e
rack-test version updated and removed from Gemfile
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-06-03 23:32:10 +10:00
José Valim
c3be207ee8
Add :only and :except to controllers MiddlewareStack. This allows
...
you to do the following:
class PostsController < ApplicationController
use AutheMiddleware, :except => [:index, :show]
end
2010-06-03 23:32:10 +10:00
wycats
fad29012af
Update template to allow handlers to more cleanly handle encodings (ht: nex3)
2010-06-03 23:32:10 +10:00
José Valim
2740943634
Remove the laziness from the middleware stack.
2010-06-03 23:32:10 +10:00
wycats
27939bd753
Now that we always return a proxy from mb_chars, even in 1.9, all Strings coming back from AS are UTF-8.
2010-06-03 23:32:10 +10:00
Santiago Pastorino
10f82fd5fa
fix translation test in actionpack [ #4701 state:commited]
...
Signed-off-by: wycats <wycats@gmail.com >
2010-06-03 23:32:10 +10:00
wycats
ed34652d1a
Removing Metal from Rails 3.
...
If you have existing Metals, you have a few options:
* if your metal behaves like a middleware, add it to the
middleware stack via config.middleware.use. You can use
methods on the middleware stack to control exactly where
it should go
* if it behaves like a Rack endpoint, you can link to it
in the router. This will result in more optimal routing
time, and allows you to remove code in your endpoint
that matches specific URLs in favor of the more powerful
handling in the router itself.
For the future, you can use ActionController::Metal to get
a very fast controller with the ability to opt-in to specific
controller features without paying the penalty of the full
controller stack.
Since Rails 3 is closer to Rack, the Metal abstraction is
no longer needed.
2010-06-03 23:32:10 +10:00
Mislav Marohnić
e6b0ea3f8a
fix reset_counters to work even with complex class names
...
e.g. it guesses that a belongs_to association to Namespace::MyModel is
named "my_model", unlike before where it would look up an association
named "namespace::mymodel" and fail.
2010-06-03 23:32:10 +10:00
Mislav Marohnić
4ab47f5420
move counter_cache tests to a separate file and refactor
2010-06-03 23:32:10 +10:00
Mislav Marohnić
d2ec9fd397
cleanup update/reset_counters: less SQL strings, more ActiveRecord/Arel
2010-06-03 23:32:09 +10:00
Mislav Marohnić
533b1311b0
avoid auto_linking already linked emails; more robust detection of linked URLs
...
References #1523 [#1862 state:resolved] [#3591 state:resolved]
Add test that shows how link text can contain HTML if needed:
the trick is using block form in combination with `raw`.
Let link text be automatically HTML-escaped
[#2017 state:resolved]
2010-06-03 23:32:09 +10:00
Mislav Marohnić
f00561e0f1
auto_link: support arbitrary URI schemes like "ftp:" and "file:"
...
recognizes all URI scheme allowed characters, such as colon and period.
[#3494 state:resolved]
2010-06-03 23:32:09 +10:00
Gonçalo Silva
884716564c
performance and integration tests inherit from AD, not AC
...
Signed-off-by: wycats <wycats@gmail.com >
2010-06-03 23:32:09 +10:00
José Valim
99f8c148f0
Use I18n 0.4.0
2010-06-03 23:32:09 +10:00
David Chelimsky
d6fec21d1a
In AV::TC, move protect_against_forgery? from the test_case to the
...
_helper module included in the view.
- ensures that protect_against_forgery? is present when a helper
included in a partial that is rendered by the template under test
calls it (which happens in FormTagHelper#extra_tags_for_form, for
example).
[#4700 state:resolved]
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-06-03 23:32:09 +10:00
David Chelimsky
70dca37cfd
reorganize tests for AV::TC
...
- decouple tests from the test case class by moving them outside
- split out more TestCase subs as cleaner way of avoiding bleed of
class level concepts
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-06-03 23:32:09 +10:00
Elomar França
15b0947579
Adding to_key to ActiveResource objects using ActiveModel::Conversion [ #4685 state:resolved]
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-06-03 23:32:09 +10:00
Josiah Ivey
24ac08fd68
Form Helpers guide: Use new syntax for fields_for examples
2010-06-03 23:32:09 +10:00
David Chelimsky
e09e0a073b
fix small doc bug about running single unit test files
2010-06-03 23:32:08 +10:00
jacortinas
9e8de7d9bc
A small rdoc change made on lines 39 and 41 on activesupport/lib/active_support/core_ext/object/to_param.rb. It looks like the method name might have been changed, and the comments were never changed to coincide with the new method name.
2010-06-03 23:32:08 +10:00
Ryan Bigg
22a32f4dd6
Cover more of the Rails initialization process, regarding the internals of YourApp::Application inheritance from Rails::Application and more.
2010-06-03 23:32:08 +10:00
Jaime Iniesta
8ce954d855
Fixed XHTML on activerecord_validation_callbacks guide
2010-06-03 23:32:08 +10:00
Jaime Iniesta
d5e97070bd
Added info about guides validation to Contribute guide
2010-06-03 23:32:08 +10:00
Jaime Iniesta
ee71f747f2
Fixed minor typo on credits
2010-06-03 23:32:08 +10:00
Jaime Iniesta
14602b1648
New rake validate_guides task to validate output/*.html against the W3C Validator
2010-06-03 23:32:08 +10:00
Rohit Arondekar
464ebb7d4a
Getting Started, don't forget to link to yourself if you are adding to the changelog.
2010-06-03 23:32:08 +10:00
Rohit Arondekar
e3b04f3ce9
Minor typo fix in callbacks.rb of abstract_controller
2010-06-03 23:32:08 +10:00
David Heinemeier Hansson
3a066e81b3
Merge branch 'master' of github.com:rails/rails
2010-06-02 16:56:24 -05:00
David Heinemeier Hansson
4aac5fd711
Missed the extraction
2010-06-02 16:55:07 -05:00
José Valim
71375c8936
Add an asset_host accessor for consistency.
2010-06-02 14:53:56 -07:00
David Heinemeier Hansson
631dc61885
Extract assets paths and make them available to Action Mailer as well
2010-06-02 16:49:02 -05:00
David Heinemeier Hansson
942fe6514c
Merge branch 'master' of github.com:rails/rails
2010-06-02 16:18:03 -05:00
David Heinemeier Hansson
02512914ae
You need the ruby-debug available in your Gemfile for debugger to work
2010-06-02 16:17:05 -05:00
wycats
ffe001f19d
Changes made while working on upgrading cells to Rails 3
2010-06-02 22:56:41 +02:00
eparreno
344a695383
AR validations: update sections 2.4 and 17.1
2010-06-02 21:43:37 +02:00
eparreno
785caba866
Routing: fix error in nested resources with name_prefix example [ #146 state:resolved]
2010-06-02 21:14:33 +02:00
wycats
26c5680bd0
Merge branch 'master' of github.com:rails/rails
2010-06-02 15:53:10 +02:00
Pratik Naik
4b91daff13
Special treatement for Relation#select { with block }
2010-06-02 14:42:25 +01:00
José Valim
0570720d66
Configure generators before invoking.
2010-06-02 09:37:38 +02:00
José Valim
afc1026986
Still copy application configuration to generator even if they are required earlier. Also tidy up the guide a little bit.
2010-06-02 08:45:33 +02:00
Josiah Ivey
3633cb8541
Revert "Guides: Give code container a proper bottom margin"
...
This reverts commit 4b71fc22ca .
2010-06-01 23:23:46 -05:00
Josiah Ivey
4b71fc22ca
Guides: Give code container a proper bottom margin
2010-06-01 23:14:58 -05:00
Xavier Noria
fdd203f964
Merge remote branch 'docrails/master'
2010-06-02 01:35:43 +02:00
Xavier Noria
315e8952df
revises the documentation of String#truncate and the truncate helper
2010-06-02 01:35:04 +02:00
José Valim
5a0d73f17c
Add lib to load paths when application is inherited to be able to load lib code during configuration.
2010-06-02 00:48:16 +02:00
Xavier Noria
158473f0d1
AS guide: documents String#truncate
2010-06-02 00:28:23 +02:00
David Heinemeier Hansson
cae2519900
Merge branch 'master' of github.com:rails/rails
2010-06-01 16:39:05 -05:00
David Heinemeier Hansson
d57397c4b6
Extracted String#truncate from TextHelper#truncate [DHH]
2010-06-01 16:38:42 -05:00
Xavier Noria
a0bb1dda11
revises rdoc of AMo::Error#add [ #4738 state:resolved]
2010-06-01 15:44:14 +02:00
Santiago Pastorino
0cc4cd020d
Unforce text-format from AM
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-06-01 12:06:47 +02:00
Santiago Pastorino
57144388f0
Unforce memcache from AS
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-06-01 10:46:05 +02:00
Santiago Pastorino
31e1445a81
Unforce builder from AS
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-06-01 10:45:51 +02:00
Santiago Pastorino
0bed93be25
Unforce tzinfo from AS
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-06-01 09:16:19 +02:00
David Heinemeier Hansson
ea037ff557
Base options cant live in lazy loaded helpers as they then wont be available to set for config
2010-05-31 13:48:47 -05:00
Santiago Pastorino
1854209bb3
Unforce i18n from AS
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-05-31 12:56:25 +02:00
Santiago Pastorino
f5104caf3b
rack-test version updated and removed from Gemfile
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-05-31 11:26:47 +02:00
eparreno
82f67586b2
AR validations & callbacks: update callbacks list
2010-05-31 10:37:13 +02:00
José Valim
9a93844aba
Add :only and :except to controllers MiddlewareStack. This allows
...
you to do the following:
class PostsController < ApplicationController
use AutheMiddleware, :except => [:index, :show]
end
2010-05-30 15:53:14 +02:00
wycats
b870daba5f
Update CHANGELOG
2010-05-30 12:11:50 +02:00
wycats
0078df6b54
Update template to allow handlers to more cleanly handle encodings (ht: nex3)
2010-05-30 11:37:35 +02:00
José Valim
19d8c8cbe4
Remove the laziness from the middleware stack.
2010-05-29 22:29:46 +02:00
wycats
d7f6f2b596
Now that we always return a proxy from mb_chars, even in 1.9, all Strings coming back from AS are UTF-8.
2010-05-29 21:20:52 +02:00
Santiago Pastorino
e5a56eb297
fix translation test in actionpack [ #4701 state:commited]
...
Signed-off-by: wycats <wycats@gmail.com >
2010-05-29 21:12:28 +02:00
wycats
45e60283e7
Removing Metal from Rails 3.
...
If you have existing Metals, you have a few options:
* if your metal behaves like a middleware, add it to the
middleware stack via config.middleware.use. You can use
methods on the middleware stack to control exactly where
it should go
* if it behaves like a Rack endpoint, you can link to it
in the router. This will result in more optimal routing
time, and allows you to remove code in your endpoint
that matches specific URLs in favor of the more powerful
handling in the router itself.
For the future, you can use ActionController::Metal to get
a very fast controller with the ability to opt-in to specific
controller features without paying the penalty of the full
controller stack.
Since Rails 3 is closer to Rack, the Metal abstraction is
no longer needed.
2010-05-29 20:08:00 +02:00
Michael Koziarski
564ab4776c
Merge commit 'mislav/counter_cache'
2010-05-29 14:06:02 +12:00
Michael Koziarski
668f7dd5d0
Merge commit 'mislav/auto_link'
2010-05-29 14:05:56 +12:00
Gonçalo Silva
d21aa6de4f
performance and integration tests inherit from AD, not AC
...
Signed-off-by: wycats <wycats@gmail.com >
2010-05-28 23:53:03 +02:00
eparreno
6330e2af11
add <%= to fields_for examples
2010-05-28 16:46:12 +02:00
José Valim
f1ae0321fa
Use I18n 0.4.0
2010-05-27 23:50:34 +02:00
Xavier Noria
ddec74fb3a
Merge remote branch 'rails/master'
2010-05-27 10:57:05 +02:00
David Chelimsky
e02db06ece
In AV::TC, move protect_against_forgery? from the test_case to the
...
_helper module included in the view.
- ensures that protect_against_forgery? is present when a helper
included in a partial that is rendered by the template under test
calls it (which happens in FormTagHelper#extra_tags_for_form, for
example).
[#4700 state:resolved]
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-05-26 15:59:03 +02:00
David Chelimsky
9ae7e93920
reorganize tests for AV::TC
...
- decouple tests from the test case class by moving them outside
- split out more TestCase subs as cleaner way of avoiding bleed of
class level concepts
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-05-26 15:58:53 +02:00
Elomar França
7bd30b9585
Adding to_key to ActiveResource objects using ActiveModel::Conversion [ #4685 state:resolved]
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-05-26 15:57:27 +02:00
David Chelimsky
163152bfd0
Support configuration of controller.controller_path on instances of
...
ActionView::TestCase::TestController without stubs. Just say:
@controller.controller_path = "path/i/need/for/this/test"
[#4697 state:resolved]
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-05-26 08:49:57 +02:00
Xavier Noria
e3549a8054
get railties/README back to the home page of the API
2010-05-25 17:26:01 +02:00
Josiah Ivey
96e2094b8b
Form Helpers guide: Use new syntax for fields_for examples
2010-05-25 08:03:04 -05:00
David Chelimsky
0855e04044
fix small doc bug about running single unit test files
2010-05-25 19:14:11 +10:00
jacortinas
6602fb62a0
A small rdoc change made on lines 39 and 41 on activesupport/lib/active_support/core_ext/object/to_param.rb. It looks like the method name might have been changed, and the comments were never changed to coincide with the new method name.
2010-05-25 19:09:11 +10:00
Ryan Bigg
2a833d7bd8
Cover more of the Rails initialization process, regarding the internals of YourApp::Application inheritance from Rails::Application and more.
2010-05-25 19:07:55 +10:00
Santiago Pastorino
78fffac668
Fix test incorrectly using a bare assert to use assert_kind_of
...
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2010-05-24 20:59:53 -07:00
Santiago Pastorino
47d568ed3f
Refactor calculation test to remove unneeded SQLite special case.
...
[#4633 ]
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2010-05-24 20:54:38 -07:00
Jeremy Kemper
f53a6d8149
i18n: t() handles single keys returning an Array, also
2010-05-24 20:30:21 -07:00
Jeremy Kemper
d8d38bedfd
HTML safety: fix textarea with nil content
2010-05-24 20:18:25 -07:00
Santiago Pastorino
b5f9c8822d
translate method doesn't support arrays anymore and is optimized to be used with strings or symbols
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-05-24 23:42:20 +02:00
Santiago Pastorino
2b8eb5404e
Revert "translation method for arrays on TranslationHelper module returns an array where values for keys of the form (.|_)html keys are html_safe"
...
This reverts commit 05c95b5c58 .
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-05-24 23:41:55 +02:00
David Chelimsky
8e583b69e8
Move AV::TC to AV::TC::Behavior [ #4678 state:resolved]
...
- enables alternative testing frameworks to include AV::TC::Behavior
instead of subclassing AV::TC
- also added tests and code for:
- test view delegates :notice to request.flash
- useful since generators generate views that use notice
- test case doesn't try to include modules that are actually
classes
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-05-24 22:58:46 +02:00
Santiago Pastorino
05c95b5c58
translation method for arrays on TranslationHelper module returns an array where values for keys of the form (.|_)html keys are html_safe
...
[#4675 ]
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-05-24 20:12:43 +02:00
Jaime Iniesta
844b195292
Fixed XHTML on activerecord_validation_callbacks guide
2010-05-24 19:00:37 +02:00
Jaime Iniesta
d85b3ef3c1
Added info about guides validation to Contribute guide
2010-05-24 18:30:47 +02:00
Jaime Iniesta
781692d583
Fixed minor typo on credits
2010-05-24 18:12:24 +02:00
Jaime Iniesta
3391cb903e
Merge branch 'w3c_validator'
2010-05-24 18:07:48 +02:00
Jaime Iniesta
7db557f152
New rake validate_guides task to validate output/*.html against the W3C Validator
2010-05-24 18:07:08 +02:00
José Valim
59d1c418be
Fix a bug where responders were not working properly on method override.
2010-05-24 13:12:40 +02:00
Mislav Marohnić
bc84bd17d1
fix reset_counters to work even with complex class names
...
e.g. it guesses that a belongs_to association to Namespace::MyModel is
named "my_model", unlike before where it would look up an association
named "namespace::mymodel" and fail.
2010-05-24 11:44:53 +02:00
Mislav Marohnić
bfca7d744d
move counter_cache tests to a separate file and refactor
2010-05-24 11:42:03 +02:00
Mislav Marohnić
f493f31533
cleanup update/reset_counters: less SQL strings, more ActiveRecord/Arel
2010-05-24 11:42:03 +02:00
Mislav Marohnić
8f0b2138ee
avoid auto_linking already linked emails; more robust detection of linked URLs
...
References #1523 [#1862 state:resolved] [#3591 state:resolved]
Add test that shows how link text can contain HTML if needed:
the trick is using block form in combination with `raw`.
Let link text be automatically HTML-escaped
[#2017 state:resolved]
2010-05-24 11:25:24 +02:00
Mislav Marohnić
133ada6ab0
auto_link: support arbitrary URI schemes like "ftp:" and "file:"
...
recognizes all URI scheme allowed characters, such as colon and period.
[#3494 state:resolved]
2010-05-24 11:25:24 +02:00
Jeremy Kemper
69a9669d9d
Missing changelog heading
2010-05-23 09:46:31 -07:00
José Valim
8d5939c096
Fix a bug where I18n fallbacks modules where not included in the proper backend if it was set through config.i18n.backend.
2010-05-23 13:22:19 +02:00
Norman Clarke
f3abc8ac36
Use multibyte proxy class on 1.9, refactor Unicode.
...
Makes String#mb_chars on Ruby 1.9 return an instance of ActiveSupport::Multibyte::Chars to work around 1.9's lack of Unicode case folding.
Refactors class methods from ActiveSupport::Multibyte::Chars into new Unicode module, adding other related functionality for consistency.
[#4594 state:resolved]
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2010-05-21 12:24:54 -07:00
José Valim
ad4be3d75d
Fix failing test.
2010-05-21 16:20:56 +02:00
Neeraj Singh
cc45a1068f
1.day should respond_to kind_of too
...
[#4656 state:resolved]
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-05-21 16:00:55 +02:00
Neeraj Singh
1bc6b43f53
Replace assert with assert_equal in some test cases
...
[#4654 state:resolved]
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-05-21 16:00:49 +02:00
Rohit Arondekar
c36374e768
Getting Started, don't forget to link to yourself if you are adding to the changelog.
2010-05-21 06:53:45 -07:00
José Valim
048cf9e922
Fix typo on rackup test (ht: pleax)
2010-05-20 13:49:06 -07:00
Nick Sieger
c0db7840fe
More accurate JRuby gem requirements
...
Signed-off-by: Santiago Pastorino <santiago@wyeworks.com >
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-05-20 15:18:57 +02:00
Santiago Pastorino
aacf2581cd
refactor evals and adds some __FILE__ and __LINE__
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-05-20 15:18:57 +02:00
Rohit Arondekar
0244b43ecd
Minor typo fix in callbacks.rb of abstract_controller
2010-05-20 03:23:21 -07:00
Xavier Noria
7f07cc364a
Merge remote branch 'rails/master'
2010-05-19 23:29:39 +02:00
Xavier Noria
b9fcd8d71f
in Ruby things in general happen at runtime, no need to specify that
2010-05-19 23:27:09 +02:00
Santiago Pastorino
61001e766d
group :mri deleted in favor of RUBY_ENGINE and RUBY_VERSION usage.
...
Allow use json, yajl-ruby and nokogiri on MRI and Rubinius only.
jruby-debug added only for jruby platform
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-05-19 21:32:45 +02:00
Neeraj Singh
39a246f545
Final iteration of use better testing methods
...
[#4652 state:resolved]
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-05-19 21:31:51 +02:00
Anil Wadghule
bdb2871df7
Fix xml serialization test [ #4650 state:resolved]
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-05-19 13:02:13 +02:00
Santiago Pastorino
5573ab2047
Enable ruby-debug only for MRI
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-05-19 12:59:53 +02:00
Santiago Pastorino
715f7c0b7c
Fixes a test on transaction_callbacks_test.rb
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-05-19 12:59:47 +02:00
Santiago Pastorino
59c7b0c23a
Avoid instance variable @output_buffer not initialized
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-05-19 12:59:29 +02:00
Neeraj Singh
b462952886
Use better assertion methods for testing
...
[#4645 state:resolved]
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-05-19 10:18:36 +02:00
Neeraj Singh
1c3d2a5a60
Updating the doc with the info that class_inheritable_accessor
...
copies properties to child at runtime
2010-05-19 01:29:15 -04:00
Josiah Ivey
695cabce39
Testing guide: Replace removed word
2010-05-18 23:04:10 -05:00
Josiah Ivey
256e13b3a3
Testing guide: Grammar, punctuation, and emphasize that test/unit is only the default
2010-05-18 22:55:15 -05:00
Marius Nuennerich
aa4fe9fb33
fix documentation typo
...
Signed-off-by: Santiago Pastorino <santiago@wyeworks.com >
2010-05-18 19:29:17 -03:00
Xavier Noria
b753b4a076
removes deprecations of last_(month|year) from master, they will be deprecated in 2.3 instead
2010-05-19 00:20:10 +02:00
Jeremy Kemper
223d6415d0
Revert "Don't carry default value when changing column for a binary type on MySQL"
...
Broke mysql tests.
This reverts commit edec1afe25 .
Conflicts:
activerecord/test/cases/migration_test.rb
[#3234 state:open]
2010-05-18 11:02:39 -07:00
Étienne Barrié
3809c80cd5
make add_index and remove_index more resilient; new rename_index method; track database limits
...
[#3452 state:committed]
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2010-05-18 10:55:41 -07:00
José Valim
d3e62fc57c
Avoid creating a Rack::Response object in the cookie middleware since it may stream the body.
2010-05-18 17:47:56 +02:00
Santiago Pastorino
03c3d1eb84
Fixes transaction callbacks tests
...
[#4640 state:committed]
Signed-off-by: wycats <wycats@gmail.com >
2010-05-18 19:32:37 +04:00
Ian White
b439d85a19
Nested records (re: autosave) are now updated even when the intermediate parent record is unchanged [ #4242 state:resolved]
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-05-18 16:13:00 +02:00
Neeraj Singh
ce20b93606
assert_equal should be used instead of assert
...
[#4629 state:resolved]
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-05-18 16:13:00 +02:00
Neeraj Singh
0ef13afef5
expected value should come first in assert_equal
...
[#4630 state:resolved]
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-05-18 16:13:00 +02:00
Neeraj Singh
d00afeaeed
Use assert_equal correctly in actionmailer test (exposing one as broken)
...
[#4626 state:resolved]
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-05-18 16:12:59 +02:00
Neeraj Singh
0dab076a08
Better error messages for some of ActiveSupport tests
...
[#4635 state:resolved]
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-05-18 16:12:59 +02:00
Neeraj Singh
c00f8e49ad
assert should be replaced with assert_equal in a particular test case
...
[#4636 state:resolved]
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-05-18 16:12:59 +02:00
Pratik Naik
5ddc904941
Remove Model.clear_default_scope
2010-05-18 12:22:23 +01:00
José Valim
c536835957
Cut the fat and make session stores rely on request.cookie_jar and change set_session semantics to return the cookie value instead of a boolean.
2010-05-18 03:18:23 +02:00
rohit
8e3c3b06dc
Fixed numericality validator in ActiveModel to reject hex numbers for floats completely [ #4622 state:commited]
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-05-18 03:10:56 +02:00
rohit
05e3fb45ee
Add a valid hex that shouldn't be valid to ActiveModel numericality tests [ #4622 state:commited]
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-05-18 03:10:55 +02:00
Neeraj Singh
73f0e1a842
Use assert_respond_to because it has better error messaging
...
[#4628 state:resolved]
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-05-18 02:12:06 +02:00
José Valim
26e645fa00
Remove deprecated methods since 2-3-stable.
2010-05-18 02:11:50 +02:00
José Valim
0c3cde404a
Kill legacy dispatcher.
2010-05-18 02:07:59 +02:00
José Valim
25f7c030e4
Simplify cookie_store by simply relying on cookies.signed.
2010-05-18 02:05:20 +02:00
José Valim
941b653627
Rely on set and delete cookie logic from rack.
2010-05-18 01:51:45 +02:00
Rizwan Reza
8c5e1652c7
Renames Array#rand -> Array#random_element
...
Signed-off-by: Xavier Noria <fxn@hashref.com >
2010-05-17 23:03:16 +02:00
wycats
f09d8f3e68
Merge remote branch 'origin/master'
2010-05-17 19:51:30 +04:00
wycats
c3b7471c69
Merge branch 'encodings'
2010-05-17 19:42:00 +04:00
wycats
80b60671f7
Revert "Moved encoding work in progress to a feature branch."
...
This reverts commit ade756fe42 .
2010-05-17 19:41:54 +04:00
wycats
02c36cf5cb
Make sure encoding changes don't break 1.8
2010-05-17 19:39:38 +04:00
Santiago Pastorino
c7e6777961
Added default currency values to NumberHelper and pass them to I18n.translate
...
[#4604 state:committed]
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-05-17 17:39:33 +02:00
José Valim
107c6381a0
Allow root to be given in the resources scope without need to specify :on => collection.
2010-05-17 17:39:32 +02:00
Jeremy Kemper
5371242384
Valid hex strings aren't valid float column values, to match the integer restriction. [ #4622 state:resolved]
2010-05-17 07:58:26 -07:00
Paco Guzman
c2fb8afaa0
Use assert_equal correctly in transaction callback tests (exposing some of them as broken)
...
[#4612 ]
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2010-05-17 07:16:53 -07:00
Josiah Ivey
ea9398f9ba
Guides: Fix numerous broken links
2010-05-16 21:58:47 -05:00
Jeremy Kemper
a06e9b4602
Ruby 1.9: helper path may be a pathname, so convert to a string before quoting for regexp
2010-05-16 18:03:27 -07:00
pleax
4db10bce7b
AR::Base#clone fixed to set dirty bits for cloned object
...
[#2919 state:committed]
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2010-05-16 17:45:12 -07:00
Comron Sattari
e1a340a91d
cache connection when quoting
...
[#3642 state:committed]
Signed-off-by: Marius Nuennerich <marius@nuenneri.ch >
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2010-05-16 17:40:40 -07:00
Rizwan Reza
d148a6f6ba
Merge branch 'master' of git://github.com/rails/rails
2010-05-17 02:40:15 +04:30
Rizwan Reza
e1c7730069
Merge branch 'master' of github.com:lifo/docrails
2010-05-17 02:39:10 +04:30
Rizwan Reza
4679b72cba
Changed guide to use random_element.
2010-05-17 02:11:56 +04:30
Federico Brubacher
6b4e0cc526
a cloned object no longer mimics changed flags from creator , plus a test case [ #4614 state:resolved]
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-05-16 23:04:40 +02:00
Jeremy Kemper
ade756fe42
Moved encoding work in progress to a feature branch.
...
This reverts commits af0d1a8815 and 64d109e353 .
2010-05-16 13:55:29 -07:00
Santiago Pastorino
821e15e5f2
Change on Array extension from rand => random_element [ #4555 state:committed]
...
Signed-off-by: Xavier Noria <fxn@hashref.com >
2010-05-16 22:23:44 +02:00
Josiah Ivey
774f596693
Fix punctuation and keep the tone consistent
2010-05-16 13:58:56 -05:00
wycats
64d109e353
Significantly improved internal encoding heuristics and support.
...
* Default Encoding.default_internal to UTF-8
* Eliminated the use of file-wide magic comments to coerce code evaluated inside the file
* Read templates as BINARY, use default_external or template-wide magic comments
inside the Template to set the initial encoding
* This means that template handlers in Ruby 1.9 will receive Strings encoded
in default_internal (UTF-8 by default)
* Create a better Exception for encoding issues, and use it when the template
source has bytes that are not compatible with the specified encoding
* Allow template handlers to opt-into handling BINARY. If they do so, they
need to do some of their own manual encoding work
* Added a "Configuration Gotchas" section to the intro Rails Guide instructing
users to use UTF-8 for everything
* Use config.encoding= in Ruby 1.8, and raise if a value that is an invalid
$KCODE value is used
Also:
* Fixed a few tests that were assert() rather than assert_equal() and
were caught by Minitest requiring a String for the message
* Fixed a test where an assert_select was misformed, also caught by
Minitest being more restrictive
* Fixed a test where a Rack response was returning a String rather
than an Enumerable
2010-05-16 22:44:43 +04:00
wycats
af0d1a8815
Initial work to improve the state of encodings for templates
2010-05-16 22:43:35 +04:00
Priit Tamboom
f8432108e8
Added nokogiri dependency to Gemfile [ #4617 state:resolved]
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-05-16 20:33:46 +02:00
Nobuhiro IMAI
5d0afe75eb
prevent to run fixture accessor (e.g. test_foos for TestFoo model) as a test case [ #2992 state:resolved]
...
Signed-off-by: Wijnand Wiersma <wijnand@videre.net >
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-05-16 20:14:36 +02:00
Santiago Pastorino
9ef232a785
Gemfile requires sqlite3-ruby = 1.3.0.beta.2
...
Signed-off-by: Xavier Noria <fxn@hashref.com >
2010-05-16 19:48:05 +02:00
Simon Jefford
7be58b6163
Tests for new reserved words [ #4602 state:resolved]
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-05-16 19:15:24 +02:00
Aleksandr Koss
b7bdacf1ab
Added rails command aliases (s g c db) to reserved words in app generator [ #4602 state:resolved]
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-05-16 19:15:01 +02:00
Franck Verrot
621ee373cb
I have updated the documentation according to ticket #4263 about fixtures and set_fixture_class
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-05-16 18:04:31 +02:00
Rizwan Reza
d61dbce482
Take out stale tasks from Actionpack's Rakefile [ #4619 state:resolved]
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-05-16 17:49:33 +02:00
Rizwan Reza
6c69221985
Takes out stale methods relating to edge_rails_version
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-05-16 17:21:29 +02:00
Santiago Pastorino
fa5f93698d
Added missing require, we are using bind method defined on active_support/core_ext/proc
...
[#4610 state:committed]
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-05-16 16:16:15 +02:00
Santiago Pastorino
fdfebb7782
Make use of assert_equal to test equallity between object assert expects and object and a message of error
...
[#4611 state:committed]
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-05-16 16:06:28 +02:00
Wijnand Wiersma
d7a3e65c50
Postgresql doesn't allow to change a string type column to a binary type. Skip this test for postgresql for now. [ #4616 state:resolved]
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-05-16 15:15:43 +02:00
Simon Jefford
f58bdae1f7
Check blocks are not incorrectly detected when compiling erubis templates [ #4575 state:resolved]
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-05-16 15:05:07 +02:00
Hussein Morsy
4ea48f2a98
Fixed 1 failure in ActionPack testsuite [ #4613 state:resolved]
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-05-16 15:00:35 +02:00
José Valim
6cabc9a61f
Add some comments related to Hash method check.
2010-05-16 14:34:36 +02:00
pleax
2dc1402417
added support for html attributes in options_for_select [ #2165 ]
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-05-16 14:33:04 +02:00
rohit
fc2480a277
Fixed 1 failure and 2 errors in ActionPack testsuite [ #4613 state:commited]
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-05-16 14:32:53 +02:00
Aleksandr Koss
3e84ea014e
Fix Hash#index deprecated warning in 1.9.x [ #4600 state:resolved]
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-05-16 14:32:48 +02:00
José Valim
1a2d556de7
Rename assert_attribute_type to asser_field_type.
2010-05-16 12:07:44 +02:00
Jeff Kreeftmeijer
5ff6de0982
Added assert_attribute_type to clean up GeneratedAttributeTest [ #2377 state:resolved]
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-05-16 12:07:22 +02:00
José Valim
99b38f371a
Move AD::Cascade to the bottom of the middleware stack.
2010-05-16 12:03:11 +02:00
Jeff Kreeftmeijer
4750e61bfe
using :time_select when the attribute type is :time in the scaffold generator. [ #2377 state:resolved]
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-05-16 10:52:36 +02:00
rohit
afe57dda26
Fixed two failing tests in railties on 1.9.2-head [ #4609 state:commited]
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-05-16 10:47:03 +02:00
Elomar França
edec1afe25
Don't carry default value when changing column for a binary type on MySQL [ #3234 state:resolved]
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-05-16 10:45:26 +02:00
Neeraj Singh
5de2e0d416
better documentation for dependent option [ #4564 state:resolved]
2010-05-16 06:47:16 +04:30
José Valim
3afdfc35e8
Expose remaining hooks to minimize the need for a Railtie based on feedback from plugin developers.
2010-05-16 00:36:46 +02:00
Xavier Noria
24610c9b28
simplify contact information in the guides contribution guide
2010-05-16 00:09:55 +02:00
Xavier Noria
08fb1c4565
updates the contribute guide in several aspects
2010-05-16 00:00:38 +02:00
José Valim
351816fab6
Ensure that eager_load actually takes place just after the middleware stack is built by using another pattern.
...
Also create a engine_blank_point initializer to ensure any :before or :after hooks defined inside engines won't move the configuration initializers to other places.
2010-05-15 23:49:03 +02:00
Jeff Dean
6617d01893
Sending :id => nil to form helpers now properly omits the "id" html element [ #4559 state:resolved]
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-05-15 22:30:21 +02:00
José Valim
d6cbb27e7b
Revert "Make ActiveModel::Errors#add_on_blank and #add_on_empty accept an options hash and make various Validators pass their (filtered) options."
...
Having a huge array to whitelist options is not the proper way to handle this case. This means that the ActiveModel::Errors object should know about the options given in *all* validators and break the extensibility added by the validators itself. If the intent is to whitelist options before sending them to I18n, each validator should clean its respective options instead of throwing the responsibility to the Errors object.
This reverts commit bc1c8d58ec .
2010-05-15 21:55:16 +02:00
José Valim
f055bc05d5
Optimize the code added in fa99de0bd0
2010-05-15 21:55:03 +02:00
Jeremy Kemper
c5537c1158
Ruby 1.9: fix invalid rack response in test
2010-05-15 11:25:56 -07:00
Jeff Kreeftmeijer
da90fe9466
make sure as is set before trying to build an #{as}_counter. [ #2804 state:resolved]
...
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2010-05-15 11:19:41 -07:00
Jeroen van Dijk
bc1c8d58ec
Make ActiveModel::Errors#add_on_blank and #add_on_empty accept an options hash and make various Validators pass their (filtered) options.
...
This makes it possible to pass additional options through Validators to message
generation. E.g. plugin authors want to add validates_presence_of :foo, :format
=> "some format".
Also, cleanup the :default vs :message options confusion in ActiveModel
validation message generation.
Also, deprecate ActiveModel::Errors#add_on_blank(attributes, custom_message) in
favor of ActiveModel::Errors#add_on_blank(attributes, options).
Original patch by Sven Fuchs, some minor changes and has been changed to be applicable to master again
[#4057 state:committed]
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2010-05-15 11:17:58 -07:00
Santiago Pastorino
47c9a35506
Reset quoted_table_name after set_table_name [ #4568 state:resolved]
...
Signed-off-by: Pratik Naik <pratiknaik@gmail.com >
2010-05-15 18:53:47 +01:00
Jeff Kreeftmeijer
fa99de0bd0
partial counters with :as [ #2804 state:resolved]
...
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2010-05-15 10:32:23 -07:00
Diego Algorta
3436fdfc12
Fix for get_ids when including a belongs_to association on a has_many association [ #2896 state:resolved]
...
Signed-off-by: Pratik Naik <pratiknaik@gmail.com >
2010-05-15 16:53:59 +01:00
Anil Wadghule
2d84f24af5
Add tests for convenience methods #notice and #alert to flash.now [ #4369 state:resolved]
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-05-15 16:52:23 +02:00
Martin
e807476d31
added convenience methods #notice and #alert to flash.now
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-05-15 16:52:19 +02:00
Paco Guzman
cdf700147c
fix assert_select messages to its declaration behaviour
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-05-15 16:31:36 +02:00
Jeroen van Dijk
f45714bb4a
Added extra documentation for content_for helper
2010-05-15 15:33:30 +02:00
José Valim
6f0ed7aa52
Update generators test.
2010-05-15 15:21:14 +02:00
wycats
9cfeefb637
Reorganized initializers a bit to enable better hooks for common cases without the need for Railtie. Specifically, the following hooks were added:
...
* before_configuration: this hook is run immediately after the Application class
comes into existence, but before the user has added any configuration. This is
the appropriate place to set configuration for your plugin
* before_initialize: This is run after all of the user's configuration has completed,
but before any initializers have begun (in other words, it runs right after
config/environments/{development,production,test}.rb)
* after_initialize: This is run after all of the initializers have run. It is an
appropriate place for forking in a preforking setup
Each of these hooks may be used via ActiveSupport.on_load(name) { }. In all these cases, the context inside the block will be the Application object. This means that for simple cases, you can use these hooks without needing to create a Railtie.
2010-05-15 06:09:07 -07:00
wycats
458f5712dc
Remove the need for a special action_mailer.url_for initializer that loads before anything else
2010-05-15 06:09:07 -07:00
Jeroen van Dijk + Rodrigo Urubatan
80fc6536bd
Added Rake task rails:templates:copy to copy templates for customization [ #4574 state:resolved]
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-05-15 14:59:29 +02:00
Carlos Antonio da Silva
c77794a924
Add missing require to with_options [ #4601 state:resolved]
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-05-15 14:54:07 +02:00
Neeraj Singh
58adc67371
STI should not ignore type condition while applying scopes from parent class scopes
...
[#4507 state:resolved]
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-05-15 09:48:49 +02:00
Adrian Sanchez
bcf5fea5e5
Bundler deprecated options in Gemfile with application template using method "gem" [ #4534 state:resolved]
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-05-15 09:43:20 +02:00
Marc-Andre Lafortune
9869ee77cd
Accept :alt => nil on image_tag [ #4558 state:resolved]
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-05-15 09:43:15 +02:00
Santiago Pastorino
7ffe76046a
ActiveResource shouldn't consider modules in the path
...
[#4529 state:committed]
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-05-15 09:38:32 +02:00
José Valim
d18a2742e0
Improve previous patch a bit [ #3645 state:resolved]
2010-05-15 09:08:40 +02:00
Stephen Celis
6e69b42b21
Let label helpers accept blocks.
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-05-15 08:59:08 +02:00
eparreno
a447f76fe5
AR Validations: Errors section updated
2010-05-15 08:52:47 +02:00
David Chelimsky + Brian Tatnall
35a114a894
Modified default_scope to merge with any pre-existing default_scope
...
and added AR::Base::clear_default_scope
- clear_default_scope provides users who rely on the old behaviour
of each call to default_scope overwriting any previous default
scopes an opportunity to maintain that behaviour.
[#4583 state:resolved]
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-05-15 08:38:28 +02:00
Neeraj Singh
a0621c1086
Better code formatting and proper line numbers for stack traces
...
[#4596 state:resolved]
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2010-05-14 12:24:01 -07:00
Santiago Pastorino
0c37bf8f91
To allow proper fisting of stack trace
...
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2010-05-14 10:36:59 -07:00
Mikel Lindsaar
4a8a62058a
Changed encoding behaviour of mail, so updated tests in actionmailer and bumped mail version to 2.2.1
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-05-14 09:27:47 +02:00
Josh Kalderimis
92160219a8
minor changes to instance level validations implementation based on feedback from José Valim
2010-05-13 13:57:37 -07:00
Josh Kalderimis
9131a88bb8
validation macros can now be used within an instance
2010-05-13 13:57:37 -07:00
eparreno
04289172cb
routing guide: fix typos and clarify code examples
2010-05-13 16:12:25 +02:00
Anil Wadghule
6e4e95b7f9
Updated 3.0 release notes guide to inform issues with unsupported Ruby versions.
2010-05-13 14:49:21 +05:30
eparreno
79e5e79b0d
fix wrong action name [ #134 ]
2010-05-12 23:15:07 +02:00
Xavier Noria
2203c781a7
defines prev_(month|year) in Date and Time to ease transition to 1.9, and deprecates last_(month|year)
2010-05-12 23:04:17 +02:00
eparreno
bcccf924af
complete rake tasks table and fix format
2010-05-12 22:59:25 +02:00
Santiago Pastorino
903637f5f0
Fixes to_json and to_xml for ActiveResource
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-05-12 21:02:31 +02:00
Santiago Pastorino
6334006b81
Revert "Refactor of active_model/naming.rb and allow collection and element to be writable"
...
This reverts commit f7862b2c34 .
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-05-12 21:02:16 +02:00
Santiago Pastorino
bea3c26833
Make ActiveResource serialize XML correctly when element_name is set.
...
[#4529 ]
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2010-05-12 09:31:36 -07:00
Santiago Pastorino
f7862b2c34
Refactor of active_model/naming.rb and allow collection and element to be writable
...
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2010-05-12 09:31:30 -07:00
Santiago Pastorino
42fa2714c5
Make use of to_xml and to_json in tests
...
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2010-05-12 09:31:30 -07:00
Xavier Noria
7321a3a7d3
revises the rdoc of #average according to 5f3bd55, and realigns when clauses
2010-05-12 08:47:55 +02:00
Santiago Pastorino
5f3bd55726
type_cast_calculated_value refactor: value is never a Fixnum here. Fix test since SQLite returns Float.
...
[#4514 state:committed]
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2010-05-11 22:29:26 -07:00
Xavier Noria
75ddbfecde
Gemfile requires sqlite3-ruby 1.3.0.beta.1
2010-05-12 00:37:23 +02:00
Blake Smith
a4207c1084
Make sure timestamp is properly referenced
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-05-11 20:06:26 +02:00
Pratik Naik
88b4a8fcaf
Remove undocumented save_without_validation!
2010-05-11 15:39:29 +01:00
Pratik Naik
475d1d1713
Use arel instead of sql strings
2010-05-11 15:32:41 +01:00
Pratik Naik
1f675ea8c7
Succint save definition
2010-05-11 13:50:09 +01:00
rohit
6b1cb1d4fd
Getting started, fixed some links in changelog
2010-05-10 17:43:58 +05:30
Josh Kalderimis
446b0ffe1c
corrected error message in session/cookie_store [ #4546 state:resolved]
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-05-10 12:37:01 +03:00
José Valim
5c245b91d2
Make sure valid? preceives the context as in ActiveModel API (ht: Carlos Antonio)
2010-05-10 12:28:38 +03:00
Pratik Naik
ce5827ea47
Make sure schema dumper doesnt throw up when there are no index lengths
2010-05-09 12:43:06 +01:00
Pratik Naik
8d2f6c16e3
Revert "Revert "Add index length support for MySQL [ #1852 state:open]""
...
This reverts commit 6626833db1 .
2010-05-09 12:42:48 +01:00
Pratik Naik
f75a6fec29
Improve code from 231d7676f7
2010-05-09 12:33:25 +01:00
Josh Kalderimis
231d7676f7
corrected AR find_each and find_in_batches to raise when the user uses select but does not specify the primary key
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-05-09 13:14:47 +03:00
José Valim
06eaf27fff
Merge branch 'master' of github.com:rails/rails
2010-05-09 13:02:55 +03:00
José Valim
6c2d974e15
Use annoted source code in Template:Error to avoid special cases in the show exceptions middleware.
2010-05-09 12:52:30 +03:00
Xavier Noria
e1a0d86fe0
Merge remote branch 'rails/master'
2010-05-09 11:46:45 +02:00
Xavier Noria
1ff3d951e6
AS guide: more date calculation utilities
2010-05-09 12:45:21 +03:00
Xavier Noria
df508bd970
aliases Date#sunday to Date#end_of_week, for symmetry with existing alias Date#monday -> Date#beginning_of_week
2010-05-09 11:16:34 +02:00
Xavier Noria
08d991ad40
AS guide: you know, the 10th is not November
2010-05-09 11:44:22 +03:00
Xavier Noria
345c38a527
AS guide: adds a catchall note about date calculations around the calendar reform
2010-05-09 11:41:13 +03:00
Xavier Noria
2969543cef
adds calendar reform test coverage for more relevant date calculations
2010-05-09 10:26:21 +02:00
Santiago Pastorino
c31b386a88
Updates bundler information, now bundler has a homepage
2010-05-08 21:41:41 -03:00
wycats
d916c62cfc
eliminate alias_method_chain from ActiveRecord
2010-05-09 02:37:52 +03:00
Xavier Noria
7a5aa35ed0
AS guide: documents some Date calculations (calendar reform details pending)
2010-05-09 02:29:02 +03:00
Xavier Noria
636ffa1f08
Backports Date#>> from 1.9 so that calculations do the right thing around the calendar reform
...
Our next_month gives November for some late dates in September of 1582.
Related methods, last_*, and in general advance have the same issues.
This commit fixes those, see the test suite for expected behavior, which
we still run in 1.9 to ensure it matches as we do with other methods
defined in Date in 1.9.
2010-05-09 01:20:23 +02:00
Josh Kalderimis
605c6455ac
removed AR from all AMo tests, including any unneeded files (schema, fixtures and test helper)
2010-05-09 00:08:11 +03:00
Josh Kalderimis
88ad3ed8b5
removed an old unused model in the AMo tests which also removes another AR dependency
2010-05-09 00:08:11 +03:00
Josh Kalderimis
e17ff6d617
updated AR to work with the AMo model validation changes
2010-05-08 23:51:36 +03:00
Josh Kalderimis
66913a76af
removed use of AR in AMo tests and removed testing of scopes (:on) in individual validation tests and moved them to their own test file
2010-05-08 23:51:36 +03:00
Josh Kalderimis
82485068f8
updated AMo validations to use a context for valid? and invalid?, removing the dependency on AR
2010-05-08 23:51:28 +03:00
Santiago Pastorino
0b4211c88b
Here the intention was to assign to different objects
2010-05-08 23:29:51 +03:00
Xavier Noria
7184a9e643
add test coverage for (last|next)_year on leap years
2010-05-08 18:46:15 +02:00
Sam Ruby
788684d75a
get the rescue error page back [ #4536 state:resolved]
2010-05-08 17:55:51 +02:00
José Valim
6626833db1
Revert "Add index length support for MySQL [ #1852 state:open]"
...
This commit breaks dumping a few tables, as the sessions table.
To reproduce, just create a new application and:
rake db:sessions:create
rake db:migrate
rake db:test:prepare
And then look at the db/schema.rb file (ht: Sam Ruby).
This reverts commit 5b95730edc .
2010-05-08 17:46:39 +03:00
Emili Parreno
5b95730edc
Add index length support for MySQL [ #1852 state:resolved]
...
Example:
add_index(:accounts, :name, :name => 'by_name', :length => 10)
=> CREATE INDEX by_name ON accounts(name(10))
add_index(:accounts, [:name, :surname], :name => 'by_name_surname', :length => {:name => 10, :surname => 15})
=> CREATE INDEX by_name_surname ON accounts(name(10), surname(15))
Signed-off-by: Pratik Naik <pratiknaik@gmail.com >
2010-05-08 12:39:46 +01:00
Santiago Pastorino
9aaef59356
Make find_or_create and find_or_initialize work mixing explicit parameters and a hash [ #4457 state:committed]
...
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2010-05-07 09:40:02 -07:00
Rohit Arondekar
2cc1686bda
migration, correct file and created a code sample out of it.
2010-05-07 00:03:16 -07:00
Lawrence Pit
1e1d30715e
Fix parsing xml input by ActionDispatch::ParamsParser
...
[#4437 state:committed]
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2010-05-06 20:34:47 -07:00
Rohit Arondekar
d3e405cdbc
Migrations, rewrote a sentence for clarity.
2010-05-06 20:33:24 -07:00
Ernie Miller
902861a43a
Fix unintuitive behavior with multiple order and group clauses
...
[#4545 state:committed]
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2010-05-06 16:00:39 -07:00
Carl Lerche
6d7f2790cd
Expand paths to app builders relative to the working directory
2010-05-06 12:02:54 +03:00
Anil Wadghule
6071b4720c
Updated guide to inform issues with unsupported Ruby versions.
2010-05-06 01:26:25 +05:30
Ernie Miller
5be49884b5
Prevent calling regexp on symbol in Ruby 1.9 in association_proxy
...
Signed-off-by: Pratik Naik <pratiknaik@gmail.com >
2010-05-05 18:54:07 +01:00
wycats
743d77f405
Update hidden namespace mechanism to work better with alternate choices and to support full namespaces (not just entire groups)
2010-05-05 10:12:33 +02:00
Santiago Pastorino
b38639ab71
typo 'Provivdes' -> 'Provides'
2010-05-05 00:55:44 -03:00
Xavier Noria
f2072a323c
adds Date#to_time refinement from previous commit to the CHANGELOG
2010-05-05 00:48:31 +02:00
Brian Lopez
bf2ee89659
add support for mysql2 adapter to dbconsole
...
[#4532 state:committed]
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2010-05-04 15:47:08 -07:00
Xavier Noria
53c1cd6cde
let Time.time_with_datetime_fallback handle properly years in the range 0..138
2010-05-05 00:35:06 +02:00
Mathieu Arnold
38da0ace77
Use primary key in conditions, not 'id' [ #4395 state:resolved]
...
Signed-off-by: Pratik Naik <pratiknaik@gmail.com >
2010-05-04 22:45:08 +01:00
Jatinder Singh
bce2c0ce37
Active Model JSON serializer now supports custom root option
...
[#4515 state:committed]
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2010-05-04 13:17:26 -07:00
Brian Lopez
7aad851c2e
Allow pre-casted values (other than nil) to pass through from calculations un-touched
...
[#4514 state:committed]
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2010-05-04 11:57:52 -07:00
Xavier Noria
583b60d109
Merge remote branch 'rails/master'
2010-05-04 19:36:26 +02:00
Josiah Ivey
0dd3b4630f
image_tag should be audio_tag, and change typo 'image' to 'audio file'
2010-05-04 19:31:41 +02:00
mica eked
d5e3c49478
typo "<image />" -> "<img />", and typo 'follow' -> 'following'
2010-05-04 19:31:40 +02:00
logylaps
d38b4771f1
typo 'main.cs' -> 'main.css', and textile typo 'h6(:has_many-group)' -> 'h6(#has_many-group)', and typo. missing 'if'
2010-05-04 19:31:32 +02:00
Joe Hannon
c8d03fbe9b
grammatical error 'uses' -> 'use'
2010-05-04 19:24:40 +02:00
Mikel Lindsaar
058f7feafe
Cleaning up Action Mailer spelling with and without the space
2010-05-04 19:24:40 +02:00
Mikel Lindsaar
fb30feb48b
Adding more docs to ActionMailer
2010-05-04 19:24:40 +02:00
Pratik Naik
841c01fa0f
Use class_inheritable_accessor for connection_handler
2010-05-04 17:51:22 +01:00
Josiah Ivey
44a9896767
Change typo 'image' to 'audio file'
2010-05-04 09:55:44 -05:00
Josiah Ivey
015114cbbb
image_tag should be audio_tag
2010-05-04 09:52:31 -05:00
mica eked
3190fcb521
typo 'follow' -> 'following'
2010-05-04 03:10:41 -07:00
mica eked
1357b659bb
typo "<image />" -> "<img />"
2010-05-04 02:46:21 -07:00
logylaps
8770b8c955
typo. missing 'if'
2010-05-04 02:25:55 -07:00
logylaps
387e16afa9
textile typo 'h6(:has_many-group)' -> 'h6(#has_many-group)'
2010-05-04 02:23:49 -07:00
logylaps
6658c95897
typo 'main.cs' -> 'main.css'
2010-05-04 02:17:36 -07:00
Xavier Noria
6704d8c994
date/conversions needs time/calculations for (utc|local)_time
2010-05-03 23:11:09 +02:00
Xavier Noria
5d7d0c2fa3
BigDecimal#as_json does not really specify the F format, it delegates that to whatever BigDecimal#to_s default format is, do the same in its test
2010-05-03 22:11:33 +02:00
Xavier Noria
9e085a9f33
adds a comment explaining why BigDecimal#as_json returns a JSON string
2010-05-03 22:04:47 +02:00
Xavier Noria
34d5725167
fixes colon in previous YAML example
2010-05-03 15:25:28 +02:00
Norman Clarke
756f762cdb
Fix transliteration rule example in docs. [ #4526 state:resolved]
...
Signed-off-by: Xavier Noria <fxn@hashref.com >
2010-05-03 15:22:52 +02:00
David Chelimsky
b3dcbedc67
move assert_template tests to their own test case [ #4501 state:resolved]
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-05-03 13:46:34 +02:00
David Chelimsky
849ab92942
Eliminate false positives when passing symbols to assert_template
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-05-03 13:46:12 +02:00
José Valim
36fc489aa3
Update I18n gem to 0.4.0.beta1 [ #4525 state:resolved].
2010-05-03 13:45:36 +02:00
Lawrence Pit
9bd91b00b8
Favor %{} in all code instead of (deprecated) {{}} as interpolation syntax for I18n
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-05-03 13:37:32 +02:00
José Valim
8ae9b05fa0
Make backtrace_cleaner work as expected. Prior to this patch, the Full Trace rarely showed the full trace. Also, increase performance considerably.
2010-05-03 12:59:48 +02:00
Joe Hannon
2a09b8ecc7
grammatical error 'uses' -> 'use'
2010-05-02 15:55:58 -07:00
Xavier Noria
0e00f428a8
adds test coverage for Date.current vs Date.today in Date.(yesterday|tomorrow) implementation
2010-05-03 00:03:32 +02:00
David Chelimsky
8672a97e11
add NullResolver
...
[#4523 state:resolved]
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-05-02 22:45:54 +02:00
David Chelimsky
a3044967ed
add tests for FixtureResolver
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-05-02 22:45:54 +02:00
David Chelimsky
91125f9927
move FixtureResolver to a file that is accessible outside Rails' own tests
...
[#4522 state:resolved]
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-05-02 22:45:54 +02:00
José Valim
a76c7e68d5
Event should be aware if yielded block failed or not.
2010-05-02 22:45:54 +02:00
Justin George
731d4392e4
Change event namespace ordering to most-significant first [ #4504 state:resolved]
...
More work still needs to be done on some of these names
(render_template.action_view and render_template!.action_view particularly)
but this allows (for example) /^sql/ to subscribe to all
the various ORMs without further modification
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-05-02 22:45:54 +02:00
Justin George
109d3ee38d
Make notifications go off even when an error is raised, so that we capture the underlying performance data [ #4505 state:resolved]
...
This is important when trying to keep track of many layers of interrelated calls
i.e.:
ActiveRecord::Base.transaction do
MyModel.find(1) #ActiveRecord::NotFound
end # should capture the full time until the error propagation
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-05-02 22:45:53 +02:00
Santiago Pastorino
02028e529c
Missing require added make pass activesupport/test/json/encoding_test.rb in isolation
...
Signed-off-by: Xavier Noria <fxn@hashref.com >
2010-05-02 22:05:40 +02:00
Mikel Lindsaar
07a5fdedd4
Cleaning up Action Mailer spelling with and without the space
2010-05-02 21:48:46 +10:00
Mikel Lindsaar
3e332948c7
Adding more docs to ActionMailer
2010-05-02 20:38:09 +10:00
Mikel Lindsaar
ceaa100e59
Adding ability for the procs to be called within the instance, allows you to pass results from instance methods to the mail header
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-05-02 11:56:08 +02:00
Mikel Lindsaar
08b07b60b6
Adding ability to pass proc's to the ActionMailer class default method
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-05-02 11:56:08 +02:00
Cezary Baginski
256a15c235
AR: fixed postgres fixture tests [ #4519 state:resolved]
...
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2010-05-01 18:53:07 -07:00
Xavier Noria
1b33a151b2
revises tests for Date.yesterday and Date.tomorrow
2010-05-02 01:36:10 +02:00
Xavier Noria
7aaabea517
let Date.yesterday and Date.tomorrow be based on Date.current rather than Date.today
2010-05-02 01:12:31 +02:00
Xavier Noria
1b898cc946
say something about after_(commit|rollback) in callbacks.rb, the fact that their implementation is elsewhere is not important for rdoc purposes
2010-05-02 00:47:09 +02:00
Xavier Noria
6433c939c1
edit pass in the transactions preamble rdoc
2010-05-02 00:40:31 +02:00
Cezary Baginski
8b1b273c21
AR: fixed postgres transaction tests [ #4519 state:commited]
...
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2010-05-01 13:40:07 -07:00
José Valim
a61a6d206b
Speed up I18n helpers in views and add entry to CHANGELOG.
2010-05-01 22:38:57 +02:00
Marius Nuennerich
35598db01a
repair the activesupport message encryptor tests for me, do so in the same way as jeremy did with message verifier
...
[#4517 state:committed]
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2010-05-01 10:04:01 -07:00
José Valim
13867a3f5f
Use %{} syntax in I18n (faster) instead of {{}}.
2010-05-01 12:54:52 +02:00
Xavier Noria
efba1d4227
Merge commit 'rails/master'
...
Conflicts:
railties/guides/source/index.html.erb
2010-05-01 02:23:47 -07:00
Carl Lerche
6c280f3398
RouteSet does not raise ActionController::RoutingError when no routes match anymore. Instead, it follows the X-Cascade convention. ShowExceptions checks for X-Cascade so that the routing error page can still be displayed.
2010-04-30 16:40:42 -07:00
Carl Lerche
95c98799a4
Fix a bug in the generators from the previous commit
2010-04-30 16:32:18 -07:00
Carlhuda
dedb842fda
It would be nice to actually commit test fixtures
2010-04-30 16:25:40 -07:00
eparreno
81807e0fe2
fix format
2010-04-30 23:19:44 +02:00
Carlhuda
785493ffed
Provide a mechanism for overriding the entire generator via a class that handles the individual elements of generating a new Rails application
2010-04-30 13:48:06 -07:00
Carlhuda
0761d1b0f7
Set up app generator class to make it easier to for alt-stacks to override targeted areas
2010-04-30 13:48:06 -07:00
Jeremy Kemper
1d2257deeb
Merge remote branch 'technoweenie/http_token_authentication'
...
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2010-04-30 13:46:37 -07:00
Xavier Noria
1ff954aaea
after_(commit|rollback) rdoc, edit pass
2010-04-30 21:35:03 +02:00
Xavier Noria
f5fa13cca1
guides index: punctuation
2010-04-30 21:22:57 +02:00
wycats
e975f6f530
Add generators to the guides and break out an extensions section
2010-04-30 11:52:04 -07:00
wycats
21c1fbb6c1
Add generators to the guides and break out an extensions section
2010-04-30 11:50:37 -07:00
wycats
0fe8827bf3
Merge branch 'master' of github.com:rails/rails
2010-04-30 11:17:58 -07:00
rick
8d236ccb84
add HTTP Token Authorization support to complement Basic and Digest Authorization.
2010-04-30 07:46:30 -07:00
José Valim
6b559474fb
Depend on the I18n 0.4.0.beta.
2010-04-30 16:22:18 +02:00
Norman Clarke
f0e754e713
Delegate Inflector.transliterate to i18n. [ #4508 state:resolved]
...
Ancillary changes: Moved Chars#normalize into a class method; removed
unused UTF_PAT constant.
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-04-30 16:18:12 +02:00
Lawrence Pit
60504e62c8
to_xml with :include should skip_instruct on the included records [ #4506 state:resolved]
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-04-30 14:22:57 +02:00
Neeraj Singh
a003a39bac
removing the extra assignment statement [ #4432 state:resolved]
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-04-30 13:20:14 +02:00
Neeraj Singh
883f27aa9a
test cases for record.to_xml [ #458 state:resolved]
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-04-30 13:19:30 +02:00
José Valim
34908e4a66
Updated the generators guide.
2010-04-30 12:50:42 +02:00
José Valim
cde168edbb
Update generators to use thor 0.13.6 with simpler source_root handling.
2010-04-30 12:42:12 +02:00
José Valim
7b98d2aa59
Reorganize the mailer generator a bit.
2010-04-30 12:11:38 +02:00
rohit
2c7f7738c3
more fixes and updated the changelog
2010-04-30 12:21:29 +05:30
rohit
0b41aa9b2c
fixes to tags section
2010-04-30 12:09:53 +05:30
rohit
7d0027554b
Rewrote Security para and a minor fix
2010-04-30 11:24:32 +05:30
Rohit Arondekar
0bd631419e
Rewrote para for clarity and better reading
2010-04-29 22:39:08 -07:00
Brian Durand
d2a49e4b1f
Update after_commit and after_rollback docs and tests to use new style API with an :on options instead of on_* suffix.
...
[#2991 ]
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2010-04-29 18:26:19 -07:00
Carlhuda
c54c84b7b4
Move ActionMailer generator to AM
2010-04-29 16:45:57 -07:00
José Valim
b0a53c86ef
Update thor dependency to 0.13.5
2010-04-29 23:25:40 +02:00
Brian Durand
da840d13da
Add after_commit and after_rollback callbacks to ActiveRecord that are called after transactions either commit or rollback on all records saved or destroyed in the transaction.
...
[#2991 state:committed]
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2010-04-29 12:24:15 -07:00
Jeremy Kemper
20f0e9f320
Fix docs typo: app.middlewares -> app.middleware
2010-04-29 11:43:09 -07:00
Jeremy Kemper
fef31be2bc
Add missing deprecation requires
2010-04-29 11:34:48 -07:00
Ben Orenstein
7c7e00b552
Small grammatical fix.
2010-04-29 12:46:10 -04:00
Ben Orenstein
f632df2828
Make output match code.
2010-04-29 12:41:56 -04:00
Ben Orenstein
90ef772ee6
Fix sentence fragment and improve wording in generated README.
2010-04-29 12:37:18 -04:00
Santiago Pastorino
199cb0f80b
as changes named routes, path is the appropriate option in this case
2010-04-29 12:02:02 -03:00
Tore Darell
8d0bdbf0b7
Change %5b ([) to %5d (]) in escaped URL
2010-04-29 15:06:31 +02:00
Tore Darell
c68ff4b27f
Replace send_data with send_file in "Sending files" example
2010-04-29 15:04:10 +02:00
Neeraj Singh
f4d174b211
making rake:migrate VERSION=0 a noop called in succession. [ #2137 state:resolved]
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-04-29 13:41:35 +02:00
Neeraj Singh
68c96fad55
Fix form builder and form helpers inconsistencies [ #4432 state:resolved]
...
* datetime_select and select_datetime should be consistent as much as possible
* date_select and select_date should be consistent as much as possible
* time_select and select_time should be consistent as much as possible
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-04-29 13:40:55 +02:00
José Valim
3dfcb56e45
ActiveRecord middlewares should be inserted before AD::Cascade [ #4493 state:resolved].
2010-04-29 13:24:35 +02:00
Ravinder Singh
e9a9ef094e
warn user if options are given before application name [ #3435 state:resolved]
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-04-29 13:00:17 +02:00
Neeraj Singh
d793d30776
ActionCachingTestController rescues from all exceptions. Making sure that all the tests check for valid response. [ #4468 state:resolved]
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-04-29 12:48:34 +02:00
José Valim
2e9af3638d
Move several configuration values from Hash to ActiveSupport::XmlMini, which both Hash and Array depends on.
...
Also, refactored ActiveModel serializers to just use ActiveSupport::XmlMini.to_tag. As consequence, if a serialized attribute is an array or a hash, it's not encoded as yaml, but as a hash or array.
2010-04-29 12:42:42 +02:00
José Valim
1bea5c755c
Ops. Rename performance to profiler.
2010-04-29 09:31:06 +02:00
Neeraj Singh
580dd3b052
array.to_xml should be able to handle all types of data elements [ #4490 state:resolved]
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-04-29 09:04:34 +02:00
rohit
19e565d005
revert back to <b> tags instead of <strong> tags in the getting started guide
2010-04-29 12:30:01 +05:30
José Valim
1b816d5024
The rake task :environment now loads config/environment.rb instead of initializing the application on its own. This fixes [ #4492 state:resolved] and also avoids the application being initialized twice in some rake tasks.
2010-04-29 08:39:52 +02:00
Ernie Miller
e33d304975
Fix eager loading of associations causing table name collisions
...
[#4463 state:committed]
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2010-04-28 20:28:51 -07:00
Jeremy Kemper
4e75cc59e7
object_id may be negative, producing an invalid symbol. h/t Markus Schirp
2010-04-28 15:20:35 -07:00
José Valim
209ab7e05b
Fix failing test.
2010-04-28 23:42:55 +02:00
Santiago Pastorino
3afa4847d9
failing test for: validates_acceptance_of overrides database fields
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-04-28 23:35:13 +02:00
Santiago Pastorino
ce48b3103a
Makes validates_acceptance_of to not override database fields [ #4460 state:committed]
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-04-28 23:12:03 +02:00
Xavier Noria
b9ab4c780a
Merge commit 'rails/master'
2010-04-28 13:41:21 -07:00
Jeremy Kemper
22184930ea
Bundle json and yajl-ruby gems for AS::JSON testing
2010-04-28 09:02:45 -07:00
Cezary Baginski
1067a7be52
Fix BigDecimal JSON encoding test. [ #4495 state:resolved]
...
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2010-04-28 09:02:03 -07:00
Jeremy Kemper
fe93cd8bc5
Fix prototype grep depending on JSON encoding regexp as JavaScript regexp
2010-04-27 22:52:37 -07:00
rohit
8f1a5bfee1
readability fixes to two paras in Refactorization
2010-04-28 11:21:45 +05:30
rohit
edcbd33785
replaced <b> tag with <strong> tag in samples
2010-04-28 10:48:55 +05:30
rohit
9dea2f4d8e
fixed para for better readability
2010-04-28 10:43:36 +05:30
rohit
56c48f8136
Fixed incomplete para
2010-04-28 10:38:06 +05:30
Curtis Hawthorne
7e06494e32
Destroy respects optimistic locking.
...
Now works with :dependent => :destroy and includes unit tests for that
case. Also includes better error messages when updating/deleting stale
objects.
[#1966 state:committed]
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2010-04-27 21:53:51 -07:00
Nathan Weizenbaum
ef5dadaf93
Only run load hooks once a file has been fully loaded.
...
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2010-04-27 21:37:40 -07:00
rohit
c6a8337851
added notice to all samples of show.html.erb of posts controller
2010-04-28 08:09:27 +05:30
rohit
033b1e68c0
added views dir to list of created things
2010-04-28 08:06:28 +05:30
Jeremy Kemper
7100c9d6ca
Switch driver to pg. [ #3635 state:resolved]
2010-04-27 17:08:01 -07:00
Xavier Noria
97b3936318
release notes: updates path to the rails command in the Rails repo
2010-04-27 22:43:55 +02:00
Brian Durand
ee51b51b60
ActiveSupport::Cache refactoring
...
All Caches
* Add default options to initializer that will be sent to all read, write, fetch, exist?, increment, and decrement
* Add support for the :expires_in option to fetch and write for all caches. Cache entries are stored with the create timestamp and a ttl so that expiration can be handled independently of the implementation.
* Add support for a :namespace option. This can be used to set a global prefix for cache entries.
* Deprecate expand_cache_key on ActiveSupport::Cache and move it to ActionController::Caching and ActionDispatch::Http::Cache since the logic in the method used some Rails specific environment variables and was only used by ActionPack classes. Not very DRY but there didn't seem to be a good shared spot and ActiveSupport really shouldn't be Rails specific.
* Add support for :race_condition_ttl to fetch. This setting can prevent race conditions on fetch calls where several processes try to regenerate a recently expired entry at once.
* Add support for :compress option to fetch and write which will compress any data over a configurable threshold.
* Nil values can now be stored in the cache and are distinct from cache misses for fetch.
* Easier API to create new implementations. Just need to implement the methods read_entry, write_entry, and delete_entry instead of overwriting existing methods.
* Since all cache implementations support storing objects, update the docs to state that ActiveCache::Cache::Store implementations should store objects. Keys, however, must be strings since some implementations require that.
* Increase test coverage.
* Document methods which are provided as convenience but which may not be universally available.
MemoryStore
* MemoryStore can now safely be used as the cache for single server sites.
* Make thread safe so that the default cache implementation used by Rails is thread safe. The overhead is minimal and it is still the fastest store available.
* Provide :size initialization option indicating the maximum size of the cache in memory (defaults to 32Mb).
* Add prune logic that removes the least recently used cache entries to keep the cache size from exceeding the max.
* Deprecated SynchronizedMemoryStore since it isn't needed anymore.
FileStore
* Escape key values so they will work as file names on all file systems, be consistent, and case sensitive
* Use a hash algorithm to segment the cache into sub directories so that a large cache doesn't exceed file system limits.
* FileStore can be slow so implement the LocalCache strategy to cache reads for the duration of a request.
* Add cleanup method to keep the disk from filling up with expired entries.
* Fix increment and decrement to use file system locks so they are consistent between processes.
MemCacheStore
* Support all keys. Previously keys with spaces in them would fail
* Deprecate CompressedMemCacheStore since it isn't needed anymore (use :compress => true)
[#4452 state:committed]
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2010-04-27 11:13:37 -07:00
Xavier Noria
1d63129eff
use ordinary syntax for options to be well-formed in 1.8
2010-04-27 02:36:34 -07:00
wycats
91963e9e33
Merge branch 'master' of github.com:rails/rails
2010-04-26 23:32:30 -07:00
Jeremy Kemper
c1d7327071
JSON: encode objects that don't have a native JSON representation using to_hash, if available, instead of instance_values (the old fallback) or to_s (other encoders' default). Encode BigDecimal and Regexp encode as strings to conform with other encoders. Try to transcode non-UTF-8 strings.
2010-04-26 19:55:39 -07:00
Jeremy Kemper
43e2fd93b4
Update CHANGELOG for include_root_in_json.
2010-04-26 15:21:04 -07:00
Santiago Pastorino
7cd1d37a51
Reuse Active Model serialization in Active Resource. [ #2584 state:committed]
...
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2010-04-26 15:00:26 -07:00
Santiago Pastorino
76d6a99364
Use explicit source encoding rather than forced UTF-8 from US-ASCII.
...
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2010-04-26 14:45:23 -07:00
eparreno
a571314755
fix font formats and code examples indentation
2010-04-26 22:32:10 +02:00
Anil Wadghule
53c13f1aca
Use Config::CONFIG['host_os'] instead of RUBY_PLATFORM [ #4477 state:resolved]
...
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2010-04-26 11:12:52 -07:00
unknown
e813ad2a42
Make db console work for all versions of ruby on Windows.
...
[#3999 state:committed]
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2010-04-26 10:57:44 -07:00
David Chelimsky
176fbfd66f
extract ActionController::TestCase::Behavior
...
- this makes it possible for other test frameworks
to hook into testing facilities provided by Rails
without having to subclass AC::TestCase.
[#4474 state:resolved]
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-04-26 09:52:38 +02:00
José Valim
9b5a1f7ac1
No need to require test and rdoc tasks.
2010-04-26 09:37:15 +02:00
José Valim
e461e1bc0e
Ensure application rake tasks and generators are loaded after the ones specified in railties/engines/rails. [ #4471 state:resolved]
2010-04-26 09:36:13 +02:00
José Valim
c9132c149c
Refactor tests by moving all middleware tests to the same place.
2010-04-26 09:04:04 +02:00
Jeremy Kemper
2a6e0f34ad
Revert "create option to include_root_in_json for ActiveResource [ #2584 state:committed]"
...
This reverts commits 72f89b5d97 , 137d8e0b2f .
Should reuse Active Model.
[#2584 state:incomplete]
2010-04-25 21:04:19 -07:00
Cezary Baginski
490a3335d5
Action Pack: fix tests with -K*, work around Ruby 1.9.1 constant lookup.
...
[#4473 state:committed]
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2010-04-25 17:00:20 -07:00
Xavier Noria
7b15629b93
the names of Rails components have a space, eg "Active Record"
2010-04-25 20:40:39 +02:00
Andrew White
8ec085bf18
Support fixtures for namespaced models [ #2965 state:resolved]
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-04-25 16:04:38 +02:00
reu
77c099c231
Fix validates_numericaly_of only integer error message [ #4406 state:resolved]
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-04-25 10:14:15 +02:00
Mikel Lindsaar
8ae5cc8380
Fixing typo in guide, updating ActionMailer description and making the contributors list alphabetical
2010-04-25 17:22:39 +10:00
Mikel Lindsaar
e1b255aca4
Merge branch 'master' of github.com:lifo/docrails
2010-04-25 17:07:55 +10:00
David Chelimsky
864bd9c21f
allow unsubscribe by name or subscription [ #4433 state:resolved]
...
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2010-04-24 22:06:24 -07:00
Rohit Arondekar
a5955196f2
Removed mentions of controller specific layouts. Ticket Ref: http://bit.ly/9dqvBI
2010-04-24 21:51:25 -07:00
Jeremy Kemper
df886c4c89
Missed commit: explicit source encoding
2010-04-24 18:52:51 -07:00
Jeremy Kemper
403752e289
Explicit source encoding
2010-04-24 18:35:12 -07:00
Jeremy Kemper
bd3cc6bfff
Remove quoted_string_prefix entirely since PostgreSQL was the only database adapter relying on it.
2010-04-24 16:27:20 -07:00
Santiago Pastorino
ed0ca5db9e
Add a test for assert_recognizes on ActionDispatch::IntegrationTest [ #4390 state:committed]
...
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2010-04-24 15:43:12 -07:00
Matthew Rudy Jacobs
5c9d23f870
Make assert_recognizes work in IntegrationTest [ #4390 state:committed]
...
Signed-off-by: Santiago Pastorino <santiago@wyeworks.com >
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2010-04-24 15:42:55 -07:00
Jeremy Kemper
426f93b751
PostgreSQL: always rely on pg driver for escape/unescape and quoting duties
2010-04-24 15:38:36 -07:00
Jeremy Kemper
dac80f779d
PostgreSQL: use standard-conforming strings if possible
2010-04-24 15:27:18 -07:00
Jeremy Kemper
72a3e4b77b
Rename fieldWithErrors style to field_with_errors. Remove unused alert style.
2010-04-24 15:02:12 -07:00
Jeremy Kemper
2538ef0d09
Use Array.wrap to quiet 1.8.8 deprecation
2010-04-24 13:12:07 -07:00
Jeremy Kemper
70625badcf
Drop support for postgres driver. Use pg >= 0.9.0.
2010-04-24 12:27:56 -07:00
Jeremy Kemper
577034decb
Ensure require and load are private - h/t apeiros
2010-04-24 10:38:41 -07:00
José Valim
aaaa1782b4
Fix render :xml test (ht Simo Niemelä)
2010-04-24 11:48:47 +02:00
Nicolas Sanguinetti
d5d717161d
Allow :remote => false to be passed to link_to
...
And add tests for `button_to` and `form_tag` which currently behave as
expected, so we avoid a regression.
Signed-off-by: wycats <wycats@gmail.com >
2010-04-22 15:29:59 -07:00
Santiago Pastorino
19cecc907f
HWIA relies on Hash#symbolize_keys and #stringify_keys extensions.
...
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2010-04-22 11:02:15 -07:00
Jeremy Kemper
c976784381
Change HWIA#stringify_keys to return a HWIA not a Hash
2010-04-22 10:07:33 -07:00
Jeremy Kemper
d692e6be30
Restore HWIA#stringify_keys! and update changelog
2010-04-22 10:00:23 -07:00
Santiago Pastorino
ebf9820f7e
HWIA symbolize_keys now returns a hash so no need to do this anymore
...
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2010-04-22 09:07:53 -07:00
Santiago Pastorino
920df0a475
Make ActionDispatch url_for use HWIA symbolize_keys
...
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2010-04-22 09:06:55 -07:00
Santiago Pastorino
2472f1026a
HWIA delegates to to_hash symbolize_keys and stringify_keys and bang methods are not in the api
...
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2010-04-22 09:06:44 -07:00
J Smith
275e839b8d
Ensure that url_for uses symbolized keys in the controller. [ #4391 ]
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-04-22 16:47:36 +02:00
José Valim
9476daa829
Speed up xml serializer by computing values just once and remove unecessary code duplication.
2010-04-22 12:29:08 +02:00
José Valim
81fb742488
Always downstream given options in :json, :xml and :js renderers and add tests for it.
2010-04-22 12:12:38 +02:00
José Valim
4163ccec23
Clean up the config object in ActionPack. Create config_accessor which just delegates to the config object, reducing the number of deprecations and add specific tests.
2010-04-22 12:00:13 +02:00
Santiago Pastorino
a8330c2006
params already has a setted controller and action here
...
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2010-04-21 17:46:37 -07:00
Santiago Pastorino
5c9c30ac65
url_for now works with HashWithIndifferentAccess ht jay [ #4391 state:committed]
...
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2010-04-21 17:09:14 -07:00
Daniel Neighman
726b5d7984
updates String#to_(date|date_time|time) to return nil for blank strings
2010-04-21 16:54:33 -07:00
Andre Arko
b73177a095
Squash backtraces from Bundler.setup
2010-04-21 14:45:13 -07:00
Santiago Pastorino
961aa70e4a
Some require indifferent_access added
...
Signed-off-by: Xavier Noria <fxn@ubuntu.(none)>
2010-04-21 07:45:29 -07:00
Santiago Pastorino
5467728d83
require without .rb
...
Signed-off-by: Xavier Noria <fxn@ubuntu.(none)>
2010-04-21 07:41:45 -07:00
Rohit Arondekar
606bed1a77
Replaced f.error_messages with the new code as generated by rails 3 b3
2010-04-20 23:23:32 -07:00
wycats
62916ecbbe
It should be possible to render :json with options
2010-04-20 22:29:00 -07:00
Santiago Pastorino
d1911a0707
TimeZones lazy load
...
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2010-04-20 21:40:24 -07:00
Pratik Naik
2ff73039bd
Build PredicateBuilder object only when needed
2010-04-21 02:43:52 +01:00
José Valim
da32661f10
Remove only formats in shortcuts and do it just once.
2010-04-20 21:19:48 +02:00
José Valim
2e3d903e1b
Move observers initialization to after_config blocks, they are still being initialized to early (before load paths are being set).
2010-04-20 21:19:48 +02:00
Jeremy Kemper
9934738ed5
Switch to TimezoneProxy for later support of deferred TZ loading
2010-04-20 10:54:37 -07:00
Santiago Pastorino
a90a076613
Missing requires added
...
Signed-off-by: Xavier Noria <fxn@hashref.com >
2010-04-20 07:45:54 -07:00
Rohit Arondekar
adda7516e9
minor fix and re-organized description of index action
2010-04-20 02:07:16 -07:00
Mikel Lindsaar
60ab54113f
Needed to update release notes too
2010-04-20 14:45:47 +10:00
Mikel Lindsaar
a9d0578711
Adding auto encoding of headers and bodies to the guide for ActionMailer
2010-04-20 14:45:30 +10:00
Phil Smith
d03196c89e
Regexp.escape(load_path) in add_routing_namespaces initializer [ #4442 state:resolved]
...
Signed-off-by: Michael Koziarski <michael@koziarski.com >
2010-04-20 08:53:46 +12:00
Santiago Pastorino
86a43ed8a1
Changed versions to ruby 1.8.7 and Rails 3.0.0
2010-04-19 13:50:59 -03:00
Santiago Pastorino
e35dcd64bc
Rails 3.0.0 version bootup messages
2010-04-19 12:35:59 -03:00
Santiago Pastorino
fa2e70b6e0
let's talk about the same path
2010-04-19 12:34:42 -03:00
Santiago Pastorino
fdf032d673
rails about is now rake about
2010-04-19 12:30:58 -03:00
Santiago Pastorino
69bd542d61
test refactor
2010-04-19 11:44:11 -03:00
Santiago Pastorino
137d8e0b2f
Make this test pass on > 1.9
2010-04-19 11:44:11 -03:00
Xavier Noria
792910bb69
Merge commit 'rails/master'
2010-04-19 05:10:55 -07:00
Cheah Chu Yeow
ad4615e978
Rails on Rack Rails guide: indicate that Metal pieces now require an "X-Cascade" header with a value of "pass" to continue the Metal chain execution instead of a HTTP 404 response. Also removed reference to old code.
2010-04-19 05:09:40 -07:00
Rohit Arondekar
15efaa701a
Fixes to the getting started guide
2010-04-19 05:09:29 -07:00
Xavier Noria
bb19f20876
much complete rdoc for String#ord
2010-04-19 05:04:18 -07:00
Xavier Noria
0f0b40d3b6
revises the rdoc of String#ord
2010-04-19 05:04:18 -07:00
Xavier Noria
9428473f9d
AS guide: AS no longer extends Pathname
2010-04-19 05:04:18 -07:00
eparreno
c52dbdc888
fix testing guide: fonts and code format
2010-04-19 05:04:18 -07:00
Cheah Chu Yeow
e00c72c971
Rails on Rack Rails guide: indicate that Metal pieces now require an "X-Cascade" header with a value of "pass" to continue the Metal chain execution instead of a HTTP 404 response. Also removed reference to old code.
2010-04-19 18:29:18 +08:00
Rohit Arondekar
a870c4928c
Cleaned up the table of files created by scaffolding a Post.
2010-04-19 03:12:52 -07:00
Rohit Arondekar
3948ba89e1
Fixed wrong purpose of _form.html.erb
2010-04-19 02:54:50 -07:00
Rohit Arondekar
2bae20138a
Replaced ',' with 'or' to make it read better.
2010-04-19 02:15:04 -07:00
Jeremy Kemper
03aa7877f7
MemoryStore#read_multi(*keys) for dev-mode compatibility with memcache store
2010-04-19 00:19:10 -07:00
Phil Smith
64373937a3
Make the migration generator handle pre-existing migrations with the same timestamp.
...
In the event a migration already exists with that number, the new migration's timestamp will be incremented by 1.
[#4412 state:resolved]
Signed-off-by: Michael Koziarski <michael@koziarski.com >
2010-04-19 14:48:31 +12:00
Carl Lerche
eb83c9cf42
Merge remote branch 'spastorino/master'
2010-04-18 13:04:04 -07:00
Carl Lerche
d32a4cbaa5
Merge branch 'master' of github.com:rails/rails
2010-04-18 13:02:37 -07:00
Santiago Pastorino
978c80d6e3
Missing require added
2010-04-18 14:02:46 -03:00
Xavier Noria
6f6cddb599
much complete rdoc for String#ord
2010-04-18 11:55:07 +02:00
Santiago Pastorino
b7ea64a86c
remove code for Ruby < 1.8.7
2010-04-18 03:46:01 -03:00
Santiago Pastorino
c4846c99c5
Missing require added
2010-04-18 00:12:08 -03:00
Santiago Pastorino
9c4ac84e49
perform_caching should be accessed through the controller here
2010-04-17 23:40:03 -03:00
Santiago Pastorino
4309c1fda3
perform_caching is now delegated to config on instance and class level
2010-04-17 23:40:03 -03:00
Diego Carrion
8c7e8976e9
added shorthand support for routes like /projects/status(.:format)
...
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2010-04-17 17:53:08 -07:00
Xavier Noria
afcd252205
removes code written for Ruby < 1.8.7
2010-04-17 15:16:38 -07:00
Xavier Noria
7f25e23783
revises the rdoc of String#ord
2010-04-18 00:05:53 +02:00
Xavier Noria
ea3fa4e7ff
AS guide: AS no longer extends Pathname
2010-04-18 00:05:53 +02:00
eparreno
078177a3dc
fix testing guide: fonts and code format
2010-04-17 23:45:08 +02:00
David Chelimsky
4327ad51ab
access assigns as a method or hash, with strings or symbols [ #4431 state:resolved]
2010-04-17 15:59:10 -04:00
Aaron Patterson
d4d352bf94
fisting codes so it will parse [ #4430 state:resolved]
...
Signed-off-by: wycats <wycats@gmail.com >
2010-04-17 15:57:36 -04:00
Sven Fuchs
9a3a4d6aef
Make i18n fallbacks configurable and fallback to the default locale by default in production [ #4428 state:resolved]
...
Allows to configure locale fallbacks through config.i18n.fallbacks. The default setting
config.i18n.fallbacks = true in production.rb will make I18n.t lookup fallback to the
I18n.default_locale if a translation could not be found for the current or given locale.
config.fallbacks = true
config.fallbacks.map = { :ca => :es }
config.fallbacks.defaults = [:'es-ES', :es]
config.fallbacks = [:'es-ES', :es]
config.fallbacks = { :ca => :es }
config.fallbacks = [:'es-ES', :es, { :ca => :es }]
Signed-off-by: Pratik Naik <pratiknaik@gmail.com >
2010-04-17 19:26:46 +01:00
Aaron Patterson
b7693dc028
working around syck defects by optionally matching a space [ #4426 state:resolved]
...
Signed-off-by: wycats <wycats@gmail.com >
2010-04-17 00:50:59 -04:00
Aaron Patterson
d92e3111fe
making yaml tests less specific to emitter. [ #4425 state:resolved]
...
Signed-off-by: wycats <wycats@gmail.com >
2010-04-17 00:41:10 -04:00
Aaron Patterson
cd6578f6a1
fixing invalid yaml [ #4424 state:resolved]
...
Signed-off-by: wycats <wycats@gmail.com >
2010-04-17 00:14:23 -04:00
Santiago Pastorino
e85100da0a
Added missing require
2010-04-16 23:44:39 -03:00
Santiago Pastorino
dadf35b2a9
avoid warning: ambiguous first argument; put parentheses or even spaces
2010-04-16 23:07:55 -03:00
wycats
457f7709e9
Missing requires
2010-04-16 21:59:09 -04:00
Sam Elliott
c16c248912
mail_to with :encode => :javascript now outputs safe html
...
Signed-off-by: Carl Lerche <carllerche@mac.com >
2010-04-16 15:53:55 -07:00
Carl Lerche
ac015b1d07
Revert "Avoid deprecation warnings and potential TypeErrors [ #4404 state:resolved]"
...
Revert "protected instance variables added to the deprecated config accessor
This reverts commit 4bce5ba600 and 0ee2d3c89a .
2010-04-16 15:39:00 -07:00
Xavier Noria
09b9add8c5
Merge commit 'docrails/master'
2010-04-16 15:08:16 -07:00
Kieran Pilkington
001ca893c6
Mark the result of grouped_options_for_select as HTML safe [ #4322 state:committed]
...
Signed-off-by: Xavier Noria <fxn@hashref.com >
2010-04-16 15:05:41 -07:00
Santiago Pastorino
66b55dbfea
Add missing require
2010-04-16 18:44:54 -03:00
Jeremy Kemper
7bd3a105fd
Bump rack-mount dependency to ~> 0.6.3 for CRITICAL FIX
2010-04-16 14:40:24 -07:00
Aaron Patterson
dc94d813e2
fixing invalid yaml [ #4418 state:resolved]
...
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2010-04-16 14:19:31 -07:00
Jeremy Kemper
9f26f95d4a
Revert "Require rack-mount 0.6.0 since 0.6.1 and later can't be bundled"
...
They can be bundled. Just the git repos can't. Use rails/rack-mount for that.
This reverts commit ef6cdc974f .
2010-04-16 13:55:21 -07:00
Jeremy Kemper
1924cff934
Fix Active Model observer tests
2010-04-16 13:14:52 -07:00
Mislav Marohnić
2161b8745a
improve how ActiveRecord::Observer defines callbacks on observed models
...
Instead of using a single `notify_observers` call for every callback type,
each observer now registers a unique callback for itself. Example:
before_save :_notify_user_observer_for_before_save
def _notify_user_observer_for_before_save
observer.update(:before_save, self)
end
Benefit: "before" callbacks halt when `observer.update` returns false.
This way, ActiveRecord observers can prevent records from saving.
[#4087 state:committed]
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2010-04-16 13:12:53 -07:00
Mislav Marohnić
c2ca73c9ee
ActiveModel::Observing: stop using Observable Ruby module, re-implement notify_observers
...
`Observable#notify_observers` from Ruby always returns false (which halts ActiveRecord
callback chains) and has extra features (like `changed`) that were never used.
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2010-04-16 13:09:07 -07:00
Mislav Marohnić
cf616e4876
merge callbacks_observers_test.rb into lifecycle_test.rb where other observers test reside
...
Benefits: test able to run independently, subclassing instead of changing the original Comment model
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2010-04-16 13:09:07 -07:00
Aaron Patterson
779723a0b4
fix a failure and some warnings on 1.9.2 [ #4417 state:resolved]
...
Signed-off-by: Xavier Noria <fxn@hashref.com >
2010-04-16 09:03:42 -07:00
Mikel Lindsaar
f7e9c93141
Fixing up some errors and changing the observer pattern to a much more simple and direct controller pattern
2010-04-17 00:57:40 +10:00
Santiago Pastorino
9c08ccd889
page_cache_extension is delegating to config so no need to deprecate
2010-04-16 11:03:16 -03:00
Santiago Pastorino
5699de1d15
Added test get to js should have a header with content-type text/javascript
2010-04-16 11:03:16 -03:00
Santiago Pastorino
8a8da68d1f
Tidy up a bit this test file
2010-04-16 11:03:16 -03:00
Santiago Pastorino
462a7b45f6
Revert "Add test case which check content type when rendering rjs" partial in html template" rendering rjs in html doesn't make sense, it would just output javascript into the template, no script tag
...
This reverts commit dc251389d1 .
2010-04-16 11:03:16 -03:00
Mislav Marohnić
8a91ccf976
add missing requires to Rescuable and RouteSet [ #4415 state:committed]
...
Signed-off-by: Xavier Noria <fxn@hashref.com >
2010-04-16 06:11:38 -07:00
Jared Giles
9cf65af881
Added a note in the section on complex forms regarding nested attributes in 2.3
2010-04-15 17:04:00 -05:00
Michael Koziarski
5aa58cc03f
Split the observer railtie into two phases.
...
Observers observing models with scopes defined will require the connection to be established.
2010-04-16 09:49:06 +12:00
Santiago Pastorino and Carl Lerche
0ea434e2f4
Make perform_caching work again, with the tests passing and backward compatible
2010-04-15 18:25:08 -03:00
Santiago Pastorino and Carl Lerche
005c2bac46
Revert "logger added to the deprecated config accessor" we need a major refactor to get this working
...
This reverts commit 68f4e046a7 .
2010-04-15 16:58:31 -03:00
Nicolas Sanguinetti
4bce5ba600
Avoid deprecation warnings and potential TypeErrors [ #4404 state:resolved]
...
Signed-off-by: Pratik Naik <pratiknaik@gmail.com >
2010-04-15 14:51:25 +01:00
eparreno
43d03c3a1c
fix ActionController font and replace extract_locale_from_uri with extract_locale_from_tld
2010-04-15 11:05:34 +02:00
Xavier Noria
19fa272b52
Revert "I18n guide: change ActionController by Action Controller in some places and fix code example in 2.4 section"
...
This reverts commit 002da9b6ea .
2010-04-15 10:37:43 +02:00
Santiago Pastorino
68f4e046a7
logger added to the deprecated config accessor
2010-04-14 22:49:53 -07:00
Santiago Pastorino
0ee2d3c89a
protected instance variables added to the deprecated config accessor
2010-04-14 22:49:53 -07:00
Santiago Pastorino
ab808a9d71
asset and helper path added to the deprecated config accessor
2010-04-14 22:49:53 -07:00
Santiago Pastorino
eb8c7b4639
page_cache added to the deprecated config accessor
2010-04-14 22:49:53 -07:00
Santiago Pastorino
a618ad358a
Make use of config.perform_caching
2010-04-14 22:35:13 -07:00
Matthew Rudy Jacobs
fc22552e5f
action_dispatch/routing/deprecated_mapper needs with_options
...
[#4398 state:committed]
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2010-04-14 21:43:35 -07:00
Santiago Pastorino
a0cc94b32e
utc_offset returns nil for unknown zones
...
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2010-04-14 21:15:15 -07:00
Santiago Pastorino
e79193f852
Test for unknown zone with nil utc_offset
...
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2010-04-14 20:27:24 -07:00
Jeremy Kemper
8539e4ee73
Merge branch 'master' of github.com:rails/rails
2010-04-14 17:16:36 -07:00
wycats
14f8e17563
Merge branch 'master' of github.com:rails/rails
2010-04-14 17:15:20 -07:00
wycats
8c3bfa4ce9
Rely specifically on 0.6.0 and add a missing require
2010-04-14 17:15:13 -07:00
Santiago Pastorino
399d5338ac
Fix missing dependency on Hash#to_query
...
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2010-04-14 17:14:50 -07:00
Jeremy Kemper
ef6cdc974f
Require rack-mount 0.6.0 since 0.6.1 and later can't be bundled
2010-04-14 17:04:33 -07:00
eparreno
002da9b6ea
I18n guide: change ActionController by Action Controller in some places and fix code example in 2.4 section
2010-04-14 22:44:40 +02:00
Ryan Bigg
a77b86d57c
Begun documenting YourApp::Application and how it ties in with the backend.
2010-04-14 20:29:15 +10:00
Ryan Bigg
50aa106fa5
Rip out bundler notes, they're now living at http://github.com/radar/how-rails-works/raw/master/bundler.textile . It really needs its own guide.
2010-04-14 19:43:47 +10:00
Xavier Noria
6be04c4631
i18n -> AS/i18n
2010-04-14 02:30:02 -07:00
Ryan Bigg
8b14275f0f
More expansion on Bundler internals.
2010-04-14 19:03:22 +10:00
Xavier Noria
dd635ec701
adds missing requires for arel and i18n, prevents Arel constant from being autoloaded (which was still seen), though it probably hides an issue related to dependencies
2010-04-14 02:01:55 -07:00
Xavier Noria
9a4fdff0af
Merge commit 'docrails/master'
2010-04-14 01:00:03 -07:00
Diego Carrion
e090898c5e
fixed typo in RUNNING_UNIT_TESTS
2010-04-14 13:15:51 +10:00
Ryan Bigg
d45cacc837
Use <plain> instead of <text>
2010-04-14 13:15:51 +10:00
Pratik Naik
2ff5f38abb
Ensure not to load the entire association when bulk updating existing records using nested attributes
2010-04-14 01:52:29 +01:00
Craig Davey
5208cc3cf5
Changed translate helper so that it doesn’t mark every translation as safe HTML. Only keys with a "_html" suffix and keys named "html" are considered to be safe HTML. All other translations are left untouched.
...
Signed-off-by: David Heinemeier Hansson <david@loudthinking.com >
2010-04-13 17:35:10 -07:00
Santiago Pastorino
0ab2ba336f
config.perform_caching added to the deprecated config accessor [ #4383 state:committed]
...
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2010-04-13 16:20:49 -07:00
Chetan Sarva
9059472177
Added tests for config.action_controller.perform_caching
...
Signed-off-by: Santiago Pastorino <santiago@wyeworks.com >
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2010-04-13 16:20:34 -07:00
Xavier Noria
0e274639b4
removes unnecessary assignment and local variable in AR::Base#subclasses, and revises its rdoc
2010-04-13 16:11:36 -07:00
José Valim
c88b9337cf
Allow a Rails application to be initialized from any directory and not just from inside it (ht: Andre Arko).
2010-04-14 00:02:00 +02:00
Santiago Pastorino
bd34df00cf
Bring back bin/rails to life on edge
2010-04-13 14:23:38 -07:00
wycats
8e9df34fa3
Merge branch 'master' of github.com:rails/rails
2010-04-13 14:07:46 -07:00
José Valim
b4fd5e6f1a
template_name and template_path should not be added to mail headers.
2010-04-13 23:04:22 +02:00
Stanko Alexander
dc251389d1
Add test case which check content type when rendering rjs partial in html template
...
Signed-off-by: wycats <wycats@gmail.com >
2010-04-13 13:09:41 -07:00
Anil Wadghule
518891f490
Use correct RUBY_PLATFORM regex for Windows env [ #4385 state:resolved]
...
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2010-04-13 12:39:03 -07:00
David Heinemeier Hansson
8116a2b981
Cleanup indention and spacing and turn errorExplanation into error_explanation now that nobody depends on it anymore
2010-04-13 12:33:34 -07:00
David Heinemeier Hansson
5c897270c2
Simple release script
2010-04-13 12:26:15 -07:00
David Heinemeier Hansson
4c8af9bf51
Update changelogs for release
2010-04-13 12:14:54 -07:00
Jeremy Kemper
4d098327da
Fix regexp typo
2010-04-13 12:06:12 -07:00
Santiago Pastorino
7fa6c16b70
Added missing require and delete unused one on proc.rb
2010-04-13 13:33:16 -03:00
Anil Wadghule
fe0b52befb
Changes in guide as per Rails 3 features
2010-04-13 12:25:44 +05:30
Norman Clarke
dceef0828a
Improve reliability of Inflector.transliterate. [ #4374 state:resolved]
...
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2010-04-12 23:19:39 -07:00
wycats
36f3634a6a
Add a test that used to fail but is fixed now [ #3417 state:resolved]
2010-04-12 21:57:40 -07:00
Craig R Webster
54533d28ef
Fix a typo in the documentation. [ #4318 state:resolved]
...
Signed-off-by: wycats <wycats@gmail.com >
2010-04-12 21:45:39 -07:00
Andrew White
9cea9bc7f0
Refactor compute_type to handle situations where the correct class is already loaded
...
Signed-off-by: wycats <wycats@gmail.com >
2010-04-12 21:31:20 -07:00
stlruby@googlegroups.com
ee04aea3ec
Remove RAILS_ROOT from webrick_server docs.
...
Signed-off-by: wycats <wycats@gmail.com >
2010-04-12 21:28:39 -07:00
Emmanuel Oga
f8eddcc735
make ActiveRecord::Base.subclasses a public method
...
Signed-off-by: wycats <wycats@gmail.com >
2010-04-12 21:20:45 -07:00
Anil Wadghule
219c81b9e1
Replace deprecated RAILS_ROOT to Rails.env [ #4373 state:resolved]
...
Signed-off-by: wycats <wycats@gmail.com >
2010-04-12 21:13:19 -07:00
Felipe Rodrigues
a64bfc3c8e
moved rails binary to rails gem, so rubygems can find specific versions of rails [ #4382 state:resolved]
...
Signed-off-by: wycats <wycats@gmail.com >
2010-04-12 19:56:38 -07:00
Santiago Pastorino
3c456a869a
Fix namespaced_controllers_with_namespaced_routes test
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-04-13 01:11:14 +02:00
Andre Arko
ca378659bc
Update the Bundler snippet for 0.9.15 and above
2010-04-12 15:44:08 -07:00
Anil Wadghule
3f0097c715
Updated guide to use 'Rails.root.join' to construct path
2010-04-13 00:56:34 +05:30
José Valim
86defed5ad
Fix a bug in url generation for generic routes.
2010-04-12 20:23:35 +02:00
Santiago Pastorino
25cb21328a
Make dev and edge app generation options generate edge arel on Gemfile
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-04-12 19:48:08 +02:00
Anil Wadghule
84e46437fa
Replace 'RAILS_ROOT' to 'Rails.root' and 'RAILS_ENV' to 'Rails.env' in significant places.
2010-04-12 22:53:49 +05:30
José Valim
a8b1ca26d7
Ensure match path, :controller => name works as expected.
2010-04-12 16:49:41 +02:00
Malcolm Locke
41bcf06d32
low and behold => lo and behold!
2010-04-12 23:47:33 +12:00
Joe Van Dyk
ccf33660a1
Avoid unnecessary allocations in Inflector.underscore [ #3626 state:resolved]
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-04-12 11:09:49 +02:00
Phil Smith
bab1f910c7
table_name_prefix and table_name_suffix are class_attributes instead of cattr_accessors. [ #4230 ]
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-04-12 10:59:38 +02:00
Andrew White
788d923893
Generate module file for namespaced models [ #4230 state:resolved]
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-04-12 10:57:27 +02:00
Anil Wadghule
b9b9f9ee15
Make RUBY_PLATFORM windows regex consistent [ #4345 state:resolved]
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-04-12 10:56:34 +02:00
José Valim
3eda7cf090
Let capture handle the yielding.
2010-04-12 10:55:43 +02:00
José Valim
3fc609ee41
Fix ActionMailer test broken in 99d5459921
2010-04-12 10:50:27 +02:00
José Valim
b5f9a9fce3
Move set_fields! to the old API module.
2010-04-12 10:25:02 +02:00
Ryan Bates
e5f392ce8f
fields_for returns block result when outside ERB
...
Signed-off-by: wycats <wycats@gmail.com >
2010-04-11 19:26:00 -07:00
wycats
59c6082d98
Merge remote branch 'mikel/master'
2010-04-11 19:20:39 -07:00
Aaron Patterson
ecf039fc05
mode postgresql adapters table_exists? method take the schema in to account. [ #4341 state:resolved]
...
Signed-off-by: wycats <wycats@gmail.com >
2010-04-11 14:53:24 -07:00
wycats
803df08d89
Merge branch 'master' of github.com:rails/rails
2010-04-11 14:53:17 -07:00
José Valim
1f80b8b04f
Merge branch 'master' of gitproxy:rails/rails
2010-04-11 12:07:47 +02:00
Santiago Pastorino
5b89fd07b2
Make namespace work with options[:to] [ #4351 state:committed]
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-04-11 12:05:43 +02:00
Xavier Noria
fb4b454de1
your beloved typo only spotted in github diff no matter how careful you were before pushing
2010-04-11 02:56:19 -07:00
Xavier Noria
9111f4268b
second pass to the intro rdoc of form_helper.rb
2010-04-11 02:50:07 -07:00
Xavier Noria
1afee7ace8
Merge commit 'rohit/master'
2010-04-11 02:03:25 -07:00
Mikel Lindsaar
dd02090d76
Updating changelog for Mail 2.2.0
2010-04-11 18:06:30 +10:00
Mikel Lindsaar
fc5d817145
Updating actionmailer to Mail version 2.2.0
2010-04-11 18:04:57 +10:00
Mikel Lindsaar
2a793fa2a8
New mail is more intelligent on encoding and decoding
2010-04-11 18:04:57 +10:00
Mikel Lindsaar
bd89c391e8
Cleaning up expectations from the new way mail does it
2010-04-11 18:04:56 +10:00
Mikel Lindsaar
fd9ee49f38
Moved test of QP into mail
2010-04-11 18:04:56 +10:00
Mikel Lindsaar
a9e918f40e
Don't need no quoting test, done in mail
2010-04-11 18:04:56 +10:00
Mikel Lindsaar
03dd8f7917
Mail::Part now no longer has nil as a default charset, it is always set to something, and defaults to UTF-8
2010-04-11 18:04:55 +10:00
Mikel Lindsaar
e157a3d222
Added explict setting of charset in set_fields! method to make sure Mail has the user defined default
2010-04-11 18:04:55 +10:00
Mikel Lindsaar
6c6bef245a
Fixing up some bad test cases
2010-04-11 18:04:55 +10:00
Mikel Lindsaar
dbcf01e631
Removing quoting.rb, upgrade to 2.1.3.6, changing all utf-8 references to UTF-8, updating tests where incorrect encoding
2010-04-11 18:04:55 +10:00
Mikel Lindsaar
8f22be04dc
Removing quoting and adding Mail 2.3.5
2010-04-11 18:04:54 +10:00
Jeremy Kemper
6d29f9789e
Fix evals missing context
2010-04-10 22:39:10 -07:00
Jeremy Kemper
86dda361e2
Avoid deprecated String#to_a by using Array.wrap(...) instead of Array(...)
2010-04-10 22:37:36 -07:00
Aaron Patterson
61355c0e24
clearing up many warnings, removing unnecessary regular expresion comparisons [ #4365 state:resolved]
...
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2010-04-10 22:13:42 -07:00
Rohit Arondekar
c7e2b6413d
Fixed indentation of database.yml examples.
2010-04-10 19:38:05 -07:00
Rohit Arondekar
a3e70ad578
Fixed indentation of database.yml examples.
2010-04-10 18:28:57 -07:00
Xavier Noria
b7d8f5a329
removes some duplication in previous edit
2010-04-10 16:53:25 -07:00
Xavier Noria
ef2ec071de
makes a pass to the intro rdoc of form_helper.rb, will revise form_for tomorrow
2010-04-10 16:49:39 -07:00
wycats
76e0a9eb5b
Not using class_eval wasn't adding clarity here
2010-04-10 16:16:31 -07:00
Santiago Pastorino
95d13cca7b
form_for :as rubydoc and tidy up a bit the form_for doc
2010-04-10 15:32:20 -07:00
wycats
093ab3ec6e
Use <plain>, not <pre> in guides
2010-04-10 17:35:31 -04:00
wycats
87f7093ee3
Merge branch 'master' into docrails_master
2010-04-10 17:22:52 -04:00
wycats
381f877bbb
Revert "Revert "Use path_names, not resource_path_names, consistently""
...
This reverts commit d3ec4b1ba6 .
2010-04-10 15:54:29 -04:00
mfoster
5850edf104
Made arrays of ActiveRecords, and any classes, with namespaces convert to valid xml. [ #3824 state:resolved]
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-04-10 18:12:43 +02:00
Doug Alcorn
dc97430630
ActiveSupport::BacktraceCleaner#remove_filters! allows for completely untouched backtrace [ #4079 state:resolved]
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-04-10 14:06:10 +02:00
Aaron Patterson
f46dc9b6b7
clear the rest of the warnings, run with warnings turned on [ #4332 state:resolved]
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-04-10 13:50:38 +02:00
Aaron Patterson
922e4c57a4
kill warnings on 1.8.7 [ #4331 state:resolved]
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-04-10 13:50:35 +02:00
José Valim
b22d0914ac
Fix a typo in load_once_paths [ #4357 state:resolved] (ht: Kim Altintop)
2010-04-10 13:29:57 +02:00
Ryan Bigg
d748cc3cd0
Re-define empty? for errors to check if the values inside the OrderedHash are empty rather than the OrderedHash itself. [ #4356 state:resolved]
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-04-10 13:21:20 +02:00
José Valim
944637648c
Use pluralize to properly inflect the number of errors.
2010-04-10 12:45:28 +02:00
José Valim
ee309d506c
Update versions (otherwise you install a gem from source as beta3 but internally it's beta2) and update CHANGELOG.
2010-04-10 12:17:34 +02:00
José Valim
55d159b25d
Remove error_messages_for data from locale.
2010-04-10 11:50:09 +02:00
José Valim
ece157e950
Move verification to a plugin as well: http://github.com/rails/verification.git
2010-04-10 11:47:20 +02:00
José Valim
26e05efdb6
Remove error_messages_for from scaffold.
2010-04-10 11:18:20 +02:00
José Valim
2f79c5b485
Merge branch 'master' of gitproxy:rails/rails
2010-04-10 10:55:19 +02:00
wycats
5087b831a0
Updated changelog
2010-04-10 04:54:25 -04:00
José Valim
cd79a46174
Remove input, form, error_messages_for and error_message_on from the framework. If you think you will miss them, feel free to use the dynamic_form plugin available at http://github.com/rails/dynamic_form
2010-04-10 10:53:05 +02:00
wycats
3401b9ba6d
Update the routing guide for style and to add information on new routing features
2010-04-10 04:51:41 -04:00
José Valim
d3ec4b1ba6
Revert "Use path_names, not resource_path_names, consistently"
...
Breaks tests on Ruby 1.8.7.
This reverts commit 13bbf98d85 .
2010-04-10 10:47:40 +02:00
wycats
13bbf98d85
Use path_names, not resource_path_names, consistently
2010-04-10 02:56:28 -04:00
Jeremy Kemper
7353fc1595
Dial back from 'namespace :controller => ...' to 'scope :module => ...'
2010-04-09 23:09:15 -07:00
Jeremy Kemper
561d9eff0c
Add test showing root match in path namespace
2010-04-09 22:12:06 -07:00
Jeremy Kemper
ac0280c39d
Routes can be selectively namespaced by path or controller module
2010-04-09 21:48:35 -07:00
Jeremy Kemper
e77a0311e5
Refactor for readability
2010-04-09 19:33:55 -07:00
Santiago Pastorino
c09744bec9
Fixed method sign error
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-04-09 23:05:26 +02:00
Xavier Noria
ee8e9d5484
release notes: updates instructions for installing the current beta
2010-04-09 14:02:44 -07:00
Santiago Pastorino
13e00ce606
fix stack trace lines on class_eval
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-04-09 21:28:49 +02:00
Xavier Noria
8b2266a8da
image_path -> path_to_image in a couple of places, plus motivation for path_to_image in rdoc
2010-04-09 11:10:26 -07:00
David Heinemeier Hansson
38f1d3543e
Stray carrier returns
2010-04-09 11:05:26 -07:00
David Heinemeier Hansson
00ff3ba56f
Need a double escape there
2010-04-09 10:52:28 -07:00
David Heinemeier Hansson
915a0ac420
Notice/alert are out of the layout, so notice has to go back into show to make it work for scaffolding
2010-04-09 10:48:51 -07:00
Norman Clarke
e416f1d0ab
Make tidy_bytes work on 1.9 and improve its performance. [ #4350 state:resolved]
...
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2010-04-09 10:30:37 -07:00
Jeremy Kemper
ad22017bdc
Use thor shorthand for indicating that application.html.erb is a template
2010-04-09 10:26:49 -07:00
Jeremy Kemper
ec8e747960
Partially revert "A new application now comes with a layout and a stylesheet."
...
This reverts commit ea2c5fa804 .
Conflicts:
railties/lib/rails/generators/rails/app/templates/app/views/layouts/application.html.erb
railties/test/generators/app_generator_test.rb
2010-04-09 10:04:20 -07:00
Jeremy Kemper
c44cacb070
Include app name in layout title
2010-04-09 09:49:46 -07:00
Jeremy Kemper
ea6a67cbdf
Discourage << as public API, much less config
2010-04-09 09:22:16 -07:00
Jeremy Kemper
19e6006636
Layout contents are html-safe
2010-04-09 09:14:02 -07:00
Jeremy Kemper
157216b7b7
Trim application.html.erb fat
2010-04-09 09:13:47 -07:00
Ryan Bigg
da69c5d8bf
Expansion on require method from runtime.rb
2010-04-09 04:49:56 -07:00
Ryan Bigg
69d5259480
Continue expanding on Bundler.
2010-04-09 04:49:56 -07:00
Ryan Bigg
c93580b480
Further work on the bundler section. Almost there now.
2010-04-09 04:49:56 -07:00
Ryan Bigg
e35f05cc8e
Mention a way to turn off bundler and begin talking about version_requirements
2010-04-09 04:49:55 -07:00
Ryan Bigg
b2a2d9f91b
Further expansion into how Bundler loads the gemfile.
2010-04-09 04:49:55 -07:00
eparreno
5fa70e8ba9
CL guide: revises fonts in a few places
2010-04-09 04:49:36 -07:00
Jaime Iniesta
1133146679
update changelog
2010-04-09 04:45:03 -07:00
Jaime Iniesta
40e9cb6f4d
Fixed duplicated IDs on active_record_querying guide to validate XHTML 1.0 Strict
2010-04-09 04:45:03 -07:00
Jaime Iniesta
647addd8e0
Fixed duplicated IDs on associations_basics guide to validate XHTML 1.0 Strict
2010-04-09 04:45:03 -07:00
James Miller
4f0982db91
More on the new ERB syntax in the guides
2010-04-09 04:45:02 -07:00
James Miller
42d3764b3d
ERB update for AC overview guide
2010-04-09 04:45:02 -07:00
Xavier Noria
773b2f0c9b
adds an entry for #favicon_link_tag in AP's CHANGELOG
2010-04-09 04:06:14 -07:00
Ryan Bigg
11f838dc2e
Expansion on require method from runtime.rb
2010-04-09 17:52:34 +10:00
José Valim
cb8fa3573c
Still use the directory command and also remove the fixture comments.
2010-04-09 08:47:19 +02:00
Ryan Bigg
395dbd53ed
Continue expanding on Bundler.
2010-04-09 15:34:13 +10:00
Santiago Pastorino
a654ef2ee1
Don't include fixtures if --skip-activerecord is given
2010-04-09 16:46:40 +12:00
Ryan Bigg
ce30d0f2bb
Further work on the bundler section. Almost there now.
2010-04-09 14:03:58 +10:00
Santiago Pastorino
808847792c
db:test:prepare for tasks only if AR is loaded
2010-04-09 16:03:27 +12:00
Jeremy Kemper
4691c696b0
Expect an incompatible encoding exception when a template with a magic comment renders a partial without one and its source encoding doesn't match the default external encoding
2010-04-08 20:22:07 -07:00
Jeremy Kemper
bd2bf5390d
Expect an incompatible encoding exception when a template doesn't have a magic comment and its source encoding doesn't match the default external encoding
2010-04-08 19:27:39 -07:00
Xavier Noria
fd7202a756
adds #favicon_link_tag back, rdoc explains why it is useful, and how to get a link for Mobile Safari with it
2010-04-08 18:13:23 -07:00
Carl Lerche
99d5459921
Fixed that default locale templates should be used if the current locale template is missing [DHH]
2010-04-08 18:11:26 -07:00
Michael Koziarski
1e3dce08e1
Revert "When creating database with rake, create schemas in schema_search_path if it doesn't exist."
...
This reverts commit 6c2a0675f1 .
Reverting because it breaks the ability to run tests using a non-superuser.
Conflicts:
activerecord/lib/active_record/connection_adapters/postgresql_adapter.rb
activerecord/lib/active_record/railties/databases.rake
2010-04-09 11:30:40 +12:00
Michael Koziarski
82514c2897
Add accessors for request and response so tests don't have to mess with internal ivars
2010-04-09 11:30:39 +12:00
Ryan Bigg
f4f24cc641
Mention a way to turn off bundler and begin talking about version_requirements
2010-04-09 06:48:41 +10:00
Ryan Bigg
7005e6db47
Further expansion into how Bundler loads the gemfile.
2010-04-09 06:48:41 +10:00
David Heinemeier Hansson
5f808b865c
Consistently use lowercase instead of camelCase for all JS class names in Rails
2010-04-08 12:17:46 -07:00
Aaron Patterson
0e44eb35d6
fisting stack trace [ #4349 state:resolved]
...
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2010-04-08 12:03:57 -07:00
David Heinemeier Hansson
00ee9b3369
Revert "adds #favicon_link_tag and #apple_touch_icon_link_tag" -- these tags are too specific.
...
This reverts commit 6891f46d10 , ec8610cfdc , and d18ff1b7ef .
2010-04-08 11:49:34 -07:00
Jeremy Kemper
e7f0d37c91
Remove superfluous condition
2010-04-08 11:38:25 -07:00
Kristopher Murata
36129f21b8
Dirty datetime attributes should be aware of time zone info [ #3658 state:resolved]
...
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2010-04-08 10:26:16 -07:00
Jeremy Kemper
ab5aa55cb8
Merge branch 'master' of github.com:rails/rails
2010-04-08 10:25:13 -07:00
Pratik Naik
2c27e3d336
Some doc updates reflecting the new query API
2010-04-08 16:49:52 +01:00
eparreno
07b09bd404
CL guide: fix font format in rails plugin section
2010-04-08 16:45:53 +02:00
eparreno
e39950847c
CL guide: convert rails server to shell text
2010-04-08 16:38:26 +02:00
eparreno
f23fff6a6e
fix font format in Command Line Basics section
2010-04-08 16:19:26 +02:00
José Valim
91d1012a98
Update rails.js to the latest one at http://github.com/rails/prototype-ujs
2010-04-08 13:53:18 +02:00
José Valim
4e92134dfa
Fix a bug in ActionDispatch::Static where Rails cannot find assets if started in another directory which is not the RAILS_ROOT.
2010-04-08 12:52:37 +02:00
Mikel Lindsaar
336cb3c0bf
Adding Rails.env= to railties to allow changing of rails env on the fly for rake tasks etc
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-04-08 12:07:19 +02:00
Xavier Noria
6891f46d10
adds #favicon_link_tag and #apple_touch_icon_link_tag to AP's CHANGELOG
2010-04-07 15:07:07 -07:00
Xavier Noria
ec8610cfdc
adds a default source to #apple_touch_icon_link_tag
2010-04-07 13:20:52 -07:00
Joshua Peek
eed89e65b6
Make sure MemCacheStore logger exists
2010-04-07 15:08:23 -05:00
Xavier Noria
d18ff1b7ef
new helpers #favicon_link_tag and #apple_touch_icon_link_tag
2010-04-07 13:04:52 -07:00
Jeremy Kemper
3957d44fd1
Use request.body IO and rewind, if possible
2010-04-07 11:42:07 -07:00
Joshua Peek
086392492c
Remove #size call on rack input io
2010-04-07 11:41:14 -07:00
Jaime Iniesta
9364c70cd5
update changelog
2010-04-07 18:21:31 +02:00
Jaime Iniesta
82526e8276
Fixed duplicated IDs on active_record_querying guide to validate XHTML 1.0 Strict
2010-04-07 18:19:17 +02:00
Jaime Iniesta
519efa637b
Fixed duplicated IDs on associations_basics guide to validate XHTML 1.0 Strict
2010-04-07 17:56:51 +02:00
José Valim
149d13e1f0
Move the error raising to api_behavior.
2010-04-07 16:18:13 +02:00
José Valim
ec73710c79
Alleviate the pain in working with utf8 templates by setting a default encoding.
2010-04-07 02:25:36 +02:00
Pratik Naik
48634bf59a
Reset named scope cache whenever the @target is reset
2010-04-07 01:16:45 +01:00
James Miller
b52b36e680
More on the new ERB syntax in the guides
2010-04-06 16:52:39 -07:00
José Valim
eb063538bd
Use config.filter_parameters on in-browser request dump. [ #4335 state:resolved]
2010-04-07 01:42:51 +02:00
James Miller
beca1af820
ERB update for AC overview guide
2010-04-06 16:36:43 -07:00
Xavier Noria
4c4fd1a60f
Merge commit 'rails/master'
2010-04-06 15:38:05 -07:00
Xavier Noria
03cb74b946
guides: adds support in the indexer for custom header IDs, and some refactors
2010-04-06 15:20:44 -07:00
James Miller
92eab845a4
First run of updating erb syntax for 3.0
2010-04-06 14:27:19 -07:00
José Valim
af13057524
Use raw in yield since templates engines should not be required to html_safe their contents.
2010-04-06 23:08:21 +02:00
Xavier Noria
80e7178789
guides: adds page title to home and credits, and revises it in the rest
2010-04-06 11:30:00 -07:00
Jaime Iniesta
29d55d86d0
Fix form_helpers guide to validate XHTML 1.0 Strict
2010-04-06 18:05:04 +02:00
Jaime Iniesta
71057c814e
Fix configuring guide to validate XHTML 1.0 Strict
2010-04-06 17:49:53 +02:00
Jaime Iniesta
d14deb7172
Fixed rails_on_rack guide to validate XHTML 1.0 Strict
2010-04-06 17:46:41 +02:00
Jaime Iniesta
6a4bf5590a
Fix contributing_to_rails guide so that it validates XHTML 1.0 Strict
2010-04-06 17:42:36 +02:00
Jaime Iniesta
852e26ab89
Fix 3_0_release_notes so it valides XHTML 1.0 Strict
2010-04-06 12:19:17 +02:00
Jaime Iniesta
6be0fa6a06
Fix 2_2_release_notes so it validates XHTML 1.0 Strict
2010-04-06 12:10:24 +02:00
José Valim
46e2a44ee1
Rename search_field to test_search_field (ht: Piotr Usewicz)
2010-04-06 11:53:34 +02:00
José Valim
77b238d169
Remove :layout option from generators.
2010-04-06 11:51:30 +02:00
Simon Effenberg
4f1d0f6b7e
remove_index now uses quote_table_name() [ #4300 state:resolved]
...
Signed-off-by: Michael Koziarski <michael@koziarski.com >
2010-04-06 14:15:57 +12:00
David Heinemeier Hansson
ebc80ea1cb
Merge branch 'master' of github.com:rails/rails
2010-04-05 16:08:03 -07:00
David Heinemeier Hansson
f8730e5ce6
Added all the new HTML5 form types as individual form tag methods (search, url, number, etc) ( Closes #3646 ) [Stephen Celis]
2010-04-05 16:07:44 -07:00
wycats
0087d0748b
Include author in changelog
2010-04-05 16:07:35 -07:00
David Heinemeier Hansson
40a3e67390
Merge branch 'master' of github.com:rails/rails
2010-04-05 16:02:47 -07:00
José Valim
4bacc2a66d
Update the documentation for Engine and Railtie.
2010-04-05 16:02:23 -07:00
José Valim
542946a0c2
Update the documentation for Engine and Railtie.
2010-04-06 00:32:03 +02:00
José Valim
3b53468a1c
Merge branch 'master' of gitproxy:rails/rails
2010-04-06 00:22:33 +02:00
Joshua Peek
570c54c39a
Fix cookie access in integration tests with other host names
2010-04-05 15:22:09 -07:00
José Valim
ea2c5fa804
A new application now comes with a layout and a stylesheet.
2010-04-06 00:18:35 +02:00
Santiago Pastorino
d270da569e
changed from :object_name to :as on form_for api
2010-04-05 18:55:37 -03:00
Rolf Bjaanes
4eab983b95
Changed the way inflections for uncountables work for 'funky jeans' [ #3576 state:resolved]
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-04-05 23:54:42 +02:00
Ryan Bigg
efa7e96821
It seems the test directory backtrace line is output with a / before it, thereby previously making it not match the regex. Support APP_DIRS that have backtrace lines maybe beginning with /. [ #4277 state:resolved]
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-04-05 23:50:12 +02:00
Pratik Naik
1f7b4447a9
Memoize association.named_scope calls
2010-04-05 21:55:24 +01:00
Santiago Pastorino
72f89b5d97
create option to include_root_in_json for ActiveResource [ #2584 state:committed]
2010-04-05 17:47:02 -03:00
Santiago Pastorino
c6746ffaf4
deprecate form_for(symbol_or_string, ...) in favor of :object_name option
2010-04-05 17:47:02 -03:00
Xavier Noria
081963af48
AS guide: updates definition file for singleton_class and class_eval
2010-04-05 12:25:02 -07:00
Xavier Noria
bb4cf38fa6
minimal update to 3.0 release notes, will link to CHANGELOGS ultimately
2010-04-05 12:23:42 -07:00
Xavier Noria
89978f10af
moves Object#singleton_class to Kernel#singleton_class to match Ruby also there, same for #class_eval to simplify, and adds coverage for class_eval
2010-04-05 12:15:08 -07:00
Rizwan Reza
05dd19e217
Active Record Query Interface Guide: Added LIMIT so the query translates correctly.
2010-04-05 19:49:48 +04:30
Rizwan Reza
f5c54bce20
Routes Guide: Added Section on customizing path names for resources.
2010-04-05 19:37:49 +04:30
Jaime Iniesta
a0e4bb9b5c
Merge branch 'w3validations'
2010-04-05 16:19:16 +02:00
Jaime Iniesta
bc5e80c760
Changelogs: change link from credits page to home page for Jaime's contributions
2010-04-05 16:18:28 +02:00
José Valim
c140aca361
Remove app/views from the load paths [ #4226 state:resolved]
2010-04-05 12:30:59 +02:00
José Valim
6690d66292
Rename config.cookie_secret to config.secret_token and pass it as configuration in request.env. This is another step forward removing global configuration.
2010-04-05 12:00:24 +02:00
Xavier Noria
9ed919eb0b
revises some <%= in rdoc
2010-04-05 02:51:26 -07:00
Xavier Noria
43d02dffcb
<% yield to <%= yield in rdoc of _layout_for, and copy-edits it now that we are on it
2010-04-05 02:16:24 -07:00
Ryan Bigg
9ed176d711
Covered further what happens in config/application.rb. Mostly bundler stuff.
2010-04-05 15:10:38 +10:00
Ryan Bigg
d2d5707854
Further expansion on the Railties and moved Common Includes section to the bottom.
2010-04-05 15:10:38 +10:00
Ryan Bigg
f141bedf16
Further (re)work done. Mostly centering around ActionMailer Railtie and Lazy Loading Hooks.
2010-04-05 15:10:38 +10:00
wycats
5c8b4c6e23
Move filter_parameter_logger to deprecated.rb
2010-04-04 21:06:39 -07:00
wycats
79d194e920
Make it easier to subclass AC::Metal with most, but not all, of the modules in AC::Base
2010-04-04 21:06:26 -07:00
wycats
d61c76840a
Bump the version
2010-04-04 21:05:54 -07:00
wycats
b96486d457
Whitespace
2010-04-04 20:09:03 -07:00
wycats
485512c50f
Whitespace
2010-04-04 19:58:16 -07:00
wycats
209fb5190b
render_to_string should have the identical signature as render
2010-04-04 19:58:15 -07:00
Rizwan Reza
181e4aac52
We don't need explicit :url => { :action => "create" } in form_for when following Rails conventions.
2010-04-05 06:45:15 +04:30
Xavier Noria
1a142fcd4d
Jaime is not an author by now
2010-04-04 14:16:37 -07:00
Xavier Noria
a1ab8e23f2
Revert "Added 'Rails Guides Reviewers' section to credits"
...
The credits page mentions the doc team and guide authors.
This reverts commit be72a397f8 .
2010-04-04 13:52:20 -07:00
Xavier Noria
723e91e9fd
Merge commit 'docrails/master'
2010-04-04 13:36:15 -07:00
wycats
b546945b51
Reapply redirect {|params, request| } with passing tests this time
2010-04-04 13:17:14 -07:00
Jeremy Kemper
50cdb654ac
Use call stack printer if available
2010-04-04 11:56:49 -07:00
Jeremy Kemper
3e5f5f2a48
Revert "Pass in the request as an optional second parameter to redirect"
...
Was not tested.
This reverts commit a8c3c71af1 .
2010-04-04 11:12:19 -07:00
Jeremy Kemper
e3959970e1
Fix signed cookies by explicitly passing config to the cookie jar
2010-04-04 11:10:00 -07:00
Kristopher Murata
ef84e691ff
Parameterize should accept malformed utf8 characters [ #4323 state:resolved]
...
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2010-04-04 09:37:26 -07:00
Andrew White
00884a5901
Merge branch 'master' of github.com:lifo/docrails
2010-04-04 17:34:23 +01:00
Andrew White
48b2451142
Update various documentation examples to use new routing DSL
2010-04-04 17:34:13 +01:00
Xavier Noria
7d7e0627a0
fixes duplicate element IDs in some guides
2010-04-04 08:42:54 -07:00
Andrew White
98b4424141
Add tests to prevent regression of lazy evaluation of has_many ..., :dependent => :___
...
[#2627 state:committed]
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2010-04-04 07:00:24 -07:00
José Valim
b352b97ff5
No .DS_Store on .gitignore. Text editor files should be ignored in your ~/.gitignore.
2010-04-04 03:47:49 -07:00
Jaime Iniesta
a6dc000158
Replace <pre> by <shell>, <ruby> and <yaml> on plugins guide; making it validate XHTML 1.0 Strict
2010-04-04 12:43:19 +02:00
Jaime Iniesta
62fd691a7a
Fix XHTML on performance guide
2010-04-04 12:33:28 +02:00
Jaime Iniesta
532f1fe075
Move credits pic to new assets/image folder
2010-04-04 12:29:25 +02:00
Jaime Iniesta
2790ca620e
Merge branch 'w3validations'
2010-04-04 12:24:56 +02:00
Jaime Iniesta
395f171141
Fixed debugging guide to pass XHTML 1.0 Strict
2010-04-04 12:21:32 +02:00
Jaime Iniesta
af87232342
Fix testing guide so that it validates XHTML 1.0 Strict
2010-04-04 12:09:09 +02:00
Jaime Iniesta
be72a397f8
Added 'Rails Guides Reviewers' section to credits
2010-04-04 11:48:10 +02:00
Jaime Iniesta
96b70229d6
Updated changelog on getting_started and layouts_and_rendering
2010-04-04 11:44:54 +02:00
Jaime Iniesta
7f956af47f
Added .DS_Store to .gitignore
2010-04-04 11:32:47 +02:00
Xavier Noria
ac8b71cc20
guides assets are now centralized in the assets directory, with standard subdirs
2010-04-04 02:30:31 -07:00
Jaime Iniesta
8f5c3e5b6a
Fixing credits page so that it validates XHTML 1.0 Strict and adding myself to it
2010-04-04 11:28:25 +02:00
Aman Gupta
af89c58696
Use a constant proc to generate ActionView::Template finalizers. For some strange reason, finalizers created via ActionView::Template.finalizer_for cause Template instances to leak on MRI.
...
Signed-off-by: wycats <wycats@gmail.com >
2010-04-04 02:10:21 -07:00
Xavier Noria
c52bec77f5
sanity check arguments in guides generation collapsed into a single WARNINGS flag, EDGE_GUIDES renamed to EDGE to be coherent with the rest, preamble revised
2010-04-04 02:08:06 -07:00
Jaime Iniesta
8fa3183436
Fixed layouts_and_rendering guide so that it validates XHTML 1.0 Strict
2010-04-04 11:06:16 +02:00
wycats
a8c3c71af1
Pass in the request as an optional second parameter to redirect
2010-04-03 21:20:45 -07:00
wycats
ab8bf9e152
* Change the object used in routing constraints to be an instance of
...
ActionDispatch::Request rather than Rack::Request.
* Changed ActionDispatch::Request#method to return a String, to be
compatible with the Rack::Request superclass.
* Changed ActionDispatch::Request#method to return the original
method in the case of methodoverride and #request_method not to,
to be compatible with Rack::Request
2010-04-03 20:24:30 -07:00
Santiago Pastorino
8f9becb426
:action => "create" added to form_for with name only to show appropiate behavior
2010-04-03 18:36:29 -03:00
Santiago Pastorino
10ad15861f
:action => "update" used in a non RESTful way confuses
2010-04-03 18:22:58 -03:00
Xavier Noria
512b4bccfb
adds a preamble to the guides generator, documents what it does and the environment variables it supports
2010-04-03 12:08:47 -07:00
Xavier Noria
11161e6c96
Merge commit 'rails/master'
2010-04-03 10:56:15 -07:00
Carl Lerche
467d251c3d
Bring back +extra_conditions+. This effectively reverts 386b7bfd9d
2010-04-03 09:54:15 -07:00
Carl Lerche
6e18fa0375
Raise a StatementInvalid error when trying to build a condition with hash keys that do not correspond to columns.
2010-04-03 09:22:00 -07:00
Carl Lerche
52ffaa182e
Sanitize association conditions using the correct class
2010-04-03 09:22:00 -07:00
wycats
3eb97531b8
Refactored url_for in AV to have its own instances of the helpers instead of proxying back to the controller. This potentially allows for more standalone usage of AV. It also kicked up a lot of dust in the tests, which were mocking out controllers to get this behavior. By moving it to the view, it made a lot of the tests more standalone (a win)
2010-04-03 02:44:02 -07:00
Carl Lerche
13004d4f84
Make the query built by has_many ...., :dependent => :____ lazy since all the information is not really available yet.
2010-04-02 22:33:57 -07:00
Carl Lerche
386b7bfd9d
Remove an unused argument
2010-04-02 20:13:09 -07:00
wycats
b29e893688
Fix memory leak in dev mode
2010-04-02 19:21:19 -07:00
Pratik Naik
c6372d6049
Improve scope docs
2010-04-03 01:49:01 +01:00
Pratik Naik
41a2ba652a
Improve named scope lambda
2010-04-03 01:35:43 +01:00
Pratik Naik
684e4d39d6
Remove unnecessary argument for creating scopes
2010-04-03 01:35:43 +01:00
Santiago Pastorino
47c99f9012
Fixing index style [ #4313 state:committed]
...
Signed-off-by: wycats <wycats@gmail.com >
2010-04-02 16:53:31 -07:00
Jeremy Kemper
ee7605ecf0
Key partial name cache on controller and object class *names* to avoid memory leaks in dev mode
2010-04-02 15:54:38 -07:00
Xavier Noria
4996d1a445
guides: warn about edge guides at the top of the home preamble, and mention that only for edge guides, stable guides need no warning
2010-04-02 15:04:54 -07:00
Xavier Noria
4e391a3d49
guides: badge insertion was a quick hack, rewrites that
2010-04-02 14:53:39 -07:00
Jeremy Kemper
a1a3520198
CI: omit ruby-debug19 from Gemfile since the ruby source dep hoses permissions
2010-04-02 14:44:56 -07:00
Santiago Pastorino
1b742ea9b1
delegate unknown timezones to TZInfo
2010-04-02 17:43:48 -03:00
Santiago Pastorino
90e3343ae5
utc_offset is no longer required on TimeZone and if it's not supplied we delegate to TZInfo
2010-04-02 16:46:56 -03:00
José Valim
997e22c275
Add a test which ensures action_dispatch.show_exceptions is properly disabled.
2010-04-02 20:54:10 +02:00
Rolf Bjaanes
d898a4ba42
Raise exceptions instead of rendering error templates in test environment [ #4315 state:resolved]
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-04-02 20:47:42 +02:00
Pratik Naik
13eb2c87e6
Make Relation#inspect less noisy
2010-04-02 18:57:46 +01:00
Pratik Naik
cfa283201e
Goodbye ActiveRecord::NamedScope::Scope
2010-04-02 18:57:46 +01:00
Pratik Naik
62fe16932c
Make Relation#first and Relation#last behave like named scope's
2010-04-02 18:57:46 +01:00
Pratik Naik
ee07950c03
Scope#method_missing can safely rely on Relation#method_missing
2010-04-02 18:57:45 +01:00
Pratik Naik
0be31f8563
Scope#current_scoped_methods_when_defined is no longer needed
2010-04-02 18:57:45 +01:00
José Valim
1cd3d296f5
Merge branch 'master' of git://github.com/rails/rails
2010-04-02 19:16:44 +02:00
José Valim
a0cdb0499e
Maintain the usage of :as consistent in the router. Whenever it's supplied, it changes the NAMED ROUTE. If you want to change the PATH, use :path instead. Example: resources :projects, :path => 'projetos'
2010-04-02 19:13:47 +02:00
Pratik Naik
83ebe6224f
Oops :extends is not a MULTI_VALUE_METHOD
2010-04-02 17:39:47 +01:00
Pratik Naik
b77dd218ce
Add Relation extensions
2010-04-02 17:38:02 +01:00
Pratik Naik
bc7da9b77d
Consistency when using Relation constants
2010-04-02 17:38:02 +01:00
Aaron Patterson
30f3a3df77
errors.rb needs to be declared as UTF-8 [ #3941 state:resolved]
...
Signed-off-by: wycats <wycats@gmail.com >
2010-04-02 09:14:55 -07:00
Rizwan Reza
eb33f0fe74
Routing guide updated for new Routes DSL. It still misses the new features.
2010-04-02 16:38:39 +04:30
Rizwan Reza
0dd3eac967
Merge branch 'master' of git://github.com/rails/rails
2010-04-02 14:57:30 +04:30
Sam Pohlenz
3adaef8ae7
Restore changed_attributes method in ActiveModel::Dirty and loosen expectation on including class' initialize method.
...
[#4308 state:committed]
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2010-04-01 17:52:45 -07:00
Paul Sadauskas
dc5300adb6
Slightly less annoying check for acceptable mime_types. This allows Accept: application/json, application/jsonp (and the like), but still blacklists browsers. Essentially, we use normal content negotiation unless you include */* in your list, in which case we assume you're a browser and send HTML [ #3541 state:resolved]
2010-04-01 17:42:46 -07:00
Carl Lerche
ab281f511c
Fix class_attribute so that it works with singleton classes.
2010-04-01 17:18:42 -07:00
David Heinemeier Hansson
f0364d87f0
Release is today, yo
2010-04-01 14:20:03 -07:00
wycats
c1883e75b3
Updated changelogs to differentiate beta1 and beta2
2010-04-01 14:04:55 -07:00
wycats
d2a48852a1
Updated changelogs
2010-04-01 13:55:06 -07:00
David Heinemeier Hansson
46aee9f1f0
Bump this guy too
2010-04-01 13:47:48 -07:00
David Heinemeier Hansson
d956003fa4
Neat and tidy, I say
2010-04-01 13:46:04 -07:00
David Heinemeier Hansson
9b71c55d3d
Make your bed and clean up your gemspecs!
2010-04-01 13:44:09 -07:00
David Heinemeier Hansson
86473b454a
Not needed with RubyGems 1.3.6
2010-04-01 13:41:23 -07:00
David Heinemeier Hansson
d868cb4f8a
Prep for beta2, depend on latest Bundler
2010-04-01 13:36:45 -07:00
Jaime Iniesta
13e3f9c0ce
Putting back italics into association headers on association_basics.textile
2010-04-01 17:53:55 +02:00
Doug Richardson
e8292abbcd
Read postgresql encoding using string key instead of symbol [ #4304 state:resolved]
...
Signed-off-by: wycats <wycats@gmail.com >
2010-04-01 08:36:57 -07:00
Jaime Iniesta
78ab9beb49
Fix unescaped '<' and badly formed ids on association_basics guide
2010-04-01 17:20:36 +02:00
Jaime Iniesta
cd9721791f
Fix unescaped <% and %> on action_view_overview guide
2010-04-01 16:36:58 +02:00
Xavier Noria
150835b6af
guides index: splits prologue in two paragraphs
2010-04-01 12:06:25 +02:00
Xavier Noria
da770104d2
insert the badge in a valid way
2010-04-01 11:27:48 +02:00
Xavier Noria
1ac60dc6ac
fine, rolling back the test
2010-04-01 11:20:00 +02:00
Xavier Noria
b49e782707
tests guides regeneration cron in edge server
2010-04-01 10:18:01 +02:00
Bernardo de Pádua
81e6933246
Fix error in number_with_precision with :significant option and zero value [ #4306 state:resolved]
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-04-01 07:25:14 +02:00
Jeremy Kemper
3859828d89
HTML safety: give a deprecation warning if an array of option tags is passed to select tag. Be sure to join the tag yourself and mark them .html_safe
2010-03-31 19:51:54 -07:00
Jeremy Kemper
8dfa27669b
Missed __FILE__
2010-03-31 17:27:39 -07:00
Jaime Iniesta
7a1c784bf2
Fixed unescaped '<' and '>' chars on getting_started section that were causing w3c validation errors (plusplus textile extension was letting them go untextilized)
2010-04-01 01:54:42 +02:00
Jaime Iniesta
1a0134c942
Fixed chapter list generation on index section, an empty pair of <ul></ul> was being created when the chapters had no children.
2010-04-01 01:14:18 +02:00
Jaime Iniesta
4174d321b3
Fixed extra closing A tag on footer, now index validates strict
2010-04-01 00:45:43 +02:00
Jaime Iniesta
8c89ee897d
Fixed unclosed li and ul tags on index
2010-04-01 00:42:31 +02:00
Ernie Miller
98bf00d50d
Add tests for postgresql column type mapping updates [ #4270 state:resolved]
...
Signed-off-by: Emilio Tagua <miloops@gmail.com >
2010-03-31 19:22:54 -03:00
Ernie Miller
ccf8311123
Fix mapping of bigint/smallint/uuid columns in postgresql adapter.
...
Signed-off-by: Emilio Tagua <miloops@gmail.com >
2010-03-31 19:22:44 -03:00
Xavier Noria
b786940248
guides: rewrites index and credit pages as pure HTML to avoid textilizing the rendered view, in particular we can now put a DOCTYPE in the layout
2010-03-31 15:20:43 -07:00
Jeremy Kemper
b3980af8d1
To skip bundler, rm Gemfile. Create a Gemfile to use it again.
2010-03-31 13:56:44 -07:00
Joshua Peek
fc3a39b599
Add --skip-bundler option to rails application generator
...
NOTE: This does not fix the bundler activation issue. The "bundler"
gem will still be installed and activated when you install rails.
2010-03-31 14:11:51 -05:00
Xavier Noria
824fa10f4d
Merge commit 'rails/master'
2010-03-31 07:47:58 -07:00
Ravinder Singh
db28d407f7
Create tmp directories if required before starting server [ #3907 state:resolved]
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-03-31 16:02:59 +02:00
José Valim
05337f61f9
yield always return an array, so we don't need to use .key?
2010-03-31 16:02:59 +02:00
Andrew White
1ed1652bef
ActionController::Resources has gone away
2010-03-31 14:59:58 +01:00
Andrew White
c10bf8205c
Remove routing implementation details from RDoc
2010-03-31 14:54:07 +01:00
Andrew White
e287b53fe3
Update routing documentation to the new way of specifying HTTP method restrictions
2010-03-31 14:19:05 +01:00
Pratik Naik
5562abb4e9
Dont try to load the record from the db if preloading didn't find anything
2010-03-31 12:56:09 +01:00
Andrew White
7a6b1d54e7
Mark ActionDispatch::Routing::DeprecatedMapper as nodoc to hide old documentation until it's removed
2010-03-31 12:45:29 +01:00
Xavier Noria
607f945b1d
adds missing require for blank? and present?
2010-03-31 04:40:51 -07:00
José Valim
62151dd272
Deprecate cookie_verifier_secret in favor of config.cookie_secret allowing signed cookies to work again.
2010-03-31 12:59:41 +02:00
Ryan Bigg
1a054459cb
Fix missing quote and remove core ext explanation.
2010-03-31 11:48:42 +01:00
Ryan Bigg
2d86124e8d
More header shuffling, scope all the "Require Rails" sections INSIDE the "Require Rails" section.
2010-03-31 11:04:28 +01:00
Ryan Bigg
1a9dc79058
Went through from the top down to line 650 fixing up discrepancies between new rails and old guide.
2010-03-31 10:50:13 +01:00
Santiago Pastorino
c10958fbdd
avoid method redefined; discarding old empty? warning [ #4302 state:committed]
...
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2010-03-30 16:59:48 -07:00
Ryan Bigg
656a21edc4
Fix headers so that the TOC generates, rails/subscriber is now rails/log_subscriber and "Finish" ActionController Railtie.
2010-03-31 00:36:44 +01:00
Santiago Pastorino
7d0eea179b
Don't cache the utc_offset we are already caching the timezone [ #4301 state:committed]
...
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2010-03-30 16:36:16 -07:00
Xavier Noria
1412ad437e
adds and entry for assert_blank and assert_present to CHANGELOG
2010-03-30 15:54:20 -07:00
Juanjo Bazan
589deb39c7
New assertion: assert_present [ #4299 state:committed]
...
Signed-off-by: Xavier Noria <fxn@hashref.com >
2010-03-30 15:25:38 -07:00
Juanjo Bazan
7212c29802
new assertion: assert_blank
...
Signed-off-by: Xavier Noria <fxn@hashref.com >
2010-03-30 15:25:38 -07:00
José Valim
772a0226fd
Add a test which ensures slugs in :id work.
2010-03-31 00:19:40 +02:00
Xavier Noria
0fc1f92ac9
<%=izes and adds doctype to guides
2010-03-30 23:02:05 +02:00
Joshua Peek
53e16d8011
Missed a few spots in railties
2010-03-30 14:18:08 -05:00
Joshua Peek
cdf8c35ffd
Consistent routing language
2010-03-30 14:05:42 -05:00
Joshua Peek
17f0c1e9e8
Fix stack overflow bug in integration test router helpers
2010-03-30 13:58:18 -05:00
Emilio Tagua
37102a5237
Fix failing test in MySQL.
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-03-30 16:01:53 +02:00
Emilio Tagua
8d99ec9a4d
Named scopes shouldn't test equality using to_a if it's not an Array, this was causing records to be loaded before they were needed.
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-03-30 15:36:18 +02:00
José Valim
41b45d5655
Bring rdoc tasks back to plugins.
2010-03-30 14:41:58 +02:00
José Valim
ffcd44144a
Remove deprecated model_subclass since it was never published.
2010-03-30 14:41:58 +02:00
Xavier Noria
ce3864aa36
periods are not metacharacters within character classes
2010-03-30 01:55:06 -07:00
José Valim
ebcc4c5e74
Remove if/else branch when generating the documentation since we are simply inspecting the load path.
2010-03-30 10:00:46 +02:00
postmodern
f9e84a9e5a
Changed gem_path to yield the path found in $LOAD_PATH to a block.
...
* This allows gems not found in $LOAD_PATH to be safely ignored by the
rails documentation task.
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-03-30 09:58:39 +02:00
Michael Koziarski
bc298152f8
Fix syntax error and avoid the use of unless/else.
2010-03-30 14:31:16 +13:00
wycats
4aded43b73
Replace the placeholder base_hook API with on_load. To specify some code that
...
should run during framework load do:
ActiveSupport.on_load(:action_controller) do
# Code run in the context of AC::Base
end
2010-03-29 17:08:50 -07:00
José Valim
331327d391
Just inspect load paths to generate the documentation.
2010-03-30 01:34:06 +02:00
José Valim
56bed512f9
Fix dom_id for ActiveRecord [ #4296 state:resolved]
2010-03-30 01:32:26 +02:00
wycats
b94c4080e5
Revert "Ruby 1.9: use ruby-debug19. [ #3949 state:resolved]"
...
This wasn't the issue here; we need to beef up the docs and speak to
Wayne and Mark about installation.
This reverts commit da238dafd7 .
2010-03-30 01:32:26 +02:00
Jeremy Kemper
4fbcde43e3
Ruby 1.9: use ruby-debug19. [ #3949 state:resolved]
2010-03-30 01:32:26 +02:00
Jeremy Kemper
af8852d1ad
Work without bundler
2010-03-29 16:25:52 -07:00
Jeremy Kemper
e30363617c
Revert "Hash#symbolize_keys(!) optimizations"
...
Was slower in common case.
[#3891 state:open]
This reverts commit 2060977b76 .
2010-03-29 15:48:36 -07:00
Ernie Miller
63026541b2
Fix honoring :primary_key option when joining or eager loading a belongs_to association
...
[#765 state:committed]
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2010-03-29 15:24:27 -07:00
wycats
a509b0b18f
Revert "Ruby 1.9: use ruby-debug19. [ #3949 state:resolved]"
...
This wasn't the issue here; we need to beef up the docs and speak to
Wayne and Mark about installation.
This reverts commit da238dafd7 .
2010-03-29 14:07:12 -07:00
Jeremy Kemper
da238dafd7
Ruby 1.9: use ruby-debug19. [ #3949 state:resolved]
2010-03-29 13:59:20 -07:00
José Valim
74efe4c253
Revert "Update USAGE docs for generators."
...
This reverts commit d31e03f356 .
2010-03-29 18:46:04 +02:00
José Valim
9a865ee25e
Revert "Reorganized app/test directory. [ #3057 state:resolved]"
...
This reverts commit a0dc6755db .
2010-03-29 18:36:28 +02:00
Jeremy Kemper
94ced08543
ruby-debug19 doesn't install cleanly on 1.9.2 trunk
2010-03-29 08:57:43 -07:00
Jeremy Kemper
36a5e78c14
Add missed changelog for table_name_prefix
2010-03-29 08:56:40 -07:00
Jeremy Kemper
4072adf9ca
Merge remote branch 'miloops/master'
2010-03-29 08:30:00 -07:00
Emilio Tagua
7006aa1a85
Arel now handles ranges with excluded end.
2010-03-29 12:30:13 -03:00
Jeremy Kemper
0d6f97e702
Bump mail to 2.1.5.3
2010-03-29 08:05:39 -07:00
Emilio Tagua
53ddbfc460
Warn scoped order and limit are ignored. [ #4123 state:resolved]
2010-03-29 11:30:06 -03:00
wycats
5f7bc47303
Rename modularized_table_name_prefix to full_table_name_prefix [ #4032 state:resolved]
2010-03-28 23:45:38 -07:00
Andrew White
67d1cec4c8
Add the ability to specify table_name_prefix on individual modules
...
Signed-off-by: wycats <wycats@gmail.com >
2010-03-28 23:43:28 -07:00
wycats
48c1d8c341
Provide a better error if the parsed REXML document has no root [ #3803 state:resolved]
2010-03-28 23:21:35 -07:00
Jeremy Kemper
41e7c68d87
Ruby 1.9.2: marshaling round-trips Time#zone
2010-03-28 22:52:08 -07:00
Andrew White
40d90ed7df
Ignore generated railties RDocs [ #4289 state:resolved]
...
Signed-off-by: wycats <wycats@gmail.com >
2010-03-28 22:45:29 -07:00
Andrew White
d39ec81955
Make Railties RDoc task work again [ #4291 state:resolved]
...
Signed-off-by: wycats <wycats@gmail.com >
2010-03-28 22:45:03 -07:00
Rizwan Reza
d31e03f356
Update USAGE docs for generators.
2010-03-28 22:38:46 -07:00
Rizwan Reza
a0dc6755db
Reorganized app/test directory. [ #3057 state:resolved]
...
Run 'rake update:test_directory' to reorganize your already generated apps.
test/functional -> test/controllers
test/functional -> test/controllers
test/unit/helpers -> test/helpers
test/unit/**/*_observer_test.rb -> test/observers
test/unit -> test/models
2010-03-28 22:38:46 -07:00
Aaron Patterson
98d2d8ce2c
use the database to lower case strings rather than ruby. [ #4293 state:resolved]
...
Signed-off-by: wycats <wycats@gmail.com >
2010-03-28 22:16:34 -07:00
Santiago Pastorino
4ea289fb11
ruby-debug19 added to Gemfile [ #4290 state:committed]
...
Signed-off-by: wycats <wycats@gmail.com >
2010-03-28 20:24:36 -07:00
David Heinemeier Hansson
a4eab8f1f3
Update example of default_scope to use the new arel finder syntax
2010-03-28 19:11:06 -07:00
wycats
bd69589143
preinitializer.rb is no longer needed, so remove it from the guide and replace with better suggestion. [ #4279 state:resolved]
2010-03-28 19:08:06 -07:00
wycats
201e8986b1
Updated asset_template_path to asset_path and have it also support a String [ #4247 state:resolved]
2010-03-28 18:46:18 -07:00
Craig R Webster
49bc6a249e
Allow customisation of asset path generation using a proc.
...
Set config.action_controller.asset_path_template to a proc that takes one
argument - the direct, unchanged asset path - and returns a path to that asset
using the scheme that your assets require.
This is useful if you have a setup which scales by introducing new application
servers where the mtime of the asset files may not be the same as those of the
asset files on your previous servers, but it does require your web servers to
have knowledge of the asset template paths that you rewrite to so it's not
suitable for out-of-the-box use. An example of configuring asset path
generation and rewriting these paths using Apache is included in
actionpack/lib/action_view/helpers/asset_tag_helper.rb.
Signed-off-by: wycats <wycats@gmail.com >
2010-03-28 18:35:05 -07:00
Rizwan Reza
cf6734fdf9
Add more tests and docs to uncountable routes. [ #3930 state:resolved]
2010-03-28 18:34:48 -07:00
Jan De Poorter
72074aac33
Add _index to named collection routes for uncountable resources (e.g. Sheep)
...
Signed-off-by: Rizwan Reza <rizwanreza@gmail.com >
2010-03-28 18:34:48 -07:00
Jeremy Kemper
4b07352420
./tools/console to drop into irb with rails loaded
2010-03-28 18:18:25 -07:00
Eugene Pimenov
fc6746fc3f
PostgreSQL adapter: escape_bytea, quote_string and unescape_bytea aren't thread-safe in Ruby 1.8 [ #3237 state:resolved]
...
Signed-off-by: wycats <wycats@gmail.com >
2010-03-28 18:04:46 -07:00
Rizwan Reza
de2b0147d0
Reapply Rizwan's patch, but memoize Bundler.load.specs in an ivar. [ #3697 state:resolved]
...
Signed-off-by: wycats <wycats@gmail.com >
2010-03-28 17:42:53 -07:00
Paco Guzman
878a9e02f6
html_tag option to wrap error_message_on text [ #4283 state:resolved]
...
Signed-off-by: wycats <wycats@gmail.com >
2010-03-28 17:27:10 -07:00
Andrew White
26bc5c542e
Add ActionDispatch to RDoc task [ #4287 state:resolved]
...
Signed-off-by: wycats <wycats@gmail.com >
2010-03-28 17:09:37 -07:00
wycats
1b9777e84f
Why are we not updating bundler?
2010-03-28 15:46:45 -07:00
Vladimir Andrijevik
edaf92f5ab
Drop expires argument from call to @data in MemCacheStore so it works with memcache-client and memcached gems, as advertised [ #3672 state:resolved]
...
Signed-off-by: wycats <wycats@gmail.com >
2010-03-28 13:57:14 -07:00
Matthew Rudy Jacobs
b0967cc5cf
defining a named_scope which overwrites an existing method is now allowed we just log a warning.
...
This was motivated by the fact that :open is defined on all classes
as such the named_scope "open" can never be used, without hacking
ActiveRecord with an "undef_method" [#4083 state:resolved]
Signed-off-by: wycats <wycats@gmail.com >
2010-03-28 13:53:20 -07:00
wycats
77a2a3d9b3
Request#content_type exists in Rack::Request, and other parts of Rack::Request expect
...
it to return a String. Split the Rails API so that Request#content_type returns
a String, and Request#content_mime_type returns a Mime::Type object.
2010-03-28 13:40:38 -07:00
Andrew White
e1a70faea6
Add constraints to resources in new routing DSL
...
Signed-off-by: Rizwan Reza <rizwanreza@gmail.com >
2010-03-28 23:31:13 +04:30
Jeremy Kemper
5c058295d1
Bump mail dep to 2.1.5.1
2010-03-28 11:44:46 -07:00
Jeremy Kemper
154f9ce5fd
Merge remote branch 'mikel/master'
2010-03-28 11:34:30 -07:00
Jeremy Kemper
7e3b4c1f2f
Merge branch 'master' of github.com:rails/rails
2010-03-28 11:34:16 -07:00
Jeremy Kemper
d1f3437cac
Cosmetics: mismatch indentation
2010-03-28 11:34:09 -07:00
wycats
c99194c7be
Merge remote branch 'rizwan/restrict'
2010-03-28 11:06:46 -07:00
Rizwan Reza
f1e5a9ff98
Add :dependent = to has_one and has_many [ #3075 state:resolved]
2010-03-28 18:47:46 +04:30
Xavier Noria
76f024ac8d
adds missing requires for Object#blank? and Object#present?
2010-03-28 14:15:02 +02:00
Xavier Noria
105f9b8154
adds missing requires for Object#duplicable?
2010-03-28 13:26:13 +02:00
Xavier Noria
3b1c69d2dd
adds a few requires in active_model/dirty.rb
...
[#4284 state:committed]
2010-03-28 12:43:20 +02:00
Rizwan Reza
835f5d0269
Rails 3 application can run performance tests now. [ #4171 state:resolved]
2010-03-28 15:03:25 +04:30
Rizwan Reza
155f0be16b
Changes migration number to version due to ambiguity. [ #3065 state:committed]
2010-03-28 12:16:46 +04:30
Rizwan Reza
b4c91de946
Merge remote branch 'rails/master'
2010-03-28 12:04:00 +04:30
Rizwan Reza
66d57d7ba8
Oops, a docfix.
2010-03-28 11:10:35 +04:30
Rizwan Reza
6c2a0675f1
When creating database with rake, create schemas in schema_search_path if it doesn't exist.
2010-03-28 11:01:15 +04:30
Mikel Lindsaar
53bcd4af09
Updating mail version requirement to 2.1.5
2010-03-28 17:03:49 +11:00
Mikel Lindsaar
4e0d1cfad7
Fixing up attachment encoding specs to work with latest mail - and be correct
2010-03-28 17:03:33 +11:00
Mikel Lindsaar
b91c57d16c
Mail now correctly bundles up the charset into the content type field
2010-03-28 16:24:54 +11:00
Mikel Lindsaar
a41d1b1fb1
Updating test, should be calling :decoded, not :encoded, is a problem now that Mail is fixed
2010-03-28 16:22:37 +11:00
Mikel Lindsaar
63002ba36b
Fixing test, ; is a delimiter, not a termination character, ref RFC 2045
2010-03-28 15:24:35 +11:00
Mikel Lindsaar
2bcc2ebf44
Merge branch 'master' of git://github.com/rails/rails
2010-03-28 14:44:34 +11:00
José Valim
8398f21880
Time zone tests were right all along.
2010-03-28 05:38:32 +02:00
Xavier Noria
4b4f69b9bf
AS guide: warns about the singleton classes of nil, true, and false according to what http://redmine.ruby-lang.org/repositories/diff/ruby-19/object.c?rev=27022 blesses
2010-03-28 04:08:54 +02:00
watsonian
edd59b7bb9
Fixes typo in environments/production.rb template.
2010-03-27 19:02:05 -07:00
Ryan Bigg
93d80672f4
Adding the initialization guide to docrails.
2010-03-28 02:03:32 +01:00
José Valim
a09e99259c
Ensure details are frozen after @details_keys lookup. The implementation waits to freeze until the last required moment, to avoid duping hashes.
2010-03-27 20:52:11 +01:00
wycats
fdebc7f55b
Missing require
2010-03-27 12:39:28 -07:00
wycats
4b9f167231
Actually check the value of the ivar
2010-03-27 12:17:17 -07:00
Jeremy Kemper
4384a95b51
Bust gem prelude to ensure bundler's in the load path. Not sure what's broken here.
2010-03-27 12:06:27 -07:00
Jeremy Kemper
a98db7c6ef
Use Array.wrap uniformly
2010-03-27 11:50:11 -07:00
Jeremy Kemper
c3cea9b594
Fix unstated dep on HWIA
2010-03-27 11:03:36 -07:00
Santiago Pastorino
38bb133881
Ruby's marshaling of Time instances doesn't respect the zone [ #4282 state:resolved]
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-03-27 16:44:20 +01:00
Santiago Pastorino
820e3a8491
LINE on class_eval need + 1, also removed comments [ #4281 state:committed]
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-03-27 16:42:52 +01:00
Santiago Pastorino
edbb9526d3
flatten not needed here
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-03-27 16:42:51 +01:00
José Valim
ff522cf4bc
Revert "primary_key now supports :limit for MySQL". Break Sam Ruby app.
...
To reproduce, start a new application, create a scaffold and run test suite. [#876 state:open]
This reverts commit faeca694b3 .
2010-03-27 14:39:43 +01:00
José Valim
46b7704b74
Do not need to load ActionPack::VERSION
2010-03-27 12:38:55 +01:00
wycats
26e714d26e
Remove stray instance variable to resolve serialization problem [ #3769 state:resolved] (ht: Joe Rafaniello)
2010-03-27 04:32:08 -07:00
wycats
bc4cdae3d9
Don't write to /dev/null on mingw. [#3921 state:resolved] (ht: Patrick Daryll Glandien)
2010-03-27 04:15:41 -07:00
wycats
c428fbdb1d
Use the new RAILS_VERSION in rake install (ht: ZhangJinzhu) [ #4116 state:resolved]
2010-03-27 04:10:40 -07:00
Rizwan Reza
faeca694b3
primary_key now supports :limit for MySQL
...
Signed-off-by: wycats <wycats@gmail.com >
2010-03-27 03:49:53 -07:00
wycats
0a352056a4
Fixes a bug where error_messages_for was returning an empty div [ #4048 state:resolved] (ht: Geoff Garside)
2010-03-27 03:10:05 -07:00
José Valim
418e5fc279
Merge branch 'master' of gitproxy:rails/rails
2010-03-27 11:07:07 +01:00
José Valim
0cb3311d06
Revert "primary_key now supports :limit. [ #876 state:resolved]" since it broke AR test suite.
...
This reverts commit 41e5c7ed44 .
2010-03-27 11:05:37 +01:00
José Valim
f1da7174cc
Fix tests added in previous commit.
2010-03-27 11:04:21 +01:00
wycats
a24a888afe
Limit Array#extract_options! to directl instances of Hash and HWIA. Add extractable_options? to Hash so that subclasses of Hash can opt-into extractable behavior. This fixes an issue where respond_with wasn't working with subclasses of Hash that were provided by other libraries (such as CouchDB or Mashie) [ #4145 state:resolved]
2010-03-27 02:59:10 -07:00
Jacob Atzen
a5d637d86c
ActiveModel::Dirty#changes should return a HashWithIndifferentAccess [ #4157 state:resolved]
...
Keep the Rails style of inject
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-03-27 10:48:32 +01:00
José Valim
140cc9caf6
Do not check for a valid const name in Rails 3.0 applications. [ #4200 state:resolved]
2010-03-27 10:46:17 +01:00
Kabari Hendrick
b081948bb3
fixing inconsistency with cattr_reader and matter_reader [ #4172 state:resolved]
...
Signed-off-by: wycats <wycats@gmail.com >
2010-03-27 02:07:04 -07:00
Daniel Rodríguez Troitiño
334983eca0
Recovers error_messages for ActiveRecordInstanceTag. [ #4078 state:resolved]
...
Signed-off-by: wycats <wycats@gmail.com >
2010-03-27 01:56:20 -07:00
Aaron Patterson
3172db12e4
avoiding a few closure references by evaling. [ #4223 state:resolved]
...
Signed-off-by: wycats <wycats@gmail.com >
2010-03-27 01:41:44 -07:00
Gaël Deest
753304bd11
Makes ActiveResource work with form_for: - Adds a build' method that can be used instead of new' to load a new, unsaved resource from the remote site, filled with the correct default values. - Adds a persisted?' method that simply returns the opposite value than the new?' method. [ #4222 state:resolved] [ #4155 state:resolved]
...
Signed-off-by: wycats <wycats@gmail.com >
2010-03-27 01:40:46 -07:00
Rizwan Reza
41e5c7ed44
primary_key now supports :limit. [ #876 state:resolved]
...
Signed-off-by: wycats <wycats@gmail.com >
2010-03-27 01:33:42 -07:00
Pratik Naik
68ade93cde
Revert "Changed behavior of touch and added touch! Originally implemented by Obie Fernandez, updated touch! to act as a thin wrapper to touch. [ #2520 state:resolved]"
...
This reverts commit 3a875e6184 .
2010-03-27 08:22:32 +00:00
Sam Elliott and Ryan Bigg
62937b8fb0
Use ActiveSupport::Autoload for view helpers. [ #4237 state:resolved]
...
Signed-off-by: wycats <wycats@gmail.com >
2010-03-27 01:13:45 -07:00
wycats
02ab7890bf
Fix a mistake in the documentation (ht: Evgeniy Dolzhenko) [ #4217 state:resolved]
2010-03-27 01:00:02 -07:00
Andrew White
39c35ff04b
Fix named routes for member actions of singleton resources [ #4266 state:resolved]
...
Signed-off-by: wycats <wycats@gmail.com >
2010-03-27 00:49:47 -07:00
Nathaniel Bibler
3a875e6184
Changed behavior of touch and added touch! Originally implemented by Obie Fernandez, updated touch! to act as a thin wrapper to touch. [ #2520 state:resolved]
...
Signed-off-by: wycats <wycats@gmail.com >
2010-03-27 00:35:39 -07:00
Rizwan Reza
167017f655
Tests method_missing to raise NameError. [ #2522 state:resolved]
...
Signed-off-by: wycats <wycats@gmail.com >
2010-03-27 00:26:44 -07:00
Andrew White
3d746fcdb5
Add parameter defaults support to new routing DSL [ #4265 state:resolved]
...
Signed-off-by: wycats <wycats@gmail.com >
2010-03-27 00:21:10 -07:00
wycats
b20a105ed0
Fixes typo (ht: Claudio Poli) [ #4107 state:closed]
2010-03-26 20:07:00 -07:00
Kris Selden
afb786ad8a
In PostgreSQLAdapter, switch tables query to use current_schemas function [ #918 state:resolved]
...
Signed-off-by: wycats <wycats@gmail.com >
2010-03-26 17:18:33 -07:00
wycats
56a86c2191
Make X-Sendfile default to "" so it works correctly in dev mode.
...
Provide a default in production.rb that can be modified, so that
people who care about sendfile performance in production mode can
get better performance easily.
2010-03-26 16:58:55 -07:00
wycats
197904341f
Merge branch 'master' into docrails
2010-03-26 15:10:24 -07:00
José Valim
b3a0aed028
Just assert for 'Hi' in generated mailer tests.
2010-03-26 20:25:54 +01:00
José Valim
395d6648ce
Move application configuration to the application configuration object, remove railtie_name and engine_name and allow to set the configuration object.
2010-03-26 18:47:55 +01:00
José Valim
fc266d7ec2
Revert "find railties and engines by name [4264 state:resolved]"
...
This reverts commit 7b8399b80c .
2010-03-26 16:12:35 +01:00
Edgars Beigarts
0848c862f0
Make script/dbconsole work with oracle (sqlplus <username>[/<password>][@<connect_identifier>])
...
[#3773 state:resolved]
2010-03-26 15:54:04 +01:00
José Valim
b2c2b0ce45
Rails router automatically calculated for you the controller and named routes in the following scenarios:
...
match "home/about" #=> maps to home#about with named route home_about_path
match "about" #=> does not work because it cannot guess the controller
match "about" => "home#about" #=> maps to home#about with named route home_about_path
match "home/about", :as => "about" #=> maps to home#about with named route about_path
2010-03-26 15:51:51 +01:00
José Valim
f5ee855f43
Improve heuristic for railties default name, otherwise railties may be named :railtie, :engine and so on.
2010-03-26 14:41:48 +01:00
Josh Susser
7b8399b80c
find railties and engines by name [4264 state:resolved]
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-03-26 14:25:45 +01:00
Rizwan Reza
5176b28852
Better MySQL Error message. [ #3775 state:resolved]
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-03-26 13:25:53 +01:00
José Valim
5231e4e8c5
Ensure to reference the proper TZInfo namespace [ #4268 state:resolved].
2010-03-26 13:24:08 +01:00
Josh Franklin
c7cc958368
Add support for a type=binary with an optional encoding=base64. If the encoding attribute is absent, the data is considered unencoded.
...
[#2966 state:resolved]
2010-03-26 12:44:12 +01:00
chrisfinne
76d2c455c0
Add debugging documentation for _callback_chain to ActiveRecord::Callback
...
Signed-off-by: Rizwan Reza <rizwanreza@gmail.com >
2010-03-26 14:01:21 +04:30
Jeremy Roman
ffb22bd2be
fix habtm documentation to correct typo
...
Signed-off-by: Rizwan Reza <rizwanreza@gmail.com >
2010-03-26 13:35:56 +04:30
José Valim
4c7c406155
Remove reference to unexistent methods and fix typo.
2010-03-26 01:12:24 +01:00
José Valim
759eb36054
Actually, bring Arel back to Gemfile and use git repo since it helps development.
2010-03-25 23:31:42 +01:00
José Valim
99ce6eb4b1
Remove Arel's git repo from Gemfile and use system_timer just on 1.8.x
2010-03-25 20:40:01 +01:00
Jeremy Kemper
a8b93d7a05
Bump to arel 0.3.3 to resolve Active Support dep
2010-03-25 11:52:53 -07:00
Emilio Tagua
d06a754fdd
Remove unused attributes_with_quotes method.
2010-03-25 15:47:16 -03:00
Emilio Tagua
fc2e25734a
Move methods from association to relation finder methods.
2010-03-25 15:47:06 -03:00
retr0h
cbdb4aa287
Updated ActionController::Base.asset_host example
...
The example provided contrived. It is not useful when wanting to use
1-based asset hosts (since it would generate a random asset host for
the same asset).
Signed-off-by: Rizwan Reza <rizwanreza@gmail.com >
2010-03-25 21:55:21 +04:30
Emilio Tagua
90a4709601
Refactor relation merging to create just one relation and then assign values, instead of creating multiple relation objects.
2010-03-25 13:03:30 -03:00
Emilio Tagua
e260d5fbcf
Require Arel 0.3.2
2010-03-25 12:37:38 -03:00
Emilio Tagua
e3a2fae05d
Add add_limit_offset! to adapters.
2010-03-25 12:37:38 -03:00
Rizwan Reza
94381b2d5a
Routes guide being rewritten, done till :singular.
2010-03-25 04:04:19 +04:30
Brian Doll
3807db8e99
Fixing spelling error in activerecord guide in the validation callbacks section, closing issue #2
2010-03-24 09:29:55 -07:00
Aaron Patterson
ed21f0c502
expand migration paths before requiring them. [ #4240 state:resolved]
...
Signed-off-by: wycats <wycats@gmail.com >
2010-03-23 18:22:46 -07:00
Aaron Patterson
bc48d39e4c
do not use unloadable constants in tests [ #4260 state:resolved]
...
Signed-off-by: wycats <wycats@gmail.com >
2010-03-23 18:02:29 -07:00
wycats
45e8cf59df
init.rb in plugins is here to stay
2010-03-23 16:35:14 -07:00
José Valim
b92963f9f8
Use latest I18n (0.3.6).
2010-03-23 23:53:38 +01:00
José Valim
5c41cb77d9
Ensure lib/rails/initializers/*.rb also works for gems.
2010-03-23 23:50:53 +01:00
wycats
cc0e402aa8
Protect routes again so they don't end up as actions. We need a better solution than this.
2010-03-23 14:09:08 -07:00
Joshua Peek
e47a1d7865
Load plugin initializers from lib/rails/initializers/*.rb
2010-03-23 15:36:32 -05:00
José Valim
b9f551ac15
Explicitly require files before monkey patching them.
2010-03-23 17:48:29 +01:00
Sebastian Martinez
a5e98d7067
updated Rakefile with new app generator path [ #4258 state:resolved]
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-03-23 17:35:19 +01:00
Sebastian Martinez
10825be40b
rake tasks should use the new app generator path [ #4257 state:resolved]
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-03-23 14:26:27 +01:00
José Valim
05ec99eed9
bin/rails should use the new app generator path.
2010-03-23 14:12:58 +01:00
José Valim
b61f6f5980
Load generators from both lib/rails/generators and lib/generators. Using the former since it's less obstrusive.
2010-03-23 13:40:41 +01:00
wycats
b144b56d82
Put MRI-specific dependencies in an MRI group
2010-03-22 20:32:31 -07:00
wycats
15c31c7639
open_session can just return the a dup of the current context.
...
At this point, its entire purpose in the open_session {} case was to
delegate back to the IntegrationTest anyway.
2010-03-22 17:14:28 -07:00
José Valim
1f93a46b43
Merge branch 'master' of gitproxy:rails/rails
2010-03-23 00:27:07 +01:00
José Valim
c53f77f3be
Rename unsignificant to insignificant.
2010-03-23 00:26:12 +01:00
Xavier Noria
926ff0e0a1
AS guide: documents Module#remove_possible_method
2010-03-23 00:19:17 +01:00
José Valim
13bb4a6e68
Current url helpers become actions in controller. Added a failing test case for it.
2010-03-22 23:57:06 +01:00
wycats
0b16c7602d
No -rubygems needed
2010-03-22 14:17:49 -07:00
wycats
d03af48a7d
Provide a better error if thor is missing
2010-03-22 14:09:00 -07:00
Bernardo de Pádua
a4090bca6a
NumberHelper methods should now return html_safe strings (when the inputs are valid numbers or are html_safe). Also adds :raise => true (used internaly) to make the number helpers throw InvalidNumberError when the given number is invalid.
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-03-22 21:19:49 +01:00
Bernardo de Pádua
75904c566e
Adds number_to_human and several improvements in NumberHelper. [ #4239 state:resolved]
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-03-22 21:19:49 +01:00
José Valim
e8a80cdded
Controller generators should use routes shortcut.
2010-03-22 21:07:37 +01:00
José Valim
4998e097cc
Make router shortcuts more polite to URLs starting with a leading slash.
2010-03-22 21:07:37 +01:00
José Valim
fb89aba8b4
Killing fixtures in mailer before they kill me (they usually lead to very brittle tests).
2010-03-22 21:07:37 +01:00
Emilio Tagua
d289e15af9
From and lock should be defined to be consistent with other ivars. Limit and offset are always defined, no need to test that.
...
[#4253 state:committed]
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2010-03-22 11:48:39 -07:00
Evan Phoenix
4f5de7f89a
Reset class attribute after changing it
2010-03-22 10:00:04 -07:00
Evan Phoenix
ab3503b496
Remove test ordering bug
...
Don't reuse classes with class attributes when testing different use cases
of class attributes.
2010-03-22 10:00:04 -07:00
Evan Phoenix
0b608abeb8
Clear the query cache between tests that test the query cache
2010-03-22 10:00:04 -07:00
Evan Phoenix
79b0861624
Remove obsolete use case that was broken in AR::Observers
2010-03-22 10:00:04 -07:00
Evan Phoenix
a307fd6bd3
Don't depend on order of elements in Set
2010-03-22 10:00:03 -07:00
Evan Phoenix
1e4be20672
Fix ActionMailer test issues
...
* Don't depend so much no the message in a NameError
* Reset the delivery method properly
2010-03-22 10:00:03 -07:00
Evan Phoenix
34497c0b36
Remove test ordering bug by using another class
2010-03-22 10:00:03 -07:00
Santiago Pastorino
3bd85e2748
db group makes more sense here
2010-03-22 02:55:28 -03:00
Santiago Pastorino
16cad60fd3
avoid active_support/core_ext/time/conversions.rb warnings
...
[#4250 state:committed]
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2010-03-21 18:16:18 -07:00
Jeremy Kemper
4884f28c80
Also revert mailer generator test changes in 8b50f89
2010-03-21 16:18:32 -07:00
Jeremy Kemper
49416550fe
Fix regression introduced in 8b50f89. Generated views mentioned the wrong path.
2010-03-21 16:07:21 -07:00
Denis Odorcic
b7adec3563
Remove data-url support from url_helper [ #4236 state:resolved]
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-03-21 19:31:59 +01:00
Sebastian Martinez
0137566c85
do not support 'data-url' anymore, just use 'href' [ #4236 state:resolved]
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-03-21 19:31:54 +01:00
José Valim
8b50f89ba7
Make ERB generators more flexible and customizable.
2010-03-21 19:30:42 +01:00
Joshua Peek
87db863fa2
Remove invalid builtin tests since we aren't adding that dir to the
...
load path anymore
2010-03-20 15:14:59 -05:00
Joshua Peek
fcc6b12e77
Autoload Rails::Info
2010-03-20 14:03:43 -05:00
Joshua Peek
14b7452c57
Require info controller from info routes
2010-03-20 13:33:25 -05:00
Joshua Peek
f38e89cfba
Move railties/builtin into lib
2010-03-20 12:34:21 -05:00
wycats
f868c2afa9
response_body is an Array in 1.9, so an Array was being pushed onto the cache
2010-03-19 18:56:06 -07:00
wycats
e1c030edd8
Fixed a bunch of tests that failed in 1.9 because they assumed that a Rack response was a String.
2010-03-19 18:46:29 -07:00
Sam Ruby
80095c54bd
Controller generators should generate tests when action is supplied. [ #3421 state:resolved]
2010-03-20 00:51:56 +01:00
José Valim
525382f638
Clean up Mime::Type and remove deprecated stuff (from 2.3).
2010-03-20 00:28:27 +01:00
Xavier Noria
dea701bd2c
normalizes titles of release notes guides, and adds them to the home page
2010-03-19 21:49:48 +01:00
Xavier Noria
02be581f45
s/guides.rails.info/edgeguides.rubyonrails.org/ in a few places, and makes some links relative to work in either site
2010-03-19 21:39:42 +01:00
wycats
9f92563892
Eliminate an error from an implicit dependency on AV::Base
2010-03-19 11:50:03 -07:00
Carlhuda
7f53dca1a1
Fix protect_against_forgery
2010-03-19 11:11:02 -07:00
José Valim
562154fcbc
Controller generator now creates routes as well [ #4233 state:resolved]
2010-03-19 18:12:54 +01:00
Aaron Patterson
541194f641
switching migrations to use require cleans up many warnings [ #4234 state:resolved]
...
Signed-off-by: wycats <wycats@gmail.com >
2010-03-19 09:56:22 -07:00
José Valim
ae499b53ef
Merge branch 'master' of gitproxy:rails/rails
2010-03-19 17:23:44 +01:00
José Valim
f28d856cec
Improve performance of the rendering stack by freezing formats as a sign that they shouldn't be further modified.
2010-03-19 17:20:20 +01:00
Xavier Noria
f3743362c2
cleans a bit #compute_public_path
...
[#4232 state:committed]
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2010-03-19 07:32:41 -07:00
José Valim
fbe35656a9
Singleton classes returns parent's methods with instance_methods(false) and this makes remove_method in Module#delegate fail. Add a test case and fix the bug.
2010-03-19 12:01:48 +01:00
Sebastian Martinez
b395c81e3c
removed useless require line
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-03-19 11:08:06 +01:00
wycats
0aa0c37b59
Well that was a bust
2010-03-18 22:55:44 -07:00
wycats
995f57033f
We seem to have removed the URL helpers from ActionView subclasses...
2010-03-18 22:21:25 -07:00
Carlhuda
a5d80f84d2
Each controller class has it's own view context subclass. This removes the need for ActionView::Base.for_controller
2010-03-18 18:14:54 -07:00
Santiago Pastorino
e629e21135
remove duplicated self.view_paths assingment on controller tests [ #4206 state:commited]
...
Signed-off-by: wycats <wycats@gmail.com >
2010-03-18 17:50:28 -07:00
Santiago Pastorino and Sebastian Martinez
e7276a9f09
Make dependencies_test pass running standalone [ #4215 state:resolved]
...
Signed-off-by: wycats <wycats@gmail.com >
2010-03-18 17:50:28 -07:00
Santiago Pastorino and Sebastian Martinez
1e2caa5d52
Added missing requires abstract_unit and activesupport to the loadpath of ts_isolated [ #4215 state:committed]
...
Signed-off-by: wycats <wycats@gmail.com >
2010-03-18 17:50:28 -07:00
Carlhuda
1dacc19702
Return a valid Rack response from bare ActionController::Metal
2010-03-18 17:32:53 -07:00
Carlhuda
edb5991a14
Make render :partial, :layout consistent between AC and AV
2010-03-18 16:55:32 -07:00
Carlhuda
71c9337f45
All tests pass without memoizing view_context
2010-03-18 15:52:43 -07:00
Carlhuda
523d0f3700
Remove caching's dependency on view_context. Also, make it so that the layout is always rendered the same way (so that layout dependencies on the action actually being rendered aren't masked on the first render)
2010-03-18 14:55:29 -07:00
Carlhuda
d8c7efece6
Make action_has_layout? non-private
2010-03-18 14:55:29 -07:00
Carlhuda
3deb60e6b4
@layout is a confusing name... use @cache_layout
2010-03-18 14:55:29 -07:00
Aaron Patterson
587f468282
kill where / having method redefine warnings. [ #4225 state:resolved]
...
Signed-off-by: wycats <wycats@gmail.com >
2010-03-18 13:30:59 -07:00
wycats
014bd4b287
Merge branch 'master' of github.com:rails/rails
2010-03-18 13:30:52 -07:00
Sebastian Martinez
14b1dc209d
Fixed require line
...
Signed-off-by: wycats <wycats@gmail.com >
2010-03-18 11:54:50 -07:00
Carlhuda
8e64998951
While isolated tests are useful, they take far too long to run for us to be getting useful information from CI. Perhaps another box that runs the isolated tests every 3 hours (instead of per commit)
2010-03-18 11:37:04 -07:00
Sebastian Martinez
bc36618ae6
added require abstract_unit on setter_trap.rb
...
Signed-off-by: wycats <wycats@gmail.com >
2010-03-18 11:32:51 -07:00
Carlhuda
9da153c2d3
Fix an error in isolated running of tests
2010-03-18 11:31:52 -07:00
snusnu
d164d868b3
AS datetime conversions now require AS time conversions
2010-03-18 10:48:11 -07:00
Aaron Patterson
3911a7c197
squelching more warnings in the AR tests. [ #4218 state:resolved]
...
Signed-off-by: wycats <wycats@gmail.com >
2010-03-18 10:24:16 -07:00
José Valim
191a2f78b1
Sending the partial as info is no longer required.
2010-03-18 12:12:07 +01:00
Jeremy Kemper
41af6d9a78
Use Array.wrap not Array()
2010-03-17 22:27:48 -07:00
Jeremy Kemper
fe2f383cf3
Fix broken test due to constant collision
2010-03-17 22:27:34 -07:00
Jeremy Kemper
db9e67a6c8
Kill nonexistent method removal
2010-03-17 21:43:01 -07:00
Mathias Biilmann Christensen
c8dd6f224c
Deleting and setting a cookie in the same request was broken
...
Made sure to remove a cookie from @deleted_cookies when set
[#4211 state:committed]
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2010-03-17 18:04:32 -07:00
Carlhuda
0e15f07b75
Get modules back into integration tests
2010-03-17 17:52:21 -07:00
Mathias Biilmann Christensen
6c0c0f41a3
Fix for missing dependency in ActionDispatch::Integration
...
When running cucumber features from a new rails 3 app requiring
'cucumber/rails/world' would raise:
uninitialized constant ActionDispatch::Integration::Session::Test (NameError)
Fixed by requiring 'test/unit/assertions' in action_dispatch/integration
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2010-03-17 16:53:42 -07:00
Carlhuda
d9375f3f30
Modify assert_template to use notifications. Also, remove ActionController::Base#template since it is no longer needed.
2010-03-17 16:29:35 -07:00
José Valim
7872fa9a43
Merge branch 'master' of gitproxy:rails/rails
2010-03-17 23:47:22 +01:00
José Valim
a6dc227167
Mark bang instrumentations as something that you shuold not be listening to.
2010-03-17 23:44:03 +01:00
snusnu
644219a680
Require AS singleton_class code in AS output_safety
...
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2010-03-17 15:14:35 -07:00
José Valim
21dcbb17de
Ensure json is loaded before using responders.
2010-03-17 23:09:28 +01:00
Xavier Noria
61f6749fb7
guides generator skips untouched guides by default, override with ALL=1
2010-03-17 23:03:48 +01:00
Carlhuda
6416a35f4b
Remove unneeded AV::Base and AV::Template monkey-patches
2010-03-17 14:29:18 -07:00
Carlhuda
947f86c699
Modify assert_template to use instrumentation
2010-03-17 14:29:18 -07:00
Joshua Peek
13a783672a
Install url helpers on module instance so they can be accessed
...
globally
2010-03-17 16:05:29 -05:00
Aaron Patterson
b652aa8121
cleaning up a bunch of method already defined warnings [ #4209 state:resolved]
...
Signed-off-by: wycats <wycats@gmail.com >
2010-03-17 13:56:33 -07:00
Aaron Patterson
db2d96a6ba
fixing activemodel tests. [ #4210 state:resolved]
...
Signed-off-by: wycats <wycats@gmail.com >
2010-03-17 13:46:21 -07:00
Jeremy Kemper
067b350301
Move require closer to home
2010-03-17 10:11:38 -07:00
Aaron Patterson
843255a763
fixing activerecord tests [ #4205 state:resolved]
...
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2010-03-17 10:09:14 -07:00
wycats
7a83abe52f
Any reason we can't just use the slow 1.8 path for transliteration in 1.9?
2010-03-17 00:54:42 -07:00
wycats
640ee5b68d
Fix some more warnings on 1.9
2010-03-17 00:53:48 -07:00
wycats
a5587efc19
Remove some 1.9 warnings (resulting in some fixed bugs). Remaining AM warnings are in dependencies.
2010-03-17 00:20:09 -07:00
wycats
cd9ffd11e1
Eliminate warnings for AM on 1.8
2010-03-16 23:24:00 -07:00
wycats
c738812415
Another missing require
2010-03-16 21:37:54 -07:00
Joshua Peek
d69e5616e8
link_to_function is here to stay
2010-03-16 22:06:16 -05:00
wycats
55aac2c696
Fix missing require
2010-03-16 17:32:42 -07:00
wycats
7c49b1adbb
Make sure options[:anchor] is correct in shorthand cases
2010-03-16 17:29:11 -07:00
Santiago Pastorino
0c1ac36ccb
scope_key_by_partial fix for Ruby 1.9 when there's virtual_path [ #4202 state:resolved]
...
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2010-03-16 16:20:10 -07:00
José Valim
7a5da21481
Use human_name in scaffold.
2010-03-17 00:09:43 +01:00
Carl Lerche
23b6def0eb
Do not always include the named URL helpers into AC::Base and AV::Base.
2010-03-16 15:47:49 -07:00
Carl Lerche
3abf5ad7f8
Make RouteSet#finalize! a NOOP if it's been called already. Call finalize! the first time call() and url_for() are called if the RouteSet has not been finalized yet.
2010-03-16 15:47:48 -07:00
Xavier Noria
b6edffa640
AS guide: completes section about loading AS core extensions within a Rails application
2010-03-16 23:38:08 +01:00
José Valim
56fb60ebfe
Fix rendering of HTML partials inside JS templates [ #4197 status:resolved]
2010-03-16 23:36:29 +01:00
Aaron Patterson
df735cf5b7
fisting uninitialized ivar warnings. [ #4198 state:resolved]
...
Signed-off-by: wycats <wycats@gmail.com >
2010-03-16 15:11:00 -07:00
Xavier Noria
f9edf89d57
AS guide: adds extension to file name
2010-03-16 22:52:39 +01:00
Santiago Pastorino
12bf636461
translation method of TranslationHelper module returns always SafeBuffer [ #4194 status:resolved]
...
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2010-03-16 13:49:13 -07:00
Xavier Noria
9659d18c9b
adds tests for #flush_output_buffer
...
[#4196 state:committed]
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2010-03-16 13:16:44 -07:00
Xavier Noria
986cac73e3
adds tests for #capture
...
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2010-03-16 13:10:54 -07:00
Aaron Patterson
8c3e46c093
clean up more warnings, remove unnecessary methods, fix eval line numbers. [ #4193 state:resolved]
...
Signed-off-by: wycats <wycats@gmail.com >
2010-03-16 11:48:34 -07:00
Carlhuda
c61ed70b00
Some more tweaks on <% %>.
...
* The cache helper is now semantically "mark this region for caching"
* As a result, <% x = cache do %> no longer works
2010-03-16 11:43:04 -07:00
James Golick
67d8b9743a
Improve performance of multibyte utils.
...
Switch from using String#match to using String#=~. There's no need to
generate a MatchData for each iteration since we're not using it.
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2010-03-16 10:04:20 -07:00
José Valim
0db68fd140
Change functional tests to make use of a setup block.
2010-03-16 16:53:54 +01:00
Santiago Pastorino
e13c179499
Change array entries to safe doesn't worth then the array is joined as a string losing the safe property of his entries [ #4134 status:resolved]
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-03-16 11:10:31 +01:00
Chris Griego
0f504a5646
Deprecated framework rake tasks should exit with non-zero exit code [ #4177 status:resolved]
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-03-16 11:10:30 +01:00
Jeremy Kemper
b65b989725
Break a window :/
2010-03-15 23:49:35 -07:00
Jeremy Kemper
748c78ffc8
RJS may cache an array
2010-03-15 23:48:32 -07:00
Jeremy Kemper
b3b6ff48df
Fix link_to with block
2010-03-15 23:26:48 -07:00
Jeremy Kemper
9e1e95f70a
link_to_remote -> link_to :remote => true
2010-03-15 23:05:12 -07:00
Jeremy Kemper
b9c48f519f
Swear I ran this test
2010-03-15 22:44:49 -07:00
Jeremy Kemper
2a50eabf45
Integration test url options should account for :protocol not just https?
2010-03-15 19:52:41 -07:00
Aaron Patterson
dcf1441c0f
removing dead code from activerecord tests. [ #4187 state:resolved]
...
Signed-off-by: wycats <wycats@gmail.com >
2010-03-15 18:36:08 -07:00
Aaron Patterson
1def14309f
cleaning up a bunch of parse time warnings in AR [ #4186 state:resolved]
...
Signed-off-by: wycats <wycats@gmail.com >
2010-03-15 18:22:31 -07:00
José Valim
8dd731bc50
Move more normalization up to the lookup context, so it does not have to repeat in every resolver.
2010-03-16 02:09:16 +01:00
Jeremy Kemper
1f5e2f2bad
Revert "Reinstate old default_url_options method signature"
...
This reverts commit 5913dd4781 .
2010-03-15 16:49:03 -07:00
Xavier Noria
c5a877f142
adds test coverage for with_output_buffer
...
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2010-03-15 16:30:31 -07:00
Jeremy Kemper
5913dd4781
Reinstate old default_url_options method signature
2010-03-15 15:54:37 -07:00
Jeremy Kemper
9ee600fe0c
Allow memcache-client 1.8.0
2010-03-15 15:38:28 -07:00
Carlhuda
9de83050d3
Add deprecation notices for <% %>.
...
* The approach is to compile <% %> into a method call that checks whether
the value returned from a block is a String. If it is, it concats to the buffer and
prints a deprecation warning.
* <%= %> uses exactly the same logic to compile the template, which first checks
to see whether it's compiling a block.
* This should have no impact on other uses of block in templates. For instance, in
<% [1,2,3].each do |i| %><%= i %><% end %>, the call to each returns an Array,
not a String, so the result is not concatenated
* In two cases (#capture and #cache), a String can be returned that should *never*
be concatenated. We have temporarily created a String subclass called NonConcattingString
which behaves (and is serialized) identically to String, but is not concatenated
by the code that handles deprecated <% %> block helpers. Once we remove support
for <% %> block helpers, we can remove NonConcattingString.
2010-03-15 14:50:43 -07:00
Xavier Noria
9209f7bafc
guides generation: undoes output buffer workaround, more refactors
2010-03-15 22:06:27 +01:00
Jeremy Kemper
1f2738261f
Hack to keep column metadata queries out of test query counts
2010-03-15 13:56:19 -07:00
Pratik Naik
03a62f4afe
Merge remote branch 'mainstream/master'
2010-03-15 19:46:03 +00:00
Xavier Noria
a594a22267
with_output_buffer cannot assume there's an output_buffer
...
[#4182 state:committed]
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2010-03-15 11:26:51 -07:00
Jeremy Kemper
c937da9e2f
to_str works here
2010-03-15 11:18:45 -07:00
Jeremy Kemper
ed199554f1
CI: sudo rm to sledgehammer bad perms
2010-03-15 11:01:16 -07:00
Jeremy Kemper
30f5f95544
Hack to keep column metadata queries out of test query counts
2010-03-15 11:00:25 -07:00
Aaron Patterson
5de3698e2b
cleaning up many more warnings in activerecord [ #4180 state:resolved]
...
Signed-off-by: wycats <wycats@gmail.com >
2010-03-15 08:57:41 -07:00
Xavier Noria
f53fddf366
AS guide: documents a use case for :instance_writer, based on a remark of Jeremy
2010-03-15 16:11:13 +01:00
Andrew White
96bc6bcfee
Don't force singularization of singleton resource names, e.g. /preferences [ #4089 state:resolved]
...
Signed-off-by: Joshua Peek <josh@joshpeek.com >
2010-03-15 09:45:29 -05:00
Xavier Noria
ac202a26ce
refactors some bits of the guides generator, ONLY selection accepts prefixes, guides generation fixed for 1.9, revised string safety in a few spots
2010-03-15 09:57:08 +01:00
Jeremy Kemper
16572fd46e
read_ and write_fragment cache preserve html safety yet cache strings only
2010-03-14 19:09:32 -07:00
Aaron Patterson
95bd56e3cc
speeding up clone_attributes, changing readonly to be initialized in def initialize
...
Signed-off-by: wycats <wycats@gmail.com >
2010-03-14 17:29:25 -06:00
Aaron Patterson
115230e619
cleaning up some test warnings
...
Signed-off-by: wycats <wycats@gmail.com >
2010-03-14 17:28:27 -06:00
Santiago Pastorino
d1eed89ac3
There's a Ruby issue with File.basename different versions returns different things, so we shouldn't test that
2010-03-14 14:57:45 -05:00
Santiago Pastorino
beeb02076a
Making escaped things more readable
2010-03-14 12:07:15 -05:00
José Valim
3da9a08a73
Optimize DetailsKey generation.
2010-03-14 10:25:29 +01:00
Xavier Noria
c8f1aac761
restricts a test to < 1.9, and rewrites it using a proper expectation
...
Signed-off-by: wycats <wycats@gmail.com >
2010-03-13 17:04:08 -06:00
José Valim
4ba334c0f4
Ensure controller filters are executed before stuff starts to happen.
2010-03-13 21:28:34 +01:00
Jeroen van Dijk
d252766d03
Update of block helpers examples in form_helper.rb
2010-03-13 17:30:30 +01:00
José Valim
ee4c89627a
Remove formats setters from render template, speeding up partial and collection renderings.
2010-03-13 09:15:13 +01:00
Xavier Noria
89eae2d187
adds coverage for the issue addressed in fe43bbd
...
[#4166 state:committed]
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2010-03-12 13:22:47 -08:00
Caio Chassot
94a60a5600
In app_generator, fix hardcoded bundle call to derive the bundle executable name from Thor::Util.ruby_command.
...
This ensures that eg. when `rails` is called from `ruby1.9`, `bundle1.9` is called.
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-03-12 21:33:39 +01:00
Kieran Pilkington
9268b598bb
Add a check to ensure that the application name does not already exist, i.e. String or Module are part of ruby [ #3872 status:resolved]
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-03-12 21:33:39 +01:00
Denis Odorcic
e484d4ae56
Made asset_tag_helper use config.perform_caching instead of ActionController::Base.perform_caching
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-03-12 21:33:39 +01:00
José Valim
b8f7ba2935
Prettify generators description whenever using the default stack [ #4143 status:resolved]
2010-03-12 21:33:39 +01:00
Xavier Noria
fe43bbd8c7
keep AssociationProxy#to_a to avoid warning in Array(post.author), and delegate it to @target in association collections
...
[#4165 state:committed]
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2010-03-12 11:53:22 -08:00
José Valim
611744ebd3
Load the environment before executing rails console. [ #3905 status:resolved]
2010-03-12 20:41:41 +01:00
José Valim
2b0611b9bb
Revert "Always load the environment before executing any command. [ #3905 status:resolved]"
...
This reverts commit 16846553b8 .
2010-03-12 20:40:34 +01:00
José Valim
f2c0a353ae
Finish cleaning up rendering stack from views and move assigns evaluation to controller (so plugins and/or controllers can overwrite just one method).
2010-03-12 20:39:53 +01:00
Jeroen van Dijk
20eb1ca77e
Updated documentation for block helpers in render/layouts.rb
2010-03-12 17:15:21 +01:00
Pratik Naik
e68bfaf1fe
Merge remote branch 'mainstream/master'
...
Conflicts:
activerecord/lib/active_record/base.rb
railties/lib/rails/configuration.rb
railties/lib/rails/log_subscriber.rb
2010-03-12 16:00:01 +00:00
Jeroen van Dijk
ef6462c730
Updated documentation for block helpers in render/partials.rb
2010-03-12 16:50:15 +01:00
Jeroen van Dijk
67de0af604
Updated documentation for block helpers in form_tag_helper.rb
2010-03-12 16:50:14 +01:00
Jeroen van Dijk
a098720719
Updated documentation for block helpers in javascript_helper.rb
2010-03-12 16:50:14 +01:00
Jeroen van Dijk
363616572d
Updated documentation for block helpers in prototype_helper.rb
2010-03-12 16:50:14 +01:00
Jeroen van Dijk
e8d2f48cff
Updated documentation for block helpers in record_tag_helper.rb
2010-03-12 16:50:14 +01:00
Jeroen van Dijk
04963f16c2
Updated documentation for block helpers in tag_helper.rb
2010-03-12 16:50:14 +01:00
Jeroen van Dijk
e98474096a
Updated documentation for block helpers in url_helper.rb
2010-03-12 16:50:14 +01:00
José Valim
2a12686832
Allow anything that responds to render to be given as :template and use find_template instead of find in views.
2010-03-12 14:25:10 +01:00
José Valim
16846553b8
Always load the environment before executing any command. [ #3905 status:resolved]
2010-03-12 12:53:22 +01:00
José Valim
4840acd485
%= works for content_tag and does not require parenthesis on method call
2010-03-12 12:08:23 +01:00
José Valim
839362fa07
Make all AP tests pass for Ruby 1.9.1.
2010-03-12 11:50:45 +01:00
Jeremy Kemper
f10631e13d
Be sure to pass through args to to_yaml
2010-03-11 18:37:28 -08:00
Jeremy Kemper
5a7f7928a6
Fix test
2010-03-11 17:49:17 -08:00
Jeremy Kemper
47bc138fc1
Write strings to fragment cache, not outputbuffers
2010-03-11 17:43:29 -08:00
Jeremy Kemper
1f6c5677ad
OutputBuffer#to_yaml should return string yaml, not some custom class dump
2010-03-11 17:42:29 -08:00
Jeremy Kemper
698312de87
Delegate #encoding to SafeBuffer too
2010-03-11 17:42:27 -08:00
Eaden McKee
b27376773e
simplify alt tag generation for images
...
[#2837 state:committed]
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2010-03-11 17:33:41 -08:00
Jeremy Kemper
d56e8be22d
Revert "Rake task for generating Rails documentation updated to support Bundler."
...
Incredibly slow. Fix gem_path to not load the bundle fresh each call.
This reverts commit 58796dcfc0 .
2010-03-11 13:23:58 -08:00
Carl Lerche
8b4dca109a
ActionController::Base.request_forgery_protection_token should actually be the name of the token and not true.
2010-03-11 10:08:18 -08:00
Rizwan Reza
58796dcfc0
Rake task for generating Rails documentation updated to support Bundler.
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-03-11 13:44:57 +01:00
José Valim
6c027443b0
Add tests for lookup context.
2010-03-11 13:23:14 +01:00
Xavier Noria
8cc55777a8
release notes: minor edit pass
2010-03-11 12:29:17 +01:00
Mikel Lindsaar
0db8af1099
Updating 3.0 release notes with cookie session store and secret changes
2010-03-11 22:18:28 +11:00
Mikel Lindsaar
6932b180f8
Updating command line guide
2010-03-11 22:12:04 +11:00
Mikel Lindsaar
965fe59bff
Merge branch 'master' of github.com:lifo/docrails
2010-03-11 22:07:48 +11:00
Mikel Lindsaar
f5774e3e3f
Merge branch 'master' of git://github.com/rails/rails
2010-03-11 22:05:15 +11:00
Jeremy Kemper
073852dff0
Float arel on latest rails/arel
2010-03-10 16:10:45 -08:00
Jeremy Kemper
3d5d0286b3
Update scaffold to use <%= form_for
2010-03-10 16:04:12 -08:00
Jeremy Kemper
c5ff181480
Use arel 0.3.1, for srs
2010-03-10 14:04:10 -08:00
Jeremy Kemper
0b00e2b0e2
For rails tests, use latest from rails/arel.git
2010-03-10 13:49:12 -08:00
Jeremy Kemper
275df55106
Bump arel dep to 0.3.0+
2010-03-10 13:49:11 -08:00
Emilio Tagua
e08c153a08
Arel now fallback to using Arel::Attribute if the table/column doesn't exists.
...
[#4142 state:committed]
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2010-03-10 13:49:11 -08:00
Aaron Patterson
aad432a9e9
removing spawn from SpawnMethods
...
Signed-off-by: wycats <wycats@gmail.com >
2010-03-10 13:29:00 -08:00
wycats
4745b53bcd
Merge branch 'master' of github.com:rails/rails
2010-03-10 13:28:52 -08:00
José Valim
84f6da45a1
Merge branch 'master' of gitproxy:rails/rails
2010-03-10 22:17:44 +01:00
José Valim
07cf49aadf
Optimize and clean up how details key get expired.
2010-03-10 22:13:29 +01:00
José Valim
ec0973c2ab
Remove uneeded methods.
2010-03-10 16:44:24 +01:00
José Valim
bbc4de75d3
Require AP::VERSION in order to install gems.
2010-03-10 14:32:02 +01:00
Pratik Naik
181c414baa
Fix scope loading issue when the table doesn't exist
2010-03-10 11:28:04 +00:00
wycats
7b622786fc
Make form helpers work with <%=
2010-03-09 23:44:12 -08:00
Carlhuda
4464b8e87b
Deprecate block_called_from_erb? pending a solution for getting it into apps
2010-03-09 23:44:12 -08:00
wycats
f30b7a0903
Rails requires Rubygems 1.3.6
2010-03-09 23:44:12 -08:00
Joshua Peek
dcd110c724
skip_relative_url_root url_for option is dead
2010-03-09 21:25:09 -06:00
Joshua Peek
1cc2a61ea6
Allow default_url_options to be set on route set
2010-03-09 21:20:13 -06:00
Joshua Peek
4d2470f7da
RouteSet#rewrite => url_for
2010-03-09 21:00:24 -06:00
Joshua Peek
e38ea982ff
Unused RouteSet#url_for is hogging a good method name
2010-03-09 20:57:43 -06:00
Joshua Peek
7db80f87e9
Move AC::UrlRewriter onto route set
2010-03-09 20:50:35 -06:00
José Valim
ffec153029
Merge branch 'master' of gitproxy:rails/rails
2010-03-09 22:57:15 +01:00
José Valim
6cee532a44
Added alert to layouts on scaffold.
2010-03-09 22:21:51 +01:00
Jeremy Kemper
a87683fb38
Disprefer JSONGem decoder since it only decodes JSON objects
2010-03-09 11:06:54 -08:00
Justin Ko
ea4f8ef33f
Reinstate dom_id in controllers.
...
[#3040 state:committed]
Signed-off-by: Santiago Pastorino <santiago@wyeworks.com >
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2010-03-09 10:49:36 -08:00
wycats
9444ac9312
Refactor the RouteSet so it uses a Generator object instead of one huge method.
2010-03-09 10:20:56 -08:00
wycats
de79525d04
Get rid of the instance-level URL rewriter
2010-03-09 10:20:56 -08:00
José Valim
00d6271d2b
Clean up the API required from ActionView::Template.
2010-03-09 13:12:11 +01:00
Jeremy Kemper
c507e16dba
Reinstate default_url_options and remove url_options= writer
2010-03-08 21:40:45 -08:00
Jeremy Kemper
514d3a47f4
Remove outdated, distracting commented code
2010-03-08 21:40:18 -08:00
wycats
e4558e0dbf
Now that class_attribute creates an instance method, remove it to avoid deprecation warnings ;)
2010-03-08 18:48:58 -08:00
Carlhuda
056042eb82
Simplify the action endpoint:
...
* Remove ActionEndpoint in favor of passing a block to MiddlewareStack
* Always create a Request; the performance win of RackDelegation is around
the response; the Request object hit is limited to a single object allocation
* #dispatch takes a Request
2010-03-08 16:50:00 -08:00
Carlhuda
146a5305d5
Add memoizing to AD::Request
2010-03-08 16:50:00 -08:00
Jeremy Kemper
60bbf16bfd
class_attribute gets instance methods which delegate to but may override their class values as you'd expect. Disable instance writer methods with :instance_writer => false.
2010-03-08 16:20:54 -08:00
Carlos Antonio da Silva
47d252f992
Fix associations to call :destroy or :delete based on the right :dependent option
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-03-09 00:11:34 +01:00
Carl Lerche
8e9d9232b0
Require 'active_support/core_ext/hash/except' in the router.
2010-03-08 14:36:05 -08:00
José Valim
8f082ff421
Clean LookupContext API.
2010-03-08 23:25:16 +01:00
Carl Lerche
01f0e47663
Move request forgery protection configuration to the AC config object
...
This is an interim solution pending revisiting the rails
framework configuration situation.
2010-03-08 14:02:41 -08:00
Carlhuda
0045f37681
Whoops. We meant to switch from returning to tap, not vice versa
2010-03-08 12:30:51 -08:00
Carlhuda
f38e2e0335
Add support for mount RackApp, :at => "/sprockets" with a shorthand of mount Sprockets => "/sprockets".
...
This is different from the match syntax in that it cannot be used for controller/action and it does not
assume an anchor at the end of the match.
For instance, in the above example, if the client asked for "/sprockets/foo.js", the Sprockets app would
have a SCRIPT_NAME of "/sprockets" and PATH_INFO of "/foo.js".
2010-03-08 12:26:18 -08:00
José Valim
7942e90960
Merge master.
2010-03-08 21:06:26 +01:00
José Valim
36eb1a686c
Bring AM up to date with new rendering stack.
2010-03-08 20:57:33 +01:00
Carlhuda
ae93789d9a
Move middlewares to the Application level. If you want to modify the middleware, either use Rails.application.config.middleware or modify it in an initializer (if you need to set it relative to user-specified middleware).
2010-03-08 11:40:51 -08:00
José Valim
bdf5096816
Move details to lookup_context and make resolvers use the cache key.
2010-03-08 20:39:15 +01:00
José Valim
67a6725bf9
Move ViewPaths module to its own file.
2010-03-08 16:50:10 +01:00
José Valim
68cda695da
Speed up performance in resolvers by adding fallbacks just when required.
2010-03-08 16:32:40 +01:00
José Valim
44ebab96da
Rename Template::Lookup to LookupContext.
2010-03-08 15:19:03 +01:00
José Valim
ea68fe59c6
More refactoring on the views side of rendering.
2010-03-08 14:46:57 +01:00
José Valim
0a85380966
Finally moved the find template logic to the views.
2010-03-08 11:32:01 +01:00
wycats
79b0b5082c
Aliasing class_eval makes JRuby ornery.
2010-03-07 22:34:39 -08:00
wycats
54a69c31ed
Typo in config.action_dispatch
2010-03-07 21:27:40 -08:00
José Valim
34b2180451
More refactoring. Split _normalize_args and _normalize_options concerns.
2010-03-08 03:23:23 +01:00
José Valim
4bae77a89b
More cleanup on the layouts side.
2010-03-08 02:58:16 +01:00
José Valim
ffd8d753f1
Move layout lookup to views.
2010-03-08 02:04:18 +01:00
Jan De Poorter
dfc7ff6429
Make sure nested singular resources get the correct name
...
[#3911 state:committed]
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2010-03-07 14:36:26 -08:00
Jeremy Kemper
aa758b9388
Update generated Gemfile to use http://rubygems.org , unicorn instead of mongrel, and nokogiri instead of hpricot
2010-03-07 12:41:54 -08:00
Jeremy Kemper
4a89467f7c
If RAILS_PATH isn't set, make a dummy doc task
2010-03-07 12:39:53 -08:00
Jeremy Kemper
ee580d0cc3
rake doc:rails complains loudly if there's no path to generate docs from
2010-03-07 12:06:48 -08:00
José Valim
c7564d74e8
Added template lookup responsible to hold all information used in template lookup.
2010-03-07 19:41:58 +01:00
Joshua Peek
e00bc711d8
Bump rack-mount requirement to 0.6
2010-03-07 11:09:50 -06:00
wycats
39d6f9e112
Make many parts of Rails lazy. In order to facilitate this,
...
add lazy_load_hooks.rb, which allows us to declare code that
should be run at some later time. For instance, this allows
us to defer requiring ActiveRecord::Base at boot time purely
to apply configuration. Instead, we register a hook that should
apply configuration once ActiveRecord::Base is loaded.
With these changes, brings down total boot time of a
new app to 300ms in production and 400ms in dev.
TODO: rename base_hook
2010-03-07 06:24:30 -08:00
José Valim
6e0443fd43
First take on ViewPaths clean up.
2010-03-07 12:49:27 +01:00
Aaron Patterson
a424f199a9
drying up more code in associations.rb
...
Signed-off-by: wycats <wycats@gmail.com >
2010-03-06 21:41:13 -08:00
Aaron Patterson
939291e8f2
deleting repeated code
...
Signed-off-by: wycats <wycats@gmail.com >
2010-03-06 21:33:29 -08:00
Stefan Penner
4bc2cbc3cf
Load RAILS_VERSION relative to the gemspec file.
2010-03-06 21:33:28 -08:00
Aaron Patterson
3789539916
converting inject to each and map
...
[#4119 state:committed]
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2010-03-06 20:31:50 -08:00
Aaron Patterson
45c36ea096
refactoring build_where
...
Signed-off-by: wycats <wycats@gmail.com >
2010-03-06 13:25:12 -08:00
José Valim
028e54c63d
Add mailers to paths in case someone wants to access it directly and ensures deep nesting works in controllers.
2010-03-06 19:25:55 +01:00
Stijn Mathysen
67512b9489
Removed the + sign as an accepted character from the parameterize method, as a + sign is interpreted by the browser as a space, possibly resulting in a "ArgumentError: illegal character in key"
...
[#4080 state:committed]
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2010-03-05 14:11:21 -08:00
Santiago Pastorino
e472f76e4c
Adds disable option to date_helpers generated hidden fields when html_options specifies it. ht by Marc Schütz
...
[#3807 state:committed]
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2010-03-05 13:49:04 -08:00
Malcolm Locke
4adcbb6b2d
Merge branch 'master' of git@github.com:lifo/docrails
2010-03-06 10:12:08 +13:00
Malcolm Locke
18a9906b1c
Corrects setting of :method on custom form_for
2010-03-06 10:09:28 +13:00
Jeremy Kemper
8fc97d198e
Allow deprecation messages with or without a final period.
2010-03-05 12:35:42 -08:00
Jeremy Kemper
a82cf0a932
Tweak default_url_options deprecation warning
2010-03-05 12:17:23 -08:00
Jose Fernandez
a04b44910e
Solved a problem that prevented render :file => work in layouts
...
Signed-off-by: wycats <wycats@gmail.com >
2010-03-05 08:52:10 -08:00
Xavier Shay
8da026cb79
Remove some of the blank rescues from number helper. This makes the code easier to understand, as you're not left wondering what the rescue is actually doing. This does not change documented/tested behaviour.
...
Signed-off-by: wycats <wycats@gmail.com >
2010-03-05 08:50:01 -08:00
José Valim
7d4d97e22a
Actually, revert previous commit. Having a lot of information is better than having no information at all.
2010-03-05 15:49:36 +01:00
José Valim
80715cee73
Define to_s method in ActionView::Resolver, so I'm not required to write it in inherited classes.
2010-03-05 15:40:06 +01:00
Carl Lerche
57cf1c578a
Remove the ability to set the mountpoint when initializing a route set.
2010-03-04 22:17:25 -08:00
Carl Lerche
9a17416d8b
Tweak out url_for uses :script_name and add some tests
2010-03-04 22:00:30 -08:00
Carl Lerche
48672cd199
Have ActionDispatch::Routing::RouteSet.new ready to receive routes as is.
2010-03-04 21:40:26 -08:00
Bryan Helmkamp
deb00bcb8c
Read Rails version from a file instead of modifying the load path and doing requires
...
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2010-03-04 21:25:52 -08:00
Carlhuda
46bf2f04a8
Fixed a broken AM test. I'm unsure how this passed before.
2010-03-04 17:44:16 -08:00
Carlhuda
900a2d304a
Get rid of relative_url_path in favor of respecting SCRIPT_NAME. Also added a way to specify a default SCRIPT_NAME when generating URLs out of the context of a request.
2010-03-04 17:43:46 -08:00
Carlhuda
3438373f03
Use AS::Concern for caching modules
2010-03-04 16:59:54 -08:00
Carlhuda
ff29606c06
Refactor cache_store to use ActionController config
2010-03-04 16:50:57 -08:00
Carlhuda
c8e1cc8657
remove_method is private
2010-03-04 16:35:05 -08:00
Carlhuda
ecf84b239f
Change generated code to replace faulty comment
2010-03-04 16:12:34 -08:00
Carlhuda
e311622e7b
Deprecated ActionController::Base.session_options= and ActionController::Base.session_store= in favor of a config.session_store method (which takes params) and a config.cookie_secret variable, which is used in various secret scenarios. The old AC::Base options will continue to work with deprecation warnings.
2010-03-04 16:05:52 -08:00
Carlhuda
48bb3b3904
Move stuff from compatibility.rb to deprecated.rb
2010-03-04 16:05:52 -08:00
Jeremy Kemper
5e3e5ac12b
Clarify cookie jar test
2010-03-04 15:31:28 -08:00
wycats
7c785592ec
Safely cleans up a test to avoid relying on a particular test order
2010-03-04 15:07:26 -08:00
wycats
70916f6a9c
Fixes test ordering bug (ht: evan)
2010-03-04 12:21:12 -08:00
Carlhuda
9795bf0e74
Fix Sam Ruby's tests and deprecation warnings
2010-03-04 12:12:04 -08:00
Carlhuda
1776969627
Move session and session_store onto ActionDispatch and add deprecation warnings
2010-03-04 11:58:30 -08:00
Carl Lerche
c0c1599fb1
Update CI to the latest bundler
2010-03-04 11:24:38 -08:00
Carl Lerche
cc789ddc89
No need for a module if it's only being included once into an empty class.
2010-03-04 09:56:40 -08:00
Carl Lerche
0de3b9ec93
Somehow this fixes the AR tests when ran with rake. I should probably figure out why.
2010-03-04 02:20:01 -08:00
Carl Lerche
05b9382e29
Update the ActionMailer tests to run off of the latest ActionController config refactor
2010-03-04 01:12:16 -08:00
Carl Lerche
ad2e6ee4ec
Fix a bunch of failing AP / AM specs created from the previous AbstractController configuration refactor.
2010-03-04 01:01:21 -08:00
Carl Lerche
9eddc85444
Add a method for configuring abstract controllers
2010-03-04 00:52:10 -08:00
Carl Lerche
5ce25aecee
Merge branch 'configuration_refactor'
2010-03-03 22:35:43 -08:00
Carl Lerche
13a932cddc
Modifying configurations on the instance of a controller should not affect the class
2010-03-03 21:32:05 -08:00
Carl Lerche
7dbf5c820b
Tweak how ActionPack handles InheritableOptions
2010-03-03 21:29:26 -08:00
Carl Lerche
15b3b74624
Fix all the broken tests due to the AC configuration refactor
2010-03-03 21:24:27 -08:00
Carl Lerche
1f0f05b10c
Move the original config method onto AbstractController
2010-03-03 21:24:27 -08:00
Carlhuda
b160663bd1
Start refactoring the method of configuring ActionView
2010-03-03 21:24:01 -08:00
Carlhuda
54302ef55b
Add caller to deprecation notices
2010-03-03 21:24:00 -08:00
Carlhuda
786724107c
Deprecate IP spoofing settings that are directly on the controller in favor of configuring a middleware
2010-03-03 21:24:00 -08:00
Carlhuda
52efbdcdef
Add caller to request_uri deprecation notice
2010-03-03 21:24:00 -08:00
Carlhuda
93422af5d5
Move remote_ip to a middleware:
...
* ActionController::Base.ip_spoofing_check deprecated => config.action_dispatch.ip_spoofing_check
* ActionController::Base.trusted_proxies deprecated => config.action_dispatch.trusted_proxies
2010-03-03 21:24:00 -08:00
Carl Lerche
9a9caf646d
Add a BlockUntrustedIps middleware
2010-03-03 21:24:00 -08:00
Carl Lerche
902d5a4f05
Indicate that ActionController::Base.resource_action_separator is deprecated and only has an effect with the deprecated router DSL.
2010-03-03 21:24:00 -08:00
Carl Lerche
18bcce596e
ActionController::Base.use_accept_header is not actually used anymore, so let's deprecate it.
2010-03-03 21:24:00 -08:00
Carl Lerche
fb14b8c6fd
ActionDispatch::Request deprecates #request_uri
...
* Refactored ActionPatch to use fullpath instead
2010-03-03 21:24:00 -08:00
Carl Lerche
eb49bd6949
Fix tests for the request refactor
2010-03-03 21:24:00 -08:00
Carl Lerche
c92d598abf
Rack::Request actually defines #query_string
2010-03-03 21:23:59 -08:00
Carlhuda
5e0a05b8cb
Tweak the semantic of various URL related methods of ActionDispatch::Request
2010-03-03 21:23:34 -08:00
Jaime Iniesta
36d28f5168
Update contribute guide so that it shows the new command to generate guides (rake generate_guides instead of rake guides)
2010-03-04 01:51:25 +01:00
Jaime Iniesta
5245bf8635
Updated 3_0_release_notes so that it specifies that the rack-mount gem needs to be version 0.4
2010-03-04 01:48:56 +01:00
Xavier Noria
dca6ddea04
the guides generator needs fileutils
2010-03-04 01:42:57 +01:00
Yehuda Katz
2a60cc6822
don't depend on the order of cookies (Hash ordering bug)
2010-03-03 16:07:23 -08:00
Carlhuda
bcfb77782b
Work on deprecating ActionController::Base.relative_url_root
2010-03-03 15:49:52 -08:00
Carlhuda
6640903481
Move InheritableOptions into ActiveSupport
2010-03-03 15:49:52 -08:00
Carlhuda
bf9913f8f4
Move session_store and session_options to the AC configuration object
2010-03-03 15:49:52 -08:00
Carlhuda
9731c5213b
Don't rely on Rails.application global state in Config
2010-03-03 15:49:24 -08:00
Carlhuda
29158d4158
Remove a failed attempt at refactoring AC configuration
2010-03-03 15:49:24 -08:00
Carl Lerche
7979da2fa8
Revert "In app_generator, fix hardcoded bundle call to derive the bundle executable name from Thor::Util.ruby_command."
...
This reverts commit 6f4c45199b .
This breaks the tests. Please investigate.
2010-03-03 15:38:22 -08:00
Xavier Noria
71b29d1e56
AS guide: How to Load Core Extensions
2010-03-03 19:58:44 +01:00
Caio Chassot
6f4c45199b
In app_generator, fix hardcoded bundle call to derive the bundle executable name from Thor::Util.ruby_command.
...
This ensures that eg. when `rails` is called from `ruby1.9`, `bundle1.9` is called.
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-03-03 10:12:42 +01:00
Joao Carlos
70b8495468
Better with #abort
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-03-03 10:12:42 +01:00
Jason King
f36a380c07
Inflection dependency, [ #4067 status:resolved]
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-03-03 10:12:42 +01:00
Pavel Golubeff
cd5ec4744d
Fix quoting regexp encoding in ActionMailer
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-03-03 10:12:42 +01:00
Carl Lerche
9dae645c5f
Actually move ImplicitRender into it's own file
2010-03-03 00:43:05 -08:00
windock
6feffe5f38
whiny nil shouldn't depend on Active Record [ #4092 status:resolved]
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-03-03 09:41:17 +01:00
José Valim
b4b0c4cb41
Add missing super call in AC::Metal. [ #4085 status:resolved]
2010-03-03 09:25:41 +01:00
Carl Lerche
07b5146442
Fix active_records' log tests
2010-03-02 23:01:31 -08:00
Carl Lerche
312570c488
Fix active_resource tests
2010-03-02 22:56:34 -08:00
Carl Lerche
05f27761a2
Fix action_mailer tests
2010-03-02 22:55:09 -08:00
Teng Siong Ong
eca46e3102
Use non-deprecated Rails.application instead of ActionController::Dispatcher.new and ActionDispatch::Integration instead of ActionController::Integration for console.
...
[#4072 state:committed]
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2010-03-02 21:56:37 -08:00
Mikel Lindsaar
6193be26ce
Removing prototype and just using vanilla js
2010-03-02 18:46:14 -08:00
Mikel Lindsaar
cefe723e28
Removing prototype and just using vanilla js
2010-03-03 13:39:36 +11:00
Xavier Noria
a368f3b170
AS guide: documents String#foreign_key
2010-03-03 00:18:57 +01:00
Xavier Noria
3100ec4355
AS guide: documents String#humanize
2010-03-03 00:05:01 +01:00
Carlhuda
d78e3fe73f
Fix failing Action Pack tests
2010-03-02 14:41:12 -08:00
Jeremy Kemper
9f83cdc38e
No longer add missing leading / on path args to assert_redirected_to. Deprecated in 2.3.6.
2010-03-02 14:16:25 -08:00
Yehuda Katz
6d7d03b77c
Fix some tests that relied on hardcoded Exception information (ht: evan)
2010-03-02 14:04:57 -08:00
Xavier Noria
8627281e3b
AS guide: documents String#constantize
2010-03-02 23:02:44 +01:00
Carlhuda
aa749a74f6
Get the railties tests to pass again.
2010-03-02 14:00:25 -08:00
Jeremy Kemper
ecfd6d90ee
Action Mailer setup obviated by test bundle
2010-03-02 13:54:59 -08:00
Xavier Noria
3084898ca6
AS guide: documents String#classify
2010-03-02 22:29:58 +01:00
Carlhuda
c2dbc391a9
Have log subscribers subscribe to the actual events, so the subscriber doesn't subscribe to *every* event, so we can have events that are slow-ish but are not actually run in production.
2010-03-02 13:05:25 -08:00
Carlhuda
d434c54068
Log Tailer doesn't exist anymore. Removing some traces left over in tests.
2010-03-02 12:34:26 -08:00
Carlhuda
b01db07a9f
Moved initializers for ActionMailer and ActionController into their own railties
2010-03-02 12:32:31 -08:00
Carlhuda
57bae9764e
Fix a test that assumes that defined?(ActiveRecord) == defined?(ActiveRecord::Base)
2010-03-02 12:31:29 -08:00
Carlhuda
a64fcc1a8d
:controller doesn't work for namespaced controllers anymore.
2010-03-02 12:06:40 -08:00
Jeremy Kemper
5c40c2691d
Stray line. Typo.
2010-03-02 10:44:40 -08:00
Jeremy Kemper
56ea20605a
Wordsmith gem descriptions
2010-03-02 10:43:41 -08:00
Jeremy Kemper
ea4fd64133
Revert orphaned SharedTestRoutes
2010-03-01 23:22:11 -08:00
Bryan Helmkamp
f221a6f19f
Leverage VERSION constants from gemspecs to avoid tedious updates when releasing
2010-03-02 00:32:53 -05:00
Bryan Helmkamp
a4111bbca0
Update versions of all components to normalize them to new format
2010-03-02 00:32:48 -05:00
Bryan Helmkamp
b1769fe0bd
Add rake update_versions task at root for quickly updating all components
2010-03-02 00:32:41 -05:00
Jeremy Kemper
a0e8eca30b
Fix unstated usage of Action Dispatch
2010-03-01 21:29:47 -08:00
Jeremy Kemper
812136a0b2
Fix unstated usage of Pathname
2010-03-01 19:29:12 -08:00
Bryan Helmkamp
11db694e0b
Remove cruft in the gem packaging and release code
2010-03-01 19:00:19 -08:00
Jeremy Kemper
8bb162f008
Fix unstated usage of inflector
2010-03-01 18:52:07 -08:00
Carlhuda
fc0882ba5a
Optimize AS::Notifications to remember which subscribers don't match and not run them. This will allow notifications that are only useful in dev or testing to run efficiently in production.
2010-03-01 17:45:37 -08:00
Carlhuda
c88360ef36
You can unsubscribe a subscriber
2010-03-01 17:45:37 -08:00
Carlhuda
048b436f33
AS::Subscriber is not a LogSubscriber
2010-03-01 17:45:37 -08:00
Carlhuda
300d6b549d
Merge _details_defaults and details_for_render
2010-03-01 17:45:37 -08:00
Jeremy Kemper
8b5b241377
Bump pg dep to 0.9.0+
2010-03-01 16:20:10 -08:00
Xavier Noria
88c01b3f10
AS guide: documents String#tableize
2010-03-02 00:25:25 +01:00
Xavier Noria
fbce2327a9
AS guide: documents String#parameterize
2010-03-02 00:06:32 +01:00
Xavier Noria
aab42ccdab
AS guide: documents String#demodulize
2010-03-01 23:42:12 +01:00
Carlhuda
b85ea58eb5
Change AV formats so they can delegate to the controller. Now users (or plugins) can override details_for_render in their controllers and add appropriate additional details. Now if only they could *do* something with those details...
2010-03-01 14:37:05 -08:00
Carlhuda
8fbbdda526
Delegate formats to the controller
2010-03-01 14:10:53 -08:00
Xavier Noria
44bd3bd4ff
AS guide: documents String#dasherize
2010-03-01 22:58:21 +01:00
Xavier Noria
71990a4157
AS guide: documents String#titleize
2010-03-01 22:35:18 +01:00
Xavier Noria
aed8c1f0a4
AV guide: titleize is defined by Active Support
2010-03-01 22:17:12 +01:00
Lourens Naudé
2060977b76
Hash#symbolize_keys(!) optimizations
...
[#3891 state:committed]
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2010-03-01 11:22:41 -08:00
Xavier Noria
0f847b95eb
AS guide: documents String#underscore
2010-03-01 06:36:51 +01:00
Xavier Noria
1064c533ce
AS guide: documents String#singularize
2010-03-01 05:43:56 +01:00
Xavier Noria
51e84bfbd6
AS guide: adds a real example for #pluralize
2010-03-01 05:35:01 +01:00
Joshua Peek
82deaf5f05
nested controllers need to be explicitly declared with the new mapper
2010-02-28 18:43:20 -06:00
Joshua Peek
2ce3085e3c
Define Bundler constant stub if bundler gem is not installed
2010-02-28 18:34:57 -06:00
Joshua Peek
a5da48d231
vendor/rails doesn't work anymore, remove it from the blank slate suggestion
2010-02-28 18:32:46 -06:00
Joshua Peek
30446f7b29
correct activeresource load path
2010-02-28 18:29:34 -06:00
Joshua Peek
5cc17da894
activerecord test load paths
2010-02-28 18:28:25 -06:00
Joshua Peek
4377deed35
ensure activemodel lib is setup correctly
2010-02-28 18:27:00 -06:00
Joshua Peek
1a2fba1b6b
don't expand test path
2010-02-28 18:26:00 -06:00
Joshua Peek
cbefcc88b3
add activesupport and activemodel load paths to actionpack tests
2010-02-28 18:25:02 -06:00
Joshua Peek
f0fe555d84
fix up actionmailer load path
2010-02-28 18:18:21 -06:00
Joshua Peek
6c8d852056
fix up activesupport test load paths
2010-02-28 18:16:57 -06:00
Joshua Peek
fef7a77386
Request#subdomain returns a string version of Request#subdomains
2010-02-28 17:16:34 -06:00
Joshua Peek
7317d9ef4c
Remove implicit controller namespacing from new dsl
2010-02-28 16:39:01 -06:00
Xavier Noria
947511e50e
AS guide: shortens a sentence
2010-02-28 22:32:00 +01:00
Xavier Noria
68dd44cc62
AS guide: documents String#pluralize
2010-02-28 22:28:58 +01:00
Joao Carlos
020fdb28ee
#exit accepts an integer, not a string
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-02-28 12:29:01 +01:00
José Valim
f3839b2b99
ActiveRecord should raise an error on invalid migration types.
2010-02-28 11:53:48 +01:00
José Valim
ae8070e21b
Add missing information about attributes method.
2010-02-28 11:43:13 +01:00
José Valim
32afcdcb88
ActiveModel::Lint should not require our models to respond to id.
2010-02-28 11:39:39 +01:00
Yehuda Katz
6ffc8364dc
Explain why we're calling an empty callback
2010-02-27 17:29:28 -08:00
Yehuda Katz
b51c0d4d25
1.9 doesn't like lambda {} being called with arguments
2010-02-27 17:28:46 -08:00
Jeremy Kemper
b1b922d6ea
Revert "Revert "Application detection should also allow dots in the path.""
...
Works after all. Culprit was 226dfc2 .
This reverts commit 6189480b18 .
2010-02-27 17:10:04 -08:00
Jeremy Kemper
6189480b18
Revert "Application detection should also allow dots in the path."
...
Ruby 1.9 regression.
This reverts commit 76237f163f .
2010-02-27 16:59:18 -08:00
S. Christoffer Eliesen
09cb0977d4
Print database.rake errors to stderr.
...
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2010-02-27 16:53:40 -08:00
Xavier Noria
f3a7f0e028
plugins guide: rails/init.rb is deprecated
2010-02-28 00:14:48 +01:00
Ryan Bigg
56c162e75d
Fix validates_exclusion_of error message as per http://bit.ly/9kxANI [gmile]
2010-02-28 09:42:06 +11:00
Yehuda Katz
1c9de08734
Escape the file name (who knows when a "(" might appear in a filename!)
2010-02-27 12:18:28 -08:00
Yehuda Katz
d8acaf2b66
Remove the noisy lines involving AS::Dependencies from the NameError stack trace if a constant cannot be found.
2010-02-27 11:51:19 -08:00
Yehuda Katz
8247bd9d3e
The instance_reader of default_url_options needs to not exist.
2010-02-27 00:18:16 -08:00
Yehuda Katz
3f0ed205e7
Remind us that RoutingAssertions should work in an integration context
2010-02-26 22:47:36 -08:00
Carlhuda
4bdc783d37
1.9 seems to have a bug involving cloned classes and super. Fix it by not cloning (and instead creating classes on demand). The 1.9 bug should be investigated.
2010-02-26 18:25:56 -08:00
Carlhuda
faf3c2f827
Set the body using the accessor for AD::Response introspection mode so it gets wrapped in a []
2010-02-26 18:24:55 -08:00
Carlhuda
8689989a52
Make ActionController::Routing::Routes a DeprecatedProxy
2010-02-26 17:31:32 -08:00
Carlhuda
050831803a
If IntegrationSession is initialized with an objects that responds to #routes, automatically extend the URL helpers from the RouteSet onto it
2010-02-26 17:18:45 -08:00
Jeremy Kemper
6324eeefd7
plugin rails/init.rb deprecation message
2010-02-26 16:08:00 -08:00
Carlhuda
be0bf10a3c
Upon further reflection, we realized that SharedTestRoutes is not really a hack, but is instead a standin (in the Rails tests) for Rails.application.routes.
...
* In a real application, action_controller/railties.rb does AC::Base.include(app.routes.url_helpers)
* ActionController itself does not know about Rails.application, but instead can have named routes for any router
* SharedTestRoutes are created in abstract_unit to stand in for Rails.application.routes, and is used in
internal functional tests
2010-02-26 16:06:54 -08:00
Carlhuda
74df7795a8
Relatively speaking, it's not actually that bad...
2010-02-26 15:58:24 -08:00
Carlhuda
ab0cc7286f
Setting UrlFor in with_routing is no longer needed now that it's not global
2010-02-26 15:56:38 -08:00
Carlhuda
dae109a463
Including UrlFor in Redirecting and Head will warn usefully if a controller is wired up without a router included (and still support redirect_to "omg")
2010-02-26 15:56:17 -08:00
Carlhuda
3bad24c85d
Remove traces of SharedTestRoutes from user code; leave it as a standin for Rails.application.routes in Rails internal tests
2010-02-26 15:44:22 -08:00
Carlhuda
5797575bac
Stop setting UrlFor using SharedTestHelpers
2010-02-26 15:40:36 -08:00
Carlhuda
47fe14bfcc
Silence test deprecation warnings
2010-02-26 15:34:12 -08:00
Carlhuda
bae691f61a
Change the API for setting global options for #url_for to self.url_options = { ... }
...
This attr_accessor can be set in a before filter or in the action itself.
Overwriting default_url_options still works but will output a deprecation notice.
2010-02-26 15:20:41 -08:00
Carlhuda
224c0318bd
Remove the :use_defaults check in UrlFor#merge options
2010-02-26 15:04:51 -08:00
Carlhuda
98f77e0827
Rename named_url_helpers to url_helpers and url_helpers to url_for
2010-02-26 15:04:50 -08:00
Santiago Pastorino
f10a019452
no more warning ambiguous first argument; put parentheses or even spaces on log_subscriber_test
2010-02-26 14:54:18 -08:00
Santiago Pastorino
b25c41e6d8
no more warning interpreted as argument prefix on association_preload.rb
2010-02-26 14:54:10 -08:00
Santiago Pastorino
b4b158ee10
no more interpreted as grouped expression warnings on array_ext_test
2010-02-26 14:54:02 -08:00
Yehuda Katz
1e95f019bb
Fix 1.9 issue
2010-02-26 14:31:29 -08:00
Ryan Bigg
2f3eefcdca
Nitpick: the first value should be odd, second is even.
2010-02-27 09:29:51 +11:00
Jeremy Kemper
47260598be
CI: restore sudo for bundler gem install
2010-02-26 09:14:12 -08:00
Jeremy Kemper
e1daf3fb73
Remove bin dir from .gitignore
2010-02-26 08:09:09 -08:00
José Valim
e6dffb70e6
reload! on console now works as expected. [ #3822 status:resolved]
2010-02-26 12:09:39 +01:00
José Valim
bd36418c51
Fix controller_path returnsing an empty string in Ruby 1.8.7 [ #4036 status:resolved]
2010-02-26 11:51:21 +01:00
Tobias Bielohlawek
4db72b702f
fixed a 'RecordNotFound' bug when calling 'reload' on a object which doesn't met the default_scope conditions, added test [ #3166 status:resolved]
...
The reload method didn't made use of 'with_exclusive_scope' when reloading the object. This lead to a RecordNotFound exception, in case the object doesn't met the default_scope condition (anymore) - which is obviously a bug. This quick fix makes use of with_exclusive_scope in the reload method as well. See test for full example.
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-02-26 11:14:16 +01:00
Dr Nic Williams
b56b9ee7d6
#add_source: Fixed docco + added required newline to line added to Gemfile
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-02-26 11:11:35 +01:00
Henry Hsu
bf9a0ae12b
Fix a bug where default_scope was overriding attributes given on model initialization [ #3218 status:resolved]
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-02-26 11:09:43 +01:00
Ramon Soares
79c47abe6c
the folder public/javascripts should be created by default [ #4027 status:resolved]
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-02-26 10:54:44 +01:00
José Valim
36a234609d
Update thor dependency.
2010-02-26 10:51:13 +01:00
José Valim
5893baa683
Add autoload to generators modules and fix failing test.
2010-02-26 10:44:53 +01:00
José Valim
b48beb6986
Add missing require on abstract_controller/collector [ #4061 status:resolved]
2010-02-26 10:27:06 +01:00
Carlhuda
f863045c45
Rename metaclass to singleton_class
2010-02-25 17:56:58 -08:00
Carlhuda
8760add31a
Get URL helpers working again in integration tests.
2010-02-25 17:53:30 -08:00
Carlhuda
fc4582fb66
Final pass at removing the router from a global constant
2010-02-25 17:53:29 -08:00
Carlhuda
36fd9efb5e
Continued effort to deglobalize the router
2010-02-25 17:53:01 -08:00
Carlhuda
9a5be2e5a8
Get Railties tests passing
2010-02-25 17:53:01 -08:00
Carlhuda
1fb2c6f635
Get ActionMailer's tests passing with the non global router
2010-02-25 17:53:01 -08:00
Carlhuda
a278f23310
Fix all of AP's tests with the non global router
2010-02-25 17:53:01 -08:00
Carlhuda
4b038f638d
Merge branch 'master' of github.com:rails/rails
2010-02-25 17:53:01 -08:00
Carlhuda
226dfc2681
WIP: Remove the global router
2010-02-25 17:53:00 -08:00
José Valim
76237f163f
Application detection should also allow dots in the path.
2010-02-26 02:35:14 +01:00
Jeremy Kemper
1ff7e566fd
Bump to Bundler 0.9.8. Remark on RubyGems 1.3.6 fix.
2010-02-25 16:55:42 -08:00
Jeremy Kemper
6e78fdbef0
Remove doubled period
2010-02-25 16:45:59 -08:00
Jeremy Kemper
e2795383cf
Update plugin tasks dirs deprecation warning
2010-02-25 16:32:24 -08:00
Xavier Noria
4dcc4a0b60
AS guide: s/metaclass/singleton_class/ due to 0b87d11
2010-02-26 00:18:11 +01:00
Jeremy Kemper
66d537852b
Bump i18n for new public I18n.normalize_keys
2010-02-25 15:06:11 -08:00
Jeremy Kemper
2ba6049506
Accept array of attributes as arg also, like 2.3
2010-02-25 13:07:48 -08:00
Jeremy Kemper
763f32ab47
metaclass deprecated in 2.3.6
2010-02-25 11:12:27 -08:00
Jeremy Kemper
ffc45f3e71
Fix dangling klass reference
2010-02-25 11:01:15 -08:00
Jeremy Kemper
0b87d114bd
Missed singleton_class
2010-02-25 10:57:29 -08:00
Jeremy Kemper
c7f9e8c06c
Fix test on 1.8.8. Broken by inherited hook now running before Class.new block.
2010-02-25 10:46:29 -08:00
Thomas R. Koll
45ceacd6de
load_path is expecting a String in the application.rb generator
...
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2010-02-25 10:45:34 -08:00
Jeremy Kemper
f7b0a857e9
Use Object#singleton_class instead of #metaclass. Prefer Ruby's choice.
2010-02-25 09:32:29 -08:00
Jeremy Kemper
6b12d74026
Commented metaprogramming turned out to be noisier not clearer
2010-02-25 09:28:18 -08:00
David Heinemeier Hansson
bf0f14579a
let the rails command recurse upwards looking for script/rails, and exec ruby on it for better portability [Xavier Noria] ( Closes #4008 )
2010-02-25 08:32:37 -08:00
David Heinemeier Hansson
a524d42acc
Merge branch 'master' of github.com:rails/rails
2010-02-25 08:31:49 -08:00
Santiago Pastorino
f76eaa4b7c
add time_separator for minutes only if minutes aren't hidden
...
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2010-02-25 08:31:02 -08:00
Santiago Pastorino
529d0f5812
add time_separator for minutes only if minutes aren't hidden
...
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2010-02-24 18:40:44 -08:00
José Valim
df85ab41c1
Renamed LocalizedCache to DetailsCache.
2010-02-24 22:17:26 +01:00
José Valim
9d7d6cd7ba
Use render instead render_to_body.
2010-02-24 22:17:25 +01:00
José Valim
a39c7505bd
Cleanup render callstack and make render(:json => {}, :status => 401) work again.
2010-02-24 22:17:25 +01:00
Carl Lerche
6a061187e2
Remove ActionController::Base.resources_path_names
2010-02-24 10:52:16 -08:00
Carl Lerche
ba57575e03
Remove references to ActionDispatch::Routing::Routes in favor of Rails.appication.routes.
2010-02-24 10:52:16 -08:00
José Valim
60ca754b97
Remove the renderer option from the hash.
2010-02-24 15:45:33 +01:00
Yehuda Katz
ae933a093d
Fix render :file => "#{Rails.root}/public/404.html", :status => :not_found. Closes #8994
2010-02-23 22:45:42 -08:00
Carlhuda
47498a7f59
Woops, forgot to actually add active_support/core_ext/file/path.rb
2010-02-23 17:42:26 -08:00
Carlhuda
24ab5665b2
Revert "Fix test load paths for those not using bundler"
...
This reverts commit eec2d301d4 .
This commit broke tests. You cannot have a file called "bundler" on the load path.
2010-02-23 17:31:17 -08:00
Carlhuda
5e2bd08023
Makes send_file work again by deferring to Rack::Sendfile.
...
* Add the Rack::Sendfile middleware
* Make the header to use configurable via config.action_dispatch.x_sendfile_header (default to "X-Sendfile").
* Add Railties tests to confirm that these work
* Remove the :stream, :buffer_size, and :x_senfile default options to send_file
* Change the log subscriber to always say "Sent file"
* Add deprecation warnings for options that are now no-ops
Note that servers can configure this by setting X-Sendfile-Type. Hosting companies and those creating packages of servers specially designed for Rails applications are encouraged to specify this header so that this can work transparently.
2010-02-23 17:06:35 -08:00
Xavier Noria
47683b7d0e
caching guide: fixes a typo, thanks to Jonathan Bryan
2010-02-24 01:34:04 +01:00
Carlhuda
a73f682e43
Make AD::Response correctly handle bodies that respond_to?(:to_path) as per the Rack spec
2010-02-23 16:29:29 -08:00
Xavier Noria
cadd5937fe
plugins guide: rewords a paragraph and revises some typography
2010-02-24 00:56:51 +01:00
Carlhuda
3345af61fb
Fix streaming by having it create a File object, which can be handled by Rack servers as appropriate
2010-02-23 15:37:17 -08:00
Santiago Pastorino
ee541049fd
avoid @lock_value not initialized warning
2010-02-22 14:08:07 -08:00
Santiago Pastorino
2b43021499
avoid @transaction_joinable not initialized warning
2010-02-22 14:07:53 -08:00
Santiago Pastorino
ca92e92ba1
avoid active not initialized warning
2010-02-22 14:07:44 -08:00
José Valim
35e0975af8
Rename erubis_implementation to erb_implementation.
2010-02-22 13:58:29 +01:00
José Valim
d92e855492
Include missing modules.
2010-02-22 13:13:26 +01:00
Mikel Lindsaar
cefc136ec3
Adding options to register observers and interceptors through ActionMailer::Base.register_observer and ActionMailer::Base.register_interceptor. These hook into Mail.register_interceptor and Mail.register_observer. Also bumped Mail requirement to 2.1.3
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-02-22 09:15:48 +01:00
David Chelimsky
a6684eeb78
don't set @expected.date in generated mailer test
...
Signed-off-by: Mikel Lindsaar <raasdnil@gmail.com >
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-02-22 09:15:27 +01:00
José Valim
6fa2bbfd10
Fix AMo isolated tests.
2010-02-22 08:45:41 +01:00
Martin Schürrer
6bc24d40d5
Use ActionDispatch::Routing everywhere
2010-02-21 13:43:51 -08:00
Martin Schürrer
4cdfe98d92
Typo
2010-02-21 13:43:51 -08:00
José Valim
a7b78e86b3
Add a tests which ensures filtered_parameters does not raise an error for a mixed array [ #3928 status:resolved]
2010-02-21 14:40:48 +01:00
José Valim
55ae903c3f
Store compiled parameter filters so we don't have to compile them in each request.
2010-02-21 14:29:40 +01:00
José Valim
87a011df6f
Make install appear on rake -T.
2010-02-21 14:18:40 +01:00
José Valim
4477bccda6
Also check if application is a valid constant in rake rails:update.
2010-02-21 13:44:08 +01:00
José Valim
7fe4ca3253
Add a test for default_url_options in AM.
2010-02-21 13:19:21 +01:00
Prem Sichanugrist
8f97e9d19a
Add validators reflection so you can do 'Person.validators' and 'Person.validators_on(:name)'.
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-02-21 12:37:46 +01:00
José Valim
250c809246
Require persisted? in ActiveModel::Lint and remove new_record? and destroyed? methods. ActionPack does not care if the resource is new or if it was destroyed, it cares only if it's persisted somewhere or not.
2010-02-21 11:12:14 +01:00
José Valim
9dd67fce25
Add to_key and to_param methods to ActiveModel::Conversion.
2010-02-21 09:08:59 +01:00
snusnu
f81c6bc040
AMo #key is now #to_key and CI is probably happy
...
Obviously #key is a too common name to be included
in the AMo interface, #to_key fits better and also
relates nicely to #to_param. Thx wycats, koz and
josevalim for the suggestion.
AR's #to_key implementation now takes customized
primary keys into account and there's a testcase
for that too.
The #to_param AMo lint makes no assumptions on how
the method behaves in the presence of composite
primary keys. It leaves the decision wether to
provide a default, or to raise and thus signal to
the user that implementing this method will need
his special attention, up to the implementers. All
AMo cares about is that #to_param is implemented
and returns nil in case of a new_record?.
The default CompliantObject used in lint_test
provides a naive default implementation that just
joins all key attributes with '-'.
The #to_key default implementation in lint_test's
CompliantObject now returns [id] instead of [1].
This was previously causing the (wrong) tests I
added for AR's #to_key implementation to pass. The
#to_key tests added with this patch should be
better.
The CI failure was caused by my lack of knowledge
about the test:isolated task. The tests for the
record_identifier code in action_controller are
using fake non AR models and I forgot to stub the
#to_key method over there. This issue didn't come
up when running the test task, only test:isolated
revealed it. This patch fixes that.
All tests pass isolated or not, well, apart from
one previously unpended test in action_controller
that is unrelated to my patch.
2010-02-20 20:17:29 -08:00
José Valim
fed72b5842
Rename engines_load_path to railties_load_path.
2010-02-20 15:46:55 +01:00
snusnu
9acd686753
Adds #key and #to_param to the AMo interface
...
This commit introduces two new methods that every
AMo compliant object must implement. Below are the
default implementations along with the implied
interface contract.
# Returns an Enumerable of all (primary) key
# attributes or nil if new_record? is true
def key
new_record? ? nil : [1]
end
# Returns a string representing the object's key
# suitable for use in URLs, or nil if new_record?
# is true
def to_param
key ? key.first.to_s : nil
end
1) The #key method
Previously rails' record_identifier code, which is
used in the #dom_id helper, relied on calling #id
on the record to provide a reasonable DOM id. Now
with rails3 being all ORM agnostic, it's not safe
anymore to assume that every record ever will have
an #id as its primary key attribute.
Having a #key method available on every AMo object
means that #dom_id can be implemented using
record.to_model.key # instead of
record.id
Using this we're able to take composite primary
keys into account (e.g. available in datamapper)
by implementing #dom_id using a newly added
record_key_for_dom_id(record)
method. The user can overwrite this method to
provide customized versions of the object's key
used in #dom_id.
Also, dealing with more complex keys that can
contain arbitrary strings, means that we need to
make sure that we only provide DOM ids that are
valid according to the spec. For this reason, this
patch sends the key provided through a newly added
sanitize_dom_id(candidate_id)
method, that makes sure we only produce valid HTML
The reason to not just add #dom_id to the AMo
interface was that it feels like providing a DOM
id should not be a model concern. Adding #dom_id
to the AMo interface would force these concern on
the model, while it's better left to be implemented
in a helper.
Now one could say the same is true for #to_param,
and actually I think that it doesn't really fit
into the model either, but it's used in AR and it's
a main part of integrating into the rails router.
This is different from #dom_id which is only used
in view helpers and can be implemented on top of a
semantically more meaningful method like #key.
2) The #to_param method
Since the rails router relies on #to_param to be
present, AR::Base implements it and returns the
id by default, allowing the user to overwrite the
method if desired.
Now with different ORMs integrating into rails,
every ORM railtie needs to implement it's own
#to_param implementation while already providing
code to be AMo compliant. Since the whole point of
AMo compliance seems to be to integrate any ORM
seamlessly into rails, it seems fair that all we
really need to do as another ORM, is to be AMo
compliant. By including #to_param into the official
interface, we can make sure that this code can be
centralized in the various AMo compliance layers,
and not be added separately by every ORM railtie.
3) All specs pass
2010-02-19 23:31:25 -08:00
Carlhuda
a3c6ad7d5e
Fix a bunch of pending tests by providing an introspection mode for the Response object that does up-front parsing of the headers to populate things like @etag
2010-02-19 19:19:20 -08:00
Yehuda Katz
bf8898b49b
Revert "i18n translate with arrays issue solved"
...
This reverts commit e7055e5b08 .
2010-02-19 15:05:46 -08:00
Santiago Pastorino
e7055e5b08
i18n translate with arrays issue solved
2010-02-19 13:59:15 -08:00
Santiago Pastorino
e4b910f6a3
require publicize_conversion_method to ensure to_date and to_datetime became public before redefining them (avoid warnings)
2010-02-19 13:36:34 -08:00
Dirkjan Bussink
a0a01d0c98
Remove empty line and trailing hash, breaks documentation generation
...
Signed-off-by: Yehuda Katz <yehudakatz@YK.local >
2010-02-19 13:10:01 -08:00
Santiago Pastorino
7ad2c5c06f
warning: instance variable @_const_missing not initialized fixed
2010-02-19 11:35:03 -08:00
Xavier Noria
17596beb89
Revert "AM guide: standarizes call to rails runner"
...
This reverts commit d2844b854b .
2010-02-19 20:30:46 +01:00
Xavier Noria
4bd37dadc4
getting started guide: script/generate -> rails generate
2010-02-19 20:27:24 +01:00
Xavier Noria
d2844b854b
AM guide: standarizes call to rails runner
2010-02-19 20:22:20 +01:00
Yehuda Katz
2f821a0a98
Fix test ordering bug related to introducing masked Name class
2010-02-19 10:31:51 -08:00
Yehuda Katz
2f98032fc9
Fix a problem where nil was appearing in the list
2010-02-19 10:12:04 -08:00
Joshua Peek
7d7f9ccfdf
Reinstate pending tests that were supposed to be fixed before the
...
beta.
Shout louder this time so they actually get fixed.
2010-02-19 09:34:22 -06:00
José Valim
be35a1510d
Allow to choose the template path and template name used in implicit rendering with ActionMailer.
2010-02-19 10:51:17 +01:00
José Valim
e49f94d71c
Revert behavior from a5684dfa3c and ensure after_initializer is executed after to_prepare callbacks.
2010-02-19 08:15:49 +01:00
Santiago Pastorino
e2806929ec
ruby 1.9 array.to_s returns a string representing an escaped array
...
Signed-off-by: Yehuda Katz <yehudakatz@YK.local >
2010-02-18 17:11:32 -08:00
Yehuda Katz
e6ce856462
Git fail
2010-02-18 16:48:28 -08:00
Santiago Pastorino
af05420d6b
i18n translate with arrays issue solved
...
Signed-off-by: Yehuda Katz <yehudakatz@YK.local >
2010-02-18 16:41:00 -08:00
Carl Lerche
ae8c384e2c
Avoid calling triggering const_missing if const_missing is private when doing constantize
2010-02-18 16:29:32 -08:00
Yehuda Katz
98c299fba5
Don't constantize possible module names when looking for new constants unless they exist
2010-02-18 14:04:26 -08:00
Yehuda Katz
8a1f057a26
Update Renderer
2010-02-18 14:04:26 -08:00
Jeremy Kemper
cc852e2580
Use FileUtils.mv instead of rename to copy in case of cross-device links
2010-02-18 10:48:01 -08:00
José Valim
a5684dfa3c
Ensure config.after_initializer is executed before building the middleware stack.
2010-02-18 18:56:11 +01:00
Aaron
1477a6101d
Fix called_from under Windows so engines works properly
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-02-18 18:36:55 +01:00
Xavier Noria
217ffcb508
edge badge revised by Jose Espinal
2010-02-17 21:08:31 +01:00
Xavier Noria
f3eab8e663
adds support for an edge badge in guides
2010-02-17 20:22:37 +01:00
José Valim
7189e3c881
Rename router internal option :namespace to :controller_namespace which is its real purpose.
2010-02-17 18:43:42 +01:00
José Valim
d0454e5766
Add readme as method in Rails::Generators::Actions (as we had in 2.3)
2010-02-17 18:43:40 +01:00
Carl Lerche
e195b48f21
Have CI use the current version of bundler
2010-02-16 17:15:56 -08:00
José Valim
3f948a0e29
Merge master.
2010-02-17 00:48:04 +01:00
Kyle Maxwell
d4e008fd0f
Invalid namespace on app generation raises an error
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-02-17 00:38:30 +01:00
José Valim
23fd1f1280
Show deprecation message for rails/init.rb in plugins.
2010-02-17 00:18:12 +01:00
José Valim
e8ef12e39d
Make Railties tests green again.
2010-02-17 00:14:49 +01:00
Yehuda Katz
762088a0ef
Clear the attribute after done
2010-02-16 15:00:10 -08:00
José Valim
b1edd09662
Ensure render :text => resource first tries to invoke :to_text on it
2010-02-16 23:26:29 +01:00
José Valim
47a236e291
AD::TestProcess relies on request.flash, so let's load it.
2010-02-16 22:54:56 +01:00
José Valim
19787e6259
Should allow symbols in :only and :except in routes.
2010-02-16 22:39:08 +01:00
José Valim
72cb0bf414
Do not swallow controller loading errors unless required.
2010-02-16 22:39:07 +01:00
José Valim
01cd9d66ed
Subscriber should not explode if a non namespaced instrumentation is given.
2010-02-16 22:39:07 +01:00
Prem Sichanugrist
f0523f72b4
Rename Rails::Subscriber to Rails::LogSubscriber
2010-02-16 22:36:15 +01:00
Yehuda Katz
ac956c4aee
Update AP to start locking down a public API. This work is parallel to some docs I'm working on.
2010-02-16 10:45:59 -08:00
Xavier Noria
b6935e5179
and now even with proper markup
2010-02-15 23:56:29 +01:00
Xavier Noria
a077e4128d
testing cron job in edge api generation
2010-02-15 23:50:36 +01:00
Xavier Noria
2b323b4d03
adds rdoc dependency to generate the API
...
Signed-off-by: Yehuda Katz <yehudakatz@YK.local >
2010-02-15 10:53:41 -08:00
Joshua Peek
3cecc44cb9
rack-mount 0.5 support
2010-02-15 11:16:56 -06:00
Joshua Peek
546e319a5f
CI has a bunch of duplicate load paths
2010-02-15 10:53:44 -06:00
Joshua Peek
4419497e40
Make sure AS test env doesn't have duplicate libs in load path
2010-02-15 10:38:39 -06:00
Joshua Peek
eec2d301d4
Fix test load paths for those not using bundler
2010-02-15 10:20:11 -06:00
Xavier Noria
7cff54f5d3
name.blank? -> anonymous?
...
Signed-off-by: Yehuda Katz <yehudakatz@YK.local >
2010-02-14 13:09:39 -08:00
Yehuda Katz
38eb2f1454
Right.
2010-02-14 12:13:37 -08:00
Santiago Pastorino and José Ignacio Costa
98a5bf8ff2
Explicit html_escape removed when not needed
...
Signed-off-by: Yehuda Katz <yehudakatz@YK.local >
2010-02-14 12:03:39 -08:00
Santiago Pastorino and José Ignacio Costa
9f1900ec7a
html_escape mail_to when encode javascript and not hex
...
Signed-off-by: Yehuda Katz <yehudakatz@YK.local >
2010-02-14 12:03:28 -08:00
Bruno Michel
f86421fb28
content_tag should escape its input
...
Signed-off-by: Yehuda Katz <yehudakatz@YK.local >
2010-02-14 12:03:28 -08:00
Yehuda Katz
411c15ed52
require Strings, not Symbols
2010-02-14 11:56:21 -08:00
Yehuda Katz
8e4363de72
Save off Module's const_missing, not Class'
2010-02-14 11:35:05 -08:00
Pratik Naik
6f3c5f6787
Merge remote branch 'mainstream/master'
...
Conflicts:
railties/README
railties/guides/source/active_support_core_extensions.textile
railties/guides/source/getting_started.textile
railties/lib/generators/rails/app/templates/README
2010-02-14 19:28:05 +00:00
Yehuda Katz
a1b60696e2
Missing require
2010-02-14 11:18:34 -08:00
Xavier Noria
b68f5f77e3
name.blank? -> anonymous? in a few places
...
Signed-off-by: Yehuda Katz <yehudakatz@YK.local >
2010-02-14 11:09:22 -08:00
Xavier Noria
f7db067b12
adds a few missing requires in AS object.rb and module.rb
...
Signed-off-by: Yehuda Katz <yehudakatz@YK.local >
2010-02-14 11:07:29 -08:00
Yehuda Katz
4da45060a2
Simplify dependencies.rb some. Remove alias of Kernel::Foo to Object::Foo as it was not used and breaks Ruby semantics.
2010-02-14 10:48:06 -08:00
David Heinemeier Hansson
d68f8ba5c3
simple_format returns a safe buffer escaping unsafe input [Santiago Pastorino]
2010-02-12 17:24:04 -08:00
David Heinemeier Hansson
325fa58ef5
Safely concat the ending tag to simple_format or it will be escaped
2010-02-12 16:38:24 -08:00
Pratik Naik
dc3cc6c608
Move batch finders to Relation
2010-02-12 22:31:03 +00:00
Xavier Noria
77bf78b3b7
AS guide: documents Module#anonymous?
2010-02-12 20:52:00 +01:00
Xavier Noria
50b2a5d8ca
AS guide: documents Module#reachable?
2010-02-12 19:06:07 +01:00
Jeremy Kemper
5188c11d2e
Revert to rack-mount 0.4.7
2010-02-12 09:05:41 -08:00
Jeremy Kemper
7b663e2feb
CI: blow away bundle path between runs to solve 1.8/1.9 binary incompat
2010-02-11 17:43:46 -08:00
Jeremy Kemper
3d3e08623f
Force 0.4.7 for 3.0.0.beta. Bump to ~> 0.5.0 for beta1.
2010-02-11 17:31:50 -08:00
Jeremy Kemper
86a696fc30
Wups, rack-mount 0.5.0
2010-02-11 17:29:14 -08:00
Jeremy Kemper
9b14b13422
Bump rack-mount dep to 0.5.3
2010-02-11 17:26:45 -08:00
Jeremy Kemper
2b874f8e81
Merge remote branch 'fxn/master'
2010-02-11 15:08:01 -08:00
Xavier Noria
a506bac586
fixes Module#anonymous? for 1.9
2010-02-11 23:58:15 +01:00
Xavier Noria
aa82bdf929
moves Class#reachable? to Module#reachable?, bases implementation on anonymous? and constantize, and adds test coverage
2010-02-11 23:41:16 +01:00
Xavier Noria
b8bb54af7f
defines Module#anonymous?
2010-02-11 23:15:04 +01:00
Carl Lerche
eea28b07cf
Remove backtrace cleaner specific to Bundler. Bundler just uses Gem.dir and Gem.path now.
2010-02-11 10:29:50 -08:00
Jeremy Kemper
2a2d1872e4
CI: use minitest on 1.9 again.
2010-02-11 09:07:19 -08:00
Jeremy Kemper
8afcd33246
Resolve test/unit load ordering by removing backtrace filter from boot initializers
2010-02-11 09:01:52 -08:00
Jeremy Kemper
523002fe16
Fix isolated test fail due to missing mocha
2010-02-10 16:45:43 -08:00
Xavier Noria
739b8a1638
AS guide: fixes a typo
2010-02-11 00:22:13 +01:00
Xavier Noria
72c83893a5
AS guide: documents Class#subclasses
2010-02-11 00:20:37 +01:00
Yehuda Katz
77f630d317
Since require_dependency cannot be cleared, remove the dependencies
2010-02-10 15:06:42 -08:00
Xavier Noria
6a395c68d2
AS guide: documents Object#subclasses_of
2010-02-11 00:03:55 +01:00
Yehuda Katz
a3eaaf6b50
Fix a JSON ordering issue
2010-02-10 14:46:16 -08:00
Yehuda Katz
ff7db40464
No need to emulate default Ruby behavior in initialize
2010-02-10 14:40:36 -08:00
Yehuda Katz
bea38d64ee
Don't rely on @message in Error classes being available for use
2010-02-10 14:40:36 -08:00
Xavier Noria
9fd9e5d4f7
fixes doc generation
...
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2010-02-10 14:37:56 -08:00
Xavier Noria
783ce11708
release notes: the following methods have resurrected: Class#reachable?, Object#subclasses_of, Class#subclasses, Class.subclasses_of
2010-02-10 10:03:41 +01:00
José Valim
97650bf54a
Fix a couple failing tests.
2010-02-10 08:33:41 +01:00
Michael Bleigh
9c654744fb
Fixes unescaped version passthrough of generator 'gem' command. [ #3901 status:resolved]
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-02-10 08:28:03 +01:00
Simo Niemelä
cafe882d12
Fix server environment [ #3877 status:resolved]
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-02-10 08:14:02 +01:00
Prem Sichanugrist
f337ebc308
Add default values to output of 'rails server -h', hardcoded as Rack::Server did since options doesn't have any data at the time of parsing arguments [ #3910 status:resolved]
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-02-10 08:08:27 +01:00
Prem Sichanugrist
af22c5b16a
Add missing -h/--help flag to several rails command [ #3909 status:resolved]
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-02-10 08:08:16 +01:00
Mikel Lindsaar
7d76474e5d
Debrittlize tests somewhat - fix for CI build
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-02-10 07:26:01 +01:00
Jeremy Kemper
f84b4b4e5f
Reinstate object/extending require too for Object.subclasses_of
2010-02-09 19:42:08 -08:00
Jeremy Kemper
d1938953f4
Reinstate Object.subclasses_of and Class#descendents for plugin compat.
...
This reverts commits 7d312e54ba , 5f981ff029 , f85f5dfc8f , 245bfafe33 , and ec7c642f5f
2010-02-09 18:20:57 -08:00
David Heinemeier Hansson
fa2ff95d4b
Its not a deprecation if you actually just ignore the call
2010-02-09 17:23:48 -08:00
David Heinemeier Hansson
834a45d8a2
Suggest Mongrel and Capistrano in the default bundle
2010-02-09 17:12:37 -08:00
Jeremy Kemper
39ebd6eb2b
rails runner loads environment after parsing command-line options
2010-02-09 08:40:21 -08:00
José Valim
ea8f9880c4
Remove outdated docs.
2010-02-09 08:38:33 -07:00
Mikel Lindsaar
79f02a473c
Altering the warnings
2010-02-09 13:31:51 +11:00
Yehuda Katz
6f247347a1
Fix failing spec
2010-02-08 12:39:06 -08:00
Jeremy Kemper
ad98f21c21
Merge remote branch 'fxn/master'
2010-02-08 11:37:56 -08:00
José Valim
7f7dfd2bab
Take into account gem versions (so script/rails server can work outside the application) and use Rails::Application.root instead of ROOT_PATH.
2010-02-08 16:05:22 +01:00
Daniel Schierbeck
50b3040115
Remove commas
2010-02-08 13:46:27 +01:00
Ryan Bigg
6e8356147d
Use mkdir_p so that the output directory is always created.
2010-02-08 21:18:48 +10:00
Xavier Noria
2928040e23
simplify a couple of regexps
2010-02-08 09:42:50 +01:00
Mikel Lindsaar
17b451898c
Updating Prototype to 1.6.1 and script.aculo.us to 1.8.3
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-02-08 09:42:40 +01:00
Mikel Lindsaar
5fe3dc4bf5
Adding ruby version spec to all gemspec files to at least 1.8.7
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-02-08 09:42:12 +01:00
Xavier Noria
6a6644742f
getting started guide: move link to Instant Rails to the first occurrence
2010-02-08 09:40:37 +01:00
Xavier Noria
8b4db93ca3
guides textile extensions: now recognizes also TIP.
2010-02-08 09:39:01 +01:00
Mikel Lindsaar
de0753d2ae
Editing the railties/../railtie.rb and engine.rb docs
2010-02-08 15:08:10 +11:00
Mikel Lindsaar
b9e5263625
First pass at full re-write of getting started guide
...
* Changed to Rails 3.0.0-beta rails command from script/*
* Changed contrived before_filter to be an authentication feature
* Refactored code into partials, showed three different types of partial usage
* Showed how helpers work and fit in
2010-02-08 14:15:34 +11:00
Xavier Noria
cf9a52a7b6
removes Module#as_load_path, which is no longer used
2010-02-07 23:06:15 +01:00
Xavier Noria
afd2e19be3
removes Module#included_in_classes, which is no longer used
2010-02-07 23:03:13 +01:00
Xavier Noria
d91ac89ab8
AS guide: specifies that renaming a file is atomic on POSIX systems
2010-02-07 22:01:54 +01:00
Gabriel Mansour
b235af702a
Fix pluralization for numbers formatted like '1.00'
...
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2010-02-07 12:12:09 -08:00
Jeremy Kemper
a1a6e54d14
Fix doc typo and update fast_xs URL. Thanks to Dmitrii Golub.
2010-02-07 11:42:24 -08:00
José Valim
518b4ff478
Check if Test::Unit is defined before adding backtrace filter.
2010-02-07 14:51:23 +01:00
RomD
d6ae930c9c
fix ambiguous example for new invocation method
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-02-07 13:46:27 +01:00
José Valim
345e0b274c
Add backtrace cleaner on test unit railtie.
2010-02-07 13:45:47 +01:00
José Valim
de69c798db
Fix nested attributes with specified collection.
2010-02-07 13:45:47 +01:00
Xavier Noria
81e779a019
AS guide: documents Module#synchronize
2010-02-07 11:22:44 +01:00
Dan Kubb
ca1879b730
Added newline to appended gem config in Gemfile
...
Signed-off-by: Yehuda Katz <yehudakatz@YK.local >
2010-02-06 23:38:58 -08:00
Mikel Lindsaar
bb55bbd207
Fixing actionmailer tests for CI
2010-02-06 23:36:03 -08:00
Nick Quaranto
b3e43a6462
Adding link to the rails module article
2010-02-07 01:01:27 -05:00
Chad Woolley
a4c3289758
remove all sudo references from CI build script
...
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2010-02-06 21:40:22 -08:00
Jeremy Kemper
03b192d1b4
CI: sudo unnecessary. Bump bundler dep to 0.9.3.
2010-02-06 21:18:08 -08:00
Jeremy Kemper
9f3ea4505a
CI: set env after sudo
2010-02-06 21:14:29 -08:00
Xavier Noria
f465a7abc7
AS guide: documents Module#local_constants and Module#local_constant_names
2010-02-07 00:20:46 +01:00
Xavier Noria
81535d0fd2
removes p calls in rdoc examples
2010-02-06 23:55:33 +01:00
Xavier Noria
f3e41e0948
AS guide: documents methods related to a module's parent(s)
2010-02-06 23:54:25 +01:00
David Heinemeier Hansson
5995482be9
Merge branch 'master' of github.com:rails/rails
2010-02-06 13:31:22 -08:00
Xavier Noria
e4945b1593
release notes: Kernel#daemonize is gone after 299ab1f
2010-02-06 22:30:52 +01:00
Xavier Noria
55bb27adc4
AS guides: documents Module#delegate
2010-02-06 22:24:38 +01:00
David Heinemeier Hansson
28fe0c330a
Silenced "SHOW FIELDS" and "SET SQL_AUTO_IS_NULL=0" statements from the MySQL driver to improve log signal to noise ration in development [DHH]
2010-02-06 13:20:47 -08:00
Jeremy Kemper
9423c2a7d8
Merge remote branch 'fxn/master'
2010-02-06 13:03:41 -08:00
Xavier Noria
bb81837201
reformats an example in the rdoc of delegate
2010-02-06 21:12:53 +01:00
RomD
3caca406c8
remove trailing whitespace
...
Signed-off-by: Carl Lerche <carllerche@mac.com >
2010-02-06 09:51:53 -08:00
RomD
f44a0b1d52
fix usage examples and more to use new invocations
...
Signed-off-by: Carl Lerche <carllerche@mac.com >
2010-02-06 09:51:53 -08:00
Xavier Noria
bd5cb0562e
rack debugger needs active_support/core_ext/kernel/requires for require_library_or_gem
2010-02-06 18:35:44 +01:00
Xavier Noria
299ab1faa1
removes Kernel#daemonize, which is no longer used
2010-02-06 18:33:09 +01:00
Xavier Noria
b712d80085
AS guide: documents module attributes
2010-02-06 18:17:08 +01:00
Xavier Noria
466948e64b
AS guide: documents internal attributes
2010-02-06 17:57:50 +01:00
José Valim
6958eac1a0
Add config.generators.templates to provide alternative paths for template lookup.
2010-02-06 17:32:06 +01:00
Xavier Noria
18f6d5332f
AS guide: documents Module#attr_accessor_with_default
2010-02-06 17:20:24 +01:00
Xavier Noria
8e72fd916e
revises an example in the rdoc of TextHelper#concat
2010-02-06 16:17:03 +01:00
Xavier Noria
dcfc3b3733
AS guide: documents where output safety is defined
2010-02-06 16:15:10 +01:00
Xavier Noria
7cb459eb60
AS guide: documents Kernel#require_library_or_gem
2010-02-06 16:11:21 +01:00
Prem Sichanugrist
1d9d9d2d89
Fix tiny version number from '3.0.0beta' to '3.0.0.beta1', so 'rake install' will be run correctly [ #3879 status:resolved]
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-02-06 15:51:44 +01:00
Henrik N
95b63c6a07
Fix 'rails server -h' double help banner. Correct its usage line. [ #3874 status:resolved]
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-02-06 13:03:52 +01:00
José Valim
22c0390085
Add a test which ensures namespaced roots.
2010-02-06 11:52:28 +01:00
José Valim
4d177d46d9
Routes should not swallow all NameErrors [ #3862 status:resolved].
2010-02-06 11:39:51 +01:00
Henrik N
e3a95cb0e9
Change "script/server" to "rails server" in README.
...
Also console, dbconsole, generate.
2010-02-06 11:02:53 +01:00
Yehuda Katz
5384df5589
Updates subscriber test for new output
2010-02-05 22:48:13 -08:00
Yehuda Katz
b392c81869
Fixes test fail
2010-02-05 21:30:26 -08:00
Mike Naberezny
f1b9b31898
Changed "before you it arrived" to "before it arrived"
2010-02-05 20:28:23 -08:00
David Heinemeier Hansson
59d8a2b4f5
Lookup the status code and rework the Completed line a bit
2010-02-05 19:01:11 -08:00
Bryan Helmkamp
badcd0ba7b
Link to primary Arel repository
2010-02-05 21:47:56 -05:00
David Heinemeier Hansson
c76df7a2d5
Cleanup comments
2010-02-05 18:45:26 -08:00
David Heinemeier Hansson
33a90f5079
Not a fan of the double ##
2010-02-05 18:41:46 -08:00
David Heinemeier Hansson
cbb0b2f6f3
Simplify conditions for --dev and --edge
2010-02-05 18:41:15 -08:00
David Heinemeier Hansson
0ce9c80c0a
Path approach shouldnt specify version
2010-02-05 18:35:19 -08:00
David Heinemeier Hansson
6201abe73f
New style for path references
2010-02-05 18:33:24 -08:00
Jeremy Kemper
47db62bf8d
CI: show bundled gems
2010-02-05 16:18:26 -08:00
Jeremy Kemper
86df107eff
CI: add missing isolated tests
2010-02-05 16:17:06 -08:00
Santiago Pastorino
a9620ab918
method_missing errors on activeresource tests, mocha is not required there
...
[#3825 state:committed]
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2010-02-05 16:08:33 -08:00
Santiago Pastorino
44c46558a4
test_validates_acceptance_of_as_database_column fixed
...
[#3826 state:committed]
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2010-02-05 16:08:08 -08:00
Matt Duncan
42551d34f9
Fixing usages of "it's" when referring to the possessive form of "it"
2010-02-05 19:02:53 -05:00
Matt Duncan
7e26809d09
Fix spelling in release notes
2010-02-05 18:46:37 -05:00
Mikel Lindsaar
2fb4bc31e2
Merge branch 'master' of github.com:lifo/docrails
2010-02-06 10:06:31 +11:00
Mikel Lindsaar
d1faa408e5
Left off the map variable, spotted by Johan Andersson
2010-02-06 10:05:44 +11:00
Santiago Pastorino and José Ignacio Costa
e115eb097e
More html_safe strings now use the safe_concat method
...
[#3856 state:committed]
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2010-02-05 13:28:43 -08:00
Santiago Pastorino
c65f4b1ffb
Making SafeBuffer << an alias for concat method
...
[#3848 state:committed]
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2010-02-05 13:26:29 -08:00
Santiago Pastorino and José Ignacio Costa
293c53ab3e
Fixed html_safe test cases which weren't testing correctly
...
[#3845 state:committed]
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2010-02-05 13:25:51 -08:00
Jeremy Kemper
fd567785f4
Make UrlWriter includable in a Module
2010-02-05 12:23:22 -08:00
Xavier Noria
8668bfc787
the infamuous typo that escapes a thousand passes and it is only spotted in github colored diff
2010-02-05 21:06:31 +01:00
Xavier Noria
50901defde
AS guide: first version of a section on output safety, trying to give some context, but trying to go not too far away from the topic of the guide which is AS-only
2010-02-05 21:01:14 +01:00
Jeremy Kemper
63bb955a99
Automatically prefer Yajl or JSON backend over Yaml, if available
2010-02-05 10:22:45 -08:00
Brian Lopez
a96bf4ab5e
Add yajl-ruby as a JSON parsing backend
...
[#2666 state:committed]
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2010-02-05 10:15:51 -08:00
Jeremy Kemper
c548e21365
Bump git versions to 3.0.0.beta1 since we've released
2010-02-05 09:24:12 -08:00
Jeremy Kemper
a81a2a29ab
Bump arel dep
2010-02-05 09:21:45 -08:00
Jeremy Kemper
f1e5642fb7
Revert "Link to main Arel repository"
...
This reverts commit 2036268679 .
2010-02-05 09:12:35 -08:00
James Miller
4f43c3c3ed
Correct command for installing/running bundler
2010-02-05 09:03:23 -08:00
Xavier Noria
6b540cef95
final touch
2010-02-05 10:43:12 +01:00
Xavier Noria
4a256922f4
release notes: quick copy-editing pass to the section about Action Mailer
2010-02-05 10:35:20 +01:00
Xavier Noria
8b38137b0d
release notes: put removals to Regexp in the same list item, grouped as the rest
2010-02-05 10:24:40 +01:00
Xavier Noria
2388753ba7
release notes: adds a missing period
2010-02-05 10:23:16 +01:00
Paul Rosania
363a752c36
install ActionController::UrlFor before environment is parsed, to provide ActionMailer#default_url_options=
...
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2010-02-05 00:08:56 -08:00
Jeremy Kemper
459ecaf95d
Submarine the rake-gemcutter dep in Rakefiles
2010-02-05 00:03:03 -08:00
Jeremy Kemper
ae4cb0641e
Add the dummy rails3b gemspec that pulls in non-prerelease deps
2010-02-04 23:53:10 -08:00
Anuj Dutta
b1af06ecac
Added rack and i18n to the list of dependencies
2010-02-05 10:49:32 +05:30
Mikel Lindsaar
436532b3ce
Added note on pre-release install
2010-02-05 14:44:12 +11:00
Jeremy Kemper
b1f30ef048
Kill default require_path
2010-02-04 19:13:07 -08:00
Jeremy Kemper
7b81f5981f
Fix task defines
2010-02-04 18:44:32 -08:00
Jeremy Kemper
ed6e72a84f
No sense bundling sense it's not available in Rakefile. Also, actually require.
2010-02-04 18:44:32 -08:00
David Heinemeier Hansson
657ffed3f5
Need gemcutter here too
2010-02-04 18:39:19 -08:00
Jeremy Kemper
c1785f3282
Release using gemcutter gem:push tasks
2010-02-04 18:28:45 -08:00
Jeremy Kemper
31f8a59c16
Test that csrf meta content is html-escaped, too
2010-02-04 18:03:06 -08:00
Jeremy Kemper
7b1d3a0ca3
Add prototype ujs handler for data-method
2010-02-04 18:01:08 -08:00
Jeremy Kemper
6bf79f02be
Revert dumb test
2010-02-04 17:49:23 -08:00
Jeremy Kemper
358968cd28
Update prototype-ujs for data-confirm
2010-02-04 17:46:29 -08:00
Jeremy Kemper
3062bc70ef
HTML-escape csrf meta contents
2010-02-04 17:45:43 -08:00
Jeremy Kemper
2191aa47ac
Expose CSRF param name also
2010-02-04 15:26:24 -08:00
Chad Woolley
09a88a347d
fix rubygems/bundler install in ci build script
...
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2010-02-04 14:59:04 -08:00
Jeremy Kemper
78de17cf70
Expose CSRF tag for UJS adapters
2010-02-04 14:58:32 -08:00
Jeremy Kemper
127e53453d
Ensure javascripts are pulled in so UJS can hook the Delete link
2010-02-04 12:22:26 -08:00
Bryan Helmkamp
2036268679
Link to main Arel repository
...
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2010-02-04 12:01:25 -08:00
Jeremy Kemper
c697974fad
Bump to bundler 0.9.2
2010-02-04 11:36:57 -08:00
James Miller
89be425bc9
include should be includes
2010-02-04 11:11:59 -08:00
Jeremy Kemper
a74ed0c2ee
Autorequire default libs and those in groups named after the current Rails environment
2010-02-04 11:04:50 -08:00
Jeremy Kemper
a871b1a4d2
Depend on bundler >= 0.9.1
2010-02-04 10:56:16 -08:00
Jeremy Kemper
293fd9daf8
server command loads the application
2010-02-04 10:50:14 -08:00
Jeremy Kemper
ca273d171c
Revert "Rails script commands load the application rather than just boot"
...
This reverts commit 358451c219 .
2010-02-04 10:49:41 -08:00
Jeremy Kemper
358451c219
Rails script commands load the application rather than just boot
2010-02-04 10:45:35 -08:00
Jeremy Kemper
6154278d22
Fix broken autorequires
2010-02-04 10:08:06 -08:00
Jeremy Kemper
2faf94a7af
Use the correct environment.rb path
2010-02-04 10:08:06 -08:00
Jeremy Kemper
23ad1eff0d
Rationalize railtie dependencies: AC uses AV; AR uses AMo; and Rails always uses AS.
2010-02-04 10:08:06 -08:00
Jeremy Kemper
5c07c33ab4
Move framework requires and Bundler.require from boot.rb to app.rb. Cut down the list of railtie choices to those that make sense.
2010-02-04 10:08:06 -08:00
Antonio Cangiano
6b3fb38461
Updated the database.yml file generated for ibm_db to the latest version of DB2 and the gem.
...
[#3852 state:committed]
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2010-02-04 10:08:06 -08:00
Pratik Naik
25b6b95459
Make RAILS_* give deprecation warning just once
2010-02-04 17:00:50 +00:00
Xavier Noria
b838a5c92b
typography detail in release notes
2010-02-04 16:30:18 +01:00
Pratik Naik
66f501e9a2
Add rails --dev to release notes
2010-02-04 13:36:57 +00:00
Pratik Naik
8260f0b40f
Merge remote branch 'mainstream/master'
...
Conflicts:
railties/guides/source/3_0_release_notes.textile
2010-02-04 13:14:44 +00:00
José Valim
06860dcf29
Remove duplicated version check.
2010-02-04 14:14:11 +01:00
Santiago Pastorino and José Ignacio Costa
6d6e6105c0
require 'action_controller' added on a test that uses it
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-02-04 14:07:24 +01:00
José Valim
d0f98420ea
Automatically require rubygems when --dev flag is given.
2010-02-04 14:05:13 +01:00
slainer68
6241d4e553
Updates bundler information : Yahuda's blog post is now too old...
2010-02-04 13:57:32 +01:00
José Valim
79376e3c9d
Update Gemfile to use latest bundler config.
2010-02-04 13:53:37 +01:00
José Valim
ab14e3f862
Merge branch 'master' of gitproxy:rails/rails
2010-02-04 13:05:27 +01:00
José Valim
31248fe369
Remove instrument! and require thread from AS::Notifications.
2010-02-04 10:39:55 +01:00
Jeremy Kemper
c9ec28b2b6
Use a normal gem source url instead of a magic symbol
2010-02-04 00:21:47 -08:00
Jeremy Kemper
b63643004c
Bump bundler dep to 0.9.1.pre1
2010-02-04 00:19:07 -08:00
Jeremy Kemper
db15e49ddf
Autorequire bundled libraries by default
2010-02-03 23:56:51 -08:00
David Heinemeier Hansson
031139bb71
Homogenize gemspecs and remove the deprecated autorequire
2010-02-03 17:59:49 -08:00
Chad Woolley
e71825d40d
remove arel directory, breaks 'git submodule init', which breaks ci builds
...
Signed-off-by: Yehuda Katz <yehudakatz@Billing-MacBook-Pro.local >
2010-02-03 17:57:49 -08:00
David Heinemeier Hansson
dd13874ff6
Merge
2010-02-03 17:31:35 -08:00
David Heinemeier Hansson
79817aa9e7
Move to 3.0.0.beta
2010-02-03 17:29:51 -08:00
David Heinemeier Hansson
ddb512c02b
Simplify description
2010-02-03 17:27:06 -08:00
David Heinemeier Hansson
36e6daac67
Copy over latest release notes from docrails
2010-02-03 17:22:08 -08:00
David Heinemeier Hansson
17ecb1da87
Tweaks
2010-02-03 17:11:39 -08:00
Jeremy Kemper
9b033d14b2
Merge remote branch 'mikel/master'
2010-02-03 17:03:21 -08:00
SubbaRao Pasupuleti
639e044298
removing , from ,= statement in WrappedDatabaseException constructor
...
[#3830 state:committed]
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2010-02-03 17:02:40 -08:00
Mikel Lindsaar
1ae543a180
-v and --version params now work on rails script in or our of an app
2010-02-04 11:57:13 +11:00
Mikel Lindsaar
02ef8d20a1
Adding guard to make sure test database declarations exist before trying to auto create
2010-02-04 11:57:13 +11:00
Carl Lerche
f497e7ad1d
Update rails to use the latest bundler
2010-02-03 16:56:32 -08:00
Yehuda Katz
77015872be
Removing submodule hacks
2010-02-03 16:28:18 -08:00
David Heinemeier Hansson
c833bd79ec
New prologue with 57% less enterprisey!
2010-02-03 15:59:23 -08:00
Mikel Lindsaar
dac1660ad6
Adding commit diff to the prologue after confirming all clear with GitHub.
2010-02-04 10:48:07 +11:00
James Miller
6697a02ee3
First pass at updating to Rails 3 AR query syntax
2010-02-03 15:27:27 -08:00
Matt Duncan
8c2d245d55
Removing duplicate Rails.config bullet item
2010-02-03 18:16:02 -05:00
Matt Duncan
ae6f856a47
Fix capitalization on note
2010-02-03 18:14:07 -05:00
Xavier Noria
69e693d711
reworded section "script/* replaced by script/rails"
2010-02-03 21:20:54 +01:00
José Valim
efa850558f
Make bin/rails call rails/commands/application, fix generators usage and update .gitignores.
2010-02-03 18:49:47 +01:00
José Valim
391f2543c9
Properly show middlewares on rake about.
2010-02-03 18:07:22 +01:00
José Valim
622e3dda84
No more vendored thor.
2010-02-03 17:57:54 +01:00
José Valim
836cbe5735
Add method and path to AC notifications.
2010-02-03 17:18:18 +01:00
Pratik Naik
69d0e94da5
Some improvements to the release notes
2010-02-03 12:30:35 +00:00
José Valim
b13504303b
Merge remote branch 'mikel/master'
2010-02-03 10:32:27 +01:00
José Valim
2f1657cb6c
Small I18n updates on release notes.
2010-02-03 10:07:26 +01:00
Mikel Lindsaar
f390eade5f
Adding 'db' as a shortcut for dbconsole to the rails command
2010-02-03 19:50:51 +11:00
Mikel Lindsaar
8d48c3b364
Merge branch 'master' of github.com:lifo/docrails
...
Conflicts:
railties/guides/source/3_0_release_notes.textile
2010-02-03 19:18:58 +11:00
Xavier Noria
9c2170c155
Doc Rails -> docrails
2010-02-03 09:17:10 +01:00
Mikel Lindsaar
2efd8dd663
Updating warning at the top
2010-02-03 19:16:25 +11:00
Xavier Noria
927613fb73
Merge branch 'master' of github.com:lifo/docrails
2010-02-03 09:15:32 +01:00
James Miller
54d01ce656
Remove a Rails 2 convention from namespaced routes
2010-02-02 23:34:44 -08:00
Mikel Lindsaar
38d13f9597
Deprecated freeze rake tasks and cleaned up annotations.rake
2010-02-03 18:31:57 +11:00
Mikel Lindsaar
9d65390805
Added encoding qery support for SQLite3 to make rake db:charset work on all databases shipping with Rails 3
2010-02-03 18:06:38 +11:00
Xavier Noria
960490e571
checking guides regeneration, should be out before 9am
2010-02-03 07:43:00 +01:00
Mikel Lindsaar
fbdef7aafe
Made rake db:create also create the test database if you are in development mode
2010-02-03 16:39:04 +11:00
Mikel Lindsaar
80e49354f1
Updating index.html to remove script/generate and making railties tests pass again
2010-02-02 21:13:01 -08:00
Mikel Lindsaar
7ebabb18be
Fixed up i18n info on release notes
2010-02-03 16:10:07 +11:00
Mikel Lindsaar
b215993662
Fixing all the 'script' references
2010-02-03 16:02:17 +11:00
Mikel Lindsaar
76d5428c33
Updating index.html to remove script/generate and making railties tests pass again
2010-02-03 15:52:05 +11:00
Mikel Lindsaar
cc1f693a87
Adding note about not being final and we want contributions
2010-02-03 14:28:20 +11:00
Mikel Lindsaar
a5647c12af
Fixing up the idea of bundle and freezing gems
2010-02-03 14:26:28 +11:00
Mikel Lindsaar
8fac028e0b
Updated release notes
2010-02-03 14:23:06 +11:00
David Heinemeier Hansson
9a83bd5006
Rename usage path to command to just the command name
2010-02-02 16:16:26 -08:00
Xavier Noria
37958f3cc9
mention Object before Class
2010-02-03 01:15:47 +01:00
Xavier Noria
c382ff42c2
ends_with is not a plural
2010-02-03 01:12:02 +01:00
David Heinemeier Hansson
ea59177156
Wups, need the application command in there too
2010-02-02 16:11:40 -08:00
David Heinemeier Hansson
68ca336195
Fix rails server
2010-02-02 16:10:24 -08:00
David Heinemeier Hansson
7840ea29b4
Added "rake about" as a replacement for script/about [DHH]
2010-02-02 16:03:47 -08:00
David Heinemeier Hansson
d53749608e
Add a reminder that you should use "rails" not "script/rails" when running normally
2010-02-02 15:56:16 -08:00
David Heinemeier Hansson
9f224061ee
Boot path has already been required, dont need it again
2010-02-02 15:54:31 -08:00
Carl Lerche
08fd9a6491
Remove the generated gemfile in railties tests since the rails gemfile is used.
2010-02-02 15:51:24 -08:00
David Heinemeier Hansson
d236827881
Removed all the default commands in script/* and replaced them with script/rails and a rails command that'll act the same when run from within the app [DHH]
2010-02-02 15:50:56 -08:00
José Valim
781d0a9bae
Add docs for Railtie, Engine, Plugin and Application.
2010-02-02 20:05:26 +01:00
Carl Lerche
144f41ed9b
Use bundler 0.9.0.pre4 when running CI
2010-02-02 10:19:43 -08:00
Chad Woolley
2c978160d2
Fix invocation of system commands in ci script
...
Signed-off-by: Carl Lerche <carllerche@mac.com >
2010-02-02 10:17:50 -08:00
José Valim
ff2d04a9ec
Revert "failing tests in multibyte_chars_test.rb fixed". The bug is in Ruby 1.9.1 p376, not in AS test suite.
...
This reverts commit bf1f70d877 .
2010-02-02 12:07:41 +01:00
Santiago Pastorino and José Ignacio Costa
afdf52402e
Routing Mapper with % interpolation on Ruby 1.9.1 fixed [ #3837 status:resolved]
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-02-02 11:58:38 +01:00
José Valim
95eadb39bd
Configuration values should be on AV::Base.
2010-02-02 11:32:28 +01:00
José Valim
ec4b18ec78
Get rid of deprecation warnings on config/environments/*
2010-02-02 10:44:09 +01:00
José Valim
101a8fa5f8
Ensure that attr_reader methods in generators are protected.
2010-02-02 10:30:28 +01:00
Szymon Nowak
17bee0dd2f
Change Rails::Generators::Migration protected instance methods to class methods. [ #3820 status:resolved]
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-02-02 10:18:48 +01:00
Prem Sichanugrist
c01014ac1c
Modify the behavior of radio_button_tag to use sanitize_to_id for consistency [ #1792 status:resolved]
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-02-02 10:17:26 +01:00
Prem Sichanugrist
ea2cbc86f7
Add test case for unable to run migration if ActiveRecord::Base.logger is nil ( #3434 )
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-02-02 10:14:51 +01:00
Xavier Noria
12f595b130
this 2nd test should be alive in rails.info sometime before 12pm
2010-02-02 10:13:29 +01:00
Corey Johnson
f4e5303bcf
fixed migration logger bug [ #3434 status:resolved]
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-02-02 10:12:07 +01:00
Kieran Pilkington
f16e2ae9c9
Updating USAGE information for Mailer generator [ #3801 status:resolved]
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-02-02 10:09:41 +01:00
Prem Sichanugrist
ab83800c35
Hide '/rails/info/properties' from 'rake routes' [ #3793 state:resolved]
...
Signed-off-by: Pratik Naik <pratiknaik@gmail.com >
2010-02-02 09:05:22 +00:00
Xavier Noria
19e61ad3af
this test should be alive in rails.info at 9:30
2010-02-02 08:55:03 +01:00
Mikel Lindsaar
12681c2a71
Merge branch 'master' of git://github.com/rails/rails
...
Conflicts:
activemodel/README
activemodel/lib/active_model/errors.rb
activemodel/lib/active_model/serialization.rb
railties/guides/source/3_0_release_notes.textile
2010-02-02 14:04:23 +11:00
Mikel Lindsaar
535ae3b946
Merge branch 'master' of github.com:lifo/docrails
2010-02-02 13:30:08 +11:00
Mikel Lindsaar
49a26c5333
Updating install docs
2010-02-02 13:29:39 +11:00
Sam Ruby
df8852d04d
Make rdoc match current API
...
Signed-off-by: Mikel Lindsaar <raasdnil@gmail.com >
2010-02-02 12:06:50 +11:00
Sam Ruby
5998dd7bb8
Resolve view paths correctly on CygWin
...
Signed-off-by: Mikel Lindsaar <raasdnil@gmail.com >
2010-02-02 12:05:49 +11:00
Mikel Lindsaar
485f12fe4c
Fixed --dev flag for new bundler
2010-02-02 11:24:19 +11:00
Xavier Noria
9b5dae7af5
update html_safe calls in guides generation
2010-02-02 01:04:35 +01:00
Mikel Lindsaar
d1eed079e1
Merge branch 'master' of git://github.com/rails/rails
2010-02-02 10:51:19 +11:00
Carl Lerche
b9edb0c60c
Update the Gemfile and CI build
2010-02-01 15:42:45 -08:00
Pratik Naik
fdcf4d6c51
Merge remote branch 'mainstream/master'
2010-02-01 23:42:38 +00:00
Xavier Noria
27fa38cc3e
AS guide: documents Class#class_attribute
2010-02-02 00:37:33 +01:00
Mikel Lindsaar
7ec7328f2a
Adding in I18n section
2010-02-02 10:36:55 +11:00
Mikel Lindsaar
783e583d9c
Adding in rake task updates and extra data on postgres and oracle fixes
2010-02-02 10:17:46 +11:00
Mikel Lindsaar
cc2fa4d713
Adding extra points from crowd sourcing
2010-02-02 10:09:10 +11:00
Carl Lerche
16c0d1d3b6
Run bundle exec rake instead of bin/rake during CI
2010-02-01 15:08:40 -08:00
Carl Lerche
90ab1a6a4d
[PATCH] remove geminstaller dependency from ci build
2010-02-01 15:04:03 -08:00
Mikel Lindsaar
ddf2b4add3
Xavier's edits
2010-02-02 09:46:55 +11:00
José Valim
d74b5e440c
Make AM test suite green.
2010-02-01 23:34:47 +01:00
Carl Lerche
ff7a6a9b41
Add the database adapter in the generated Gemfile
2010-02-01 13:43:17 -08:00
Santiago Pastorino
bf1f70d877
failing tests in multibyte_chars_test.rb fixed
...
Signed-off-by: Yehuda Katz <wycats@Yehuda-Katz.local >
2010-02-01 09:30:00 -08:00
Xavier Noria
1bc2bb12af
dumps the current 3.0 release notes draft
2010-02-01 16:34:11 +01:00
Mikel Lindsaar
428bdb5063
Adding Release Notes 3.0
2010-02-01 23:51:40 +11:00
José Valim
66615f25cf
Merge branch 'master' of gitproxy:rails/rails
2010-02-01 11:41:16 +01:00
José Valim
0dece7929c
Deprecate AC configuration values which were moved to Rack.
2010-02-01 11:40:27 +01:00
Jeremy Kemper
e5ab4b0d07
Convert to class_attribute
2010-02-01 02:02:42 -08:00
Jeremy Kemper
8ae25a8e41
Introduce class_attribute to declare inheritable class attributes. Writing an attribute on a subclass behaves just like overriding the superclass reader method. Unifies and replaces most usage of cattr_accessor, class_inheritable_attribute, superclass_delegating_attribute, and extlib_inheritable_attribute.
2010-02-01 02:02:41 -08:00
José Valim
a8c5d22c23
Add config.generators.fallbacks.
2010-02-01 10:48:59 +01:00
Mikel Lindsaar
aa9f549965
Updates to output and warning on being for Rails 3.0
2010-02-01 19:59:45 +11:00
Yehuda Katz
2092351652
Add support for compile-time <%= raw %>
2010-01-31 23:42:35 -08:00
Santiago Pastorino
1adfb92135
Deleted all references to ActionView::SafeBuffer in favor of ActiveSupport::SafeBuffer
...
Signed-off-by: Yehuda Katz <wycats@Yehuda-Katz.local >
2010-01-31 22:14:18 -08:00
Santiago Pastorino
9987a00738
action_view/safe_buffer is no longer valid
...
Signed-off-by: Yehuda Katz <wycats@Yehuda-Katz.local >
2010-01-31 21:55:41 -08:00
Prem Sichanugrist
2025bab9e6
Fix some typo that I forgot to remote 'map.'
2010-02-01 11:55:33 +07:00
Prem Sichanugrist
0d01a737a2
Modify the documentation for routing to add the new DSL format of Rails 3
2010-02-01 11:53:37 +07:00
Santiago Pastorino
f439f1d86f
action_view is requiring the deleted action_view/erb/util.rb file
...
Signed-off-by: Yehuda Katz <wycats@Yehuda-Katz.local >
2010-01-31 20:26:28 -08:00
Carl Lerche
3b922aaf08
Update the Ci build script
2010-01-31 20:18:13 -08:00
Mikel Lindsaar
65fb2c7b32
Completely updated the ActionMailer guide
2010-02-01 14:57:54 +11:00
Carl Lerche
a54654de1c
Update the generated Gemfile and config/boot.rb to work with bundler 0.9
2010-01-31 19:48:42 -08:00
Yehuda Katz
4cbb9db0a5
For performance reasons, you can no longer call html_safe! on Strings. Instead, all Strings are always not html_safe?. Instead, you can get a SafeBuffer from a String by calling #html_safe, which will SafeBuffer.new(self).
...
* Additionally, instead of doing concat("</form>".html_safe), you can do
safe_concat("</form>"), which will skip both the flag set, and the flag
check.
* For the first pass, I converted virtually all #html_safe!s to #html_safe,
and the tests pass. A further optimization would be to try to use
#safe_concat as much as possible, reducing the performance impact if
we know up front that a String is safe.
2010-01-31 19:39:13 -08:00
Carl Lerche
1c83fd2eff
Have rails depend on bundler
2010-01-31 19:35:11 -08:00
Carl Lerche
dfeae62e57
Update the CI geminstaller to pull in the correct version of bundler
2010-01-31 19:25:51 -08:00
Carl Lerche
9f01dff9c2
Get rails tests running on bundler 0.9
2010-01-31 19:13:43 -08:00
Jeremy Kemper
9bd0422dd7
Bump arel dependency to 0.2.0 from 0.2.pre
2010-01-31 18:42:41 -08:00
Mikel Lindsaar
65ad16568c
Updating copyright dates on all licenses
2010-02-01 10:10:53 +11:00
Mikel Lindsaar
a07d0f8786
Full update on ActiveModel documentation
2010-02-01 10:08:20 +11:00
Stefan Penner
c493370f33
UJS documentation.
2010-01-31 16:37:33 -06:00
Erik St. Martin
e1618b9ac3
data-remote needs to be on the form and not the submit when using button_to :remote=>true
2010-01-31 14:43:07 -06:00
Stephen St. Martin
a9e89e82b6
add :remote option to form_tag
2010-01-31 13:46:33 -06:00
Stephen St. Martin
a3349f845f
form_for should pass :remote to form_tag through html_options
2010-01-31 13:46:27 -06:00
Joshua Peek
59e9478f57
Require ac/test_case from AV::TestCase
2010-01-31 13:38:16 -06:00
Mikel Lindsaar
bb2c7b432c
Updating Action Mailer documentation
2010-01-31 09:46:51 -08:00
Mikel Lindsaar
2ebea1c02d
deOMGifying Railties, Active Support, and Action Pack
2010-01-31 09:46:30 -08:00
Pratik Naik
ed60021f39
Merge remote branch 'mainstream/master'
...
Conflicts:
activemodel/lib/active_model/state_machine.rb
2010-01-31 14:32:26 +00:00
José Valim
b3a028259f
Improve missing template error messages a little bit.
2010-01-31 10:24:38 +01:00
Joshua Peek
48459c8278
Add rel=nofollow on non get remote links
2010-01-30 20:26:30 -06:00
Joshua Peek
31820b9dd6
Generate UJS code for :disable_with
2010-01-30 20:22:15 -06:00
Erik St. Martin
392817cf11
updating link_to and button_to to support :remote => true and other options such as :confirm in a unobtrusive manor
...
Signed-off-by: Joshua Peek <josh@joshpeek.com >
2010-01-30 19:44:35 -06:00
Joshua Peek
7d9ed8eec1
Include prototype ujs adapter with new apps
2010-01-30 19:20:49 -06:00
Joshua Peek
db49c706b6
Axe AM state machine
...
We're going do it eventually, get it done before 3.0 is final.
2010-01-30 18:38:01 -06:00
Joshua Peek
657d85580e
Reorg options_for_javascript and array_or_string_for_javascript
2010-01-30 16:13:49 -06:00
Joshua Peek
570e02c96a
Move button_to_function to prototype helper
2010-01-30 16:08:56 -06:00
Joshua Peek
ff3f779629
Unused JAVASCRIPT_PATH const
2010-01-30 16:04:58 -06:00
Joshua Peek
ad1924125d
Move scripty JSG helpers into scriptaculous_helper.rb
2010-01-30 16:02:26 -06:00
Joshua Peek
9c2c307ee4
Move form_remote_tag and remote_form_for into prototype_legacy_helper
2010-01-30 15:42:30 -06:00
Joshua Peek
779094a602
Move button_to_remote and submit_to_remote into prototype_legacy_helper
...
plugin
2010-01-30 15:28:31 -06:00
Joshua Peek
b3787643ec
Move link_to_function and link_to_remote into prototype_legacy_helper
...
plugin
2010-01-30 15:20:00 -06:00
Joshua Peek
2de311a093
Drop AjaxHelper
2010-01-30 15:08:29 -06:00
Joshua Peek
95f317b020
Move periodically_call_remote into prototype_legacy_helper plugin
2010-01-30 15:01:02 -06:00
Joshua Peek
61c9b16487
Move observe_field and observe_form to prototype_legacy_helper plugin
2010-01-30 14:53:43 -06:00
Joshua Peek
4f7a85d2c6
Revert "Merge branch 'rails/master' into ujs"
...
This reverts commit 3aa1ea1ae4 , reversing
changes made to 2c12a71378 .
Conflicts:
actionpack/lib/action_view/helpers/javascript_helper.rb
actionpack/lib/action_view/helpers/url_helper.rb
actionpack/test/template/url_helper_test.rb
2010-01-30 14:39:59 -06:00
Joshua Peek
ac20f2cea1
Revert "Add rails.js driver to default source list"
...
This reverts commit 8a46e1182e .
2010-01-30 14:39:59 -06:00
Joshua Peek
ffc10731c3
Revert "fixed tests to also look for rails.js when using javascript_include_tag :defaults"
...
This reverts commit 7f181e4750 .
2010-01-30 14:39:59 -06:00
Joshua Peek
e0d4e5f345
Revert "Drop JS scripts from core"
...
This reverts commit a06c47a52b .
2010-01-30 14:39:59 -06:00
Pratik Naik
ec057ada07
Rely on arel to generate the correct sql when an empty array is supplied to IN predicate
2010-01-30 19:34:05 +00:00
Joshua Peek
1bd8a50a99
Deprecation notice for TestResponse#redirected_to
2010-01-30 12:26:49 -06:00
José Valim
c164ca1efb
Bring helpers_dir deprecation back.
2010-01-30 16:49:58 +01:00
José Valim
2d567e470a
Add transfer_encoding= setter deprecation.
2010-01-30 16:39:27 +01:00
José Valim
0e063f435c
Fix some backward incompatible behavior on AM.
2010-01-30 16:35:22 +01:00
José Valim
d6e2f5013c
Drop AR I18n deprecation and simple use errors.messages as fallback.
2010-01-30 13:12:12 +01:00
José Valim
431fc3c817
Improve railtie deprecation messages.
2010-01-30 12:30:15 +01:00
Paul Rosania
766e857bea
tsort-based dependency resolution for initializers
...
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2010-01-29 19:25:58 -08:00
Joshua Peek
a06c47a52b
Drop JS scripts from core
2010-01-29 20:27:23 -06:00
Joshua Peek
bddd1bb626
Deprecate link_to :popup
2010-01-29 20:00:55 -06:00
Erik St. Martin
7f181e4750
fixed tests to also look for rails.js when using javascript_include_tag :defaults
2010-01-29 16:33:27 -06:00
Joshua Peek
8a46e1182e
Add rails.js driver to default source list
2010-01-29 14:03:38 -06:00
José Valim
24aba77d9c
Only load testing tasks if test unit is being used.
2010-01-29 17:51:06 +01:00
José Valim
17ea8d8d4d
Automatically configure generators if application is defined.
2010-01-29 17:51:06 +01:00
José Valim
cc2642b220
Added :format and :locale options to render.
2010-01-29 17:51:06 +01:00
José Valim
986a4e616b
Fix rendering of layouts.
2010-01-29 17:51:05 +01:00
José Valim
ba82eb2efa
Get rid of AM warnings in AP test suite.
2010-01-29 17:51:05 +01:00
José Valim
3f84091937
ActionMailer should depend just on AbstractController.
2010-01-29 17:51:05 +01:00
Mikel Lindsaar
2960077445
Add a failing test case for render :layout
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-01-29 17:51:05 +01:00
Mikel Lindsaar
1024c11f3c
Added tests for rendering different template for new API
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-01-29 17:51:05 +01:00
Yehuda Katz
8031a53abd
superclass_delegating_accessor rewritten to serve as the base for many other kinds of accessors (step 1 of unification)
2010-01-29 03:01:02 -08:00
Mikel Lindsaar
c6af337d2d
Updating Action Mailer documentation
2010-01-29 16:50:10 +11:00
Pratik Naik
285361d158
Merge remote branch 'mainstream/master'
...
Conflicts:
railties/lib/rails/railtie.rb
2010-01-28 19:46:17 +00:00
Jeremy Kemper
d58398c2b5
Ensure test sets json time format flag
2010-01-28 10:46:23 -08:00
Carl Lerche
f15bbcf97e
Move the ActiveRecord generator settings into the Railtie
2010-01-28 10:45:25 -08:00
José Valim
e7418ab63c
Add more tests to some key points in Railties.
...
Signed-off-by: Carl Lerche <carllerche@mac.com >
2010-01-28 10:28:41 -08:00
José Valim
64ea3dfd9f
Add reloadable specific for engines and move environment to application paths.
...
Signed-off-by: Carl Lerche <carllerche@mac.com >
2010-01-28 10:28:41 -08:00
José Valim
d3d487479a
Add config.to_prepare back and add tests for it.
...
Signed-off-by: Carl Lerche <carllerche@mac.com >
2010-01-28 10:28:40 -08:00
José Valim
226d8e745a
Refactor MetalLoader and RoutesReloader to rely less on class configuration.
...
Signed-off-by: Carl Lerche <carllerche@mac.com >
2010-01-28 10:28:40 -08:00
Carl Lerche
252911e378
Cleanup the test_unit generator move into the railtie
2010-01-28 10:17:41 -08:00
Carl Lerche
6268fcdc30
Fix the test_framework generator tests
2010-01-28 10:03:47 -08:00
Carlhuda
c7c3eac762
Test::Unit Railtie
2010-01-28 09:55:29 -08:00
Xavier Noria
dfa1940865
removes unnecessary curlies in collection_select rdoc
2010-01-28 11:18:32 +01:00
Stefan Penner
3aa1ea1ae4
Merge branch 'rails/master' into ujs
2010-01-27 22:44:56 -06:00
Jeremy Kemper
2c12a71378
Missed template change for defaults -> default
2010-01-27 19:53:46 -08:00
Jeremy Kemper
452bb1e48d
Rename 'defaults' class method to 'default' to reflect that it's a declaration
2010-01-27 19:38:17 -08:00
Jeremy Kemper
079714277d
Attend to brittle mailer generator tests
2010-01-27 19:33:26 -08:00
Jeremy Kemper
fd0eb3d904
Clear up some ivar warnings
2010-01-27 19:33:03 -08:00
Erik St. Martin
2ec99192d5
renaming javascript drivers to *.rails.js for better naming convention
2010-01-27 22:32:10 -05:00
Jeremy Kemper
187b3b0b48
Fix time comparison. Mail#date returns DateTime not Time.
2010-01-27 19:08:36 -08:00
Jeremy Kemper
8c60acbea2
Expected attachment encoding is binary
2010-01-27 18:37:17 -08:00
Erik St. Martin
eff999d679
initial prototype of jQuery driver complete
2010-01-27 21:35:58 -05:00
Jatinder Singh
e87748869a
Use format of ARes rather than content-type of remote errors to load errors.
...
[#1956 state:committed]
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2010-01-27 18:27:18 -08:00
Geoff Buesing
e98f9579c4
Time#- with a DateTime argument behaves the same as with a Time argument, i.e. returns the difference between self and arg as a Float [ #3476 status:resolved]
2010-01-27 20:17:09 -06:00
snusnu
016f15dc69
active_support/ordered_hash now requires yaml
2010-01-27 18:13:06 -08:00
Erik St. Martin
a0232d8641
jquery driver now supports :confirm
2010-01-27 20:58:17 -05:00
Erik St. Martin
4911343bf7
jquery driver now supports :popup
2010-01-27 20:42:36 -05:00
Jeremy Kemper
f2dd3578c0
self.defaults => default
2010-01-27 17:35:51 -08:00
Jeremy Kemper
030ab357f9
Remove unbundle changelogs
2010-01-27 17:11:29 -08:00
Jeremy Kemper
8399a315f5
Merge remote branch 'mikel/master'
2010-01-27 17:09:55 -08:00
Mikel Lindsaar
a06a5a64ba
Unvendor'd text-format, now requires text-format gem
2010-01-28 12:08:14 +11:00
Mikel Lindsaar
c1f308f8c6
Unvendor'd MemCache-Client. Now requires the MemCache Client gem as a dependency - Don't forget to gem bundle buys and girls
2010-01-28 11:56:47 +11:00
Mikel Lindsaar
f1fe71d754
Unvendor'd Builder. Now requires the Builder gem as a dependency
2010-01-28 11:51:37 +11:00
Mikel Lindsaar
9029efce41
Unbundling TZInfo
2010-01-28 11:46:54 +11:00
Mikel Lindsaar
32ce2bb37f
Updated mail requirement to 2.1.2
2010-01-28 11:33:58 +11:00
Gregor Schmidt
7b8c6472ff
Adding custom yaml (de-)serialization for OrderedHash
...
[#3608 state:committed]
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2010-01-27 15:29:06 -08:00
Xavier Noria
5d21676aaa
AS guide: Class#subclasses has been removed in ec7c642f5f
2010-01-27 22:15:37 +01:00
Xavier Noria
7346dec713
AS guide: Object#remove_subclasses_of has been removed in 5b01c8bb8b
2010-01-27 22:14:14 +01:00
Xavier Noria
afc7baf568
AS guide: Object#subclasses_of has been removed in 245bfafe33
2010-01-27 22:12:58 +01:00
Xavier Noria
be45bf0fd9
AS guide: Class#descendents has been removed in f85f5dfc8f
2010-01-27 22:11:38 +01:00
Xavier Noria
5c2be6d804
AS guide: Class#reachable? has been removed in 5f981ff029
2010-01-27 22:10:46 +01:00
Xavier Noria
b0edc8dcf2
AS guide: Class#remove_class has been removed in 44afd785c8
2010-01-27 22:09:52 +01:00
Xavier Noria
6bdd9cb8f1
AS guide: Object#extend_with_included_modules_from has been removed in ccec730d7f
2010-01-27 22:08:08 +01:00
Xavier Noria
7a91f3712c
Object#extended_by has been deleted in c25ac0deee
2010-01-27 22:06:04 +01:00
Stefan Penner
2e338aed70
updated tests + docs, plus minor inconsistency fixes
2010-01-27 12:44:36 -06:00
Stefan Penner
253f335294
tests + docs
2010-01-27 12:44:36 -06:00
Stephen St. Martin
da19dfa419
support for observers in jquery driver, and minor bug fixes
2010-01-27 12:44:35 -06:00
Erik St. Martin
d13f254160
initial prototype of prototype js driver
2010-01-27 12:44:35 -06:00
Erik St. Martin
3c7d39d65f
observe_form now supports :with option as it should
2010-01-27 12:44:35 -06:00
Stephen St. Martin
5584d58e65
refactored to be more dry, data-update-failure now correctly works, combine compat and driver, namespaced events, and support for periodically_call_remote
2010-01-27 12:44:35 -06:00
Stefan Penner
1b8ced53c4
Added regression tests that discovered the previous issue.
2010-01-27 12:44:35 -06:00
Erik St. Martin
c0f63883ea
:href should be comming in through html_options and not options
2010-01-27 12:44:35 -06:00
Erik St. Martin
f661a3bc59
removing container inline js function of observed elements :function callback
2010-01-27 12:44:35 -06:00
Erik St. Martin
a6cd35ba68
moving html_safe call into helpers directly as they only work from that level
2010-01-27 12:44:35 -06:00
Erik St. Martin
007db3fca8
start of prototype driver, missing observe_form, observe_field, and periodically_call_remote
2010-01-27 12:44:35 -06:00
Erik St. Martin
0215466832
periodically_call_remote does not need data-observe=true
2010-01-27 12:44:35 -06:00
Erik St. Martin
6a8da2053e
need to tell erb that our <script> tag is html_safe
2010-01-27 12:44:35 -06:00
Erik St. Martin
ad26b3934e
test to go with last commit, explicit :href for link_to_remote
2010-01-27 12:44:35 -06:00
Erik St. Martin
9fe845670d
adding :href override to link_to_remote
2010-01-27 12:44:34 -06:00
Erik St. Martin
56ae6550b8
adding support for :disable_with to button_to_remote
2010-01-27 12:44:34 -06:00
Stephen St. Martin
ff26ca68d2
support for submit_to_remote in jquery driver
2010-01-27 12:44:34 -06:00
Stephen St. Martin
8b7cd5ae7e
fix duplidate data-submit attribute, submit_to_remote should test url
2010-01-27 12:44:34 -06:00
Stephen St. Martin
2204215b43
upgrade jquery to 1.4.1 and default request method to GET as its default on forms and links
2010-01-27 12:44:34 -06:00
Erik St. Martin
eb2d32f309
remote_form_for now supports :confirm
2010-01-27 12:44:34 -06:00
Stephen St. Martin
ed09413230
refractor handler code for remote_form_tag to also handle link_to_remote, fix a bug preventing :method from being used, also add missing :position, :confirm is still not functional yet
2010-01-27 12:44:34 -06:00
Erik St. Martin
44542bd7da
account for the fact a few options may be passed as symbols and need to be converted to string
2010-01-27 12:44:34 -06:00
Stephen St. Martin
04ad12d681
initial jquery driver and compat, right now the only supported method is form_remote_tag
2010-01-27 12:44:34 -06:00
Stephen St. Martin
5a75f1ab90
add missing call to set_with_and_condition_attributes for form_remote_tag
2010-01-27 12:44:34 -06:00
Erik St. Martin
06dd23d671
removing Prototype inline js for attributes for :with and :condition, it now is free form js that can be placed there, also moved :submit out into AjaxHelper, updated tests to reflect changes
2010-01-27 12:44:34 -06:00
Stephen St. Martin
d9af0dfac4
refactor params and with into copat module
2010-01-27 12:44:33 -06:00
Stephen St. Martin
a5e9d033e8
add missing test for :with option to link_to_remote
2010-01-27 12:44:33 -06:00
Erik St. Martin
9e3e1b3f24
fixing last merge breakage
2010-01-27 12:44:33 -06:00
Stephen St. Martin
133f6011d0
add missing :before and :after callbacks for link_to_remote
2010-01-27 12:44:33 -06:00
Erik St. Martin
426a6b2e00
making non remote versions of link_to, button_to, submit_tag and image_submit_tag output data attributes for things like :confirm, :method, :popup, and :disable_with
2010-01-27 12:44:33 -06:00
Erik St. Martin
9821648644
link_to_remote and button_to_remote now support :confirm
2010-01-27 12:44:33 -06:00
Erik St. Martin
d769897171
modified helper that adds attributes for :method to include rel='nofollow' if :method => :delete, same as its remote_ equivalent
2010-01-27 12:44:33 -06:00
Erik St. Martin
fbb56f7ee8
refactoring AjaxHelper a bit so that it calls shared method from JavascriptHelper to add attributes for :confirm
2010-01-27 12:44:33 -06:00
Erik St. Martin
463fc71107
making non remote versions of link_to, button_to, submit_tag and image_submit_tag output data attributes for things like :confirm, :method, :popup, and :disable_with
2010-01-27 12:44:33 -06:00
Erik St. Martin
c3baf8b767
link_to_remote and button_to_remote now support :confirm
2010-01-27 12:44:33 -06:00
Stephen St. Martin
9ad8d348b5
test :method option of link_to_remote, and ensure rel='nofollow' is added when :method => 'delete'
2010-01-27 12:44:33 -06:00
Erik St. Martin
9f5cb3d3b4
moving include of ScriptaculousHelper into PrototypeHelper, ActionView should know as little as possible about individual frameworks
2010-01-27 12:44:33 -06:00
Stephen St. Martin
37ad57596b
port existing test suite to check for new output, and fix all breaking tests
2010-01-27 12:44:32 -06:00
Erik St. Martin
7bf5aef907
fixed current tests that were failing do to module location change, this is temporary to fix state of repo till all the new tests are complete
2010-01-27 12:44:32 -06:00
Stefan Penner
255066b6c7
first round of documenation for ujs
2010-01-27 12:44:32 -06:00
Stephen St. Martin
20c6c71e6a
oops, remove test code
2010-01-27 12:44:32 -06:00
Stephen St. Martin
d8343a6ad7
restructure compatibility module so it is no longer a child
2010-01-27 12:44:32 -06:00
Erik St. Martin
565a696e71
Removed all helpers from PrototypeHelper that are implemented in AjaxHelper. Modified tests that extended with PrototypeHelper to now extend using AjaxHelper. AjaxHelper is now included by default in view helper
2010-01-27 12:44:32 -06:00
Erik St. Martin
5462caf434
fixing failing tests from last commit, order of attributes matters should probably change this later
2010-01-27 12:44:32 -06:00
Erik St. Martin
1cd8b98d01
javascript_helper now correctly pulls in ajax_helper instead of prototype_helper. prototype_helper is pulled in by ajax_helper for reverse compatibility
2010-01-27 12:44:32 -06:00
Stephen St. Martin
f115fb0111
make observers a little more dry
2010-01-27 12:44:32 -06:00
Stephen St. Martin
49e84a5943
fix failing tests from fork/merge
2010-01-27 12:44:31 -06:00
Stephen St. Martin
07299eb60d
rename ajax_test.rb to ajax_helper_test.rb for consistency
2010-01-27 12:44:31 -06:00
Stephen St. Martin
143d0764d0
nuke what appears to be a duplicate and unused test file
2010-01-27 12:44:31 -06:00
Stephen St. Martin
62a2d5178c
cleanup some spacing
2010-01-27 12:44:31 -06:00
Stephen St. Martin
27d52e00d9
extract_remote_attributes should be a private method
2010-01-27 12:44:31 -06:00
Bob Remeika
95b77e925f
Added observe_form
2010-01-27 12:44:31 -06:00
Bob Remeika
7d34975214
Added submit_to_remote helper
2010-01-27 12:44:31 -06:00
Bob Remeika
39ec7ce6a9
Removed duplication
2010-01-27 12:44:31 -06:00
Bob Remeika
8e172f13d7
Changed data-name to data-observed on observe_field
2010-01-27 12:44:31 -06:00
Bob Remeika
261654becf
Refactored ajax helpers so they use a little bit more coherent pattern; Removed code duplication from form_remote_tag
2010-01-27 12:44:31 -06:00
Bob Remeika
dad3d09ce8
Applied Yehuda's patch; Sharing extract_object_name_for_form! between form_helper and ajax_helper; Added script_decorator helper
2010-01-27 12:44:30 -06:00
Bob Remeika
5491a663da
Changed observe_field to field_observer
2010-01-27 12:44:30 -06:00
Bob Remeika
9c12e66748
Changed data-rails-type to data-js-type
2010-01-27 12:44:30 -06:00
Bob Remeika
bd65e7f73d
Changed data-remote='true' to data-js-type='remote'
2010-01-27 12:44:30 -06:00
Bob Remeika
631537a25d
remote_form_for tests pass
2010-01-27 12:44:30 -06:00
Bob Remeika
5316e77db1
Took first stab at reimplementing form_remote_tag helpers
2010-01-27 12:44:30 -06:00
Bob Remeika
b225de9711
Added assert_data_element_json test helper for data element helpers
2010-01-27 12:44:30 -06:00
Bob Remeika
afdecbc0a8
Took another stab at observe_field. Now implementing data only helpers as script elements.
2010-01-27 12:44:30 -06:00
Bob Remeika
d383f057c0
Changed the observe field node into a div with display:none
2010-01-27 12:44:30 -06:00
Bob Remeika
25c5ddd021
ObserveFieldTest uses url_for from AjaxTestCase
2010-01-27 12:44:30 -06:00
Stefan Penner
8f97e03fb0
fixed failing tests
2010-01-27 12:44:30 -06:00
Bob Remeika
773c4929fd
Implemented a fuller stub in AjaxTestCase for url_for because link_to calls url_for on all urls passed to it. Tests that were testing different input types for the url were failing because of this.
2010-01-27 12:44:30 -06:00
Bob Remeika
23275d1b79
Added the beginnings of the observe_field helper
2010-01-27 12:44:29 -06:00
Bob Remeika
b599c4c7ee
Added observe_form
2010-01-27 12:44:29 -06:00
Bob Remeika
8c43c11a9d
Added submit_to_remote helper
2010-01-27 12:44:29 -06:00
Bob Remeika
67b73ff272
Removed duplication
2010-01-27 12:44:29 -06:00
Bob Remeika
d9765c3af5
Changed data-name to data-observed on observe_field
2010-01-27 12:44:29 -06:00
Bob Remeika
4536191d55
Refactored ajax helpers so they use a little bit more coherent pattern; Removed code duplication from form_remote_tag
2010-01-27 12:44:29 -06:00
Bob Remeika
5ced1225fa
Applied Yehuda's patch; Sharing extract_object_name_for_form! between form_helper and ajax_helper; Added script_decorator helper
2010-01-27 12:44:29 -06:00
Bob Remeika
c1ce17a5f4
Changed observe_field to field_observer
2010-01-27 12:44:29 -06:00
Bob Remeika
081e057b17
Changed data-rails-type to data-js-type
2010-01-27 12:44:29 -06:00
Bob Remeika
efb70f0f9f
Changed data-remote='true' to data-js-type='remote'
2010-01-27 12:44:29 -06:00
Bob Remeika
29811533b4
remote_form_for tests pass
2010-01-27 12:44:29 -06:00
Bob Remeika
118a720a01
Took first stab at reimplementing form_remote_tag helpers
2010-01-27 12:44:29 -06:00
Bob Remeika
0955f57915
Added assert_data_element_json test helper for data element helpers
2010-01-27 12:44:28 -06:00
Bob Remeika
6fa8f81d7d
Took another stab at observe_field. Now implementing data only helpers as script elements.
2010-01-27 12:44:28 -06:00
Bob Remeika
88e793e5e7
Changed the observe field node into a div with display:none
2010-01-27 12:44:28 -06:00
Bob Remeika
fab8b25c15
ObserveFieldTest uses url_for from AjaxTestCase
2010-01-27 12:44:28 -06:00
Stefan Penner
77fc50a08b
fixed failing tests
2010-01-27 12:44:28 -06:00
Bob Remeika
c44682f6ab
Implemented a fuller stub in AjaxTestCase for url_for because link_to calls url_for on all urls passed to it. Tests that were testing different input types for the url were failing because of this.
2010-01-27 12:44:28 -06:00
Bob Remeika
a792ee5665
Added the beginnings of the observe_field helper
2010-01-27 12:44:28 -06:00
James Miller
d546a72d00
Add my info to the credits
2010-01-27 09:51:46 -08:00
James Miller
b204d9477c
Fix view description mismatch
2010-01-27 09:23:42 -08:00
Mikel Lindsaar
b6b3db6734
Fixed bug on HTML only emails getting set to text/plain
2010-01-28 00:24:30 +11:00
Geoff Buesing
f3caa63bcb
Update bundled TZInfo to v0.3.16
2010-01-26 20:22:29 -06:00
Geoff Buesing
1cda85d08a
Georgetown TimeZone is now mapped to "America/Guyana" instead of "America/Argentina/San_Juan" [ #1821 status:resolved]
2010-01-26 20:18:17 -06:00
Jeremy Kemper
aef76d1e71
Merge remote branch 'fxn/master'
2010-01-26 15:38:49 -08:00
Mikel Lindsaar
458b6a7fc9
Fixing mailer generators to use the right email address
2010-01-27 10:35:56 +11:00
Aaron Patterson
beda2d43d6
future proofing the sqlite3 adapter code
...
Signed-off-by: Yehuda Katz <wycats@Yehuda-Katz.local >
2010-01-26 15:09:11 -08:00
Xavier Noria
3c6891593d
removes now void extending.rb
2010-01-26 23:08:00 +01:00
Xavier Noria
c25ac0deee
removes Object#extended_by
2010-01-26 23:03:58 +01:00
Xavier Noria
ccec730d7f
removes unused method Object#extend_with_included_modules_from
2010-01-26 23:01:51 +01:00
Xavier Noria
7d312e54ba
deletes no void files removal.rb and class_test.rb
2010-01-26 22:57:27 +01:00
Xavier Noria
44afd785c8
removes unused method Class#remove_class
2010-01-26 22:51:44 +01:00
Xavier Noria
5f981ff029
removes unused method Class#reachable?
2010-01-26 22:49:35 +01:00
Xavier Noria
f85f5dfc8f
removes unused Class#descedents
2010-01-26 22:48:21 +01:00
Xavier Noria
245bfafe33
removes unused Object#subclasses_of
2010-01-26 22:46:47 +01:00
Xavier Noria
5b01c8bb8b
removes unused Object#remove_subclasses_of
2010-01-26 22:44:32 +01:00
Xavier Noria
1b2ac25a2f
removes unused Class#remove_subclasses
2010-01-26 22:42:56 +01:00
Xavier Noria
ec7c642f5f
removes unused method Class#subclasses
2010-01-26 22:37:55 +01:00
José Valim
6404feee50
AC railtie should configure helpers path.
2010-01-26 21:05:50 +01:00
José Valim
dc57d545bb
Fix t('.helper').
2010-01-26 20:43:35 +01:00
José Valim
9f63c4b26e
Bring AM tests back to green again.
2010-01-26 19:50:59 +01:00
José Valim
af43674c1c
Fix failing tests on AM about render(:body => Hash).
2010-01-26 19:15:32 +01:00
José Valim
bdc39fad36
Merge branch 'master' of git://github.com/rails/rails
2010-01-26 18:39:53 +01:00
Joshua Peek
31b538df64
Failing AM test for legacy multipart alternative rendering
2010-01-26 09:37:20 -06:00
José Valim
e274eb1df1
Bring layouts with proc back alive.
2010-01-26 16:34:25 +01:00
Joshua Peek
9f7190187c
Failing AM test for nested layouts
2010-01-26 09:27:54 -06:00
José Valim
48a3985dd7
Also include translation in ActionMailer.
2010-01-26 16:18:29 +01:00
José Valim
52bb455c0d
Merge branch 'master' of git://github.com/rails/rails
2010-01-26 16:05:32 +01:00
José Valim
1078677575
Merge remote branch 'mikel/master'
2010-01-26 16:00:57 +01:00
José Valim and Mikel Lindsaar
05c4ad9d3f
Tidy up tests and docs.
2010-01-26 16:00:24 +01:00
Joshua Peek
f74fbf9d32
Keep ActionController::Base.helpers_dir around for a bit longer
2010-01-26 08:52:20 -06:00
José Valim
d7de1c76ca
Add a test which ensures application can overwrite plugins/engines view paths.
2010-01-26 15:46:17 +01:00
José Valim
081dfca33a
Clean up Rails::Rack::Logger.
2010-01-26 15:37:45 +01:00
José Valim
edb8131535
Move Rails::Rack::Metal to Rails::Application::Metal and just add cascade if any metal was declared.
2010-01-26 15:27:46 +01:00
José Valim
517b35a2bb
Middleware stack actually runs routes and not the application.
2010-01-26 15:00:27 +01:00
José Valim
f8bf1982df
Add tests for explicit engines.
2010-01-26 14:58:00 +01:00
Mikel Lindsaar
ccea6ab07d
Fixing up tests and docs to use defaults :from => 'name' instead of defaults({:from => 'name'})
2010-01-27 00:38:12 +11:00
Mikel Lindsaar
1133757a95
Merge branch 'master' of github.com:mikel/rails
...
Conflicts:
actionmailer/lib/action_mailer/base.rb
2010-01-27 00:21:22 +11:00
Mikel Lindsaar
21dcc20ed2
Fixed up documentation to reflect code change and cleaned up tests of spurious #deliver calls
2010-01-27 00:18:40 +11:00
José Valim
7adb1ffc03
Remove old fixtures files.
2010-01-26 14:09:48 +01:00
Mikel Lindsaar
9520166f70
Fixed up being able to pass random headers in with headers, or mail. Also, undeprecated headers(hash) as this works now too
2010-01-27 00:06:19 +11:00
José Valim
1dca7ebc93
Refactor railties test, break huge files in smaller chunks and move initializers to application folder.
2010-01-26 13:57:11 +01:00
José Valim
e6da2f651f
Ensure app does not show up in generators.
2010-01-26 12:23:02 +01:00
José Valim
007c0bb3b0
Ensure proper class is shown on rake middleware.
2010-01-26 12:16:47 +01:00
José Valim
db99324a89
Ensure calling a method in Rails::Application does not instantiate a void application.
2010-01-26 12:16:47 +01:00
José Valim and Mikel Lindsaar
8fabcb2eca
Update generators to use new defaults.
2010-01-26 11:48:25 +01:00
José Valim and Mikel Lindsaar
39a1b06f13
Deprecate old defaults API.
2010-01-26 11:46:42 +01:00
José Valim and Mikel Lindsaar
9dd65c368b
Make defaults accept a hash.
2010-01-26 11:21:20 +01:00
Mikel Lindsaar
b8c82edc1f
Updating generators for mailer to reflect changes in API
2010-01-26 18:59:52 +11:00
Mikel Lindsaar
e297eed4f2
Fixing up expectations in base_test.rb
2010-01-26 17:11:36 +11:00
Mikel Lindsaar
0b05acd424
Implementing class level :defaults hash, instead of delivers_from et al
2010-01-26 17:08:55 +11:00
Jack Christensen
c5b652f3d2
PostgreSQLAdapter: set time_zone to UTC when Base.default_timezone == :utc so that Postgres doesn't incorrectly offset-adjust values inserted into TIMESTAMP WITH TIME ZONE columns [ #3777 state:resolved]
2010-01-25 20:57:07 -06:00
Carlhuda
64f8c87b1d
Fix AR's rake tasks to work with the Rails::Application refactor
2010-01-25 17:55:54 -08:00
José Valim
abad097016
Merge remote branch 'mikel/master'
2010-01-26 01:56:52 +01:00
José Valim and Mikel Lindsaar
c02391f8f9
Fix small typo.
2010-01-26 01:54:23 +01:00
José Valim and Mikel Lindsaar
4af2bbc6b4
Merge branch 'master' of github.com:mikel/rails
2010-01-26 01:51:23 +01:00
José Valim and Mikel Lindsaar
74a5889abe
Refactor content type setting, added tests to ensure boundary exists on multipart and fixed typo
2010-01-26 11:49:59 +11:00
José Valim and Mikel Lindsaar
6589976533
Remove old files, add some information to docs and improve test suite.
2010-01-26 01:43:41 +01:00
José Valim and Mikel Lindsaar
1b3cb54eba
More work on generated mailer templates.
2010-01-26 01:09:08 +01:00
José Valim
8974dac92e
Ensure root routes inside optional scopes works as expected.
2010-01-26 00:55:26 +01:00
José Valim
5d07869245
Ensure all initializers are collections.
2010-01-26 00:08:08 +01:00
José Valim
a89c8cb528
Merge branch 'master' of git://github.com/rails/rails
...
Conflicts:
railties/test/railties/plugin_test.rb
2010-01-25 23:44:03 +01:00
José Valim
49be3316c2
Add a deprecation for helpers_dir.
2010-01-25 23:38:47 +01:00
Joshua Peek
3086dbd8d0
Failing test for plugin init requiring another plugin lib file
2010-01-25 16:33:29 -06:00
José Valim
cc1bb8590e
Refactor some railties tests structure.
2010-01-25 23:17:39 +01:00
José Valim
02908e1142
As first step setup the load path and lazy compare middlewares.
2010-01-25 22:59:08 +01:00
José Valim
1177a40e68
Fix i18n locales order test.
2010-01-25 22:10:11 +01:00
Joshua Peek
c6104e6514
Failing test for using plugin middleware in application config
2010-01-25 12:55:30 -06:00
Joshua Peek
2d1f9fb98f
Plugins need to load before app initializers
2010-01-25 11:06:39 -06:00
José Valim and Mikel Lindsaar
f14390091c
We don't support enriched yet
2010-01-26 00:09:18 +11:00
José Valim and Mikel Lindsaar
4a6eba3232
Added initial documentation for the new API
2010-01-25 23:46:23 +11:00
José Valim and Mikel Lindsaar
9cb3ca1d29
Change mailer generator templates and refactor the whole naming schema.
2010-01-25 13:20:32 +01:00
José Valim and Mikel Lindsaar
ad8f5d4106
Updated to mail 2.1.1
2010-01-25 23:15:16 +11:00
José Valim and Mikel Lindsaar
d5e4e9185b
Updated gemspec for Mail
2010-01-25 21:47:24 +11:00
José Valim and Mikel Lindsaar
ace74974cf
Got AM working with Mail yield on delivery_handler and updated tests
2010-01-25 21:47:03 +11:00
Mikel Lindsaar
45b7bccd61
Updating credits file to add myself
2010-01-25 20:34:44 +11:00
Mikel Lindsaar
c3743c7ff7
Updated formatting on shell code to fit
2010-01-25 20:34:44 +11:00
Mikel Lindsaar
cdba13e504
Updated layouts and rendering guide to Rails 3.0
2010-01-25 20:34:44 +11:00
José Valim and Mikel Lindsaar
4240369a43
changed test to get TestMailer to use :file delivery method directly (as setup action was resetting delivery_method to :test on init
2010-01-25 13:46:44 +11:00
José Valim and Mikel Lindsaar
e4a989e9d9
Added delivery_handler method to mail and implemented in ActionMailer to deliver inside of instrumentation
2010-01-25 13:39:48 +11:00
José Valim
3b6f659fb6
Add active_model/railtie back to generated boot.rb, add models back to paths, load active_support/railtie since we need it and ensure default logger is set before config.
2010-01-25 01:12:22 +01:00
José Valim and Mikel Lindsaar
e1c1318638
Added delivers_from.
2010-01-25 00:37:12 +01:00
José Valim and Mikel Lindsaar
48faf53be1
Add some view paths tests.
2010-01-25 00:20:38 +01:00
Ben Marini
c5211c28e2
Updated instructions on how to create test databases with proper encoding [ #97 ]
2010-01-24 15:01:22 -08:00
José Valim and Mikel Lindsaar
90e9e46576
Merge branch 'master' of github.com:mikel/rails
2010-01-24 23:59:29 +01:00
José Valim and Mikel Lindsaar
0ece244fee
Ensure implicit multipart templates with locale works as expected.
2010-01-24 23:59:12 +01:00
José Valim and Mikel Lindsaar
4e96442c4e
Merge branch 'master' of git://github.com/rails/rails
...
Conflicts:
actionmailer/lib/action_mailer/mail_helper.rb
railties/lib/rails/configuration.rb
2010-01-25 09:50:01 +11:00
José Valim and Mikel Lindsaar
c0262827ca
Speed up some Hash core extensions.
2010-01-24 23:40:45 +01:00
José Valim and Mikel Lindsaar
328b0b1268
Remove deprecated behavior since 2.3.
2010-01-24 23:32:09 +01:00
José Valim and Mikel Lindsaar
0361414ae3
Add uniq_by and uniq_by! to Array.
2010-01-24 23:28:52 +01:00
Rizwan Reza
396003fc48
Revamp of Rails documentation task
...
Signed-off-by: Yehuda Katz <wycats@Yehuda-Katz.local >
2010-01-24 13:16:38 -08:00
José Valim
6e57b88c60
Fix a couple failures on 1.9.1.
2010-01-24 21:21:37 +01:00
José Valim and Mikel Lindsaar
a74a655648
Add tests to mail helper.
2010-01-24 19:52:50 +01:00
José Valim and Mikel Lindsaar
bd96614101
Move old tests to a specific folder and add some delivery method tests.
2010-01-24 19:36:42 +01:00
José Valim and Mikel Lindsaar
99f960a3d7
Handle some TODOs and deprecations.
2010-01-24 18:40:04 +01:00
José Valim and Mikel Lindsaar
0d931fecbb
Finish cleaning up delivery methods implementation.
2010-01-24 18:11:57 +01:00
José Valim and Mikel Lindsaar
5dead5bb88
Maintain old_api and deprecated_api in different files.
2010-01-24 17:49:48 +01:00
Joshua Peek
9543298d02
Use Rails::Application ref in Rakefile and console scripts.
...
Less places you need to change if you rename your application.
2010-01-24 10:35:45 -06:00
José Valim and Mikel Lindsaar
f30d73bab4
Add new class delivery method API.
2010-01-24 17:31:18 +01:00
Joshua Peek
9212652155
Add Rails::Application pointer to the default app to add symmetry to Foo::Application
2010-01-24 10:29:38 -06:00
José Valim and Mikel Lindsaar
7409b73484
Some refactoring.
2010-01-24 16:37:28 +01:00
José Valim
6545a68264
Fix failing tests after merge.
2010-01-24 15:08:06 +01:00
José Valim
84ebfa4550
Ensure metals and initializers in plugins are loaded.
2010-01-24 14:48:00 +01:00
José Valim
dd05b6c543
Add tests for plugin sanity check.
2010-01-24 12:49:12 +01:00
José Valim
e548f96b1d
Rename plugin_name to railtie_name and engine_name.
2010-01-24 12:23:21 +01:00
José Valim
b92608770e
Ensure environment config has higher priority than application ones.
2010-01-24 12:15:46 +01:00
José Valim
37e4deb260
Ensure helpers work from configured path.
2010-01-24 12:04:37 +01:00
José Valim
e0bdc4f446
Ensure namespaced controllers in engines work.
2010-01-24 11:06:06 +01:00
José Valim and Mikel Lindsaar
73a9000402
Adding failing tests for calling just the action, instead of :create_action_name and :deliver_action_name
2010-01-24 20:38:53 +11:00
José Valim
5cd9aad4fd
Add I18n tests to engines.
2010-01-24 10:27:42 +01:00
José Valim
25724c664d
Load deprecated tasks for plugins.
2010-01-24 10:03:03 +01:00
José Valim
5b26fa4875
Make plugin generator compatible with new schema.
2010-01-24 09:42:28 +01:00
José Valim
2fde9d774b
Solve some pendencies.
2010-01-24 09:32:54 +01:00
Mikel Lindsaar
5742a72b8a
Fixed :_delete is now :_destroy in Rails 3.0
2010-01-24 19:31:39 +11:00
Mikel Lindsaar
48142a704a
Fixing up that _delete is no longer used on the form helper for accepts_nested_attributes_for, it is now _destroy
2010-01-24 19:26:40 +11:00
Mikel Lindsaar
6b2ee4e8a0
Updated "Getting Started" to work and reflect changes in Rails 3.0
...
Also created http://github.com/mikel/getting-started-code which is
a copy of all the code in this guide.
2010-01-24 16:58:14 +11:00
José Valim and Mikel Lindsaar
afc758297c
Moving AS::Notifications call to one location in base
2010-01-24 12:30:13 +11:00
José Valim and Mikel Lindsaar
258ca14800
Delegated ActionMailer::Base.deliveries to Mail.deliveries, added callback support in Mail to call ActionMailer on delivery, moved deliver to deprecated API in preparation for new API
2010-01-24 11:15:42 +11:00
José Valim and Mikel Lindsaar
e7e4ed48df
Set sort order for explicit parts from the collector's template sequence
2010-01-24 09:34:50 +11:00
José Valim
d3c40242a5
Move console stuff to its own directory.
2010-01-23 23:02:43 +01:00
José Valim
f915f9e339
Merge branch 'master' into app
...
Conflicts:
railties/lib/rails/application.rb
2010-01-23 22:53:26 +01:00
José Valim
b17e358e3d
Move configuration to subfolders.
2010-01-23 22:30:17 +01:00
Pratik Naik
efd0bd3b73
Merge remote branch 'mainstream/master'
2010-01-24 01:33:18 +05:30
José Valim
788fce2550
Create configurable modules and ensure that they are added only on direct children.
2010-01-23 18:41:53 +01:00
orangea
f4571e3617
generate_pdf gets it's parameter now
2010-01-23 09:20:46 -08:00
José Valim
2b75b94ac0
Plugin is now an Engine.
2010-01-23 17:51:48 +01:00
José Valim
924fa084e8
First steps into making Plugin < Engine.
2010-01-23 17:13:25 +01:00
José Valim
13d66cdf25
Extract Railtie load from application.
2010-01-23 16:59:37 +01:00
José Valim
4f03603215
Break application.rb file in smaller chunks.
2010-01-23 16:07:20 +01:00
José Valim
80130d1201
Extract routes reloading responsibilities from application and load them just upon a request.
2010-01-23 16:06:33 +01:00
Xavier Noria
c718da5351
render :text renders text, thank to Patrik Wenger
2010-01-23 13:19:58 +01:00
José Valim and Mikel Lindsaar
c985a0ee3d
Add some tests to collector with templates and any.
2010-01-23 12:46:40 +01:00
José Valim and Mikel Lindsaar
6ba944608e
Make implicit and explicit templates pass through the same part creation process.
2010-01-23 12:20:20 +01:00
José Valim and Mikel Lindsaar
5a19d24892
Adding collector to ActionMailer
2010-01-23 21:50:36 +11:00
José Valim and Mikel Lindsaar
c6b16260fe
Added basic explicit multipart rendering and tests
2010-01-23 21:37:34 +11:00
José Valim and Mikel Lindsaar
502028a32b
Move double render check out of AbstractController.
2010-01-23 10:29:22 +01:00
José Valim and Mikel Lindsaar
5c3ef8c17d
Refactor subject with i18n.
2010-01-23 10:24:19 +01:00
José Valim and Mikel Lindsaar
ddfc0725a0
Added AbstractController::Collector.
2010-01-23 10:23:06 +01:00
Mikel Lindsaar
1ea84c38ea
Merge branch 'master' of git://github.com/rails/rails
2010-01-23 19:45:25 +11:00
Pratik Naik
8ff2fb6f3a
Make default_scope work with Relations
2010-01-23 13:41:09 +05:30
Mikel Lindsaar
bd24c75fc6
Updated Gemspec to mail 2.0.3 from gemcutter
2010-01-23 18:45:59 +11:00
José Valim
4eab3aad8d
Ensure user set load paths have higher preference and move Bootstrap inside Application.
2010-01-23 02:03:11 +01:00
José Valim
98240c49b0
Get rid of initializers global and create i18n railtie.
2010-01-23 01:29:29 +01:00
Joshua Peek
c2e57c0bb0
I removed the rdoc task from plugin Rakefile
2010-01-22 13:56:10 -06:00
Joshua Peek
2db14457f4
Delegate App calls to instance
2010-01-22 13:56:10 -06:00
José Valim
c8cc8a9872
Moved more configuration away from bootstrap.
2010-01-22 20:44:38 +01:00
José Valim
d618b7e3dc
Ensure strings given to render with slash are rendered relative to the configured _prefix.
2010-01-22 17:58:03 +01:00
Prem Sichanugrist
cc6f16685c
Add test case for load initializers before routing behavior.
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-01-22 17:58:03 +01:00
Xavier Noria
5c53ffe1db
Add missing require for Object#try [ #3771 state:resolved]
...
Signed-off-by: Pratik Naik <pratiknaik@gmail.com >
2010-01-22 22:20:00 +05:30
Joshua Peek
1a750da130
Make @controller an internal ivar in the view
2010-01-22 10:19:01 -06:00
José Valim
4ae7936727
Got tests working once again.
2010-01-22 16:24:44 +01:00
Pratik Naik
4afd9702fe
Relation should respond to class methods
2010-01-22 20:14:37 +05:30
Pratik Naik
ee8c006dac
Allow calling class methods on a Relation
2010-01-22 20:10:41 +05:30
Joshua Peek
c52820ae15
Use expand_path to require environment in metal template
2010-01-22 08:34:12 -06:00
Joshua Peek
284fd2568d
Include cascade header in metal template
2010-01-22 08:31:41 -06:00
Joshua Peek
658f9e7e44
lib is already included w/ rake test task
2010-01-22 08:29:42 -06:00
Joshua Peek
5bf5688f51
Remove rdoc task from generated plugin Rakefile
2010-01-22 08:29:07 -06:00
Joshua Peek
259f3846a9
Template whitespace
2010-01-22 08:27:05 -06:00
José Valim and Mikel Lindsaar
951397b4a2
Get implicit multipart and attachments working together.
2010-01-22 14:38:41 +01:00
José Valim and Mikel Lindsaar
1cd55928c6
First work on implicit multipart.
2010-01-22 13:56:06 +01:00
José Valim and Mikel Lindsaar
dcb9253693
Add basic template rendering to new DSL.
2010-01-22 13:27:26 +01:00
Mikel Lindsaar
6cf378aeb0
Merge branch 'master' of github.com:mikel/rails
2010-01-22 21:58:13 +11:00
José Valim and Mikel Lindsaar
b30eb39ff0
Add more tests to new API.
2010-01-22 11:57:54 +01:00
Mikel Lindsaar
1170e70797
Merge branch 'master' of github.com:mikel/rails
2010-01-22 21:10:52 +11:00
José Valim and Mikel Lindsaar
bb9d71ff9e
Move class methods to deprecated stuff.
2010-01-22 11:10:37 +01:00
José Valim and Mikel Lindsaar
343ac48f45
Moved deprecated_body.rb to deprecatead_api.rb
2010-01-22 11:01:21 +01:00
Mikel Lindsaar
6fd7d1fc12
Fixing typo in config.frameworks error
2010-01-22 19:38:50 +11:00
Mikel Lindsaar
4443f4173b
Added more documentation on railtie.rb
2010-01-22 14:54:32 +11:00
José Valim and Mikel Lindsaar
8a6a2ca712
Merge branch 'master' of git://github.com/rails/rails
2010-01-22 13:37:29 +11:00
José Valim and Mikel Lindsaar
c9dc1ac95b
Updating functional tests to not compare equality with encoded, Mail::Message has an == operator
2010-01-22 13:32:16 +11:00
José Valim and Mikel Lindsaar
90bbed233e
Updating deprecated_body.rb to use :content instead of :data or :body in the params hash
2010-01-22 12:51:07 +11:00
José Valim and Mikel Lindsaar
77986f6bdb
Added use of AS::Notifications for tmail_compat.rb
2010-01-22 12:49:13 +11:00
José Valim and Mikel Lindsaar
12c001fec4
Updating deprecated API to sanitize old style attachments hash to work with new mail.attachments method
2010-01-22 12:46:19 +11:00
José Valim
02c5137ead
Add view paths to Engine setup.
2010-01-22 01:10:31 +01:00
Xavier Noria
8e4c7aaba8
removes that beloved typo you only catch in github colored diff
2010-01-21 23:52:10 +01:00
Xavier Noria
603112ee5d
rewords rdoc about :allow_nil in Module#delegate
2010-01-21 23:48:38 +01:00
Xavier Noria
6d70b93450
a hash has no final key
2010-01-21 23:47:05 +01:00
José Valim
7fcf8590e7
Massive cleanup in Railties and load stack.
2010-01-21 23:14:20 +01:00
Pratik Naik
6d30002a52
Revert "Refactoring attributes/types" [ #3348 state:open]
...
This reverts commit f936a1f100 .
Conflicts:
activerecord/lib/active_record.rb
activerecord/lib/active_record/base.rb
Revert "Fixed: #without_typecast should only disable typecasting on the duplicated attributes" [#3387 state:open]
This reverts commit 2831996483 .
Reason :
It's not generating attribute methods properly, making object.column 5x slower.
2010-01-22 02:37:07 +05:30
Pratik Naik
a68a3e9af6
Simplify finder method definitions
2010-01-21 22:29:21 +05:30
Prem Sichanugrist
2df1810cf3
Add test case for load initializers before routing behavior.
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-01-21 17:45:21 +01:00
José Valim
fc4f237864
Make filter parameters based on request, so they can be modified for anything in the middleware stack.
2010-01-21 16:52:49 +01:00
José Valim
04063393f9
Give higher priority to rails generators.
2010-01-21 14:11:24 +01:00
Pratik Naik
da142cd865
Supplying Arel::SqlLiteral is much faster
2010-01-21 17:52:09 +05:30
José Valim
378464a2e4
Default to sync instrumentation.
2010-01-21 13:09:12 +01:00
José Valim
dcb8b64975
Add shortcut test to abstract/render_test.rb
2010-01-21 12:12:10 +01:00
José Valim
48dc1ae309
Don't let generators die if rubygems puts crap in your load path.
2010-01-21 12:10:39 +01:00
José Valim
31fddf2ace
Tidy up new filter_parameters implementation.
2010-01-21 11:57:24 +01:00
Prem Sichanugrist
b1bc3b3cd3
Add deprecation warning for calling filter_parameter_logging ActionController::Base, and allow it to be configured in config.filter_parameters
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-01-21 11:41:31 +01:00
Prem Sichanugrist
bd4f21fbac
Move filter_parameter_logging logic out of the controller and create ActionDispatch::ParametersFilter to handle parameter filteration instead. This will make filteration not depending on controller anymore.
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-01-21 10:08:26 +01:00
José Valim and Mikel Lindsaar
3829f9ecfd
Adding tests for attachments['blah.rb'] = {} et al
2010-01-21 20:03:55 +11:00
Xavier Noria
32eea7a157
AS guide: updates docs for LoadError after 1a50d2e
2010-01-21 08:01:15 +01:00
José Valim and Mikel Lindsaar
fbdbac2b88
Merge branch 'master' of git://github.com/rails/rails
2010-01-21 11:42:22 +11:00
Pratik Naik
fa9f000246
Use quoted_table_name with arel.from() if no from values explicitly supplied. Arel seems to be spending a lot of time figuring out the FROM value otherwise.
2010-01-21 01:37:02 +05:30
Pratik Naik
798d2828dc
Cache quoted_table_name
2010-01-21 01:28:50 +05:30
Pratik Naik
24cc9e5b4f
Relation#spawn is basically clone + reset
2010-01-21 00:41:15 +05:30
Pratik Naik
8bdcb6f072
Always use table.* in the finder query unless specified
2010-01-21 00:40:38 +05:30
Sam Ruby
c8cba7db76
Add AD::Route#to_s
...
Signed-off-by: Joshua Peek <josh@joshpeek.com >
2010-01-20 10:56:27 -06:00
Pratik Naik
459e9b29d4
Use @limit_value and @offset_value instead of calling arel
2010-01-20 22:20:56 +05:30
Pratik Naik
8d31c9f3a0
Move update and update_all to Relation
2010-01-20 22:20:56 +05:30
Joshua Peek
93956a18e4
Only send filtered_env for notifications
2010-01-20 10:07:23 -06:00
Joshua Peek
87bcf1aa15
Request#filter_parameters and filter_env
2010-01-20 09:55:58 -06:00
Pratik Naik
f7d94cdc6d
Fix AP's AR integration tests warning
2010-01-20 20:40:20 +05:30
Pratik Naik
1fb78e3ed8
Base.merge_conditions is no longer needed
2010-01-20 20:37:17 +05:30
Joshua Peek
909443eab6
Expose last controller in rack env["action_controller.instance"]
2010-01-20 09:00:23 -06:00
Santiago Pastorino
d1ffc54c06
fixes the failure of config.plugins without :all option tests [ #3718 status:resolved]
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-01-20 15:02:13 +01:00
José Valim
6e26be6960
Move ActionController::Translation to AbstractController::Translation.
2010-01-20 15:02:13 +01:00
José Valim
8e2fd54b19
Bring normalize behavior to AbstractController::Rendering
2010-01-20 15:02:13 +01:00
Pratik Naik
8b9bfbe225
Dont delegate Relation#update to arel
2010-01-20 19:01:26 +05:30
José Valim and Mikel Lindsaar
d3da87ce77
Mail method accepting all headers set via the hash
2010-01-21 00:10:22 +11:00
Pratik Naik
f216fadc0e
Delegate delete_all to Relation
2010-01-20 18:33:14 +05:30
Pratik Naik
9756805676
Move destroy to Relation
2010-01-20 18:28:45 +05:30
Pratik Naik
223e2a2709
Remove Base.delete as it's same as Relation#delete
2010-01-20 18:24:36 +05:30
Pratik Naik
2493229674
Delegate exists? to Relation
2010-01-20 18:17:37 +05:30
José Valim and Mikel Lindsaar
c34cfcc29f
Created mail method for new API
2010-01-20 23:46:59 +11:00
Pratik Naik
8f0f02a166
Make Relation#destroy_all handle all the cases
2010-01-20 18:12:50 +05:30
José Valim and Mikel Lindsaar
10c509fbfa
Moved old API into deprecated_api.rb in preparation for new Rails 3 Mailer API
2010-01-20 22:26:24 +11:00
Mikel Lindsaar
8b37fee201
Merge branch 'master' of git://github.com/rails/rails
...
Conflicts:
actionmailer/lib/action_mailer/base.rb
2010-01-20 21:58:22 +11:00
Pratik Naik
8a1be22849
Use unscoped instead of with_exclusive_scope for preloading
2010-01-20 16:11:14 +05:30
Pratik Naik
5502780c69
Move array_of_strings? to Relation
2010-01-20 14:01:42 +05:30
Pratik Naik
394c05ed82
Remove stale methods constructing joins
2010-01-20 13:24:53 +05:30
Yehuda Katz
1a50d2e66a
Stop overriding LoadError.new to return a MissingSourceError (and sometimes nil!)
2010-01-19 22:35:26 -08:00
Joshua Peek
5ebfa62427
Revert streaming params parser support.
...
AS Xml and Json parsers expect the request body to be a real IO object
supporting methods like getc or ungetc which are not specified by the
Rack spec and aren't supported by Passenger or the Rewindable input
wrapper.
We can restore functionality if the AS parsers are rewritten to support
Racks subset of supported IO methods.
2010-01-19 22:56:38 -06:00
Joshua Peek
a5d06d05fb
Cleanup middleware introspection output
2010-01-19 22:56:37 -06:00
Mikel Lindsaar
c04baed627
Fixing failing test on sendmail expectation
2010-01-20 14:12:17 +11:00
Mikel Lindsaar
2a3ec5fee4
Updating gemspec to 2.0.1 for mail
2010-01-20 14:12:05 +11:00
Pratik Naik
565b4cd3e0
Scope#find is no longer needed now that Relation#find handles all the cases
2010-01-20 03:40:37 +05:30
Pratik Naik
52ec4311f5
Delegate all finders to Relation
2010-01-20 03:35:25 +05:30
Xavier Noria
2877e5c216
AS guide: documents Float#round
2010-01-19 22:45:41 +01:00
Pratik Naik
74e3539cda
Ignore order for simple calculations to make postgresql happy
2010-01-20 02:17:49 +05:30
José Valim
848d6cd46b
Mail should log when raise_delivery_methods is false.
2010-01-19 21:34:59 +01:00
Pratik Naik
d8c30723aa
Named scopes dont need count() now that Relation#count handles all the cases
2010-01-20 01:35:20 +05:30
Pratik Naik
1b78a3f8d5
with_scope no longer needs :reverse_merge
2010-01-20 01:29:18 +05:30
Pratik Naik
42553a98ea
Remove find_with_associations and related code from associations now that Relation handles that stuff
2010-01-20 01:20:20 +05:30
Prem Sichanugrist
6e62e89737
Fix bug that causes TimeZone.seconds_to_utc_offset to returns wrong offset when hour < 0 and not in hundreds [ #3741 status:resolved]
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-01-19 20:31:33 +01:00
José Valim
d2759d125a
Avoid load tasks from plugins recursively (so stuff in tests or vendor does not get loaded).
2010-01-19 20:07:50 +01:00
José Valim
4ca9765088
Allow railties to specify generators paths.
2010-01-19 19:59:08 +01:00
Pratik Naik
9acf0af544
Remove Relation#where_clause
2010-01-19 23:11:54 +05:30
Pratik Naik
dbce07b81d
Give preference to to_a over arel from Relation#method_missing
2010-01-19 22:52:08 +05:30
Pratik Naik
9465b84b54
Rename CalculationMethods to Calculations and get rid of the old Calculations module
2010-01-19 22:17:33 +05:30
Pratik Naik
8f63dcb648
Move the only remaining calculation method calculate() to Relation
2010-01-19 22:17:33 +05:30
José Valim
fef5afa962
Get rid of RAILS_ROOT deprecation on AM::TestCase.
2010-01-19 16:13:27 +01:00
José Valim
e8e8da5c85
Logging thread should not die on logging errors.
2010-01-19 16:13:27 +01:00
Pratik Naik
ec63fdcff3
Get rid of construct_count_options_from_args
2010-01-19 20:43:03 +05:30
Pratik Naik
73b179eb68
Delegate count to Relation
2010-01-19 20:37:12 +05:30
Joshua Peek
88ffba2329
Disable ShowExceptions during integration tests
2010-01-19 09:06:21 -06:00
José Valim
a8e25a518a
Move parameters to the top on logging.
2010-01-19 15:35:24 +01:00
José Valim
5a81dbf489
Fix failing test.
2010-01-19 15:35:23 +01:00
José Valim
4e2852a487
Do not send rack.input or any other rack information to AD listeners.
2010-01-19 15:35:23 +01:00
José Valim
e10f51b6b7
Refactor delivery methods.
2010-01-19 15:34:58 +01:00
Joshua Peek
bec5356f25
Define named routes for other non-GET REST actions
2010-01-19 08:23:23 -06:00
José Valim
f32e3aff5f
Merge branch 'master' of git://github.com/rails/rails
2010-01-19 14:29:11 +01:00
José Valim
c1848f9736
Get all tests passing.
2010-01-19 14:28:04 +01:00
Mikel Lindsaar
c8e2998701
First pass on fixing delivery method
2010-01-19 23:36:49 +11:00
Pratik Naik
9c7c7104f6
Fix the named scope equality check
2010-01-19 17:45:48 +05:30
Mikel Lindsaar
d201d39437
latest updates
2010-01-19 23:09:46 +11:00
Pratik Naik
4148c686ec
Delegate :average, :minimum, :maximum, :sum to Relation
2010-01-19 15:50:47 +05:30
Mikel Lindsaar
2107921000
Merge branch 'master' of git://github.com/rails/rails into rails
2010-01-19 21:05:37 +11:00
Pratik Naik
ed8501ef16
Fix DoubleRenderError error message
2010-01-19 15:23:56 +05:30
Pratik Naik
b9599502c9
Add Relation#construct_relation_for_association_calculations for calculations with includes
2010-01-19 15:22:09 +05:30
Mikel Lindsaar
eaae58ce0c
Merge branch 'master' of github.com:lifo/docrails
2010-01-19 19:41:15 +11:00
Mikel Lindsaar
c5acbcbb0f
Adding Rails 3.0 release notes
2010-01-19 19:39:13 +11:00
Mikel Lindsaar
83e5f2bbaa
remove newline
2010-01-19 19:38:47 +11:00
Pratik Naik
c71120e29c
Merge remote branch 'mainstream/master'
2010-01-19 13:40:26 +05:30
Mikel Lindsaar
087b67805e
Adding initial intro to railtie
2010-01-19 19:05:42 +11:00
Mikel Lindsaar
001c99e75e
Fix up spelling in railties/lib/rails/subscriber.rb docs
2010-01-19 17:09:21 +11:00
Joshua Peek
71d67fc6bd
Prettier hash dump
2010-01-18 21:22:09 -06:00
Joshua Peek
5579de5bab
Show Rack env dump on exception page
2010-01-18 21:12:17 -06:00
José Valim
f00cbf7872
Bring render_message back for 2.3 compatibility.
2010-01-19 01:36:07 +01:00
José Valim
a0374582ff
Bring body(Hash) behavior back.
2010-01-19 01:36:07 +01:00
José Valim
c7255386cd
script/generate mailer Notifier will now create a mailer at app/mailers.
2010-01-19 01:36:06 +01:00
José Valim
a18dd52d58
Get generators tests running on Ruby 1.9.1
2010-01-19 01:36:06 +01:00
José Valim
93d64dfefc
Improve script/generate help.
2010-01-19 01:36:06 +01:00
José Valim
e1029be1eb
Since Rails will require Ruby >= 1.8.7, we can rely on instance_exec.
2010-01-19 01:36:06 +01:00
Mikel Lindsaar
3cb0283fb6
Documentation cleanup and linkage for validator
2010-01-19 11:29:01 +11:00
Pratik Naik
e6a68a5cc3
Add Relation#find_with_associations to load relation with eager loaded associations
2010-01-19 04:42:19 +05:30
Joshua Peek
f2693cda44
Install plugin view paths into AM view load path
2010-01-18 16:48:04 -06:00
Xavier Noria
907754d7ee
AS guide: documents Object#extend_with_included_modules_from
2010-01-18 23:32:17 +01:00
Xavier Noria
cf82ddc96a
AS guide: documents Object#extended_by
2010-01-18 23:28:14 +01:00
Joshua Peek
59cd044310
Add all folders in app/* to the load path
2010-01-18 15:37:58 -06:00
Pratik Naik
9e7ec2a9f1
Simplify calculation scope building. Remove :order from associations as it is troublesome w/ calculation methods using postgresql.
2010-01-18 23:40:42 +05:30
Pratik Naik
3c4186b366
Remove construct_calculation_arel_with_included_associations because it's same as construct_finder_arel_with_included_associations
2010-01-18 23:40:42 +05:30
Pratik Naik
893524382a
No need to pass current_scoped_methods to construct_calculation_arel everytime
2010-01-18 23:40:42 +05:30
José Valim
728db5a932
Rake tasks should load generators from new paths.
2010-01-18 18:22:55 +01:00
Joshua Peek
68b76a38eb
Cleanup deprecation notices.
2010-01-18 09:49:38 -06:00
Paco Guzman
e27bfad6a5
Forgot to change named_scope to scope in an ArgumentError raise exception for duplication scopes related to commit d60bb0a9e4 [ #3736 status:resolved]
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-01-18 16:36:08 +01:00
José Valim
a2b76d1dde
Improve generators help.
2010-01-18 16:21:11 +01:00
José Valim
61f77b1dcd
More cleaning up on rails generators load path.
2010-01-18 16:21:11 +01:00
José Valim
9fffdc5cdb
Generators load path now will be Ruby load path. If you want to use rspec:install generator, you need generators/rspec/install_generator in your load path.
2010-01-18 16:21:11 +01:00
José Valim
e75ea47434
Automatically remove :generators: from namespaces.
2010-01-18 16:21:10 +01:00
José Valim
a2e2e73c5e
Ensure generators can be invoked by their shortcut and remove attr_reader tasks.
2010-01-18 16:21:10 +01:00
Pratik Naik
4c00c65c58
Simplify construct_finder_arel_* methods
2010-01-18 19:40:23 +05:30
Pratik Naik
2a2bc8e84a
Handle invalid query IN() generated when a blank array is supplied in hash conditions
2010-01-18 18:56:55 +05:30
Pratik Naik
8bb5274648
Get rid of Relation#order_clauses
2010-01-18 18:56:55 +05:30
Pratik Naik
8ba2902dd4
Fix the named_scope deprecation notice
2010-01-18 18:56:55 +05:30
José Valim
40c4a0036a
Ensure deprecated validate methods are invoked when they are private [ #3214 status:resolved]
2010-01-18 09:56:36 +01:00
Damien Mathieu
38c2e4687f
Missing rename from named_scope to scope [ #3735 status:resolved]
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-01-18 09:33:36 +01:00
Mikel Lindsaar
9aee365924
Adding ActiveModel::Validations documentation
2010-01-18 18:29:33 +11:00
Mikel Lindsaar
91c38403be
Adding documentation for ActiveModel::Translation
2010-01-18 18:13:49 +11:00
Mikel Lindsaar
71328a9856
Fixing up state machine docs
2010-01-18 17:20:25 +11:00
Gavin Stark
6e45bf53fb
Fixing documentation on ActiveModel::Observer#observed_classes
2010-01-18 00:21:45 -05:00
Nestor Ovroy
aa8cbb79dc
Partial Documentation for ActiveModel::StateMachine
2010-01-18 14:54:02 +10:00
Joshua Peek
c29bb8857e
Clear out AS callback method pollution in AC::Base.action_methods
2010-01-17 22:06:28 -06:00
Joshua Peek
58fe3295fe
Base#action_methods delegates to Base.action_methods
2010-01-17 21:51:07 -06:00
Joshua Peek
eeba755a11
Accessing nonexistant cookies through the signed jar should not raise an
...
exception
2010-01-17 21:31:06 -06:00
Pratik Naik
6ce538d485
Add missing CHANGELOG entry about relations as scopes
2010-01-18 04:42:04 +05:30
Pratik Naik
d60bb0a9e4
Rename named_scope to scope
2010-01-18 04:38:19 +05:30
Pratik Naik
e1d507c7fb
Dont check for class equaity when merging relations
2010-01-18 04:28:21 +05:30
Pratik Naik
88de6b2de2
Inherit named scope class Scope from Relation
2010-01-18 04:24:24 +05:30
Pratik Naik
c6850d8361
Ensure that Scope#proxy_scope is always klass. Rename proxy_scope to klass too.
2010-01-18 00:03:18 +05:30
Pratik Naik
dca3de3bc7
Make relations work as scopes
2010-01-17 23:22:11 +05:30
Pratik Naik
f0cde5be54
Make sure named_scope names are not used as method names already
2010-01-17 21:34:41 +05:30
Sam Elliott and Santiago Pastorino
5a6596787b
Module lookup issue on flash_test using ruby 1.9 solved [ #3716 status:resolved]
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-01-17 16:57:14 +01:00
Prem Sichanugrist
eb67532bc1
Make local_request? to returns true when facing ::1 IPv6 address [ #3257 status:resolved]
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-01-17 16:56:54 +01:00
Rizwan Reza
a0dc6cc70b
Fix RAILS_ROOT deprecation on guides generation. [ #3710 status:resolved]
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-01-17 16:28:31 +01:00
José Valim
44a10a2440
Fix resources_path_names branch which was sending an array as entity. [ #3715 status:resolved]
2010-01-17 16:18:14 +01:00
José Valim
58136e1bd3
Plugin generator should use templates.
2010-01-17 15:17:50 +01:00
Rizwan Reza
e3898bda9c
Take --skip-activerecord into account boot.rb requires. [ #3711 status:resolved]
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-01-17 14:55:11 +01:00
Rizwan Reza
cf109342a7
Fixes rake:template task [ #3714 status:resolved]
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-01-17 14:54:49 +01:00
Santiago Pastorino
8268d68b50
mail.create_path returns an array test fixed [ #3712 status:resolved]
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-01-17 14:54:06 +01:00
Samuel Elliott
31ea83eb89
Adding Proc support to validation messages so that they can become a little more dynamic, allowing for customisations during the request [ #3514 status:resolved].
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-01-17 14:40:10 +01:00
José Valim
c0d31ca41b
save(false) is gone, use save(:validate => false) instead.
2010-01-17 14:22:34 +01:00
Mikel Lindsaar
ccb7d9def3
Fixing up base to refactor settings
2010-01-17 23:27:59 +11:00
José Valim
020e656447
Move middleware builder back to Rails::Rack::Metal without losing the new behavior.
2010-01-17 13:23:38 +01:00
José Valim
27d9836ad3
Add ActionDispatch::Railties::Subscriber and finish tidying up the logging.
2010-01-17 12:43:17 +01:00
José Valim
61ada28ed3
Get rid of prepare_each_request, since now it's a middleware initialization parameter.
2010-01-17 11:44:04 +01:00
José Valim
8f5e733998
Add notifications to default middleware stack and update subscriber tests.
2010-01-17 11:35:48 +01:00
José Valim
0334f9f6cf
Add ActionDispatch::Notifications middleware.
2010-01-17 11:29:51 +01:00
Mikel Lindsaar
9a3a0d15fc
Updating mail require to 2.0.0
2010-01-17 21:02:38 +11:00
Mikel Lindsaar
a6831b95d6
Updating ActiveModel::Errors documentation to plug Translations and Validations modules
2010-01-17 20:22:14 +11:00
Mikel Lindsaar
19814df40d
Adding documentation for ActiveModel::Serialization
2010-01-17 20:14:14 +11:00
José Valim
afd0c06dfa
Validates needs hash slice.
2010-01-17 09:57:16 +01:00
José Valim
645832cfdd
Clean up filter parameter logging tests.
2010-01-17 09:54:24 +01:00
Pratik Naik
54a043895f
Make merging of order values consistent
2010-01-17 14:19:41 +05:30
Mikel Lindsaar
e6063282f9
Fixing documentation for ActiveModel::Observer
2010-01-17 19:12:12 +11:00
Mikel Lindsaar
fbc7c2beca
Adding ActiveModel::Naming documentation
2010-01-17 15:52:33 +11:00
Mikel Lindsaar
87bd8c803b
Update errors docs
2010-01-17 15:41:41 +11:00
Mikel Lindsaar
cf55e4e382
Added documentation for ActiveModel::Lint
2010-01-17 15:35:18 +11:00
Mikel Lindsaar
4d4bdb0766
Added ActiveModel::Errors documentation
2010-01-17 15:17:54 +11:00
Joshua Peek
f9a4300415
debug helper output should not be sanitized
2010-01-16 21:43:03 -06:00
Joshua Peek
eb39d0f7b9
Use backtrace cleaner for dev mode exception page
2010-01-16 21:34:35 -06:00
Mikel Lindsaar
6f663addaa
Merge branch 'master' of github.com:lifo/docrails
2010-01-17 12:46:51 +11:00
Mikel Lindsaar
8834b2612b
Adding ActiveModel::AttributeMethods documentation
2010-01-17 12:42:53 +11:00
Xavier Noria
3e94032227
AS guide: documents Class#descendents
2010-01-17 00:53:47 +01:00
Xavier Noria
32bbd61e06
AS guide: Object#subclasses_of also selects anonymous classes
2010-01-17 00:48:28 +01:00
Xavier Noria
28f31f5d62
AS guide: revises Class#reachable?
2010-01-17 00:46:26 +01:00
Xavier Noria
205b4c41b8
AS guide: documents Class#reachable?
2010-01-17 00:33:24 +01:00
Joshua Peek
d2d4acf027
Cookies middleware
2010-01-16 17:22:27 -06:00
Xavier Noria
043e876676
AS guide: revises section about Class#subclasses
2010-01-17 00:15:51 +01:00
Xavier Noria
0ec76099e0
AS guide: documents Object#subclasses_of
2010-01-17 00:07:08 +01:00
Xavier Noria
844b8e7797
AS guide: documents Object#remove_subclasses_of
2010-01-17 00:04:21 +01:00
Pratik Naik
8d87c80c19
Make Relation#reload force load the records immediately
2010-01-17 04:25:59 +05:30
Pratik Naik
7921a73acd
Use relations to build scope for named scopes
2010-01-17 04:20:11 +05:30
Pratik Naik
b8b6621acb
Simplify Model.scoped definition
2010-01-17 03:54:52 +05:30
Joshua Peek
603d4fbacd
Build middleware stack and reload routes after app initializers run
...
[#3709 state:resolved]
2010-01-16 16:15:32 -06:00
Pratik Naik
67920bc26c
Merge remote branch 'mainstream/master'
2010-01-17 03:26:54 +05:30
Pratik Naik
dba196cb7f
Merge docrails
2010-01-17 03:26:20 +05:30
Pratik Naik
b04230e3bb
Merge remote branch 'mainstream/master'
...
Conflicts:
actionpack/lib/action_controller/metal/flash.rb
2010-01-17 03:20:30 +05:30
Pratik Naik
6e3bee6cf1
Cache Model.arel_table
2010-01-17 03:14:17 +05:30
Pratik Naik
6806483b91
Use arel_table[] instead of unscoped[] to get arel attribute
2010-01-17 03:10:07 +05:30
Pratik Naik
0ab30637dd
Revert "Fix #microseconds conversion and #fast_string_to_time"
...
This reverts commit 717a2941e1 . Bunch of failures when running postgresql tests.
2010-01-17 03:04:11 +05:30
Pratik Naik
cd90dcb1bd
Rename Model.active_relation to Model.unscoped
2010-01-17 03:00:56 +05:30
Joshua Peek
e9a1dbe79a
Allow custom controller for resource(s) [ #3703 state:resolved]
2010-01-16 15:16:22 -06:00
Pratik Naik
468cfcedd3
Improve the error message for class mismatch on Relation#merge
2010-01-17 02:08:42 +05:30
Santiago Pastorino
867829b187
Missings do added to with_scope
2010-01-16 17:22:01 -02:00
Pratik Naik
7f8d4d3c4e
Get rid of Base#merge_includes
2010-01-16 23:59:57 +05:30
Ryan Bigg
e17b23db01
Make guides generation work for Ruby 1.9.x
...
Signed-off-by: Pratik Naik <pratiknaik@gmail.com >
2010-01-16 23:25:16 +05:30
Ryan Bigg
0fc6418e75
Mark title and headers as html_safe! for guides [ #3702 state:resolved]
...
Signed-off-by: Pratik Naik <pratiknaik@gmail.com >
2010-01-16 23:24:38 +05:30
Pratik Naik
07e41a8361
No need to set @arel_engine to nil twice. Committed by mistake in 3968825f
2010-01-16 23:17:14 +05:30
Pratik Naik
3968825f5f
Make sure Model#active_relation always adds STI conditions if needed
2010-01-16 23:11:35 +05:30
Pratik Naik
cfdfd89926
Use new finder methods for association preloading
2010-01-16 22:14:10 +05:30
Pratik Naik
f80be3ea0f
Use Relation#apply_finder_options from calculations
2010-01-16 22:05:01 +05:30
Pratik Naik
61e831564a
Add Relation#apply_finder_options for applying old finder options
2010-01-16 21:21:20 +05:30
Sam Granieri
488b4c8c5c
Make script/dbconsole work again [ #3690 state:resolved]
...
Signed-off-by: Pratik Naik <pratiknaik@gmail.com >
2010-01-16 20:55:22 +05:30
José Valim
92f49b5f1e
Split ActionDispatch http in smaller chunks.
2010-01-16 15:45:07 +01:00
Mikel Lindsaar
03c1457eb5
Removed autoload of DeliveryMethods
2010-01-16 14:02:55 +01:00
Mikel Lindsaar
0750304c01
Migrated over to Mail doing delivery.
2010-01-16 14:02:55 +01:00
Mikel Lindsaar
5b0c8a1266
Removing internal delivery agents
2010-01-16 14:02:55 +01:00
Mikel Lindsaar
e1c15d9fa1
fixed column alignment
2010-01-16 23:09:32 +11:00
Mikel Lindsaar
4a2d2ef91a
Adding RDoc for active_model dirty
2010-01-16 23:03:20 +11:00
Mikel Lindsaar
db274a02ed
Fixed readme for ActiveModel::Dirty
2010-01-16 22:21:07 +11:00
Pratik Naik
5a52523a80
Rename active_relation_engine -> arel_engine and active_relation_table -> arel_table
2010-01-16 16:02:30 +05:30
Chris Hapgood
717a2941e1
Fix #microseconds conversion and #fast_string_to_time
...
* Use direct integer parsing in #fast_string_to_time to avoid convoluted
conversions and errors due to truncation.
* Use Float#round in #microseconds to avoid truncation errors.
Signed-off-by: Michael Koziarski <michael@koziarski.com >
2010-01-16 15:21:36 +13:00
Pratik Naik
81cd11259c
Remove protected method Class#scoped?
2010-01-16 04:38:16 +05:30
Pratik Naik
2d0bc08a7e
Make type_condition return Arel predicate and not a string condition
2010-01-16 04:21:18 +05:30
Pratik Naik
99dd107760
Remove unused default_select
2010-01-16 04:21:18 +05:30
José Valim
b3c87746ef
Move I18n to gemspec and update dependencies.
2010-01-15 23:48:38 +01:00
José Valim
5a5760828b
Add tests for simple match with namespace.
2010-01-15 23:36:03 +01:00
José Valim
13d76b6170
Add some implicit path tests to Subscriber.
2010-01-15 23:36:03 +01:00
Joshua Peek
b2578a148c
Fix singleton resource named routes
2010-01-15 16:31:00 -06:00
Pratik Naik
2ee130abec
Remove scope related code from construct_join
2010-01-16 03:51:10 +05:30
Joshua Peek
89082004b0
Fix const reference for SessionRestoreError
2010-01-15 16:20:12 -06:00
Joshua Peek
6437eb9f35
Always join scoped paths with slashes
2010-01-15 16:13:01 -06:00
Joshua Peek
576b8dda52
Cleanup internal resource macro to use method helper shorthand
2010-01-15 16:13:01 -06:00
Pratik Naik
21ce8eac9b
Remove stale construct_* methods
2010-01-16 03:37:04 +05:30
Pratik Naik
951e485b88
Remove construct_conditions
2010-01-16 02:56:13 +05:30
Pratik Naik
6c997c3c39
Simplify Model.delete_all
2010-01-16 02:38:19 +05:30
Pratik Naik
c5f3811a49
Model.delete should just use scoped.delete
2010-01-16 02:35:53 +05:30
Joshua Peek
184ef28f55
Routing method shorthand shouldn't clobber :to options
2010-01-15 14:55:13 -06:00
Joshua Peek
ead93c5be5
Move Flash into middleware
2010-01-15 14:55:13 -06:00
Pratik Naik
3da29f647b
Remove AR#scope() method
2010-01-16 01:42:01 +05:30
Joshua Peek
3eaf525213
Make HEAD method masquerade as GET so requests are routed correctly
2010-01-15 12:38:50 -06:00
Pratik Naik
43a84a054f
Fix the query matching in SubscriberTest
2010-01-16 00:02:46 +05:30
Pratik Naik
bed9179aa1
Make scopes use relations under the hood
2010-01-16 00:02:46 +05:30
José Valim
1c30ec23fe
In heterogeneous collections, neither the @path nor the @template are available, so we need to tell that we are simply rendering a collection.
2010-01-15 17:43:45 +01:00
José Valim
a0cdfdc771
Allow f.submit to be localized per object.
2010-01-15 16:10:19 +01:00
José Valim
e5a2a9fced
Remove URI object from ActiveResource notification, send the :mailer class in AM (like in AP#process_action) and remove locale instrumentation.
2010-01-15 15:57:33 +01:00
José Valim
4598d88749
Ensure log is flushed and tailed on failures.
2010-01-15 14:16:52 +01:00
José Valim
5252f5c1c9
Bundle automatically if --dev or --edge is given as option.
2010-01-15 13:39:56 +01:00
José Valim
c905fce35f
Add message_id to AM payload and don't send bcc and cc if they were not sent.
2010-01-15 13:17:56 +01:00
José Valim
a5a9156b4e
Template rendering should include layout time.
2010-01-15 12:24:32 +01:00
José Valim
6487d2871c
Fix an issue where log was not being tailed in the first request.
2010-01-15 12:24:31 +01:00
José Valim
88dd60298e
Do not send the whole controller in notifications, cherry pick required pieces.
2010-01-15 12:24:31 +01:00
José Valim
704daad762
Ensure we just send Ruby Stdlib objects in ActionMailer notifications.
2010-01-15 12:24:31 +01:00
José Valim
6932f6751e
ActiveRecord should give the connection id as payload, and not the whole connection.
2010-01-15 12:24:31 +01:00
José Valim
7f4d8e3fbd
Yield the payload notifications for further modification (like adding the result).
2010-01-15 12:24:31 +01:00
José Valim
b0994be5bd
LogTailer should be invoked after all logs in threads were flushed.
2010-01-15 12:24:31 +01:00
José Valim
b4019d5080
Rails::Subscriber is now responsible for flushing all loggers it's responsible for.
2010-01-15 12:24:31 +01:00
José Valim
8b9bff9557
Small tweaks in ActionController subscriber messages format.
2010-01-15 12:24:31 +01:00
José Valim
8c8942ed4f
Move Dispatcher setup to Railties and add instrumentation hook.
2010-01-15 12:24:30 +01:00
Mikel Lindsaar
d1bedd182b
Updated README
2010-01-15 10:01:40 +11:00
Mikel Lindsaar
23e434f08f
ActiveModel::Conversion documentation
2010-01-15 08:29:08 +11:00
Mikel Lindsaar
582228e435
ActiveModel::Callbacks documentation
2010-01-15 08:19:53 +11:00
Joshua Peek
5a8e7287c5
Set a good example, no system ignores in project ignore file
2010-01-13 20:26:01 -06:00
Joshua Peek
be968ecd8b
Respect resources_path_names and :path_names options in new dsl
2010-01-13 20:26:01 -06:00
Joshua Peek
0f51e45307
optimise_named_routes is unnecessary
2010-01-13 20:22:53 -06:00
José Valim
9038a4af35
Add documentation to f.submit and make scaffold generators use the new shortcut.
2010-01-14 02:02:07 +01:00
José Valim
363545aa20
Different nested validations should not be ignore [ #3638 status:resolved]
2010-01-14 01:46:27 +01:00
José Valim
35933822de
Ensure optional path scopes are properly handled.
2010-01-14 01:31:17 +01:00
Stephen Celis
2835ec6134
Custom 'type' attribute support for text_field. [ #3646 status:resolved]
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-01-14 01:07:04 +01:00
José Valim
214b548485
Make check boxes accept :multiple as option so they can handle collections (such as HABTM).
2010-01-14 01:07:03 +01:00
José Valim
d50bf47b00
Call :to_model before working with the object.
2010-01-14 01:07:03 +01:00
Carlos Antonio da Silva
8e0208f650
Add possibility to use i18n translatios in submit FormHelper.
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-01-14 01:07:03 +01:00
José Valim
f921ad5c97
Tidy up ActiveRecord and Views runtime information on process action logger.
2010-01-14 01:07:03 +01:00
José Valim
116df09c3e
Add notifications to ActiveResource.
2010-01-14 01:07:03 +01:00
José Valim
7c3573f327
Add instrument! to notifications which adds the result to the payload.
2010-01-14 01:07:03 +01:00
José Valim
2a6bc1263e
Add subscriber to ActionMailer.
2010-01-14 01:07:03 +01:00
Joshua Peek
d01716731b
Add router support for resources :only and :except actions
2010-01-13 17:23:14 -06:00
Joshua Peek
5d787590f2
Cool this routing test passes now
2010-01-13 16:42:47 -06:00
Joshua Peek
bf9b81e2cb
Pass :as to resources to change the resource name
2010-01-13 12:18:06 -06:00
Joshua Peek
521ef3c40f
Passing in a crud action overloads the default action instead of creating a
...
new member action.
2010-01-13 11:45:27 -06:00
Xavier Noria
e396683244
adds missing fixed-width font
2010-01-13 16:29:54 +01:00
José Valim
01839834fd
ControllerRuntime tests also use Rails::Subscriber::TestHelper.
2010-01-13 01:19:24 +01:00
José Valim
b0d35ad00c
Test fragment/page cache and send data/file notifications.
2010-01-13 01:19:24 +01:00
José Valim
da5978c223
Add subscriber for ActionPack and move all logging inside it.
2010-01-13 01:19:23 +01:00
José Valim
8d78a82d79
Deprecate ActiveRecord::Base.colorize_logging.
2010-01-13 01:19:23 +01:00
José Valim
743cafb7f4
Create Rails::Subscriber::TestHelper and use it to make ActiveRecord subscriber tests run in both sync and async scenarios.
2010-01-13 01:19:23 +01:00
José Valim
dc2e291a93
Move AR logging responsibilities to ActiveRecord::Railties::Subscriber.
2010-01-13 01:19:23 +01:00
José Valim
fe3ceabeed
Set up subscriber on initialization.
2010-01-13 01:19:23 +01:00
José Valim
7f25ccf38d
Remove allow_concurrency and verification_timeout from ActiveRecord::Base (deprecated since 2.2).
2010-01-13 01:19:23 +01:00
José Valim
c464271e03
Get rid of old rails_info_controller.rb
2010-01-13 01:19:22 +01:00
José Valim
1a275730b2
Set deprecation warnings for RAILS_ENV and RAILS_DEFAULT_LOGGER.
2010-01-13 01:19:22 +01:00
José Valim
9dd4c79d61
Allow to add subscribers through Railtie.
2010-01-13 01:19:22 +01:00
José Valim
4704af763f
Do not send notifications when instrumentation raise an error.
2010-01-13 01:19:22 +01:00
José Valim
1e12dc04cb
Stub initial Rails::Subscriber implementation.
2010-01-13 01:19:22 +01:00
José Valim
5f34bd61b0
As the other constants, RAILS_DEFAULT_LOGGER no more.
2010-01-13 01:19:22 +01:00
José Valim
c4e3344a26
Revert "Add a generator_paths config option"
...
This reverts commit 8665c754cb .
2010-01-13 01:19:22 +01:00
José Valim
a5c45e69d9
Remove old bundler version from vendor.
2010-01-13 01:19:22 +01:00
Chad Woolley
b9a7ec6db5
reduce max size of fixture IDs to fix sqlite2 tests, because sqlite2 was getting negative and changing values for ID field. See http://www.sqlite.org/datatypes.html
...
Signed-off-by: Yehuda Katz <wycats@gmail.com >
2010-01-12 11:01:49 -08:00
Pratik Naik
006519d2c9
Use Relation#except for reversing the order
2010-01-12 22:55:57 +05:30
Pratik Naik
4938a5746d
Ensure using proper engine for Arel::Table
2010-01-12 22:37:26 +05:30
Pratik Naik
a04486dc99
Delay building arel relation as long as possible for improved introspection
2010-01-12 22:25:55 +05:30
José Valim
b078f7fd39
Fix typos and add tests to ensure they will be caught the next time.
2010-01-11 23:38:35 +01:00
José Valim
cccb998800
Expose connections available in the connection pool.
2010-01-11 23:38:18 +01:00
José Valim
d382e93d8f
Improve ActionPack logger output.
2010-01-11 23:38:17 +01:00
David Heinemeier Hansson
8cb594a2e1
Get everyone running on Rails.env and fix the broken environment settings for script/console and script/dbconsole
2010-01-11 14:01:28 -08:00
José Valim
a9eebde856
Merge branch 'master' of git://github.com/rails/rails
2010-01-11 15:18:24 +01:00
José Valim
c1239e6509
Send the connection in AR notifications to avoid checking out new connections in threads just for logging purposes.
2010-01-11 15:14:52 +01:00
José Valim
0a8004efd2
Provide useful information when instrumenting partials.
2010-01-11 10:21:15 +01:00
Joshua Peek
02bbde4e78
Cleanup junk metal and revise API
...
API Change: Returning a "X-Cascade: pass" header triggers the cascade
instead of a 404 response.
2010-01-10 23:09:10 -06:00
Joshua Peek
3921586091
Rewrite Metal tests
2010-01-10 22:33:34 -06:00
David Heinemeier Hansson
2c2b84f93c
Javascript tests expects the old default of escaping HTML, make it so for now
2010-01-10 18:25:17 -08:00
David Heinemeier Hansson
5ddc597066
Use safe_concat instead of trying to html_safe! what might be a frozen string
2010-01-10 18:13:43 -08:00
José Valim
d2e7c1b97d
Raise an error if respond_with is invoked and no format is declared.
2010-01-10 20:21:08 +01:00
José Valim
8d72ba51ba
Ensure nested namespaces work as expected.
2010-01-10 18:42:45 +01:00
Joao Carlos
36969c6ecd
Fixes namespaced routes [ #3673 status:resolved]
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-01-10 12:49:31 +01:00
David Heinemeier Hansson
d2c4a93c69
Have to remove the environment name from ARGV or IRB will freak out
2010-01-09 09:52:16 -08:00
Yehuda Katz
8665c754cb
Add a generator_paths config option
2010-01-09 11:04:06 -06:00
José Valim
7e6530b170
Merge remote branch 'eloy/master'
2010-01-09 00:23:29 +01:00
José Valim
017f5d5308
Fix typo by renaming :genre to :gender.
2010-01-09 00:18:07 +01:00
José Valim
93898b389b
Ensure new validates works with uniqueness validator.
2010-01-08 23:50:31 +01:00
David Heinemeier Hansson
d4589e96ef
Fixed that PrototypeHelper#update_page should return html_safe [DHH]
2010-01-08 13:46:30 -08:00
Jeffrey Hardy
652d1c19ea
Allow AR::Schema's migrations_path to be overwritten by subclasses. Defaults to 'db/migrate'
...
[#3671 state:committed]
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2010-01-08 13:08:23 -08:00
Eloy Duran
7f775ef1a9
Renamed AssociationReflection #collection_association? to #collection?.
2010-01-08 21:47:17 +01:00
Eloy Duran
f2aacd5140
Rollback the transaction when one of the autosave associations fails to save. [ #3391 state:resolved]
2010-01-08 21:45:02 +01:00
Lawrence Pit
5193fe9dd7
Exclude unchanged records from the collection being considered for autosave. [ #2578 state:resolved]
...
Signed-off-by: Eloy Duran <eloy.de.enige@gmail.com >
2010-01-08 21:45:02 +01:00
Bryan Stearns
1080351437
Add failing test that triggers the stack overflow
2010-01-08 21:45:02 +01:00
José Valim
802b08da00
Mailer should give self as payload because it contains all the information needed (as the template rendered and the mailer name).
2010-01-08 21:36:04 +01:00
José Valim
7045c4c279
Allow validates to map some types to specific options. So now you can do:
...
validates :email, :presence => true, :format => /@/
validates :genre, :inclusion => %w(m f)
validates :password, :length => 6..20
2010-01-08 21:36:04 +01:00
José Valim
fa14d6d51e
Compile length validator options still at the class level, so whenever the validator is called, it just needs to check for :maximum, :minimum and :is values.
2010-01-08 21:36:04 +01:00
David Heinemeier Hansson
188d52165b
Fixed that much of DateHelper wouldn't return html_safe? strings [DHH]
2010-01-08 11:49:12 -08:00
Eloy Duran
c7319f5fa0
Fixed french sentence so it actually makes sense.
2010-01-08 13:29:24 +01:00
David Heinemeier Hansson
5ea130943e
Fixed that fragment caching should return a cache hit as html_safe (or it would all just get escaped) [DHH]
2010-01-07 17:45:32 -08:00
Mikel Lindsaar
1ddf17dff0
Return-Path per RFC needs '<' and '>' around the addr_spec
2010-01-08 12:17:12 +11:00
Jeremy Kemper
8087d51842
Liberalize picky test
2010-01-07 17:08:02 -08:00
Jeremy Kemper
1ca9c26301
Merge remote branch 'mikel/master'
2010-01-07 16:59:23 -08:00
Jeremy Kemper
ee85f15453
Qualify constant lookup in BasicObject
2010-01-07 16:43:25 -08:00
Mikel Lindsaar
82407f94aa
Merge branch 'master' of github.com:mikel/rails
...
Conflicts:
actionmailer/actionmailer.gemspec
actionmailer/lib/action_mailer/vendor/text-format-0.6.3/text/format.rb
2010-01-08 11:17:04 +11:00
Mikel Lindsaar
e2aa6712a1
Updating mail require
2010-01-08 11:13:46 +11:00
Jeremy Kemper
4300f94533
Revert "Remove connection method definition, since it's called just once."
...
Restore the connection method which was added so it can be overridden.
This reverts commit e428c75d2b .
2010-01-07 13:30:51 -08:00
José Valim
3022ce4f72
No more hacks to ensure generators are executed inside Rails.root.
2010-01-07 21:24:50 +01:00
José Valim
ccc9f0b7de
Ensure application names are not singularized.
2010-01-07 21:09:32 +01:00
Joshua Peek
8fe66f1af0
Run railtie and plugin initializers before app specific ones
2010-01-07 14:01:34 -06:00
José Valim
19e7c524d2
Ensure config/application.rb also uses app_const instead of app_name.classify.
2010-01-07 20:59:26 +01:00
José Valim
423e2acbb7
Merge remote branch 'eloy/master'
2010-01-07 20:13:07 +01:00
José Valim
47a5fd4c4b
Allow :if, :unless, :on, :allow_nil and :allow_blank as shared options in validates.
2010-01-07 19:23:59 +01:00
jamie
0a79eb7889
Add validates method as shortcut to setup validators for a given set of attributes:
...
class Person < ActiveRecord::Base
include MyValidators
validates :name, :presence => true, :uniqueness => true, :length => { :maximum => 100 }
validates :email, :presence => true, :email => true
end
[#3058 status:resolved]
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-01-07 19:23:59 +01:00
Jeffrey Hardy
2dcc53bdbc
Remove stray semicolon from cookie_verification_secret initialzer template
2010-01-07 11:51:54 -05:00
Jeffrey Hardy
f8352ec255
Align assignments in the session_store initializer template
2010-01-07 11:46:55 -05:00
José Valim
3b631df101
Ensure that segments in default_url_options also work with format specified.
2010-01-07 17:17:06 +01:00
José Valim
f149eb19d4
From now on, parameters defined in default_url_options can be absent from named routes.
...
This allows the following setup to work:
# app/controllers/application_controller.rb
class ApplicationController
def default_url_options(options=nil)
{ :locale => I18n.locale }
end
end
# From your views and controllers:
I18n.locale #=> :en
users_url #=> "/en/users"
users_url(:pl) #=> "/pl/users"
user_url(1) #=> "/en/users/1"
user_url(:pl, 1) #=> "/pl/users/1"
user_url(1, :locale => :pl) #=> "/pl/users/1"
If you provide all expected parameters, it still works as previously.
But if any parameter is missing, it tries to assign all possible ones
with the hash returned in default_url_options or the one passed straight
to the named route method.
Beware that default_url_options in ApplicationController is not shared
with ActionMailer, so you are required to always give the locale in your
email views.
2010-01-07 15:34:14 +01:00
José Valim
f564f947d9
Remove duplicated url_for code and move methods shared between ActionMailer and ActionController up to AbstractController.
2010-01-07 15:31:50 +01:00
José Valim
598456b68b
Updated the documentation for helpers.label.
2010-01-07 15:31:50 +01:00
José Valim
a25ef06956
Allow to specify default attributes names translation in I18n yml files.
...
For example, you could easily specify :created_at and :updated_at translations as:
en:
attributes:
created_at: "Created at"
updated_at: "Updated at"
This configuration is built on ActiveModel, so it means those translations are
shared between different ORMs as well (but always as a fallback).
2010-01-07 15:31:50 +01:00
José Valim
b0572ab2b6
Be sure to dup load paths before clearing the array.
2010-01-07 15:31:50 +01:00
José Valim
c68cc49dcd
Use helpers.label instead of views.labels.
2010-01-07 15:31:50 +01:00
José Valim
a091e2e4f6
errors in ActionView should not be namespaced as well.
2010-01-07 15:31:50 +01:00
José Valim
821a160a49
Add a deprecation message to activerecord.errors.
2010-01-07 15:31:49 +01:00
José Valim
190ce3ab37
Errors messages are now moved from :activerecord.errors to simply :errors on I18n yml files.
2010-01-07 15:31:49 +01:00
Eloy Duran
9550916903
Raise a RecordNotFound if an ID in nested attributes is given but doesn't return a record. [ #2415 state:resolved]
2010-01-07 13:19:49 +01:00
Eloy Duran
b6264c43f4
Moved the validation logic to the association reflection and refactored autosave_association.rb a bit.
2010-01-07 13:19:48 +01:00
Eloy Duran
fc6aae3459
Remove deprecated '_delete' option from NestedAttributes.
2010-01-07 13:19:48 +01:00
Eloy Duran
a559260e41
Removed unnecessary call to #try and cleaned up a bit more.
2010-01-07 13:19:48 +01:00
Eloy Duran
f866ced24a
Don't use strings for callbacks, as these will be evaled. Rather use symbols, which uses a direct method dispatch.
...
Patch by Comron Sattari. [#3429 state:resolved]
2010-01-07 13:19:48 +01:00
Eloy Duran
2171e0a1d1
Cleanup some code in nested_attributes.rb, autosave_association.rb, and associations.rb with AssociationReflection#collection_association?
...
Also cache the result value.
2010-01-07 13:19:48 +01:00
Eloy Duran
f82adc7c5a
Add AssociationReflection#collection_association? which returns true if it's for a has_many or has_and_belongs_to_many association.
2010-01-07 13:19:48 +01:00
Eloy Duran
1afa9fa5a9
Refactored nested attributes a bit around :reject_if => :all_blank.
2010-01-07 13:19:48 +01:00
Jeremy Kemper
a323b83acf
Remove unneeded reliance on super -> method_missing quirk
2010-01-07 00:06:20 -08:00
Jeremy Kemper
816ba1e15a
Remove unneeded reliance on Numeric#round quirk
2010-01-06 23:35:03 -08:00
José Valim
74f6ccea20
instrumenter should be accessible from ActiveSupport::Notifications.
2010-01-06 22:24:16 +01:00
José Valim
0c2d933f36
Ensure before_validation and after_validation accepts :on as option.
2010-01-06 22:24:16 +01:00
Jeffrey Hardy
cfe0fcae06
Fix failing app generator test when using the --dev option
2010-01-06 14:22:51 -05:00
Jeffrey Hardy
caad6c634c
Restore require of 'active_record/fixtures' for Rake tasks that use them
2010-01-06 13:58:27 -05:00
Jeffrey Hardy
894ce15534
Use better defaults for fixtures: transactional=true, instantiated=false
...
These reflect the settings that were previously included in the default
test_helper.rb, removed in d7d9173 .
2010-01-06 13:38:11 -05:00
Jeffrey Hardy
891ba18d65
Update db:migrate error message to reflect the removal of config.frameworks
2010-01-06 13:37:45 -05:00
Jeffrey Hardy
8a41b710f6
Fix spacing on frameworks error message
2010-01-06 13:37:11 -05:00
Joshua Peek
88fd569ba0
Remove config.gem deprecation stub since its not "deprecated" but
...
completely removed.
This makes feature detection easier with config.respond_to?(:gem)
2010-01-06 11:33:04 -06:00
José Valim
0d5ce7c525
namespace in routes changes both the path and name prefix.
2010-01-06 09:51:46 +01:00
José Valim
e4099c2ad3
Allow named routes to be debugged.
2010-01-06 09:32:29 +01:00
Joshua Peek
bbe80ae652
config.plugins should still work with an array of strings
2010-01-05 23:37:40 -06:00
José Valim
10389a4c29
Ruby 1.9.1 requires hash given to foormat to contain symbols.
2010-01-06 00:42:58 +01:00
José Valim
0cf190001e
Remove CGI.escape in function of Rack::Mount.escape
2010-01-06 00:33:17 +01:00
José Valim
e55d70a380
redirect in routes takes port into account [ #3653 status:resolved]
2010-01-05 23:40:56 +01:00
Joshua Peek
b3900a29eb
All router redirect helper to accept a full URI [ #3653 state:resolved]
2010-01-05 12:00:38 -06:00
Joshua Peek
8ff4faf66a
assert_template depends on AV::Template monkey patches in action_view/test_case
2010-01-05 11:48:06 -06:00
David Heinemeier Hansson
2dc5aeed6d
NumberHelper#number_to_currency should output html_safe strings so the units are not escaped
2010-01-05 08:22:17 -08:00
Dan Croak
38f669766c
Rails layouts, error pages, and public/index now use HTML5.
...
The specification allows the character encoding meta tag to be removed
if character encoding is set at the transport level (Content-Type),
which Rails is doing.
http://dev.w3.org/html5/html4-differences/#character-encoding
Signed-off-by: Joshua Peek <josh@joshpeek.com >
2010-01-05 10:13:29 -06:00
Jeremy Kemper
5c527c2f61
Controller tests should always require view tests since they add behavior controllers expect
2010-01-04 19:44:27 -08:00
Joshua Peek
3f28e0bda6
Trash string coercion rack hacks
2010-01-04 19:46:21 -06:00
Joshua Peek
76b5f18feb
Default middleware stack needs to be available at configuration time
2010-01-04 19:40:16 -06:00
Joshua Peek
56b28ec8d6
Middleware configuration tests
2010-01-04 19:40:16 -06:00
Jeremy Kemper
6591a10b1f
Reinstate explicit active_support/test_case require since console_app interacts with a non-autoloaded constant
2010-01-04 17:00:47 -08:00
Carlhuda
952e449fc0
Fix --dev option
2010-01-04 16:32:43 -08:00
Joshua Peek
17f053931e
use_instantiated_fixtures and use_transactional_fixtures defaults are set in active_record/fixtures
2010-01-04 17:23:36 -06:00
Joshua Peek
947bbc170e
Smoke test for test_help
2010-01-04 17:13:45 -06:00
Joshua Peek
508ffccfe7
rack and rack-test are pulled in by AD
2010-01-04 16:55:27 -06:00
Joshua Peek
e5ed62deea
Autoload AR test case
2010-01-04 16:50:01 -06:00
Joshua Peek
640d9e7e32
Autoload AMo test case
2010-01-04 16:29:07 -06:00
Joshua Peek
2601a16ede
Autoload AS test case
2010-01-04 16:22:46 -06:00
Joshua Peek
ce56c36cd3
Autoload AM test case class
2010-01-04 16:22:46 -06:00
Joshua Peek
cf83a6f16b
Autoload AC and AV test case classes
2010-01-04 16:22:46 -06:00
José Valim
45462c5e41
Expose Instrumenter id in Notifications.
2010-01-04 23:05:28 +01:00
José Valim
562a00ba16
@_formats initialization should be AbstractController::Base.
2010-01-04 23:05:28 +01:00
José Valim
bd729344a7
Remove deprecated formatted named routes
2010-01-04 23:05:27 +01:00
Zach Brock
79438b4638
adding fix for auto linking to master too
...
Signed-off-by: Michael Koziarski <michael@koziarski.com >
2010-01-05 10:57:20 +13:00
Joshua Peek
ae270f597d
Remove rack submodule, 1.1 has been released as a gem.
2010-01-04 10:09:10 -06:00
David Heinemeier Hansson
5e94d3e3ea
Merge
2010-01-03 22:27:28 -08:00
David Heinemeier Hansson
d7d917335e
Stop featuring ActiveSupport::TestCase.use_instantiated_fixtures and ActiveSupport::TestCase.use_transactional_fixtures as likely-to-change settings in test/test_helper.rb -- they are not and their values are already set in test_help.rb [DHH]
2010-01-03 19:55:21 -08:00
David Heinemeier Hansson
437df4a8d3
Describe intent, not implementation
2010-01-03 19:46:10 -08:00
David Heinemeier Hansson
0ad07d9c26
Removed config/initializers/new_rails_defaults.rb as all frameworks now follow the settings from it [DHH]
2010-01-03 19:32:48 -08:00
David Heinemeier Hansson
1459c8cc1d
Changed ActiveRecord::Base.store_full_sti_class to be true by default reflecting the previously announced Rails 3 default [DHH]
2010-01-03 19:30:28 -08:00
David Heinemeier Hansson
6042067c0b
Changed the default ActiveSupport.use_standard_json_time_format from false to true and
...
ActiveSupport.escape_html_entities_in_json from true to false to match previously announced Rails 3 defaults [DHH]
2010-01-03 19:20:43 -08:00
David Heinemeier Hansson
532b11690f
Change the ActiveModel::Base.include_root_in_json default to true for Rails 3 [DHH]
2010-01-03 22:02:10 -05:00
David Heinemeier Hansson
0422314b29
Time zoning should be turned on by default with UTC
2010-01-03 21:55:48 -05:00
David Heinemeier Hansson
51460b5bf2
This comment has been true of all helpers for a long time
2010-01-03 21:34:19 -05:00
David Heinemeier Hansson
950e6bb491
Remove self-evident comment about how subclasses work
2010-01-03 21:32:40 -05:00
David Heinemeier Hansson
090d12b49b
Added that ActionController::Base now does helper :all instead of relying on the default ApplicationController in Rails to do it [DHH]
2010-01-03 21:32:02 -05:00
José Valim
eca11bfdb5
Merge branch 'master' of git://github.com/rails/rails
2010-01-04 01:05:19 +01:00
José Valim
b0947bf97c
Bring generators tests back to life.
2010-01-04 00:31:53 +01:00
José Valim
3990310a2b
Use underscore in notification namespaces.
2010-01-04 00:03:56 +01:00
José Valim
f2d276fefd
Ensure no notification is on the queue before running notifications related tests.
2010-01-03 23:39:09 +01:00
José Valim
53c6984944
Add notifications to ActionDispatch::ShowExceptions, this can be used as hooks for plugins like ExceptionNotifier.
2010-01-03 23:33:34 +01:00
Pratik Naik
a68165833a
Add Relation#create_with to explictily specify create scope
2010-01-04 03:50:16 +05:30
Pratik Naik
cda36a0731
Merge remote branch 'mainstream/master'
2010-01-04 03:24:39 +05:30
Pratik Naik
a115b5d79a
Ensure using proper engine for Arel::Table
2010-01-04 02:05:18 +05:30
José Valim
6fbe9ef2ff
Use namespaces in notifications.
2010-01-03 20:39:42 +01:00
José Valim
4796be33a4
Add missing tests to Validators.
2010-01-03 17:14:50 +01:00
José Valim
271e7c803f
Move all generators tests to use new test case syntax.
2010-01-03 17:14:50 +01:00
José Valim
441227a10f
Create Rails::Generators::TestCase.
2010-01-03 17:14:49 +01:00
José Valim
e88ea3255f
Assert for valid application names. [ #3556 status:resolved]
2010-01-03 17:14:49 +01:00
José Valim
6716e4bc0c
Use regexp in lookups instead of traversing namespaces. This removes the need of special cases.
2010-01-03 17:14:48 +01:00
Pratik Naik
00f3f6dc31
Relation#merge and Relation#except should respect locks
2010-01-03 21:25:19 +05:30
Pratik Naik
3db876cb76
Relation#merge and Relation#except should respect havings
2010-01-03 20:50:04 +05:30
Pratik Naik
af5e1b4cc6
Add Relation#except
2010-01-03 19:43:29 +05:30
Pratik Naik
22bfd8b098
Rename a variable name for consistency
2010-01-03 19:20:40 +05:30
Pratik Naik
8edfa8f82f
Move Relation#spawn and Relation#merge to a separate module
2010-01-03 18:57:57 +05:30
Pratik Naik
3eca0ab838
Give preference to the second relation's order when merging
2010-01-03 18:52:30 +05:30
Xavier Noria
bd4a3cce4e
removes warning in multiple_of? that is no longer needed after 7a2554d
2010-01-03 11:15:25 +01:00
Stefan Penner
d531cbc809
fixed missing or incorrect session data error message
2010-01-02 23:01:06 -08:00
Yehuda Katz
106d8f7688
AppName::Application.root should work
2010-01-02 22:49:40 -08:00
Yehuda Katz
f1cd3a98f3
Doc fix
2010-01-02 22:46:09 -08:00
Mikel Lindsaar
42aa9b87c2
Silence warnings
2010-01-02 22:39:00 -08:00
Mikel Lindsaar
bf6d0e2bc2
Updating to Mail 1.5.0, including default values for all Message#field_name methods, can access field objects by calling Message#[:field_name]
2010-01-02 22:39:00 -08:00
Pratik Naik
4939f95c9b
Reapply "Remove optional join_dependency argument as Relation always supplies it" - Now without syntax errors
2010-01-03 11:08:57 +05:30
Jeremy Kemper
7ad7c82caf
Skip isolation test tests until they work
2010-01-02 20:29:47 -08:00
Xavier Noria
7a2554d9a3
Let Integer#multiple_of? accept zero as argument
...
[#2982 state:committed]
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2010-01-02 20:25:15 -08:00
Jeremy Kemper
8571aa613f
Revert "Remove optional join_dependency argument as Relation always supplies it"
...
This reverts commit 8e57deed8b .
2010-01-02 18:39:36 -08:00
Mikel Lindsaar
fcf2dd3352
Merge branch 'master' of github.com:mikel/rails
2010-01-03 11:24:04 +11:00
Mikel Lindsaar
ffcd356771
Updating to Mail 1.5.0, including default values for all Message#field_name methods, can access field objects by calling Message#[:field_name]
2010-01-03 11:15:50 +11:00
Steve Agalloco
c3d19eb950
app_generator option should be skip_activerecord not no_activerecord
...
(Thor actually accepts both, the patch was applied to improve readability)
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-01-03 00:47:01 +01:00
Mikel Lindsaar
5867f9516d
Silence warning of missing init on @config
2010-01-03 10:17:30 +11:00
Mikel Lindsaar
a009239092
Silence @text not initialized warning
2010-01-03 10:17:30 +11:00
Xavier Noria
f95b12c3f3
AS guide: documents the file where each method is defined to allow cherry-picking (rest)
2010-01-03 00:00:11 +01:00
Xavier Noria
9c28fdaf88
Regexp#(un)optionalize are also gone
2010-01-02 23:49:55 +01:00
Xavier Noria
1a95f44f21
Regexp#number_of_captures is gone
2010-01-02 23:47:34 +01:00
Xavier Noria
37c76c13da
AS guide: documents the file where each method is defined to allow cherry-picking (covers up to Hash)
2010-01-02 23:46:26 +01:00
Pratik Naik
8e57deed8b
Remove optional join_dependency argument as Relation always supplies it
2010-01-03 04:09:36 +05:30
Pratik Naik
47da00e94b
Further simplify Relation#references_eager_loaded_tables?
2010-01-03 03:58:34 +05:30
Pratik Naik
e9ebf8b898
Cache Relation#to_sql
2010-01-03 03:56:21 +05:30
Pratik Naik
0d1a2a3c22
Remove unused code from association.rb now that Relation takes care of checking the referenced tables
2010-01-03 03:49:10 +05:30
Pratik Naik
eb7fdb9464
Make Relation#includes behave exactly like the existing :include option
2010-01-03 03:46:08 +05:30
Pratik Naik
6f5f23aaa7
Add Relation#includes to be an equivalent of current finder option :include
2010-01-03 03:24:28 +05:30
Xavier Noria
a9426eb711
AS guide: documents the file where each method is defined to allow cherry-picking (covers up to String)
2010-01-02 22:52:33 +01:00
Pratik Naik
c51347152a
Get rid of Model.construct_finder_arel_with_includes. Use construct_finder_arel instead
2010-01-03 03:08:01 +05:30
Pratik Naik
a9c790e10f
Simply methods for checking eager loaded tables references in the query
2010-01-03 03:00:30 +05:30
José Valim
4c5b5024c3
Rails notifications are set through Railtie in each framework.
2010-01-02 22:27:03 +01:00
José Valim
08986ce290
Remove deprecated ActiveModel tests (%d and %s is no longer supported in error messages a couple months already)
2010-01-02 22:27:03 +01:00
José Valim
fd719d7ecf
Update vendored Thor.
2010-01-02 22:27:03 +01:00
José Valim
f50bb48e04
Do not enforce human_attribute_name as required API.
2010-01-02 22:27:03 +01:00
Carsten Gehling
bef968d379
I18n label helper [ #745 status:resolved]
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-01-02 22:27:02 +01:00
José Valim
653fa4c10c
Add naming to AMo::Lint
2010-01-02 22:27:02 +01:00
José Valim
7cc0a4cfa1
Use activerecord.errors.format as in Rails 2.3.5.
2010-01-02 22:27:02 +01:00
José Valim
5fdd0e80a4
Be sure to convert namespaced names to we have 'Parrots name' instead of 'Parrots.name' in error messages.
2010-01-02 22:27:02 +01:00
José Valim
dcafe995bf
Make nested attributes behave like in 2.3.5 and add a sanity test for it with I18n.
2010-01-02 22:27:02 +01:00
Pratik Naik
ac1df91e5e
Implement Relation#create and Relation#create!
2010-01-03 00:16:14 +05:30
Pratik Naik
65200d2933
Implement Relation#new
2010-01-03 00:08:59 +05:30
Pratik Naik
32b48bf419
Use arel predicates instead of strings wherever possible when merging relations
2010-01-02 22:43:40 +05:30
Pratik Naik
f1acf1cc74
Give higher preference to second relation's equality predicates when merging
2010-01-02 21:16:16 +05:30
Pratik Naik
3e6e3e90ef
Remove the test which was testing a non-existing method, always failing on 1.9 and never even running on 1.8
2010-01-02 16:12:01 +05:30
Pratik Naik
7ff131f740
Make sure not to spalt string arguments
2010-01-02 13:43:50 +05:30
Xavier Noria
abae712213
fixes a couple of wrong requires
2010-01-01 14:28:57 -08:00
Xavier Noria
9ab528df8d
nokogiri.rb needs active_support/core_ext/object/blank
2010-01-01 14:28:57 -08:00
Xavier Noria
2d233ebdcf
libxml.rb needs active_support/core_ext/object/blank
2010-01-01 14:28:57 -08:00
Xavier Noria
173f828760
jdom.rb needs active_support/core_ext/object/blank
2010-01-01 14:28:57 -08:00
Xavier Noria
388dde9f9d
time_with_zone.rb needs active_support/core_ext/object/acts_like
2010-01-01 14:28:57 -08:00
Xavier Noria
606203c034
testing/performance.rb needs active_support/core_ext/string/inflections because it uses demodulize
2010-01-01 14:28:56 -08:00
Xavier Noria
0e5b9d7d7d
rescuable.rb needs active_support/core_ext/array/extract_options
2010-01-01 14:28:56 -08:00
Xavier Noria
bddf0a6fd3
rescuable.rb needs active_support/core_ext/string/inflections because it uses constantize
2010-01-01 14:28:56 -08:00
Xavier Noria
b7afaa08bf
message_verifier.rb needs active_support/core_ext/object/blank
2010-01-01 14:28:56 -08:00
Xavier Noria
679acfbefd
message_verifier.rb needs active_support/base64
2010-01-01 14:28:56 -08:00
Xavier Noria
d26d671e38
message_encriptor.rb needs active_support/base64
2010-01-01 14:28:56 -08:00
Xavier Noria
f15313c0c8
duration.rb needs active_support/core_ext/object/acts_like
2010-01-01 14:28:56 -08:00
Xavier Noria
e7c08c1e29
method_wrappers.rb needs active_support/core_ext/array/extract_options
2010-01-01 14:28:56 -08:00
Xavier Noria
9036bf82c6
to_param.rb needs active_support/core_ext/object/to_query
2010-01-01 14:28:56 -08:00
Xavier Noria
cbab9c0347
extending.rb needs active_support/core_ext/object/blank
2010-01-01 14:28:56 -08:00
Xavier Noria
7f17b23aea
extending.rb needs active_support/core_ext/class/removal because it uses reachable?
2010-01-01 14:28:56 -08:00
Xavier Noria
4d2f0d2287
synchronization.rb needs active_support/core_ext/array/extract_options
2010-01-01 14:28:56 -08:00
Xavier Noria
8ae9ef75f3
loading.rb needs active_support/core_ext/string/inflections because it uses underscore
2010-01-01 14:28:56 -08:00
Xavier Noria
7ba8c9e78e
hash/conversions.rb needs active_support/core_ext/string/inflections because it uses singularize and a few others
2010-01-01 14:28:55 -08:00
Xavier Noria
e6385a912a
hash/conversions.rb needs active_support/core_ext/object/blank because it uses blank?
2010-01-01 14:28:55 -08:00
Xavier Noria
2f9fc1fe01
date_time/calculations.rb needs active_support/core_ext/object/acts_like because it uses acts_like?
2010-01-01 14:28:55 -08:00
Xavier Noria
44f9813344
date/calculations.rb needs active_support/core_ext/object/acts_like because it uses acts_like?
2010-01-01 14:28:55 -08:00
Xavier Noria
5b295a65c3
callbacks.rb needs active_support/core_ext/object/metaclass because it uses metaclass
2010-01-01 14:28:55 -08:00
Xavier Noria
3337da9e94
cache.rb requires active_support/core_ext/string/inflections because it uses camelize
2010-01-01 14:28:55 -08:00
Xavier Noria
13168e6594
requires active_support/inflector/methods active_support/core_ext/string/inflections in local_cache.rb because it uses underscore
2010-01-01 14:28:55 -08:00
Xavier Noria
f1e34cc41d
requires active_support/core_ext/array/extract_options in mem_cache_store.rb because it uses extract_options!
2010-01-01 14:28:55 -08:00
Xavier Noria
7f7f5d619a
requires active_support/gzip in CompressedMemCacheStore because it uses ActiveSupport::Gzip
2010-01-01 14:28:55 -08:00
Xavier Noria
da97b51fdf
requires active_support/core_ext/hash/keys in benchmarkable because it uses assert_valid_keys
2010-01-01 14:28:55 -08:00
Xavier Noria
39667c846b
make sure returning is available for the libxml extension
2010-01-01 14:28:55 -08:00
Xavier Noria
a2595a1f0f
delegating_attributes.rb does not use duplicable
2010-01-01 14:28:55 -08:00
Xavier Noria
4a27d42637
require cgi to reopen it, not technically needed but makes sense
2010-01-01 14:28:55 -08:00
Pratik Naik
4a7a14b0e1
Use relations to build uniqueness conditions
2010-01-02 03:46:08 +05:30
Pratik Naik
498fddc714
Fix join string for the WHERE clause
2010-01-02 03:20:52 +05:30
Willem van Bergen
689984ddd3
Fixed some bugs and fixed some tests in new SAX-based XmlMini backends.
...
[#3636 state:committed]
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2010-01-01 13:18:03 -08:00
Willem van Bergen
96a2b3905c
Added SAX-based parser for XmlMini, using LibXML
...
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2010-01-01 13:17:46 -08:00
Willem van Bergen
d7f9b9fd24
Added SAX-based parser for XmlMini, using Nokogiri.
...
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2010-01-01 13:17:45 -08:00
Willem van Bergen
34b03cebf9
Code cleanup, bugfixes and speed improvements for the Nokogiri and LibXML XmlMini backends
...
[#3641 state:committed]
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2010-01-01 13:16:40 -08:00
Jeremy Kemper
4f590b67b7
Ruby 1.9.2: explicit coercion check no longer needed; bug fixed upstream
2010-01-01 11:02:09 -08:00
Pratik Naik
b35873a575
Rename Model.arel_table to Model.active_relation
2010-01-02 00:25:29 +05:30
Pratik Naik
d2c4b3b672
Rename Model.engine to active_relation_engine. Cache arel_table and the method takes no arguments now
2010-01-02 00:03:20 +05:30
Pratik Naik
5971842d2d
Use Arel::Table instead of ActiveRecord::Relation from HABTM and has_many#delete_records
2010-01-01 23:42:13 +05:30
Pratik Naik
fc94c03c1d
Remove unncessary arguments passed to arel_table
2010-01-01 23:34:15 +05:30
Pratik Naik
d200d08004
Use arel for building the STI type condition
2010-01-01 23:15:48 +05:30
Mikel Lindsaar
a0f44fe0fb
Silence warning of missing init on @config
2010-01-01 20:45:28 +11:00
Mikel Lindsaar
f72dd368b3
Silence @text not initialized warning
2010-01-01 14:44:11 +11:00
Yehuda Katz
7789663a7d
Put MySQL and Postgres in an :only block so you can gem bundle --only default to leave out MySQL and Postgres
2009-12-31 18:49:27 -08:00
José Valim
50aa876f32
Make rendering in ActionView happen through _render_template, as the rendering which comes from ActionController.
2009-12-31 18:40:20 -08:00
José Valim
c03c40b481
Expose a _render_partial hook as thhe _render_template one and make use of it.
2009-12-31 18:40:20 -08:00
José Valim
33c98b15bc
ActionController::Logger should include AbstractController::Logger and sort autoloads for easier readability.
2009-12-31 18:40:20 -08:00
José Valim
38fa0d14a8
controller_path is required by ActionView, so move it up to AbstractController and refactor AbstractController::Layouts.
2009-12-31 18:40:20 -08:00
Jeremy Kemper
db49b7dc94
Fix new year heisenbug
2009-12-31 18:32:16 -08:00
Jeremy Kemper
9790f0eda5
Merge commit 'josevalim/inheritance'
2009-12-31 18:24:45 -08:00
José Valim
8c5fe60ec8
Simplify repair_validations on AR and make it work with new callbacks.
2010-01-01 03:20:38 +01:00
Jeremy Kemper
6ce562c9ff
Merge commit 'mikel/master'
2009-12-31 17:15:06 -08:00
José Valim
50fbb74056
Fix inheritance issue with new callbacks.
2010-01-01 01:48:12 +01:00
Pratik Naik
58ad656769
Make sure association proxy does not pass quoted table name to sanitize_sql
2010-01-01 04:37:19 +05:30
Pratik Naik
8a32d37967
Handle Range with excluded end
2010-01-01 04:33:56 +05:30
Pratik Naik
c62e88a5ab
Try using cached attribute before creating a new one
2010-01-01 04:17:56 +05:30
Pratik Naik
77c23b2104
Use PredicateBuilder for sql hash sanitization
2010-01-01 04:17:56 +05:30
Pratik Naik
141d3aff2f
Fix the method name for recusion
2010-01-01 04:17:56 +05:30
Pratik Naik
3c23b71a09
Move predicate building to a stand alone PredicateBuilder class
2010-01-01 04:17:55 +05:30
Carl Lerche
ae7ada1fde
Some railties cleanup:
...
* Rename <framework>/rails.rb -> <framework>/railtie.rb
* Rails::Plugin -> Rails::Railtie
* Rails::Plugin::Vendored -> Rails::Plugin
2009-12-31 13:12:52 -08:00
Carl Lerche
e749424dfa
Rename rails.rb -> rails/all.rb and rails/core.rb -> rails.rb
2009-12-31 13:12:52 -08:00
Pratik Naik
fdc62cdcdb
Use Arel::Attribute when building where conditions from hash
2010-01-01 02:22:03 +05:30
Carl Lerche
2f8643955a
Raise a helpful error if config.frameworks is used
2009-12-31 11:57:59 -08:00
Carl Lerche
a23f4b6aee
Add a /rails.rb for each framework for consistency
2009-12-31 11:57:59 -08:00
Carl Lerche
1e41097294
Fully remove config.frameworks in favor of requires in boot.rb
2009-12-31 11:57:59 -08:00
Pratik Naik
783caae52f
Use Arel::Attribute for pk conditions
2010-01-01 01:00:18 +05:30
Pratik Naik
93555c672e
Add Relation#table to get the relevant Arel::Table
2010-01-01 00:56:49 +05:30
Pratik Naik
d5f9173926
Add Relation#delete [Pratik Naik, Emilio Tagua]
2010-01-01 00:17:40 +05:30
David Heinemeier Hansson
ea41a757aa
Dont gitkeep things that are gitignored
2009-12-31 11:09:10 -05:00
Mikel Lindsaar
94838fbe39
Updating mail requirement to 1.4.3
2009-12-31 19:51:25 +11:00
Mikel Lindsaar
e372f25b0d
Merge branch 'master' of github.com:mikel/rails
...
Conflicts:
actionmailer/lib/action_mailer/tmail_compat.rb
2009-12-31 19:48:40 +11:00
Mikel Lindsaar
2f1aaebe77
removing spurious line
2009-12-31 19:46:22 +11:00
Mikel Lindsaar
a2880827b4
Adding :transfer_encoding -> :content_transfer_encoding as part of TmailCompat
2009-12-31 19:37:37 +11:00
Jeremy Kemper
16f1a2b573
Clarify assertion
2009-12-30 23:21:10 -08:00
David Heinemeier Hansson
96c27e4003
Merge branch 'master' of github.com:rails/rails
2009-12-31 01:15:30 -05:00
Jeremy Kemper
c4c2502df8
Fix controller runtime test
2009-12-30 22:15:02 -08:00
David Heinemeier Hansson
5d8342cc32
Added .gitkeep to empty directories and --skip-git to skip gitignore/gitkeep files
2009-12-31 01:14:23 -05:00
Carl Lerche
d39d7f5f44
Allow ActiveSupport's isolation tests to run with MiniTest on 1.9
2009-12-30 20:48:46 -08:00
David Heinemeier Hansson
5eb3ceca01
Orphan experiment no longer needed
2009-12-30 22:55:52 -05:00
Jeremy Kemper
1fbd02e446
Revert "Add config.action_controller.include behavior to plugins."
...
This reverts commit 7e8b7f46bf .
Conflicts:
railties/lib/rails/plugin.rb
2009-12-30 19:34:15 -08:00
Jeremy Kemper
10a2638db0
Fix up AR extension by using Railties module instead of Rails and requiring ControllerRuntime at initialization time instead of boot
2009-12-30 19:24:00 -08:00
Jeremy Kemper
d349b22097
Remove self-require
2009-12-30 19:00:12 -08:00
Jeremy Kemper
8ad9d14494
Partially revert "ActionDispatch should require as little of ActiveSupport as possible"
...
Removes load path change from commit bb153f42e4 .
2009-12-30 17:35:17 -08:00
Jeremy Kemper
1a0c372b19
depends on Module#attr_internal
2009-12-30 14:31:02 -08:00
Jeremy Kemper
3a29aa3abc
Merge commit 'josevalim/arlog'
2009-12-30 14:01:05 -08:00
Jeremy Kemper
0c7c842d8f
Merge branch 'master' of github.com:rails/rails
2009-12-30 14:01:00 -08:00
Xavier Noria
7f8d2cdb17
AS guide: documents Object#presence
2009-12-30 22:53:44 +01:00
Jeremy Kemper
17787fbfdb
Merge commit 'josevalim/callbacks'
2009-12-30 13:48:20 -08:00
José Valim
cb3c0d490b
Get rid of DeprecatedCallbacks in ActiveRecord::Associations and finally remove it.
2009-12-30 13:40:37 -08:00
José Valim
a6e2d16b1e
Setup and teardown now use new callbacks.
2009-12-30 13:40:37 -08:00
Xavier Noria
2e59151c5f
fixes a link in the plugins guide
2009-12-30 22:38:39 +01:00
Carl Lerche
bb153f42e4
ActionDispatch should require as little of ActiveSupport as possible
2009-12-30 12:58:40 -08:00
Pratik Naik
7aabaac0f5
Organize Relation methods into separate modules
2009-12-30 19:29:26 +05:30
José Valim
4ecdf24bde
Kick AR logging back to life and move ControllerRuntime inside ActiveRecord::Rails.
2009-12-30 13:07:48 +01:00
José Valim
97a64b6b22
Get rid of DeprecatedCallbacks in ActiveRecord::Associations and finally remove it.
2009-12-30 11:43:34 +01:00
José Valim
e58ad8ed9c
Setup and teardown now use new callbacks.
2009-12-30 11:09:27 +01:00
Mikel Lindsaar
79280a233f
Adding :transfer_encoding -> :content_transfer_encoding as part of TmailCompat
2009-12-30 20:43:56 +11:00
Jeremy Kemper
97204fc0bc
Merge commit 'mikel/master'
2009-12-30 00:18:41 -08:00
Pratik Naik
8734f9a271
Relation#many? shoud load the records if there's a LIMIT
2009-12-30 12:14:00 +05:30
Pratik Naik
bdf59a5618
Add Relation#any? and Relation#many?
2009-12-30 12:11:22 +05:30
Mikel Lindsaar
345e622a20
Adding TMailCompat layer for :set_content_type and friends
2009-12-30 16:12:51 +11:00
Pratik Naik
a56518aee2
Fix the count test for postgres
2009-12-30 10:41:47 +05:30
Jeremy Kemper
79550e8995
Revert "Add default respond_to formats to ApplicationController."
...
(Needs consensus that these are appropriate defaults.)
This reverts commit 66604b2e0e .
2009-12-29 19:11:00 -08:00
Carl Lerche
e5c88434db
Use the correct method for eager loading autoloads
2009-12-29 19:04:37 -08:00
Jeremy Kemper
153ce2f328
Clean up changelog a bit
2009-12-29 15:50:47 -08:00
Jeremy Kemper
71ffa76070
Merge branch 'mail'
2009-12-29 15:49:04 -08:00
Jeremy Kemper
ce1aeeee3f
Move mail gem dep to Action Mailer's gemspec
2009-12-29 15:47:28 -08:00
Jeremy Kemper
b27a3e8da3
Merge branch 'master' of git://github.com/mikel/rails into mail
...
Conflicts:
actionmailer/lib/action_mailer.rb
2009-12-29 15:46:12 -08:00
Jeremy Kemper
485d244eae
Merge branch 'master' of github.com:rails/rails
2009-12-29 15:38:17 -08:00
Xavier Noria
bf7ec2d745
fixes link to Pickaxe in getting started guide
2009-12-30 00:22:36 +01:00
Xavier Noria
9069761ef7
fixes broken links in migrations guide
2009-12-30 00:18:50 +01:00
Xavier Noria
b476ab7e3a
fixes broken links in form helpers guide
2009-12-30 00:09:12 +01:00
Xavier Noria
93371d4c4a
LH redirects to https in contributing guide
2009-12-29 23:59:06 +01:00
José Valim
0b37572552
Clean up railties Rakefile from old responsibilities which are now part of main Rakefile
2009-12-29 23:58:44 +01:00
José Valim
1a4d909c68
Add rails app --edge and rails app --dev
2009-12-29 23:58:34 +01:00
José Valim
66604b2e0e
Add default respond_to formats to ApplicationController.
2009-12-29 23:58:25 +01:00
Xavier Noria
9834c857e5
fixes broken links in 2.3 release notes
2009-12-29 23:50:11 +01:00
Sam Pohlenz
468bdb3ed8
Make plugins responsible for loading their own rake tasks
...
Signed-off-by: Carl Lerche <carllerche@mac.com >
2009-12-29 14:47:48 -08:00
Sam Pohlenz
cbce027669
Application object should instantiate non-vendored plugins
...
Signed-off-by: Carl Lerche <carllerche@mac.com >
2009-12-29 14:45:43 -08:00
Xavier Noria
bb27bd073b
fixes broken links in 2.2 release notes
2009-12-29 23:42:23 +01:00
Carl Lerche
2e87196d14
Use extlib_inheritable_accessor in request_forgery_protection.rb.
...
For some reason the current class_inheritable_accessor does not play nice with included hooks. class_inheritable_accessor will be revised shortly.
2009-12-29 13:21:36 -08:00
Carl Lerche
3cb7e04763
Finally remove rails/initializer.rb
2009-12-29 13:20:10 -08:00
Pratik Naik
f17bb1fbff
Simplify get_projection_name_from_chained_relations using recursion
2009-12-30 01:16:24 +05:30
Emilio Tagua
00cd3789f6
Relation#count should look for projections in chained relations and perform the count on the given column
...
Signed-off-by: Pratik Naik <pratiknaik@gmail.com >
2009-12-30 01:12:38 +05:30
Carl Lerche
aa1b32ae97
Check to see if the plugin object responds to load_tasks (vendor/plugin/* does not yet) Fixes Sam Ruby's tests.
2009-12-29 10:49:12 -08:00
Pratik Naik
0dea509817
Oops, add the missing #tap call
2009-12-29 15:54:40 +05:30
Pratik Naik
3b8853eda4
Replace Base#safe_to_array with Array.wrap
2009-12-29 15:53:06 +05:30
Pratik Naik
0a1ff1a14f
Rewrite Relation#readonly, eager_load, preload using Object#tap
2009-12-29 15:28:40 +05:30
Pratik Naik
1785e1b26e
Rename Relation#create_new_relation to spawn and refactor preload/eagerload associations using attr_writer
2009-12-29 15:24:30 +05:30
Pratik Naik
61fa111a55
Refactor Relation#readonly using attr_writer
2009-12-29 15:24:30 +05:30
Yehuda Katz
cf4978313b
Make sure evalled method knows where it came from
2009-12-29 01:04:32 -08:00
Pratik Naik
981f696398
Relation#respond_to? should take second argument for responding to private methods
2009-12-29 12:31:08 +05:30
Pratik Naik
bc933d0fa1
Make sure Relation responds to dynamic finder methods
2009-12-29 12:27:40 +05:30
Pratik Naik
f290e685f0
Add Relation#size and Relation#empty?
2009-12-29 12:15:28 +05:30
Pratik Naik
13989ff8c6
Use relation#delete_all for Model.delete_all
2009-12-29 11:46:07 +05:30
Pratik Naik
54b80c7361
Add Relation#delete_all
2009-12-29 11:46:07 +05:30
Jeremy Kemper
f79caa49fb
Complain if there's no such middleware
2009-12-28 20:24:28 -08:00
Carl Lerche
4ee70643b3
Don't require initializer.rb in core.rb
2009-12-28 18:26:15 -08:00
Carl Lerche
49c800b6bd
Move the ActiveRecord related rake tasks into the AR gem.
2009-12-28 17:53:05 -08:00
Carl Lerche
d747b6847b
Require active_support/dependencies/autoload in action_dispatch
2009-12-28 17:53:05 -08:00
Carl Lerche
c02f278263
Add the ability to have plugins load rake tasks.
2009-12-28 17:53:04 -08:00
Jeremy Kemper
9a650a6547
Silence some trivial warnings: shadowed local vars, indentation mismatches
2009-12-28 17:36:08 -08:00
José Valim
6d390671f6
Move ActiveRecord callbacks implementation to ActiveModel and make use of it.
...
Signed-off-by: Yehuda Katz <wycats@Yehuda-Katz.local >
2009-12-28 16:19:23 -08:00
Yehuda Katz
643862e3be
Merge branch 'master' of github.com:rails/rails
2009-12-28 16:19:09 -08:00
Pratik Naik
078ea0dfbd
Oops. Remove debug information inside a test from the previous commit
2009-12-29 04:33:37 +05:30
Pratik Naik
08633bae5e
Migrate all the calculation methods to Relation
2009-12-29 04:30:04 +05:30
Jeremy Kemper
949c8c0d0e
Don't publicize with_scope for tests since it may shadow public misuse
2009-12-28 14:07:23 -08:00
Jeremy Kemper
1b91f534ce
Fix uniqueness validation: with_exclusive_scope is not public
2009-12-28 14:06:22 -08:00
Jeremy Kemper
d927265abd
Fix pg test
2009-12-28 13:05:36 -08:00
Jeremy Kemper
9fe42232f1
Merge commit 'Fingertips/master'
2009-12-28 12:50:56 -08:00
Jeremy Kemper
a76af2309a
rake smoke: toplevel task to quickly smoke-test all projects
2009-12-28 12:29:03 -08:00
Pratik Naik
1ebfd999ec
Add ruby-debug to Gemfile for Ruby < 1.9
2009-12-29 01:53:15 +05:30
Jeremy Kemper
ea7b5ff99e
Use present rather than any
2009-12-28 12:12:53 -08:00
Eloy Duran
c23fbd0d47
Refactored previous changes to nested attributes.
2009-12-28 21:09:22 +01:00
Michael Siebert
07b615fb89
Add an :update_only option to accepts_nested_attributes_for for to-one associations. [ #2563 state:resolved]
...
Signed-off-by: Eloy Duran <eloy.de.enige@gmail.com >
2009-12-28 21:09:19 +01:00
Jeremy Kemper
f95fcdd3af
Fix copy/pasted test class name
2009-12-28 11:40:34 -08:00
Jeremy Kemper
4691cc43ee
Fix ruby version test
2009-12-28 11:40:23 -08:00
Jeremy Kemper
632df063a3
Merge commit 'josevalim/validations'
2009-12-28 11:13:35 -08:00
Pratik Naik
91e28aae86
Add Model.having and Relation#having
2009-12-29 00:07:46 +05:30
Eloy Duran
9c771a9608
Make sure to not add autosave callbacks multiple times. [ #3575 state:resolved]
...
This makes sure that, in a HABTM association, only one join record is craeted.
2009-12-28 16:56:31 +01:00
Dave Rothlisberger
3eeb0df402
Further improvement to the documentation of has_many method collection.create:
...
Of course the "associated object" (base model) cannot be nil, or you wouldn't
be calling this method on it. What concerns the user is that the base model
must be present in the DB.
2009-12-28 14:33:26 +00:00
Murray Steele
ff508640e2
Make polymorphic_inverse_of in Reflection throw an InverseOfAssociationNotFoundError if the supplied class doesn't have the appropriate association. [ #3520 state:resolved]
...
Signed-off-by: Eloy Duran <eloy.de.enige@gmail.com >
2009-12-28 15:12:17 +01:00
Murray Steele
6a74ee7f4d
Provide a slightly more robust we_can_set_the_inverse_on_this? method for polymorphic belongs_to associations. [ #3520 state:resolved]
...
Also add a new test for polymorphic belongs_to that test direct accessor assignment, not just .replace assignment.
Signed-off-by: Eloy Duran <eloy.de.enige@gmail.com >
2009-12-28 15:12:15 +01:00
George Ogata
81ca0cf2b0
Add inverse polymorphic association support. [ #3520 state:resolved]
...
Signed-off-by: Eloy Duran <eloy.de.enige@gmail.com >
2009-12-28 15:12:13 +01:00
Murray Steele
6c8c85bc1e
Add more tests for the various ways we can assign objects to associations. [ #3513 state:resolved]
...
Get rid of a duplicate set_inverse_instance call if you use new_record(true) (e.g. you want to replace the existing instance).
Signed-off-by: Eloy Duran <eloy.de.enige@gmail.com >
2009-12-28 15:12:11 +01:00
George Ogata
fc85c66527
Set inverse for #replace on a has_one association. [ #3513 state:resolved]
...
Signed-off-by: Eloy Duran <eloy.de.enige@gmail.com >
2009-12-28 15:12:07 +01:00
Pratik Naik
e8ca22d129
Move Relation calculation methods to a separate module
2009-12-28 19:12:15 +05:30
Pratik Naik
8f5d9eb0e2
Add Relation#count
2009-12-28 18:38:28 +05:30
Pratik Naik
aefa975fdd
Remove the todo note for arel#lock
2009-12-28 16:20:40 +05:30
Pratik Naik
02207dc02c
Add Model.readonly and association_collection#readonly finder method
2009-12-28 16:17:46 +05:30
Mikel Lindsaar
b354496bda
Adding default 8bit encoding if the body has non usascii in it
2009-12-28 21:41:16 +11:00
José Valim
616ebb8f6a
Remove unused code paths and require mail only when it's needed.
2009-12-28 11:21:36 +01:00
Dave Rothlisberger
44e8f7cf00
Corrected documentation of has_many methods collection.build and collection.create.
...
* collection.create: Clarified the wording (this had always confused me). I used the phrase
"base model" to mean the model that specifies the has_many association (this wording is also
used previously, e.g. in the "Cardinality and associations" section).
* collection.build: You *can* actually call this to add new association records when the base
model is a new record. In ActiveRecord::Associations::AssociationCollection, #create_record
calls #ensure_owner_is_not_new, but #build_record does not.
2009-12-28 09:21:53 +00:00
Pratik Naik
5156507e13
Remove locking related unused code
2009-12-28 14:33:56 +05:30
Pratik Naik
b95cc72429
Raise ArgumentError when trying to merge relations of different classes
2009-12-28 14:24:52 +05:30
Pratik Naik
92c982d973
Relation#readonly(false) should toggle the readonly flag
2009-12-28 14:20:54 +05:30
Pratik Naik
9f4e98330b
Remove unused construct_finder_sql
2009-12-28 12:57:35 +05:30
Pratik Naik
d6b0a7d67c
Fix a typo in CHANGELOG
2009-12-28 12:44:43 +05:30
Pratik Naik
a3c1db4e44
Add Model.lock and relation#lock now that arel has locking
2009-12-28 12:42:06 +05:30
Yehuda Katz
9abbe9f0b3
Merge branch 'master' of github.com:rails/rails
2009-12-27 22:27:33 -08:00
David Heinemeier Hansson
1c47d04ea5
Added Object#presence that returns the object if it's #present? otherwise returns nil [DHH/Colin Kelley]
2009-12-27 17:54:43 -08:00
David Heinemeier Hansson
a642edbef3
Added default .gitignore (this is just recognizing Git market share, don't throw a hissy if you use another SCM) [DHH]
2009-12-27 17:48:11 -08:00
Mikel Lindsaar
c039bcdb1c
Moved sort_parts into Mail, updated mail requirement to 1.4.2
2009-12-28 12:25:14 +11:00
Yehuda Katz
99f7e0ff27
Update rack submodule
2009-12-27 16:20:27 -08:00
Yehuda Katz
f095e6f59d
Fixes some problems with getting a new app working
2009-12-27 16:00:34 -08:00
Jeremy Kemper
19c48281a7
String#exclude? core extension: inverse of #include?
2009-12-27 15:49:29 -08:00
Jeremy Kemper
7c4fb93ac3
Ruby 1.9: string is not enumerable, so #exclude? is not available
2009-12-27 15:38:00 -08:00
Jeremy Kemper
3a79117c77
Typo
2009-12-27 15:27:18 -08:00
David Heinemeier Hansson
ebe3c8f2e4
Merge branch 'master' of github.com:rails/rails
2009-12-27 15:23:38 -08:00
David Heinemeier Hansson
438a8c3ec7
Require the enumberable extension from active support because we use #exclude?
2009-12-27 15:23:30 -08:00
José Valim
a176263ebc
Fix generators tests.
...
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2009-12-27 15:19:16 -08:00
Jeremy Kemper
292363c75f
Use i18n
2009-12-27 15:17:44 -08:00
David Heinemeier Hansson
5012a1558d
Merge branch 'master' of github.com:rails/rails
2009-12-27 14:44:21 -08:00
David Heinemeier Hansson
1cd949006a
Fix the i18n dependency problem
2009-12-27 14:43:06 -08:00
Yehuda Katz
12e43494a7
Merge remote branch 'jose/perf'
2009-12-27 14:36:59 -08:00
Pratik Naik
1c26ba486c
Add Model.from and association_collection#from finder methods
2009-12-28 03:59:44 +05:30
Pratik Naik
6a776dcc9d
Use relation.from when constructing a relation
2009-12-28 03:59:44 +05:30
David Heinemeier Hansson
9521fcbcc2
Merge branch 'master' of github.com:rails/rails
2009-12-27 14:14:54 -08:00
David Heinemeier Hansson
95762cbbb3
Added shorthand for match 'products/overview' that expands to match 'products/overview', :to => 'products#overview', :as => 'products_overview'
2009-12-27 14:13:03 -08:00
Pratik Naik
a0ff5f82c3
Dont delegate relation#find to to_a
2009-12-28 03:22:33 +05:30
Pratik Naik
e9e20ab601
Use arel#from instead of the current hack
2009-12-28 03:19:31 +05:30
Pratik Naik
630dc50730
Fix relation tests for postgres
2009-12-28 02:50:04 +05:30
Pratik Naik
51a1d5a670
Handle preloads and eager loads when merging relations
2009-12-28 01:33:20 +05:30
Pratik Naik
a8b10a2a8d
Add relation#merge to merge two relations
2009-12-28 01:08:34 +05:30
Pratik Naik
08312e9958
Return a new relation when blank is supplied to relation.joins
2009-12-27 23:29:41 +05:30
Pratik Naik
5565bab994
Rewrite AssociationCollection#find using relations
2009-12-27 22:32:20 +05:30
Pratik Naik
bbdeaae2ca
Add relation.destroy_all
2009-12-27 21:15:12 +05:30
Pratik Naik
5cd8818258
Make Model.destroy_all use new finders
2009-12-27 19:22:18 +05:30
Pratik Naik
352cc7c94a
Make Model.find(:last) use relations
2009-12-27 19:12:50 +05:30
Pratik Naik
d5e98dc859
Add relation.last and relation.reverse_order
2009-12-27 19:04:30 +05:30
Pratik Naik
8957f5db5d
Make Model.all just a wrapper for find(:all)
2009-12-27 18:32:10 +05:30
Pratik Naik
d6d0fe8c8f
Make Model.find(:first, ..) use relations
2009-12-27 18:28:59 +05:30
Pratik Naik
59cf5e7bf2
Make Model.exists? use relation.exists?
2009-12-27 18:10:26 +05:30
José Valim
97db79ab3c
Remove ActiveRecord runtime logging from ActionPack and place in ActiveRecord, adding it through config.action_controller.include hook.
2009-12-27 13:32:40 +01:00
José Valim
7e8b7f46bf
Add config.action_controller.include behavior to plugins.
2009-12-27 13:31:36 +01:00
Pratik Naik
2c8f83556b
Add relation.exists?
2009-12-27 18:00:49 +05:30
Pratik Naik
b31233485b
Make Model.find(:all) use relations
2009-12-27 17:43:31 +05:30
Pratik Naik
a3f3fab795
Add relation.from as a temporary workaround until arel relation has .from option
2009-12-27 17:37:36 +05:30
Pratik Naik
6f5e3a04d6
Relation should supply :from to find_with_associations
2009-12-27 17:16:20 +05:30
José Valim
971f4ff829
DRY ActionMailer code.
2009-12-27 12:36:00 +01:00
Pratik Naik
7b5d0e8b78
Make Model.find(ids) use relations
2009-12-27 16:56:10 +05:30
José Valim
4747a9a57e
Getting rid of some warnings in AM suite.
2009-12-27 12:18:46 +01:00
José Valim
47e5caa96b
Merge Mail with latest Rails and move mail gem to Gemfile.
2009-12-27 12:09:20 +01:00
Pratik Naik
d92c4a8402
Add find(ids) to relations
2009-12-27 16:15:29 +05:30
Mikel Lindsaar
fd58a2d1da
Updating action_mailer to need mail 1.4.1
2009-12-27 21:42:33 +11:00
Mikel Lindsaar
331d375cc3
Changing body to use :to_s instead of :decoded... better use case
2009-12-27 20:56:16 +11:00
Pratik Naik
81608cf8fa
Make Model.all return an array rather than a relation for consistency. Use Model.scoped to get a relation
2009-12-27 15:06:45 +05:30
Pratik Naik
1efc8edb5f
Fix dynamic finder docs
2009-12-27 14:50:33 +05:30
Pratik Naik
85770ec713
Make Model.find_or_create_by_* and find_or_initialize_by_* use relations and remove method caching
2009-12-27 14:46:38 +05:30
Pratik Naik
d511de0261
Add find_or_create_by_* and find_or_initialize_by_* to relations
2009-12-27 14:28:19 +05:30
Pratik Naik
8829d6ecc6
Make Model.find_by_* and Model.find_all_by_* use relations and remove dynamic method caching
2009-12-27 13:17:29 +05:30
Mikel Lindsaar
d9aadb5b2d
Updating readme
2009-12-27 18:39:37 +11:00
Mikel Lindsaar
4e1fa4912d
Updating actionmailer to call :to_s on all field values instead of decoded
2009-12-27 18:38:30 +11:00
Jeremy Kemper
51d84eff12
Require bundled environment, if present, so Active Support can load i18n
2009-12-26 22:22:48 -08:00
Joshua Peek
bdf8ee44c5
script/server should init Rails by loading config.ru
...
Fixes "Rails 3.0 doesn't fucking work"
2009-12-26 18:23:48 -06:00
Pratik Naik
f6f416c58e
Add find_by_* and find_all_by_* finders to ActiveRecord::Relation
2009-12-27 03:25:29 +05:30
Pratik Naik
cc753eaf58
Replace Model.first(options) with new finder methods inside tests
2009-12-27 01:50:03 +05:30
José Valim
75ba102a80
Remove ActionView inline logging to ActiveSupport::Notifications and create ActionController::Base#log_event, so everything can be logged within one listener. Also expose log_process_action as a hook for different modules to include their own information during the action processing. This allow ActiveRecord to hook and any other ORM. Finally, this commit changes 'Processing' and 'Rendering' in logs to 'Processed' and 'Rendered' because at the point it's logged, everying already happened.
2009-12-26 20:28:53 +01:00
Joshua Peek
feb7382047
AD::Cascade that supports X-Cascade
2009-12-26 13:28:06 -06:00
Joshua Peek
673fa7f066
rack-mount 0.4
2009-12-26 13:25:36 -06:00
Joshua Peek
f53c36350d
Expect Rack 1.1
2009-12-26 13:25:35 -06:00
Pratik Naik
83f24afd44
Add new finder methods to association collection.
2009-12-27 00:25:00 +05:30
Pratik Naik
f374150698
Ensure Model.scoped adds type conditions for STI models
2009-12-27 00:11:31 +05:30
Pratik Naik
c6258ee313
Ensure all the finder methods respect scoping
2009-12-26 19:15:05 +05:30
José Valim
8a36e907d2
More <%= render(@posts) %> optimization.
2009-12-26 14:11:04 +01:00
José Valim
ff1a1c0b4d
Optimize <%= render(@posts) %>.
2009-12-26 14:11:04 +01:00
José Valim
c86424a72d
Break instrumentation into several end-points so rendering of partials can be optimized.
2009-12-26 14:11:04 +01:00
José Valim
48273a44c6
Wrap layout rendering in one method: _render_layout (this should make partial instrumentation easier).
2009-12-26 14:11:04 +01:00
José Valim
561885aea2
String#<< should work for any object which responds to :to_str, so enable this without the performance hit and make Fixnum safe by default.
2009-12-26 14:11:04 +01:00
Pratik Naik
9a9f97af28
Add relation.reload to force reloading the records
2009-12-26 15:31:50 +05:30
Pratik Naik
3c5a7dcaf5
Cache the loaded relations
2009-12-26 15:07:00 +05:30
Pratik Naik
9d3d60c64a
Ensure preload and eager_load finder methods accept multiple arguments
2009-12-26 14:40:45 +05:30
Pratik Naik
284d186cf4
Make sure the relations are always immutable
2009-12-26 14:26:02 +05:30
Pratik Naik
187fbe5cba
Add support for multiple arguments to .where finder
2009-12-26 12:57:34 +05:30
Pratik Naik
5f5aa44d2d
Add missing changelog entries
2009-12-26 12:43:49 +05:30
Pratik Naik
feb8b20eb5
Add Relation#all as an alias for to_a
2009-12-26 12:39:44 +05:30
Pratik Naik
a73fa9356f
Stop supporting blank arguments to AR#relation query methods
2009-12-26 04:07:50 +05:30
Pratik Naik
95274b28d9
Rename Model.conditions and relation.conditions to .where
2009-12-26 03:50:57 +05:30
Xavier Noria
2ad0618385
fixes broken link, thanks to veger
2009-12-25 23:04:24 +01:00
Pratik Naik
1a99337180
No parentheses for assert_equal
2009-12-26 03:10:55 +05:30
Pratik Naik
a7fd564ab1
Add Model.select/group/order/limit/joins/conditions/preload/eager_load class methods returning a lazy relation.
...
Examples :
posts = Post.select('id).order('name') # Returns a lazy relation
posts.each {|p| puts p.id } # Fires "select id from posts order by name"
2009-12-26 03:06:51 +05:30
Yehuda Katz
8f6da9483b
Merge remote branch 'jose/am'
2009-12-25 13:06:11 -08:00
José Valim
9f1c359a20
Fix whiny_nil tests, improve error messages and make CI happy.
2009-12-25 22:00:36 +01:00
José Valim
88ba056043
Refactor multiple parts logic and move Utils to PartContainer.
2009-12-25 21:47:47 +01:00
José Valim
ee70d1b6ad
adv_attr_accessors in ActionMailer are not sent to the views, use the mailer object if you need to access the subject, recipients, from, etc.
2009-12-25 21:35:40 +01:00
Pratik Naik
2e79ec71a5
Model.scoped now returns a relation if invoked without any arguments
...
Example :
posts = Post.scoped
posts.size # Fires "select count(*) from posts" and returns the count
posts.each {|p| puts p.name } # Fires "select * from posts" and loads post objects
2009-12-26 01:33:20 +05:30
David Heinemeier Hansson
7f5d44bac5
The controller key shouldnt be part of the mapping if its not used
2009-12-25 10:14:44 -08:00
David Heinemeier Hansson
a8f1ee5986
Fix tests
2009-12-25 10:04:26 -08:00
José Valim
135d32c8bd
Move i18n to Gemfile.
2009-12-25 15:15:13 +01:00
José Valim
eb8e627c69
Merge branch 'master' of git://github.com/rails/rails
2009-12-25 12:09:13 +01:00
Yehuda Katz
1c66f85eb6
This code was needed to work around http://redmine.ruby-lang.org/issues/show/2494 . Since that bug is now closed in Ruby, we can remove it.
2009-12-24 23:48:35 -08:00
Yehuda Katz
3b1642c23c
Simplify and improve the performance of output_safety
2009-12-24 22:44:21 -08:00
Yehuda Katz
f3b072189a
Instead of marking raw text in templates as safe, and then putting them through String#<< which checks if the String is safe, use safe_concat, which uses the original (internal) String#<< and leaves the safe flag as is. Results in a significant performance improvement.
2009-12-24 21:50:18 -08:00
Yehuda Katz
baaaf2acaa
Dead code
2009-12-24 21:50:17 -08:00
David Heinemeier Hansson
0a365d63f6
Translated strings in the view are assumed html_safe ( Closes #3401 )
2009-12-24 20:32:53 -08:00
David Heinemeier Hansson
6ce5982afa
Stray carrier return
2009-12-24 16:13:50 -08:00
David Heinemeier Hansson
b9c0a16655
The new routes shortform now also works for :as
2009-12-24 16:08:03 -08:00
David Heinemeier Hansson
38af368360
Merge
2009-12-24 15:24:57 -08:00
David Heinemeier Hansson
2b7256a42e
Extract Mapping class from monster match method
2009-12-24 15:23:39 -08:00
Jeremy Kemper
46b376962f
Fix new schema test dependency on Hash#to_xml
2009-12-23 23:30:59 -08:00
Sam Ruby
aa3565f3a6
Allow named_routes to be used with root, and with new DSL short-form.
...
The real use case it to make all of the following act the same:
root 'store#index', :as => 'store'
match '/' => 'store#index', :as => 'store'
match '/', :to => 'store#index', :as => 'store'
The test case provided deviates from this in order to demonstrate all three
forms in a single set of test routes.
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2009-12-23 20:55:21 -08:00
Carlhuda
84f1137ef8
Merge remote branch 'origin/master'
...
Conflicts:
railties/lib/rails/application.rb
2009-12-23 19:18:11 -08:00
Carlhuda
c4d6d50a46
Rackup config.ru from the correct directory
2009-12-23 19:10:44 -08:00
Carlhuda
af5c3c852e
Require active_support/all unless specifically requested to be left out.
2009-12-23 19:00:20 -08:00
Carlhuda
9653599a79
Remove the ActionView::Base autoload because it creates crazy circular autoload insanity
2009-12-23 18:59:49 -08:00
Jeremy Kemper
7a6f73e79b
Fix reference to Application#configuration to use #config
2009-12-23 17:47:38 -08:00
Carlhuda
d926fb62e8
Isolation tests intentionally avoid loading any state (because they're often testing things that have their own load path semantics that should not be polluted), so rack/test is not yet on the load path. Moving require "rack/test" into the setup means and after boot_rails means that it'll be required after the laod path has been altered to add in the Rails vendor/gems
2009-12-23 17:46:38 -08:00
Jeremy Kemper
4d3602a8c4
Routing: fix that route shorthand shouldn't ignore other options. Raise if :as option is given to root method since its name is always 'root'
2009-12-23 17:42:30 -08:00
Carlhuda
d2bd71a145
Finish moving config.frameworks-dependent code to the framework plugin
2009-12-23 17:23:29 -08:00
Jeremy Kemper
1ee50e58f6
Fix Rack::Lock middleware condition: use *unless* we allow concurrency
2009-12-23 17:14:21 -08:00
Jeremy Kemper
94bb331635
Shift more responsibility from application class to its singleton instance. Treat instantiation and boot as separate steps. Use app.config rather than app.configuration.
2009-12-23 17:11:17 -08:00
Carlhuda
61af34b001
Make /rails/info/properties work again. Also, the mocked up tests were passing so we added a test that actually tested this functionality.
2009-12-23 16:26:10 -08:00
Carlhuda
83be262b4b
Isolation tests intentionally avoid loading any state (because they're often testing things that have their own load path semantics that should not be polluted), so rack/test is not yet on the load path. Moving require "rack/test" into the setup means and after boot_rails means that it'll be required after the laod path has been altered to add in the Rails vendor/gems
2009-12-23 16:14:34 -08:00
Carlhuda
38aeb1528c
Moving out some framework specific initializers into the framework libraries.
2009-12-23 16:13:09 -08:00
Carlhuda
fa8dfc7d01
Raise an exception if an initializer is defined without a block
2009-12-23 15:16:38 -08:00
Carlhuda
dc677f7665
tests pass with requiring the frameworks in rails.rb
2009-12-23 15:16:38 -08:00
Jeremy Kemper
24e1b55608
Fix bare string Rack response bodies
2009-12-23 13:06:53 -08:00
Dwayne Litzenberger
808cad2bb4
Fix ActiveSupport::JSON encoding of control characters [\x00-\x1f]
...
According to RFC 4627, only the following Unicode code points are
allowed unescaped in JSON:
unescaped = %x20-21 / %x23-5B / %x5D-10FFFF
However, ActiveSupport::JSON did not escape the range %x00-1f. This caused
parse errors when trying to decode the resulting output.
[#3345 state:committed]
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2009-12-23 11:46:06 -08:00
José Valim
74098e4cb6
No need to use ValidationsRepairHelper hack on ActiveModel anymore, Model.reset_callbacks(:validate) is enough. However, tests in ActiveRecord are still coupled, so moved ValidationsRepairHelper back there.
2009-12-23 13:30:58 +01:00
José Valim
e31077c9aa
Small clean up in Naming and TTranslation tests.
2009-12-23 12:28:02 +01:00
José Valim
44cd9e0e71
ActiveRecord::Validations are now built on top of Validator as well.
2009-12-23 12:14:00 +01:00
Joshua Peek
74b2e00ce8
Require rack-mount 0.3.3
...
Fixes "Rack-mount boot time is slow as shit" [#3567 state:resolved]
2009-12-22 19:44:38 -06:00
David Heinemeier Hansson
e7ef57dd0d
Merge
2009-12-22 17:31:29 -08:00
David Heinemeier Hansson
ec095456d8
Dont auto require rubygems, move dep on rack-test to Gemfile
2009-12-22 17:29:25 -08:00
David Heinemeier Hansson
fe5f660413
Dont encourage __FILE__ bullshit
2009-12-22 17:25:34 -08:00
José Valim
279067639f
validates_each uses a BlockValidator.
2009-12-23 01:38:15 +01:00
José Valim
977a5c43b1
Added check_validity! to EachValidator and refactor existing ones.
2009-12-23 01:08:27 +01:00
Joshua Peek
f737c2d69b
All AMo modules are safe to defer
2009-12-22 17:39:41 -06:00
José Valim
f1085f4128
Move validations in ActiveModel to validators, however all validatity checks are still in the class method.
2009-12-23 00:36:51 +01:00
Joshua Peek
22752ec27c
All ARes modules are safe to defer
2009-12-22 17:36:29 -06:00
Joshua Peek
2e4e8d156c
All AM modules are safe to defer
2009-12-22 17:33:00 -06:00
Joshua Peek
ace20bd25e
Flip deferrable autoload convention
2009-12-22 17:27:37 -06:00
Joshua Peek
b1aee9f4ee
All AD modules are "deferrable"
2009-12-22 17:11:21 -06:00
Joshua Peek
2d0c703c92
Use Rack::Runtime middleware so the reported time includes the entire middleware stack
2009-12-22 16:18:22 -06:00
José Valim
2476c5312d
Validator is simply sent to validate method. However, the API needs to change, so validate accepts a record.
2009-12-22 23:12:21 +01:00
Joshua Peek
df7faef68e
Referer and user agent are in Rack::Request
2009-12-22 16:09:41 -06:00
Joshua Peek
a1bf2f96ce
AD::StatusCodes support is now part of rack
2009-12-22 16:08:03 -06:00
Joshua Peek
17b6053083
Float on rack/master in preparation for rack 1.1 gem release
2009-12-22 15:46:15 -06:00
José Valim
4964d3b02c
Make ActionMailer::Base inherit from AbstractController::Base
...
Signed-off-by: Yehuda Katz <wycats@Yehuda-Katz.local >
2009-12-22 11:29:06 -08:00
José Valim
4b8330d2d5
Merge branch 'master' of git://github.com/rails/rails
2009-12-22 08:26:00 +01:00
David Heinemeier Hansson
8e48a5ef0c
Add test for root
2009-12-21 21:49:36 -08:00
Joshua Peek
1de95077dc
Merge branch 'master' of github.com:rails/rails
...
Conflicts:
railties/test/initializer/initialize_i18n_test.rb
railties/test/initializer/path_test.rb
2009-12-21 20:41:25 -06:00
Joshua Peek
426348b484
Update routes.rb template to use App name
2009-12-21 20:15:27 -06:00
Jeremy Kemper
2e571e8f99
Blog -> Blog::Application. Leave the toplevel module up for grabs.
2009-12-21 17:03:21 -08:00
David Heinemeier Hansson
76e732a7be
Fix the documentation for root :to. It should use a fully qualified controller#action syntax ( Closes #3606 )
2009-12-21 16:54:04 -08:00
Carlhuda
be225adafb
Fix ActionMailer. The fact that ActionMailer::Base does not inherit from AbstractController::Base is either a bug or we need to re-evaluate the requirements of the mixins.
2009-12-21 16:49:21 -08:00
David Heinemeier Hansson
a43a9c81cf
Dont need to specify password_confirmation, that happens automatically
2009-12-21 16:41:02 -08:00
Carlhuda
d982fe2b2f
Replace reopening the class with App.configure as an alias to class_eval
2009-12-21 16:35:54 -08:00
Carlhuda
b0b4ae970c
test.rb, dev.rb, and production.rb just reopen the Application class; no more hax required
2009-12-21 16:03:26 -08:00
David Heinemeier Hansson
a110ff0fca
Dont introspect inline templates for the logger and cleanup a few styling issues
2009-12-21 16:03:04 -08:00
David Heinemeier Hansson
36624b2c70
Give the builtin controllers their own routes.rb now that the legacy catch-all is gone
2009-12-21 15:55:59 -08:00
David Heinemeier Hansson
fee07b9da0
Merge branch 'master' of github.com:rails/rails
2009-12-21 15:50:19 -08:00
David Heinemeier Hansson
cf66d16bdf
Its cookie_verifier_secret
2009-12-21 15:49:52 -08:00
Joshua Peek
880688a499
Default route was removed from default route config, patch up failing tests.
2009-12-21 17:47:03 -06:00
Joshua Peek
715dd10961
Less annoying RoutingError message
2009-12-21 17:34:53 -06:00
Joshua Peek
f82e1046f8
reset_session needs to be a real method so flash can override it
2009-12-21 17:29:59 -06:00
Joshua Peek
3e33985e19
Update CI bundler
2009-12-21 17:27:30 -06:00
David Heinemeier Hansson
81c3b0403d
Merge branch 'master' of github.com:rails/rails
2009-12-21 15:25:51 -08:00
Daniel Schierbeck
02a31b9d8a
Fix some more typos in ActionController::Responder
2009-12-21 23:50:54 +01:00
Jeremy Kemper
bf03ddc636
Missed changelog entry for :inverse_of
2009-12-21 13:18:11 -08:00
David Heinemeier Hansson
fa8849a573
Merge branch 'master' of github.com:rails/rails
2009-12-21 11:28:16 -08:00
Daniel Schierbeck
d62661b464
Fix some typos in the docs for ActionController::Responder
2009-12-21 14:55:40 +01:00
José Valim
5f34421c77
Merge branch 'master' of git://github.com/rails/rails
2009-12-21 11:21:27 +01:00
David Heinemeier Hansson
f09ad263ca
Turn filter_parameter_logging on by default for password and password_confirmation and remove contentless comments
2009-12-20 20:50:25 -08:00
David Heinemeier Hansson
f9a4cf1562
Show the new short-form in an example
2009-12-20 20:45:18 -08:00
David Heinemeier Hansson
3ff9e9ee14
Its now possible to use match 'stuff' => 'what#stuff' instead of using the :to for simple routes
2009-12-20 20:37:36 -08:00
David Heinemeier Hansson
8763b78f89
Merge branch 'master' of github.com:rails/rails
2009-12-20 19:41:05 -08:00
David Heinemeier Hansson
3506cb730b
Mark the wild controller route as legacy an comment it out
2009-12-20 19:40:18 -08:00
Joshua Peek
15f95621d5
We don't need AD parse_config
2009-12-20 21:11:42 -06:00
Yehuda Katz
17f66473bc
AC::Head now doesn't have an unfulfilled Rendering dependency, and instead works just fine standalone (which means that ConditionalGet also doesn't have a Rendering dependency)
2009-12-20 18:50:54 -08:00
David Heinemeier Hansson
eeda059818
Just a little tidying
2009-12-20 18:37:09 -08:00
David Heinemeier Hansson
91ce8d8b7f
Merge branch 'master' of github.com:rails/rails
2009-12-20 18:32:35 -08:00
David Heinemeier Hansson
cf9d6a95e8
Added ActionDispatch::Request#authorization to access the http authentication header regardless of its proxy hiding [DHH]
2009-12-20 18:30:50 -08:00
David Heinemeier Hansson
36c13cc07a
Rename RenderOptions to Renderers
2009-12-20 18:15:20 -08:00
Joshua Peek
29c8a43056
Rename RackConvenience => RackDelegation
2009-12-20 20:05:26 -06:00
Joshua Peek
0f8a5c7954
Merge Session stuff into RackConvenience
2009-12-20 20:00:04 -06:00
Yehuda Katz
b4ecb55551
Missing acts_like dependency
2009-12-20 17:38:28 -08:00
David Heinemeier Hansson
9b41e1e4d8
Renamed Redirector to Redirecting (its a module, not a class)
2009-12-20 17:25:13 -08:00
David Heinemeier Hansson
83f4d86a93
Rename the RenderingController module to just plain Rendering
2009-12-20 17:15:31 -08:00
Joshua Peek
bdccffc40e
Remove annoying and useless meta comments
2009-12-20 19:04:54 -06:00
Joshua Peek
2e9c775998
Use instance_eval for schema block
2009-12-20 19:04:53 -06:00
Joshua Peek
c0ad3f6cc6
Rename define_schema => schema
2009-12-20 19:04:53 -06:00
Joshua Peek
669c5eec44
Rename SchemaDefinition => Schema
2009-12-20 19:04:53 -06:00
Taryn East
fc9b3e4a45
define_schema for Active Resource
...
Signed-off-by: Joshua Peek <josh@joshpeek.com >
2009-12-20 19:04:53 -06:00
Yehuda Katz
33a6bd390a
Fixes Dependency bug in ActiveSupport
2009-12-20 17:03:38 -08:00
David Heinemeier Hansson
c06aff0a7e
Added cookies.permanent, cookies.signed, and cookies.permanent.signed accessor for common cookie actions [DHH]
2009-12-20 14:33:13 -08:00
Yehuda Katz
e48b4c2dd0
:to => redirect() can take a String using 1.9-style interpolation or proc that takes the path parameters as a Hash
2009-12-20 14:07:32 -08:00
Yehuda Katz
8b4735fbd9
Add active_support/ruby/shim to the default requirements for AP components
2009-12-20 14:06:40 -08:00
Joshua Peek
2419fae092
Pending tests for AD Response
2009-12-17 22:10:37 -06:00
Joshua Peek
3b44f35e24
Don't need response prepare!
2009-12-17 22:10:37 -06:00
David Heinemeier Hansson
44fb54fecd
Models with no attributes should just have empty hash fixtures [Sam] ( Closes #3563 )
2009-12-17 17:53:16 -08:00
David Heinemeier Hansson
fa575973b1
Added alert/notice from 2-3-stable and refactored redirect_to into just living in Redirector [DHH]
2009-12-17 16:37:11 -08:00
Erica Kwan
2094fe5bf4
Fixed spelling mistake.
2009-12-17 15:50:06 -08:00
David Heinemeier Hansson
2bfa477128
Fix deprecated :vendored_at option
2009-12-17 12:02:19 -08:00
Mikel Lindsaar
8950346f8a
Updating requirement for mail to 1.3.4
2009-12-17 13:17:35 +11:00
Mikel Lindsaar
f176c94663
Updating requirement for mail to 1.3.3
2009-12-17 12:35:07 +11:00
Mikel Lindsaar
63b124b043
Merged in latest changes from rails/master
2009-12-17 12:23:08 +11:00
Mikel Lindsaar
418639b4cf
Fixes for working with 1.9.1-head
2009-12-17 12:00:32 +11:00
Mikel Lindsaar
186cd7bc53
Merge branch 'rails'
...
Conflicts:
actionmailer/lib/action_mailer.rb
actionmailer/lib/action_mailer/delivery_method/smtp.rb
2009-12-17 11:24:02 +11:00
Xavier Noria
e9a23e4f20
AS guide: fixes an example
2009-12-17 00:02:15 +01:00
Xavier Noria
64eee76541
AS guide: documents Enumerable#exclude?
2009-12-16 23:47:49 +01:00
Joshua Peek
b9d4ceb43c
Need to lazy realize middleware options so they can be modified in
...
the environment
2009-12-16 16:12:04 -06:00
Joshua Peek
7217d64f61
Use AbstractController error constants
2009-12-16 16:11:42 -06:00
Ryan Bigg
25550d9022
[].from(0) actually returns [], not nil
2009-12-17 07:41:40 +10:00
Joshua Peek
7ee5843c3c
Fully expand relative rails framework paths and make sure we aren't
...
adding any to the load path more than once.
2009-12-16 11:56:51 -06:00
Joshua Peek
1ab35020c1
Hush AMo test suite
2009-12-16 11:05:48 -06:00
Joshua Peek
c4df013852
ARes rake task should not worry about AS being in path
2009-12-16 11:03:40 -06:00
Joshua Peek
e1ee13e5fb
Hush ARes test suite
2009-12-16 11:03:13 -06:00
Joshua Peek
1ca567e634
Hush AM test suite
2009-12-16 10:56:10 -06:00
Joshua Peek
ee51ddcc27
Hush AS test suite
2009-12-16 10:52:52 -06:00
Will
bf6af5f719
When passing force_reload = true to an association, don't use the query cache [ #1827 state:resolved]
...
Signed-off-by: Joshua Peek <josh@joshpeek.com >
2009-12-16 10:49:53 -06:00
Ryan Bigg
b67dc00eae
Add options_from_collection_for_select to select_tag doco [hat-tip to anathematic]
2009-12-16 18:28:04 +10:00
Carl Lerche
1b27f5c4f7
Add the ability for plugins to set default configuration settings.
2009-12-15 22:13:52 -08:00
Joshua Peek
f0bbc647c2
Procs don't call themselves
...
Fixes dev mode reloading [#3574 state:resolved]
2009-12-15 10:48:56 -06:00
Geoff Buesing
a4b19277b2
Add test for TimeWithZone#to_i with wrapped DateTime
2009-12-15 08:28:24 -06:00
Serguei Filimonov
2ae8300489
Added #to_i to DateTime in ActiveSupport so #to_yaml works correctly on ActiveRecord models with DateTime attributes.
2009-12-15 08:15:21 -06:00
David Heinemeier Hansson
7b61541ea5
Add Enumerable#exclude? to bring parity to Enumerable#include? and avoid if !x.include?/else calls [DHH]
2009-12-14 18:00:14 -08:00
Joshua Peek
5f8e48cbd2
Move route reloading into railties
2009-12-14 17:54:41 -06:00
Joshua Peek
ce970a8bb9
Remove route loading tests since it should be tested by railties
2009-12-14 16:52:22 -06:00
Joshua Peek
ec99eca013
Fix loading plugin and engine route sets
2009-12-14 16:51:13 -06:00
Joshua Peek
70c3e825fc
Fix response_body warning in AC
2009-12-14 16:07:46 -06:00
Joshua Peek
bcb686054a
Hush loading AR unless it fails
2009-12-14 16:01:23 -06:00
Joshua Peek
819a353c44
Hush AP test suite
2009-12-14 15:55:05 -06:00
Joshua Peek
1c52bca266
Fix warning in AC flash
2009-12-14 15:54:27 -06:00
Joshua Peek
2130566acf
Fix warnings in AD::Response
2009-12-14 15:47:52 -06:00
Joshua Peek
f70079efb1
Fix warnings in railties configuration and initializeable
2009-12-14 15:42:48 -06:00
Yehuda Katz
ffb351713e
Modify backtrace test to take implementations with slightly different backtrace output into consideration.
2009-12-13 10:40:00 -05:00
Yehuda Katz
0f7f90d25b
Extract descendents a bit so it can take advantage of Rubinius' __subclasses__.
2009-12-13 10:39:10 -05:00
Joshua Peek
25bb301d9c
Forgot to revert tests from that last commit
2009-12-12 21:03:45 -06:00
Joshua Peek
8a50f8a545
Revert "Fix instance_eval calls to association proxies"
...
I think it may of broke the build. Lets see.
This reverts commit 49e943c4f0 .
Conflicts:
activerecord/test/cases/associations/has_many_associations_test.rb
2009-12-12 19:58:54 -06:00
Joshua Peek
39b708be96
rendering controller needs base
2009-12-12 19:50:12 -06:00
Joshua Peek
71cd5b9568
Don't require AD test_case
2009-12-12 19:44:52 -06:00
Joshua Peek
289c9a24fc
Nearly all AC modules can be deferred
2009-12-12 19:41:58 -06:00
Joshua Peek
9cc9949817
All AbstractController modules are deferrable
2009-12-12 19:28:03 -06:00
Joshua Peek
4b4e517bf1
Relocate AbstractController exceptions into their proper parent modules
2009-12-12 18:48:34 -06:00
Joshua Peek
018dafe574
Allow autoloads to opt out of eager loading
2009-12-12 18:41:26 -06:00
Joshua Peek
ee395fe626
TestProcess belongs in AD
2009-12-12 18:09:44 -06:00
José Valim
cf7b94c013
Merge branch 'master' of git://github.com/rails/rails
2009-12-11 19:24:32 -02:00
John Pignata
96deabace7
Fix postgresql AR test failure
...
Due to the ordering of the returning result set, the test fails under the postgresql adapter. Order results by id prior to checking the first item
[#3542 state:committed]
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2009-12-11 15:15:12 -06:00
Joshua Peek
2297eaed5b
"new" and "edit" name routes always need to be prepend to the
...
named_route [#3561 state:resolved]
2009-12-11 12:46:50 -06:00
Joshua Peek
61e9f2023b
Use rackmounts recognize api and don't piggyback recognize_path on
...
top of rack call
2009-12-11 00:11:16 -06:00
Joshua Peek
588225f885
Remove fancy method not allowed resource exceptions since they are
...
too much of a hack
2009-12-11 00:01:22 -06:00
Joshua Peek
2f90d70049
Kill RouteSet#recognize
2009-12-10 23:45:04 -06:00
Joshua Peek
d1191507bc
Cleanup generate_extras build/parse mess
2009-12-10 22:57:07 -06:00
Joshua Peek
1b82590c36
Reduce usage of interpret_status. It should also return a integer
...
not a string.
2009-12-10 22:02:50 -06:00
Nathan Weizenbaum
c517a4fb9a
Add autoloads for ActionView::Template* classes, and an ActionView::TemplateError alias for ActionView::Template::Error.
...
Signed-off-by: Yehuda Katz <wycats@Yehuda-Katz.local >
2009-12-10 13:11:21 -08:00
Yehuda Katz
8b9275340f
Merge branch 'master' of github.com:rails/rails
2009-12-10 13:11:15 -08:00
Joshua Peek
ec5434c3c2
Check block arity passed to routes draw so you don't need to use
...
|map|
2009-12-09 20:46:32 -06:00
Joshua Peek
b2ef6d13f0
Fixed old routing mapper example in generated routes.rb
2009-12-09 20:39:42 -06:00
Joshua Peek
0fec53f243
Scaffolding generates new routing dsl examples
2009-12-09 18:57:16 -06:00
Carlhuda
f9d570bdd8
Simpler RenderOption API -- removes the need for registering the types and extending a module
2009-12-09 13:40:49 -08:00
Joshua Peek
9fbde11b8b
More test porting
2009-12-08 17:41:00 -06:00
Joshua Peek
511cef296b
Tack format onto resource routes
2009-12-08 17:19:49 -06:00
Joshua Peek
2be5e088d2
Use new routing dsl in tests
2009-12-08 16:52:26 -06:00
Joshua Peek
ac711043ec
Fix ambiguous access_token scoping example
2009-12-08 16:15:25 -06:00
Joshua Peek
ce5f27b04b
Remove double scoping blocks and just use one
2009-12-08 16:13:00 -06:00
Joshua Peek
c4df6332a4
Seperate scope level for nesting resources
2009-12-08 16:06:46 -06:00
Joshua Peek
33658ea1ae
Don't use name prefix by itself unless as is an empty string
2009-12-08 15:50:44 -06:00
Joshua Peek
3d91d7f0a2
Routes added under resource collection should be prefixed with
...
resource collection name
2009-12-08 15:31:56 -06:00
Joshua Peek
1fc58a889d
Fixed named prefix scope in resource member and collection actions
2009-12-07 20:57:01 -06:00
Joshua Peek
0c34e3f41a
Ignore name_prefix unless there is an explicit name
2009-12-07 20:11:57 -06:00
Joshua Peek
81d7227c9b
Move base mapper methods into Base module so plugins can easily
...
extend the mapper
2009-12-07 19:59:23 -06:00
Joshua Peek
e86a82c52c
Move name_prefix merging into Scoping concern
2009-12-07 19:50:13 -06:00
Joshua Peek
e600b41c7f
Cleanup resource scoping by passing down the parent resource object
...
in the scope
2009-12-07 19:47:47 -06:00
Joshua Peek
5835447b6f
named_prefix doesn't join with "_"
2009-12-07 19:31:29 -06:00
Joshua Peek
e8489b43e2
Allow name_prefix to be pass into scope
2009-12-07 19:24:33 -06:00
Joshua Peek
40ad54e381
Allow scope to take :path and :controller options
2009-12-07 18:28:02 -06:00
Joshua Peek
66375434b6
Pass symbol in as route name when match is used with a symbol
2009-12-07 17:22:09 -06:00
José Valim
2ecfa817c9
Responder redirects to resource if destroy fails.
...
Signed-off-by: Yehuda Katz <wycats@Yehuda-Katz.local >
2009-12-07 15:05:27 -08:00
José Valim
324fa688fc
Make controller.flash public to be used in responders.
...
Signed-off-by: Yehuda Katz <wycats@Yehuda-Katz.local >
2009-12-07 15:05:12 -08:00
Joshua Peek
48127c637c
Deprecate recalling generation params when the defaults are nil
2009-12-06 20:40:07 -06:00
Jeremy Kemper
63e435955e
Ruby 1.9.2: explicitly raise NoMethodError for explicit coercion attempts
2009-12-06 18:22:09 -08:00
Jeremy Kemper
071af66e9e
Ruby 1.9.2: explicitly raise NoMethodError for explicit coercion attempts. Calling super gives us NameErrors.
2009-12-06 18:03:18 -08:00
Jeremy Kemper
adc2115132
Remove assert_raises usage that only test-unit 1 supports. Breaks minitest and test-unit 2.
2009-12-06 17:23:43 -08:00
Joshua Peek
4663f75f6b
Update rackmount to fix some pending tests
2009-12-05 13:10:00 -06:00
Gabe da Silveira
32395899d7
Replace reset_counter_cache with reset_counters that has API inline with existing update_counters method
...
[#1211 state:committed]
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2009-12-03 23:25:11 -08:00
Ben Marini
e55284e825
Add support for Mysql column positioning via #add_column and #change_column
...
add_column and change_column in the Mysql adapter now accept some
additional options:
:first => true # Put the column in front of all the columns
:after => column_name # Put the colmn after 'column_name'
add_column :new_col, :string, :first => true
add_column :another_col, :integer, :default => 0, :after => :new_col
[#3286 state:committed]
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2009-12-03 23:09:57 -08:00
Xavier Noria
c4083ed4c3
revises an example in docs about habtm & fixtures
2009-12-03 23:13:06 +01:00
Yehuda Katz
96e0638ce2
Should fix a few Sam Ruby fails.
2009-12-03 09:06:01 -08:00
Robby Russell
02ae6d3927
Adding the directory tree of a generated Rails app.
2009-12-03 23:22:28 +08:00
Robby Russell
716ac913af
Added links to web server options to their respective websites to save people the trouble of having to google them.
2009-12-03 23:22:28 +08:00
Robby Russell
5a19236fca
Updating documentation for Console. Now mentioniing sandbox and including a link to the irb section in the online Pickaxe.
2009-12-03 23:22:27 +08:00
Carlhuda
c1304098cc
Reorganize autoloads:
...
* A new module (ActiveSupport::Autoload) is provide that extends
autoloading with new behavior.
* All autoloads in modules that have extended ActiveSupport::Autoload
will be eagerly required in threadsafe environments
* Autoloads can optionally leave off the path if the path is the same
as full_constant_name.underscore
* It is possible to specify that a group of autoloads live under an
additional path. For instance, all of ActionDispatch's middlewares
are ActionDispatch::MiddlewareName, but they live under
"action_dispatch/middlewares/middleware_name"
* It is possible to specify that a group of autoloads are all found
at the same path. For instance, a number of exceptions might all
be declared there.
* One consequence of this is that testing-related constants are not
autoloaded. To get the testing helpers for a given component,
require "component_name/test_case". For instance, "action_controller/test_case".
* test_help.rb, which is automatically required by a Rails application's
test helper, requires the test_case.rb for all active components, so
this change will not be disruptive in existing or new applications.
2009-12-02 20:01:08 -08:00
José Valim
6e55b32e98
Merge branch 'master' of git://github.com/rails/rails
2009-12-02 22:29:34 -02:00
Joshua Peek
399909b11c
Use to_query in route query string generation
2009-12-02 15:23:26 -06:00
Joshua Peek
856d2fd874
Quick fix for not escaping []s (not ideal)
2009-12-02 15:17:08 -06:00
Joshua Peek
1ee9b40b18
Failing tests for to_param/to_query not escaping "[]"
2009-12-02 15:08:42 -06:00
Mat Brown
49e943c4f0
Fix instance_eval calls to association proxies
...
In the current stable, ActiveRecord::Associations::AssociationProxy#method_missing calls yield() if a block is given, causing the block to always be evaluated in its calling context. However, in the case of instance_eval, correct behavior requires that the block be passed directly to the @target, rather than being evaluated inside a different block. Incidentally, this also simplifies the code slightly.
[#3412 state:committed]
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2009-12-02 12:47:09 -08:00
Mike Breen
50c28e78c7
Implement ActiveRecord#reset_counter_cache
...
[#1211 state:committed]
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2009-12-02 12:20:00 -08:00
Joshua Peek
de2cd8e39f
Merge branch 'master' of github.com:rails/rails
2009-12-02 14:12:35 -06:00
Joshua Peek
8db038227c
Move controller namespace tracking into route set so it gets
...
reloaded in dev mode
2009-12-02 14:10:22 -06:00
Carlhuda
c446b1b12b
Ignore all pkg files
2009-12-02 11:35:48 -08:00
Carlhuda
6680f9c4d7
Fix an ivar name conflict in Rails::Server
2009-12-02 11:35:47 -08:00
Carlhuda
fe41c7030b
Stop evalling the environment file in favor of require + setting a Kernel#config. This will fix the bug where reopening classes caused them to be overwritten.
2009-12-02 11:35:47 -08:00
Carlhuda
39034997d1
Add support for bare ActiveSupport via config.active_support.bare
2009-12-02 11:35:47 -08:00
Carlhuda
8ff310aef4
Break up rails and railties:
...
* rails is now a metagem (gem install rails works as it does now)
* railties includes the glue layer, so you can easily declare dependencies
on railties, actionpack, and actionmailer and not get ActiveRecord's rake
tasks, initializers, etc.
2009-12-02 11:35:47 -08:00
Carlhuda
abfc4dad3e
Remove global Rails initializers
2009-12-02 11:35:47 -08:00
Joshua Peek
4dee277a9b
Stop escaping "[]" in query string
2009-12-02 12:46:14 -06:00
Joshua Peek
c0949cc8f6
Rackmount 0.3.0
2009-12-02 12:38:25 -06:00
Joshua Peek
84be6cfb64
Fork rack build nested query to support to_param
2009-12-02 12:33:33 -06:00
Jeremy Kemper
de40bc033a
Ensure Cache-Control max-age is an integer
2009-12-02 03:23:00 -08:00
Joshua Peek
ad26f066fe
Response#write is defined twice (this is why -w is good)
2009-12-01 23:29:28 -06:00
Joshua Peek
f22db809c9
Response#cache_control is defined later
2009-12-01 23:27:40 -06:00
Joshua Peek
e12380e787
Remove concat before overriding it
2009-12-01 23:25:24 -06:00
Joshua Peek
70d0b7c87a
Fix parens warning in ajax test
2009-12-01 23:19:41 -06:00
Joshua Peek
75ae5bb022
cache_store and page_cache_directory are already defined in caching
...
and pages
2009-12-01 23:14:03 -06:00
Joshua Peek
5d9af09563
Silence known internal AM deprecation calls
2009-12-01 23:01:21 -06:00
Joshua Peek
97be8537eb
Fix @renderer warning
2009-12-01 22:58:56 -06:00
Joshua Peek
2fbd6f46fd
Simply track controller namespaces instead of a complete list of
...
possible controllers to route to
2009-12-01 22:48:42 -06:00
Joshua Peek
7fe19d415a
Make recognize try to constantize controller to see if it exists
2009-12-01 22:22:48 -06:00
Joshua Peek
30ae3538a3
Some basic route discovery tests
2009-12-01 21:19:20 -06:00
José Valim
28657e4f41
Update vendored thor and ensure that content is completely modified before checking file collisions.
...
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2009-12-01 17:51:10 -08:00
Jeremy Kemper
74be70039f
Avoid using unrequired core extensions
2009-12-01 15:07:41 -08:00
Jeremy Kemper
544de09631
rails:update:configs updates boot.rb and the rest of config/*
2009-12-01 13:37:29 -08:00
Jeremy Kemper
df9f5e771b
Reinstate rails:update:configs task removed in e1fdc8b
2009-12-01 13:37:29 -08:00
Jeremy Kemper
fe319103db
Fix rails:update:scripts
2009-12-01 13:37:29 -08:00
Joshua Peek
44587b7fae
Merge branch 'master' of github.com:rails/rails
2009-12-01 14:53:39 -06:00
Joshua Peek
61a31f3d3d
Fix generating params with optional defaults [ #3404 state:resolved]
2009-12-01 14:52:19 -06:00
Jeremy Kemper
0c4990b5f4
Fix caching test to ensure notifications are all delivered
2009-12-01 12:19:42 -08:00
José Valim
6e30361260
Allow ActionController::Responder to have a common entry point for all formats.
...
Signed-off-by: Yehuda Katz <wycats@Yehuda-Katz.local >
2009-12-01 08:23:43 -08:00
José Valim
c2e97cb410
Merge branch 'master' of git://github.com/rails/rails
2009-12-01 13:00:34 -02:00
Jonathan Lim
0da0072b01
assert_recognizes with a hash as first argument, needs to enclose arguments in brackets
2009-11-30 12:24:18 +00:00
Jonathan Lim
a5cf2a95f4
assert_routing with a hash as first argument, needs to enclose arguments in brackets
2009-11-30 12:20:35 +00:00
Joshua Peek
6ac32a8328
Define a welcome controller in mailer tests
2009-11-29 18:28:45 -06:00
Joshua Peek
075f50d62c
Fix some nested resource generation tests
2009-11-29 18:17:14 -06:00
Joshua Peek
f69f9820ee
Wrap up http related routing helpers
2009-11-29 17:45:12 -06:00
Joshua Peek
312c3bfa24
Break down long match routing method
2009-11-29 17:39:37 -06:00
Joshua Peek
5da01a92c7
Make use of extract_options!
2009-11-29 17:01:14 -06:00
Joshua Peek
40ae2070d5
Extract Resource and SingletonResource helper objects
2009-11-29 16:59:44 -06:00
Joshua Peek
8815fefd16
Bump required rack-mount version to 0.2.3
2009-11-29 15:34:46 -06:00
Joshua Peek
b87c13242c
Remove rackmount submodule
2009-11-29 15:26:55 -06:00
Joshua Peek
3f025e6408
Resource collection should be defined before member routes
2009-11-29 15:23:27 -06:00
Jeremy Kemper
327545c3ae
Notifications: synchronous fanout queue pushes events to subscribers rather than having them concurrently pull
2009-11-29 02:30:35 -08:00
Bryan Helmkamp
bb84cab2fc
Update reference to deprecated constant to avoid warnings
2009-11-28 23:41:03 -08:00
Yehuda Katz
45d8ff08a4
Remove reference to class that doesn't exist (ht: brynary)
2009-11-28 21:36:58 -08:00
Jeremy Kemper
4f2a04cc08
Notifications: extract central Notifier, cordon off the internal Fanout implementation, and segregate instrumentation concerns
2009-11-28 12:50:09 -08:00
Jeremy Kemper
02893d1705
Remark that Listener is an implementation detail
2009-11-28 12:50:09 -08:00
Jeremy Kemper
ddf681ce1d
Expose a simple Queue#wait to block until all notifications are drained
2009-11-28 12:50:09 -08:00
Jeremy Kemper
6f7fc5824f
Revert "Create SyncListener. Since they do not rely on Thread, they can be used on Google App Engine."
...
Take a step back on this API direction.
This reverts commit 8104f65c32 .
2009-11-28 12:50:09 -08:00
Jeremy Kemper
eeb1afa200
Expand path relative to __FILE__
2009-11-28 12:50:09 -08:00
Michael Koziarski
7e0aa35c20
avoid generating invalid SMTP commands in ruby pre 1.9
...
Signed-off-by: Michael Koziarski <michael@koziarski.com >
Conflicts:
actionmailer/lib/action_mailer/base.rb
2009-11-28 13:34:05 +13:00
José Valim
fc3629f6ca
Merge branch 'master' of git://github.com/rails/rails
2009-11-25 23:25:32 -02:00
Carl Lerche
02c3c9dfbc
Fix the application.rb generator
2009-11-25 14:52:56 -08:00
Carl Lerche
25b8e996bd
Fix the rackup test to correctly use Rack::Builder.parse_file
2009-11-25 14:45:12 -08:00
Carl Lerche
34eac1cf1c
Load application specific rake tasks in the application object
2009-11-25 14:29:28 -08:00
Jeremy Kemper
71a6b0465b
Revert "macruby: no format_datetime or msg2str"
...
Obviated by fix in macruby trunk.
This reverts commit 6d91e7dca1 .
2009-11-24 17:15:35 -08:00
Carlhuda
530b8ff5ae
Have script/* and Rakefile use the application object
2009-11-24 14:36:30 -08:00
Carlhuda
a2cb90c0c2
Refactor script/dbconsole into an object
2009-11-24 13:05:21 -08:00
Jeremy Kemper
d8c5ea76bc
Use Rails.env after loading environment
2009-11-24 10:46:16 -08:00
Joshua Peek
fa007e591d
Quieter rake test runner
2009-11-24 12:04:36 -06:00
José Valim
41e607dee2
Merge branch 'master' of git://github.com/rails/rails
2009-11-24 09:24:40 -02:00
Mikel Lindsaar
5f2395041d
Merge branch 'master' of git://github.com/rails/rails into rails_master
2009-11-24 21:45:14 +11:00
Jeremy Kemper
e62e6d4099
Add a dead --irb option mentioning upgrade path
2009-11-23 22:09:36 -08:00
Jeremy Kemper
0088ceb6fa
Set RAILS_ENV before loading config/environment
2009-11-23 22:07:37 -08:00
Joshua Peek
59dbae145b
Privatize Routing.possible_controllers and fix brittle url helper
...
controller test loading.
2009-11-23 21:50:21 -06:00
Joshua Peek
15ab3a98a1
Find all controllers in memory to use for routing
2009-11-23 20:20:50 -06:00
Joshua Peek
f987e8561c
with_controllers is no longer used
2009-11-23 19:45:42 -06:00
Joshua Peek
8d351eac07
Extract Routing.controller_constraints
2009-11-23 19:44:43 -06:00
Carlhuda
53d7acdf4f
Refactor script/console into an object and use IRB.start instead of calling exec.
2009-11-23 17:28:50 -08:00
Carlhuda
a080323cb0
Refactor script/server into an object that inherits from Rack::Server
2009-11-23 17:28:50 -08:00
Carlhuda
58dec09353
Update rails application root detection to take into consideration a callstack that includes the rack library
2009-11-23 17:28:50 -08:00
Carlhuda
c102db9367
Updates notifications tests in railties to reflect changes to the notifications API
2009-11-23 17:28:50 -08:00
Joshua Peek
350d3daa88
Remove inflection reloads routes test
2009-11-23 19:25:39 -06:00
Joshua Peek
01c9f99c53
Kill dead routing internals helpers
2009-11-23 19:17:53 -06:00
Joshua Peek
ef771552b7
Don't really care about reloading routes when inflections are
...
changed.
2009-11-23 18:59:48 -06:00
José Valim
16cf25e717
Merge branch 'master' of git://github.com/rails/rails
2009-11-23 22:40:55 -02:00
Jeremy Kemper
eeb1f472a5
RAILS_ENV falls back to RACK_ENV
2009-11-23 16:10:51 -08:00
Joshua Peek
0ddba7cf66
Require rackmount >= 0.2.2
2009-11-23 18:07:18 -06:00
José Valim
4ff66b6b85
Merge branch 'master' of git://github.com/rails/rails
2009-11-23 22:04:18 -02:00
Yehuda Katz
934bb012ba
Fixes remote errors in isolation tests
2009-11-23 15:42:25 -08:00
Jeremy Kemper
ada895e8ca
Merge branch 'master' into mail
2009-11-23 15:32:41 -08:00
Jeremy Kemper
671538cd6e
Merge commit 'mikel/master' into mail
...
Conflicts:
actionmailer/lib/action_mailer.rb
2009-11-23 15:29:35 -08:00
Mikel Lindsaar
3a72923e27
Change require mail version to 1.3.0
2009-11-24 09:38:00 +11:00
Mikel Lindsaar
2e453d930d
Changed deprecation to use ActiveSupport::Deprecation
2009-11-24 09:33:05 +11:00
Jeremy Kemper
f8d06e62a9
Pending test now passing
2009-11-23 14:07:54 -08:00
David Heinemeier Hansson
35eda7d6d2
Fixed that the debugger wouldn't go into IRB mode because of left-over ARGVs [DHH]
2009-11-23 15:36:48 -06:00
Jeremy Kemper
78790e47b8
Revert "Revert "Assert primary key does not exist in habtm when the association is defined, instead of doing that everytime a record is inserted.""
...
This reverts commit 2b82708b0e .
[#3128 state:resolved]
Conflicts:
activerecord/lib/active_record/associations.rb
activerecord/lib/active_record/associations/has_and_belongs_to_many_association.rb
2009-11-23 10:42:32 -08:00
Jeremy Kemper
ca5de16ddc
Add mail dep to AM gemspec
2009-11-23 09:57:53 -08:00
José Valim
d0aa0cfbd7
Ensure generator fallbacks work even when a context is given.
...
Signed-off-by: Yehuda Katz <wycats@Yehuda-Katz.local >
2009-11-23 09:08:48 -08:00
José Valim
d6f10126eb
Also load generators at lib/rails_generators.
...
Signed-off-by: Yehuda Katz <wycats@Yehuda-Katz.local >
2009-11-23 09:08:33 -08:00
José Valim
8104f65c32
Create SyncListener. Since they do not rely on Thread, they can be used on Google App Engine.
...
Signed-off-by: Yehuda Katz <wycats@Yehuda-Katz.local >
2009-11-23 09:08:17 -08:00
Mikel Lindsaar
906e308220
Fixed up incompatible encoding problem for Ruby 1.9 in test suite
2009-11-23 20:58:22 +11:00
Mikel Lindsaar
cc391c3022
Deprecating attachment :body => 'string' in favour of attachment :data => 'string'
2009-11-23 20:53:07 +11:00
Mikel Lindsaar
a6eed86c33
Removing utils, and updating requires to match
2009-11-23 20:50:49 +11:00
Jeremy Kemper
d98fee67e2
Never require jcode
2009-11-22 15:41:29 -08:00
Jeremy Kemper
e6bce95580
Rely on gemspec and bundled env for gem dependency. We just require it.
2009-11-22 15:08:01 -08:00
Jeremy Kemper
0f9029ec48
Explicit source no longer needed, default gems source points to gemcutter.
2009-11-22 14:34:11 -08:00
Jeremy Kemper
c5509a056c
Bundle mail 1.2.8
2009-11-22 13:00:31 -08:00
Jeremy Kemper
e68bc3f14e
Merge commit 'origin/master' into mail
2009-11-22 10:31:47 -08:00
Mikel Lindsaar
3cb46b40a0
Opps.. need to require it as well as gem mail :)
2009-11-22 23:36:30 +11:00
Mikel Lindsaar
06c5270343
Adding mail as a gem load
2009-11-22 23:34:39 +11:00
Mikel Lindsaar
747d56881a
131 tests, 309 assertions, 0 failures, 0 errors
2009-11-22 23:20:57 +11:00
Jeremy Kemper
6d91e7dca1
macruby: no format_datetime or msg2str
2009-11-21 19:11:50 -08:00
José Valim
5ecee1cd54
More improvements to generators guide.
2009-11-22 10:51:48 +08:00
José Valim
0468201778
More improvements to Rails Generators Guide.
2009-11-22 10:51:48 +08:00
José Valim
8f669ee465
First version of Generators guides
2009-11-22 10:51:48 +08:00
Mike Naberezny
a2bf741385
Fixed grammar.
2009-11-21 15:51:59 -08:00
Mike Naberezny
0a9f8dc2ec
Updated link to RedCloth.
2009-11-21 15:49:42 -08:00
Jeremy Kemper
e1935e3c0c
Fix Rails::Rack::Static deprecated constant proxy
2009-11-21 10:45:42 -08:00
Mikel Lindsaar
f6f70540bb
Updating tests for Mail gem
2009-11-22 00:04:36 +11:00
Mikel Lindsaar
0e38f5bdcc
131 tests, 266 assertions, 9 failures, 6 errors
2009-11-21 23:55:53 +11:00
Mikel Lindsaar
6456a08334
Down to 13 failures, 14 errors
2009-11-20 22:01:40 +11:00
Mikel Lindsaar
a5e6295d72
Down to 30 failures total
2009-11-20 21:19:10 +11:00
Cheah Chu Yeow
14ee31cdd0
Indicate that the :method routing condition can also accept an array of HTTP methods.
2009-11-20 14:06:42 +08:00
Mikel Lindsaar
539d9b355f
More updates... 45 errors left to get it working with Mail gem
2009-11-20 14:10:57 +11:00
Jeremy Kemper
0ce9206541
Update gemspec also
2009-11-19 18:31:50 -08:00
Joshua Peek
74a0fb9722
Should be rackmount 0.2
2009-11-19 18:08:38 -08:00
Joshua Peek
4236473e31
Depend on rack-mount 0.0.2
2009-11-19 17:59:26 -08:00
Joshua Peek
6e67f88a11
Extended and case insensitive regexp routes aren't that important.
...
Mark them as pending till I figure it out.
2009-11-19 17:58:57 -08:00
Joshua Peek
4b325fcd1a
Update routing for rackmount 0.2 api changes
2009-11-19 17:58:57 -08:00
Jeremy Kemper
c7c39f52dc
Revert "Final steps toward clean rails "foo"; cd foo; gem bundle; script/server working"
...
Broke stuff.
This reverts commit 520b8b5911 .
2009-11-19 15:24:00 -08:00
Joshua Peek
5df26dd7a9
Add basic nested named route support to new routing dsl. Also add a
...
bunch of pending tests.
2009-11-19 09:04:53 -08:00
Jeremy Kemper
0dfd993e77
Fix test bleed
2009-11-18 17:54:27 -08:00
Xavier Noria
78c1127a63
documents that the REXML security fix is still needed to support all 1.8.7 patchlevels
2009-11-19 01:31:57 +01:00
Yehuda Katz + Carl Lerche
520b8b5911
Final steps toward clean rails "foo"; cd foo; gem bundle; script/server working
2009-11-18 16:28:37 -08:00
Xavier Noria
2ddbef421c
explains the motivation for duplicable?
2009-11-19 00:10:19 +01:00
Jeremy Kemper
4403dfac6c
Check whether another lib has implemented ruby 1.9 string interp syntax
2009-11-18 11:33:41 -08:00
Jeremy Kemper
e1385be025
Extract form_authenticity_param instance method so it's overridable in subclasses
2009-11-17 23:40:06 -08:00
Gabe da Silveira
ea290e77e6
Insert generated association members in the same order they are specified when assigning to a has_many :through using the generated *_ids method
...
[#3491 state:committed]
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2009-11-17 22:25:40 -08:00
Jeremy Kemper
fb61fbd352
Revert "Ensure Model#destroy respects optimistic locking"
...
[#1966 state:open]
This reverts commit 0d922885fb .
Conflicts:
activerecord/lib/active_record/locking/optimistic.rb
2009-11-17 15:35:35 -08:00
Pratik Naik
5446d5cb05
Merge remote branch 'mainstream/master'
...
Conflicts:
activesupport/lib/active_support/core_ext/hash/conversions.rb
2009-11-17 22:47:23 +00:00
Joshua Peek
f8877d4b2a
Merge remote branch 'Fingertips/master'
2009-11-16 21:03:27 -06:00
Yehuda Katz
c2997017f7
Make script/server work with correct application.rb
2009-11-16 13:58:08 -08:00
Yehuda Katz
2675ba9ef4
Require action_dispatch, not action_controller
2009-11-16 12:37:43 -08:00
Yehuda Katz
c1f5168073
Temporarily add submodules to the Rails repo for Arel and Rack::Mount. These submodules will be removed once we add proper Gemfile following to bundler
2009-11-16 12:30:06 -08:00
Will Read
7fadb3f261
Allow explicit placement of hidden id element for nested models.
...
[#3259 state:resolved]
Signed-off-by: Eloy Duran <eloy.de.enige@gmail.com >
2009-11-15 21:47:57 +01:00
Jeremy Kemper
7601d482bd
Ruby 1.9: skip pg locking test for 1.9.1 also
2009-11-15 10:28:58 -08:00
Yehuda Katz
cc011bc2be
Add TimeZone dependency
2009-11-14 19:33:58 -08:00
Jeremy Kemper
bc1538e995
Repair time dependencies
2009-11-14 11:37:06 -08:00
Jeremy Kemper
74e1ff9dc2
Loosen optional gem deps from ~> to >=
2009-11-14 03:32:35 -08:00
Jeremy Kemper
3ee9b8f2b2
Remove Gemfile deps duplicated from AP gemspec
2009-11-14 03:27:18 -08:00
Jeremy Kemper
795213a5f4
Just use abstract_unit
2009-11-14 03:27:18 -08:00
Jeremy Kemper
313a7ea9d6
Fix bundler environment check
2009-11-14 03:27:18 -08:00
Jeremy Kemper
61843595ea
No need for test stub
2009-11-14 03:27:18 -08:00
Jeremy Kemper
364a8f3902
No need to check for generated method, just redispatch
2009-11-14 01:51:52 -08:00
Jeremy Kemper
6ebb061b18
Ruby 1.9.2: use recursive flatten
2009-11-14 01:50:47 -08:00
Jeremy Kemper
f0f4dffd3b
Skip pg locking test due to connection checkout deadlock detection
2009-11-14 01:22:36 -08:00
Jeremy Kemper
7eb4f2ecc5
Consolidate date & time landscape: require 'active_support/time'
2009-11-14 01:13:54 -08:00
Jeremy Kemper
92253829de
Ruby 1.9.2: fix flatten_deeper to preserve nils
2009-11-14 01:12:49 -08:00
Jeremy Kemper
58c0d31487
Notifications: queue.drained? for testability in place of brittle sleeps
2009-11-13 20:58:38 -08:00
Jeremy Kemper
66fda6b894
Fix duration check for longer sleep
2009-11-13 19:28:59 -08:00
Jeremy Kemper
7ab78b9ccd
CI: slow down brittle notifications tests
2009-11-13 18:57:10 -08:00
Jeremy Kemper
7b3d85db4c
Revert "Split arel_table into method to get a relation and another to memoize the default relation."
...
This reverts commit bd51790895 .
2009-11-13 15:30:51 -08:00
Jeremy Kemper
3f54f3100b
Ruby 1.9.2: StringIO no longer has #path
2009-11-13 13:10:28 -08:00
Jeremy Kemper
2841a14f4b
Ruby 1.9.2: fix broken to_ary expectation
2009-11-13 12:42:49 -08:00
Jeremy Kemper
9acc824d96
Ruby 1.9.2: disallow explicit coercion via method_missing. Only give friendly nil errors for Array and Active Record methods.
2009-11-13 12:25:54 -08:00
Jeremy Kemper
0214d337b3
Rescue handlers should never need array wrapping. Bug if so.
2009-11-13 11:00:18 -08:00
Jeremy Kemper
bd51790895
Split arel_table into method to get a relation and another to memoize the default relation.
2009-11-13 10:53:19 -08:00
Jeremy Kemper
0da71980cd
Missing customers fixture
2009-11-13 10:38:23 -08:00
Jeremy Kemper
3fd2624be4
Uses Hash#reverse_merge
2009-11-13 10:31:05 -08:00
Jeremy Kemper
fbbf0086ca
Ruby 1.9.2: avoid #flatten
2009-11-13 09:52:53 -08:00
Jeremy Kemper
18d4976516
Prefer Array.wrap to Array()
2009-11-13 09:52:53 -08:00
Jeremy Kemper
f07bcf015e
Ruby 1.9.2: work around Array allowing method_missing for to_ary
2009-11-13 09:52:53 -08:00
Jeremy Kemper
c0ebc21493
Test that Array.wrap works with proxy objects and structs
2009-11-13 09:52:52 -08:00
José Valim
2cb47c742f
Split mime responder into smaller chunks and allow action to be configured.
...
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2009-11-13 09:52:52 -08:00
Joshua Peek
a28d0ea33e
Remove rackmount const usage
2009-11-12 23:33:30 -06:00
Jeremy Kemper
2da432dde3
Always bundle pg and mysql for AR tests
2009-11-12 11:26:55 -08:00
David Vrensk
af44b07649
Rdoc for changes introduced in e2ed1a1ca, 36058f450.
...
[#3451 state:committed]
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2009-11-12 11:21:44 -08:00
Mikel Lindsaar
15d7cac282
Starting again on actionmailer integration with mail
2009-11-12 16:08:50 +11:00
Yehuda Katz + Carl Lerche
82b9b151ff
Refactor plugins
2009-11-11 18:09:16 -08:00
José Valim
01ae99c681
Merge branch 'master' of git://github.com/rails/rails
2009-11-11 08:16:25 -02:00
Jeremy Kemper
fca32eb6c5
Update AR logger subscriber for Notifications subscriber args change
2009-11-11 01:43:58 -08:00
Jeremy Kemper
322b6b29c2
test-unit 2: filter_backtrace is private
2009-11-10 21:04:00 -08:00
Jeremy Kemper
0df1dc5a72
CI: yeah, run those tests
2009-11-10 17:19:39 -08:00
Jeremy Kemper
486a63c258
CI: short-circuit at first failing task. Chmod 755 bin, vendor, vendor/gems
2009-11-10 17:13:43 -08:00
Jeremy Kemper
1ac8e0662f
Rack: HTTPS is either 'on' or 'off' as of 9b7a0569e4067d0c23a00fc24273436e85c56d7f
2009-11-10 16:57:55 -08:00
Jeremy Kemper
215fa16734
CI: list bundled gems in build environment
2009-11-10 16:54:15 -08:00
Jeremy Kemper
bbb3e5a858
Unify test:isolated across components and run by default at toplevel
2009-11-10 16:50:15 -08:00
Jeremy Kemper
e02bff2634
CI: missed mysql gem in bundle
2009-11-10 16:50:12 -08:00
Jeremy Kemper
13280a049e
Back to rack master, rack-1.0 reverts the kind_of? String fix
2009-11-10 16:34:04 -08:00
Jeremy Kemper
631a27d6a5
Revert "Revert "Eliminate warning with layout is unset""
...
This reverts commit d8fd0499bf .
2009-11-10 16:15:43 -08:00
Jeremy Kemper
8cd486da80
test-unit 2 compat: assert_raise doesn't support regexp second arg to match exception message
2009-11-10 16:14:10 -08:00
Jeremy Kemper
d8fd0499bf
Revert "Eliminate warning with layout is unset"
...
This reverts commit 1fcf32f8fe .
2009-11-10 16:09:52 -08:00
Jeremy Kemper
c626be796c
CI: rearrange build order, AR last
2009-11-10 16:08:02 -08:00
Jeremy Kemper
60558cc753
CI: no system gems required
2009-11-10 15:59:39 -08:00
Jeremy Kemper
819bdd0f4a
Bundle rack-1.0 branch
2009-11-10 15:51:01 -08:00
Jeremy Kemper
1fcf32f8fe
Eliminate warning with layout is unset
2009-11-10 15:48:03 -08:00
Jeremy Kemper
f14eb686ef
CI: bundle test-unit on 1.9
2009-11-10 15:46:32 -08:00
Jeremy Kemper
6480850d37
Revert "Eliminate warning with layout is unset"
...
This reverts commit 90be80361f .
2009-11-10 15:43:37 -08:00
Jeremy Kemper
e889f315c8
CI: return result of last rake task
2009-11-10 15:40:54 -08:00
Jeremy Kemper
907858c1fe
CI: shush complaints about 777 perms
2009-11-10 15:32:09 -08:00
Jeremy Kemper
aef7e214bd
Use an env var to expand the CI bundle. Using bundler's 'only' includes this stuff for everybody, oops.
2009-11-10 15:28:25 -08:00
Jeremy Kemper
a7dc7cd0c4
Ruby 1.9: don't bundle fcgi at all for CI
2009-11-10 15:24:37 -08:00
Jeremy Kemper
ec2b2654e5
Make root_dir a method so rails can call it
2009-11-10 15:18:21 -08:00
Jeremy Kemper
a4aa95ba0c
Bump AR.gemspec Arel dep too
2009-11-10 15:13:38 -08:00
Jeremy Kemper
74306b9526
Use bundled bin/rake
2009-11-10 14:59:59 -08:00
Jeremy Kemper
0247262833
Rely on bundler for gem deps instead of geminstaller
2009-11-10 14:59:46 -08:00
Jeremy Kemper
a584b4c13d
Get rack from rails/rack.git. Introduce ci-only deps.
2009-11-10 14:59:22 -08:00
Jeremy Kemper
457940e684
Bump CI mocha to 0.9.8 and rack to 1.0.1
2009-11-10 14:17:40 -08:00
Jeremy Kemper
d887e46c29
Be sure to invoke the super chain! And initialize response body.
2009-11-10 14:14:17 -08:00
Jeremy Kemper
be664392c0
Eliminate warning by initializing nil formats
2009-11-10 14:13:54 -08:00
Jeremy Kemper
90be80361f
Eliminate warning with layout is unset
2009-11-10 14:13:21 -08:00
Jeremy Kemper
3bdfda0730
Bump arel dep to 0.2.pre
2009-11-10 13:52:25 -08:00
Jeremy Kemper
1874a88765
Ruby 1.9: bump CI mysql from 2.7 -> 2.8.1
2009-11-10 11:57:56 -08:00
Jeremy Kemper
5fa497abf5
Ruby 1.9: fix Relation respond_to? and method_missing
2009-11-10 11:00:50 -08:00
Jeremy Kemper
77478f21af
Resolve deadlock in pooled connections test
2009-11-10 11:00:29 -08:00
Jeremy Kemper
7ad6e9bc78
Fix generated performance test helper requires
2009-11-10 01:52:40 -08:00
Joshua Peek
38e8d5b10c
Enable warnings for mailer tests
2009-11-09 23:42:46 -06:00
Matt Jones
d625312fe1
delete correct records for a has_many with :primary_key and :dependent => :delete_all
...
Signed-off-by: Michael Koziarski <michael@koziarski.com >
2009-11-10 18:41:37 +13:00
Joshua Peek
11e798ae0f
Avoid adding component lib/ to load path multiple times
2009-11-09 23:28:36 -06:00
Joshua Peek
23229d5ad4
Remove preflight lib check during AP tests. Bundler resolves this issue
2009-11-09 22:59:30 -06:00
Joshua Peek
22b581e04c
Always add AS lib/ to path when running its test suite
2009-11-09 22:56:49 -06:00
Joshua Peek
a31ecff554
Don't warn me if I'm not using bundler to run tests
2009-11-09 22:51:48 -06:00
Joshua Peek
94058c689a
Remove automatic rubygems loading from AS test runner
2009-11-09 22:44:28 -06:00
Joshua Peek
335c0e62cd
Fix railties isolated tests if bundler environment doesn't exist
2009-11-09 22:36:30 -06:00
Joshua Peek
f03bcf2495
Don't load all of railties just for Rails::Version
2009-11-09 22:30:26 -06:00
Joshua Peek
e9d21ca903
Add pending test for generating routes with optional params that recall last
...
request
2009-11-09 22:18:51 -06:00
Jeremy Kemper
3ce6a10b67
Contortions to work around brittle naming dependency
2009-11-09 20:10:10 -08:00
Joshua Peek
763489ce06
Add pending test for route generation with default param
2009-11-09 21:54:50 -06:00
Joshua Peek
1004fcb767
Fixed AD assertion autoloads [ #3470 state:resolved]
2009-11-09 21:38:01 -06:00
Jeremy Kemper
08f7c4dd89
Revert "the REXML security fix is not needed for Ruby >= 1.8.7"
...
Still required on older 1.8.7 patchlevels.
This reverts commit a48f49e56b .
2009-11-09 19:30:02 -08:00
Jeremy Kemper
703d31c20a
Clarify failed assertion
2009-11-09 17:01:57 -08:00
Jeremy Kemper
feaa762e40
Ditto
2009-11-09 16:59:38 -08:00
Jeremy Kemper
eeac054d59
Fix missing dependency
2009-11-09 16:57:10 -08:00
Jeremy Kemper
0ac88af998
Remark when bundled env require fails
2009-11-09 16:10:37 -08:00
Xavier Noria
9754debb9a
AS guide: removes docs for String#start_with? and String#end_with?, no longer in AS
2009-11-09 23:50:32 +01:00
Xavier Noria
7982956013
AS guide: removes docs for Object#instance_variable_defined?, no longer in AS
2009-11-09 23:38:48 +01:00
Xavier Noria
b5faacb194
AS guide: removes docs for Symbol#to_proc, no longer in AS
2009-11-09 23:38:00 +01:00
Jeremy Kemper
a66449d852
Ruby 1.9.2: work around inherited hook being called before yielding to block
2009-11-09 14:36:49 -08:00
Xavier Noria
169aaa6218
AS guide: removes docs for Object#tap, no longer in AS
2009-11-09 23:32:31 +01:00
Xavier Noria
2ed5251d11
AS guide: removes docs for bytesize, no longer in AS
2009-11-09 23:31:55 +01:00
Xavier Noria
171e0adabb
AS guide: removes docs for each_char, no longer in AS
2009-11-09 23:31:10 +01:00
Xavier Noria
dcff121c09
AS guide: removes docs for none?, no longer in AS
2009-11-09 23:30:31 +01:00
Xavier Noria
18ce0f517d
AS guide: removes docs for even? and odd?, no longer in AS
2009-11-09 23:29:17 +01:00
Jeremy Kemper
7a68554291
Merge commit 'fxn/master'
2009-11-09 13:56:49 -08:00
Jeremy Kemper
d5fd09246e
Bump AP gem dependencies to upgrade Rack to 1.0.1 and to include rack-mount and erubis.
2009-11-09 13:29:15 -08:00
Xavier Noria
a48f49e56b
the REXML security fix is not needed for Ruby >= 1.8.7
2009-11-09 22:16:51 +01:00
Xavier Noria
db2c0d79e3
Enumerable#none? is not needed for Ruby >= 1.8.7
2009-11-09 22:16:51 +01:00
Xavier Noria
329e7f4441
Integer#even? and Integer#odd? are not needed for Ruby >= 1.8.7
2009-11-09 22:16:51 +01:00
Xavier Noria
b6598c683b
String#each_char is not needed for Ruby >= 1.8.7
2009-11-09 22:16:51 +01:00
Xavier Noria
c0bb4c6ed2
String#start_with? and String#end_with? are not needed for Ruby >= 1.8.7, leaves their plural aliases though
2009-11-09 22:16:51 +01:00
Xavier Noria
004db18cb0
String#bytesize is not needed for Ruby >= 1.8.7
2009-11-09 22:16:51 +01:00
Xavier Noria
f8e713f488
Object#tap is not needed for Ruby >= 1.8.7
2009-11-09 22:16:51 +01:00
Xavier Noria
1979e9c855
Symbol#to_proc is not needed for Ruby >= 1.8.7
2009-11-09 22:16:51 +01:00
Xavier Noria
d4513ac699
Object#instance_variable_defined? is not needed for Ruby >= 1.8.7
2009-11-09 22:16:51 +01:00
Bryan Helmkamp
047007fa9d
Silence warning: discarding old h
2009-11-09 15:44:36 -05:00
Jeremy Kemper
3b0b6dfc86
Merge branch 'master' of github.com:rails/rails
2009-11-09 12:00:08 -08:00
Jeremy Kemper
c74cddc919
Merge commit 'brynary/fix-master-warnings'
2009-11-09 11:58:57 -08:00
Bryan Helmkamp
17dee01b6f
Fix Ruby warning: method redefined; discarding old breakpoint
2009-11-09 14:49:12 -05:00
Bryan Helmkamp
afc129e270
Fix some Ruby warnings: `*' interpreted as argument prefix
2009-11-09 14:46:29 -05:00
Yehuda Katz
0f1da1cb5c
Revert "Bundle I18n 0.2.0."
...
This reverts commit 83f329f5f3 .
2009-11-09 11:33:47 -08:00
José Valim
4a1f438781
Change mailer subjects lookup.
2009-11-09 10:57:53 -08:00
José Valim
83f329f5f3
Bundle I18n 0.2.0.
2009-11-09 10:57:53 -08:00
Yehuda Katz
790c062280
Merge branch 'master' of github.com:rails/rails
2009-11-09 10:57:20 -08:00
Jeremy Kemper
3039912886
Silence spurious warning
2009-11-09 05:09:04 -08:00
Jeremy Kemper
76b2d3e337
Ruby 1.9.2: URI.parse and .decode are deprecated
2009-11-09 05:07:58 -08:00
Jeremy Kemper
6d808cf494
Remove reliance on string access core extension
2009-11-09 04:59:26 -08:00
Jeremy Kemper
7f0fcadd36
Revert "Ruby 1.9.2: avoid Array#to_s and Array(nil)"
...
This reverts commit 7ad461b44d .
2009-11-09 04:05:22 -08:00
Jeremy Kemper
a038b3d1bc
Make Rakefile usable outside of base dir
2009-11-09 03:31:59 -08:00
Jeremy Kemper
ee0d41c38d
Remove string access core extension dependency
2009-11-09 03:18:54 -08:00
Jeremy Kemper
b1164adda1
Fix arg destructure
2009-11-08 23:29:33 -08:00
Jeremy Kemper
8e32830412
Fix unresolved string extension dependencies
2009-11-08 22:49:31 -08:00
Jeremy Kemper
deddd55086
Work around assert_raise limitation
2009-11-08 22:02:57 -08:00
Jeremy Kemper
20cdaddfd2
Ruby 1.9.2: work around changes to flatten and nil.to_str
2009-11-08 22:02:57 -08:00
Jeremy Kemper
7ad461b44d
Ruby 1.9.2: avoid Array#to_s and Array(nil)
2009-11-08 22:02:49 -08:00
Jeremy Kemper
c44fb4ced5
Ruby 1.9: use method_name to work around miniunit API changes
2009-11-08 21:30:34 -08:00
José Valim
51fe6d05e7
Refactor generators a little bit.
...
Signed-off-by: Yehuda Katz <wycats@mobile-166-129-219-135.mycingular.net >
2009-11-08 18:41:44 -08:00
José Valim
216e8c6bfa
Update Rails Generators to use Thor 0.12.0.
...
Signed-off-by: Yehuda Katz <wycats@mobile-166-129-219-135.mycingular.net >
2009-11-08 18:41:44 -08:00
Joshua Peek
c10f4ae01d
Merge remote branch 'Fingertips/master'
2009-11-08 16:03:15 -06:00
Jeremy Kemper
a595abff21
Unknown :format param should result in empty request.formats
2009-11-08 12:12:58 -08:00
Yehuda Katz
103b29831e
Since we require 1.8.7 we don't need to shim instance_exec anymore
2009-11-07 11:23:34 -08:00
Yehuda Katz
e1b5e3cc70
Break up inflector to reduce the dependency burden on dependency-les methods like constantize.
2009-11-07 11:23:21 -08:00
Eloy Duran
f125a34501
Define autosave association callbacks when using accepts_nested_attributes_for.
...
This way we don't define all the validation methods for all associations by
default, but only when needed.
[#3355 state:resolved]
2009-11-07 00:42:42 +01:00
Chris Hapgood
c2cfb20198
Share ActionView::TestCase's output_buffer with view for concat support.
...
[#3467 state:resolved]
Signed-off-by: Eloy Duran <eloy.de.enige@gmail.com >
2009-11-07 00:42:07 +01:00
Chris Hapgood
b43964d606
Make some assertions in the ActionView::TestCase tests actually do something.
...
[#3468 state:resolved]
Signed-off-by: Eloy Duran <eloy.de.enige@gmail.com >
2009-11-07 00:39:39 +01:00
Nathan Weizenbaum
cbded53671
When rendering layouts with blocks, use #capture to avoid assuming that the return value is the block's content.
...
Signed-off-by: Yehuda Katz <wycats@Yehuda-Katz.local >
2009-11-05 20:08:04 -08:00
Jeremy Kemper
cb9a1759c0
Fix generators tests that expect a class name
2009-11-05 16:12:02 -08:00
Jeremy Kemper
1c047be0fc
If class doesn't have a name, there's no implied layout name, so don't set up a _layout method
2009-11-05 16:12:02 -08:00
Jeremy Kemper
60911c3933
Ruby 1.9: Rack apps must *always* take an env arg on 1.9
2009-11-05 16:12:02 -08:00
Jeremy Kemper
73a36b599a
Shush
2009-11-05 16:12:02 -08:00
Yehuda Katz
b12f194c39
Update AC::Middleware to play better with the normal AC::Metal stack. This required stopping to use #call for non-rack-related stuff
2009-11-05 15:38:25 -08:00
Yehuda Katz
b0dfd1d19b
Update Ruby version check to 1.8.7
2009-11-05 15:38:25 -08:00
Yehuda Katz + Carl Lerche
4369426993
Add the ability to merge initializers from various objects in order.
2009-11-05 14:45:53 -08:00
Yehuda Katz + Carl Lerche
897164ddb7
Conceptually unify instance & global initializers
2009-11-05 14:44:29 -08:00
Chris Hapgood
6c59e5a558
Fix OrderedHash#replace
...
Signed-off-by: Michael Koziarski <michael@koziarski.com >
2009-11-05 21:17:13 +13:00
Jeremy Kemper
a8ed10546d
Ruby 1.9: don't assume params are US-ASCII. Hands off the encoding.
2009-11-04 16:27:54 -08:00
Jeremy Kemper
dc1816da30
Ruby 1.9: fix number precision test
2009-11-04 16:10:24 -08:00
Jeremy Kemper
425a02cece
Ruby 1.9: resolve constant lookup issues
2009-11-04 15:41:50 -08:00
Jeremy Kemper
0ff8f81adc
Ruby 1.9: more constant lookup badness :(
2009-11-04 15:00:19 -08:00
Jeremy Kemper
52e2bbd5c0
Ruby 1.9: work around constant resolution behavior change :(
2009-11-04 14:51:54 -08:00
Jeremy Kemper
d2d3464fcc
Turn off --debug for gem bundle. Force gem update.
2009-11-04 14:49:15 -08:00
Jeremy Kemper
726a2fc8d2
Give useful test:isolated failures
2009-11-04 12:44:06 -08:00
Jeremy Kemper
03dc66444e
Add bundler 0.6.0 to CI geminstaller
2009-11-04 11:57:21 -08:00
Jeremy Kemper
d64e87edd6
Try to remotely troubleshoot bundler issue in CI
2009-11-04 11:50:52 -08:00
Manfred Stienstra
0e64eab6a2
Autoload Multibyte features.
2009-11-04 10:15:03 +01:00
Manfred Stienstra
da3a228a93
Make ActiveSupport::Chars#limit run on Ruby 1.9.
2009-11-04 10:14:49 +01:00
Manfred Stienstra
62a022891b
Improve performance of Multibyte::Utils.
...
Replace explicit for-loops by faster enumeration methods.
[#3158 state:committed]
2009-11-04 10:12:06 +01:00
Manfred Stienstra
935bd0fef8
Add ActiveSupport::Multibyte::Chars#limit.
...
The limit method limits the number of bytes in a string. Useful when the
storage space of the string is limited, for instance in a database column
definition.
Sharpen up the implementation of translate offset.
[#3192 state:committed]
2009-11-04 10:12:03 +01:00
Jeremy Kemper
a3d5274e67
Configure generator when needed rather than during initialization
2009-11-03 18:58:40 -08:00
José Valim
d627c932bd
Pass config.generators options along when RAILS_GENERATORS is set and show --force-plural message just once.
...
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2009-11-03 18:22:05 -08:00
Jeremy Kemper
e5211e3bd0
Improve Gemfile commentary
2009-11-03 16:36:19 -08:00
José Valim
3b8e29fe56
Remove --freeze (since Rails will come bundled in all new apps) and update gem action to change Gemfile instead of config.environment.
...
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2009-11-03 16:32:47 -08:00
José Valim
3fb548cac3
Ensure ActiveRecord is loaded on revoke/destroy.
...
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2009-11-03 16:32:47 -08:00
José Valim
e15b5eda2b
Avoid duplicated names on help description and show proper error message if trying to load a Rails 2.x generator.
...
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2009-11-03 16:32:47 -08:00
Joshua Peek
f950d0b4af
Fix simple resource named routes for new routing dsl
2009-11-03 11:23:22 -06:00
Jeremy Kemper
aaa5a692a3
Use spoofed version bump to ensure git is preferred
2009-11-03 00:25:15 -08:00
Jeremy Kemper
8ed82dfeb9
Force gemcutter source to ensure a consistent arel version
2009-11-02 20:26:44 -08:00
Jeremy Kemper
ca990b03cc
Work around rebundling issue
2009-11-02 20:08:43 -08:00
José Valim
d226f17507
Ensure that generators can be invoked from any directory.
...
Signed-off-by: Engine Yard <engineyard@Engine-Yards-MacBook-Pro.local >
2009-11-02 18:20:16 -08:00
Matias Flores
2378085023
Fix chars.reverse for multibyte decomposed strings
...
[#597 state:committed]
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2009-11-02 17:57:55 -08:00
Jeremy Kemper
e93c2da141
Arel::In -> Arel::Predicates::In
2009-11-02 17:50:12 -08:00
Jeremy Kemper
36a9644b86
Clarify date/time dependencies
2009-11-02 17:50:12 -08:00
Jeremy Kemper
b540eca588
Consolidate Object#to_param and #to_query core extensions
2009-11-02 17:50:12 -08:00
Jeremy Kemper
8935854375
Ruby 1.9.2: rational.rb is deprecated
2009-11-02 17:50:12 -08:00
Jeremy Kemper
a2de13e1e0
Ruby 1.9.2: URI.escape is obsolete
2009-11-02 17:50:12 -08:00
Jeremy Kemper
36121d29a5
Ruby 1.9 doesn't recognize EM SPACE as whitespace, breaking String#strip
2009-11-02 17:50:12 -08:00
Jeremy Kemper
13004c37e6
Give useful test:isolated failures
2009-11-02 17:50:11 -08:00
José Valim
d002826e54
Merge branch 'master' of git://github.com/rails/rails
2009-11-02 23:46:00 -02:00
Yehuda Katz
14370e1aab
CI breakage
...
This reverts commit a288b74f1c .
2009-11-02 17:12:01 -08:00
Xavier Noria
cdeaf0f4db
corrects an example
2009-11-01 19:59:52 +01:00
Xavier Noria
738fd3d4a6
AS guide: documents Numeric#bytes and friends
2009-11-01 19:50:21 +01:00
mazuhl
106b78d2ef
Swapped : for . on a NOTE section.
2009-11-02 01:33:24 +08:00
José Valim
976c264724
Extracted localized_cache.rb from ActionController, added it to AbstractController and made ActionMailer use it.
2009-11-01 02:23:49 +01:00
José Valim
a107103e85
Allow :instance_reader to be given to superclass_delegating_accessor as well.
2009-11-01 02:23:49 +01:00
José Valim
2aafdc8396
Use I18n on ActionMailer subjects by default.
2009-11-01 02:23:49 +01:00
José Valim
81c416b72e
More refactoring on ActionMailer::Base.
2009-11-01 02:23:49 +01:00
José Valim
e9667ad1f0
Make tests run without deprecation warning (just one left).
2009-11-01 02:23:48 +01:00
José Valim
418c3f801c
Another refactoring on AM. body is deprecated, use render instead.
2009-11-01 02:23:48 +01:00
José Valim
0396004861
Add some basic render_test to AbstractController.
2009-11-01 02:23:48 +01:00
José Valim
0cf16ddb88
Improve AbstractController layouts coverage.
2009-11-01 02:23:48 +01:00
José Valim
2d514e5352
Move some of helper tests to AbstractController.
2009-11-01 02:23:48 +01:00
José Valim
43d5504f0a
Move all render and layout pieces required in ActionMailer from ActionController to AbstractController.
2009-11-01 02:23:48 +01:00
José Valim
684c2dc208
Remove ActionMailer helpers and rely on AbstractController one.
2009-11-01 02:23:48 +01:00
José Valim
a9751a7034
Refactor ActionMailer layout and remove legacy one.
2009-11-01 02:23:47 +01:00
Matthew Rudy Jacobs
f4f76772fb
abstract all of the ActionMailer delivery methods into their own classes. thereby the following are equivalent
...
ActionMailer::Base.delivery_method = :smtp
ActionMailer::Base.delivery_method = ActionMailer::DeliveryMethod::Smtp
we could equally set our own custom object
as long as it provides the instance method :perform_delivery(mail)
eg.
class MySmsDeliveryMethod
def perform_delivery(mail)
Sms.send(mail['to'], mail['body'])
end
end
MySmsMailer.delivery_method = MySmsDeliveryMethod.new
Signed-off-by: José Valim <jose.valim@gmail.com >
2009-11-01 02:23:47 +01:00
Ben Orenstein
7f8196f908
Fixed an example that was missing a colon for a hash-key.
2009-10-30 12:57:49 -04:00
Tim Carey-Smith
3f56038612
Remove the random line at the beginning of every new log file
2009-10-29 08:05:41 +01:00
Yehuda Katz
51c24ae3e3
Caching refactoring
2009-10-29 00:44:12 -04:00
José Valim
a288b74f1c
Generators should use Rails.root instead of Dir.pwd [ #3408 status:resolved]
...
Signed-off-by: Yehuda Katz <wycats@gmail.com >
2009-10-28 16:54:38 -04:00
Yehuda Katz
8dcf91ca11
First pass at cleaning up action caching
2009-10-28 16:54:00 -04:00
José Valim
427a7385eb
Make polymorphic_url work with symbols again and refactor it [ #1384 status:resolved]
...
Signed-off-by: Joshua Peek <josh@joshpeek.com >
2009-10-28 14:13:48 -05:00
Yehuda Katz
f51ac9e780
Array.wrap(struct) needs to return the wrapped struct
2009-10-28 06:51:25 -07:00
Yehuda Katz
c9487ed6af
Change Event#thread_id to #transaction_id. Defaults to one "transaction" per thread but you can explicitly declare the start of a new one. This makes it possible for each request to have it own id.
2009-10-28 01:58:33 -07:00
Yehuda Katz
03d3824d96
Make it possible to have IDs per request
2009-10-28 01:50:59 -07:00
Yehuda Katz
654b33afc5
New semantics eliminate the need for __send__
2009-10-28 01:43:46 -07:00
Yehuda Katz
a0fc92f455
This is all that's needed in 1.8.7+
2009-10-28 01:43:33 -07:00
Yehuda Katz
c5e73b8976
Reduce TextTemplate cost for simple cases
2009-10-28 00:13:08 -07:00
Yehuda Katz
0b2dd7afd9
Reorganize CSRF a bit
2009-10-28 00:12:35 -07:00
Yehuda Katz
cbcb947b00
AS::Notifications.subscribe blocks are now yielded the arguments to pass to AS::Notifications::Event.new
2009-10-27 21:04:53 -07:00
Phil Ross
9b67b7ba2f
Edinburgh TimeZone references "Europe/London" instead of "Europe/Dublin" [ #3310 state:resolved]
2009-10-27 21:13:13 -05:00
Geoff Buesing
057f0d3c16
Bundle Tzinfo 0.3.15
2009-10-27 21:13:13 -05:00
Geoff Buesing
37c9ec3add
Tzinfo bundling task: unpack tzinfo with lib directory preserved
2009-10-27 21:13:12 -05:00
Yehuda Katz
86596975be
Tests pass again
2009-10-27 19:05:47 -07:00
Joshua Peek
07da304ff8
Some more generation tests
2009-10-27 21:02:21 -05:00
Joshua Peek
43e0bc1c9f
Extract routing controller stub helper into abstract unit
2009-10-27 21:02:20 -05:00
Joshua Peek
e296ea056e
Enable named route tests
2009-10-27 21:02:20 -05:00
Joshua Peek
759f2ccc4c
Start migrating AC routing tests into dispatch folder
2009-10-27 21:02:20 -05:00
Jeremy Kemper
c2a17217d0
Fix test failures due to requiring rails without AS in load path
2009-10-27 18:35:41 -07:00
Yehuda Katz + Carl Lerche
df95f16570
Update initializable
2009-10-27 17:01:33 -07:00
Yehuda Katz + Carl Lerche
da62a7c536
Duplicate AS code no longer needed
2009-10-27 17:01:33 -07:00
José Valim
c28a45ad8b
Fix rake dev and update vendored Thor.
...
Signed-off-by: Yehuda Katz <wycats@gmail.com >
2009-10-27 16:46:19 -07:00
Jeremy Kemper
b30294b54a
Fix broken tests
2009-10-27 09:34:17 -07:00
Yehuda Katz
c3fa20883e
#include should be #extend
2009-10-27 09:21:01 -07:00
Yehuda Katz
b3a198041b
Some optimizations on AS::Notifications. This does not change the public-facing API.
2009-10-27 09:15:41 -07:00
Yehuda Katz
4653719aa6
Clean up flash a bit
2009-10-27 09:15:41 -07:00
Ryan Bigg
d84106c5b7
There is no query method for belongs_to associations.
2009-10-27 20:15:26 +10:00
Jeremy Kemper
58555d0c8b
Remove old per-component bundled environments first
2009-10-27 02:03:25 -07:00
Jeremy Kemper
b3012bbd16
Tweak CI for toplevel gem bundle
2009-10-27 01:55:27 -07:00
Yehuda Katz
df06e0bd86
Clean up flash a bit
2009-10-26 23:11:52 -07:00
Yehuda Katz
2bdd8fa863
Clean up parameter logging some
2009-10-26 21:31:37 -07:00
Yehuda Katz
000d593621
Clean up and update cookies
2009-10-26 18:01:09 -07:00
Yehuda Katz
e1786ee6eb
Fixes expires_now and cleans things up a bit
2009-10-26 17:32:42 -07:00
Yehuda Katz
d7499f8ee8
Extract #head into its own module and simplify it
2009-10-26 17:13:43 -07:00
Xavier Noria
f37c90a875
AS guide: documents Proc#bind
2009-10-27 00:11:22 +01:00
Yehuda Katz
60cc86136b
Base setup for config object in AC.
2009-10-26 15:47:08 -07:00
Joshua Peek
55ae53baad
Fix rake routes method name output [ #3422 state:resolved]
2009-10-26 11:23:39 -05:00
Joshua Peek
6083a87d63
Splat calls to_a not to_ary [ #3423 state:resolved]
2009-10-26 11:16:17 -05:00
Xavier Noria
d226287855
AS guide: documents the Range#overlaps?
2009-10-25 20:51:56 +01:00
Xavier Noria
25ea652c70
AS guide: documents the extension to Range#include?
2009-10-25 20:46:01 +01:00
Xavier Noria
24a85e0ee5
AS guide: documents the extension to Range#to_s
2009-10-25 20:21:38 +01:00
Xavier Noria
e7b3ad535b
AS guide: documents the extension to Range#step
2009-10-25 20:07:01 +01:00
Xavier Noria
27993c5a21
AS guide: removes the placeholder for extensions to Benchmark because benchmark.rb just reimplements an existing method
2009-10-25 19:53:55 +01:00
Xavier Noria
039e85d684
AS guide: removes the placeholder for extensions to Exception because exception.rb seems to provide stuff for internal use
2009-10-25 19:49:10 +01:00
Xavier Noria
7c56071c3a
AS guide: removes CGI placeholder section, CGI.escape_skipping_slashes seems something for internal use
2009-10-25 19:38:22 +01:00
Xavier Noria
97e02faa3c
AS guide: reflects the guide finally covers only core extensions (is gonna be one of the biggest ones just with that)
2009-10-25 19:33:36 +01:00
Xavier Noria
243cfceba5
corrects typo in previous commit
2009-10-25 13:54:42 +01:00
Xavier Noria
acde75c84a
Caching guide: documents that page/action caching run in an after_filter, and this spurious cache entries are avoided just by halting the request
2009-10-25 13:14:52 +01:00
Joshua Peek
a840c8afbf
Restore rake routes [ #3402 state:resolved]
2009-10-24 18:08:54 -05:00
Jeremy Kemper
a0049a6b42
Use rails/rack-mount
2009-10-22 20:13:46 -07:00
Carl Lerche
8a0f456443
Refactored railties' isolation tests to be able to run script/* scripts.
2009-10-21 15:46:22 -07:00
Joshua Peek
3e35d30c0c
Always add actionpack/lib to load path for isolated tests
2009-10-21 11:32:31 -05:00
José Valim
9fbb2c571b
Fix error_messages_for when instance variable names are given.
...
Signed-off-by: Joshua Peek <josh@joshpeek.com >
2009-10-21 11:18:36 -05:00
José Valim
e714b499cc
Move validator, human_name and human_attribute_name to ActiveModel, remove deprecated error messages and add i18n_scope and lookup_ancestors.
...
Signed-off-by: Carl Lerche <carllerche@mac.com >
2009-10-20 17:52:32 -07:00
Yehuda Katz + Carl Lerche
4f6d6f7031
Have all the tests running off a single Gemfile
2009-10-20 16:34:44 -07:00
Joshua Peek
a5c82a9dfb
Start rewriting some internal tests to use the new routing dsl
2009-10-20 16:03:55 -05:00
Joshua Peek
207d0483e5
Run bundler before AM and AMo tests
2009-10-20 15:28:34 -05:00
Joshua Peek
a1ce52effc
New routing dsl
2009-10-20 12:31:23 -05:00
Joshua Peek
df68cae0c0
Group together all the old routing dsl logic
2009-10-20 10:46:27 -05:00
Joshua Peek
35576a237e
Add arel to AMo gemfile
2009-10-20 10:16:19 -05:00
Joshua Peek
a74022ecd3
Move Routing into AD
2009-10-20 10:14:46 -05:00
Joshua Peek
3895e2ccb3
Donate tests I wrote for rackmount rails integration
2009-10-20 09:52:59 -05:00
Joshua Peek
fa1926ddaa
Exclude gem backtrace filter if rubygems is not loaded
2009-10-20 09:32:26 -05:00
Joshua Peek
80a3983b7b
Add rackmount to railties gemspec
2009-10-20 09:27:37 -05:00
Joshua Peek
e994bf0c81
Add rackmount to actionmailer gemspec
2009-10-20 09:27:06 -05:00
Joshua Peek
a1df259074
Replace decaying routing internals w/ rack-mount
2009-10-19 23:32:17 -05:00
Jeremy Kemper
cbedcb0615
Missed cherry-pick from 2e37effd72
2009-10-19 21:03:37 -07:00
Jeremy Kemper
248d84f2e6
Simplify path expansions
2009-10-19 21:00:22 -07:00
Joshua Peek
6c581f5fd5
Kill routing tests expecting path to be unescaped. Most rack servers already escape PATH_INFO.
2009-10-19 22:42:11 -05:00
Joshua Peek
33258d713a
Fix brittle query string comparisons
2009-10-19 22:42:11 -05:00
Jeremy Kemper
16d245e796
Missed Gemfile commits
2009-10-19 19:25:52 -07:00
Jeremy Kemper
4f6d8ceb04
Bundle for railties tests too
2009-10-19 19:22:23 -07:00
Jeremy Kemper
2767036392
Use bundled env for tests only
2009-10-19 19:00:48 -07:00
Jeremy Kemper
c9cd10c4fa
Bundle arel for AR integration tests
2009-10-19 19:00:17 -07:00
Jeremy Kemper
418ce487c4
Only undef to_json if it's defined
2009-10-19 18:46:59 -07:00
Jeremy Kemper
acb1624f27
Merge commit 'josevalim/fixes'
...
Conflicts:
railties/test/generators/app_generator_test.rb
2009-10-19 18:37:19 -07:00
Jeremy Kemper
7ab30599a6
Error message references application.rb instead of environment.rb
2009-10-19 18:33:57 -07:00
Jeremy Kemper
66c4f28bd6
Bump arel requirement to 0.1.1
2009-10-19 18:33:38 -07:00
Jeremy Kemper
4afe70790c
Check for environment.rb
2009-10-19 18:12:29 -07:00
Jeremy Kemper
3072bf7555
Check for bundler environment or 2.x-style vendor/rails + rubygems
2009-10-19 18:10:14 -07:00
Jeremy Kemper
a49c3b0365
Merge branch 'master' of github.com:rails/rails
2009-10-19 12:33:36 -07:00
Pratik Naik
1ac5cf4788
Make sure boot.rb requires rubygems only when needed
2009-10-19 15:06:54 -02:00
Mike Gunderloy
77bb129fdb
Fix bad assumption in BacktraceCleaner test [ #3249 state:resolved]
...
Signed-off-by: Pratik Naik <pratiknaik@gmail.com >
2009-10-18 17:17:09 -02:00
Joshua Peek
51e1260b18
Rails info tests needs use_controllers
2009-10-18 11:13:57 -05:00
Joshua Peek
91726c201b
Relax generation requirements and only enforce the requirements used in the path segment
2009-10-18 11:05:24 -05:00
Joshua Peek
01e04a446c
Use Rails.root in railties tests
2009-10-18 10:53:43 -05:00
Joshua Peek
f74e04c21d
RAILS_GEM_VERSION is obsolete
2009-10-18 10:44:05 -05:00
Joshua Peek
3ccaabc6c6
Need to use "use_controllers" for nonexistent controller in AM test
2009-10-18 10:39:21 -05:00
Eric Chapweske
2831996483
Fixed: #without_typecast should only disable typecasting on the duplicated attributes [ #3387 state:resolved]
...
Signed-off-by: Joshua Peek <josh@joshpeek.com >
2009-10-18 10:22:22 -05:00
Joshua Peek
6873b1d658
Don't use use_controllers in routing tests
2009-10-18 00:26:36 -05:00
Joshua Peek
2c3ca9ae80
This is routing error message test is tightly coupled to the implementation. Just test that it raises an exception.
2009-10-17 21:56:43 -05:00
Joshua Peek
f1767c1513
Drop legacy support for case insensitive controller recognition
2009-10-17 21:21:34 -05:00
Joshua Peek
cc0103fe83
Fix brittle query string comparisons
2009-10-17 19:18:18 -05:00
Joshua Peek
e900a8437a
Fix brittle query string comparisons
2009-10-17 17:35:21 -05:00
Joshua Peek
702df0d238
Fix standalone run of routing test. Only reference controllers that are provided in fake_controllers
2009-10-17 17:35:21 -05:00
Joshua Peek
6c2a73909e
Stop using with_controllers in tests
2009-10-17 17:35:20 -05:00
Joshua Peek
e00f57e208
No longer need this special routing exception message because these kinds of ambiguous generations are deprecated
2009-10-17 17:35:20 -05:00
Joshua Peek
20f0b33035
Drop support for routing :generate_all
2009-10-17 17:35:20 -05:00
Joshua Peek
d50413826f
Invalid route requirements should always raise an exception even if they are unused
2009-10-17 17:35:19 -05:00
Carl Lerche
d0f4d93df8
Remove some remnants of config.gem
2009-10-17 14:38:40 -07:00
José Valim
1f9d234a6b
By default use ActiveModel API in controller generators, unless otherwise specified [ #3123 status:resolved]
2009-10-17 15:56:44 -03:00
José Valim
03c5a0e5c4
Make app generatoor specs green once again.
2009-10-17 15:54:58 -03:00
Eric Chapweske
f936a1f100
Refactoring attributes/types [ #3348 state:resolved]
...
Signed-off-by: Joshua Peek <josh@joshpeek.com >
2009-10-17 12:37:15 -05:00
José Valim
cb87302689
Bring agnosticism to error_messages_for.
2009-10-17 13:03:28 -03:00
José Valim
2e37effd72
Unify class_inheritable_accessor and extlib_inheritable_accessor and allow responder to be set in the class level.
2009-10-17 12:54:03 -03:00
Joshua Peek
e13d232150
Add stub for configuring your package manager
2009-10-16 20:57:46 -05:00
Carl Lerche
e1fdc8bba3
Remove config.gem in favor of using the bundler. This makes config/boot.rb obsolete.
...
The bundler library is at: http://github.com/wycats/bundler/ and is a rubygem.
2009-10-16 18:10:52 -07:00
Joshua Peek
29ba9c0307
Use Rails.root in statistics rake task
2009-10-16 19:40:59 -05:00
Joshua Peek
7593e8b8b5
Rakefile doesn't need initializers to be ran
2009-10-16 19:40:08 -05:00
Jeremy Kemper
028911ad00
Use rails/rack
2009-10-16 17:39:12 -07:00
Joshua Peek
c7bf1058d3
Fix incorrect path in script/runner template
2009-10-16 19:33:25 -05:00
Joshua Peek
f1640a1653
script/runner should require environment
2009-10-16 19:33:25 -05:00
Joshua Peek
8f2d8f4528
script/performance/profiler should require environment
2009-10-16 19:33:24 -05:00
Joshua Peek
2f7217c76a
script/performance/benchmarker should require environment
2009-10-16 19:33:24 -05:00
Joshua Peek
7635c9f4c0
script/generate should require environment
2009-10-16 19:33:24 -05:00
Yehuda Katz
7e9e370e03
Make encodings work with Erubis and 1.9 again
2009-10-16 17:28:44 -07:00
Joshua Peek
a22394295c
Ignore log folder created by tests
2009-10-16 19:25:21 -05:00
Joshua Peek
c40f79f330
script/about should require environment
2009-10-16 19:24:19 -05:00
Joshua Peek
4cebd41d9e
Fix Rails root in sqlite adapter
2009-10-16 19:08:09 -05:00
Joshua Peek
c1261b5484
Use Rails.application where we want a valid rack app
2009-10-16 19:04:28 -05:00
Joshua Peek
d859402696
Use Rails.initialize! where we just want to run the initializers and aren't concerned about the config
2009-10-16 18:58:35 -05:00
Joshua Peek
92bfc693f2
Rackup file should require environment
2009-10-16 18:46:34 -05:00
Joshua Peek
3971d972c3
Expand paths in i18n initializer tests
2009-10-16 18:42:55 -05:00
Carl Lerche
c296b33ef1
Make the railties tests pass
2009-10-16 16:31:05 -07:00
Carl Lerche
591eaf3b2c
Get apps generated with working again.
2009-10-16 16:03:14 -07:00
Joshua Peek
2ca93403a2
Ruby 1.9: qualify toplevel File reference since config.ru could be eval'd in a different scope
...
Restores accidentally-reverted commit.
2009-10-16 14:21:27 -07:00
Carl Lerche
2110a524a4
Deprecate RAILS_ROOT in favor of Rails.root (which proxies to the application's object root)
2009-10-16 12:51:02 -07:00
Joshua Peek
6094e65169
We won't be publishing tars and zips anymore
2009-10-16 13:56:59 -05:00
Yehuda Katz
a565c19c5b
Fix a bug where templates with locales were not being sorted correctly
2009-10-16 11:26:19 -07:00
Nick Sieger
471a394215
Modify connection pool callbacks to be compatible w/ new style
...
Signed-off-by: Yehuda Katz <wycats@gmail.com >
2009-10-16 10:34:52 -07:00
Jeremy Kemper
b0f55dc1f8
Remove framework subscriber tests which depends on AR, which isn't loaded
2009-10-15 21:51:24 -07:00
José Valim
9ba83cce03
Merge branch 'master' of git://github.com/rails/rails
2009-10-16 01:08:18 -03:00
Jeremy Kemper
ef75d05829
Get rid of stray require again
2009-10-15 17:39:19 -07:00
Jeremy Kemper
71f7e75d95
Merge branch 'master' into orchestra
2009-10-15 17:36:54 -07:00
Yehuda Katz
ef70ad5538
Fix a few more 1.9 bugs. Rack 1.0.1 is required for 1.9 compliance but not release, so bundling 1.0.1 from git
2009-10-15 17:16:42 -07:00
Yehuda Katz
c44d560145
Rack responses need to wrap Strings in 1.9
2009-10-15 16:37:27 -07:00
Yehuda Katz
e9d6bcd19f
Update MetalTest for constant scoping change in 1.9
2009-10-15 16:33:47 -07:00
Yehuda Katz
4869b74aee
Fix test to correctly handle 1.9 Array#to_s behavior
2009-10-15 16:27:26 -07:00
Yehuda Katz
b71f83c9cc
Work around apparent bug in 1.9
2009-10-15 16:03:30 -07:00
Carl Lerche
97296b11e2
Have config/application.rb contain the application definition and require that file instead of config/boot.rb or config/environment.rb in script/*.
2009-10-15 14:54:12 -07:00
José Valim
2d7abe245e
Renamed Orchestra to Notifications once again [ #3321 state:resolved]
2009-10-15 18:51:51 -03:00
Yehuda Katz
e1490d4e4c
Change config implementation in AV slightly
2009-10-15 14:41:59 -07:00
José Valim
5988b87c30
Added parent_of? method to help tracing events.
2009-10-15 18:19:25 -03:00
José Valim
11f9f556b8
Make Orchestra specs run on isolation.
2009-10-15 18:19:25 -03:00
José Valim
a15e02d44a
Unify benchmark APIs.
2009-10-15 18:19:25 -03:00
José Valim
aeaabc6d2d
Configure Orchestra on initialization.
2009-10-15 18:19:25 -03:00
José Valim
8f59d7a8d8
Instrument cache store events only if required.
2009-10-15 18:19:24 -03:00
José Valim
af0d1fa892
Update Orchestra instrumentations and move part of logging to Orchestra.
2009-10-15 18:18:44 -03:00
José Valim
5d0f8abc00
Orchestra listeners have their own queue.
2009-10-15 18:18:44 -03:00
José Valim
7b7796e23d
Events are created inside threads.
2009-10-15 18:18:44 -03:00
José Valim
7b5225a529
Abstract publishing, subscribing and instrumenting in Orchestra.
2009-10-15 18:18:43 -03:00
José Valim
a60bdd7d29
Added queue abstraction to Orchestra.
2009-10-15 18:18:43 -03:00
José Valim
8b340ab2f6
Revert "Rename Orchestra to Notifications [ #3321 state:resolved]"
...
This reverts commit 8cbf825425 .
2009-10-15 18:06:15 -03:00
Yehuda Katz
02b76862e1
Bundle AMo
2009-10-15 14:04:18 -07:00
Yehuda Katz
cb8b0f4a5a
Make this less brittle and work on 1.8
2009-10-15 13:35:22 -07:00
Jeremy Kemper
428c0bd4ba
Kill rake bundle
2009-10-15 00:29:21 -07:00
Jeremy Kemper
d5de94d6b7
Fix AM tests by configuring AV
2009-10-15 00:22:15 -07:00
Jeremy Kemper
deafa10e6c
AP tests depend on AR
2009-10-15 00:22:15 -07:00
Michael Koziarski
b1201792a7
Make the erubis implementation easier for plugins to change.
2009-10-15 17:54:01 +13:00
Michael Koziarski
cc1ad46ead
Add a read-only method which plugin authors can use to determine if xss escaping.
...
This doesn't provide a way to turn off the escaping, but alternative template engine authors
can figure out what their default should be by calling this. Avoids a messy version + plugin check.
2009-10-15 17:22:50 +13:00
Jeremy Kemper
4484f0bccf
Don't push siblings on load path if using bundled env
2009-10-14 20:59:45 -07:00
Jeremy Kemper
5b8e6279ac
AV expects options[:locals] to be a Hash
2009-10-14 20:59:33 -07:00
Jeremy Kemper
e19ab99134
CI bundles Active Record dependencies before running (pulls in Arel)
2009-10-14 19:36:55 -07:00
Jeremy Kemper
c09a5ffea7
Merge branch 'arel'
2009-10-14 19:32:09 -07:00
Jeremy Kemper
6eee1dd62c
Clarify AR dependency
2009-10-14 19:31:29 -07:00
Jeremy Kemper
6be5f45019
Fix env path
2009-10-14 19:30:06 -07:00
Jeremy Kemper
9c52f96acb
Include bundled env in toplevel require, if present
2009-10-14 19:15:33 -07:00
Jeremy Kemper
df55781458
No more toplevel arel sibling
2009-10-14 19:05:06 -07:00
Jeremy Kemper
a9f9ae385e
Explicitly require logger
2009-10-14 18:03:07 -07:00
Joshua Peek
bc1a18d7bd
Punt on ConcurrentHash [ #3322 state:resolved]
2009-10-14 19:53:52 -05:00
Joshua Peek
8cbf825425
Rename Orchestra to Notifications [ #3321 state:resolved]
2009-10-14 19:50:36 -05:00
Jeremy Kemper
5ad0e315e4
Merge branch 'master' into arel
2009-10-14 17:24:17 -07:00
Jeremy Kemper
4cbd3f050b
Move from git submodule to gem bundle
2009-10-14 17:19:24 -07:00
Carl Lerche
bf9819f73d
Have Rails.root be based off of config.ru
2009-10-14 16:40:25 -07:00
Jeremy Kemper
00eb09e016
Revert "Get AS TestCase off deprecated callbacks"
...
This reverts commit 29b280666b .
2009-10-14 16:12:57 -07:00
Jeremy Kemper
efdc062454
Revert "Rewrite AS::TestCase setup/teardown as a single callback chain"
...
This reverts commit 610e94c097 .
2009-10-14 16:12:57 -07:00
Michael Koziarski
d5d242660c
Avoid warning spam by flipping to the new callbacks mechanism. These callbacks are actually never called by rails itself, merely there for plugins
2009-10-15 11:21:53 +13:00
George Ogata
3de8b44b26
Make IntegrationTest::Runner propagate method_missing to ancestors.
...
Fixes RSpec integration example groups, which mixes its Matchers
module into ActiveSupport::TestCase.
Signed-off-by: Michael Koziarski <michael@koziarski.com >
2009-10-15 11:01:42 +13:00
Craig Smith
316f4704ea
Test cases should see all the cookies, not just cookies that have been set in the controller.
...
Previously this example would always pass, even when cookies.delete was not called.
@request.cookies['foo'] = 'bar'
get :delete_cookie
assert_nil cookies['foo']
Signed-off-by: Michael Koziarski <michael@koziarski.com >
[#2768 state:committed]
2009-10-15 10:58:55 +13:00
Jacob Lauemoeller
fc46c9b220
Added CDATA support to the XmlMini LibXML engine, adjusted whitespace handling to closer match that of the REXML engine, and added a LibXML engine test
...
Signed-off-by: Michael Koziarski <michael@koziarski.com >
2009-10-15 10:54:30 +13:00
Jeremy Kemper
3fa7e2fc98
Revert "Missing requires"
...
These rely on constant autoloads.
This reverts commit d39f397dc6 .
2009-10-14 14:48:43 -07:00
Jeremy Kemper
3e62503903
Fix tests
2009-10-14 14:47:11 -07:00
Michael Koziarski
d39f397dc6
Missing requires
2009-10-15 10:42:18 +13:00
pivotal
945d999aad
Digest auth option for ActiveResource.
...
Signed-off-by: Michael Koziarski <michael@koziarski.com >
2009-10-15 10:37:04 +13:00
Michael Koziarski
1d01bad3ce
Make sure non-escaped urls aren't considered safe
2009-10-15 09:58:35 +13:00
Michael Koziarski
5d5e34fa52
Use ERB::Util.h over CGI.escapeHTML as the former is safety aware and the latter isn't
2009-10-15 09:58:17 +13:00
Phil Darnowsky
1b3195b63c
ActionView.url_for doesn't escape by default
...
ActionView::Helpers::UrlHelper#url_for used to escape the URLs it generated by
default. This was most commonly seen when generating a path with multiple
query parameters, e.g.
url_for(:controller => :foo, :action => :bar, :this => 123, :that => 456)
would return
http://example.com/foo/bar?that=456&this=123
escaping an ampersand that shouldn't be escaped. This is both wrong and
inconsistent with the behavior of ActionController#url_for, and is changed.
Signed-off-by: Michael Koziarski <michael@koziarski.com >
2009-10-15 09:49:07 +13:00
Yehuda Katz
a41c6c35ca
Start adding configuration to ActionView instead of using constants.
...
By using config rather than hardcoded constants, we can evolve the
configuration system over time (we'd just need to update the config
method with more robust capabilities and all consumers would get
the capabilities with no code changes)
2009-10-14 13:36:41 -07:00
Jeffrey Hardy
a8dc9fd27b
CookieJar#delete should return the key's value, consistent with a Hash
...
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2009-10-14 11:50:51 -07:00
Carl Lerche
ff8be66f24
Finish porting over the initializers to the app object and fix all the tests
2009-10-14 11:47:37 -07:00
Yehuda Katz + Carl Lerche
5ffb877d3a
Add Gemfile to the rails application generator
2009-10-14 11:18:45 -07:00
Yehuda Katz + Carl Lerche
d56984c016
Make rails configuration's path object's root lazy
2009-10-14 11:18:45 -07:00
Emilio Tagua
5da109d105
Merge commit 'rails/master'
2009-10-14 09:50:23 -03:00
Joshua Peek
7ec947d59c
Refactor AS concern to avoid hacking the "include" method.
...
Ruby Magic!
2009-10-13 23:32:32 -05:00
Joshua Peek
7b169ed1bb
Extend Callbacks and Rescuable with AS concern
2009-10-13 23:30:06 -05:00
Emilio Tagua
06ad817f92
Use ActiveSupport::Callbacks instead of
...
ActiveSupport::DeprecatedCallbacks.
2009-10-13 15:15:00 -03:00
Emilio Tagua
991d1bc200
Merge commit 'rails/master'
2009-10-13 15:06:43 -03:00
Yehuda Katz
9cd50e7752
Make logger work again (h/t Sam Ruby)
2009-10-13 10:43:28 -07:00
Joshua Peek
610e94c097
Rewrite AS::TestCase setup/teardown as a single callback chain
2009-10-12 23:23:02 -05:00
Joshua Peek
29b280666b
Get AS TestCase off deprecated callbacks
2009-10-12 23:03:02 -05:00
Joshua Peek
4552dabba7
Add erubis gem to ci
2009-10-12 22:23:29 -05:00
Joshua Peek
eff61fcfa8
Insert a deprecation warn notice when using AS::DeprecatedCallbacks.
...
We are still using DeprecatedCallbacks in AS and AR. This is meant to annoy the
shit out of Rails core until we fix it.
2009-10-12 22:18:41 -05:00
Joshua Peek
21e7b84621
Callbacks, DeprecatedCallbacks = NewCallbacks, Callbacks
2009-10-12 22:15:43 -05:00
Joshua Peek
9bc8defe38
Use "run_callbacks :foo" since it is the public api for callbacks [ #3329
...
state:resolved]
2009-10-12 21:58:49 -05:00
Joshua Peek
2a5c92c101
Kill unused SafelyMemoizable [ #3323 state:resolved]
2009-10-12 21:44:30 -05:00
Jeremy Kemper
cbb70c896c
Bundle with system gem sources rather than gems.rubyforge.org default
2009-10-11 12:35:01 -07:00
Jeremy Kemper
7b8f9d254a
Fix generators load paths
2009-10-11 12:35:01 -07:00
José Valim
0cd7d4d8cf
Fix rake dev.
...
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2009-10-11 12:35:01 -07:00
Joshua Peek
8b46c50eac
Kill mock routing assertion that tests router implementation
2009-10-10 21:30:51 -05:00
Joshua Peek
e61bc8e29f
Fix failing safe buffer test. We don't patch CGI.escapeHTML, only ERB:Util.
2009-10-10 21:30:51 -05:00
Joshua Peek
1610cd0827
Move safe buffer into test/template
2009-10-10 21:30:51 -05:00
Joshua Peek
21be1dcffa
Relative url generations are covered more thoroughly by url rewriter tests
2009-10-10 21:30:50 -05:00
Joshua Peek
673f73b538
Add define another "stuff" controller to support routing tests
2009-10-10 21:30:50 -05:00
Joshua Peek
5d071b4bc2
Drop implementation specific routing test assertions
2009-10-10 21:30:50 -05:00
Joshua Peek
7bc5e3bd02
Add define a "stuff" controller in fixtures to support routing tests
2009-10-10 21:30:50 -05:00
Xavier Noria
326829633c
trust generated HTML, and define html_safe! for gem >= 2.3 just in case by now
2009-10-10 23:29:12 +02:00
Xavier Noria
8fcf2347b2
removes a no longer needed workaround in the guides generator
2009-10-10 23:00:58 +02:00
Xavier Noria
2b2de86594
requires rubygems in all cases, fixes guides generation
2009-10-10 22:59:13 +02:00
Pratik Naik
66ee2654ff
Merge commit 'mainstream/master'
2009-10-10 17:15:11 +01:00
Yehuda Katz
b9ce8216fa
Fix a bug where render :text could not handle yield :symbol. Fixes guides generation
2009-10-10 00:31:12 -10:00
Jeremy Kemper
6395c7bed2
Mark html safety
2009-10-09 18:36:58 -07:00
Jeremy Kemper
ed139730ff
Uses fileutils
2009-10-09 18:31:30 -07:00
Jeremy Kemper
c23d28e2b3
To unmarshal MissingSourceFile from child
2009-10-09 18:31:30 -07:00
Pratik Naik
68d416a58f
Add a :limit option to specify the maximum number of records that can be processed by accepts_nested_attributes_for
2009-10-09 16:08:11 +01:00
Pratik Naik
e94caf0788
Store entire options hash in the class var rather than just the reject_if proc for the nested attributes
2009-10-09 15:47:10 +01:00
Pratik Naik
987d501182
Mute log info coming from the local_cache strategy
2009-10-09 15:03:18 +01:00
Yehuda Katz
16a48a95e3
Fix issue with standalone ActionView
2009-10-09 00:55:00 -10:00
Yehuda Katz
2954cf1369
Avoid super in define_method for Rubinius
2009-10-09 00:54:12 -10:00
Yehuda Katz
ee37ff46e9
Get rid of constant name usage for stack trace help in favor of overriding #inspect and .name.
2009-10-09 00:53:48 -10:00
Pratik Naik
69aa5e8a86
Ensure MessageVerifier raises appropriate exception on tampered data
2009-10-09 02:26:18 +01:00
Carl Lerche
992c2db76c
Finish porting over the initializers to the app object and fix all the tests
2009-10-08 18:12:28 -07:00
Carl Lerche
5c42157cd8
Even more initializers ported over
2009-10-08 15:30:17 -07:00
Carl Lerche
ed77e84c4b
Ported over more initializers
2009-10-08 15:08:08 -07:00
Carl Lerche
7faa52a424
Add a test that ensures that Rails::Initializable can be used with modules
2009-10-08 12:31:09 -07:00
Carl Lerche
feb04bf897
Move the ensure_tmp_directories_exist initializer to the application object
2009-10-08 12:31:09 -07:00
Carl Lerche
e4d7e5090c
Moving more initializers into the application object
2009-10-08 12:31:09 -07:00
Carl Lerche
6d6ae0841c
Start moving the initializers into the application object
2009-10-08 12:31:09 -07:00
Carl Lerche
d096589245
Remove the old initializer file.
2009-10-08 12:31:09 -07:00
Joshua Peek
3b6bdfc105
API change: content_tag_for outputs prefixed class name
2009-10-08 14:13:49 -05:00
Emilio Tagua
0cf4662ec5
Merge commit 'rails/master'
2009-10-08 15:05:18 -03:00
Emilio Tagua
c3f9d51a00
Updated ARel commit version.
2009-10-08 15:04:27 -03:00
Carl Lerche
665c7ad29d
Fix warning spew for 1.9
2009-10-08 10:58:04 -07:00
Chad Woolley
6e7b02b21a
Fix for Ruby 1.9 - define_method throws an exception under 1.9 if given incorrect number of args
...
Signed-off-by: Carl Lerche <carllerche@mac.com >
2009-10-08 10:48:47 -07:00
Chad Woolley
32cea98c3b
Ruby 1.9: Fix ActiveResource::ConnectionError#to_s when @response does not respond to #code or #message
...
Signed-off-by: Carl Lerche <carllerche@mac.com >
2009-10-08 10:45:00 -07:00
Michael Koziarski
28bd0873ff
Don't need h in there now that XSS protection is on by default
2009-10-08 14:34:15 +13:00
Pratik Naik
0c27d0886e
Use indifferent access attributes instead of stringifying them
2009-10-08 00:15:36 +01:00
Michael Koziarski
c352ec060c
error procs have to be safe too
2009-10-08 12:13:48 +13:00
Pratik Naik
572323135f
Allow accepts_nested_attributes_for :reject_if option accept symbols for using a method
...
Conflicts:
activerecord/lib/active_record/nested_attributes.rb
2009-10-07 23:50:30 +01:00
Michael Koziarski
9415935902
Switch to on-by-default XSS escaping for rails.
...
This consists of:
* String#html_safe! a method to mark a string as 'safe'
* ActionView::SafeBuffer a string subclass which escapes anything unsafe which is concatenated to it
* Calls to String#html_safe! throughout the rails helpers
* a 'raw' helper which lets you concatenate trusted HTML from non-safety-aware sources (e.g. presantized strings in the DB)
* New ERB implementation based on erubis which uses a SafeBuffer instead of a String
Hat tip to Django for the inspiration.
2009-10-08 09:31:20 +13:00
José Valim
f27e7ebc0e
Do not ignore .empty_directory files.
...
Signed-off-by: Carl Lerche <carllerche@mac.com >
2009-10-07 11:00:17 -07:00
Emilio Tagua
9a958a3d7d
Relations: Added offset when finding with associations. Delegate array instance
...
methods to to_a.
2009-10-07 12:43:04 -03:00
Emilio Tagua
aadb09b13b
Merge commit 'rails/master'
2009-10-07 12:23:23 -03:00
Emilio Tagua
f13a7bf4e1
Don't send table_name when updating attributes, use the class arel_table.
2009-10-07 12:21:52 -03:00
Emilio Tagua
942d4b2e4f
Don't send table_name when there's no need to.
2009-10-07 12:17:51 -03:00
Emilio Tagua
1d5854826b
Allow preload and eager_load to work on relations at the same time.
2009-10-07 11:57:59 -03:00
Joshua Peek
ff56f3d5e1
Rewrite ActiveModel::Lint as a simple TU mixin
2009-10-07 09:24:51 -05:00
Sam Pohlenz
4df96338ed
Fixed behavior of attribute_methods_generated? [ #3220 state:resolved]
...
Signed-off-by: Joshua Peek <josh@joshpeek.com >
2009-10-07 09:07:39 -05:00
Sam Pohlenz
f8e91bda9c
Don't share attribute matchers between classes [ #3216 state:resolved]
...
Allows separate models that include ActiveModel::AttributeMethods to
use different sets of attribute matchers.
Signed-off-by: Joshua Peek <josh@joshpeek.com >
2009-10-07 09:07:39 -05:00
Yehuda Katz
3916f0340e
Not calling a private method anymore
2009-10-07 00:33:13 -10:00
Yehuda Katz
e57197a967
Fix warning spew
2009-10-06 22:36:14 -10:00
Paul Gillard
6361d4234c
Call initialize_copy when cloning [ #3164 state:resolved]
...
Cloned AR objects are now instantiated through initialize_copy rather than
new/initialize. This allows AR classes to override initialize_copy in order to
implement deep cloning.
Signed-off-by: Joshua Peek <josh@joshpeek.com >
2009-10-06 16:25:51 -05:00
Emilio Tagua
c3b4da7796
Merge commit 'rails/master'
2009-10-06 16:17:02 -03:00
Michael Koziarski
126f623711
don't ignore all bin directories
2009-10-06 15:53:25 +13:00
Jeffrey Hardy
9212138ad0
MessageVerifier#verify raises InvalidSignature if the signature is blank
...
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2009-10-05 13:38:26 -07:00
Joshua Peek
b480da5cd6
Coerce all out going body parts to Strings
2009-10-05 13:58:43 -05:00
Emilio Tagua
97aba353c8
Merge commit 'rails/master'
2009-10-05 15:33:59 -03:00
Emilio Tagua
23c168a4fd
Initial documentation to Base#all.
2009-10-05 15:27:40 -03:00
Emilio Tagua
1daceeb838
Merge branch 'associations_2'
2009-10-05 15:25:06 -03:00
Emilio Tagua
65f055a3ed
Added eager loading support to Relation and ActiveRecord#all.
2009-10-05 15:24:08 -03:00
Emilio Tagua
3747f896a1
Moved relation's test to relation_test.
2009-10-05 14:39:20 -03:00
Joshua Peek
570f055c44
Yank FCGI Handler from core
...
http://github.com/rails/fcgi_handler
2009-10-05 11:16:24 -05:00
Joshua Peek
20d6938453
Rewrite FCGI handler test
2009-10-05 10:36:05 -05:00
Joshua Peek
7de5f69cc6
Try to load lib before trying to activate the gem for testing
2009-10-05 10:01:46 -05:00
Joshua Peek
444ba150bd
Put test in place for deprecated dispatcher
2009-10-05 09:42:35 -05:00
Joshua Peek
635aa91224
More robust console test
2009-10-05 09:41:08 -05:00
Emilio Tagua
9a71b6d29d
Merge commit 'rails/master'
2009-10-05 11:30:18 -03:00
Joshua Peek
76d823677f
Revert "Revert "Fix Dispatch.new so passenger works" as it broke the build"
...
This reverts commit 49b52cadc2 .
2009-10-05 09:17:51 -05:00
Michael Koziarski
49b52cadc2
Revert "Fix Dispatch.new so passenger works" as it broke the build
...
This reverts commit c97c31b096 .
2009-10-05 17:23:37 +13:00
Joshua Peek
c97c31b096
Fix Dispatch.new so passenger works
2009-10-04 12:45:53 -05:00
Joshua Peek
86d0590022
Only draw default route once
2009-10-03 23:55:35 -05:00
Joshua Peek
86ed58d912
Use with_routing helper in tests instead of modifying global route set
2009-10-03 23:31:38 -05:00
Joshua Peek
61411f2aeb
Redraw default routes on all internal integration tests. We don't need SimpleRouteCase anymore
2009-10-03 23:18:32 -05:00
Joshua Peek
8287a112c9
Avoid creating new controller constants during test runtime. All routable controllers should be defined beforehand.
2009-10-03 23:03:08 -05:00
Joshua Peek
2a938ad5e7
Run AP isolated tests on CI
2009-10-03 22:14:58 -05:00
Joshua Peek
f5cba5e6b1
Moved shared form helper models into fake_models
2009-10-03 22:14:50 -05:00
Joshua Peek
31319b471b
NumberHelper depends on big decimal extensions
2009-10-03 22:06:25 -05:00
Joshua Peek
7eaed071a2
Changing directories during the test breaks file loading when ran by itself
2009-10-03 22:02:51 -05:00
Joshua Peek
660eb068d3
Don't load rubygems for isolated tests
2009-10-03 21:51:34 -05:00
Joshua Peek
75a2f00c97
Move improved isolated test runner to AP
2009-10-03 21:33:06 -05:00
Joshua Peek
018b79dd36
File extra test folders into controller, dispatch, or template
2009-10-03 21:05:51 -05:00
Joshua Peek
84e94551f6
Add custom "with_routing" to internal tests to fix reseting session after using
...
with_routing. This only affects our internal AP tests.
2009-10-03 20:45:49 -05:00
Emilio Tagua
61c959ab0d
Merge commit 'rails/master'
2009-10-03 18:23:06 -03:00
Joshua Peek
89630a7c2c
Cleanup whitespace introduced in 8377646 and f4f6888
2009-10-02 10:19:30 -05:00
Taryn East
8377646d68
add indifferent access to the attributes
...
Signed-off-by: Joshua Peek <josh@joshpeek.com >
2009-10-02 10:13:40 -05:00
Taryn East
f4f68885ef
update_attribute(s) added to Active Resource
...
Signed-off-by: Joshua Peek <josh@joshpeek.com >
2009-10-02 10:13:01 -05:00
Emilio Tagua
29457a21c0
Merge commit 'rails/master'
2009-10-02 10:52:55 -03:00
Pratik Naik
dd2779e1b8
Merge commit 'mainstream/master'
2009-09-30 22:27:02 +01:00
Carl Lerche
420004e030
Initialize a new instance of Rails.application during integration tests
...
This is to fix the AWDWR tests until the application object is refactored to be a singleton.
2009-09-30 12:39:26 -07:00
Carl Lerche
2370e87ae0
Remove all calls to Rails::Initializer from boot.rb
...
This is starting a refactor of the rails initialization process. The boot.rb file will not remain the same.
2009-09-30 12:05:34 -07:00
Carl Lerche
34aae6d739
Remove a duplicate initializer
2009-09-29 17:46:33 -07:00
Carl Lerche
c9d4529c9d
Change Rails::Application to a class that is inherited from.
...
This is still very experimental.
2009-09-29 17:33:17 -07:00
Carl Lerche
d1a63b15e3
Remove unneeded files from the railties test directory
2009-09-29 16:12:45 -07:00
Carl Lerche
6b086449be
Fix the broken railties isolation tests
2009-09-29 16:07:29 -07:00
George Ogata
329b14aa8f
Fix nested attributes examples again.
...
Those hashes don't have indifferent access.
2009-09-29 11:37:29 -04:00
George Ogata
10f3cf00b8
Fix creation example in nested attributes.
2009-09-29 11:35:45 -04:00
Yehuda Katz + Carl Lerche
6f6a589d4b
Create the application object from config/environment.rb
...
This is preliminary and not necessarily reflective of the
full plan.
2009-09-28 18:00:26 -07:00
Erik Ostrom
8ffc2e3b8d
Ported the new ActionView::TestCase from 2-3-stable to master [ #3260
...
state:resolved]
The test case now mimicks the template environment more closely, so it's
possible to use render, load helper dependencies.
This also fixes assert_select, and similar assertions. Because view tests
and helpers generally don't render full templates assert_select looks
first in rendered and then in output_buffer to find the rendered output.
Additional `master'-only changes: Made the Action Pack Rakefile run the
ActionView::TestCase tests, and made ActionView::Rendering#_render_text
always return a string.
Signed-off-by: Joshua Peek <josh@joshpeek.com >
2009-09-28 13:31:30 -05:00
Mike Gunderloy
1696039f29
Remove SQLite2 from CI setup
...
Signed-off-by: Michael Koziarski <michael@koziarski.com >
2009-09-28 14:51:40 +13:00
Luciano G Panaro
4168f87623
Make has_one with :conditions hash scope build or creation of the associated object with those conditions
...
Signed-off-by: Michael Koziarski <michael@koziarski.com >
[#3088 state:committed]
2009-09-28 14:50:33 +13:00
Jay Pignata
d48ebeade2
Escaping symbol passed into Memoizable's flush_cache for query methods to allow them to be cleared
...
Signed-off-by: Michael Koziarski <michael@koziarski.com >
[#3138 state:committed]
2009-09-28 14:48:13 +13:00
John Trupiano
e01f99786a
Allow PKG_NAME env variable to control the directory name used when 'rake dev' is used to generate a new rails app.
...
Signed-off-by: Michael Koziarski <michael@koziarski.com >
[#3278 state:committed]
2009-09-28 14:41:17 +13:00
Matias Flores
173ee14c3d
Prefer tap to returning
...
Signed-off-by: Michael Koziarski <michael@koziarski.com >
[#3280 state:committed]
2009-09-28 14:38:24 +13:00
John Trupiano
c9318e9010
Introduce :almost keyword for distance_of_time_in_words. Make 1.75 days - 2 days return '2 days'.
...
Signed-off-by: Michael Koziarski <michael@koziarski.com >
[#3266 state:committed]
2009-09-28 14:37:31 +13:00
Jay Pignata
8ef1cd9733
Enhancing distance_of_time_in_words to prefix year output with over and about depending upon how many months have elapsed
...
Signed-off-by: Michael Koziarski <michael@koziarski.com >
[#3106 state:committed]
2009-09-28 14:36:38 +13:00
Joshua Peek
a6757a02e1
Move middleware and route configuration from AC::Dispatcher to Rails application object
2009-09-26 21:59:28 -05:00
Joshua Peek
14866fa3d8
Allow setting a default application for all integration tests
2009-09-26 21:38:48 -05:00
Joshua Peek
b0506b086f
Create separate middleware stack for initializer
2009-09-26 21:07:49 -05:00
Joshua Peek
acfeec5151
Allow integration test rack app to be set with "@app" ivar instead of using open_session
2009-09-26 20:51:05 -05:00
Joshua Peek
02413baabb
Fix skipping memcache tests if a memcache server isn't running
2009-09-26 20:02:47 -05:00
Joshua Peek
198081a639
Remove deprecated calls to Dispatcher.to_prepare
2009-09-26 19:57:36 -05:00
Joshua Peek
1f72700575
Move default middleware stack into initializer
2009-09-26 13:41:32 -05:00
Joshua Peek
71b33ec482
AC::Dispatcher is the default app, don't need to set it
2009-09-26 13:02:34 -05:00
Joshua Peek
0c638b3406
Clean up session integration tests so they don't reference AC::Dispatcher
2009-09-26 12:56:53 -05:00
Joshua Peek
db65bb5a31
Pull middleware for Rails info from the initializer instead of ActionController
2009-09-26 12:41:17 -05:00
Chad Woolley
438ff3b5b9
include nokogiri gem, so activesupport nokogiri tests run
...
Signed-off-by: Joshua Peek <josh@joshpeek.com >
2009-09-26 12:23:30 -05:00
Joshua Peek
15cffe6fbc
ruby 1.9: Qualify toplevel File reference since config.ru could be eval'd in a different scope
2009-09-26 11:52:37 -05:00
Joshua Peek
ef58194129
Move Rails::Static into ActionDispatch
2009-09-26 11:37:42 -05:00
Joshua Peek
dbb32115ef
Enable static asset server by default
2009-09-26 11:24:56 -05:00
Joshua Peek
79a4d505fa
Add gem filter for default gem path since it maybe different than the set of gem paths
2009-09-26 11:04:08 -05:00
Joshua Peek
5eeed9f00a
Move tmp directory creation from server to initializer
2009-09-26 10:56:36 -05:00
Xavier Noria
a14a8a6e54
typo
2009-09-26 13:19:52 +02:00
Xavier Noria
cee2ee808e
AS guide: touches an example that confounds the indexer
2009-09-26 13:02:03 +02:00
Joshua Peek
c83c0f6936
Remove config.ru generation from --with-dispatchers option
2009-09-25 23:15:49 -05:00
Joshua Peek
5fba5409f7
Fix railties tests
2009-09-25 22:54:41 -05:00
Joshua Peek
85e0a6cd7d
Set const for application object. "Basecamp::Application"
2009-09-25 22:35:54 -05:00
Joshua Peek
968c994c3b
Initializer.run returns an application object
2009-09-25 22:28:09 -05:00
Joshua Peek
dfbd3b9409
Extract "parse_config" into AD
2009-09-25 21:40:55 -05:00
Joshua Peek
accd9b4634
Restore "Start Rails::Application object
...
This reverts commit f14ad41456 .
2009-09-25 21:32:28 -05:00
Joshua Peek
bace497aea
Remove relative url configuration from script/server
2009-09-25 21:17:38 -05:00
Joshua Peek
382870f763
Generate a config.ru stub
2009-09-25 21:10:00 -05:00
Xavier Noria
cbcdb19a47
AS guide: documents Regexp.unoptionalize
2009-09-26 04:07:22 +02:00
Xavier Noria
ee289f42c6
AS guide: documents Regexp.optionalize
2009-09-26 04:06:40 +02:00
Xavier Noria
c63e19c8a0
AS guide: documents Regexp#multiline?
2009-09-26 03:48:49 +02:00
Xavier Noria
23566b071c
AS guide: documents Regexp#number_of_captures
2009-09-26 03:46:22 +02:00
Joshua Peek
f14ad41456
Revert "Start Rails::Application object"
...
This reverts commit 4129449594 .
2009-09-25 20:41:40 -05:00
Yehuda Katz + Carl Lerche
4129449594
Start Rails::Application object
2009-09-25 17:42:53 -07:00
Joshua Peek
088ce2904d
Fix generic url rewriter in integration tests
2009-09-25 11:10:39 -05:00
Joshua Peek
24ac3a8d8e
Wrap isolated test runner in a test suite
2009-09-25 01:16:52 -05:00
Jeremy Kemper
a6a0904fcb
Nah, test SHA1, but skip the test and whine if OpenSSL is borked up
2009-09-24 23:13:56 -07:00
Jeremy Kemper
55f132ab82
Test with MD5 digest in an attempt to mollify CI
2009-09-24 23:10:05 -07:00
Jeremy Kemper
38e056ee2a
Use ActiveModel::TestCase base class
2009-09-24 22:56:30 -07:00
Joshua Peek
f430d6b63e
Make gemspecs the authoritative source instead of generating them from the Rakefile
2009-09-25 00:46:13 -05:00
Jeremy Kemper
0a692e48ae
Use OpenSSL::Digest.const(...).new instead of OpenSSL::Digest::Digest.new(...)
2009-09-24 22:44:40 -07:00
Jeremy Kemper
5d24827e39
Explicitly require String#bytesize extension
2009-09-24 22:44:40 -07:00
Joshua Peek
897b9ac43b
Make activesupport.gemspec the authoritative source instead of generating it from the Rakefile
2009-09-25 00:24:34 -05:00
Joshua Peek
bb6ca25d03
Check if the lib is in the load path and requirable before attempting to activate the gem version
2009-09-24 23:57:14 -05:00
Jeremy Kemper
018ba27701
Skip addition to load path if an externally-provided lib is already in place. Just to keep the path shorter.
2009-09-24 19:10:31 -07:00
Jeremy Kemper
0bd6e933c0
Restore split between require-time and runtime load path mungery. Simplifies vendor requires.
2009-09-24 18:38:18 -07:00
Jeremy Kemper
772a32a22d
Convert the other vendored libs to avoid pulling in old gems. Works even if rubygems isn't loaded.
2009-09-24 17:29:59 -07:00
Jeremy Kemper
0039c0344c
Avoid inadvertently loading an old tzinfo gem
2009-09-24 17:21:14 -07:00
Yehuda Katz + Carl Lerche
f0dd77c6be
Move railties/lib/* into railties/lib/*
2009-09-24 16:11:41 -07:00
Joshua Peek
610b81beca
Clean up log output for rendered templates
2009-09-24 12:30:13 -05:00
Joshua Peek
9f96708f53
Resurrect AC::Benchmarking [ #3140 state:resolved]
2009-09-24 12:13:09 -05:00
Joshua Peek
c2f8b4e92f
Remove dead requries to AC integration. Rely on autoloads instead
2009-09-24 09:41:46 -05:00
Joshua Peek
3fb623fa90
SessionRestoreError belongs in AD
2009-09-23 23:37:31 -05:00
Joshua Peek
542ddde5d4
Move helpers specific to functional tests out of TestProcess into AC::TestCase
2009-09-23 23:03:24 -05:00
Joshua Peek
4a55d1de8d
Move integration test runner into ActionDispatch
2009-09-23 22:38:19 -05:00
Mike Gunderloy
3600c3840e
More places to bump rack-test version [ #3250 state:resolved]
...
Signed-off-by: Joshua Peek <josh@joshpeek.com >
2009-09-23 09:21:44 -05:00
Xavier Noria
547865bc3d
AS guide: documents String#first, and String#last
2009-09-22 23:09:31 +02:00
Xavier Noria
76e4e686f9
details how a corner case behaves in different Ruby versions
2009-09-22 23:09:30 +02:00
Xavier Noria
d768f7415e
AS guide: details how a corner case behaves in different Ruby versions
2009-09-22 23:09:30 +02:00
Xavier Noria
6aa959e7fc
AS guide: documents String#to and fixes examples
2009-09-22 23:09:30 +02:00
Xavier Noria
b1409799f8
AS guide: documents String#at
2009-09-22 23:09:30 +02:00
Xavier Noria
b1cdd97ce5
AS guide: documents Enumerable#none?
2009-09-22 23:09:30 +02:00
Xavier Noria
586fe4dc72
AS guide: documents Enumerable#many?
2009-09-22 23:09:30 +02:00
Xavier Noria
e79c8bcd7b
AS guide: documents Enumerable#index_by
2009-09-22 23:09:30 +02:00
Joshua Peek
a9c8995ac2
Bump rack-test required version to 0.5
2009-09-22 14:09:24 -05:00
Emilio Tagua
5f9540e483
Merge commit 'rails/master'
2009-09-22 15:08:45 -03:00
José Valim
2407479603
Fixes Sam Ruby tests suite.
...
Signed-off-by: Yehuda Katz <wycats@gmail.com >
2009-09-21 17:56:24 -07:00
Michael Gunderloy
1ec3cdce59
SQLite 2 test passage is no longer required when patching AR.
2009-09-21 18:04:47 -05:00
Xavier Noria
3ed6b3a8b3
AS guide: documents Enumerable#each_with_object
2009-09-21 23:27:48 +02:00
Pratik Naik
340be9bddd
Merge commit 'mainstream/master'
2009-09-21 21:14:04 +01:00
Yehuda Katz
1bbb9b2db0
Merge commit 'jose/orchestra'
2009-09-21 12:05:28 -07:00
Emilio Tagua
a294d8362b
Merge commit 'rails/master'
2009-09-21 14:57:24 -03:00
lakshan
e2d0b0ee61
fixed ActiveModel::Lint typos [ #3236 state:resolved]
...
Signed-off-by: Joshua Peek <josh@joshpeek.com >
2009-09-21 09:49:43 -05:00
Xavier Noria
b31cdb5542
AS guide: documents Enumerable#sum
2009-09-20 20:59:52 +02:00
José Valim
4215e9ab93
Instrumenting cache stores.
2009-09-20 12:07:21 -03:00
José Valim
09f798ba18
Instrument create and deliver in ActionMailer.
2009-09-20 11:09:17 -03:00
José Valim
a0233dd3b2
Use NewCallbacks on ActionDispatch::Callbacks.
2009-09-20 10:56:38 -03:00
José Valim
7cc1c2e71d
Add Orchestra instrumentation to fragment and page caching.
2009-09-20 10:56:38 -03:00
José Valim
8f47f311b7
Instrument process_action, render and sql.
2009-09-20 10:56:38 -03:00
José Valim
3c9a37c9c4
Added Orchestra.
2009-09-20 10:56:38 -03:00
Joshua Peek
762d761673
All tests should be ran under isolated_test too
2009-09-19 13:26:54 -05:00
Joshua Peek
d5cfc72f55
Merge "test_new_base" runner into standard "test_action_pack"
2009-09-19 13:22:58 -05:00
Joshua Peek
f5ace625fe
Ensure changes to I18n locale get reset during tests
2009-09-19 13:22:09 -05:00
Joshua Peek
f1c8f07be8
Follow short name convention for test folder and just call it "abstract"
2009-09-19 13:14:22 -05:00
Joshua Peek
69192bee2d
Merge bundler helper into abstract_unit
2009-09-19 13:12:54 -05:00
Joshua Peek
0540781539
Namespace TestControllers inside their test case class
2009-09-19 13:04:12 -05:00
Joshua Peek
db0af8075d
Avoid conflict with a "MetalTest" module used in tests
2009-09-19 12:52:52 -05:00
Joshua Peek
355e2350ca
All on one base, don't need this
2009-09-19 12:51:28 -05:00
Joshua Peek
12b3799448
Avoid conflicts with another ContentTypeController used in testing
2009-09-19 12:50:14 -05:00
Joshua Peek
f05b1e5eb1
All on one abstract_unit
2009-09-19 12:10:41 -05:00
Joshua Peek
a6f19a155a
There is only one base now
2009-09-19 11:57:56 -05:00
Joshua Peek
5bc47a93b7
Make sure caching test is using a generatable url
2009-09-19 11:56:11 -05:00
Rob Olson
c61bb08d0e
NestedAttributes: call reload after saving to see deletions reflected in
...
nested associations. Docs now match actual behavior.
2009-09-18 13:51:02 -07:00
Yehuda Katz
81c421386c
1.9 fix for changes to #to_s. By Sam Ruby. [ #3228 state:resolved]
2009-09-18 10:35:42 -07:00
Jay Pignata
38e6eb74ab
Fixing typo in ActiveRecord::Errors documentation
2009-09-17 23:03:36 -04:00
Brian Donovan
f183288050
Fix typo.
...
Signed-off-by: Yehuda Katz <wycats@gmail.com >
2009-09-17 18:30:28 -07:00
Jeremy Kemper
3fc2d1ebd9
Extract class-finder method from instantiate
2009-09-17 17:26:29 -07:00
Jeremy Kemper
7701c6f1c0
Collapse nested conditional
2009-09-17 16:15:04 -07:00
Aaron Patterson
636624fbf2
making nokogiri to hash less clever, more fast O_o
...
[#2243 state:committed]
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2009-09-17 11:50:58 -07:00
Jeremy Kemper
b5dd1b6599
Fix brittle content-type check. [ #1956 state:committed]
2009-09-17 11:34:40 -07:00
Justin Bailey
c9d3c48dc6
Enable use of MySQL stored procedures by default.
...
[#3204 state:committed]
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2009-09-17 10:57:03 -07:00
Developer
0d762646c4
Allow Nokogiri XmlMini backend to process cdata elements
...
[#3219 state:committed]
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2009-09-17 10:28:10 -07:00
Joshua Peek
23e72d4cc8
Forward all methods to delayed log
2009-09-16 22:34:44 -05:00
Xavier Noria
fb404216c9
AS guide: documents Array#extract_options!
2009-09-17 00:09:27 +02:00
Yehuda Katz
6be6fae59a
Adds patch to CI
2009-09-15 17:56:20 -07:00
José Valim
befec8a0d8
Remove unused code in ActionView.
...
Signed-off-by: Yehuda Katz <wycats@gmail.com >
2009-09-15 16:18:10 -07:00
Xavier Noria
c37034d8e8
AS guide: str[0, 1] -> str.at(0) in an example
2009-09-16 01:15:14 +02:00
Xavier Noria
68e433a323
removes (nowadays) unneeded tests macro from an example in the Action Mailer guide
2009-09-16 00:07:41 +02:00
Xavier Noria
e0d3cec3cc
AS guide: documents Enumerable#group_by
2009-09-16 00:01:11 +02:00
Joshua Peek
52aeb8d2e7
Beef up AD::Rescue to replace global exception handling lost in ApplicationController
2009-09-15 16:33:15 -05:00
Xavier Noria
b4e11dfdac
@user -> user in example of Action Mailer guide, thanks to Robert
2009-09-15 23:21:28 +02:00
Jens Wille
0ab2e5f45b
Simplify Session.sweep example?
2009-09-15 18:30:14 +02:00
Jens Wille
4e45fa0565
Fixed some examples.
2009-09-15 18:06:26 +02:00
Joshua Peek
90d7ae23c6
Remove global exception catching from ApplicationController.
...
It was severely broken since it was ported to NewBase and is causing problems with normal exception catching. A replacement is coming soon.
2009-09-15 10:05:46 -05:00
Mike Gunderloy
0fb16d018a
Clean up documentation on validates_length_of and change overly juvenile example.
2009-09-15 07:11:20 -05:00
Xavier Noria
55ffc26b39
AS guide: documents slice and slice!
2009-09-15 01:55:54 +02:00
Xavier Noria
193133555f
AS guide: documents reverse_update
2009-09-15 01:25:12 +02:00
Xavier Noria
08aa954805
AS guide: documents reverse_merge and reverse_merge!
2009-09-15 01:21:41 +02:00
Emilio Tagua
378b02d3aa
Updated ARel version.
2009-09-14 17:37:26 -03:00
Jeremy Kemper
d58ee23008
Require rubygems in generators test so Action Dispatch can find rack
2009-09-14 13:04:43 -07:00
Jeremy Kemper
b8e914709c
Require active_support after autoload setup
2009-09-14 13:04:43 -07:00
Jeremy Kemper
4b8576a0c6
Style bikeshed: prefer obvious string paths with / separator to args lists with ', ' separator
2009-09-14 13:04:43 -07:00
Jeremy Kemper
697dda5f29
Fix deprecated gem-name requires
2009-09-14 13:04:43 -07:00
Jeremy Kemper
70d2640700
Cherry-pick core extensions. Don't explicitly require rubygems. Use load path for vendored thor.
2009-09-14 13:04:43 -07:00
Jeremy Kemper
51d202e6f3
Remove premature active_support/mini
2009-09-14 13:04:43 -07:00
Jeremy Kemper
af68eb99c1
Uses extlib_inheritable_accessor
2009-09-14 13:04:43 -07:00
Emilio Tagua
24260dc0c8
Merge commit 'rails/master'
2009-09-14 09:47:55 -03:00
Joshua Peek
181cd109d9
Lookup ruby bin name too
2009-09-14 00:51:31 -05:00
Joshua Peek
c5a6de50bb
Use rbconfig instead of rubygem detection
2009-09-14 00:47:09 -05:00
Joshua Peek
ec01cc4510
For testing, only load rubygems if mocha is missing
2009-09-14 00:41:04 -05:00
Joshua Peek
27458464d6
Forgot to update load path dir for vendored memcache
2009-09-14 00:09:34 -05:00
Jeremy Kemper
ec36edff2d
Use abort
2009-09-13 21:52:18 -07:00
Jeremy Kemper
fa1e6dc577
Skip parent isolation tests too
2009-09-13 21:37:31 -07:00
Joshua Peek
988a614dd2
Don't run gem bundle by default
2009-09-13 23:33:54 -05:00
Joshua Peek
a42c8958f9
Bump vendored memcache to 1.7.5
2009-09-13 23:30:32 -05:00
Joshua Peek
b2f0b8cbda
Rollback AS bundler work and improve activation of vendored dependencies
2009-09-13 22:55:46 -05:00
Joshua Peek
6f9e449830
Callbacks need to require reporting
2009-09-13 21:56:10 -05:00
Joshua Peek
8c8e09c305
Restore AS vendor file until we get things sorted out in railties
2009-09-13 21:07:35 -05:00
Joshua Peek
a0e43073e2
Rewrite resource routing tests that are coupled to the router implementation
2009-09-13 18:43:16 -05:00
Joshua Peek
a3fcfd819b
Need to reset session for AP rescue tests after altering the route set
2009-09-13 17:52:33 -05:00
Joshua Peek
213c920e4f
Define weblog controller for url helper test
2009-09-13 17:28:44 -05:00
Joshua Peek
67eb892e94
AV::UrlHelper depends on Array#second
2009-09-13 17:25:40 -05:00
Joshua Peek
8491b77f55
Omit PATH_INFO in integration test so rack mock will properly override it
2009-09-13 17:15:35 -05:00
Joshua Peek
076d7f885e
AP tests: detect missing dependencies and automatically run bundler
2009-09-13 16:37:30 -05:00
Joshua Peek
6d214c953b
Merge abstract_controller/test_helper and new_base/test_helper since they are expected to run in the same testing sandbox
2009-09-13 16:30:27 -05:00
Joshua Peek
199a423f42
Don't eager require mocha, AS unit needs to set stuff up first
2009-09-13 16:12:33 -05:00
Joshua Peek
48c81f52d4
Remove dead old base abstract unit
2009-09-13 15:34:17 -05:00
Joshua Peek
a01bf41c61
Lazy require memcache for session middleware
2009-09-13 15:30:55 -05:00
Joshua Peek
fff3f0ae0c
Detect missing dependencies and automatically run bundler
2009-09-13 15:10:29 -05:00
Joshua Peek
ef38e67562
Ignore bundled gems
2009-09-13 14:36:20 -05:00
Joshua Peek
5b8373da29
Shush interpolation warnings
2009-09-13 14:34:59 -05:00
Xavier Noria
a0fb9a6f7c
AS guide: documents assert_valid_keys
2009-09-13 21:24:04 +02:00
Xavier Noria
115aa4eee0
AS guide: documents to_options and to_options!
2009-09-13 21:12:08 +02:00
Xavier Noria
a079f60b63
details that symbolize_keys symbolizes keys as long as they respond to to_sym (so "all" may not be really all)
2009-09-13 21:11:33 +02:00
Xavier Noria
119040fafb
AS guide: documents symbolize_keys and symbolize_keys!
2009-09-13 21:04:10 +02:00
Xavier Noria
924d9066cf
AS guide: documents stringify_keys and stringify_keys!
2009-09-13 20:52:48 +02:00
Joshua Peek
3b6bb4664f
Forget about old memoize immutable behavior
2009-09-13 13:08:12 -05:00
Joshua Peek
25f4129151
Need to declare optional dependencies from AS
2009-09-13 12:58:49 -05:00
Joshua Peek
870bf8950f
Load vendored i18n if its not found since its a real requirement
2009-09-13 12:49:22 -05:00
Joshua Peek
ec0d4efd79
Avoid referencing rubygems
2009-09-13 12:47:37 -05:00
Joshua Peek
a9f5f4bb45
Don't force test suite to use bundler
2009-09-13 12:42:13 -05:00
Joshua Peek
f3f2e0b00d
Move AS vendor support into bundler.
...
Run `rake bundle` before running tests.
2009-09-13 12:24:50 -05:00
Joshua Peek
3b325d624c
require reporting before attempting to "shush"
2009-09-13 10:53:12 -05:00
Jeremy Kemper
941e990410
Shush, new_callbacks
2009-09-13 06:06:20 -07:00
Jeremy Kemper
c2018b4b7b
Shush, rexml
2009-09-13 05:57:44 -07:00
Jeremy Kemper
7e6652edbf
Prefer not to shadow a local
2009-09-13 05:56:21 -07:00
Jeremy Kemper
98f96a0809
Ignore isolation test tests for test-unit 2 also
2009-09-13 05:52:18 -07:00
Jeremy Kemper
053a0f6ac4
Clean up spurious JSON decoding test failure
2009-09-13 05:43:02 -07:00
Jeremy Kemper
7d2add8c96
Ruby 1.9 compat: fix regexp slice test
2009-09-13 05:31:43 -07:00
Jeremy Kemper
cce2112f12
Silence warning for Encoding.default_external=
2009-09-13 04:48:40 -07:00
Jeremy Kemper
91ffddca57
Use Encoding.default_external, not _internal
2009-09-13 04:43:41 -07:00
sdsykes
dbe9fa03df
Ruby 1.9 compat: corrected instance_methods check
...
[#3156 state:committed]
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2009-09-13 02:57:53 -07:00
Jeremy Kemper
091486fb98
activesupport -> active_support
2009-09-13 02:45:37 -07:00
Aaron Patterson
f959758687
making secure_compare faster
...
[#3195 state:committed]
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2009-09-13 02:44:52 -07:00
Michael Koziarski
e590508a9b
Dup the arguments to string compare so we can use force_encoding.
2009-09-13 10:36:04 +12:00
Michael Koziarski
81cba78e9e
Merge commit 'alloy/master-nested_attributes_and_autosave'
2009-09-13 10:32:24 +12:00
Yehuda Katz
76cd4cb27e
Memoize in the endpoint.
2009-09-12 15:38:34 -05:00
Yehuda Katz
ddb4600ce6
Get ActionPack's test running on bundled gems. This should make running tests on new machines, as well as CI, work well.
2009-09-12 15:22:11 -05:00
Yehuda Katz
a8a336cbfc
Revert "ruby 1.9 friendly secure_compare" because it breaks CI and Sam Ruby's suite
...
This reverts commit 5de75398c4 .
2009-09-12 14:35:03 -05:00
Yehuda Katz
7152a4e9a6
Add per-controller middleware
2009-09-12 13:51:15 -05:00
Eloy Duran
26639e8a45
Removed the version of ActiveRecord::Base#destroyed? that was added in a44a1257d8.
...
Because José Valim was cheeky enough to already add it to the master branch.
2009-09-12 16:16:48 +02:00
Eloy Duran
a144b41cbc
Removed some superfluous conditionals from the autosave association validation methods.
...
Which are unneeded now that we only define them when needed.
2009-09-12 16:04:47 +02:00
Alexey Kovyrin
938c0ee045
Define autosave association validation methods only when needed. [ #3161 state:resolved]
...
Signed-off-by: Eloy Duran <eloy.de.enige@gmail.com >
2009-09-12 16:04:36 +02:00
Eloy Duran
580ec0dccd
Added some documentation about setting :autosave => false on an association.
2009-09-12 16:04:25 +02:00
Eloy Duran
65f98951ac
During autosave, ignore records that already have been destroyed. [ #2537 state:resolved]
2009-09-12 16:04:07 +02:00
Graeme Porteous
c01be9de32
Fix has_one with foreign_key and primary_key association bug which caused the associated object being lost when saving the owner. [ #1756 state:resolved]
...
Mixed in a bit from patch by ransom-briggs. [#2813 state:resolved]
Signed-off-by: Eloy Duran <eloy.de.enige@gmail.com >
2009-09-12 16:03:32 +02:00
José Valim
3091252aba
Rename nested attributes _delete to _destroy to reflect its actual behavior and DSL (:allow_destroy). Deprecation warning added. [ #2889 state:resolved]
...
Signed-off-by: Eloy Duran <eloy.de.enige@gmail.com >
2009-09-12 15:59:32 +02:00
Dmitry Polushkin
845f62f473
Fix autosave association to skip validation if it is marked for destruction. [ #2064 state:resolved]
...
Signed-off-by: Eloy Duran <eloy.de.enige@gmail.com >
2009-09-12 15:56:01 +02:00
Eloy Duran
6cc0b9638f
Explicitely setting `autosave => false' should override new_record autosaving. [ #2214 state:resolved]
...
Original author is Jacob.
2009-09-12 15:53:15 +02:00
Andrew France
1b78e9bba3
Allow fields_for on a nested_attributes association to accept an explicit collection to be used. [ #2648 state:resolved]
...
Signed-off-by: Eloy Duran <eloy.de.enige@gmail.com >
2009-09-12 15:50:05 +02:00
Lance Ivy
a44a1257d8
Don't cascade autosave validation to destroyed children. [ #2761 state:resolved]
...
Signed-off-by: Eloy Duran <eloy.de.enige@gmail.com >
2009-09-12 15:40:45 +02:00
Mike Breen
bcd0ef710e
Raise an exception with friendlier error message when attempting to build a polymorphic belongs_to with accepts_nested_attributes_for. [ #2318 state:resolved]
...
Signed-off-by: Eloy Duran <eloy.de.enige@gmail.com >
2009-09-12 15:37:54 +02:00
Xavier Noria
a692e5b970
documents Hash#with_indifferent_access
2009-09-12 15:06:00 +02:00
Xavier Noria
8d0fa4054e
AS guide: documents Hash#with_indifferent_access
2009-09-12 15:05:12 +02:00
Xavier Noria
ebe1775b78
documents in Hash#except that convert_key is honored
2009-09-12 14:49:03 +02:00
Xavier Noria
f56b814671
AS guide: documents Hash#except
2009-09-12 14:44:53 +02:00
Xavier Noria
848bdaaa22
AS guide: documents Hash#diff
2009-09-12 13:25:06 +02:00
sdsykes
3180619c0d
Fix habtm associations when using multiple databases
...
[#3128 ]
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2009-09-12 02:57:29 -07:00
Jeremy Kemper
8682d76cc9
Revert "Allow frameworks to be required by their gem name"
...
This has just been confusing. Better to educate than band-aid.
This reverts commit 18a24274ec .
Originally from http://dev.rubyonrails.org/ticket/8845 [drnic]
2009-09-12 02:41:01 -07:00
Akira Matsuda
3ce16b4c5f
Ruby 1.9 compat: Avoid using the return value of FileUtils.mkdir_p, as it does not return a String but an Array in Ruby 1.9
...
[#2018 state:committed milestone:2.3.5]
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2009-09-11 19:20:57 -07:00
Akira Matsuda
0990a13500
Ensure validation errors to be ordered in declared order
...
[#2301 state:committed milestone:2.3.5]
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2009-09-11 18:52:22 -07:00
Akira Matsuda
68b2b730e4
Fix default_error_messages back to the original message
...
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2009-09-11 18:34:12 -07:00
Jakub Kuźma
b22c951e7a
ruby 1.9 friendly secure_compare
...
Signed-off-by: Michael Koziarski <michael@koziarski.com >
2009-09-12 12:48:34 +12:00
Xavier Noria
d74783e78e
AS guide: documents Hash#deep_merge
2009-09-12 02:22:12 +02:00
Xavier Noria
d7e85f363a
documents Hash#to_xml
2009-09-12 01:58:51 +02:00
Xavier Noria
d9ac4a7717
AS guide: documents Hash#to_xml
2009-09-12 01:58:51 +02:00
Xavier Noria
5cc55dda3e
AS guide: corrects a typo
2009-09-12 01:58:51 +02:00
Trevor Turk
e433a391d6
AV overview guide: progress on helpers
2009-09-11 17:58:37 -05:00
Shugo Maeda
ff2eb2d808
Removed the copyright notice not to show it in the result of 'ri ActiveRecord'.
2009-09-11 15:33:20 -07:00
Joshua Peek
72721c6725
Add gem load paths after loading environment
2009-09-11 10:31:31 -05:00
Mike Gunderloy
d879cb8710
Use 'git apply' to apply patches
2009-09-11 10:04:09 -05:00
Nathaniel Talbott
f024aabee3
Fix filtering parameters when there are Fixnum or other un-dupable values.
...
[#3184 state:committed]
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2009-09-10 18:53:50 -07:00
Beau Harrington
38d65b03d6
Remove redundant checks for valid character regexp in ActiveSupport::Multibyte#clean and #verify.
...
[#3181 state:committed]
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2009-09-10 17:36:54 -07:00
Trevor Turk
fb74a1b3dd
AV overview guide: helper docs progress
2009-09-09 22:12:29 -05:00
Emilio Tagua
0489f0c582
Merge commit 'rails/master'
2009-09-08 15:39:33 -03:00
Emilio Tagua
670281c6b2
Merge commit 'rails/master'
...
Conflicts:
activerecord/lib/active_record/associations.rb
2009-09-08 15:38:51 -03:00
José Valim
af5b12c64c
Fix callbacks on ActionPack.
...
Signed-off-by: Yehuda Katz <wycats@gmail.com >
2009-09-08 10:28:28 -07:00
José Valim
2ea1d684d9
Refactor new callbacks and AR implementation.
...
Signed-off-by: Joshua Peek <josh@joshpeek.com >
2009-09-08 10:26:39 -05:00
José Valim
4f37b97033
Changed ActiveRecord to use new callbacks and speed up observers by only notifying events that are actually being consumed.
...
Signed-off-by: Joshua Peek <josh@joshpeek.com >
2009-09-08 10:26:39 -05:00
Jeremy Kemper
aeab739bd5
Ruby 1.9: fix MessageVerifier#secure_compare
2009-09-08 14:05:33 +09:00
Joshua Peek
47aebacd51
Please 1.8.6 CI
2009-09-07 21:56:53 -05:00
Joshua Peek
b7c1fbc050
Start running AS isolated tests on CI
2009-09-07 21:13:25 -05:00
Joshua Peek
1a0f822037
Use draw/connect mapper api instead of directly using add_named_route
2009-09-06 23:21:04 -05:00
Joshua Peek
314e18aba2
Need to reset session for AR session tests after altering the route set
2009-09-06 23:09:47 -05:00
Joshua Peek
2ae84e04aa
Add fake controllers for url rewriter tests
2009-09-06 23:02:55 -05:00
Joshua Peek
c531bd6665
Cleanup hacky routing with controller_path in url helper tests. This doesn't work in real life anyway.
2009-09-06 22:29:29 -05:00
Joshua Peek
ab8aac09d6
Need to reset session in internal integration tests after altering the route set
2009-09-06 22:01:58 -05:00
Joshua Peek
9f47f8d892
Fix isolated running of AddressesTest
2009-09-06 21:42:05 -05:00
Joshua Peek
1c02fc295d
Fix isolated running of ActionPackAssertionTest
2009-09-06 21:19:29 -05:00
Joshua Peek
c3accd7ded
Fix failing isolated routing test
2009-09-05 19:39:33 -05:00
Joshua Peek
59d1b23ea1
Fix failing ARes isolated tests
2009-09-05 19:24:43 -05:00
Joshua Peek
6dc9ad80e6
Fix warnings in AMo
2009-09-05 19:10:21 -05:00
Joshua Peek
c6e0923245
Fix failing AMo isolated tests
2009-09-05 18:54:19 -05:00
Joshua Peek
fe68cf2784
Fix failing AS isolated tests
2009-09-05 18:31:10 -05:00
Joshua Peek
ca2f2d1800
Turn warnings on for AS isolated tests
2009-09-05 18:24:58 -05:00
Xavier Noria
05b8c82555
AS guide: documents Array#to_xml
2009-09-06 00:26:31 +02:00
Luigi Montanez
4dccf18b93
Link to the mislav-hosted Why's Poignant Guide.
2009-09-04 11:42:07 -04:00
Trevor Turk
612fea185a
Commit progress on Action View Overview
2009-09-03 22:35:18 -05:00
Michael Koziarski
87c93da440
Fix a messed up merge commit
2009-09-04 14:28:32 +12:00
Trevor Turk
b270c1a12e
Commit progress on Action View Overview
2009-09-03 17:51:11 -05:00
Michael Koziarski
b16e0c9223
Clean tag attributes before passing through the escape_once logic.
...
Addresses CVE-2009-3009
2009-09-04 09:25:38 +12:00
Michael Koziarski
9a73630d93
Add verify and clean methods to ActiveSupport::Multibyte.
...
When accepting character input from outside of your application you can't
blindly trust that all strings are properly encoded. With these methods
you can check incoming strings and clean them up if necessary.
Signed-off-by: Michael Koziarski <michael@koziarski.com >
Conflicts:
activesupport/lib/active_support/multibyte.rb
2009-09-04 09:25:38 +12:00
Coda Hale
5e6dab8b34
Fix timing attack vulnerability in ActiveSupport::MessageVerifier.
...
Use a constant-time comparison algorithm to compare the candidate HMAC with the calculated HMAC to prevent leaking information about the calculated HMAC.
Signed-off-by: Michael Koziarski <michael@koziarski.com >
2009-09-04 09:25:38 +12:00
Trevor Turk
c90d326eea
Commit progress on Action View Overview guide
2009-09-03 15:55:55 -05:00
Jay Pignata
bd97c3044a
CookieStore should not be derived from Hash - reverting [ #2268 state:resolved]
...
Signed-off-by: Joshua Peek <josh@joshpeek.com >
2009-09-03 15:15:15 -05:00
Yehuda Katz + Carl Lerche
487ee41d2f
Test for previous commit (we wrote it first, I swear)
2009-09-03 12:58:43 -07:00
Yehuda Katz + Carl Lerche
119793a4c1
Replace :formats => ["*/*"] with the default formats set
2009-09-03 12:52:53 -07:00
Yehuda Katz + Carl Lerche
e3744166ec
Refactor ActionController to use find_template and template_exists?
2009-09-03 12:52:53 -07:00
Sam Pohlenz
4b6321efa9
Don't raise exceptions for missing javascript_include_tag or stylesheet_link_tag sources unless the :cache or :concat options are given. [ #2738 state:resolved]
...
Signed-off-by: Joshua Peek <josh@joshpeek.com >
2009-09-03 14:01:01 -05:00
Yehuda Katz + Carl Lerche
f61dc0ef65
Remove a useless method in the fixture template class
2009-09-03 11:40:03 -07:00
Yehuda Katz + Carl Lerche
f3fc5c4b5f
Refactor ActionView::Resolver
2009-09-03 11:18:57 -07:00
Yehuda Katz + Carl Lerche
dd34691b8d
Extract finding the template in AC to it's own method
2009-09-03 11:18:56 -07:00
Jay Pignata
e0f1a7dc19
If session_options[:id] is requested when using CookieStore, unmarshal the session to access it [ #2268 state:resolved]
...
Signed-off-by: Joshua Peek <josh@joshpeek.com >
2009-09-03 11:50:01 -05:00
Carl Lerche
f416f9f0ae
Vendor the latest version of the bundler
2009-09-03 09:31:04 -07:00
Carl Lerche
e3f5fd536e
Add ActiveModel's ./pkg and ./doc to .gitignore
2009-09-03 08:59:26 -07:00
Jeremy Kemper
3b6a9a020e
Revert "Assert primary key does not exist in habtm when the association is defined, instead of doing that everytime a record is inserted."
...
Test failures on PostgreSQL.
[#3128 state:open]
This reverts commit da636809da .
2009-09-02 13:55:47 -07:00
Xavier Noria
50be5f039b
fixes generation of index and credits page
2009-09-02 20:47:15 +02:00
Joshua Peek
723a47bfb3
Kill AMo observing wrap_with_notifications since ARes was only using it
2009-09-02 11:44:36 -05:00
Xavier Noria
836b7787f5
fixes undefined method keys for nil:NilClass error while generating guides
2009-09-02 18:40:40 +02:00
Jeffrey Hardy
e870e24887
Don't try to log protected attribute removal if there's no logger defined [ #3135 state:resolved]
...
Signed-off-by: Joshua Peek <josh@joshpeek.com >
2009-09-02 11:21:20 -05:00
Jeffrey Hardy
41b3c912b7
Remove ClassInheritableAttributes test case, already covered by ActiveSupport [ #3114 state:resolved]
...
Signed-off-by: Joshua Peek <josh@joshpeek.com >
2009-09-02 11:21:20 -05:00
Yehuda Katz
847907d753
Make Sam Ruby's test suite happy
2009-09-01 19:37:49 -07:00
Yehuda Katz + Carl Lerche
66a4585f88
Fix the */* with Net::HTTP bug [ #3100 state:resolved]
2009-09-01 15:54:29 -07:00
Carl Lerche
bd53ebde72
Add required dependencies on activemodel
2009-09-01 12:26:00 -07:00
Carl Lerche
016b1d3596
Merge branch 'master' of git@github.com:rails/rails
2009-09-01 12:19:09 -07:00
Emilio Tagua
39e4e76d15
Merge commit 'rails/master'
...
Conflicts:
activerecord/lib/active_record/associations.rb
2009-09-01 15:45:43 -03:00
Emilio Tagua
c01c21b31d
Added association preload to relation.
2009-09-01 15:36:09 -03:00
José Valim
da636809da
Assert primary key does not exist in habtm when the association is defined, instead of doing that everytime a record is inserted.
...
[#3128 state:committed]
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2009-09-01 10:15:23 -07:00
Joshua Peek
c5f6e038da
ActionPack test helpers need to activate rack gem
2009-09-01 10:27:19 -05:00
Joshua Peek
ad49895fe8
Railties test helpers need to activate rack gem
2009-09-01 10:05:17 -05:00
Geoff Buesing
cc1efe7e5a
Rails::Info doesn't require version for unwanted frameworks
...
[#3124 state:committed]
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2009-09-01 02:29:22 -07:00
Ryan Bigg
acd5395877
Document IrreversibleMigration.
2009-09-01 17:13:28 +10:00
Bryan Helmkamp
a5588ffc08
Activate rack-test gem before it's required. This shouldn't be necessary, but should fix the build for now
2009-08-31 23:17:43 -07:00
Joshua Peek
a79790e1a5
rack-test 0.4.2 has rack 1.1.pre goodies, we'll use it instead
2009-08-31 23:08:20 -05:00
Joshua Peek
426e76ad85
Temp rack-test gem needs proper gem source
2009-08-31 21:53:24 -05:00
Joshua Peek
14870257c1
Initializer middleware helper needs to require actioncontroller
2009-08-31 21:09:39 -05:00
Yehuda Katz
67f5d611f5
Add rake gemspec and gemspecs to the repo
2009-08-31 17:20:44 -07:00
Joshua Peek
66d713fc8f
License, version, and gemspec for ActiveModel. Ship it!
2009-08-31 19:09:16 -05:00
Pratik Naik
bae00bb1cc
Merge commit 'mainstream/master'
2009-08-31 22:11:50 +01:00
Joshua Peek
ffd2cf1670
To make CI happy, use my edge rack-test gem (just for now)
2009-08-31 15:46:29 -05:00
Joshua Peek
b4068c12eb
Restore rack gem dependency
2009-08-31 15:40:08 -05:00
Joshua Peek
5e5e34377c
Back off rack 1.1-pre and bundle in the new testing goodies
2009-08-31 15:39:19 -05:00
Joshua Peek
8974ab2e2e
action_dispatch and action_view are just more autoloads, so its okay to require them
2009-08-31 14:49:59 -05:00
Joshua Peek
c63dac81c1
Switch over to rack-test gem
2009-08-31 14:27:10 -05:00
Joshua Peek
6f40139b53
SessionHash#update and SessionHash#delete are missing a call to load! [ #3056 state:resolved]
2009-08-31 13:39:06 -05:00
Kane
cf9f361699
added proc and symbol support to validates_numericality_of [ #3049 state:resolved]
...
Signed-off-by: Joshua Peek <josh@joshpeek.com >
2009-08-31 13:35:14 -05:00
Yehuda Katz
7e3abbfdc2
Merge commit 'jose/generators'
2009-08-31 11:07:37 -07:00
Jay Pignata
7316d029e6
Duplicating the options hash in Date#advance to prevent modification of the original [ #1133 state:resolved]
...
Signed-off-by: Joshua Peek <josh@joshpeek.com >
2009-08-31 13:02:19 -05:00
Josh Sharpe
80989437dc
I added this feature so that a Map of changed fields could be retrieved
...
after a model had been saved. This is useful in the after_save callback
when you need to know what fields changed. At present there is no way
to do this other than have code in the before_save callback that takes
a copy of the changes Map, which I thought was a bit messy.
Example.
person = Person.find_by_name('bob')
person.name = 'robert'
person.changes # => {'name' => ['bob, 'robert']}
person.save
person.changes # => {}
person.previous_changes # => {'name' => ['bob, 'robert']}
person.reload
person.previous_changes # => {}
Signed-off-by: Joshua Peek <josh@joshpeek.com >
2009-08-31 12:50:27 -05:00
Jay Pignata
57f7308da4
Changing plugin loader to use blocks instead of Symbol#to_proc to ensure tests run without activesupport
...
[#3118 state:committed]
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2009-08-30 17:01:59 -07:00
Antonio Tapiador del Dujo
cf4846c6ae
I18n support for plugins
...
Rails will now automatically add locale files found in any engine's locale
directory to the I18n.load_path (i.e. files that match the glob pattern
"config/locales/**/*.{rb,yml}" relative to engine directories).
[#2325 state:committed]
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2009-08-30 13:36:22 -07:00
Xavier Noria
93c76b2fb0
AS guide: your lovely typo only seen in github diff even if you reviewed the snippet a hundred times before pushing
2009-08-30 22:24:38 +02:00
Xavier Noria
755fd0ba82
AS guide: explains Array#to_formatted_s
2009-08-30 22:18:33 +02:00
Xavier Noria
0ed583f59a
AS guide: explains Array#to_sentence
2009-08-30 21:43:17 +02:00
Xavier Noria
0af0a3db77
AS guide: reorders an example
2009-08-30 20:51:32 +02:00
José Valim
d8d83e7821
Change div.attribute to div.field and add some _form to tests.
2009-08-30 18:49:54 +02:00
José Valim
0efedf2a30
Ensure scaffold works properly even if plural name is given. [ #3062 ]
2009-08-30 17:58:20 +02:00
José Valim
5096ba961c
Remove inline css. [ #593 status:resolved]
2009-08-30 17:04:16 +02:00
José Valim
5d645c271b
Change scaffold to use _form as partial and div's instead of paragraphs. [ #1760 status:resolved]
2009-08-30 16:53:23 +02:00
David Calavera
0fc5c59b37
Rails templates git command runs inside another directory [ #2466 status:resolved]
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2009-08-30 16:25:07 +02:00
Rodrigo Rosenfeld Rosas
0f9675a872
Fix spelling in Rails 'generator' generator. [ #3080 status:resolved]
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2009-08-30 16:18:21 +02:00
José Valim
72c6ea1022
Update vendored thor.
2009-08-30 16:16:53 +02:00
Chad Woolley
d8e7ff12a8
CI config updates: do not send CI emails unless explicitly enabled, use 'gem update --system', and send emails from an address which can post to the core list
...
[#3116 state:committed]
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2009-08-30 00:06:07 -07:00
Chad Woolley
22e946873c
Send CI notifications to core list.
...
* Only send emails on official box.
* Update CI setup docs to correct hostname instructions.
[#3063 state:committed]
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2009-08-29 13:09:46 -07:00
José Valim
3f78de67b5
Ensure that blocks are also handled inside the responder.
2009-08-29 18:21:19 +02:00
kitallis
ea6cc2800f
two typos fixed
2009-08-29 09:18:53 -07:00
José Valim
684a6b3c71
Attempt to render the template inside the responder, so it can be used for caching and pagination.
...
Signed-off-by: Yehuda Katz <wycats@gmail.com >
2009-08-29 11:01:00 -05:00
Carl Lerche
22d5e3d89d
Make sure all needed files get added to the rails gem
2009-08-29 10:13:52 -05:00
Yehuda Katz
dbf20c2dbb
Initial AMo Lint implementation
2009-08-29 01:49:18 -05:00
Yehuda Katz
353157ccd9
Make rake install work
2009-08-28 18:05:02 -05:00
Jeremy Kemper
f6ca7e4e75
Prefer utf8_unicode_ci (better) over utf8_general_ci (faster)
2009-08-27 23:07:43 -07:00
Emilio Tagua
6b67df70ab
Revert "Revert "Add readonly support for relations.""
...
This reverts commit f2c0725d79 .
2009-08-27 20:03:46 -03:00
Emilio Tagua
f2c0725d79
Revert "Add readonly support for relations."
...
This reverts commit 7cce95b25a .
2009-08-27 20:00:14 -03:00
Emilio Tagua
7cce95b25a
Add readonly support for relations.
2009-08-27 18:52:14 -03:00
Emilio Tagua
d56e987757
No need to reload the relation table with a method param, just nil it.
2009-08-27 16:49:16 -03:00
Emilio Tagua
53f6c6d24e
Performance: Don't reload ARel relation on update.
2009-08-27 16:46:24 -03:00
Emilio Tagua
e204f80dbb
Performance: Don't reload the ARel relation on create, do it on
...
reset_column_information.
2009-08-27 16:42:57 -03:00
Emilio Tagua
1cc0ea826e
Performance: Don't reload the arel_table when destroying.
2009-08-27 16:30:48 -03:00
Emilio Tagua
d395391e1d
Merge commit 'rails/master'
2009-08-27 15:56:16 -03:00
Jeffrey Hardy
c10396b142
When running multiple test tasks, don't abort early if one produces failures
...
[#3107 state:committed]
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2009-08-27 11:20:51 -07:00
Joshua Peek
ba5995dcd9
Reset session in integration tests after changing routes to reload the middleware stack
2009-08-27 12:43:26 -05:00
Yehuda Katz
f3ed0de340
Create an install task that successfully installs all Rails gems
2009-08-27 05:00:57 -05:00
Yehuda Katz
bb91beabbd
Remove some old cruft
2009-08-27 05:00:57 -05:00
Carl Lerche
6a001e925e
Require necessary active_support files in cookie store
2009-08-26 23:07:55 -07:00
Jeffrey Hardy
0a1c7b9df1
Use a more idiomatic redirect_to example in the flash docs
2009-08-27 00:32:57 -04:00
Carl Lerche
4467fa7d24
Fixed stupid mistake... nothing to see here.
2009-08-26 20:51:54 -07:00
Carl Lerche
78ced08338
Add a default parameter for Resolver#initialize
2009-08-26 19:52:18 -07:00
Carl Lerche
2890760665
Set the request and response in ActionController::Middleware
2009-08-26 19:52:18 -07:00
Carl Lerche
efbd535f36
Have AbstractController::Logger#process_action return super's value
2009-08-26 19:52:17 -07:00
Jeffrey Hardy
8c05ca96f8
Don't use AR::Base.connection for fixture column quoting. Use the connection given to Fixtures.new
...
[#3104 state:committed]
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2009-08-26 14:53:09 -07:00
Jeffrey Hardy
0821941598
Eliminate warnings from Regexp multiline extension tests
...
[#3103 state:committed]
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2009-08-26 14:47:29 -07:00
Jeffrey Hardy
66d8063c91
Correct Regexp#un/optionalize assertions and fix uncovered failures
...
[#3102 state:incomplete]
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2009-08-26 14:46:38 -07:00
Jeffrey Hardy
05b529ca57
UrlRewriter#rewrite_url should call #to_param on the value given in :anchor option, just as #url_for does
...
[#2746 state:committed]
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2009-08-26 14:11:26 -07:00
Akira Matsuda
cc9af20da7
I18n: use I18n for select helpers' prompt text
...
[#2252 state:committed]
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2009-08-26 13:55:57 -07:00
Emilio Tagua
286f47f3b0
Remove useless var local definition.
2009-08-26 16:19:19 -03:00
Jeremy Kemper
a7ca5595a2
Revert "I18n: use I18n for select helpers' prompt text"
...
Broke CI.
[#2252 state:open]
This reverts commit adedf72821 .
2009-08-26 12:12:40 -07:00
Sven Fuchs
d672a14ee7
allow ActiveRecord#RecordInvalid exception message to be localized
...
[#2754 state:committed]
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2009-08-26 11:29:16 -07:00
Akira Matsuda
adedf72821
I18n: use I18n for select helpers' prompt text
...
[#2252 state:committed]
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2009-08-26 11:29:16 -07:00
Yehuda Katz
9408fcd2e8
Create new ActionController::Middleware class that will work as a normal Rack middleware.
...
* This initial implementation is a bit hackish, but it uses a normal middleware API
so it's future-proof when we improve the internals.
2009-08-26 00:18:52 -07:00
Joshua Peek
78129b1731
Track all AC base subclasses as possible controllers for internal testing
2009-08-25 23:34:48 -05:00
Yehuda Katz + Carl Lerche
5bc66f160d
And the same thing for Basic
2009-08-25 17:34:07 -07:00
Yehuda Katz + Carl Lerche
3a5269eba4
HTTP Auth should not depend on RenderingController
2009-08-25 17:29:48 -07:00
Yehuda Katz + Carl Lerche
303f9b8841
Redirector had an undeclared dependency on Logger.
2009-08-25 17:20:58 -07:00
Yehuda Katz + Carl Lerche
a21aaca8ea
Rework Middleware stack to match the Rack middleware protocol more closely
2009-08-25 17:04:09 -07:00
Yehuda Katz + Carl Lerche
469424c85e
Modify Digest and Basic to take a request so they can be used outside of the controller
2009-08-25 16:02:26 -07:00
Yehuda Katz + Carl Lerche
86c7b144fa
Add a TODO so we remember to fix partial layouts
2009-08-25 16:02:26 -07:00
Emilio Tagua
33746c44cb
No need to create a new relation if the argument is blank.
2009-08-25 19:47:29 -03:00
Emilio Tagua
51910106f1
Merge commit 'rails/master'
2009-08-25 19:37:41 -03:00
Jeremy Kemper
c3a0a36fc3
Fix typo
2009-08-25 13:41:48 -07:00
Yehuda Katz + Carl Lerche
c7ba911a43
ActionController::Metal can be a middleware
2009-08-25 12:14:31 -07:00
Emilio Tagua
09fde6440a
timestamps gives a created_at field not created_on.
...
[#3093 state:committed]
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2009-08-24 16:17:08 -07:00
Xavier Noria
c5c24732a5
AS guide: explains Array.wrap
2009-08-25 01:11:26 +02:00
Xavier Noria
016905f97f
explains difference between Array.wrap and Array()
2009-08-25 01:08:52 +02:00
Xavier Noria
4a5396c064
AS guide: documents String#each_char
2009-08-24 22:23:37 +02:00
Xavier Noria
dd44bce265
fixes typo in previous (pushed) commit
2009-08-23 15:06:36 +02:00
Xavier Noria
f23fc5861f
AS guide: documents String#(start|end)_with?
2009-08-23 15:04:05 +02:00
Xavier Noria
8458abb5e5
AS guide: documents key-based interpolation
2009-08-23 14:09:46 +02:00
Marshall Huss
4d0df0a4e2
Merge branch 'master' of git@github.com:lifo/docrails
2009-08-22 20:00:24 -04:00
Marshall Huss
77173c8567
Added docs for ActiveResource HTTP proxy support
2009-08-22 20:00:14 -04:00
Xavier Noria
49a23ad421
AS guide: documents String#squish
2009-08-23 01:23:56 +02:00
Xavier Noria
db41df2cd1
AS guide: documents String#bytesize
2009-08-23 00:53:32 +02:00
Jeremy Kemper
e93d0a50c0
Ruby 1.9: fix Time#beginning_of_day inaccuracy due to subtracting a Float
2009-08-22 15:53:19 -07:00
Xavier Noria
fa210686fd
AS guide: 2nd pass in aliasing
2009-08-22 17:03:13 +02:00
Xavier Noria
01b18f7f68
a couple of touches in just committed text
2009-08-22 02:13:54 +02:00
Xavier Noria
7ca7dad434
AS guide: documents aliasing
2009-08-22 02:08:21 +02:00
Ryan Bigg
c52be36148
Add missing end ERB tag.
2009-08-22 09:06:46 +10:00
Joshua Peek
b58acea569
Move legacy param_parsers config onto AD::ParamsParser
2009-08-21 16:49:33 -05:00
Emilio Tagua
689b89f548
Revert "Add bench script for ActiveRecord. Ignore log file and temporary cache"
...
This reverts commit 0c6aed0a09 .
2009-08-21 17:43:46 -03:00
Emilio Tagua
c57f94d730
Merge commit 'rails/master'
2009-08-21 17:43:32 -03:00
taryn
ce61a6bd55
Added first/last/all aliases for equivalent find scopes
...
Just a copy from Active Record (with tests). Each is a warpper function for
the equivalent scoped call to find eg first is a wrapper for find(:first)
Signed-off-by: Joshua Peek <josh@joshpeek.com >
2009-08-21 14:49:59 -05:00
Jeremy Kemper
8bc3a14727
Benchmark script via miloops' arel fork via DataMapper's AR comparison script
2009-08-20 21:09:59 -07:00
Emilio Tagua
0c6aed0a09
Add bench script for ActiveRecord. Ignore log file and temporary cache
...
sql files.
2009-08-20 18:58:12 -03:00
Emilio Tagua
a60334fdc5
Remove useless conditionals/local var.
2009-08-19 19:36:06 -03:00
Emilio Tagua
54fcbb881d
Make sure join association methods are called once.
2009-08-19 17:45:13 -03:00
peter
8b5f9e9d9c
Dropped uneeded things, finalized TOC (for now), started on Prototype and RJS sections
2009-08-19 13:43:02 -07:00
Emilio Tagua
b32474020c
Don't sanitize_sql where it doesn't make sense.
2009-08-19 16:29:26 -03:00
Emilio Tagua
ccf5f2c4a2
Remove old method and comment.
2009-08-19 16:17:16 -03:00
Emilio Tagua
3e1ef198e0
Remove useless InnerJoinDependency, inner joins are performed through
...
Arel::InnerJoin.
2009-08-19 16:08:54 -03:00
Emilio Tagua
b342728677
Merge commit 'rails/master'
2009-08-19 11:09:24 -03:00
Emilio Tagua
2048556a14
Remove whitespace.
2009-08-19 11:09:12 -03:00
taryn
328ba3b333
Added save! which raises ResourceInvalid unless valid?
...
Similar to Active Record - it will raise ActiveResouce::ResourceInvalid if
the resource is not valid (ie if <tt>valid?</tt> returns false)
However - does not raise ActiveResource::ResourceNotFound if the callbacks
fail (callbacks have not yet been implemented) - it will just try to save
and raise if the callbacks all fail.
This is not ideal behaviour - but will do until we decide to change the
behaviour of save_with_validations to actually raise (rather than catch) the
ResourceInvalid exception.
Signed-off-by: Joshua Peek <josh@joshpeek.com >
2009-08-19 09:05:02 -05:00
taryn
4dc05bc8a9
Swallow ResourceNotFound error on find_every
...
Active Record does not explode with RecordNotFound if you go looking for a
collection of objects - it just returns nil. Thus Active Resource should
also not explode.
After all - finding no objects that match a set of conditions is not
exceptional behaviour - unlike looking for a specific object with a given id
(which you'd expect to exist).
I've also added documentation to +find+ to reflect this.
Signed-off-by: Joshua Peek <josh@joshpeek.com >
2009-08-19 09:04:48 -05:00
taryn
079ed8fc43
Pulled find-based tests into their own test case. This matches Active Record, and allows us to have one places where all find-tests are located, which will help when adding dynamic finders later.
...
Signed-off-by: Joshua Peek <josh@joshpeek.com >
2009-08-19 09:04:14 -05:00
taryn
36bf587347
Moved all test cases into a new test/cases directory to match Active Record test directory structure.
...
Signed-off-by: Joshua Peek <josh@joshpeek.com >
2009-08-19 09:03:57 -05:00
taryn
c2f90d6530
Added validations to ActiveResource. Added a smoke test to see if we can add a validation and use it, and add a validates callback and use it.
...
Signed-off-by: Joshua Peek <josh@joshpeek.com >
2009-08-19 09:03:17 -05:00
Johan Andersson
c920712769
Typo. wil should be will
2009-08-19 11:50:29 +00:00
Emilio Tagua
c36cfa7568
Remove unused quoted_record_ids, now ARel does this using ARel::In.
2009-08-18 20:03:32 -03:00
Emilio Tagua
a09215ee96
has_many nullify associations keys using ARel.
2009-08-18 20:02:14 -03:00
Emilio Tagua
a7178773d2
Remove now unused quote_table_name, ARel does that quoting now.
2009-08-18 19:53:21 -03:00
Emilio Tagua
d5476b466f
habtm insertion with ARel integration.
2009-08-18 19:51:41 -03:00
Emilio Tagua
c1f833dff4
habtm delete method integrated with ARel.
2009-08-18 19:38:34 -03:00
Emilio Tagua
0abba2813b
Call to_sql method on ActiveRecord::Relation instance not it's relation
...
attribute.'
2009-08-18 19:38:03 -03:00
Emilio Tagua
74ed123e08
Override respond_to? in ActiveRecord::Relation to go with
...
method_missing.
2009-08-18 16:35:33 -03:00
Emilio Tagua
fefb4c78ac
Cache arel_table when possible, use class method arel_table instead
...
instance method.
2009-08-18 16:28:04 -03:00
Emilio Tagua
0d6997b6e3
Cache #arel_able when possible.
2009-08-18 14:49:11 -03:00
Emilio Tagua
60926db9e0
Inline initializer setup.
2009-08-18 14:22:38 -03:00
Emilio Tagua
66fbcc1de6
Use immutable relation objects to generate queries.
2009-08-18 14:10:03 -03:00
Mike Gunderloy
ef93524058
Remove sqlite2 build from CI recipe [ #3066 state:resolved]
...
Signed-off-by: Pratik Naik <pratiknaik@gmail.com >
2009-08-18 13:24:39 +01:00
Emilio Tagua
ac03bc91db
Use explicit method definition instead of metaprogramming.
2009-08-18 08:27:37 -03:00
Emilio Tagua
fa8f5c2667
Relation#joins! should know what to join instead of delegating to
...
construct_join.
2009-08-18 08:18:24 -03:00
Emilio Tagua
08f6af2d53
Fix typo in test classname.
2009-08-18 08:12:35 -03:00
Emilio Tagua
79e951ca9b
Use finder options as relation method names to provide more familiar
...
naming. Use bang methods convention in methods that alter the
relation.
2009-08-18 07:50:11 -03:00
Emilio Tagua
c923409630
Clean up relation joins when finding records with included associations.
2009-08-17 20:17:40 -03:00
Emilio Tagua
4b339f44bd
Merge commit 'rails/master'
2009-08-17 19:46:32 -03:00
Emilio Tagua
c01c8967a0
Merge commit 'rails/master'
...
Conflicts:
activerecord/lib/active_record/calculations.rb
2009-08-17 19:46:06 -03:00
Pratik Naik
25e5b0c4a8
Remove support for SQLite 2.
...
If you're still using it, please install the plugin from git://github.com/rails/sqlite2_adapter.git
2009-08-17 14:54:34 +01:00
Joshua Peek
ff1b0d3c86
k, thats really slow, lets not
2009-08-16 21:21:39 -05:00
Joshua Peek
24ad9ae3d2
Cleanup route reloading in tests. Prefer with_routing over using ActionController::Routing::Routes directly
2009-08-16 21:14:26 -05:00
Emilio Tagua
770fca10fb
Remove group when building the relation, it will be added later if
...
options[:group] is given.
2009-08-16 17:27:45 -03:00
Josiah Ivey
902c78dc26
Fix typo in debugging guide
2009-08-16 07:22:58 -05:00
Yehuda Katz
ccf28d2499
Fixes ActionMailer regression [ #3059 state:resolved]
2009-08-15 20:38:50 -07:00
Yehuda Katz
d6d550f0cb
Missing fixture template -- fixes AP tests
2009-08-15 20:33:34 -07:00
Jay Pignata
7213da37ce
Fix test_has_many_through_polymorphic_has_one on sqlite2 [ #3054 state:resolved]
...
Signed-off-by: Pratik Naik <pratiknaik@gmail.com >
2009-08-15 19:14:32 -07:00
Jay Pignata
cb3e669b0d
Fix calculation tests on sqlite2 [ #3053 state:resolved]
...
Signed-off-by: Pratik Naik <pratiknaik@gmail.com >
2009-08-15 19:14:11 -07:00
Jeremy Kemper
76335c27b6
Bump pg gem requirement to 0.8.0. Build psql db with UTF8 encoding.
2009-08-15 19:04:25 -07:00
Jay Pignata
679128da58
Adding a call to logger from params_parser to give detailed debug information when invalid xml or json is posted
...
[#2481 state:committed]
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2009-08-15 16:51:03 -07:00
Joshua Peek
911acc10de
Axe "best fit" generation support
2009-08-15 18:08:46 -05:00
Jeremy Kemper
df6617bc8a
Normalize route generation order: associations, yield block, then own routes.
2009-08-15 15:56:52 -07:00
Yehuda Katz
1310231c15
Got tests to pass with some more changes.
...
* request.formats is much simpler now
* For XHRs or Accept headers with a single item, we use the Accept header
* For other requests, we use params[:format] or fallback to HTML
* This is primarily to work around the fact that browsers provide completely
broken Accept headers, so we have to whitelist the few cases we can
specifically isolate and treat other requests as coming from the browser
* For APIs, we can support single-item Accept headers, which disambiguates
from the browsers
* Requests to an action that only has an XML template from the browser will
no longer find the template. This worked previously because most browsers
provide a catch-all */*, but this was mostly accidental behavior. If you
want to serve XML, either use the :xml format in links, or explicitly
specify the XML template: render "template.xml".
2009-08-15 12:32:02 -07:00
Yehuda Katz
9b552fb300
Caches and cache clearing seems to actually work, but the actual architecture is kind of messy. Next: CLEAN UP.
2009-08-15 12:32:01 -07:00
Yehuda Katz
9f5cd0156a
More cleanup of ActionView and reduction in need for blocks in some cases:
...
* only one of partial_name or :as will be available as a local
* `object` is removed
* Simplify _layout_for in most cases.
* Remove <% render :partial do |args| %>
* <% render :partial do %> still works fine
2009-08-15 12:32:01 -07:00
Yehuda Katz
27adcd1c1a
Clean up ActionView some:
...
* Call _evaluate_assigns_and_ivars at the two entry points so we don't have to
do a check at every render.
* Make template.render viable without having to go through a wrapper method
* Remove old TemplateHandler#render(template, local_assigns) path so we don't have
to set self.template every time we render a template.
* Move Template rescuing code to Template#render so it gets caught every time.
* Pull in some tests from Pratik that test render @object in ActionView
2009-08-15 12:32:01 -07:00
Jatinder Singh
a363dba790
Fix ActiveResource load test for 64bit machines [ #3051 state:resolved]
...
Signed-off-by: Pratik Naik <pratiknaik@gmail.com >
2009-08-15 20:29:37 +01:00
Jeremy Kemper
26e4d688ac
Skip isolation test tests when using MiniTest
2009-08-15 12:28:09 -07:00
Joshua Peek
940a391c9b
Attempt to rewrite most of the highly coupled router segments tests
2009-08-14 16:16:29 -05:00
anuj dutta
d572bf99ec
Corrected the use of rackup command from rackup to rackup config.ru
2009-08-15 02:46:05 +05:30
Joshua Peek
f86a4b84dd
Kill routing timed tests
2009-08-14 14:30:19 -05:00
Emilio Tagua
796ec652ad
Don't use regular rinder on calculations since scoping order blows
...
PostreSQL.
2009-08-14 15:59:55 -03:00
Emilio Tagua
48c1e6d584
Merge commit 'rails/master'
2009-08-14 12:34:38 -03:00
Emilio Tagua
9ac01fad19
Use ARel's joins when building a query for finding records with included
...
associations.
2009-08-14 12:33:05 -03:00
Joshua Peek
c6bc8e6626
Break up concerns for choosing what attributes should be serialized and the actual serializer
2009-08-13 22:27:36 -05:00
Joshua Peek
7a26c21d8e
Use safe tmp dir
2009-08-13 21:03:25 -05:00
Jay Pignata
de69e244f2
Updates to configuration: changed syntax to use config, added general configuration options
2009-08-13 12:03:24 -04:00
Jay Pignata
f365d79246
Updates to active record basics: reworked what is section, added CRUD methods, added migrations blurb and link to migrations guide
2009-08-13 12:02:01 -04:00
Rodrigo Rosenfeld Rosas
2a9c6cc06e
Update instructions for contribution guide.
2009-08-13 12:27:04 -03:00
José Valim
8692b11e81
Merge branch 'master' of git://github.com/rails/rails
2009-08-13 10:27:53 +02:00
José Valim
4f9047ecc8
Ensure collections are not treated as nested resources.
2009-08-13 10:27:41 +02:00
Chad Woolley
f413a703ba
make mysql and postgresql rebuild databases on every CI build, to prevent breakages such as collation and character set changing
...
Signed-off-by: Yehuda Katz <wycats@gmail.com >
2009-08-12 00:11:16 -07:00
Yehuda Katz
ba67e256b8
Remove submodule
2009-08-11 23:44:44 -07:00
Yehuda Katz
27e880729e
Made benchmarks submodule so it's easier to keep in sync
2009-08-11 16:49:27 -07:00
Yehuda Katz
ccd1c5e521
Allow superclass_delegating_accessor to take a block for initial set.
2009-08-11 15:03:53 -07:00
Yehuda Katz
4bf516e072
More perf work:
...
* Move #set_cookie and #delete_cookie inline to optimize. These optimizations should
almost certainly be sent back upstream to Rack. The optimization involves using
an ivar for cookies instead of indexing into the headers each time.
* Was able to use a bare Hash for headers now that cookies have their own joining
semantics (some code assumed that the raw cookies were an Array).
* Cache blankness of body on body=
* Improve expand_cache_key for Arrays of a single element (common in our case)
* Use a simple layout condition check unless conditions are used
* Cache visible actions
* Lazily load the UrlRewriter
* Make etag an ivar that is set on prepare!
2009-08-11 15:03:53 -07:00
Yehuda Katz
0adbeeb0c9
Got overhead down from 127 to 85. All tests pass:
...
* Tentatively replaced HeaderHash with SimpleHeaderHash, which does not preserve
case but does handle converting Arrays to Strings in to_hash. This requires
further discussion.
* Moved default_charset to ActionDispatch::Response to avoid having to hop over
to ActionController. Ideally, this would be a constant on AD::Response, but
some tests expect to be able to change it dynamically and I didn't want to change
them yet.
* Completely override #initialize from Rack::Response. Previously, it was creating
a HeaderHash, and then we were creating an entirely new one. There is no way to
call super without incurring the overhead of creating a HeaderHash.
* Override #write from Rack::Response. Its implementation tracks Content-Length,
and doing so adds additional overhead that could be mooted if other middleware
changes the body. It is more efficiently done at the top-level server.
* Change sending_file to an instance_variable instead of header inspection. In
general, if a state is important, it should be set as a property of the response
not reconstructed later.
* Set the Etag to @body instead of .body. AS::Cache.expand_cache_key handles
Arrays fine, and it's more efficient to let it handle the body parts, since
it is not forced to create a joined String.
* If we detect the default cache control case, just set it, rather than setting
the constituent parts and then running the normal (expensive) code to generate
the string.
2009-08-11 15:03:53 -07:00
Yehuda Katz
9e62d6d1c0
Tentatively accept the ":as or :object, but not both" solution
2009-08-11 15:03:53 -07:00
Yehuda Katz
945a7df9f8
Make large_collection 1,000 partials
2009-08-11 15:03:53 -07:00
Yehuda Katz
4945d82239
Further experimentation. Was able to cut the cost of rendering 100 partials in a collection in half.
...
To discuss: What are the desired semantics (if any) for layouts in a collection. There are no
tests for it at present, and I'm not sure if it's needed at all.
Deprecated on this branch: `object` pointing at the current object in partials. You can still
use the partial name, or use :as to achieve the same thing. This is obviously up for discussion.
2009-08-11 15:03:53 -07:00
Yehuda Katz
bef7576c09
Add a few more benches
2009-08-11 15:03:53 -07:00
Yehuda Katz
02d9dd9000
Add some more caching to the lookup
2009-08-11 15:03:52 -07:00
Yehuda Katz
04d4537cd4
This change causes some failing tests, but it should be possible to make them pass with minimal performance impact.
2009-08-11 15:03:52 -07:00
Emilio Tagua
b68ef73344
Merge commit 'rails/master'
2009-08-11 12:41:49 -03:00
Pratik Naik
0a558b36eb
Add tests for hm:t#push failures
2009-08-11 02:37:04 +01:00
Emilio Tagua
8c3a6f871e
Merge commit 'rails/master'
2009-08-10 20:51:05 -03:00
Bryan Helmkamp
d15ddf04ec
Allow delegating to nil, because the method might actually exist on it
2009-08-10 18:48:38 -05:00
Emilio Tagua
10af9fae4a
Merge commit 'rails/master'
2009-08-10 18:19:24 -03:00
Emilio Tagua
0e2fbd80e2
Merge commit 'rails/master'
...
Conflicts:
activerecord/lib/active_record/calculations.rb
activerecord/lib/active_record/connection_adapters/mysql_adapter.rb
activerecord/lib/active_record/connection_adapters/postgresql_adapter.rb
2009-08-10 18:07:33 -03:00
Pratik Naik
d0f891ae02
Rewrite hm:t#create tests using assert_no_difference and assert_difference
2009-08-10 21:30:44 +01:00
Pratik Naik
ad28e0037b
Remove unnecessary scoping for creating hm:t join record
2009-08-10 21:20:01 +01:00
Pratik Naik
50b83984f1
Remove unnecessary scoping and validation checks from hm:t#create
2009-08-10 21:06:49 +01:00
Pratik Naik
d9c4087a9e
Unify hm:t#create and create! implementation
2009-08-10 21:02:06 +01:00
Joshua Peek
f97dae5ebe
Extract common dirty tracking methods in AMo
2009-08-10 13:51:48 -05:00
Joshua Peek
391f978acd
AMo overrides alias_attribute and manages aliasing all known attribute method matchers
2009-08-10 11:58:44 -05:00
Joshua Peek
d574cb31f0
Centralize attr method name concatenation in AttributeMethodMatch
2009-08-10 11:53:10 -05:00
José Valim
5f7cfffc53
Use less strict rules in generators lookup, so people can lay their generators wherever they want.
2009-08-10 18:29:20 +02:00
Arthur Zapparoli
55b5cf586a
Fixed typo in test name and CHANGELOG [ #3017 state:resolved]
...
Signed-off-by: Pratik Naik <pratiknaik@gmail.com >
2009-08-10 16:13:18 +01:00
Pratik Naik
e202c6c814
Move :with/:without check outside the method generated by validates_format_of
2009-08-10 15:24:48 +01:00
Elliot Winkler
cccb0e6b93
Add validates_format_of :without => /regexp/ option [Elliot Winkler, Peer Allan]
...
[#430 state:resolved]
Example :
validates_format_of :subdomain, :without => /www|admin|mail/
Signed-off-by: Pratik Naik <pratiknaik@gmail.com >
2009-08-10 15:22:31 +01:00
Emilio Tagua
eb3ae44cca
Merge commit 'rails/master'
...
Conflicts:
activerecord/lib/active_record/migration.rb
2009-08-10 10:40:11 -03:00
Kamal Fariz Mahyuddin
600a89f208
find_cmd should return the full path of the db command
...
[#1488 state:committed]
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2009-08-10 00:04:37 -07:00
codeape
8c32248acb
Introduce grouped_collection_select helper.
...
[#1249 state:committed]
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2009-08-09 23:58:43 -07:00
Erik Ostrom
7d16e94d82
Correctly handle offsets in Multibyte::Chars#index and #rindex.
...
The offset in codepoints was being passed directly to the wrapped string's index/rindex method. Now we translate the offset into bytes first.
[#3028 state:committed]
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2009-08-09 23:30:41 -07:00
Cristi Balan
3e35ba2481
Add tests for scoping schema_migrations index by global table prefix and suffix
...
[#1543 state:committed]
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2009-08-09 22:59:04 -07:00
Tim Peters
7eaed4fefe
Use table prefix and suffix for schema_migrations index.
...
[#1543 state:committed]
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2009-08-09 22:56:37 -07:00
Jeff Dean
22f3398253
Introduce validates_with to encapsulate attribute validations in a class.
...
[#2630 state:committed]
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2009-08-09 22:47:56 -07:00
Fabien Jakimowicz
797588543e
Add support for errors in JSON format.
...
[#1956 state:committed]
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2009-08-09 22:40:20 -07:00
Jay Pignata
793a9f122f
Fixing isolation test
...
[#3022 state:committed]
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2009-08-09 22:33:23 -07:00
Daniel Sheppard
b3381cacaf
Fix that JSON parser fails to read escaped backslashes.
...
[#973 state:committed]
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2009-08-09 22:30:44 -07:00
Leonardo Borges
0c391b46fb
PostgreSQL: XML datatype support
...
[#1874 state:committed]
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2009-08-09 22:24:54 -07:00
Jaime Bellmyer
9c1bac0b7f
raises an exception on habtm join table inserts if join table contains a primary key. Caches this check to save time on subsequent inserts.
...
[#2086 state:committed]
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2009-08-09 22:19:18 -07:00
Jaime Bellmyer
f0602214e0
raises exception (ActiveRecord::ConfigurationError with message) on habtm association creation if join table contains a primary key
...
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2009-08-09 22:17:39 -07:00
Morgan Schweers
d2d464e26e
Fix that creating a table whose primary key prefix type is :table_name generates an incorrectly pluralized primary key.
...
[#872 state:committed]
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2009-08-09 21:57:56 -07:00
Jeremy Kemper
47f7c936a2
Fix test dependency on taggings
2009-08-09 21:30:55 -07:00
Gabe da Silveira
7e3364ac46
Fix that counter_cache breaks with has_many :dependent => :nullify.
...
[#1196 state:committed]
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2009-08-09 21:18:16 -07:00
Jatinder Singh
5704ecffad
AR should respect default values for MySQL BINARY and VARBINARY columns.
...
[#1273 state:committed]
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2009-08-09 21:05:26 -07:00
Joshua Peek
734e903af5
Deprecate router generation "best match" sorting
2009-08-09 22:53:16 -05:00
Prem Sichanugrist
82dd725fc1
Fix that irregular plural inflections should not be double-pluralized: 'people'.pluralize should return 'people' not 'peoples'.
...
[#1183 state:committed]
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2009-08-09 20:28:57 -07:00
Joshua Nichols
84d24cdae8
Only load db/schema.rb if it exists; otherwise, display a message to run db:migrate or remove active_record in environment.rb.
...
[#3012 state:committed]
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2009-08-09 20:18:56 -07:00
Jeremy Kemper
279b785839
pare down core_ext dependency
2009-08-09 19:32:38 -07:00
Erik Ostrom
4dda9b644d
Add rindex to ActiveSupport::Multibyte::Chars.
...
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2009-08-09 19:05:19 -07:00
railsbob
e06a0b03c8
has_many :through create should not raise validation errors
...
[#2934 state:committed]
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2009-08-09 18:44:45 -07:00
jeem
e4ceea3795
make private_and_public_methods unmemoizable [ #2372 state:resolved]
...
Signed-off-by: Joshua Peek <josh@joshpeek.com >
2009-08-09 20:04:48 -05:00
Andrew Moreland
ca92d44e76
Support deep-merging HashWithIndifferentAccess.
...
[#2732 state:committed]
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2009-08-09 17:32:04 -07:00
Max Lapshin
0af4b0755f
Make sure link_to generates the form with the specified :href if any [ #2254 state:resolved]
...
Signed-off-by: Pratik Naik <pratiknaik@gmail.com >
2009-08-10 00:58:40 +01:00
Tristan Dunn
a0f69722be
Allow ho:through#build when the owner is a new record [ #1749 state:resolved]
...
Signed-off-by: Pratik Naik <pratiknaik@gmail.com >
2009-08-10 00:46:16 +01:00
Tristan Dunn
0472839d68
Prevent overwriting of table name in merging SQL conditions [ #2949 state:resolved]
2009-08-10 00:41:36 +01:00
Gabe da Silveira
00d6c76660
Enable has_many :through for going through a has_one association on the join model [ #2719 state:resolved]
...
Signed-off-by: Pratik Naik <pratiknaik@gmail.com >
2009-08-10 00:30:44 +01:00
Arthur Zapparoli
810b59a2a9
Removed duplicated tests [ #3026 state:resolved]
...
Signed-off-by: Pratik Naik <pratiknaik@gmail.com >
2009-08-10 00:08:40 +01:00
Arthur Zapparoli
ce2422ceaf
Model#human_attribute_name now accept symbols [ #3025 status:resolved]
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2009-08-09 23:55:54 +01:00
Matt Duncan
920ef4e6f3
Fixed to_label_tag to accept id attribute without changing for attribute [ #2660 status:resolved]
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2009-08-09 23:54:21 +01:00
Grzegorz Forysinski
e391c7a97c
Ensure ActiveResource#load works with numeric arrays [Grzegorz Forysinski, Elad Meidar]
...
[#2305 state:resolved]
Signed-off-by: Pratik Naik <pratiknaik@gmail.com >
2009-08-09 23:39:38 +01:00
Vladimir Meremyanin
08ec22054f
Make sure association conditions work with :include and :joins [ #358 state:resolved]
...
Signed-off-by: Pratik Naik <pratiknaik@gmail.com >
2009-08-09 23:10:23 +01:00
Jordan Brough
916b18adeb
Active Resource recognizes 410 as Resource Gone now [ #2316 state:resolved] [Jordan Brough, Jatinder Singh]
...
Signed-off-by: Pratik Naik <pratiknaik@gmail.com >
2009-08-09 22:56:32 +01:00
Tristan Dunn
1af9bd58a0
No longer require database name for MySQL to allow cross database selects.
...
[#1122 state:committed]
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2009-08-09 14:35:57 -07:00
Hugo Peixoto
202b091373
Added both the documentation and a test case for the collection path name customization feature.
...
[#1218 state:committed]
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2009-08-09 14:26:36 -07:00
Bence Nagy
e1b73b9752
path_names could be used to customize collection actions too
...
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2009-08-09 14:26:36 -07:00
Jatinder Singh
1fc1986d6d
Make ActiveResource#exists? work [ #3020 state:resolved]
...
Signed-off-by: Pratik Naik <pratiknaik@gmail.com >
2009-08-09 22:24:57 +01:00
Joshua Nichols
0ec64bea92
Added back support for destroying an association's object by id. [ #2306 status:resolved]
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2009-08-09 21:46:52 +01:00
José Valim
ae47f7575d
Improving test coverage for Range#sum [ #2489 ]
...
Signed-off-by: Pratik Naik <pratiknaik@gmail.com >
2009-08-09 21:46:52 +01:00
David Burger
1382f4de1f
Fix that Hash#to_xml and Array#to_xml shouldn't modify their options hashes [ #672 state:resolved]
...
Signed-off-by: Pratik Naik <pratiknaik@gmail.com >
2009-08-09 21:46:52 +01:00
Hugo Peixoto
870750ed4b
With multiparameter date attributes, the behaviour when empty fields are present is now coherent with the one described in the date_select documentation.
...
[#1715 state:committed]
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2009-08-09 13:39:47 -07:00
Roy Nicholson
3e0951632c
Add ability to set SSL options on ARes connections.
...
[#2370 state:committed]
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2009-08-09 13:24:05 -07:00
Elise Huard
c5896bfd84
validate uniqueness with limit in utf8
...
[#2653 state:committed]
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2009-08-09 12:50:04 -07:00
Jeremy Kemper
87e2c1895f
Fix failing dependencies test relying on . being in LOAD_PATH
2009-08-09 12:40:16 -07:00
Jeremy Kemper
d0bcf51191
Extract repetitive method
2009-08-09 12:14:25 -07:00
Jeremy Kemper
635f68dca9
Uses &:foo
2009-08-09 12:11:50 -07:00
Jeremy Kemper
db42f1bf67
Fix standalone test missing developer fixture
2009-08-09 11:58:07 -07:00
Hugo Peixoto
ff60ec469f
Added a uniqueness validation test that uses diacritics.
...
[#2883 state:committed]
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2009-08-09 11:51:58 -07:00
Jeremy Kemper
c2f9c42719
Fix that RedCloth shouldn't be required to run tests
2009-08-09 11:02:34 -07:00
Pratik Naik
2e50110eac
Merge commit 'mainstream/master'
2009-08-09 18:39:44 +01:00
Dan Croak
a7f09bc122
docrails [ #8 ] changed old def test_ methods to new test(name, block) style in testing guide
2009-08-09 13:35:27 -04:00
Pratik Naik
bb1e177691
.gitignore activesupport/test/fixtures/isolation_test
2009-08-09 18:18:47 +01:00
Pratik Naik
60bed59fbf
Remove unnecessary &block from Range#sum and add tests for (num..float).sum
2009-08-09 18:15:20 +01:00
Pratik Naik
97a5c7a516
Make enumerable test run stand alone
2009-08-09 18:13:03 +01:00
José Valim
e0adfa82c0
Optimize Range#sum only for integers [ #2489 ]
2009-08-09 18:05:58 +01:00
Gabe da Silveira
1185500ff0
Remove unused routeset method routes_for_controller_and_action in favour for routes_for [ #3023 state:resolved]
...
Signed-off-by: Pratik Naik <pratiknaik@gmail.com >
2009-08-09 18:02:35 +01:00
jastix
a1c289dbe4
Require test/unit in the generated test_helper for plugin [ #1878 state:resolved]
...
Signed-off-by: Pratik Naik <pratiknaik@gmail.com >
2009-08-09 17:56:41 +01:00
Matt Conway
1c9b3aabdd
Allow connect_timeout, read_timeout and write_timeout settings for MySQL [ #2544 state:resolved]
...
Signed-off-by: Pratik Naik <pratiknaik@gmail.com >
2009-08-09 17:13:22 +01:00
railsbob
076ca48bd6
Ensure hm:t#find does not assign nil to :include [ #1845 state:resolved]
...
Signed-off-by: Pratik Naik <pratiknaik@gmail.com >
2009-08-09 17:02:19 +01:00
Felipe Talavera
654568e71b
Allow to configure trusted proxies via ActionController::Base.trusted_proxies [ #2126 state:resolved]
...
Signed-off-by: Pratik Naik <pratiknaik@gmail.com >
2009-08-09 16:56:18 +01:00
rizwanreza
7dbb2b6f83
Support passing Redcloth options via textilize helper [ #2973 state:resolved]
...
Signed-off-by: Pratik Naik <pratiknaik@gmail.com >
2009-08-09 16:41:09 +01:00
Mike Breen
7d254b5d74
Serialized attributes should only be saved with partial_updates when the serialized attribute is present [ #2397 state:resolved]
...
Signed-off-by: Pratik Naik <pratiknaik@gmail.com >
2009-08-09 16:34:53 +01:00
Pratik Naik
96b575d6dc
Get rid of parenthesize argument warnings
2009-08-09 16:00:53 +01:00
José Valim
1ea7a00bc4
Refactored create_migration on model generator.
...
Signed-off-by: Pratik Naik <pratiknaik@gmail.com >
2009-08-09 15:57:59 +01:00
Hugo Peixoto
3545d6b0b2
Setting usec (and nsec for Ruby 1.9) on Time#end_of_* methods [ #1255 status:resolved]
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2009-08-09 15:56:37 +01:00
José Valim
1bd4d1c674
Optimize Range#sum to use arithmetic progression when a block is not given [ #2489 ].
...
Signed-off-by: Pratik Naik <pratiknaik@gmail.com >
2009-08-09 15:56:10 +01:00
Michael Siebert
d811864e88
Fix deprecating =-methods by using send [ #2431 status:resolved]
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2009-08-09 15:54:56 +01:00
José Valim
32bde66aa6
Make http digest work with different server/browser combinations
...
Signed-off-by: Pratik Naik <pratiknaik@gmail.com >
2009-08-09 15:53:52 +01:00
Dmitry Ratnikov
314ba0433f
Changed to use klass instead of constantizing in assign_ids generated method
...
[#260 state:committed]
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2009-08-09 02:52:06 -07:00
Dmitry Ratnikov
f16008afdd
Modified Rich Bradley's test-case to fail as part of suite and with a reasonable message
...
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2009-08-09 02:40:27 -07:00
Hugo Peixoto
22b38c18c6
Fixed generating a namespaced model with table pluralization turned off. Add tests for namespaced model generation.
...
[#767 state:committed]
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2009-08-09 02:38:35 -07:00
Jeremy Kemper
a0caad5255
Setting connection timeout also affects Net::HTTP open_timeout.
...
[#2947 state:resolved]
2009-08-09 02:28:00 -07:00
Yehuda Katz
60219a13da
Add a .tmp path
2009-08-09 05:52:49 -03:00
Jeff Dean
ebd6ef3b36
Added section to guide for validates with, which is scheduled for rails 3. See related ticket at:
...
https://rails.lighthouseapp.com/projects/8994-ruby-on-rails/tickets/2630-adding-a-validates_with-method
2009-08-09 03:51:23 -04:00
Rich Bradley
9bb8ef9ede
Fix for nested :include with namespaced models.
...
[#260 state:committed]
2009-08-09 00:31:46 -07:00
Yehuda Katz
0d53994701
Make bench harness produce output that is easier to compare
2009-08-09 04:12:09 -03:00
Yehuda Katz
e8849203dc
Updates to benchmark harness.
2009-08-09 04:12:09 -03:00
Yehuda Katz
b05c951907
Temporary fix to get our LoadError monkey-patch working with newer JRuby. We should probably remove MissingSourceFile and just monkey-patch LoadError instead of overriding LoadError.new.
2009-08-09 04:12:09 -03:00
Yehuda Katz
e58b2769cf
Experimental: Improve performance of ActionView by preventing method cache flushing due to runtime Kernel#extend:
...
* The helper module adds a new _helper_serial property onto AbstractController subclasses
* When #helper is used to add helpers to a class, the serial number is updated
* An ActionView subclass is created and cached based on this serial number.
* That subclass includes the helper module from the controller
* Subsequent requests using the same controller with the same serial will result in
reusing that subclass, rather than being forced to take an action (like include
or extend) that will result in a global method cache flush on MRI and a flush
of the entire AV class' cache on JRuby.
* For now, this optimization is not applied to the RJS helpers, which results in
a global method cache flush in MRI and a flush of the JavaScriptGenerator class in
JRuby only when using RJS.
* Since the effects are limited to using RJS, and would only affect JavaScriptGenerator
in JRuby (as opposed to the entire view object), it seems worthwhile to apply this
now.
* This resulted in a significant performance improvement. I will have benchmarks
in the next day or two that show the performance impact of the last several
commits.
* There is a small chance this could break existing code (although I'm not sure how).
If that happens, please report it immediately.
2009-08-09 04:12:09 -03:00
Yehuda Katz
10eaba8f41
Cache controller_path on the AV instance to avoid needing to make additional calls back into the controller for each attempt (this was done because these calls were adding up significantly in partial rendering and showing up on profiles)
2009-08-09 04:12:09 -03:00
Yehuda Katz
e28e061165
Use response_body rather than performed?
2009-08-09 04:12:09 -03:00
Yehuda Katz
964bc4e855
Rendering a template from ActionView will default to looking for partials only in the current mime type.
...
* The old behavior was tested only as a side-effect of a different test--the original tests remain;
a new template in the XML mime was added.
* If you are relying on the current behavior and object to this change, please participate in
http://groups.google.com/group/rubyonrails-core/browse_thread/thread/6ef25f3c108389bd
2009-08-09 04:12:08 -03:00
Yehuda Katz
33f01fb1f6
Cache some more things to improve partial perf
2009-08-09 04:12:08 -03:00
Yehuda Katz
0ab40b039b
Went from 25% slower partials (vs. 2.3) to 10% faster. More to come.
2009-08-09 04:12:08 -03:00
Yehuda Katz
930d235981
Support a warmup for JRuby
2009-08-09 04:12:08 -03:00
Yehuda Katz
b57d94c187
Update minimal.rb to benchmark partials
2009-08-09 04:12:08 -03:00
Yehuda Katz
d7415f792c
Clean up partial object some more; replace passing around a block to a single block ivar
2009-08-09 04:12:08 -03:00
Yehuda Katz
bf412c9ec6
Clean up initializer and some of the internals of PartialRenderer
2009-08-09 04:12:08 -03:00
Jeremy Kemper
b5b1576aa9
Ruby 1.9 compat: can't implicitly set instance var using block arg
2009-08-08 23:04:25 -07:00
Tristan Dunn
791cccaeda
Don't define a default primary key in the schema dumper.
...
[#1908 state:committed]
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2009-08-08 19:31:35 -07:00
Rob
4b7f95eb8b
Fix binary fixture test on Windows
...
[#2597 state:committed]
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2009-08-08 19:18:38 -07:00
Hugo Peixoto
d8041538dd
MySQL: fix diacritic uniqueness test by setting the default character set and collation to utf8/utf8_unicode_ci
...
[#2883 state:committed]
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2009-08-08 19:02:29 -07:00
Michael Koziarski
b97d293374
Merge branch 'patches'
2009-08-09 13:10:14 +12:00
Michael Koziarski
370bf1401a
Don't call additional methods on builders passed to the atom_feed helper.
...
Additionally, actually test that the atom_feed helper works with :xml as an option.
[#1836 state:committed]
2009-08-09 13:10:08 +12:00
Jon Wood
271baf235d
Add :redirect to the testable RJS statements [ #2612 state:resolved]
...
Example :
assert_select_rjs :redirect, root_path
Signed-off-by: Pratik Naik <pratiknaik@gmail.com >
2009-08-09 02:00:15 +01:00
Pratik Naik
89c8affe47
Use Pathname for checking if sqlite path is absolute
2009-08-09 01:54:08 +01:00
bastilian
071f48b716
Make sure db:drop doesn't fail when sqlite db is given by an absolute path [ #1789 state:resolved]
...
Signed-off-by: Pratik Naik <pratiknaik@gmail.com >
2009-08-09 01:54:08 +01:00
Marc-Andre Lafortune
29096268cc
Enumerable#sum now works will all enumerables, even if they don't respond to :size
...
[#2489 state:committed]
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2009-08-08 17:51:09 -07:00
Matt Duncan
3b3798506b
Adding :from scoping to ActiveRecord calculations
...
Signed-off-by: Michael Koziarski <michael@koziarski.com >
[#1229 state:committed]
2009-08-09 12:43:07 +12:00
Matt Duncan
45f5bdfbc7
Adding :from scoping to ActiveRecord calculations
...
Signed-off-by: Michael Koziarski <michael@koziarski.com >
[#1229 state:committed]
2009-08-09 12:33:33 +12:00
Jan Schwenzien
1f6afe4a74
Fix HTTP basic authentication for long credentials [ #2572 state:resolved]
...
Signed-off-by: Pratik Naik <pratiknaik@gmail.com >
2009-08-09 01:28:43 +01:00
Steve St. Martin
618771beb5
Update truncate documentation / examples to more clearly demonstrate its actual behavior
...
[#3016 state:committed]
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2009-08-08 17:16:26 -07:00
Michael Koziarski
df745ed805
Depend on rubygems 1.3.2
...
Also move the min_version definition up a line so it's present in the rescue block down below.
2009-08-09 11:11:34 +12:00
Adam Keys
5632b36701
Fix exclusive range patch to use begin/end instead of min/max. [ #2981 status:resolved]
...
Signed-off-by: José Valim <jose.valim@gmail.com >
Signed-off-by: Pratik Naik <pratiknaik@gmail.com >
2009-08-08 23:42:18 +01:00
Matt Duncan
bee3e099bd
Users can now pass :branch for git plugins and :revision for subversion plugins
...
[#2352 status:resolved]
Signed-off-by: José Valim <jose.valim@gmail.com >
2009-08-08 23:42:18 +01:00
José Valim
3ea091e1cc
Improved coverage for session_migration generator. [ #3008 status:resolved]
...
Signed-off-by: Pratik Naik <pratiknaik@gmail.com >
2009-08-08 23:42:18 +01:00
Elad Meidar
c0f828ca4f
Fixed reference to AR::SessionStore::Session.table_name in session migrations
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2009-08-08 23:42:18 +01:00
Marshall Huss
4d1552810f
HTTP proxy support
...
[#2133 state:committed]
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2009-08-08 15:33:55 -07:00
Emilio Tagua
9520143159
Merge commit 'rails/master'
...
Conflicts:
activerecord/test/cases/adapter_test.rb
activerecord/test/cases/method_scoping_test.rb
2009-08-08 19:14:35 -03:00
rizwanreza
5786395760
Allow content_tag options to take an array [ #1741 state:resolved] [rizwanreza, Nick Quaranto]
...
Example:
content_tag('p', "limelight", :class => ["song", "play"])
# => <p class="song play">limelight</p>
Signed-off-by: Pratik Naik <pratiknaik@gmail.com >
2009-08-08 22:21:32 +01:00
Pratik Naik
761283ffdb
Ensure hm:t#create/create! throws ActiveRecord::RecordNotSaved when the owner is new
2009-08-08 21:51:33 +01:00
Dan Croak
00544c778f
Add test ensuring redirect_to uses the given protocol [ #2886 ]
...
Signed-off-by: Pratik Naik <pratiknaik@gmail.com >
2009-08-08 20:48:39 +01:00
Pratik Naik
6464d76feb
DRY migration's rollback/forward methods
2009-08-08 20:47:14 +01:00
Pratik Naik
c6fe49b009
Simplyfy validates_length_of and remove puts
2009-08-08 19:08:39 +01:00
jzw
5ab94b2595
validates_length_of with maximum should allow nil [ #2309 status:resolved]
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2009-08-08 19:08:13 +01:00
José Valim
c34d6279a0
Allow radio buttons to work with booleans.
...
Signed-off-by: Pratik Naik <pratiknaik@gmail.com >
2009-08-08 18:02:07 +01:00
rizwanreza
1191e3ffaf
Add :include_blank option for select_tag [ #1987 status:resolved]
...
Signed-off-by: José Valim <jose.valim@gmail.com >
Signed-off-by: Pratik Naik <pratiknaik@gmail.com >
2009-08-08 17:58:27 +01:00
Pratik Naik
ed8a0a1c23
Ensure db:drop:all doesn't error out on exception [ #2997 state:resolved] [Anthony Caliendo]
2009-08-08 17:53:51 +01:00
Cristi Balan
7f84f14efa
Add rake db:forward - opposite of db:rollback [ #768 state:resolved]
...
Example:
rake db:forward # performs the next migration
rake db:forward STEP=4 # performs the next 4 migrations
Signed-off-by: Pratik Naik <pratiknaik@gmail.com >
2009-08-08 17:41:43 +01:00
Niklas Holmgren
c284412b14
Polymorphic routes generates collection URL from model class [ #1089 state:resolved]
...
Signed-off-by: Dan Pickett <dpickett@enlightsolutions.com >
Signed-off-by: Pratik Naik <pratiknaik@gmail.com >
2009-08-08 17:00:29 +01:00
Yehuda Katz
ad98827a78
Merge commit 'jose/responder'
2009-08-08 12:54:02 -03:00
José Valim
016ed9b429
Added rubygems to generators load_paths, but we only load generators from gems that are alraedy activated. This fixes the version problem and avoid silly conflicts.
2009-08-08 17:48:07 +02:00
José Valim
469d89dd44
Rename Rails::Generators::ActionORM to Rails::Generators::ActiveModel.
2009-08-08 17:48:07 +02:00
José Valim
6e0ac748e4
Renamed ActionController::Renderer to ActionController::Responder and ActionController::MimeResponds::Responder to ActionController::MimeResponds::Collector.
2009-08-08 17:48:07 +02:00
Yehuda Katz
efcfce50c4
Fixes "Cached fragment hit" written to log even if fragment is not cached (Erik Andrejko) [ #2917 state:resolved]
2009-08-08 12:46:44 -03:00
Bas Van Klinkenberg
0fbeaa98e4
Fixed a bug in JSON decoding with Yaml backend, where a combination of dates, escaped or unicode encoded data and arrays would make the parser fail with a ParseError exception. [ #2831 state:resolved]
...
Signed-off-by: Yehuda Katz <wycats@gmail.com >
2009-08-08 12:44:41 -03:00
Yehuda Katz
d0301e13f4
First pass at making partial rendering an Object. More cleanup to come.
2009-08-08 12:44:26 -03:00
Steve St. Martin
a8645593a4
remove duplicate call to stringify_keys [ #2587 status:resolved]
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2009-08-08 13:56:41 +02:00
Wolfram Arnold
73f2d37505
Add test to verify that the new :inverse_of association option will indeed fix the validation problem for a belongs_to relationship that validates_presence_of the parent, when both the parent and the child are new (in-memory) records. Also check that this works when the parents adds child via nested_attributes_for.
...
Lastly, add a require 'models/pet' to association_validation_test.rb, so that test can be run independently (was failing due to that missing dependency). [#2815 status:resolved]
Signed-off-by: José Valim <jose.valim@gmail.com >
2009-08-08 13:07:49 +02:00
Eric Davis
fbe6c3c195
Adds a :file delivery_method to save email to a file on disk
...
Signed-off-by: Michael Koziarski <michael@koziarski.com >
[#2438 state:committed]
2009-08-08 16:32:17 +12:00
Josh Sharpe
54e7f5ba43
Tidy up the AR tests, removing duplicates and making tests clearer / more focussed.
...
Signed-off-by: Michael Koziarski <michael@koziarski.com >
[#2774 state:committed]
2009-08-08 14:53:35 +12:00
Mike Breen
e8dc151396
Add option to routes task to target a specific controller with CONTROLLER=x.
...
Signed-off-by: Michael Koziarski <michael@koziarski.com >
[#2928 state:committed]
2009-08-08 14:38:33 +12:00
Matt Duncan
5fdc33c1a3
Default sent_on time to now in ActionMailer
...
Signed-off-by: Michael Koziarski <michael@koziarski.com >
[#2607 state:committed]
2009-08-08 14:11:32 +12:00
wmoxam
98450fd168
Fix number_to_precision rounding error [ #2071 state:resolved]
...
Signed-off-by: Pratik Naik <pratiknaik@gmail.com >
2009-08-08 02:05:10 +01:00
Xavier Noria
47a3701df9
AS guide: changes the example in explanation of MissingSourceFile
2009-08-08 02:54:48 +02:00
Xavier Noria
8d32c2c39b
AS guide: explains extensions to NameError
2009-08-08 02:54:04 +02:00
Jeremy Kemper
43b406bdb0
Ruby 1.9 compat: fix route recognition encoding test
2009-08-07 17:16:34 -07:00
Jeremy Kemper
12c271d1d2
Ruby 1.9.2: implicit argument passing of super from method defined by define_method() is not supported
2009-08-07 17:04:56 -07:00
Jeremy Kemper
019ed5a7c0
Don't rely on T::U::TestCase#name
2009-08-07 17:04:19 -07:00
Jeremy Kemper
482a6f716f
Ruby 1.9.2: Object#id is gone now
2009-08-07 16:41:04 -07:00
Emilio Tagua
ae9e1e9f6d
Removed unused methods.
2009-08-07 17:55:36 -03:00
Emilio Tagua
d469ad8a49
Removed useless OR.
2009-08-07 16:41:58 -03:00
Brendan Schwartz
201387496e
Ruby 1.9 compat: fix for SSL in Active Resource
...
[#1272 state:committed]
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2009-08-07 12:24:02 -07:00
Jeremy Kemper
06afa48c8c
Merge branch 'oracle_enhanced'
2009-08-07 11:58:45 -07:00
Yehuda Katz
010a0c92eb
Rename find_by_parts and find_by_parts? to find and exists?
2009-08-07 15:00:12 -03:00
Emilio Tagua
6b5fab9300
Don't scope order in calculations.'
2009-08-07 14:33:35 -03:00
Emilio Tagua
04abe538ac
Merge commit 'rails/master'
2009-08-07 13:27:36 -03:00
Emilio Tagua
945ef58533
More work on removing plain SQL from associations and use ARel instead.
2009-08-07 13:16:34 -03:00
José Valim
55575e2165
Allow rails templates relative to the current path to be given.
2009-08-07 17:17:51 +02:00
José Valim
aed135d3e2
Renamed presenter to renderer, added some documentation and defined its API.
2009-08-07 17:17:51 +02:00
José Valim
1fd65c80fc
Encapsulate respond_with behavior in a presenter.
2009-08-07 17:16:16 +02:00
José Valim
7034272354
Add destroyed? to ActiveRecord, include tests for polymorphic urls for destroyed objects and refactor mime responds tests and documentation.
2009-08-07 17:16:16 +02:00
José Valim
f59984cc81
Add nagivational behavior to respond_with.
2009-08-07 17:16:15 +02:00
José Valim
c44f7e39f4
Updated vendored thor to 0.11.5
2009-08-07 17:16:15 +02:00
José Valim
e45e120af9
Merge branch 'master' of git://github.com/rails/rails into old
2009-08-07 17:13:44 +02:00
Yehuda Katz
bfe58ac05d
Get all ActionController partial rendering to use ActionView's partial code. Consequences:
...
* It is not possible to always pre-determine the layout before going to ActionView.
This was *already* broken for render :partial => @object, :layout => true. This is
now handled by overriding render_to_body in layouts.rb and manually injecting the
partial's response. This needs to be done in ActionController since ActionController
knows enough to get _layout_for_option. There is probably a better abstraction here.
* As a result, all partial rendering can correctly restrict their layouts to the mime
type of the rendered partial. This could have previously caused a bug in some edge cases.
* If other layout-like options are added, they might need to add special code for the
case of render :partial. We should try to think of an alternate solution, if possible,
but this works for the cases we know of now.
2009-08-07 11:33:54 -03:00
José Valim
dac8927b05
Merge branch 'master' of git://github.com/rails/rails into old
2009-08-07 16:10:17 +02:00
Yehuda Katz
606e950ccb
Whitespace
2009-08-07 06:32:54 -03:00
Yehuda Katz
d94ba11295
Continue reworking the partial path.
...
* TODO: Review ActionController calling render_template for certain partials.
Might we be able to save logic by always delegating to AV's render_partial?
2009-08-07 06:32:17 -03:00
Yehuda Katz
493d84ce2f
Modify various partial methods to carry along the block that can be passed in with render
...
* _render_single_template, which renders a template without layout
* _render_partial_unknown_type, which renders a partial of unknown type
(the entry method for most partial rendering; supports strings, objects, and collections)
* _render_partial_object, which renders a partial for a single object.
* extracted _render_partial_path so it can be used to render the spacer without going
through the public render :partial
2009-08-07 05:40:01 -03:00
Yehuda Katz
59e475e3a6
Some more AV work:
...
* rename _render_partial to _render_partial_unknown_type to reflect that for this call,
we don't know the type.
* Merge _render_partial_with_block and _render_partial_with_layout to _render_partial
* TODO: Check to see if any more logic can be shared
* TODO: See about streamlining block path so we can get rid of @_proc_for_layout
* Remove @exempt_from_layout as it is no longer needed
2009-08-07 03:48:28 -03:00
Yehuda Katz
0612fd0f09
Replace _render_template_with_layout with _render_template since the layout is optional
2009-08-07 03:18:45 -03:00
Yehuda Katz
b3e199f698
Some more AV refactoring:
...
* remove no longer used _array_like_objects
* _render_content_with_layout renamed to _render_content since layout it optional
* remove check for optional layout before _render_content
2009-08-07 02:46:21 -03:00
Yehuda Katz
8534c5bf19
Start cleaning up partial path
2009-08-07 01:51:50 -03:00
Yehuda Katz
9b506484f1
This is handled by the resolver now
2009-08-07 01:51:32 -03:00
Yehuda Katz
70a440aa27
Clean up render @object a bit more.
2009-08-07 00:52:13 -03:00
Yehuda Katz
4ac9d391d3
Improve a path in _render_partial
2009-08-06 23:42:11 -03:00
Yehuda Katz
0435178ff8
Remove file that doesn't seem to be used anymore
2009-08-06 22:57:42 -03:00
Yehuda Katz
71638e6760
Move AbstractController to a top-level component
2009-08-06 22:51:24 -03:00
Yehuda Katz
16c01224cb
ActionController::Metal#to_rack converted to #to_a to match normal rack convention
2009-08-06 20:05:14 -03:00
Yehuda Katz
70d779aaea
Update _render_options to reflect the fact that they're public
2009-08-06 20:03:59 -03:00
Yehuda Katz
bd6b61be88
Rename /base to /metal and make base.rb and metal.rb top-level to reflect their module locations
2009-08-06 19:52:11 -03:00
Yehuda Katz
52798fd479
rename ActionController::Http to ActionController::Metal at Josh's suggestion
2009-08-06 19:50:22 -03:00
Yehuda Katz
af375a5eb3
Replace _action_view with view_context to reflect that it is public and that it does not need to be an ActionView instance
2009-08-06 19:45:40 -03:00
Yehuda Katz
f0945409d9
replace _render_*_from_controller with render_* as they are intended to be public
2009-08-06 19:43:28 -03:00
Emilio Tagua
4e86602e11
Merge commit 'rails/master'
2009-08-06 18:57:47 -03:00
Raimonds Simanovskis
5f0c425e8d
Some databases (e.g. Oracle) does not allow "AS" between table name and table alias name, for others it is optional
2009-08-06 23:41:00 +03:00
Raimonds Simanovskis
53be10c5e6
fixed test_foreign_key_violations_are_translated_to_specific_exception to work with Oracle
2009-08-06 23:41:00 +03:00
Raimonds Simanovskis
44a7ef85eb
modifications to Oracle connection.rb setup
2009-08-06 23:41:00 +03:00
Raimonds Simanovskis
9b2309c4a8
fix schema_dumper_test for Oracle as it supports precision up to 38
2009-08-06 23:41:00 +03:00
Raimonds Simanovskis
94e761551b
changed default connection to localhost orcl database
2009-08-06 23:41:00 +03:00
Raimonds Simanovskis
8afab34a76
always sort lists by id before comparison to avoid errors because of different sorting of same results (on Oracle database)
2009-08-06 23:41:00 +03:00
Raimonds Simanovskis
8f34c96614
support for assert_queries when using Oracle adapter
...
initialize $KCODE to UTF8 when JRuby is used
2009-08-06 23:41:00 +03:00
Raimonds Simanovskis
090ec47bec
added Subject#after_initialize to be the same as Topic#after_initialize
2009-08-06 23:41:00 +03:00
Raimonds Simanovskis
01a4e07c36
Oracle can store integers with any :limit
2009-08-06 23:41:00 +03:00
Raimonds Simanovskis
04e6bc1134
Oracle adapter recourns count() as numeric (not string)
2009-08-06 23:40:59 +03:00
Raimonds Simanovskis
5d0dece6a6
Oracle adapter gets Time or DateTime value already with timezone
2009-08-06 23:40:59 +03:00
Raimonds Simanovskis
ee654e54c4
Oracle generates different ORDER BY fragment
2009-08-06 23:40:59 +03:00
Raimonds Simanovskis
3a1cbc5c3b
Oracle adapter returns Time value for DATE columns
2009-08-06 23:40:59 +03:00
Raimonds Simanovskis
42fd2a3b16
added :order to find :all as otherwise Oracle tests were failing
2009-08-06 23:40:59 +03:00
Raimonds Simanovskis
c3e1ef0b40
Oracle needs sequence value for primary key in INSERT statement
2009-08-06 23:40:59 +03:00
Raimonds Simanovskis
a12358b3a5
Oracle adapter returns numeric (not string) value after SUM
2009-08-06 23:40:59 +03:00
Raimonds Simanovskis
d40e3ea936
Oracle saves empty string as NULL
2009-08-06 23:40:59 +03:00
Raimonds Simanovskis
71c32d3cac
1=2 is invalid expression in Oracle SELECT
2009-08-06 23:40:59 +03:00
Raimonds Simanovskis
5666a3ad06
added :order option to find :first methods and associations as otherwise Oracle tests were failing
...
Oracle stores '' string as NULL
Oracle cannot have identifiers larger than 30 characters
added missing fixtures to test setup method
2009-08-06 23:40:59 +03:00
Raimonds Simanovskis
963570b51c
added additional objects necessary for OracleAdapter specific tests
...
if OracleAdapter is used then use VARCHAR2(4000) instead of CLOB datatype as CLOB data type has many limitations in
Oracle SELECT WHERE clause which causes many unit test failures
2009-08-06 23:40:59 +03:00
Raimonds Simanovskis
04fea8a07b
modified native_oracle/connection.rb to run it with oracle_enhanced adapter
2009-08-06 23:40:58 +03:00
Rob Christie
7e560d0b0d
Fixed adapter test cases that were failing in oracle because the asserts were looking for the presence of offset and limit which are not available in oracle. Changed the tests to check that the sql injection is not present in the output so that the tests are database adapter agnostic.
2009-08-06 23:40:58 +03:00
Jeremy Kemper
7f717abb0e
Merge branch 'master' of git@github.com:rails/rails
2009-08-05 17:09:56 -07:00
Akira Matsuda
230d43fbf5
Ruby 1.9.2 compat: Array#* uses to_str instead of to_s to join values since Ruby 1.9.2
...
[#2959 state:committed]
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2009-08-05 17:08:02 -07:00
Pratik Naik
5ce3831faf
Use send instead of instance_eval
2009-08-06 00:11:28 +01:00
James Tucker
b7052b8dc3
Dont require thin as the thin rack adapter is now upstream
...
Signed-off-by: Pratik Naik <pratiknaik@gmail.com >
2009-08-05 23:00:33 +01:00
Xavier Noria
54b09fce0f
AS guide: documents extensions to LoadError
2009-08-05 23:54:01 +02:00
Xavier Noria
96780d52f6
AS guide: extensions to NilClass are documented in "Extensions to All Objects"
2009-08-05 23:54:00 +02:00
Xavier Noria
d60e499569
AS guide: extensions to (True|False)Class are documented in "Extensions to All Objects"
2009-08-05 23:54:00 +02:00
Emilio Tagua
ae175a5354
Merge commit 'rails/master'
2009-08-05 14:52:07 -03:00
James Hill
cfd421daa2
Allow validations to use values from custom readers [ #2936 state:resolved]
...
Signed-off-by: Joshua Peek <josh@joshpeek.com >
2009-08-05 11:45:01 -05:00
Matthew Rudy Jacobs
64268a0b06
Make sure javascript_include_tag/stylesheet_link_tag does not append ".js" or ".css" onto external urls [ #1664 state:resolved]
...
Signed-off-by: Pratik Naik <pratiknaik@gmail.com >
2009-08-05 15:58:55 +01:00
Geoff Buesing
bfafe8c405
Revert "fallback_string_to_date sets Date._parse comp arg to true, so that strings with two-digit years, e.g. '1/1/09', are interpreted as modern years" [ #2019 state:wontfix]
...
This reverts commit 55d1d12c32 .
2009-08-05 08:26:12 -05:00
Joshua Peek
f8d3c72c39
Extract generic attribute method generation to AMo
2009-08-04 23:36:05 -05:00
Joshua Peek
64eecdd131
whitespace
2009-08-04 16:28:44 -05:00
Paul Gillard
bada18dc36
Added reset_attribute! method to ActiveRecord::AttributeMethods::Dirty which will reset an attribute to its original value should it have changed.
...
Signed-off-by: Joshua Peek <josh@joshpeek.com >
2009-08-04 16:23:08 -05:00
Paul Gillard
c30a0ce3c8
Modified ActiveRecord::AttributeMethods to allow classes to specify attribute method prefixes and/or suffixes. Previously only suffixes were allowed.
...
Signed-off-by: Joshua Peek <josh@joshpeek.com >
2009-08-04 16:19:19 -05:00
Joshua Peek
aad5a30bf2
Add simple support for ActiveModel's StateMachine for ActiveRecord
2009-08-04 11:03:57 -05:00
Matt Ganderup
55d1d12c32
fallback_string_to_date sets Date._parse comp arg to true, so that strings with two-digit years, e.g. '1/1/09', are interpreted as modern years [ #2019 state:resolved]
2009-08-03 22:41:56 -05:00
Geoff Buesing
6f97ad07de
quoted_date converts time-like objects to ActiveRecord::Base.default_timezone before serialization. This allows you to use Time.now in find conditions and have it correctly be serialized as the current time in UTC when default_timezone == :utc [ #2946 state:resolved]
2009-08-03 22:03:47 -05:00
Emilio Tagua
f8eb4434d6
Added collection iteration to AR::Relation.
2009-08-03 14:15:47 -03:00
Emilio Tagua
31c83534d6
Don't use local vars before testing its conditional.
2009-08-03 13:59:34 -03:00
Emilio Tagua
62296a51c8
Merge commit 'rails/master'
2009-08-03 13:12:51 -03:00
Joshua Peek
9b68877897
Track generated attribute methods in a separate module
2009-08-02 21:06:35 -05:00
Yehuda Katz
b53f006901
Remove legacy processing and content_length
...
* convert_content_type! is handled by assign_default_content_type_and_charset!
* set_content_length! should be handled by the endpoint server. Otherwise
each middleware that modifies the body has to do the expensive work of
recalculating content_length.
* convert_language! appears to be legacy. There are no tests for this
* convert_cookies! should be handled by the new HeaderHash in Rack
* Use an integer for .status's internal representation to avoid needing to
do String manipulation just to find out the status
2009-08-02 19:39:33 -04:00
Yehuda Katz
503ce1d01c
Update cache_control to be a Hash of options that is used to build the header.
...
* Significantly simplifies setting and modifying cache control in other areas
2009-08-02 19:39:33 -04:00
Jeremy Kemper
f2a35723c8
Ruby 1.9: fix encoding for test_file_stream
2009-08-01 20:26:05 -07:00
Sava Chankov
ec94c2550d
Ruby 1.9: fix Content-Length for multibyte send_data streaming
...
[#2661 state:resolved]
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2009-08-01 20:25:59 -07:00
Jeremy Kemper
a606727606
Extract String#bytesize shim
2009-08-01 18:34:41 -07:00
Jeremy Kemper
cdf60e46cc
SQLite: drop support for 'dbfile' option in favor of 'database.'
2009-08-01 18:22:12 -07:00
Mike Gunderloy
f9308953a4
Updates/additions to contributing guide
2009-08-01 11:03:13 -05:00
Xavier Noria
b082cfa1e6
AS guide: explains a few extensions to Integer
2009-08-01 03:21:10 +02:00
José Valim
072c87b532
Merge branch 'respond_with'
2009-07-31 21:49:29 +02:00
Emilio Tagua
3de59e916d
Merge commit 'rails/master'
...
Conflicts:
activerecord/lib/active_record/associations.rb
2009-07-31 16:21:07 -03:00
Emilio Tagua
c1cbf02e31
Added ActiveRecord::Relation tests. Allow Relation to accept conditional
...
hashes and arrays like #find does.
2009-07-31 16:08:22 -03:00
José Valim
b2d24baf79
Added tests for nested resources.
2009-07-31 20:56:53 +02:00
José Valim
5b7e81efec
Allow respond_with to deal with http verb accordingly.
2009-07-31 11:59:05 +02:00
Joshua Peek
62fd1d3716
Start separating primary key concerns
2009-07-30 17:54:02 -05:00
Joshua Peek
ded3d97c5a
Make sure we use send for the default attribute method body because the suffix maybe an invalid method name
2009-07-30 17:54:02 -05:00
Joshua Peek
1ae7eb5200
Make sure to reset defined methods after calling attribute_method_suffix
2009-07-30 17:54:02 -05:00
Joshua Peek
d599ea27c5
Move attribute_types_cached_by_default into attribute methods reading concern
2009-07-30 17:54:02 -05:00
Joshua Peek
89e9efcbe2
Don't need to pass attr_name to evaluate_attribute_method anymore
2009-07-30 17:54:01 -05:00
Joshua Peek
2c30c9fe6c
Undefine id and let it automatically be generated
2009-07-30 17:54:01 -05:00
Joshua Peek
f8d2c77c90
Redirect method missing for primary key to read_attribute
2009-07-30 17:54:01 -05:00
Joshua Peek
9cdcfb4fc5
ditto for id=
2009-07-30 17:54:01 -05:00
Joshua Peek
831c38ffc7
Don't define id_before_type_cast, just let it be generated on its own
2009-07-30 17:54:01 -05:00
Joshua Peek
1841fd54e6
Move id attribute methods into their related concern
2009-07-30 17:54:01 -05:00
Joshua Peek
3e58f8e191
Restore DangerousAttributeError
2009-07-30 17:54:00 -05:00
Joshua Peek
e129c5673a
Wrap up attribute method reset concerns in 'undefine_attribute_methods'
2009-07-30 17:54:00 -05:00
Joshua Peek
586baf8ffe
read_attribute is always available through attribute
2009-07-30 17:54:00 -05:00
Joshua Peek
bd07c5ca8e
cache_attributes is related to attribute reading
2009-07-30 17:54:00 -05:00
Joshua Peek
94dabf9b4b
Generate methods for all suffixes
2009-07-30 17:54:00 -05:00
Joshua Peek
c2b075bed0
Concernify AR AttributeMethods
2009-07-30 17:53:59 -05:00
José Valim
7a4a679dba
Remove any resource logic from respond_to.
2009-07-30 22:43:37 +02:00
Yehuda Katz
2c2ca833a5
Removed default_internal, which was preventing round-tripping of some encodings.
2009-07-30 09:55:17 -07:00
Pratik Naik
83537bf090
Generator config should be commented by default
2009-07-30 17:49:48 +01:00
Pratik Naik
61d995f7ed
Remove whitespaces from the default mailer file
2009-07-30 17:49:48 +01:00
Marc Love
d860c89170
Fix tag helpers so that all HTML element boolean attributes render according to the specs. Added all boolean attributes listed in the XHTML 1.0 specs ( http://www.w3.org/TR/xhtml1/guidelines.html ) and HTML 5 specs ( http://www.whatwg.org/specs/web-apps/current-work ). HTML 5 boolean attribute rendering was broken in commit 1e2d722960 / [ #2864 state:resolved].
...
Signed-off-by: Yehuda Katz <wycats@gmail.com >
2009-07-30 09:48:27 -07:00
Rodrigo Rosenfeld Rosas
f320c994db
Fix typo in generate_message documentation.
2009-07-30 13:32:47 -03:00
Pratik Naik
915cf5747a
Merge commit 'mainstream/master'
...
Conflicts:
railties/guides/source/active_support_overview.textile
2009-07-30 14:18:53 +01:00
Xavier Noria
23f5e7e966
AS guide: explains Symbol#to_proc
2009-07-30 04:13:29 +02:00
Jeremy Kemper
d83b182857
Revert "Methods invoked within named scope Procs should respect the scope stack. [ #1267 state:resolved]"
...
This reverts commit 6a13376525 .
Conflicts:
activerecord/test/cases/named_scope_test.rb
2009-07-29 16:54:54 -07:00
José Valim
e566fc0577
Merge branch 'master' of git://github.com/rails/rails
2009-07-29 21:22:56 +02:00
José Valim
d209aea7d8
Remove last TODO.
...
Signed-off-by: Yehuda Katz <wycats@gmail.com >
2009-07-29 12:06:04 -07:00
José Valim
fa0cf663fe
Add a couple more tests to respond_with.
...
Signed-off-by: Yehuda Katz <wycats@gmail.com >
2009-07-29 12:06:03 -07:00
José Valim
09de34ca56
Added respond_with.
...
Signed-off-by: Yehuda Katz <wycats@gmail.com >
2009-07-29 12:06:03 -07:00
José Valim
bbe86077c2
Added tests for respond_to class method.
...
Signed-off-by: Yehuda Katz <wycats@gmail.com >
2009-07-29 12:06:03 -07:00
José Valim
67b2d08c0a
Ensure that the proper accept header value is set during tests.
...
Signed-off-by: Yehuda Katz <wycats@gmail.com >
2009-07-29 12:06:03 -07:00
José Valim
b51632d34d
Improve request test coverage by adding formats and negotiate_mime tests.
...
Signed-off-by: Yehuda Katz <wycats@gmail.com >
2009-07-29 12:06:02 -07:00
José Valim
7e280c3bff
Remove Mime::ALL from Mime::SET.
...
Signed-off-by: Yehuda Katz <wycats@gmail.com >
2009-07-29 12:06:02 -07:00
José Valim
3e8ba616ef
Refactor even more Responder. Move mime negotiation to request and added respond_to class method.
...
Signed-off-by: Yehuda Katz <wycats@gmail.com >
2009-07-29 12:06:02 -07:00
José Valim
3f445b316d
Refactor Responder to only calculate available mime types. Those are sent to the controller that knows what to do with it (render a block or call default render).
...
Signed-off-by: Yehuda Katz <wycats@gmail.com >
2009-07-29 12:06:02 -07:00
Yehuda Katz
c4d1075bd3
Add support for error_messages_for(@obj)
2009-07-28 19:06:14 -07:00
José Valim
7d56fd9f08
Always use application generator to run templates.
2009-07-28 16:21:30 +02:00
José Valim
d9aae2b56e
Merge branch 'master' of git://github.com/rails/rails
2009-07-28 09:00:33 +02:00
José Valim
5025ae610f
Ensure that not namespaced generators also load RAILS_ROOT/lib/templates files.
2009-07-28 08:51:57 +02:00
José Valim
419ca7a747
Ensure that developers options are overwritten by user options.
2009-07-28 08:48:21 +02:00
Pratik Naik
9533e0eca7
Ignore everything under test/fixtures/public/absolute
2009-07-27 17:21:52 +01:00
Xavier Noria
c783b48a8d
AS guide: explains File.atomic_write
2009-07-26 01:44:48 +02:00
José Valim
67c2f53938
Allow templates for non namespaced generators too.
2009-07-25 21:14:43 +02:00
Pratik Naik
e033b5d037
Merge docrails
2009-07-25 16:03:58 +01:00
Pratik Naik
e6b89126db
Revert "Added callback details in "supported options" of has_many association"
...
This reverts commit abe2038d5f .
Reason : It should add documentation to all the options
2009-07-25 15:48:23 +01:00
Pratik Naik
b2ef631f39
Revert asset tag changes
2009-07-25 15:35:47 +01:00
Pratik Naik
c6b16fc2aa
Merge commit 'mainstream/master'
2009-07-25 12:55:01 +01:00
Xavier Noria
f2d65a456f
i18n guide: removes some related for 2.2
2009-07-25 10:52:35 +02:00
Xavier Noria
0012ee5d95
i18n guide: minor tweaks
2009-07-25 10:38:57 +02:00
José Valim
edd07b5a7a
Updated vendored thor to 0.11.3.
2009-07-23 14:30:49 +02:00
José Valim
178044dbd2
Do not try to use thor gem.
2009-07-23 07:33:54 +02:00
John Duff
0c68d23f19
make pass through error code configurable [ #2817 state:resolved]
...
Signed-off-by: Joshua Peek <josh@joshpeek.com >
2009-07-22 22:21:06 -05:00
Joshua Peek
272c504f91
Dasherize XML root by default to avoid invalid tags "<admin/posts>...</admin/posts>" [ #2875 state:resolved]
2009-07-22 21:06:34 -05:00
John Maxwell
c39151a847
Patch to ActiveModel's (and ActiveRecord, by association) XML serialization: If two parameters are present in Procs supplied to to_xml's :procs option, the model being serialized will be passed as the second argument [ #2373 state:resolved]
...
Signed-off-by: Joshua Peek <josh@joshpeek.com >
2009-07-22 20:47:15 -05:00
Emilio Tagua
ca1e62f142
Performance: cache/reload arel relation when possible to speed up things.
2009-07-21 23:01:26 -03:00
Emilio Tagua
5123a2359b
Removed unused local variable.
2009-07-21 20:28:35 -03:00
Emilio Tagua
0e0866e056
Introduced ActiveRecord::Relation, a layer between an ARel relation and an AR relation
2009-07-21 20:21:03 -03:00
Emilio Tagua
f32c370983
Merge commit 'rails/master'
2009-07-21 11:27:23 -03:00
José Valim
33048b6e27
Solving merge conflicts.
2009-07-21 12:51:53 +02:00
José Valim
edda0bfe76
Allow nested and multiple fallbacks for generators.
2009-07-21 12:16:25 +02:00
José Valim
10fd021789
Change attributes default type to array to allow order to be preserved.
2009-07-21 12:00:02 +02:00
José Valim
c90419d4f4
Update db:sessions:create to use the proper generator.
2009-07-21 11:28:54 +02:00
Akira Matsuda
9d7aae7103
Ruby 1.9.2 compat: name method was renamed to __name__ since MiniTest 1.4.x [ #2922 state:resolved]
...
Signed-off-by: Yehuda Katz <wycats@gmail.com >
2009-07-21 01:15:51 -07:00
Akira Matsuda
9163b9ac9d
Ruby 1.9.2 compat: Use File#expand_path for require path because "." will not be included in LOAD_PATH since Ruby 1.9.2 [ #2921 state:resolved]
...
Signed-off-by: Yehuda Katz <wycats@gmail.com >
2009-07-21 00:09:39 -07:00
Joshua Peek
108545a9d6
Clean up validation example
2009-07-21 00:56:27 -05:00
Joshua Peek
574323df62
So you can require 'activemodel'
2009-07-21 00:52:50 -05:00
Joshua Peek
92c00d7586
AMo conversion helper
2009-07-21 00:51:57 -05:00
Joshua Peek
6944b391cd
Kill AMo Base
2009-07-21 00:13:26 -05:00
Joshua Peek
48bc39e03a
Improve AMo observing docs
2009-07-21 00:11:26 -05:00
Joshua Peek
7c84bbf160
Add wrap_with_notifications helper to AMo observing
2009-07-20 23:57:01 -05:00
Joshua Peek
2685d93b07
Kill AMo ivar attributes helper
2009-07-20 23:28:58 -05:00
Yehuda Katz + Carl Lerche
e7a2496fda
Vendor the bundler project
2009-07-20 18:03:38 -07:00
Yehuda Katz
d80316ad32
First effort at new Ajax helpers
2009-07-20 16:13:21 -07:00
Emilio Tagua
9a28bd7876
Merge commit 'rails/master'
2009-07-20 16:57:23 -03:00
Emilio Tagua
b326faef09
Performance boost for AR#create
2009-07-20 16:56:15 -03:00
Emilio Tagua
046c22c8c1
Removed legacy test.
2009-07-20 16:53:48 -03:00
Mike Gunderloy
679a556294
Insert missing word in callbacks documentation.
2009-07-19 19:54:51 -05:00
Yehuda Katz
37658f15bb
Merge branch 'master' of git@github.com:rails/rails
2009-07-19 13:21:17 -07:00
Yehuda Katz
f2f5cdc8bc
Rename ActiveRecordHelper to ActiveModelHelper
2009-07-20 01:30:49 +09:00
Yehuda Katz
b00cac4adc
Finish convert_to_object updates
2009-07-20 01:22:24 +09:00
Yehuda Katz
13e18dd940
Update some tests and add a to_model to form helpers
2009-07-20 00:58:59 +09:00
Yehuda Katz
5ffaaa71d1
Define ActiveModel API Compliance
...
- Define to_model on AR
- Define to_model on ActiveModel::APICompliant
- Update test fixtures to be API Compliant
- Start using to_model in AP
2009-07-20 00:27:04 +09:00
Yehuda Katz
45d41d8012
Add some simple examples for unconventional AMo and AP use
2009-07-19 23:24:19 +09:00
Yehuda Katz
b20d68446d
Move default_form_builder to ActionView so it'll work in environments not using ActionView::Base
2009-07-19 22:31:55 +09:00
Yehuda Katz
0f2914be40
Separate ActionView::Context so something else can easily be made into an AV context
2009-07-19 22:31:44 +09:00
Yehuda Katz
bb530923bc
Simplify required "ActionView compliant" API
2009-07-19 21:53:02 +09:00
Mike Gunderloy
1c167cd6fb
Minor cleanup to Getting Started for 2.3.3
2009-07-18 16:50:52 -05:00
Sven Fuchs
17d5cc12b9
* don't include String#% for Ruby 1.9
...
* raise a KeyError exception for missing named interpolation args (like Ruby 1.9 does)
* raise an ArgumentError when mixing named and unnamed placeholders (like Ruby 1.9 does)
* improve docs and comply a bit more w/ Rails names/conventions
[#2870 state:committed]
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2009-07-18 11:27:27 -07:00
Xavier Noria
2637c5eee1
redirect_to forwards options to url_for if it is a Hash (the example with articles_url does not work indeed because of that), understanding :params is a particular case of that
...
This reverts commit 0fc481d7c8 .
2009-07-17 00:37:41 +02:00
danielc192
0fc481d7c8
The redirect_to method in ActionController supports the :params option, however this is not mentioned in the documentation. This commit adds this. It includes an example and a brief description of the :params option.
2009-07-16 12:53:29 -07:00
Emilio Tagua
87ca87d635
Merge commit 'rails/master'
2009-07-16 16:18:25 -03:00
kommissar
3032795c50
minor HTML and formatting fixes
2009-07-16 14:52:54 -04:00
Christopher J. Kenna
3e599e6d8e
fixed typo. meaning was opposite of intent.
2009-07-16 13:18:02 -04:00
Emilio Tagua
f4a23567e2
Added ActiveRecord::Base#(where|join|project|group|order|take|skip) methods.
2009-07-16 13:35:07 -03:00
José Valim
d6a590a710
Modified rake tasks to use new app generator structure and updated Thor version.
2009-07-16 11:17:19 +02:00
José Valim
b03034a686
Update vendored Thor to have latest actions updates.
2009-07-16 10:16:23 +02:00
Szymon Nowak
1c11437a32
Add primary_key option to belongs_to association
...
[#765 state:committed]
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2009-07-15 18:13:32 -07:00
Xavier Noria
b794765296
AS guide: documents extensions related to instance variables
2009-07-16 02:26:22 +02:00
José Valim
fa5f7f7087
Merge branch 'master' of git://github.com/rails/rails
2009-07-16 00:28:33 +02:00
José Valim
e3d5364e41
Implemented generaators fallbacks.
2009-07-16 00:17:28 +02:00
Ryan Bigg
00d899e11f
More documentation about methods taking blocks.
2009-07-16 07:52:49 +10:00
Ryan Bigg
bb8fb2d143
Document that after_create can take a block.
2009-07-16 07:48:54 +10:00
José Valim
9c4ba74b7c
Change generators configuration to have a hash style.
2009-07-15 23:38:41 +02:00
Yehuda Katz
1a2946a6d9
Add some missing dependencies
2009-07-15 14:16:30 -07:00
Yehuda Katz
1273ffa186
Fix AbstractController::Layouts to work when included directly on a controller
2009-07-15 14:16:12 -07:00
Yehuda Katz
28508d444e
Centralize commonly used parts of AS in ActionController into action_controller.rb
2009-07-15 14:15:52 -07:00
José Valim
bcf754d8c4
Add a form hook to erb scaffold. Customize and go!
2009-07-15 22:43:25 +02:00
José Valim
8d47078a49
Added source_paths to rails generators. If a template is added to RAILS_ROOT/lib/templates/base/generator it will be used. For example, to customize edit.html.erb template on scaffold, just add a customized copy at RAILS_ROOT/lib/templates/erb/scaffold.
2009-07-15 22:37:22 +02:00
Lourens Naude
0920e69244
ActiveSupport Hash optimizations [ #2902 state:resolved]
...
Signed-off-by: Carl Lerche <carllerche@mac.com >
2009-07-15 13:23:05 -07:00
José Valim
b4ef958de6
Change false to :verbose => false as in new Thor version.
2009-07-15 20:16:37 +02:00
José Valim
baa4781ac7
Allow nil and false to be given as configuration values and avoid creating unecessary hashes.
2009-07-15 16:53:54 +02:00
José Valim
7022b58842
Allow namespaced configuration on generators.
2009-07-15 16:20:48 +02:00
Xavier Noria
65ab56bb18
AS guide: documents with_options
2009-07-15 12:09:22 +02:00
José Valim
0702e04e0d
Refactored some generators to make use of improved invocations on thor.
2009-07-15 11:33:36 +02:00
Emilio Tagua
634f6713ee
Merge commit 'rails/master'
2009-07-14 23:00:08 -03:00
Xavier Noria
3469fb93c5
AS guide: fixes internal link
2009-07-15 01:03:17 +02:00
Xavier Noria
0a1af53892
AS guide: documents Object#returning
2009-07-15 01:02:46 +02:00
José Valim
a06c825b46
Updated vendored Thor to 0.11.1 and update Rails::Generators.
2009-07-14 22:20:43 +02:00
José Valim
e96af1eaa2
Add version to thor frozen gem.
2009-07-14 15:44:14 +02:00
José Valim
925c9104e0
Copy Thor files instead of using as a submodule.
2009-07-13 23:21:47 +02:00
José Valim
5021dc69a4
Vendorized Thor.
2009-07-13 23:13:48 +02:00
José Valim
52673cd2ee
Added a generator generator.
2009-07-13 23:01:12 +02:00
Pratik Naik
40b387580f
Use map! instead of map for <association>_ids
2009-07-13 21:59:06 +01:00
José Valim
a5ab030ae4
Ensure non timestamped migrations are generated properly.
2009-07-13 22:26:58 +02:00
José Valim
25647f7021
Add some attribute readers to migration module.
2009-07-13 20:42:25 +02:00
José Valim
b9f4ea7198
Add hooks for integration and performance tests.
2009-07-13 18:29:40 +02:00
José Valim
f68e7a3987
Remove generator environment until we have a gem manifest.
2009-07-13 18:18:08 +02:00
Pratik Naik
373b053dc8
Optimize <association>_ids for hm:t with belongs_to source
2009-07-13 16:29:19 +01:00
José Valim
21019304f0
Make explicit that references and belongs_to types have nil as default value.
2009-07-13 16:18:56 +02:00
José Valim
ae7a7852d5
Always allow params to be skipped on action orm in generators.
2009-07-13 15:08:45 +02:00
José Valim
d5225c1fd5
Do not require options on class_option.
2009-07-13 14:30:32 +02:00
José Valim
cd28dcb5a4
Cache source root in a rails specific variable.
2009-07-13 13:39:48 +02:00
Xavier Noria
6f49e7fe08
just removes a blank line
2009-07-13 00:17:39 +02:00
Xavier Noria
29ce39e217
AS guide: documents Object#try
2009-07-13 00:07:13 +02:00
José Valim
3075ae0611
Solving merge conflicts.
2009-07-12 16:29:15 +02:00
Yehuda Katz
b0429f5e66
Rename method to a more obvious name
2009-07-11 23:40:36 -04:00
Xavier Noria
ae44ed5908
AS guide: explains Object#tap
2009-07-12 01:58:28 +02:00
Joshua Peek
c863388039
Add observing hooks to ARes
2009-07-11 16:59:11 -05:00
Joshua Peek
e83a05af07
Integrate AMo XML serializer into AR
2009-07-11 16:20:58 -05:00
Karel Minarik
ee7487e46a
Fix typo in I18n guide. Closes ticket #83 reported by noocx
2009-07-11 21:11:58 +02:00
Xavier Noria
f081fe2679
AS guide: class objects are not duplicable either
2009-07-11 01:11:55 +02:00
Xavier Noria
4f59ebb1a6
class objects are not duplicable either
2009-07-11 01:11:28 +02:00
Xavier Noria
9b43e6b54e
AS guide: documents duplicable?
2009-07-11 01:05:22 +02:00
Joshua Peek
01d92021e6
Switch scaffolding templates to HTML 5 doctype
2009-07-10 11:34:39 -05:00
Mike Gunderloy
5c0a76c41a
Updated migration documentation to reflect default for UTC timestamped migration names
2009-07-09 06:07:27 -05:00
José Valim
cca16a015d
Do not clean up frameworks on generators environment, otherwise initializers, gems and plugins might not be loaded properly.
2009-07-09 10:04:59 +02:00
Sam Goldstein
d60d7edce4
Make it so AR attributes which conflict with object-private methods (e.g. system) don't 'randomly' cause NoMethodErrors
...
Previously if you called this attribute before others, you'd get exceptions. But if it was the second-or-subsequent attribute you retrieved you'd get the correct behaviour.
Signed-off-by: Michael Koziarski <michael@koziarski.com >
[#2808 state:committed]
2009-07-09 16:44:30 +12:00
Xavier Noria
af29eeeafd
Action Mailer guide: revised a couple of links, thanks to Kyle Mathews
2009-07-08 23:25:02 +02:00
José Valim
09c288f0c5
Add the new generators environment and update commands.
2009-07-08 12:55:50 +02:00
José Valim
c9ea21717e
Generators are configured on initialization if RAILS_ENV=generators.
2009-07-08 12:53:45 +02:00
José Valim
2699e9c2dd
Added config.generators with tests.
2009-07-08 12:53:45 +02:00
José Valim
c07746cbdf
Merge branch 'master' of git://github.com/rails/rails
2009-07-08 12:53:13 +02:00
Lawrence Pit
579250ea46
Use the i18n gem if present instead of vendor code. [ #2871 state:resolved]
...
Signed-off-by: Yehuda Katz <wycats@gmail.com >
2009-07-07 18:36:42 -07:00
mynyml
8c7300ed56
Callback chain stops on *true* block result (rdoc).
...
Relevant code (in CallbackChain#run):
break result if terminator.call(result, object)
2009-07-08 08:47:06 +08:00
Lawrence Pit
da635394c1
Ruby 1.9 style String interpolation support for lower ruby versions. Thanks to code from Masao Mutoh's GetText gem. [ #2870 state:resolved]
...
Signed-off-by: Yehuda Katz <wycats@yehuda-katzs-macbookpro41.local >
2009-07-07 16:21:57 -07:00
Hongli Lai (Phusion)
187d90f752
Add support for dumping non-standard primary keys when using the SQLite3 adapter. Fix unit tests so that this feature is tested for all adapters. [ #2868 state:resolved]
...
Signed-off-by: Yehuda Katz <wycats@yehuda-katzs-macbookpro41.local >
2009-07-07 16:17:25 -07:00
Emilio Tagua
1e2d722960
Adds a audio_tag helper for the HTML5 audio tag. Fixed video_path docs. HTML attributes values should be true or false not attribute's name. [ #2864 state:resolved]
...
Signed-off-by: Yehuda Katz <wycats@yehuda-katzs-macbookpro41.local >
2009-07-07 15:56:27 -07:00
Abhishek Parokar
abe2038d5f
Added callback details in "supported options" of has_many association
2009-07-07 15:29:43 +05:30
Xavier Noria
62725b1de8
updates work status of fxn
2009-07-07 01:39:46 +02:00
Yehuda Katz + Carl Lerche
61604feec0
Get Initializer tests running without requiring parts of Rails being loaded first
2009-07-06 12:25:34 -07:00
Yehuda Katz + Carl Lerche
9a42e06dd8
Reapply Rails::Application::Path tweaks
...
Reapplies: a4bdc00fec
3c1dab7225
2009-07-06 10:22:42 -07:00
José Valim
dd7ee082be
Use active_support/mini since we just need inflections.
2009-07-06 18:38:27 +02:00
José Valim
66d1b968d1
Make specs pass on Ruby 1.9.
2009-07-06 18:31:28 +02:00
Emilio Tagua
fb46d00fdf
Merge commit 'rails/master'
2009-07-06 10:29:05 -03:00
José Valim
eeb6a0786a
Load generators from user home and show a error message if they can't be loaded.
2009-07-04 20:17:32 +02:00
José Valim
b277cf28e8
Allow scaffold controller to load action_orm files on demand.
2009-07-04 20:17:32 +02:00
José Valim
35925a8995
Ensure that rails templates methods are invoked with the proper extensions [ #2531 status:resolved]
2009-07-04 20:17:32 +02:00
José Valim
8ff214e0db
Use the proper shebang when using Ruby 1.9 or jruby or windows.
2009-07-04 20:17:32 +02:00
José Valim
da09d46ed4
Make generators test pass with latest Thor version
2009-07-04 20:17:32 +02:00
José Valim
cd388e075c
Search for generators on vendorized plugins and gems.
2009-07-04 20:17:31 +02:00
José Valim
37ba0047a9
Removed invoke_if and allow hook_for to accept boolean options.
2009-07-04 20:17:31 +02:00
José Valim
9e36dd4e1c
Remove update_js from Rakefile and the uneeded railsgen.
2009-07-04 20:17:31 +02:00
José Valim
20e2140ce7
Merge branch 'master' of git://github.com/rails/rails
2009-07-04 20:16:36 +02:00
Joshua Peek
783db25e0c
Integrate AMo JSON serializer into AR
2009-07-03 23:12:42 -05:00
Joshua Peek
d2b78b3594
Initial extraction of AMo xml serializer
2009-07-03 21:38:14 -05:00
Joshua Peek
e3d6d10e1f
Ensure JSON serializer includes model naming
2009-07-03 21:38:13 -05:00
Emilio Tagua
6d4b6a247e
Merge commit 'rails/master'
2009-07-03 12:17:23 -03:00
José Valim
44633dc7a5
Add some tests for no_color! behavior.
2009-07-03 15:12:18 +02:00
José Valim
21db04818e
More tests for rails generators and lookup.
2009-07-03 14:57:46 +02:00
José Valim
3ca504c966
Removed remaining old generators files.
2009-07-03 14:57:46 +02:00
José Valim
de68cf7e06
Plugin generators now reflect new generators sutrcture.
2009-07-03 14:57:46 +02:00
José Valim
d1c404ee90
Added lookup to generators.
2009-07-03 14:57:46 +02:00
José Valim
3bf45890b3
Merge branch 'master' of git://github.com/rails/rails
2009-07-03 14:56:19 +02:00
Pratik Naik
2fe263bb32
Merge commit 'mainstream/master'
...
Conflicts:
actionpack/lib/action_controller.rb
actionpack/lib/action_controller/base/base.rb
actionpack/lib/action_view/template/path.rb
activesupport/lib/active_support/json/encoders/hash.rb
2009-07-03 13:01:39 +01:00
Pratik Naik
a4bdc00fec
Revert "Compact the way application paths are defined"
...
This reverts commit 940aad225a .
Reason : The server does not start
2009-07-03 12:35:53 +01:00
Pratik Naik
3c1dab7225
Revert "Modify the Rails::Application::Path object to allow for more concise path definition."
...
This reverts commit 913bb2f4c2 .
Reason : The server does not start
2009-07-03 12:23:57 +01:00
Yehuda Katz + Carl Lerche
378a65a909
Added tests for the :install_gem_spec_stubs initializer
2009-07-02 17:52:46 -07:00
Yehuda Katz + Carl Lerche
d8406f0c20
Wrote tests for the :check_ruby_version initializer
2009-07-02 16:51:05 -07:00
Yehuda Katz + Carl Lerche
1d280e21a1
Adds support for def self.setup in isolation tests for setup that should be run only once in the parent
2009-07-02 16:03:41 -07:00
Yehuda Katz + Carl Lerche
940aad225a
Compact the way application paths are defined
2009-07-02 15:49:35 -07:00
Yehuda Katz + Carl Lerche
913bb2f4c2
Modify the Rails::Application::Path object to allow for more concise path definition.
2009-07-02 15:47:11 -07:00
Emilio Tagua
cd424f0f32
Merge commit 'rails/master'
2009-07-02 16:30:55 -03:00
Jesús García Sáez
fc6077d76e
Allow symbols on routes declaration (:controller and :action values) [ #2828 state:resolved]
...
Signed-off-by: Yehuda Katz + Carl Lerche <ykatz+clerche@engineyard.com >
2009-07-02 12:18:48 -07:00
Yehuda Katz + Carl Lerche
0fbf458b6c
Removed unnecessary calls to image_path and hash lookups [ #2827 state:resolved]
2009-07-02 12:14:23 -07:00
Brian Abreu
d036899717
Fixed ActiveSupport::OrderedHash::[] work identically to ::Hash::[] in ruby 1.8.7 [ #2832 state:resolved]
...
Signed-off-by: Yehuda Katz + Carl Lerche <ykatz+clerche@engineyard.com >
2009-07-02 12:01:05 -07:00
Jarl Friis
e61afed6f8
My suggestion to fix ticket 2401 [ #2401 state:resolved]
...
Signed-off-by: Yehuda Katz + Carl Lerche <ykatz+clerche@engineyard.com >
2009-07-02 11:55:24 -07:00
Aaron Patterson
49bdbebca6
wycats forgot a +1, so I added it [ #2749 state:resolved]
...
Signed-off-by: Yehuda Katz + Carl Lerche <ykatz+clerche@engineyard.com >
2009-07-02 11:39:06 -07:00
Levin Alexander
ab2d6abb55
make #inspect if zero length duration return '0 seconds' instead of empty string [ #2838 state:resolved]
...
Signed-off-by: Yehuda Katz + Carl Lerche <ykatz+clerche@engineyard.com >
2009-07-02 11:22:25 -07:00
Yehuda Katz + Carl Lerche
cf5b2b250f
Fixes a number of tests that inexplicably didn't fail when we committed the original patch
2009-07-02 10:50:25 -07:00
Tieg Zaharia
51d7b3070c
Adds a video_tag helper for the HTML5 video tag (similar to how the image_tag works) (tests included); removes a duplicate test line for image_tag; adds boolean attributes for video tag to tag()'s boolean attributes
...
Signed-off-by: Yehuda Katz + Carl Lerche <ykatz+clerche@engineyard.com >
2009-07-02 10:36:38 -07:00
J.D. Hollis
9eab435631
Only check for built extensions on gem dependencies that are in vendor/gems. [ #2825 state:resolved]
...
Signed-off-by: Yehuda Katz + Carl Lerche <ykatz+clerche@engineyard.com >
2009-07-02 10:27:54 -07:00
José Valim
b7bc68076c
Make color optional.
2009-07-02 15:57:37 +02:00
José Valim
528d555e37
Make invoke output white and use padding.
2009-07-02 15:55:21 +02:00
Xavier Noria
bf5ac9965f
routing guide: removes misleading full stop, thanks to steven_noble
2009-07-02 14:53:24 +02:00
Xavier Noria
5b59bff705
migrations guide: updates link to foreign_key_migrations plugin, thanks to holli
2009-07-02 14:45:40 +02:00
José Valim
a08a8cd8d2
Add update tasks.
2009-07-02 11:47:03 +02:00
José Valim
826a6a72fe
Updated rake tasks.
2009-07-02 11:40:00 +02:00
José Valim
ec55e59e99
Updated commands.
2009-07-02 11:08:07 +02:00
José Valim
776220e1e2
Rename a wrongly named file.
2009-07-02 10:27:40 +02:00
José Valim
ea0b0c820d
rm -rf rails_generator/generators
2009-07-02 10:27:40 +02:00
José Valim
c972b25df5
Tests for scaffold generator.
2009-07-02 10:27:40 +02:00
José Valim
a7c1591315
Added stylesheets controller which is invoked by scaffold.
2009-07-02 10:27:40 +02:00
José Valim
7f7afdf0f1
Rename ControllerNamedBase to ScaffoldBase and move ActionORM helpers.
2009-07-02 10:27:40 +02:00
José Valim
1a4d8aca8a
Added tests to scaffold controller.
2009-07-02 10:27:40 +02:00
José Valim
86ff074101
Added test unit files for scaffold_controller.
2009-07-02 10:27:40 +02:00
José Valim
80cd16372c
Added scaffold views to scaffold controller.
2009-07-02 10:27:39 +02:00
José Valim
9541977e04
Make scaffold controller generate agnostic code and mark some hooks as required.
2009-07-02 10:27:39 +02:00
José Valim
bf672a12a3
Added Rails::Generators::ActionORM to hold ORM methods necessary to build a generator.
2009-07-02 10:27:39 +02:00
José Valim
0760d5b542
Added comments to meta programming code.
2009-07-02 10:27:39 +02:00
José Valim
555a956a66
Ensure both migration and routes are removed on revoke.
2009-07-02 10:27:39 +02:00
José Valim
10a9205c58
Put migration methods into a separate folder and let just ActiveRecord dependency in ActiveRecord models.
2009-07-02 10:27:39 +02:00
José Valim
b77a7dcf4d
Added controller named base.
2009-07-02 10:27:39 +02:00
José Valim
d5d0b8ea8e
Removing unecessary class methods.
2009-07-02 10:27:39 +02:00
José Valim
35c4df4aa5
Added scaffold_controller.
2009-07-02 10:27:39 +02:00
José Valim
00b168e9d0
Show second level invocations on usage.
2009-07-02 10:27:39 +02:00
José Valim
dec1ee7422
Started with scaffold controller and added remove_hook_for.
2009-07-02 10:27:39 +02:00
José Valim
1c265da1db
Merge branch 'master' of git://github.com/rails/rails
2009-07-02 10:25:18 +02:00
Elliot Winkler
8bb510f6c1
Patch FormTagHelper so that when a form tag is created, the div which holds the form authenticity token is set to display:inline [ #2846 state:resolved]
...
Signed-off-by: Yehuda Katz + Carl Lerche <ykatz+clerche@engineyard.com >
2009-07-01 17:12:08 -07:00
Yehuda Katz + Carl Lerche
ee7d4c47e7
Fixes bug where Memcached connections get corrupted when an invalid expire is passed in [ #2854 state:resolved]
2009-07-01 16:56:43 -07:00
Emilio Tagua
084e4a2dd4
Merge commit 'rails/master'
2009-07-01 20:36:53 -03:00
Emilio Tagua
260c847817
Create is now powered by Arel. Removed methods that are no longer used.
2009-07-01 20:34:26 -03:00
Akira Matsuda
92bff2ebf1
Fix pattern to match various magic comment formats
2009-07-01 16:26:15 -07:00
Jeremy Kemper
49824e8ad6
JSON.escape returns UTF-8 strings
...
[#2849 state:resolved]
2009-07-01 16:22:19 -07:00
Jeremy Kemper
f37a2ea84c
uses Hash#except/slice
2009-07-01 16:01:20 -07:00
Yehuda Katz + Carl Lerche
8e3e362aed
Forgot to commit the new file. This is slightly embarrassing.
2009-07-01 15:26:14 -07:00
Yehuda Katz + Carl Lerche
1a6f4d424a
Apparently stdlib isn't std enough
2009-07-01 15:20:02 -07:00
Yehuda Katz + Carl Lerche
3990c128ef
Modify isolation test to require a file not in use anywhere in Rails
2009-07-01 15:06:11 -07:00
Yehuda Katz + Carl Lerche
677f74dd0d
Updates CI to use latest mocha
2009-07-01 13:50:05 -07:00
Jeremy Kemper
e7312105c7
Merge branch 'master' of git@github.com:rails/rails
2009-07-01 12:55:19 -07:00
Yehuda Katz + Carl Lerche
1026d7706f
Original cache objects should not be immutable [ #2860 state:resolved]
...
Signed-off-by: Yehuda Katz + Carl Lerche <ykatz+clerche@engineyard.com >
2009-07-01 12:16:55 -07:00
Yehuda Katz + Carl Lerche
16dc139caa
Added AR:B#dup method for duplicationg object without frozen attributes [ #2859 state:resolved]
...
Signed-off-by: Yehuda Katz + Carl Lerche <ykatz+clerche@engineyard.com >
2009-07-01 12:16:35 -07:00
Emilio Tagua
0f5785c997
Small refactor to update_all.
2009-07-01 16:16:11 -03:00
Yehuda Katz + Carl Lerche
882dd4e605
ensure Inflector.camelize works with symbols [ #2856 state:resolved]
...
Signed-off-by: Yehuda Katz + Carl Lerche <ykatz+clerche@engineyard.com >
2009-07-01 12:14:34 -07:00
Emilio Tagua
a9cd9f4c75
Merge commit 'rails/master'
2009-07-01 16:07:45 -03:00
Yehuda Katz + Carl Lerche
7583a24ee0
Move mocha down below initial T::U require and bump version to 0.9.7 [ #2858 state:resolved]
2009-07-01 11:53:17 -07:00
Yehuda Katz + Carl Lerche
0515256fd3
Accept Symbol for contoller name [ #2855 state:resolved]
...
Signed-off-by: Yehuda Katz + Carl Lerche <ykatz+clerche@engineyard.com >
2009-07-01 11:16:18 -07:00
Yehuda Katz + Carl Lerche
eea7b5db1d
Crazy hacks to get the Isolation testing module to work on non forking environments
2009-06-30 17:39:32 -07:00
Emilio Tagua
cbf8ecc1cb
Merge commit 'rails/master'
2009-06-30 20:32:28 -03:00
Emilio Tagua
e5b8c4483c
Merge commit 'rails/master'
...
Conflicts:
activerecord/lib/active_record/base.rb
2009-06-30 20:12:17 -03:00
Pratik Naik
45e6f19925
Revert "Revert "Generate proper :counter_sql from :finder_sql when there is a newline character immediately following 'SELECT' [ #2118 state:resolved]""
...
This reverts commit 80f1f863cd .
The feature doesn't work on Postgres, so don't test it on Postgres.
Also, Postgres compatibility is irrelevant to the ticket/patch in question.
2009-07-01 00:02:00 +01:00
Emilio Tagua
9c70442534
Merge commit 'rails/master'
...
Conflicts:
activerecord/test/cases/adapter_test.rb
2009-06-30 19:34:26 -03:00
Carl Lerche
db3de78a83
Bump up the version to 3.0.pre
2009-06-30 14:37:12 -07:00
Carl Lerche
132e6d0063
Add #concat to Rails::Application::Path
2009-06-30 13:55:11 -07:00
Carl Lerche
f281745056
Test that builtin_directories is only used in development mode
2009-06-30 13:53:03 -07:00
Yehuda Katz + Carl Lerche
575b95ea0b
Created AS::Testing::Isolation which runs each test case in a separate process.
...
This allows for testing rails bootup (files are required, correct constants are
set, etc...). Currently, this is implemented via forking only, but we will add
support for jruby and windows shortly.
2009-06-30 12:00:50 -07:00
Carl Lerche
9101941c12
Require core_ext/kernel/requires in test_help to providing #require_library_or_gem
2009-06-30 09:05:53 -07:00
Carl Lerche
f66b5d79c1
Stop the initializer from blowing up when builtin_directories is empty
2009-06-30 09:01:46 -07:00
Carl Lerche
4954379283
Remove stray checks for Rspec in the testing setup.
2009-06-30 08:41:17 -07:00
Justin French
7d548f795d
Changed ActiveRecord::Base.human_name to underscore the class name before it humanizes it
...
This gives you 'Post comment' rather than 'Postcomment' by default.
Signed-off-by: Michael Koziarski <michael@koziarski.com >
[#2120 state:committed]
2009-06-30 15:24:04 +12:00
José Valim
4739f0ff5d
Small fix to plugin generator.
2009-06-29 21:08:12 +02:00
José Valim
95ef9bd67f
Simplifying resource generator.
2009-06-29 19:56:22 +02:00
José Valim
ff4c600448
Added singleton support to resource controller.
2009-06-28 19:57:00 +02:00
José Valim
9413dba432
Added tessts for resources generator.
2009-06-28 19:46:34 +02:00
José Valim
9068bc05b8
Added ResourceGenerator.
2009-06-28 18:28:30 +02:00
José Valim
a2d4d755ae
Use inject_into_file instead of gsub_file (the first is reversible)
2009-06-28 16:48:22 +02:00
José Valim
1ca51df000
Added migration and session_migration generator.
2009-06-28 13:16:14 +02:00
José Valim
4f3e44fa03
Move file action only to app generator.
2009-06-28 12:00:13 +02:00
José Valim
496dde95fb
Added migrations and make base generators be lazy loaded.
2009-06-28 11:56:44 +02:00
Xavier Noria
b0df8b615e
AS guide: added section "Silencing Warnings, Streams, and Exceptions"
2009-06-28 02:22:57 +02:00
José Valim
c03585aa8d
Show invoked generators options on meta generators.
2009-06-27 21:30:00 +02:00
José Valim
fdeee65c96
Add model_subclass generator with deprecation warning.
2009-06-27 21:30:00 +02:00
José Valim
7b6c5ed7db
Added parent option to model generator.
2009-06-27 21:30:00 +02:00
José Valim
ff44e5055c
Output invocations.
2009-06-27 21:30:00 +02:00
José Valim
1a15dd4de5
Rename invoke_for to hook_for.
2009-06-27 21:30:00 +02:00
José Valim
acaeaf308a
Add a fixture replacement hook to TestUnit model generator.
2009-06-27 21:29:59 +02:00
José Valim
8c5622f0d4
Initial scratch of model generators.
2009-06-27 21:29:59 +02:00
José Valim
9acb721e6a
Do not generate aliases automatically to avoid conflicts.
2009-06-27 21:29:59 +02:00
José Valim
ff48e23a4e
Make Observer generator agnostic.
2009-06-27 21:29:59 +02:00
José Valim
85ff67ce4c
Merge branch 'master' of git://github.com/rails/rails
2009-06-27 21:27:21 +02:00
Chris Mear
085db5e128
Make text_area_tag escape contents by default.
...
Signed-off-by: Michael Koziarski <michael@koziarski.com >
[#2015 state:committed]
2009-06-27 13:16:52 +12:00
Vicente Mundim
68b02cb00a
Make filter_parameters work correctly with array parameters.
2009-06-27 12:43:57 +12:00
Yehuda Katz + Carl Lerche
188a892c5a
Starting to replace scattered path configuration settings with the path object
2009-06-26 17:32:05 -07:00
Yehuda Katz + Carl Lerche
4153c6b720
Finished a first stab at the Rails application path object.
2009-06-26 15:37:52 -07:00
Yehuda Katz + Carl Lerche
b0774281ef
Update paths to support an explicit root and multiple paths per category
2009-06-26 15:37:52 -07:00
Yehuda Katz + Carl Lerche
728e3b4047
Simple initial Paths impl
2009-06-26 15:37:52 -07:00
Yehuda Katz + Carl Lerche
2865421f5d
Checkpoint. Added a bunch of TODOs and some changes after further going through the initializer
2009-06-26 15:37:52 -07:00
José Valim
e375819b76
Spec --no and --skip.
2009-06-26 20:42:00 +02:00
José Valim
95a5cc6167
Add invoke_iff and invoke_for to the public interface.
2009-06-26 20:26:10 +02:00
José Valim
54208cbe60
Added invoke_if and make use of it on controller generators.
2009-06-26 20:24:52 +02:00
José Valim
e981aeb576
invoke_for now uses Rails built-in lookup.
2009-06-26 19:30:18 +02:00
José Valim
5ef1d9706b
Added Rails::Generators.find_by_namespace.
2009-06-26 19:14:55 +02:00
José Valim
3a0619f1bb
Update some USAGE files.
2009-06-26 18:54:58 +02:00
José Valim
2d48f80a6b
Use type :default for invoke_for, this allows --no-test-framework and --skip-test-framework to be given.
2009-06-26 12:33:21 +02:00
José Valim
e2346244a2
Added Controller Generators.
2009-06-26 11:59:14 +02:00
José Valim
d40bd85119
Small fixes.
2009-06-26 11:59:14 +02:00
José Valim
2f3681dfc2
Clean up class collisions check and a class method helper.
2009-06-26 11:59:14 +02:00
José Valim
6bd101188e
Class collision checks.
2009-06-26 11:59:14 +02:00
José Valim
e084313640
Added HelperGenerator.
2009-06-26 11:59:13 +02:00
José Valim
da1baeab4a
Added integration and performance test generators.
2009-06-26 11:59:13 +02:00
José Valim
0f1c325f3c
Improving generators runner.
2009-06-26 11:59:13 +02:00
José Valim
915f108d6a
Merge branch 'master' of git://github.com/rails/rails
2009-06-26 11:58:02 +02:00
Michael Koziarski
b5dfdc714f
Make sure the wrapped exceptions also have the original exception available.
...
[#2419 state:committed]
2009-06-26 17:01:21 +12:00
Michael Schuerig
00a5fd3d18
Translate foreign key violations to ActiveRecord::InvalidForeignKey exceptions.
...
Signed-off-by: Michael Koziarski <michael@koziarski.com >
2009-06-26 16:52:55 +12:00
Michael Schuerig
53a3eaa860
Translate adapter errors that indicate a violated uniqueness constraint to ActiveRecord::RecordNotUnique exception derived from ActiveReecord::StatementInvalid.
...
Signed-off-by: Michael Koziarski <michael@koziarski.com >
2009-06-26 16:52:54 +12:00
Christos Zisopoulos
18a97a6601
Handle missing javascript/stylesheets assets by raising an exception
...
An exception will be raised if a local javascript/stylesheet file included
by the stylesheet_link_tag or javascript_include_tag can not be found.
When caching is enabled, we use atomic_write to ensure that the cache file
is not created with zero length.
Signed-off-by: Michael Koziarski <michael@koziarski.com >
[#2738 state:committed]
2009-06-26 16:47:15 +12:00
Yehuda Katz + Carl Lerche
8ee60660ce
Try speeding up rails booting
2009-06-25 14:32:15 -07:00
Yehuda Katz + Carl Lerche
c117e8e848
Run the block passed to #run first when initializing
2009-06-25 14:32:15 -07:00
Joshua Peek
b598baf813
ignore absolute tmp directory
2009-06-25 14:52:58 -05:00
Joshua Peek
7837da41a3
send_data should set Content-Length as a string
2009-06-25 14:47:15 -05:00
Joshua Peek
7aa730440c
Remove deprecated implicit ivar assignment
2009-06-25 12:51:21 -05:00
Pratik Naik
97159fad6a
Missed file from the previous commit 92b229e125
2009-06-25 17:03:07 +01:00
Pratik Naik
92b229e125
Make performance tests work again
2009-06-25 17:02:04 +01:00
José Valim
aee63a12f2
More tests for mailer.
2009-06-25 16:27:44 +02:00
José Valim
534f7b54e3
Mailer tests.
2009-06-25 16:21:33 +02:00
José Valim
0bb95968db
More code refactoring.
2009-06-25 15:45:15 +02:00
José Valim
d5bdf31d89
Refactoring out descriptions.
2009-06-25 13:46:19 +02:00
José Valim
6e6c0117b3
Added Mailer generaator template engine and test framework agnostic.
2009-06-25 12:57:58 +02:00
José Valim
ed33c29a4e
Added class collision checks.
2009-06-25 11:56:18 +02:00
José Valim
4573fd2e06
Added observer generator.
2009-06-25 11:24:35 +02:00
José Valim
eaef1ee09c
Make tests pass again after merge.
2009-06-25 10:44:46 +02:00
José Valim
5337766fa0
Tests for metal generator.
2009-06-25 10:39:44 +02:00
José Valim
f596495556
Tests for plugin generator.
2009-06-25 10:39:44 +02:00
José Valim
a748bb7961
Get base_name from class_name.
2009-06-25 10:39:43 +02:00
José Valim
0ed602b3ef
Removed TODOs.
2009-06-25 10:39:43 +02:00
José Valim
ccd26575d1
Clean up plugin generator.
2009-06-25 10:39:43 +02:00
José Valim
b72d966707
Merge branch 'master' of git://github.com/rails/rails
2009-06-25 10:38:17 +02:00
Emilio Tagua
50f73bd39c
Merge commit 'rails/master'
2009-06-24 16:30:27 -03:00
Yehuda Katz + Carl Lerche
3aad4d7fbe
Separate Rails module methods, the config object, and the initializer into separate files.
2009-06-23 16:10:43 -07:00
Emilio Tagua
0002fd4ab6
Updated Arel submodule.
2009-06-23 19:47:55 -03:00
Emilio Tagua
3b27a4856f
Refactoring: Calculations now use construct_finder_sql instead they own method.
2009-06-23 19:40:57 -03:00
Yehuda Katz + Carl Lerche
ce9d9fda77
Resurrect threadsafe!
2009-06-23 14:49:04 -07:00
Yehuda Katz + Carl Lerche
042bd0a5c8
Tests pass, AWDoR passes, and a fresh app boots.
2009-06-23 14:49:04 -07:00
Yehuda Katz + Carl Lerche
9d398f4827
Got all the railties tests to pass, rails must boot!
2009-06-23 14:49:04 -07:00
Yehuda Katz + Carl Lerche
30baaac546
Fix the default frameworks
2009-06-23 14:49:04 -07:00
Yehuda Katz + Carl Lerche
9cfd1d4491
Get more tests to pass
2009-06-23 14:49:04 -07:00
Yehuda Katz + Carl Lerche
f2aea4d3ea
Get initializer_test.rb to pass with the new initializer.
2009-06-23 14:49:03 -07:00
Yehuda Katz + Carl Lerche
a3309e4d70
Started making progress on implementing a new initializer.
...
Class.any_instance.expects(:require).raises(LoadError)
... w0t
2009-06-23 14:49:03 -07:00
Yehuda Katz + Carl Lerche
99b8248f6e
Initial initializer impl
2009-06-23 14:49:03 -07:00
Yehuda Katz + Carl Lerche
805369c8c8
Starting to write the new initializer
2009-06-23 14:49:03 -07:00
Yehuda Katz + Carl Lerche
1b844e4bf4
Passes in 1.9
2009-06-23 14:45:27 -07:00
Emilio Tagua
b9088dce07
Merge commit 'rails/master'
2009-06-23 18:13:46 -03:00
Yehuda Katz
4417a19b03
Small changes to get 1.9 passing (for the most part)
2009-06-23 14:06:22 -07:00
Emilio Tagua
4864f92ee3
Removed unused methods.
2009-06-23 17:57:31 -03:00
Emilio Tagua
02a723f7b5
Arel now buils SQL queries for associations. Removed old code and
...
updated Arel version to support this.
2009-06-23 17:38:31 -03:00
Emilio Tagua
bc899fd3a3
Arel updated. All tests passing for SQLite3 and PostgreSQL.
2009-06-23 17:20:42 -03:00
Emilio Tagua
d587cf3794
Removed old commented code
2009-06-23 17:19:51 -03:00
José Valim
8843b91da7
Delete uneeded USAGE file.
2009-06-23 20:45:27 +02:00
José Valim
ea106cf051
Added plugin generators (and a couple of TODOs).
2009-06-23 20:42:29 +02:00
José Valim
d7bab3a43a
Splitting base into several files.
2009-06-23 19:45:50 +02:00
José Valim
a7ba4b95e9
TestUnit, you have a home.
2009-06-23 19:27:46 +02:00
José Valim
4494a752c3
Change current sstructure.
2009-06-23 19:10:42 +02:00
José Valim
75fbd73936
Add GeneratedAttribute.
2009-06-23 18:12:37 +02:00
José Valim
d4ec091580
Removing template runner old specs.
2009-06-23 16:58:43 +02:00
José Valim
83f7fe2028
NamedBase.
2009-06-23 16:53:48 +02:00
José Valim
301c48c15c
Added a generator file responsable for loading generator files.
2009-06-23 16:53:47 +02:00
José Valim
1845675822
Added metal generator.
2009-06-23 16:53:47 +02:00
José Valim
f03890e151
Use Rails generators files organization.
2009-06-23 16:53:47 +02:00
José Valim
04eb5b6e34
Use Rails default banner.
2009-06-23 16:53:47 +02:00
José Valim
0744900861
Merge branch 'master' of git://github.com/rails/rails
2009-06-23 16:52:39 +02:00
Yehuda Katz + Carl Lerche
80f1f863cd
Revert "Generate proper :counter_sql from :finder_sql when there is a newline character immediately following 'SELECT' [ #2118 state:resolved]"
...
This reverts commit 4851ca9e13 .
The tests do not pass for postgresql.
2009-06-22 12:04:02 -07:00
Ryan Bigg
f73ee375a6
Added example of using shorthand in create_table.
2009-06-22 15:03:03 +10:00
Patrick Joyce
4851ca9e13
Generate proper :counter_sql from :finder_sql when there is a newline character immediately following 'SELECT' [ #2118 state:resolved]
...
Signed-off-by: Pratik Naik <pratiknaik@gmail.com >
2009-06-21 22:07:23 +01:00
Joseph Wilk
eb30e4ca40
Fixed a bug where create_table could not be called without a block [ #2221 state:resolved]
...
Signed-off-by: Pratik Naik <pratiknaik@gmail.com >
2009-06-21 19:51:32 +01:00
Brian Hogan
b26c2c11ab
Ensure table names are quoted while renaming for sqlite3 adapter [ #2272 state:resolved]
...
Signed-off-by: Pratik Naik <pratiknaik@gmail.com >
2009-06-21 18:24:19 +01:00
Xavier Noria
3009fcffa5
guides -> Guides in title of home page
2009-06-21 18:58:31 +02:00
=?utf-8?q?Mislav=20Marohni=C4=87?=
21cd4c0e93
Fix polymorphic_path doesn't modify options hash [ #2099 state:resolved]
...
Signed-off-by: Pratik Naik <pratiknaik@gmail.com >
2009-06-21 17:53:07 +01:00
mattbauer
83c1934003
Ensure hm:t#create respects source associations hash conditions [ #2090 state:resolved]
...
Signed-off-by: Pratik Naik <pratiknaik@gmail.com >
2009-06-21 17:35:04 +01:00
Darragh Curran
9cb8c812f2
Add content_for?(:name) helper to check if content_for(:name) is present [ #1311 state:resolved]
...
Signed-off-by: Pratik Naik <pratiknaik@gmail.com >
2009-06-21 17:07:22 +01:00
Pratik Naik
66eb05821b
Use stubbing instead of sleep() in File store cache tests
2009-06-21 15:25:28 +01:00
Pratik Naik
b5775c2b3e
Add expiry support File cache store [ #1693 state:resolved] [Roman Shterenzon, Pratik Naik]
2009-06-21 15:25:28 +01:00
José Valim
6dd196914c
Remove class level conditions and ensure that RAILS_GEM_VERSION is commented when freeze.
2009-06-20 22:04:34 +02:00
José Valim
2c3ebc00b7
More tests to app generator.
2009-06-20 16:58:15 +02:00
José Valim
181feecfb9
First stub at app generators test.
2009-06-20 15:43:25 +02:00
Justin Brown
6fba6c6d81
Testing Guide: fix some grammar errors and typos
2009-06-19 12:28:28 -05:00
José Valim
68739eed57
Skip Rails::VERSION warnings.
2009-06-19 16:19:15 +02:00
José Valim
631deb5992
Removing duplicated files.
2009-06-19 16:14:49 +02:00
José Valim
5b8fe9c4c7
Moving tests to new generators schema.
2009-06-19 16:11:55 +02:00
José Valim
9dd1e2f2b0
Starting test structure.
2009-06-19 16:11:55 +02:00
José Valim
bd216924a3
No more application generator.
2009-06-19 16:11:55 +02:00
José Valim
6658711775
Template wwas not found? Raise an error.
2009-06-19 16:11:55 +02:00
José Valim
98adc9a42e
Secret key generator. You are gone.
2009-06-19 16:11:55 +02:00
José Valim
94a83007b6
Kick boot_test back to life.
2009-06-19 16:11:54 +02:00
José Valim
7a8e284766
Refactor shebang to a class method, so other generators can use it.
2009-06-19 16:11:54 +02:00
José Valim
748e1d6745
Require open-uri, we will need it.
2009-06-19 16:11:54 +02:00
José Valim
cd05ed6711
Do not show status when calling gsub_file or append_file.
2009-06-19 16:11:54 +02:00
José Valim
e0a4d8be93
Fix shebang on created files.
2009-06-19 16:11:54 +02:00
José Valim
6f044c9b6c
Change --freeze alias from -f to -F to avoid conflict with --force.
2009-06-19 16:11:54 +02:00
José Valim
768d763436
Apply template when required.
2009-06-19 16:11:54 +02:00
José Valim
9b82fa159a
Freeze rails when required.
2009-06-19 16:11:54 +02:00
José Valim
b9d8fafd7e
Update templates to be backwards compatible.
2009-06-19 16:11:54 +02:00
José Valim
090de591fc
Raise an error if invalid value for database is provided.
2009-06-19 16:11:54 +02:00
José Valim
6619357f75
When rails is invoked without args, be sure that help is called.
2009-06-19 16:11:54 +02:00
José Valim
01cde13290
Updated namespace so help can show usage properly.
2009-06-19 16:11:54 +02:00
José Valim
30fff3077d
Updated dependency, so we can remove extra code.
2009-06-19 16:11:54 +02:00
José Valim
5ff80e7433
bin/rails uses the new generator.
2009-06-19 16:11:53 +02:00
José Valim
b6f826376a
Added a couple more options to app generator.
2009-06-19 16:11:53 +02:00
José Valim
615527dcb0
Allow user to skip ActiveRecord, TestUnit and/or Prototype. However any customization should be done with templates.
2009-06-19 16:11:53 +02:00
José Valim
fef38fd542
Small alias typo.
2009-06-19 16:11:53 +02:00
José Valim
a8b3efbe5c
Moved prototypes files to where they should be.
2009-06-19 16:11:53 +02:00
José Valim
4bf8f40638
Added usage to app generator.
2009-06-19 16:11:53 +02:00
José Valim
34ed2d8d5e
Send new files too.
2009-06-19 16:11:51 +02:00
José Valim
d57b19380e
Add base and port actions. Not functional though.
2009-06-19 16:10:43 +02:00
José Valim
ceede90017
Move prototype files to javascripts folder.
2009-06-19 16:10:42 +02:00
José Valim
720aceeea9
Send new files too.
2009-06-19 16:10:42 +02:00
José Valim
ced68c7430
App generator is working using new generators (except for templates).
2009-06-19 16:10:42 +02:00
José Valim
42e51ea9c0
More tasks into app generator.
2009-06-19 16:10:42 +02:00
José Valim
489f422152
Initial scratch of application generator.
2009-06-19 16:10:42 +02:00
José Valim
8037fee9ff
Merge branch 'master' of git://github.com/rails/rails
2009-06-19 16:10:24 +02:00
Joel Chippindale
f9c6dcbf7c
Add documentation for qualifying table names in conditions hashes
2009-06-19 07:32:39 +01:00
Jeremy Kemper
54f4851770
Turn on autolist for debugging also
2009-06-18 21:55:13 -04:00
Jeremy Kemper
63cc6b7242
Friendlier runtime exception if delegatee is nil
2009-06-18 20:00:35 -04:00
Jeremy Kemper
50fe928c15
Delegated methods report the expected file/line in backtraces
2009-06-18 18:07:55 -04:00
Yehuda Katz + Carl Lerche
9f7eaea201
Minor ActionView cleanup
2009-06-18 12:08:50 -07:00
Yehuda Katz + Carl Lerche
497554fd10
Fix typo
2009-06-18 11:14:44 -07:00
Jeremy Kemper
5267addd4f
Use errors[field] instead of errors.on(field)
2009-06-17 19:37:56 -07:00
Joshua Peek
fbdf706fff
Add basic JSON serializer to AMo
2009-06-17 21:27:54 -05:00
Joshua Peek
af5301089f
Add simple attribute implementation backed by ivars
2009-06-17 21:27:54 -05:00
Joshua Peek
d5d59230f4
Simplify AMo validation attribute reader
2009-06-17 21:27:54 -05:00
Yehuda Katz + Carl Lerche
b4a91db441
Extract the layout proc into a method, and write documentation explaining what the proc does in various cases.
2009-06-17 18:55:10 -07:00
Yehuda Katz + Carl Lerche
ca8f8fb031
Remove one more note about deprecated behavior
2009-06-17 18:15:41 -07:00
Yehuda Katz + Carl Lerche
a9ad763c86
Drive the final stake through @content_for_*'s heart!
2009-06-17 18:08:45 -07:00
Mike Gunderloy
d2dfd340e3
rdoc spelling fix
2009-06-17 20:01:09 -05:00
Yehuda Katz + Carl Lerche
65102c8f1a
Cleaning up more tests and code that needed to work in both old and new base
2009-06-17 16:51:51 -07:00
Yehuda Katz + Carl Lerche
55ee0ba7f5
Cleaning up if defined?(ActionController::Http) blocks from the pre new base era.
2009-06-17 16:23:11 -07:00
Yehuda Katz + Carl Lerche
8fdf3d7890
Remove some defined?(Http) checks
2009-06-17 16:14:05 -07:00
Yehuda Katz + Carl Lerche
251a6e492c
Rename path.rb to resolver.rb
2009-06-17 15:39:41 -07:00
Yehuda Katz + Carl Lerche
d8f352e970
Rename ActionView::Template::Path ActionView::Resolver
2009-06-17 15:32:55 -07:00
Yehuda Katz + Carl Lerche
7ac9f29093
Updated require for AMo move
2009-06-17 13:05:14 -07:00
Yehuda Katz + Carl Lerche
6927f1119b
Finish making pending tests pass
2009-06-17 12:54:19 -07:00
Yehuda Katz + Carl Lerche
487312515c
RJS doesn't render with an HTML layout by default
2009-06-17 12:54:19 -07:00
Yehuda Katz + Carl Lerche
4fad953f90
Fixing pending tests and fixed some formats / partial rendering semantics
2009-06-17 12:54:19 -07:00
Yehuda Katz + Carl Lerche
de388ba864
Fix pending test about content-type
2009-06-17 12:54:18 -07:00
Emilio Tagua
3e4452c73f
Forget about auto scope, it's always explicit.
2009-06-17 15:10:57 -03:00
Joshua Peek
1c4d28ba31
Move model naming into ActiveModel
2009-06-17 10:37:39 -05:00
José Valim
908b5305d4
Convert line breaks.
2009-06-17 11:26:32 +02:00
Yehuda Katz + Carl Lerche
85f2f34d5e
Remove a stray process2 require
2009-06-16 16:29:33 -07:00
Yehuda Katz + Carl Lerche
315147fcb5
Move the exceptions for missing template into Compatibility in prep for moving it into a "not-production" module
2009-06-16 13:54:55 -07:00
Yehuda Katz + Carl Lerche
dd58f4021d
An exception is raised if a layout is missing only if the layout is missing for all mimes
2009-06-16 13:44:51 -07:00
Emilio Tagua
16ac353f4c
Merge commit 'rails/master'
2009-06-16 16:59:12 -03:00
Yehuda Katz + Carl Lerche
01a4bc84b8
Exceptions now in an exceptions module
2009-06-16 11:32:38 -07:00
Yehuda Katz + Carl Lerche
a6e803bee1
Remove exceptions from AbstractUnit so they work in real life
2009-06-16 11:20:28 -07:00
Yehuda Katz + Carl Lerche
18c3b77b23
Merge process2 into process to people's regular tests run :P
2009-06-16 10:46:03 -07:00
Yehuda Katz + Carl Lerche
1fbfa3e705
More _write_layout_method removal
2009-06-15 17:33:25 -07:00
Yehuda Katz + Carl Lerche
3c15cba175
Whoops, I guess we broke layouts ;)
2009-06-15 17:32:10 -07:00
Yehuda Katz + Carl Lerche
19c3495a67
rm -r controller/base!
2009-06-15 16:29:45 -07:00
Yehuda Katz + Carl Lerche
7b1f483fda
Get all of rake tests to pass
2009-06-15 16:14:45 -07:00
Yehuda Katz + Carl Lerche
c7ba9aa195
Get the new base tests to pass
2009-06-15 15:56:18 -07:00
Yehuda Katz + Carl Lerche
0e558f0bbd
Get the AR integration tests to pass
2009-06-15 15:55:09 -07:00
Yehuda Katz + Carl Lerche
5314abed18
Keep ActionMailer using the old layouts code until it gets refactored.
2009-06-15 11:59:28 -07:00
Yehuda Katz + Carl Lerche
80d1e27788
Fix the fixture path
2009-06-15 11:50:11 -07:00
Yehuda Katz + Carl Lerche
a63caa4c0c
Get tests to run (with failures) without old base around
2009-06-15 11:44:45 -07:00
Yehuda Katz + Carl Lerche
614374b3e5
Require missing file in AS
2009-06-15 11:31:52 -07:00
Yehuda Katz + Carl Lerche
64ae5b56ff
Fix failing tests in new callbacks
2009-06-15 11:26:47 -07:00
Yehuda Katz + Carl Lerche
5a8a550a45
Finish making things pass with updated internal content_type semantics
2009-06-15 11:21:08 -07:00
Joshua Peek
c50b03b754
Add :concat option to asset tag helpers to force concatenation.
...
This is useful for working around IE's stylesheet limit.
stylesheet_link_tag :all, :concat => true
2009-06-15 10:23:23 -05:00
Xavier Noria
b56169c262
moves reopening of core classes to add generic stuff from Action Pack to AS/core_ext and adds tests
...
[#2798 state:committed]
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2009-06-13 15:01:14 -07:00
Luca Guidi
9eeb5fed2f
Bytes calculation speed up
...
[#2800 state:committed]
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2009-06-13 14:03:45 -07:00
Xavier Noria
bdf9c97c8c
AS guide: renames a variable
2009-06-13 15:41:47 +02:00
Xavier Noria
74e87308ed
AS guide: typo
2009-06-13 15:40:21 +02:00
Xavier Noria
8ac17e6d9b
AS guide: explains to_query
2009-06-13 15:37:59 +02:00
Xavier Noria
c62f1f0754
AS guide: 2nd revision of the explanation of to_param
2009-06-13 15:00:21 +02:00
Xavier Noria
c35d55c918
AS guide: explains to_param
2009-06-13 10:11:47 +02:00
Xavier Noria
0c70bf373c
AS guide: adds another example to Object#metaclass
2009-06-13 09:15:21 +02:00
Xavier Noria
d32965399c
uses Object#metaclass and Object#class_eval in a few spots
...
[#2797 state:committed]
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2009-06-12 16:14:06 -07:00
Xavier Noria
fe0cf9213c
AS guide: explains acts_like?
2009-06-13 01:10:22 +02:00
Xavier Noria
e20e0c8c42
AS guides: explains Object#metaclass and Object#class_eval
2009-06-13 01:10:22 +02:00
Xavier Noria
b9ac9474db
AS guide: rewords a sentence
2009-06-13 01:10:22 +02:00
Emilio Tagua
34a068d053
Leave the quoting part to ARel
2009-06-12 18:09:48 -03:00
Adam Milligan
54a5446641
HasOneThroughAssociation still shouldn't derive from HasManyThroughAssociation.
...
[#1642 state:committed]
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2009-06-12 13:52:51 -07:00
Emilio Tagua
8db190acba
HasOneAssociation inherits AssociationProxy since it shares nothing with BelongsToAssociation.
...
[#2796 state:committed]
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2009-06-12 13:45:25 -07:00
Emilio Tagua
a924b2f66e
Merge commit 'rails/master'
2009-06-12 16:20:27 -03:00
Joshua Peek
8f7c657f4b
Move observing notify helper into AMo
2009-06-11 13:41:48 -05:00
Joshua Peek
c4e440b1d2
Fix observing AS dependencies
2009-06-11 13:21:56 -05:00
Joshua Peek
4d70359200
Integrate ActiveModel::Observing into ActiveRecord
2009-06-10 23:36:44 -05:00
Andrew Kaspick
59c83af18b
allow absolute paths for the asset caches
...
Signed-off-by: Michael Koziarski <michael@koziarski.com >
2009-06-11 16:33:32 +12:00
Emilio Tagua
247ac95413
Merge commit 'rails/master'
2009-06-10 19:54:27 -03:00
Emilio Tagua
d7b98b3ca8
Arel updated
2009-06-10 19:54:08 -03:00
Emilio Tagua
d127831d9e
Merge branch 'update_all'
2009-06-10 19:46:47 -03:00
Emilio Tagua
af9f9dd02c
Use array of orders instead of string concatenation
2009-06-10 19:46:35 -03:00
Emilio Tagua
71528c2921
Initial update_all migration
2009-06-10 19:36:45 -03:00
Yehuda Katz + Carl Lerche
47ff57f6d1
Document and clean up HideActions and Http
2009-06-10 15:27:53 -07:00
Yehuda Katz + Carl Lerche
82a10ce9f6
Removed unnecessary code
2009-06-10 14:43:43 -07:00
Yehuda Katz + Carl Lerche
fbb6b936e9
Document ActionController::Helpers
2009-06-10 14:28:58 -07:00
Yehuda Katz + Carl Lerche
316fab7de6
Cleaned up the #default_helper_module method to make better use of #helper instead of duplicating code.
2009-06-10 14:15:21 -07:00
Emilio Tagua
0587462050
Revert "Use ARel in SQL generation through associations"
...
This reverts commit 7be3e3ba05 .
2009-06-10 17:32:20 -03:00
Emilio Tagua
7be3e3ba05
Use ARel in SQL generation through associations
2009-06-10 17:31:26 -03:00
Emilio Tagua
8c3b8323f5
Use ARel in SQL generation through associations
2009-06-10 16:36:05 -03:00
Yehuda Katz + Carl Lerche
37be453a87
Adding "test" to the lib directory when running action pack tests on new base
2009-06-10 12:26:03 -07:00
Yehuda Katz + Carl Lerche
4fc0778123
Simplify helper use of ActiveSupport::Dependencies, and use super better for in #helpers
2009-06-10 12:15:30 -07:00
Michael Koziarski
c014c3e5c1
Whitelist the methods which are called by multiparameter attribute assignment.
...
This prevents users from causing NoMethodErrors and the like by editing the parameter names, and closes a potential exploit of CVE-2009-1904.
2009-06-10 12:12:21 +12:00
Yehuda Katz + Carl Lerche
b6fde6b480
Clean up AbstractController::Logger and write documentation
2009-06-09 17:03:02 -07:00
Yehuda Katz + Carl Lerche
f35f47b8c0
Cleaning up and documenting AbstractController::Layouts
2009-06-09 16:47:40 -07:00
Yehuda Katz + Carl Lerche
acb2447785
Write documentation for AbstractController::Helpers
2009-06-09 16:47:39 -07:00
Matt Jones
d7e0cb05cc
Fix incorrect specification path in GemDependency#from_directory_name
...
Signed-off-by: Michael Koziarski <michael@koziarski.com >
2009-06-10 09:57:58 +12:00
Brian Lopez
69bc2043f9
enable *real* IO parsing for the libxml, nokogiri and rexml backends [ #2659 state:resolved]
...
Signed-off-by: Joshua Peek <josh@joshpeek.com >
2009-06-09 09:01:50 -05:00
Emilio Tagua
103b282130
Merge commit 'rails/master'
2009-06-09 10:29:55 -03:00
Stephen Anderson
a94e7d7897
Sanitized the id generated by text_area_tag helper method. text_area_tag('item[description]') should return: <textarea id="item_description" name="item[description]"></textarea> instead of: <textarea id="item[description]" name="item[description]"></textarea> The old id was causing HTML validation failures.
...
Signed-off-by: Michael Koziarski <michael@koziarski.com >
2009-06-09 20:36:45 +12:00
David Stevenson
a14df8c9b2
Made label target radio button tags with values. Radio button now respects inherited :index options when generating id.
...
Signed-off-by: Michael Koziarski <michael@koziarski.com >
2009-06-09 20:28:43 +12:00
Raimonds Simanovskis
63091cef2e
disabled base_test.rb tests that were not Oracle compatible (TIME datatype is not supported on Oracle, UPDATE does not support ORDER BY) _before_type_cast on Oracle returns Time and not String added Oracle specific schema definition that was missing for test_default_values test
...
Signed-off-by: Michael Koziarski <michael@koziarski.com >
2009-06-09 20:26:55 +12:00
Friedrich Göpel
1d57ccbc6f
1.9 compatibility - don't pass an array as the from address as this ends up generating invalid SMTP commands.
2009-06-09 20:22:20 +12:00
Eugene Pimenov
74c1249d07
PostgreSQL adapter should call thread safe quote_string function
...
Signed-off-by: Michael Koziarski <michael@koziarski.com >
2009-06-09 20:12:01 +12:00
Michael Koziarski
99803b7cdb
Pull autoload fix from 2-3-stable
2009-06-09 20:10:21 +12:00
Matt Jones
41a94048e5
Fix several issues with the 2.3.2 gem loader.
...
Incorporates the following:
- migrates back small change to gems:build:force from bfc1609a50 to finish closing #2266 .
- unrolls to_proc calls in gems.rake, to match the change in master.
- fixes #2722 by passing the options hash to dependencies during build. (includes a test)
- fixes #2721 by loading the specification directly in from_directory_name. Adds an option to opt-out of specification loading when needed (in gems:refresh_specs, for instance). Includes tests.
- fixes #2679 by refreshing specs for all frozen gems rather than just gems loaded from the environment.
- fixes #2678 by passing the options hash to dependencies during unpack.
Signed-off-by: Michael Koziarski <michael@koziarski.com >
2009-06-09 19:57:38 +12:00
nate
f68cc639f5
A test to show that http_authentication needs to fail authentication if the password procedure returns nil. Also includes a fix to validate_digest_response to fail validation if the password procedure returns nil.
...
Signed-off-by: Michael Koziarski <michael@koziarski.com >
2009-06-09 19:47:53 +12:00
Yehuda Katz
114e25e735
Further cleanup of callbacks
2009-06-09 19:47:53 +12:00
Yehuda Katz
8cae3cd0cf
More pruning of NewCallbacks
2009-06-09 19:47:53 +12:00
Jeremy Kemper
e9a6255938
Lazier Rakefile requires to avoid needing full rake gem on 1.9
2009-06-08 20:49:21 -07:00
Jeremy Kemper
23f3b567e2
Uses Hash#symbolize_keys
2009-06-08 19:37:52 -07:00
Jeremy Kemper
5b256ac369
Prefer JSON.encode(value) to value.to_json
2009-06-08 19:37:52 -07:00
Jeremy Kemper
14de1a9597
each yields per message not per attribute
2009-06-08 19:37:51 -07:00
Jeremy Kemper
e1f679a020
Simplify json decoder backend lazy load
2009-06-08 19:37:51 -07:00
Jeremy Kemper
6e73cf6bdf
Fix AR json encoding
2009-06-08 19:37:51 -07:00
Jeremy Kemper
99cf77be27
Add #element and #collection to ModelName
2009-06-08 19:37:50 -07:00
Jeremy Kemper
d9f16fafec
Update for Active Model yielding per error not per attribute
2009-06-08 19:37:50 -07:00
Joshua Peek
27766ccf3b
Make use of AS::Concern in ActiveResource
2009-06-08 20:52:27 -05:00
Joshua Peek
0b694a4ff4
Setup ActiveResource autoloads
2009-06-08 20:48:14 -05:00
Joshua Peek
28f36279cd
Properly require ActiveModel validation dependencies
2009-06-08 20:32:08 -05:00
Joshua Peek
01515f8ecd
Fix activesupport path
2009-06-08 19:59:56 -05:00
Yehuda Katz + Carl Lerche
be371993b7
More documentation work on AbstractController
...
This is still not completely done and there might be pointers to things that don't exist yet.
2009-06-08 17:41:08 -07:00
Yehuda Katz + Carl Lerche
38b608ecab
Writing comments to AbstractController
2009-06-08 16:15:14 -07:00
Yehuda Katz + Carl Lerche
a470bb3612
Remove extraneous response_obj
2009-06-08 16:15:13 -07:00
Jeremy Kemper
30a3b6b4fc
Ruby 1.9: fix json encoding
2009-06-08 15:16:47 -07:00
Jeremy Kemper
d3078b540e
Explicitly qualify constants in BasicObjects
2009-06-08 15:07:52 -07:00
Yehuda Katz + Carl Lerche
c1fcabb350
Remove duplicate
2009-06-08 14:26:22 -07:00
Jeremy Kemper
a6bf6f275c
Use as_json instead of rails_to_json
2009-06-08 14:08:04 -07:00
Yehuda Katz + Carl Lerche
86fc43fd58
ActionPack components should no longer have undeclared dependencies.
...
* Tests can be run in isolation
* Dependencies added
* A few tests modified to avoid depending on AS deps
not depended on my files they were testing
2009-06-08 13:34:07 -07:00
Jeremy Kemper
00ee990443
JSON: split encoding and coercion
2009-06-08 13:21:30 -07:00
Lloyd Pick
d11a86069c
Cleaned up Apache .htaccess section of main README
2009-06-08 12:35:57 +01:00
Lloyd Pick
c6ce600bc5
Minor spelling/grammer changes in associations
2009-06-08 12:17:37 +01:00
Jeremy Kemper
5e1b46d4c2
Don't rely on Rails.logger
2009-06-08 01:40:14 -07:00
Geoff Buesing
7fe8b630ce
Add notes to TZInfo bundling task
2009-06-07 22:09:21 -05:00
Geoff Buesing
71b1a4b39d
Kathmandu TimeZone: reference Asia/Kathmandu zone directly instead of through linked timezone
2009-06-07 21:43:44 -05:00
Geoff Buesing
184986067a
Load correct version of TZInfo
2009-06-07 21:36:09 -05:00
Jason Frey (Fryguy)
1d9346428b
String #to_time and #to_datetime: handle fractional seconds [ #864 state:resolved]
2009-06-07 20:16:08 -05:00
Geoff Buesing
04eb2b72b4
Update bundled TZInfo to v0.3.13
2009-06-07 20:00:25 -05:00
Xavier Noria
ee9382e597
AS guide: explains blank? and present?
2009-06-07 01:19:12 +02:00
Tim Connor
6a3f8ae407
Work around a gem dependency edge case that prevents Rails from booting..
...
If you have a frozen gem with unfrozen dependencies (for instance if the
dependency has native extensions so can't be frozen) you can have a
nightmare upgrade problem, where you cannot rake gems:install, because
rake is broken by a gem loading problem.
If you bump up your frozen gem to a newer version that requires a newer
dependency, everybody else on the team will have rake broken by that
dependency mismatch, since you will have had to specify the dependency
in your config.gems, otherwise nobody will have installed it, since the
parent is frozen. And now the config.gems loading code will kill rake.
[#2609 state:committed]
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2009-06-05 21:54:56 -07:00
Jeremy Kemper
ccf70b9570
Pull in time extensions also
2009-06-05 18:27:27 -07:00
Jeremy Kemper
a838ba392e
Prefer sibling action_controller
2009-06-05 18:27:27 -07:00
Mike Gunderloy
d82ad19d26
Some general cleanup to the rdoc for date_select
2009-06-05 08:30:41 -05:00
Mike Gunderloy
ceac720392
Correct typo on add_month_numbers option (From: Sam Pohlenz <sam@sampohlenz.com>)
2009-06-05 08:26:27 -05:00
Yehuda Katz
d6e4113c83
YAGNI Method references. Deprecated
2009-06-02 22:06:21 -07:00
Yehuda Katz
6b4da2ecac
Add explicit requirement in a few cases it was missing.
...
TODO: Come up with the minimal core and remove all of these
2009-06-02 21:43:54 -07:00
Yehuda Katz
1126a85aed
Further cleaning up new callbacks
2009-06-02 21:41:31 -07:00
Yehuda Katz
971e2438d9
Simplify callbacks to use less metaprogramming
2009-06-02 19:00:59 -07:00
Emilio Tagua
fd3c55f09f
Merge commit 'rails/master'
...
Conflicts:
activerecord/lib/active_record.rb
2009-06-02 12:36:36 -03:00
Emilio Tagua
5255a81b80
Updated Arel submodule
2009-06-02 12:33:51 -03:00
Emilio Tagua
2474fbb4d6
Set ActiveRecord as Arel engine on load.
2009-06-02 12:29:09 -03:00
Emilio Tagua
bbe51a1b9d
No need to specify the engine now that it is in active_record.rb
2009-06-02 12:27:26 -03:00
Emilio Tagua
522711952b
Refactors to work with latest Arel implementation.
2009-06-02 11:40:01 -03:00
Yehuda Katz + Carl Lerche
196f780e30
Get all the callback tests to work on new base
2009-06-01 15:40:40 -07:00
Xavier Noria
d6424f05c3
AS guide: explains array grouping
2009-06-02 00:13:00 +02:00
Jeremy Kemper
dcba6e1148
Fix initializer i18n path test
2009-06-01 13:44:43 -07:00
Jeremy Kemper
94911c7af7
Ensure ERB source begins with the encoding comment
2009-06-01 12:34:08 -07:00
Xavier Noria
c842dbf16d
simplifies a sentence
2009-06-01 21:12:44 +02:00
Joseph Pecoraro
c2917940f5
Fixed XHR typo and another Application => ApplicationController typo
2009-06-01 09:42:59 -04:00
Pratik Naik
67317b6104
Make ApplicationController extend from AC::Base
2009-06-01 09:41:46 +01:00
Pratik Naik
9d60525b5f
Merge commit 'mainstream/master'
2009-06-01 09:38:09 +01:00
Han Kessels
9537fd0e3a
fix for IE incompatibility of :disable_with in submit_tag
...
Signed-off-by: Michael Koziarski <michael@koziarski.com >
2009-06-01 14:03:52 +12:00
Giles Alexander
532219fd09
Schema dumper now records scale 0 decimal columns as decimal not integer.
...
The schema dumper would dump out any decimal or numeric column that had a zero
scale as an integer column. This will cause problems for very large precision
columns on some DBMSs, particularly PostgreSQL. It also looks strange to see
your column change type after moving through schema.rb.
Signed-off-by: Michael Koziarski <michael@koziarski.com >
[#2741 state:committed]
2009-06-01 13:40:05 +12:00
Jeff Dean
b3839f1c98
Updated the db:structure:dump task to properly format the pgdump command when you have multiple schemas in your schema search path.
...
Signed-off-by: Michael Koziarski <michael@koziarski.com >
[#2695 state:committed]
2009-06-01 12:12:45 +12:00
Vladimir Dobriakov
64756e8f71
better db:create for mysql - do not assume root user
...
Signed-off-by: Michael Koziarski <michael@koziarski.com >
[#1459 state:committed]
2009-06-01 12:09:19 +12:00
Xavier Noria
dc7323efd3
AS guide: explains extensions to Array for accessing elements
2009-06-01 00:19:05 +02:00
Xavier Noria
a66909c5c4
AS guide: adds see also to explanation of Class#remove_subclasses
2009-05-31 23:25:25 +02:00
Xavier Noria
680303107a
AS guide: small rewording
2009-05-31 23:25:25 +02:00
Murray Steele
a6584bba74
Merge branch 'master' of git@github.com:lifo/docrails
2009-05-31 22:14:58 +01:00
Murray Steele
b418f8c6a2
Documenting :inverse_of options for associations.
2009-05-31 22:14:02 +01:00
Xavier Noria
f60b732940
AS guide: explains class removal
2009-05-31 23:08:05 +02:00
Xavier Noria
c78e587e0b
use "Subclasses" in title for coherence with method name
2009-05-31 23:08:05 +02:00
Mike Enriquez
145f182ea1
Fix url and route helpers to follow the given example
2009-05-31 11:16:28 -04:00
Joseph Pecoraro
0351896f71
Fixed some typos and a more common grammar styles.
2009-05-31 10:17:12 -04:00
Joseph Pecoraro
e93e422532
Fixed typo.
2009-05-31 10:00:15 -04:00
Xavier Noria
d610295cf3
AS guide: explains Class#subclasses
2009-05-31 15:52:16 +02:00
Xavier Noria
370cdd2d80
just a typo
2009-05-31 01:18:34 +02:00
Xavier Noria
a5394c9313
explains superclass_delegating_accessor
2009-05-31 01:13:44 +02:00
Jeremy Kemper
f9bd10054c
Sidestep need for Kernel#silence_warnings
2009-05-30 11:59:17 -07:00
Jeremy Kemper
c79551f02b
Depend on Hash#slice and Object#try
2009-05-30 11:59:17 -07:00
Jeremy Kemper
85eb3af873
Tolerate missing logger
2009-05-30 11:59:17 -07:00
Jeremy Kemper
3962be5b8c
Use URI and Inflector
2009-05-30 11:59:17 -07:00
Jeremy Kemper
c53057d4fd
html-scanner uses Set and class_inheritable_accessor
2009-05-30 11:59:17 -07:00
Jeremy Kemper
249d9a6606
Depend on Hash#diff extension
2009-05-30 11:59:17 -07:00
Jeremy Kemper
5481e54175
AM::StateMachine autoloads
2009-05-30 11:59:16 -07:00
Joshua Peek
a1140a1031
Revert "Only save the session if we're actually writing to it [ #2703 state:resolved]"
...
This reverts commit dd98280e38 .
2009-05-30 09:36:08 -05:00
Luke Melia
54984f0f24
Avoid loading the ActiveRecord::SessionStore class on initialization if it is not in use [ #2737 state:resolved]
...
Signed-off-by: Joshua Peek <josh@joshpeek.com >
2009-05-30 09:35:25 -05:00
Joshua Peek
e7d6f48ea9
Use AS::Concern in ActiveModel
2009-05-30 09:35:24 -05:00
Pratik Naik
e767c65cc9
Make sure tests pass action name to Controller.action()
2009-05-30 15:18:46 +01:00
Pratik Naik
63992e8f3a
Support Object#filter method for before/after filters
2009-05-30 15:14:23 +01:00
Xavier Noria
4f90eb9f19
form helpers guide: revises a TIP on resources
2009-05-30 10:25:55 +02:00
Joseph Pecoraro
8e06b2ce25
Fixed some links pointing to guides.rails.info to relative links. Fixed hashs as well.
2009-05-30 01:16:03 -04:00
Joseph Pecoraro
3b6a40a7bd
Fixed links to the Routing Guide.
2009-05-30 01:01:36 -04:00
Joseph Pecoraro
ece603cdf9
Added TIP about resources when using the short form_for syntax.
2009-05-30 00:53:32 -04:00
Joseph Pecoraro
c9d7affd8c
Link titles are generally capitalized.
2009-05-30 00:49:25 -04:00
Joseph Pecoraro
dd888c9603
Removed the Javascript. It conflicts with the highlighting code.
2009-05-30 00:48:22 -04:00
Joseph Pecoraro
7749e1784c
Grammer: 'a' => 'an' where applicable.
2009-05-29 21:09:01 -04:00
Joseph Pecoraro
3aeec3209c
Clarification in an example. Grammar correction.
2009-05-29 20:48:46 -04:00
Joseph Pecoraro
bf1b1e976b
Semi-fix for Firefox code Copy and Paste
...
The underlieing problem is that Firefox ignores the css 'white-space:pre'
rule when actually copying and pasting. This Javascript turns newlines
into <br /> tags inside the code containers.
This will run in Safari, Opera, Chrome, Webkit, etc. gracefully.
This will not run in IE due to IE not having the methods needed.
A permanent solution would be at the Markdown level in such a way that
the highlighter still runs on the output with brake tags.
2009-05-29 18:35:55 -04:00
Joshua Peek
669fd84910
AS::Concern redefines "include" to lazy include modules as dependencies
2009-05-29 17:03:23 -05:00
Joshua Peek
c7c35be8fe
AS::Concern includes InstanceMethods module if it exists
2009-05-29 16:28:54 -05:00
Joshua Peek
69742ca8fa
Merge branch 'master' into active_model
...
Conflicts:
activemodel/lib/active_model/core.rb
activemodel/test/cases/state_machine/event_test.rb
activemodel/test/cases/state_machine/state_transition_test.rb
activerecord/lib/active_record/validations.rb
activerecord/test/cases/validations/i18n_validation_test.rb
activeresource/lib/active_resource.rb
activeresource/test/abstract_unit.rb
2009-05-29 16:06:21 -05:00
Joseph Pecoraro
f68fca2e76
Linked to the IRC channel.
2009-05-29 16:27:50 -04:00
Joseph Pecoraro
3014f0f4c5
Capitalized Rails where appropriate.
2009-05-29 16:26:50 -04:00
Joseph Pecoraro
796fef684b
Corrected path to standard.
2009-05-29 10:40:29 -04:00
Joseph Pecoraro
72b033f6b6
Corrected paths to standard.
2009-05-29 10:29:44 -04:00
Joseph Pecoraro
d2b8564ab2
Typo and Style Corrections
2009-05-29 09:53:33 -04:00
Jeremy Kemper
5ec2c7dc29
Ruby 1.9: ERB template encoding using a magic comment at the top of the file
2009-05-28 17:12:48 -05:00
Jeremy Kemper
e23554d79e
Ruby 1.9: flushing the output buffer preserves its encoding
2009-05-28 17:12:48 -05:00
Jeremy Kemper
d120f9de7e
Reinstate pending output buffer tests
2009-05-28 17:12:48 -05:00
Jeremy Kemper
cf3ccd7be0
Ruby 1.9: use UTF-8 for default internal and external encodings.
2009-05-28 17:12:48 -05:00
Joshua Peek
4e50a35fa2
Break up DependencyModule's dual function of providing a "depend_on" DSL and "included" block DSL into separate modules. But, unify both approaches under AS::Concern.
2009-05-28 11:35:36 -05:00
Joshua Peek
de203245af
Revert "Revert "Whitespace!""
...
This reverts commit 0cac68d3be .
2009-05-28 09:49:02 -05:00
Johan Sörensen
dd98280e38
Only save the session if we're actually writing to it [ #2703 state:resolved]
...
Signed-off-by: Joshua Peek <josh@joshpeek.com >
2009-05-28 09:35:17 -05:00
Johan Sörensen
72cb6f58be
The FlashHash and friends causes a lot of needless session storing, when we know for a fact that there's no content in the flash. By not storing the empty hash in the session we save a lot of communication with the various session backends, while still keeping the same interface to the flash. [ #2703 state:resolved]
...
Signed-off-by: Joshua Peek <josh@joshpeek.com >
2009-05-28 09:30:49 -05:00
Olly Legg
0349278f3d
Memoize cookies so that updates to cookies are available in the current request. [ #2733 state:resolved]
...
Signed-off-by: Joshua Peek <josh@joshpeek.com >
2009-05-28 09:18:27 -05:00
Joshua Peek
d17fb9dc76
Fix script/server's default mount path [ #2731 state:resolved]
2009-05-28 09:16:29 -05:00
Yehuda Katz + Carl Lerche
f2f58f5355
Fix failing ActionCacheFilter tests due to around filter changes.
2009-05-27 17:31:48 -07:00
Yehuda Katz + Carl Lerche
1e2628431a
Added support to new callbacks for around filter object that respond to :before & :after used in before|after callbacks
2009-05-27 16:50:40 -07:00
Yehuda Katz + Carl Lerche
2b166d306c
Added support to new callbacks for around filter object that respond to :before & :after
2009-05-27 16:49:23 -07:00
Yehuda Katz + Carl Lerche
bd7e3dc47d
Added a compatibility layer to get legacy filter tests to pass on new base
2009-05-27 16:49:04 -07:00
Yehuda Katz + Carl Lerche
e70bd6bdfa
Added hook point in new base #send_action which does the actual action method dispatching
2009-05-27 16:16:33 -07:00
Carl Lerche
a5688fa907
Add the ability to prepend filters to new callbacks
2009-05-27 16:15:53 -07:00
Xavier Noria
9c0064dd98
fixes markup, thanks to Joseph Pecoraro
2009-05-27 22:46:49 +02:00
Hongli Lai (Phusion)
760cb63339
Make the default 500 Internal Server Error page more friendly. Many people don't know they're supposed to look in the log files. [ #2716 state:resolved]
...
Signed-off-by: Joshua Peek <josh@joshpeek.com >
2009-05-27 15:01:03 -05:00
calavera
0d9e904da3
ensure initialize_database_middleware doesn't use ActionController if action_controller framework is not enabled [ #2680 state:resolved]
...
Signed-off-by: Joshua Peek <josh@joshpeek.com >
2009-05-27 14:56:14 -05:00
Joshua Peek
6ef329d325
Ensure Memcache local cache returns duplicated values [ #2302 state:resolved]
2009-05-27 14:54:58 -05:00
Eduard Bondarenko
61c471eebb
Add % to RESERVED_PCHAR [ #2574 state:resolved]
...
Signed-off-by: Joshua Peek <josh@joshpeek.com >
2009-05-27 14:53:05 -05:00
Niels Ganser
bb8e5843f3
ActionController::Flash::FlashHash.use now returns either the value corresponding to the passed key or itself when no key is passed [ #1792 state:resolved]
...
Signed-off-by: Joshua Peek <josh@joshpeek.com >
2009-05-27 14:51:33 -05:00
anupom syam
746f3860c1
server command help inconsistency fix [ #2685 state:resolved]
...
Signed-off-by: Joshua Peek <josh@joshpeek.com >
2009-05-27 14:45:16 -05:00
Chad Woolley
5679bf64d5
Fix failing CI test (broken in 2daac47 or e693f45): make test_multipart_with_template_path_with_dots only test path with dots, and stop failing on unrelated mimetype assertion. The image/jpeg multipart content type is already tested in test_explicitly_multipart_messages.
...
Signed-off-by: Yehuda Katz <wycats@yehuda-katzs-macbookpro41.local >
2009-05-27 21:38:23 +02:00
Fabien Jakimowicz
2cb60abfec
Add an model_subclass generator.
...
This generator creates a new model as a subclass of an existing model and the unit test for that model. Lets users avoid having to manually delete the fixtures and migration or remember to pass those arguments.
[#2702 state:committed]
Signed-off-by: Michael Koziarski <michael@koziarski.com >
2009-05-27 13:14:04 +02:00
Yehuda Katz
eaf8fe7708
Merge branch 'master' of git@github.com:rails/rails
2009-05-27 10:40:55 +02:00
Yehuda Katz
6bbe965ccd
Reduce the cost of using ActionController::Http significantly by:
...
* Removing the dependency on AD::Request and AD::Response
* Moving the logic for the request and response object
into a new module that is included by default.
* Changing Renderer and Redirector to use self.headers,
self.content_type, and self.status, which have very basic
default implementations on AC::Http. When RackConvenience
is included (which it is by default on AC::Base), the full
Request/Response logic is used instead of the simple logic.
2009-05-27 10:40:43 +02:00
Jeremy Kemper
d73f2ff434
Rename tools/profile_requires -> tools/profile since we do both require and ruby-prof profiling.
2009-05-27 01:11:33 -05:00
Jeremy Kemper
311d686d03
add a metal to minimal examples for comparison
2009-05-27 01:00:02 -05:00
Carl Lerche
7211048b2b
Get all template tests passing on new base
2009-05-26 15:19:39 -07:00
Carl Lerche
a1f280e83d
Got all the dispatch tests running on new base
2009-05-26 15:03:09 -07:00
Carl Lerche
1358f77745
Add controller/integration_test.rb to the new base test runner
2009-05-26 14:24:22 -07:00
Carl Lerche
a3ca5638d3
Get controller/test_test.rb to pass on new base
2009-05-26 14:13:35 -07:00
Carl Lerche
7dd094329e
Add html-scanner to the new base set of autoloads
2009-05-26 13:40:58 -07:00
Xavier Noria
6197606588
suggests using Hash#(except|slice) to be able to implement access logic where attr_(accessible|protected) is not enough
2009-05-26 22:18:42 +02:00
Carl Lerche
09907d1b93
Get controller/view_paths_test.rb to pass on new base
2009-05-26 12:14:50 -07:00
Carl Lerche
cbb0724f0d
In new base Rails2Compatibility, move @template assignment to right before the first action is processed.
2009-05-26 12:06:48 -07:00
Carl Lerche
cd8fb1800d
Remove a no-op from view path tests and removed a Symbol#to_proc
2009-05-26 11:47:42 -07:00
Emilio Tagua
b3d4054692
Merge commit 'rails/master'
2009-05-26 11:34:02 -03:00
Pratik Naik
2f59066470
Support Method callbacks
2009-05-26 13:09:33 +02:00
Pratik Naik
10085114ce
Make Filter#filter work with around filters
2009-05-25 18:09:12 +02:00
Pratik Naik
9cda410d81
Make cookie store tests pass with the new base
2009-05-25 16:52:44 +02:00
Xavier Noria
1afe7f2b79
The original example was correct.
...
This reverts commit 4e56cc2f99 .
2009-05-25 09:50:53 +02:00
Adam Meehan
4e56cc2f99
typo in AS
2009-05-25 15:39:43 +10:00
Jeremy Kemper
8097da93cc
Don't want Rack's Content-Type default header though
2009-05-24 19:25:53 -07:00
Jeremy Kemper
b1d4fb71bf
Construct a single HeaderHash. Speed up assign_default_content_type_and_charset
2009-05-24 17:35:49 -07:00
Jeremy Kemper
bdb61c1dad
Compare Base with Http
2009-05-24 17:34:40 -07:00
Xavier Noria
91e32af772
a few details here and there in url_helper.rb docs
2009-05-24 23:17:47 +02:00
Lloyd Pick
bd918ce75f
Updated examples to use latest config structure
2009-05-24 15:15:02 -04:00
Hongli Lai (Phusion)
358ed90fe5
Document the way BufferedLogger defines its methods.
2009-05-24 12:03:21 +02:00
Pratik Naik
7324e46a3f
Merge commit 'mainstream/master'
...
Conflicts:
actionpack/lib/action_controller/base/mime_responds.rb
2009-05-24 11:54:27 +02:00
Thomas R. Koll
1fee2fb996
Fixed a typo
...
Writing "form element" instead of "FORM element"
2009-05-24 11:46:10 +02:00
Jeremy Kemper
6e039e863a
Speed up Request#formats
2009-05-23 19:30:23 -07:00
Jeremy Kemper
a78b0a40c6
runner class
2009-05-23 19:30:18 -07:00
Xavier Noria
9b5fd797c5
performance guide: performance tests run in test environment, thanks to Nicholas J Kreucher
2009-05-24 01:05:16 +02:00
Xavier Noria
a65457158e
layouts guide: makes some app paths relative
2009-05-24 00:26:08 +02:00
Xavier Noria
39ad75bda2
associations guide: find_by_customer_id -> find_all_by_customer_id, thanks to Kai Krakow
2009-05-24 00:04:45 +02:00
Xavier Noria
402f08f1ef
in associations guide: exist? -> exists?, thanks to Peter Zlatnar
2009-05-23 23:55:04 +02:00
Jeremy Kemper
4e3fd23e31
test depends on html-scanner
2009-05-23 03:10:48 -07:00
Yehuda Katz
e0ed4b7aa4
Make a couple more tests pass.
...
A large number of the remaining failing tests have to do with
the semantics of filters that are Objects. The right solution
is probably to just implement the filter/before/after semantics
in NewCallbacks directly (the current semantics are based
on the old AS::Callbacks specs)
2009-05-23 01:30:25 -07:00
Yehuda Katz
e22a3d893e
Slightly modify things to get content type matching working without breaking other code
2009-05-23 00:39:32 -07:00
Xavier Noria
9d316bbf7c
AS guide: documents class attribute accessors and inheritable attributes
2009-05-23 04:46:07 +02:00
Pratik Naik
3ac6d8f8b0
Remove unnecessary asset_host initialization
2009-05-23 02:35:34 +02:00
Pratik Naik
9286d422f8
Add asset_host to Rails2Compatibility
2009-05-23 02:29:55 +02:00
Yehuda Katz + Carl Lerche
5097bd6241
Modify render_test's determine_layout to match RJS
2009-05-22 17:26:27 -07:00
Jeremy Kemper
fb64263c91
Restore some missing test constants
2009-05-22 17:22:37 -07:00
Pratik Naik
595107f22e
Move html-scanner tests one dir up
2009-05-23 02:21:07 +02:00
Yehuda Katz + Carl Lerche
69a1ea8b5d
Created an ActionController::Renderers::All that includes all the default render options (:json, :js, :rjs, :xml)
2009-05-22 17:17:16 -07:00
Jeremy Kemper
da9e53ec3b
Move testing_sandbox to test/lib
2009-05-22 17:17:14 -07:00
Jeremy Kemper
8a03a999ef
Cordon off missing filter methods
2009-05-22 17:16:03 -07:00
Yehuda Katz + Carl Lerche
7b3fb1d43f
Got controller/render_js_test.rb to pass on new base
2009-05-22 17:08:58 -07:00
Pratik Naik
3a72b55229
Add missing selector_test to the list
2009-05-23 02:08:07 +02:00
Jeremy Kemper
f9dde8fe4e
Port cookies to new base
2009-05-22 17:05:44 -07:00
Pratik Naik
c90f613ad6
Add Translation to the new base
2009-05-23 02:03:22 +02:00
Yehuda Katz + Carl Lerche
28dbeb3a64
Get controller/render_other_test.rb to pass on new base and fixed a bug in new base with regards to rendering layouts.
2009-05-22 16:55:27 -07:00
Yehuda Katz + Carl Lerche
63ed43cb99
Added render_other_test.rb to the new base test runner
2009-05-22 16:55:27 -07:00
Pratik Naik
b77602824a
Add some more tests to the test_new_base_on_old_tests task
2009-05-23 01:46:37 +02:00
Pratik Naik
f766f66946
Make logging_test pass with the new base
2009-05-23 01:36:09 +02:00
Jeremy Kemper
a01d2a2586
Remove gratuitous filter_chain internal testing. Not part of the API and other tests are sufficient to catch regressions.
2009-05-22 16:25:49 -07:00
Jeremy Kemper
444480c9a5
Verbose test_new_base_on_old_tests
2009-05-22 16:23:48 -07:00
Jeremy Kemper
b7c031f52e
Move active_record_unit to shared load path
2009-05-22 16:21:21 -07:00
Jeremy Kemper
ca72078388
Move fake controllers and models to a common load path
2009-05-22 16:11:54 -07:00
Jeremy Kemper
98f856d772
Set ENV['NEW'] to run any test task with the new Base.
2009-05-22 15:32:35 -07:00
Jeremy Kemper
3c13551aa2
Complain if new_base/abstract_unit was already loaded
2009-05-22 15:32:35 -07:00
Jeremy Kemper
df2d96a7f0
Move misplaced test
2009-05-22 15:32:35 -07:00
Pratik Naik
8a336d01d2
Use super wherever possible in ActionController::Helpers#helper
2009-05-23 00:30:32 +02:00
Yehuda Katz + Carl Lerche
72a574b507
Get controller/layout_test.rb running on new base except for ActionController::Base.exempt_from_layout which is going to be deprecated.
2009-05-22 15:25:13 -07:00
Yehuda Katz + Carl Lerche
01129534cd
Cleaned up the #render_to_body chain by extracting determining the templates to render to a separate hook point.
2009-05-22 15:24:31 -07:00
Pratik Naik
e976c489e6
Add all the existing helpers related features to the new base
2009-05-23 00:17:10 +02:00
Pratik Naik
1d168afcb1
Move FilterParameterLogging to a stand alone module and make it work on new base
2009-05-22 19:51:17 +02:00
Pratik Naik
faaff383e6
Add assert_select tests to the new base
2009-05-22 19:03:27 +02:00
Pratik Naik
9d08f86cd4
Make assertion tests pass with the new base
2009-05-22 19:01:52 +02:00
Pratik Naik
d1d9a6c261
Require ruby-debug from new_base/abstract_unit
2009-05-22 18:15:43 +02:00
Jeremy Kemper
1fa7e3322d
Ruby 1.9 compat: don't rely on lexical scoping since the included block is called from dependency_module
2009-05-21 20:54:28 -07:00
Jeremy Kemper
4c52ba278b
Move Safari response-padding fix to Rails2Compatibility. Should be a Rack concern.
2009-05-21 20:27:24 -07:00
Jeremy Kemper
8f3cbb4773
Dead local
2009-05-21 20:27:24 -07:00
Jeremy Kemper
e0e124757a
Fewer runs by default
2009-05-21 20:27:24 -07:00
Yehuda Katz + Carl Lerche
68a207ccf6
Implemented layout conditions in new base
2009-05-21 18:14:20 -07:00
Yehuda Katz + Carl Lerche
6923b392b7
Added the :rjs render option
2009-05-21 16:35:40 -07:00
Yehuda Katz + Carl Lerche
e773d0e68a
Renamed #implicit_render to #default_render in new base to support the default_render API
2009-05-21 16:31:05 -07:00
Pratik Naik
1a52b246eb
Add HTTP Authentication to the new base
2009-05-22 00:29:47 +02:00
Pratik Naik
d2cac9dd0e
Add missing dependency in Streaming
2009-05-22 00:27:08 +02:00
Yehuda Katz + Carl Lerche
9d3d774670
Update render options to remove performance implications of many render options types
2009-05-21 15:23:52 -07:00
Yehuda Katz + Carl Lerche
ad1c90de3a
Added the :xml render option
2009-05-21 14:51:29 -07:00
Yehuda Katz + Carl Lerche
2daac47d58
Added the ability to register methods to handle specific render option keys and render :json
2009-05-21 14:36:00 -07:00
Yehuda Katz + Carl Lerche
e693f45e15
Remove some response content type concepts from ActionView
2009-05-21 14:34:56 -07:00
Pratik Naik
386ff66e5e
Add Streaming to new base
2009-05-21 21:48:42 +02:00
Pratik Naik
59b32f2883
RequestForgeryProtection now works with the new base
2009-05-21 21:48:42 +02:00
Jeremy Kemper
886eeed52e
Clean up tools/profile_requires a bit
2009-05-21 10:22:35 -07:00
Chad Woolley
0f1b283e03
Fix eager association test related to different ordering on sqlite
...
[#2686 state:committed]
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2009-05-21 10:01:47 -07:00
Jeremy Kemper
e9a7545123
Avoid uninitialized instance variable warning
2009-05-20 18:12:45 -07:00
Jeremy Kemper
428829fc38
Single-require forward compatibility with new Ruby features like Object#tap, Enumerable#group_by, and Process.daemon. Code with the latest but run anywhere.
2009-05-20 18:12:45 -07:00
Jeremy Kemper
886aa2f0e1
Extract autoloads
2009-05-20 18:12:45 -07:00
Jeremy Kemper
5f222c524e
Remove 'core' fluff. Hookable ActiveSupport.load_all!
2009-05-20 18:12:44 -07:00
Jeremy Kemper
3694227f24
Break out Symbol#to_proc as a future-ruby extension
2009-05-20 18:12:44 -07:00
Jeremy Kemper
6839883854
Break up misc Object extensions
2009-05-20 18:12:44 -07:00
Jeremy Kemper
429a00f225
Remove bad add
2009-05-20 18:12:44 -07:00
Pratik Naik
5a03645762
Allow Module#depends_on to accept multiple modules
2009-05-21 03:04:17 +02:00
Pratik Naik
e21d1614bb
Made ActionController::Verification work with new_base
2009-05-21 02:55:25 +02:00
Yehuda Katz + Carl Lerche
7f7fdc407a
Make controller/content_type_test.rb pass on new base
2009-05-20 17:42:04 -07:00
Yehuda Katz + Carl Lerche
c8eda9ade4
Fixed new_base tests on ruby 1.9
2009-05-20 17:22:29 -07:00
Yehuda Katz + Carl Lerche
c4a6109286
Got controller/mime_responds_test.rb running on the new base
2009-05-20 16:54:21 -07:00
Pratik Naik
8e7a87d299
Make ActionController::Flash work with new_base
2009-05-21 01:41:35 +02:00
Jeremy Kemper
205cfe2163
Massage setup for old tests on new base
2009-05-20 16:23:55 -07:00
Jeremy Kemper
c86ec82cf6
Wrap string body in an array
2009-05-20 16:01:21 -07:00
Jeremy Kemper
b46c9071c3
Ruby 1.9 stdlib gems don't recognize .pre yet
2009-05-20 16:01:21 -07:00
Yehuda Katz + Carl Lerche
77d955c517
Added passing old tests on new base to the main test runner
2009-05-20 15:54:29 -07:00
Yehuda Katz + Carl Lerche
01f032f256
Added responds_to to new base.
2009-05-20 15:34:26 -07:00
Pratik Naik
8ba4307bf7
Add coding style to contributing guide
2009-05-20 23:44:38 +02:00
Pratik Naik
c03b0ca7eb
Replace the class level Rack::Test DSL with the regular integration tests DSL
2009-05-20 21:15:06 +02:00
Joshua Peek
6761759a90
Temporarily bundle rack-test while MockSession is baking
2009-05-19 22:43:22 -05:00
Bryan Helmkamp
df0faea378
Refactor ActionController instantiation capture
2009-05-19 22:43:21 -05:00
Bryan Helmkamp
0029d5e594
Integrating Rack::MockSession (from Rack::Test)
2009-05-19 22:43:21 -05:00
Yehuda Katz + Carl Lerche
321168b17b
Make old caching tests pass on new base.
2009-05-19 18:11:45 -07:00
Yehuda Katz + Carl Lerche
67cc021d01
Modified caching implementation to work with NewBase
2009-05-19 18:11:45 -07:00
Yehuda Katz + Carl Lerche
0e7da0e4a0
Include caching module into new base
2009-05-19 18:11:44 -07:00
Yehuda Katz + Carl Lerche
26f2be01c2
Modify caching to use new included helper
2009-05-19 18:11:44 -07:00
Yehuda Katz + Carl Lerche
67247ca8ee
Corrected new callbacks semantics with regards to using objects for around filters.
2009-05-19 18:11:44 -07:00
Bryan Helmkamp
36058f4504
Use duck typing to also allow MemCache-like object when initializing a MemCacheStore
...
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2009-05-19 16:58:04 -07:00
Emilio Tagua
aa55122990
Merge commit 'rails/master'
2009-05-19 19:37:36 -03:00
Pratik Naik
d8fffe7b23
Replace ad hoc Rack::Test with ActionController::IntegrationTest
2009-05-20 00:06:14 +02:00
Pratik Naik
f503a5dc97
Missing CHANGELOG entry for 4a6f4b92ad
2009-05-19 23:57:49 +02:00
Pratik Naik
4a6f4b92ad
Change integration test helpers to accept Rack environment instead of just HTTP Headers.
...
Before : get '/path', {}, 'Accept' => 'text/javascript'
After : get '/path', {}, 'HTTP_ACCEPT' => 'text/javascript'
2009-05-19 23:50:03 +02:00
Jeremy Kemper
0bdef30f35
Lazy-require Kernel#silence_warnings
2009-05-19 12:19:58 -07:00
Bryan Helmkamp
e2ed1a1ca4
Allow MemCacheStore to be initialized with a MemCache object instead of addresses and options
2009-05-19 10:54:56 -07:00
Chad Woolley
6dc3a6a954
Upgrade CI server to latest RubyGems [ #2665 state:resolved]
...
Signed-off-by: Pratik Naik <pratiknaik@gmail.com >
2009-05-19 12:50:26 +02:00
Emilio Tagua
20deb677a2
Add missing models and fixtures [ #2673 state:resolved]
...
Signed-off-by: Pratik Naik <pratiknaik@gmail.com >
2009-05-19 12:11:46 +02:00
Xavier Noria
dfcc3e2f89
attempt at fixing fxn picture in credits page
2009-05-19 10:02:08 +02:00
Yehuda Katz + Carl Lerche
07f733c631
Ported simple benchmarking in new base
2009-05-18 17:33:45 -07:00
Emilio Tagua
1cc4459939
Merge commit 'rails/master'
...
Conflicts:
activerecord/lib/active_record.rb
Updated:
Arel submodule
2009-05-18 20:01:06 -03:00
Jeremy Kemper
ee5520a0a5
Merge branch 'master' of git@github.com:rails/rails
2009-05-18 15:02:15 -07:00
Jeremy Kemper
41e9414b60
Include acts_as_string?
2009-05-18 15:01:13 -07:00
Emilio Tagua
5463823df3
Remove unnecessary condition and local variable [ #2602 state:resolved]
...
Signed-off-by: Pratik Naik <pratiknaik@gmail.com >
2009-05-18 22:46:37 +02:00
Joe Van Dyk
29550cc91f
Add ability to get multiple memcached keys at the same time (via MemCacheStore#read_multi).
...
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2009-05-18 13:43:56 -07:00
Jeremy Kemper
3e2f0800e3
Merge branch 'master' of git@github.com:rails/rails
2009-05-18 13:43:44 -07:00
Ken Collins
87adecfef5
Reimplement Fixtures.identify so that it consistently generates identities across ruby versions.
...
[#2633 state:committed]
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2009-05-18 13:40:45 -07:00
Luca Guidi
cef76c8af4
Ensure HasManyThroughAssociation#destroy delete orphan records [ #2251 state:resolved]
...
Signed-off-by: Pratik Naik <pratiknaik@gmail.com >
2009-05-18 22:30:43 +02:00
Jeremy Kemper
a69b28a8b1
Missing 1.8.7 backport extensions
2009-05-18 13:20:04 -07:00
Pratik Naik
c5e109bbe7
Make sure default_scope#create checks for options[:conditions] [ #2181 state:resolved] [James Le Cuirot]
2009-05-18 21:27:42 +02:00
Jeremy Kemper
37453e11e9
Revert "Get AR CI passing again by requiring the entire core_ext"
...
This reverts commit 8e6a18d867 .
2009-05-18 11:55:06 -07:00
Jeremy Kemper
cf6e025a45
Merge branch 'master' of git@github.com:rails/rails
2009-05-18 11:54:51 -07:00
Andy Stewart
5e190ef138
Truncate helper accepts a :separator for a more legible result [ #1807 state:resolved]
...
Signed-off-by: Pratik Naik <pratiknaik@gmail.com >
2009-05-18 20:46:19 +02:00
Pratik Naik
195fadbfd3
Ensure HTTP Digest auth uses appropriate HTTP method [ #2490 state:resolved] [Steve Madsen]
2009-05-18 16:59:37 +02:00
Emilio Tagua
3db44e938f
Merge branch 'master' of git://github.com/rails/rails
2009-05-18 11:19:03 -03:00
Emilio Tagua
a04dedd563
Merge commit 'rails/master'
...
Conflicts:
activerecord/lib/active_record/base.rb
activerecord/lib/active_record/migration.rb
activerecord/test/cases/helper.rb
2009-05-18 11:18:46 -03:00
Emilio Tagua
28f5cfe066
Add missing model and fixtures to finder_test [ #2671 state:resolved]
...
Signed-off-by: Pratik Naik <pratiknaik@gmail.com >
2009-05-18 15:58:25 +02:00
Benjamin Floering
27de7f150b
Fixed limited eager loading associations with numbers in the name [ #2668 state:resolved]
...
Signed-off-by: Pratik Naik <pratiknaik@gmail.com >
2009-05-18 13:56:17 +02:00
Kerry Buckley
49afe81a13
Report errors in 'all project' rake tasks [ #2224 state:resolved]
...
Signed-off-by: Pratik Naik <pratiknaik@gmail.com >
2009-05-18 11:13:51 +02:00
rick
e89241c92f
load the JSON Backend lazily. If the JSON gem is already loaded, use the JSONGem backend by default.
2009-05-17 19:18:00 -07:00
Brian Lopez
b0de061e7b
Allow ParamsParser to parse YAML from the request body IO directly
...
Signed-off-by: Joshua Peek <josh@joshpeek.com >
2009-05-17 16:09:28 -05:00
Joshua Peek
01d7acd11d
Fix reset_session with ActiveRecord store [ #2200 state:resolved]
2009-05-17 14:42:36 -05:00
Mislav Marohnić
b33c0d9832
replace the aaa_create_tables_test hack with loading test database schema in the test helper [ #2663 state:resolved]
...
Signed-off-by: Joshua Peek <josh@joshpeek.com >
2009-05-17 13:51:35 -05:00
Joshua Peek
092089015b
Extract generic callbacks middleware from dispatcher
2009-05-17 13:39:55 -05:00
Mike Breen
edc9c226d1
Add tests for assert_template :template
...
Signed-off-by: Pratik Naik <pratiknaik@gmail.com >
2009-05-17 19:50:00 +02:00
Joshua Peek
8118fca9be
Merge Failsafe middleware into ShowExceptions
2009-05-17 12:24:59 -05:00
Joshua Peek
c3319504f0
Rescue hack was supposed to be removed. Some how it crept back in.
2009-05-17 12:24:59 -05:00
Travis Briggs
98eaa2c683
Ensure number_to_human_size does not strip zeros from the end [ #1763 state:resolved]
...
Signed-off-by: Pratik Naik <pratiknaik@gmail.com >
2009-05-17 19:02:50 +02:00
Thomas E. Glasgow
e41984c5f7
Simplify filter_chain method implementation [ #2327 state:resolved]
...
Signed-off-by: Pratik Naik <pratiknaik@gmail.com >
2009-05-17 18:56:07 +02:00
Chris Kampmeier
4e8c36a741
Implement #many? for NamedScope and AssociationCollection using #size [ #1500 state:resolved]
...
Signed-off-by: Pratik Naik <pratiknaik@gmail.com >
2009-05-17 18:56:06 +02:00
Lance Ivy
11bac70078
Ensure auto_link does not ignore multiple trailing punctuations [ #2504 state:resolved]
...
Signed-off-by: Pratik Naik <pratiknaik@gmail.com >
2009-05-17 18:56:06 +02:00
Brian Lopez
53dda29f8b
Add support for parsing XML and JSON from an IO as well as a string [ #2659 state:resolved]
...
Signed-off-by: Joshua Peek <josh@joshpeek.com >
2009-05-17 10:37:52 -05:00
Mike Gunderloy
344ee681d6
Remove obsolete wiki reference [ #2291 state:resolved]
...
Signed-off-by: Pratik Naik <pratiknaik@gmail.com >
2009-05-17 15:15:43 +02:00
Paulo Schneider
34874b3bcd
Fix typo in the generated routes.rb [ #2433 state:resolved]
...
Signed-off-by: Pratik Naik <pratiknaik@gmail.com >
2009-05-17 15:00:05 +02:00
Jacob Kjeldahl
d6645a5e52
Supply valid ruby-prof parameters [ #1804 state:resolved]
...
Signed-off-by: Pratik Naik <pratiknaik@gmail.com >
2009-05-17 14:53:06 +02:00
Daniel Guettler
25724eede9
has_one :through should not create a new association when assigned nil [ #698 state:resolved]
...
Signed-off-by: Pratik Naik <pratiknaik@gmail.com >
2009-05-17 14:48:20 +02:00
Pratik Naik
a9e8c4b374
Ensure rake test does not run new base tests as that requires rack/test
2009-05-17 14:31:54 +02:00
Jeffrey Chupp
842dab0c29
Ensure WhiteListSanitizer allows dl tag [ #2393 state:resolved]
...
Signed-off-by: Pratik Naik <pratiknaik@gmail.com >
2009-05-17 14:29:47 +02:00
Yehuda Katz
4fa871654d
Get Railties passing again
2009-05-16 12:28:25 -07:00
Yehuda Katz
db1bf3650d
Fix ActionMailer Symbol#to_proc instance
2009-05-16 12:13:41 -07:00
Yehuda Katz
8e6a18d867
Get AR CI passing again by requiring the entire core_ext
...
Note that this includes Time and Date; we should
really figure out what parts of core_ext are really
required for AR and require just those.
2009-05-16 12:09:25 -07:00
Bryan Helmkamp
59c4d9a5b4
Changelog
2009-05-16 14:18:10 -04:00
Bryan Helmkamp
7f318c3ec5
Instead of checking Rails.env.test? in Failsafe middleware, check env["rails.raise_exceptions"]
2009-05-16 14:15:26 -04:00
Pratik Naik
6be72a1e62
Merge commit 'mainstream/master'
2009-05-16 17:13:58 +02:00
Pratik Naik
a6d8ca0f0e
Include guides directory in the rails gem
2009-05-16 17:10:04 +02:00
Pratik Naik
c8fb22bc29
Remove some informal sentences and new lines
2009-05-16 16:47:24 +02:00
Peter Szinek
a40a720b0a
Initial version - quick brain dump
2009-05-16 16:13:31 +02:00
Yehuda Katz + Carl Lerche
5a45446cff
Ported Rescuable to new base
2009-05-15 17:49:11 -07:00
Yehuda Katz + Carl Lerche
7e10504bde
Refactored AbstractController to provide better hook points for overriding aspects of action dispatching
2009-05-15 15:57:12 -07:00
Mike Gunderloy
01064e25c9
Fix comment in seeds.rb to make more sense.
2009-05-15 10:07:51 -05:00
Pratik Naik
59653101b8
Merge commit 'mainstream/master'
...
Conflicts:
actionpack/lib/action_view/helpers/form_helper.rb
2009-05-15 16:47:15 +02:00
José Valim
eb021707f5
Allow strings to be sent as collection to select.
...
Signed-off-by: Michael Koziarski <michael@koziarski.com >
2009-05-15 15:30:17 +12:00
Jeremy Kemper
628110d7ee
Active Support dependencies
2009-05-14 17:42:20 -07:00
Yehuda Katz + Carl Lerche
b6bac73b28
Merge commit 'origin/master'
...
Conflicts:
actionpack/lib/action_controller/abstract/base.rb
actionpack/lib/action_controller/routing.rb
2009-05-14 17:38:30 -07:00
Yehuda Katz + Carl Lerche
da65320433
Got new base to pass controller/base_test.rb, implemented method_missing action semantics in compatibility mode, and fixed a few action_missing bugs.
2009-05-14 17:25:10 -07:00
Yehuda Katz + Carl Lerche
8fac2c88ca
Cleaning up more render tests
2009-05-14 15:30:35 -07:00
Andreas Scherer
26ad104e72
'TIP.' replaced with 'TIP:' for consistent formatting.
2009-05-14 14:35:18 +02:00
Jeremy Kemper
c286952050
Minimal base/new_base comparison
2009-05-14 02:01:08 -07:00
Jeremy Kemper
5dd29c466c
Cherry-picking Active Support extensions
2009-05-14 02:01:08 -07:00
Jeremy Kemper
29bd8f7b89
Simple example for require profiling
2009-05-14 02:01:08 -07:00
Peter Marklund
afcbdfc15f
Changed ActiveRecord::Base#exists? to invoke find_initial so that it is compatible with, and doesn't lose, :include scopes (references to eager loaded tables)
...
Signed-off-by: Michael Koziarski <michael@koziarski.com >
[#2543 state:committed]
2009-05-14 20:42:00 +12:00
Yehuda Katz + Carl Lerche
49a84ff69c
Ported over render :file tests.
2009-05-13 17:00:59 -07:00
Xavier Noria
a65224f036
a few details in the caching guide I saw in passing
2009-05-13 23:29:56 +02:00
Jeremy Kemper
4f291fa528
Simple examples for require profiling
2009-05-13 12:00:49 -07:00
Jeremy Kemper
e8550ee032
Cherry-pick core extensions
2009-05-13 12:00:15 -07:00
Jeremy Kemper
fa5da8ad54
isolated_test task
2009-05-13 11:43:03 -07:00
Jeremy Kemper
a7ccc7c79f
Remove support for deprecated validation message interpolation format
2009-05-13 11:43:03 -07:00
Jeremy Kemper
e9c5750bd1
Preserve ordering
2009-05-13 11:43:03 -07:00
Jeremy Kemper
4c963972fd
Defer rake/contrib requires so we can use the stdlib rake instead of the full gem
2009-05-13 11:43:03 -07:00
Yehuda Katz + Carl Lerche
216309c165
Implemented redirects and partial rendering in new base.
2009-05-12 16:21:34 -07:00
Emilio Tagua
0048897a41
Merge commit 'rails/master'
2009-05-12 16:13:00 -03:00
Yehuda Katz + Carl Lerche
72ca7c591c
Fixed new callbacks to not call the action when a callback sets the response body
2009-05-12 10:53:00 -07:00
Cheah Chu Yeow
3c790b631d
Remove space between JSON keys and values since we're no longer emitting those.
2009-05-13 01:42:51 +08:00
Jeremy Kemper
22c5667c2e
Defer rake/contrib/sshpublisher require so we can use the stdlib rake instead of the full gem
2009-05-11 19:49:11 -07:00
Bryan Helmkamp
a2875bec9a
Use DependencyModule for included hooks in ActiveRecord
2009-05-11 22:23:47 -04:00
Yehuda Katz + Carl Lerche
00a9d4b91c
Merge branch 'master' into wip_abstract_controller
...
Conflicts:
actionpack/lib/action_controller/abstract/callbacks.rb
actionpack/lib/action_controller/abstract/renderer.rb
actionpack/lib/action_controller/base/base.rb
actionpack/lib/action_controller/dispatch/dispatcher.rb
actionpack/lib/action_controller/routing/route_set.rb
actionpack/lib/action_controller/testing/process.rb
actionpack/test/abstract_controller/layouts_test.rb
actionpack/test/controller/filters_test.rb
actionpack/test/controller/helper_test.rb
actionpack/test/controller/render_test.rb
actionpack/test/new_base/test_helper.rb
2009-05-11 17:07:05 -07:00
Yehuda Katz + Carl Lerche
0cac68d3be
Revert "Whitespace!"
...
This reverts commit a747ab5b20 .
2009-05-11 15:03:24 -07:00
Yehuda Katz + Carl Lerche
0f6e764e40
Fixed a bug with handling render options
2009-05-11 14:48:58 -07:00
Yehuda Katz + Carl Lerche
6694bd46f5
Aliased AbstractController::ActionNotFound to ActionController::UnknownAction
2009-05-11 12:45:26 -07:00
Jeremy Kemper
ddbeb15a5e
Revert "Fixed bug with polymorphic has_one :as pointing to an STI record"
...
[#2594 state:open]
This reverts commit 99c103be11 .
2009-05-11 12:20:54 -07:00
Yehuda Katz + Carl Lerche
94ee9d2452
Ported ConditionalGet to new Base
2009-05-11 12:04:43 -07:00
Yehuda Katz + Carl Lerche
c1d120a71e
Don't run the action if callbacks are halted.
...
In AbstractController, this means that response_body is not empty
2009-05-11 11:48:38 -07:00
Douglas F Shearer
e1854e0b19
ActiveSupport::OrderedHash[1,2,3,4] creates an OrderedHash instead of a Hash.
...
[#2615 state:committed]
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2009-05-11 11:45:57 -07:00
Jeremy Kemper
d45d0a1864
Merge branch 'master' of git@github.com:rails/rails
2009-05-11 11:43:30 -07:00
Yehuda Katz + Carl Lerche
34caf4f552
Merge branch 'master' into wip_abstract_controller
2009-05-11 10:58:30 -07:00
Yehuda Katz + Carl Lerche
a2f3684cec
Ported fresh_when into a ConditionalGet module
2009-05-11 10:57:59 -07:00
Yehuda Katz
030dfe3f83
More community code review :)
2009-05-11 10:22:07 -07:00
David Heinemeier Hansson
4932f7b38f
Added db/seeds.rb as a default file for storing seed data for the database. Can be loaded with rake db:seed (or created alongside the db with db:setup). (This is also known as the "Stop Putting Gawd Damn Seed Data In Your Migrations" feature) [DHH]
2009-05-11 19:08:13 +02:00
Mina Naguib
a2cfc13f9e
Fix some bad grammar, and elaborate more on common web serving setup
2009-05-11 11:18:42 -04:00
Alexander Dymo
2e7409f035
Change spelling of Kyev timezone to Kyiv [ #2613 state:resolved]
2009-05-10 11:59:03 -05:00
Mike Breen
9010ed2755
Allow you to pass :all_blank to :reject_if option to automatically create a Proc that will reject any record with blank attributes.
2009-05-10 15:02:00 +12:00
Anthony Crumley
026b78f907
Fixed eager load error on find with include => [:table_name] and hash conditions like {:table_name => {:column => 'value'}}
...
Signed-off-by: Michael Koziarski <michael@koziarski.com >
2009-05-10 13:36:51 +12:00
Ken Collins
9e0cfdb7f9
ActiveSupport::OrderedHash#to_a method returns an ordered set of arrays. Matches ruby1.9's Hash#to_a.
...
Signed-off-by: Michael Koziarski <michael@koziarski.com >
[#2629 state:committed]
2009-05-10 13:04:46 +12:00
Frederick Cheung
235775de29
honour :inverse_of for joins based include
...
Signed-off-by: Michael Koziarski <michael@koziarski.com >
2009-05-10 12:50:03 +12:00
Frederick Cheung
ef6f22ab2a
honour inverse_of when preloading associations
...
Signed-off-by: Michael Koziarski <michael@koziarski.com >
2009-05-10 12:50:02 +12:00
Evan Farrar
da965645c2
Adds a missing comma in example code.
2009-05-09 14:05:06 -05:00
Evan Farrar
f3853c7769
Syntax error in example code: not valid to omit parens with hash arguments.
2009-05-09 13:27:15 -05:00
Evan Farrar
095bfadb61
Tiny syntax error in the action mailer guide.
2009-05-09 13:20:14 -05:00
Emilio Tagua
6c7d8cb8ac
Merge commit 'rails/master'
2009-05-09 13:07:30 -03:00
Evan Farrar
c7d975708f
The MailingAddress is good design, but it adds some noise to the querying guide b/c it is not referenced anywhere.
2009-05-09 09:58:29 -05:00
Evan Farrar
54b5b0632e
Just a fix to the units in the RPM prize 'formula.'
2009-05-09 09:29:35 -05:00
Jeremy Kemper
4817bf94d1
Check for date/time methods that moved upstream in 1.9
2009-05-07 18:39:03 -07:00
Jeremy Kemper
49ed452136
Defer rake/contrib/sshpublisher require so basic tasks don't need the full rake gem
2009-05-07 18:27:50 -07:00
Evan Farrar
d3b3eb59b7
Fixes some typos in the guides.
2009-05-07 15:24:07 -05:00
Jeremy Kemper
8ee0c598db
Tool for profiling resource usage in each require call.
...
$ ruby -Iactiveresource/lib tools/profile_requires.rb active_resource
91.84 KB 3220 obj 4.0 ms active_resource
83.86 KB 3108 obj 3.3 ms active_support
69.32 KB 2682 obj 2.6 ms active_support/vendor
33.98 KB 651 obj 0.6 ms i18n
94.40 KB 315 obj 4.0 ms 44 KB RSS
2009-05-07 12:10:26 -07:00
Evan Farrar
d2e8cdea2c
Spelling fixes in activerecord.
2009-05-07 13:43:11 -05:00
Evan Farrar
a97f3bdfa9
Some spelling changes.
2009-05-07 12:35:38 -05:00
Joshua Peek
a747ab5b20
Whitespace!
2009-05-07 10:45:29 -05:00
Joshua Peek
af40fa6d03
Prefer "included" language over "setup"
2009-05-07 10:38:57 -05:00
Joshua Peek
2854535b02
Make module dependency DSL opt in
2009-05-07 10:29:22 -05:00
Joshua Peek
783deae99a
Add test coverage to module setup extensions
2009-05-07 10:03:39 -05:00
Matt Jones
bfc1609a50
Remove stray call to gems:unpack in gems:build:force
...
[#2266 state:committed]
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2009-05-06 18:57:27 -07:00
Xavier Noria
1135e29bab
destroyal -> destruction, thanks to FelixLeiter
2009-05-06 22:49:31 +02:00
Jeremy Kemper
201d8b1755
Fix tests on 1.8.6
2009-05-06 12:19:30 -07:00
Emilio Tagua
8885b2d6c1
Refactor to calculations. Migration's versions are string not integer. ARel submodule updated.
2009-05-06 14:16:03 -03:00
Emilio Tagua
118b19a9fa
Merge branch 'master' of git://github.com/rails/rails
2009-05-06 11:32:14 -03:00
Jeremy Kemper
bd7659e014
Fix old reference to ActionController::Failsafe
2009-05-06 01:28:06 -07:00
Jeremy Kemper
6d4a4fabbb
Cherry pick Active Support dependencies. Autoload.
2009-05-06 00:14:55 -07:00
Jeremy Kemper
c585e263ab
Remove superfluous CGI require
2009-05-05 21:50:53 -07:00
Jeremy Kemper
a05cfb6df5
Prefer sibling Active Support
2009-05-05 21:44:02 -07:00
Jeremy Kemper
2f42433f0a
Cherry-pick the inflector only
2009-05-05 21:40:53 -07:00
Emilio Tagua
a83a1cceba
Merge commit 'rails/master'
2009-05-05 10:14:28 -03:00
Joshua Peek
d4402c5554
assert_redirect_to's partial hash matching was deprecated in 2-3 stable 7f1f16c01
2009-05-04 20:26:43 -05:00
Tim Connor
e3891601d1
fix problems with requires in metal choking under development reloading [ #2579 state:resolved]
...
Signed-off-by: Joshua Peek <josh@joshpeek.com >
2009-05-04 20:11:24 -05:00
Joshua Peek
b9f9dd8fe9
Fix console
2009-05-04 20:02:14 -05:00
Emilio Tagua
d19d4d2f20
Fixes to have all test passing on PostgreSQL.
...
Calculations now use construct_calculation_arel, making construct_finder_arel less hackish.
Updated ARel to support PostgreSQL.
2009-05-04 21:53:29 -03:00
Murray Steele
ccea98389a
Providing support for :inverse_of as an option to associations.
...
You can now add an :inverse_of option to has_one, has_many and belongs_to associations. This is best described with an example:
class Man < ActiveRecord::Base
has_one :face, :inverse_of => :man
end
class Face < ActiveRecord::Base
belongs_to :man, :inverse_of => :face
end
m = Man.first
f = m.face
Without :inverse_of m and f.man would be different instances of the same object (f.man being pulled from the database again). With these new :inverse_of options m and f.man are the same in memory instance.
Currently :inverse_of supports has_one and has_many (but not the :through variants) associations. It also supplies inverse support for belongs_to associations where the inverse is a has_one and it's not a polymorphic.
Signed-off-by: Murray Steele <muz@h-lame.com >
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2009-05-04 15:27:39 -07:00
Emilio Tagua
d3042ef80c
Merge commit 'rails/master'
2009-05-04 19:23:34 -03:00
Mike Gunderloy
0dc17a2616
Minor update to RDoc for enumerable#sum
2009-05-04 17:22:40 -05:00
Xavier Noria
912da7fb98
tray and -> try to, thanks to FelixLeiter
2009-05-04 20:57:29 +02:00
codebrulee
eb201e64c0
Fixed Hash#from_xml with keys that are all caps.
...
Signed-off-by: Michael Koziarski <michael@koziarski.com >
2009-05-04 10:01:01 -07:00
Jeremy Kemper
8b6d2ef2f5
Merge branch 'master' of git@github.com:rails/rails
2009-05-04 08:35:35 -07:00
Chris Kampmeier
d3ee8756c8
Don't use #tap before Active Support is available, since older versions of ruby don't have native implementations
...
[#2603 state:committed]
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2009-05-04 08:32:25 -07:00
Ryan Bigg
13b4a9e8d7
Use the word 'action' over 'method'... is clearer and helps when people are grepping the document for the word 'method'
2009-05-04 14:08:30 +10:00
Joshua Peek
bcc4537f2a
Wrap dispatcher callbacks around the whole middleware chain. Kill unnecessary Reloader middleware.
2009-05-03 09:41:40 -05:00
Joshua Peek
e066019280
Show lazy middleware args in pretty print
2009-05-03 09:24:32 -05:00
Joshua Peek
11af089cee
Extract ActionController rescue templates into Rescue and ShowExceptions middleware.
...
This commit breaks all exception catching plugins like ExceptionNotifier. These plugins should be rewritten as middleware instead overriding Controller#rescue_action_in_public.
2009-05-02 23:02:22 -05:00
Jeremy Kemper
9047c9809d
Fix implicit ordering expectation
2009-05-02 16:41:50 -07:00
Aditya Chadha
80e161e647
Formatting fixes, take 3
2009-05-02 18:37:15 -04:00
Aditya Chadha
8f3a3c5544
Formatting fixes, take 2
2009-05-02 18:36:13 -04:00
Aditya Chadha
7a17ad3f2b
Merge branch 'master' of git@github.com:lifo/docrails
2009-05-02 18:32:45 -04:00
Aditya Chadha
5469a0be1a
Formatting fixes
2009-05-02 18:32:35 -04:00
Jeremy Kemper
1c6fcbfd2d
Fix implicit ordering expectation
2009-05-02 15:30:00 -07:00
Jeremy Kemper
186fee48c7
Merge branch 'master' of git@github.com:rails/rails
2009-05-02 15:21:19 -07:00
Jeremy Kemper
945bf9c254
Check for sibling Active Support first
2009-05-02 15:16:12 -07:00
Joshua Peek
24affdc88c
Deprecate Controller.process interface
2009-05-02 15:37:29 -05:00
Joshua Peek
f32cf44870
Switch functional tests to run through the rack interface instead of process
2009-05-02 15:29:18 -05:00
Joshua Peek
a8b75c480f
Functional test runner finalizes response just like the integration test runner. In both runners, the @response object will now behave the same.
...
Some functional tests will need to be updated if they are relying on preprocessed data on the response.
2009-05-02 14:57:40 -05:00
Joshua Peek
3900f4007e
Deprecate assert_redirect_to's partial hash matching
2009-05-02 14:23:44 -05:00
Emilio Tagua
d522b7ccf6
Revert "Work around count returning string (bug)"
...
This reverts commit 4bb6f77059 .
2009-05-02 12:59:49 -03:00
Yehuda Katz
72160d9f89
Implement FooController.action(:name)
...
* Rails actions are now Rack endpoints, and can be retrieved
via FooController.action(name) and called with an env
* Updated some tests that relied on the old internal
#process/#call implementation
2009-05-02 02:15:09 -07:00
Emilio Tagua
3fd467e9ed
Refactor to use arel_table method, and also use the same method name for instance and class methods.
2009-05-02 04:02:09 -03:00
Emilio Tagua
c9896884a4
Removed ARel table assignment
2009-05-02 03:40:31 -03:00
Emilio Tagua
5e790d368c
Merge commit 'rails/master'
2009-05-02 03:21:40 -03:00
Emilio Tagua
9f36431f58
Updated ARel
2009-05-02 03:15:19 -03:00
Yehuda Katz + Carl Lerche
ad2a1b5cb1
Get render :inline working
2009-05-01 18:17:08 -07:00
Yehuda Katz + Carl Lerche
7dd072d333
A few more tweaks to get new Base running old render tests again
2009-05-01 17:53:20 -07:00
Yehuda Katz + Carl Lerche
e046f36824
Renamed Base2 to Base and don't require old action_controller for new Base
2009-05-01 17:31:03 -07:00
Yehuda Katz + Carl Lerche
b1d34b3aa4
Starting to get new_base to run on old tests
2009-05-01 17:31:03 -07:00
Yehuda Katz + Carl Lerche
918b119bd3
Add support for stripping "layouts/" from the layout name
2009-05-01 17:31:02 -07:00
Yehuda Katz + Carl Lerche
b4903a8e34
Modify new_base to use String action_names for back-compat
2009-05-01 17:31:02 -07:00
Yehuda Katz + Carl Lerche
69fd669165
Committing the last changes before we start trying to get the old tests to pass on the new base
2009-05-01 17:31:02 -07:00
Yehuda Katz + Carl Lerche
4ee3e5b094
Ported over the concept of public instance methods on controller child classes as callable action methods
2009-05-01 17:31:02 -07:00
Yehuda Katz + Carl Lerche
d58b57a3ca
Move ContentType inline for now.
...
Trying to avoid premature proliferation of modules.
2009-05-01 17:31:02 -07:00
Yehuda Katz + Carl Lerche
b98e496c03
Support implicit and explicit content types
2009-05-01 17:31:02 -07:00
Yehuda Katz + Carl Lerche
49834e088b
Support implicit render and blank render
2009-05-01 17:31:02 -07:00
Yehuda Katz + Carl Lerche
0c3d9bc4c2
Ported over render :template tests
2009-05-01 17:31:01 -07:00
Yehuda Katz + Carl Lerche
4f68311685
Finished implementing render :text in Base2
2009-05-01 17:31:01 -07:00
Yehuda Katz + Carl Lerche
1b45991603
Renamed the new_base tests
2009-05-01 17:31:01 -07:00
Yehuda Katz + Carl Lerche
b692fceb6a
Renamed ActionController::AbstractBase to ActionController::Http
2009-05-01 17:31:01 -07:00
Yehuda Katz + Carl Lerche
059afb3a3a
Removed a stray method_missing in the new callbacks system
2009-05-01 17:31:01 -07:00
Yehuda Katz + Carl Lerche
8a4e77b420
OMG, a lot of work
2009-05-01 17:31:01 -07:00
Yehuda Katz + Carl Lerche
34509777fd
Makes new callbacks support keys with special characters
2009-05-01 17:31:01 -07:00
Ruy Asan
3be3470fab
Added routing test for irregular ID requirements and custom member action.
...
[#2595 state:committed]
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2009-05-01 15:02:32 -07:00
Ruy Asan
99c103be11
Fixed bug with polymorphic has_one :as pointing to an STI record
...
[#2594 state:committed]
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2009-05-01 14:47:56 -07:00
Alexander Podgorbunsky
db0bfe4ede
Default scope :order should be overridden by named scopes.
...
[#2346 state:committed]
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2009-05-01 14:44:24 -07:00
Pratik Naik
853c229bbd
Rename vendor/rack to vendor/rack-1.1.pre
2009-05-01 20:24:14 +01:00
Pratik Naik
432e631d5c
Vendor Rack edge ( commit : 815342a8e15db564b766f209ffb1e340233f064f )
2009-05-01 20:12:49 +01:00
Simon Tokumine
1b32f88209
bugfix for with_options routing documentation
2009-05-01 19:55:02 +01:00
steve
60a6284a46
Tests should use ActiveRecord::Base.connection.rollback_db_transaction to rollback a transaction
...
Signed-off-by: Pratik Naik <pratiknaik@gmail.com >
2009-05-01 16:00:09 +01:00
steve
5501b99a19
Ensure ActiveRecord::Base.connection_pool.with_connection creates a new connection only when needed [ #1752 state:resolved]
...
Signed-off-by: Pratik Naik <pratiknaik@gmail.com >
2009-05-01 14:58:10 +01:00
Ken Collins
b193f23390
Use table_exists? in #initialize_schema_migrations_table [ #1923 state:resolved]
...
Signed-off-by: Pratik Naik <pratiknaik@gmail.com >
2009-05-01 14:24:40 +01:00
Joshua Peek
664ae187a9
Update some old tests to use AC TestProcess
2009-04-30 23:46:35 -05:00
Joshua Peek
05bd863c02
alias method chain process with test
2009-04-30 23:46:35 -05:00
Joshua Peek
1fcc7dbcc8
Move TestRequest#query_parameters into AD TestRequest
2009-04-30 23:46:34 -05:00
Jeremy Kemper
dc9f53b05b
Selectively require rake sshpublisher so full gem isn't required
2009-04-30 21:02:23 -07:00
Jeremy Kemper
7a7382b213
Selectively require rake sshpublisher so full gem isn't required
2009-04-30 21:02:11 -07:00
Jeremy Kemper
9b852af497
Explicitly require builder for to_xml
2009-04-30 20:34:11 -07:00
Jeremy Kemper
509c389bf8
Explicitly require builder for to_xml
2009-04-30 20:33:50 -07:00
Jeremy Kemper
4bb6f77059
Work around count returning string (bug)
2009-04-30 20:32:19 -07:00
Jeremy Kemper
59b58dfa89
Use public submodule url
2009-04-30 20:31:47 -07:00
Jeremy Kemper
64c9a40137
Make ruby-debug optional
2009-04-30 20:31:32 -07:00
Joshua Peek
0fa1e75d41
Set rack.input instead of RAW_POST_DATA in TestRequest
2009-04-30 20:04:55 -05:00
Joshua Peek
261ec996de
Missed stray @request_uri
2009-04-30 19:36:18 -05:00
Joshua Peek
a6fff94baf
Move TestRequest cookies accessor into AD TestRequest
2009-04-30 19:23:50 -05:00
Joshua Peek
d54604c352
Depend on unreleased rack 1.1
2009-04-30 19:10:05 -05:00
Jeremy Kemper
6ae839bf48
Merge branch 'master' of git@github.com:rails/rails
2009-04-30 16:45:39 -07:00
John F. Douthat
e59835bd09
Fix action-cached exception responses.
...
Methods raising ActiveRecord::RecordNotFound were returning 404 on first request and 200 OK with blank body on subsequent requests.
[#2533 state:committed]
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2009-04-30 16:43:01 -07:00
Jeremy Kemper
f0b9e28619
Fix render :json => nil [ #2589 state:resolved]
2009-04-30 16:34:00 -07:00
Joshua Peek
00d1a57e9f
Start moving TestRequest and TestResponse into ActionDispatch
2009-04-30 17:26:03 -05:00
Joshua Peek
64e66cf161
Vendor new Rack::Mock changes
2009-04-30 14:40:46 -05:00
Joshua Peek
9bac470c7a
Group integration test helpers and delegate other helpers to request and response objects
2009-04-30 14:28:42 -05:00
Joshua Peek
ba9887c9c0
Switch to action_dispatch rack namespace
2009-04-30 13:45:12 -05:00
Joshua Peek
7b3b7cb2ab
Move generic assertions into ActionDispatch
2009-04-30 11:55:53 -05:00
Emilio Tagua
ca0530a53f
exists? method now uses ARel
2009-04-30 13:47:51 -03:00
Joshua Peek
98dd726687
Test::Unit work arounds are handled by ActiveSupport
2009-04-30 11:42:01 -05:00
Joshua Peek
988513ac7a
Framework backtrace cleaning is handled by ActiveSupport now
2009-04-30 11:42:01 -05:00
Emilio Tagua
5b61168aaf
Added arel_attributes_values methods, refactored locking and AR#update to use this method
2009-04-30 13:21:13 -03:00
Emilio Tagua
0cf54f9dd8
Merge commit 'rails/master'
2009-04-30 10:10:42 -03:00
Pratik Naik
5f24ed718f
Merge commit 'mainstream/master'
2009-04-30 13:29:33 +01:00
Pratik Naik
35ca877abc
Minor edits
2009-04-30 13:29:13 +01:00
Jeremy Kemper
79420e71e0
Work around Float faux precision
2009-04-30 01:33:07 -07:00
Jeremy Kemper
7eef11eb65
Convert params keys to strings
2009-04-29 23:29:11 -07:00
Jeremy Kemper
091965c0fc
Prefer behavior check to RUBY_VERSION to catch 1.8 backports
2009-04-29 23:12:34 -07:00
Emilio Tagua
b0bd4f45fa
Merge commit 'rails/master'
2009-04-29 19:47:21 -03:00
Emilio Tagua
db892ea775
Fix duplicated test name
...
[#2581 state:committed]
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2009-04-29 15:46:43 -07:00
Emilio Tagua
19d2ff83db
Calculations now use Arel to construct the query.
...
Implemented other methods in AR::Base with Arel support.
2009-04-29 19:39:53 -03:00
Mike Gunderloy
33b9d1aafd
Tweak to credits.
2009-04-29 12:50:30 -05:00
Pratik Naik
30e6a8a83e
More templates
2009-04-29 18:19:27 +01:00
David Dollar
7149ddd2a1
Additional tests for the gem subsystem
...
* test_gem_ignores_development_dependencies
* test_gem_guards_against_duplicate_unpacks
* test_gem_does_not_unpack_framework_gems
[#2236 state:committed]
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2009-04-29 08:07:57 -07:00
Jeremy Kemper
d6c584618f
Merge branch 'master' of git@github.com:rails/rails
2009-04-28 23:19:53 -07:00
David Dollar
599f2cfb4a
Attempt to deal with more cases of gems with native components.
...
This commit adds a rudimentary check for 'unbuilt' gems, so that we can abort
the application load if there are any gems that have native components that
have not yet been built.
The rake task gems:build has now only builds 'unbuilt' gems as a result.
The rake task gems:build:force has been added to deal with cases of incomplete
builds, or any case where you need to force the build of all of your gems.
Changes the gems:build task to get its gem list by parsing directory entries
in vendor/gems, which sidesteps the chicken/egg issues involved with having a
gem unpacked into vendor/gems without before its native bits are compiled.
[#2266 state:committed]
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2009-04-28 23:16:47 -07:00
Joshua Peek
c0a372ba87
Deprecate template, session, assigns, and layout accessors on response object. Instead access them through the controller instance. This mainly affects functional test assertions.
2009-04-28 23:29:46 -05:00
Joshua Peek
8925e89c63
Deprecate response.assigns
2009-04-28 23:29:46 -05:00
Joshua Peek
d63b42da36
Move header injection back into integration tests
2009-04-28 23:29:46 -05:00
Joshua Peek
afa7d7ff05
Fix validate_request method name
2009-04-28 23:29:45 -05:00
Jeremy Kemper
acd5db300b
Rejig active support dependencies to behave better with the boot process
2009-04-28 18:25:35 -07:00
Jeremy Kemper
b825bef74c
Fix missing core extension dependencies
2009-04-28 17:58:51 -07:00
Emilio Tagua
4246a79a99
Show executed queries when assert_sql assertion fails [ #2573 state:resolved]
...
Signed-off-by: Pratik Naik <pratiknaik@gmail.com >
2009-04-28 22:11:47 +01:00
Dallas Taylor
8fa1235c27
changed sentence
2009-04-28 14:14:03 +01:00
Sunny Ripert
24b78dfcd0
Missing tiny quote
2009-04-28 15:01:41 +02:00
Xavier Noria
348d7f8a84
fixes redirect codes in layouts and rendering guide, thanks to Loren Norman
2009-04-28 09:48:27 +02:00
Aditya Chadha
57f031cba2
Merge branch 'master' of git@github.com:lifo/docrails
2009-04-27 22:01:36 -04:00
Aditya Chadha
eeb12d6ad5
Formatting updates per lifo
2009-04-27 22:01:22 -04:00
Yehuda Katz + Carl Lerche
38bd60eae4
Makes new callbacks support keys with special characters
2009-04-27 18:16:55 -07:00
Yehuda Katz + Carl Lerche
ab83db9d06
Fixes ActionMailer to work with the ActionView refactoring
2009-04-27 12:34:25 -07:00
Yehuda Katz + Carl Lerche
cecafc52ee
Refactor ActionView::Template
...
ActionView::Template is now completely independent from template
storage, which allows different back ends such as the database.
ActionView::Template's only responsibility is to take in the
template source (passed in from ActionView::Path), compile it,
and render it.
2009-04-27 11:49:11 -07:00
Eloy Duran
da3c21ead5
Ensure the parent record is always saved when the child is invalid. [ #2249 state:resolved]
...
Signed-off-by: Pratik Naik <pratiknaik@gmail.com >
2009-04-27 19:25:27 +01:00
Joshua Peek
21aa32692c
Delegate controller.session to request.session and deprecate response session
2009-04-27 13:11:17 -05:00
Luke Amdor
4df9680a6f
Removed reference in documentation of form_authenticity_token to deprecated :secret option of protect_from_forgery
2009-04-27 12:38:14 -05:00
Xavier Noria
ba84025eb4
fixes an example from the previous commit
2009-04-27 19:03:20 +02:00
Xavier Noria
2e530638ee
adds timestamps in examples of generated asset paths, and documents this bit in a few helpers
2009-04-27 19:00:36 +02:00
Dallas Taylor
8e93e929a1
Merge branch 'master' of git://github.com/lifo/docrails
2009-04-27 17:46:18 +01:00
Jeremy Kemper
dde063507a
Can't please them all
2009-04-27 09:29:17 -07:00
Sean Schofield
de9ea3bf25
Made a minor syntax correction.
2009-04-27 11:05:38 -04:00
Ryan Bigg
5ec91ef5ec
Add documentation for respond_to's any method
2009-04-27 21:34:38 +10:00
Xavier Noria
e5bebbbeff
bring index actions back in caching guide, REST conventions are encouraged and surrounding text assumes index
2009-04-27 10:18:37 +02:00
Jeremy Kemper
c2b4da1c42
Sufficient to test that multipart/mixed wasn't parsed to a hash
2009-04-27 00:17:02 -07:00
Jeremy Kemper
a88ddf8cc3
Don't return bare string as rack body
2009-04-27 00:00:03 -07:00
Jeremy Kemper
e44cd41620
Make it clearer that session is nil
2009-04-26 23:59:17 -07:00
Jeremy Kemper
6e3e00219b
Fix differing rails_to_json arity
2009-04-26 20:26:44 -07:00
Jeremy Kemper
706f313231
Use Array.wrap
2009-04-26 20:24:45 -07:00
Aditya Chadha
4d1e21e8cb
Fix typos in submitted patch
2009-04-26 23:07:40 -04:00
Jeremy Kemper
f58c322e7e
Use __send__ for BasicObject friendliness
2009-04-26 20:05:17 -07:00
Jeremy Kemper
ee46ffedb8
Now that we have a separate internal rails_to_json, use a separate circular reference stack instead of sticking it in the options hash
2009-04-26 20:04:47 -07:00
Jeremy Kemper
678385d307
Use javascript_object_for
2009-04-26 19:59:22 -07:00
Jeremy Kemper
5cef0cbad2
Check for to_str rather than String
2009-04-26 19:08:04 -07:00
Jeremy Kemper
f5b4a9d02b
Array splitting strings on newlines is deprecated
2009-04-26 18:27:41 -07:00
Jeremy Kemper
1850aea7fc
Not sure why Request#session is missing
2009-04-26 18:26:06 -07:00
Jeremy Kemper
f7d7dc5aa8
Use session= writer methods
2009-04-26 17:19:14 -07:00
Dallas Taylor
9d9adc998d
fixed typo and clarified sentence
2009-04-27 01:05:22 +01:00
Jeremy Kemper
8aaed3d456
Convert encoding before escaping
2009-04-26 16:21:57 -07:00
Stephen Bannasch
1d71a34afa
add JRuby-JDOM backend for XmlMini
...
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2009-04-26 16:13:55 -07:00
Jeremy Kemper
3f63202781
Don't assume :params is a Hash
2009-04-26 16:04:29 -07:00
Jeremy Kemper
c9d9bd7227
Check for to_str rather than String
2009-04-26 16:04:11 -07:00
Jeremy Kemper
ea712364e2
Don't undefine object_id
2009-04-26 15:56:08 -07:00
Jeremy Kemper
3bd32754e2
Privatize rails_to_json
2009-04-26 15:54:28 -07:00
Jeremy Kemper
4a8d2ef0a5
Extract json string escaping
2009-04-26 15:53:59 -07:00
Jeremy Kemper
5577d561f9
Merge branch 'master' of git@github.com:rails/rails
2009-04-26 15:18:51 -07:00
Jeremy Kemper
8d64085138
Only Object to_json alias is needed. Prefer nil options.
2009-04-26 15:18:33 -07:00
Jeremy Kemper
be7e21a85c
Qualify toplevel constant references since we're in a BasicObject
2009-04-26 15:05:50 -07:00
Jeremy Kemper
da3a80dd4f
Track object ids so the objects needn't respond to ==
2009-04-26 15:04:02 -07:00
Joshua Peek
0494909679
Inherit TestSession from Session::AbstractStore and add indifferent access to Session::AbstractStore.
2009-04-26 14:33:57 -05:00
Joshua Peek
c8919f4c7c
Require an ActionDispatch::Request to use response assertions
2009-04-26 11:52:45 -05:00
Joshua Peek
6940c0de12
Unify functional and integration tests cookie helpers
2009-04-26 11:37:11 -05:00
Hongli Lai (Phusion)
3cb97aeea8
Fix environment variable testing code in failsafe.rb.
...
Signed-off-by: Joshua Peek <josh@joshpeek.com >
2009-04-26 11:23:10 -05:00
Hongli Lai (Phusion)
cd9bb88eef
Remove reference to Rack::RewindableInput, which has been removed a while ago.
...
Signed-off-by: Joshua Peek <josh@joshpeek.com >
2009-04-26 11:22:03 -05:00
Joshua Peek
82bc768dad
Fix typo in stale session check [ #2404 state:resolved]
2009-04-26 11:19:42 -05:00
Joshua Peek
5ea8d40156
Deprecate response.redirect_url_match?, use assert_match instead.
2009-04-26 11:16:14 -05:00
Joshua Peek
5352a2417b
Move useful response test helpers into request
2009-04-26 11:12:33 -05:00
Joshua Peek
dbbe2e74ff
Create a new file for response tests
2009-04-26 10:26:53 -05:00
Yehuda Katz
d0ace15c01
Updated for Rack 1.0
2009-04-25 12:33:14 -07:00
Joshua Peek
4f412a10b6
Remove RewindableInput middleware since all input MUST be rewindable according to a recent change in the Rack 1.0 SPEC
2009-04-25 14:04:03 -05:00
Joshua Peek
b69da86ea5
Remove vendored version of Rack
2009-04-25 13:56:37 -05:00
Joshua Peek
044794fc9e
Remove pending rack specifications until they are official
2009-04-25 13:41:30 -05:00
Dana Jones
1703fbbcef
Minor changes to scaffold code, addition of dependent destroy example.
2009-04-25 08:56:18 -05:00
Karel Minarik
4f623f5f89
Better wording of environment.rb example code, thanks Paul Gillard
...
See https://rails.lighthouseapp.com/projects/16213/tickets/23-rails-i18
2009-04-25 11:32:40 +02:00
Karel Minarik
7163b64d32
Consolidate config/locale vs config/locales issue. [ #16213 ]
2009-04-25 11:28:20 +02:00
Jeremy Kemper
dc2caea9dc
test uses Pathname
2009-04-24 23:17:15 -07:00
Joshua Peek
dd2ed32418
Start to integrate some of the features in Rack::Test.
...
Eventually commit ActionDispatch::Test::MockRequest and ActionDispatch::Test:: UploadedFile upstream.
2009-04-24 20:24:54 -05:00
Emilio Tagua
090539604b
construct_finder_sql now use Arel
2009-04-24 21:48:45 -03:00
Emilio Tagua
0e113a040d
Refactored locking update
2009-04-24 17:32:16 -03:00
Emilio Tagua
649fd1058f
Merge commit 'rails/master'
2009-04-24 17:28:31 -03:00
Emilio Tagua
345e686d83
Changed locking to use Arel. Arel updated
2009-04-24 17:27:05 -03:00
Emilio Tagua
c0f66b764e
Added ruby-debug
2009-04-24 17:26:34 -03:00
Jeremy Kemper
cbcc0ca57b
Use Symbol#to_proc in rails plugin internals
2009-04-24 10:41:45 -07:00
Emilio Tagua
a841cd2503
Fix models load order to be able to run unit tests.
...
[#2550 state:committed]
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2009-04-23 16:02:11 -07:00
Emilio Tagua
e428c75d2b
Remove connection method definition, since it's called just once.
2009-04-23 18:59:35 -03:00
Emilio Tagua
7958308ef6
More progress on migrations. Arel updated.
2009-04-23 18:54:04 -03:00
Emilio Tagua
d8f99c36ba
Added Arel integration to migration's version update table
2009-04-23 13:55:42 -03:00
Emilio Tagua
0d9f1da955
Arel updated
2009-04-23 13:55:02 -03:00
Emilio Tagua
a934bbbb28
Removed blank lines
2009-04-23 13:54:38 -03:00
Emilio Tagua
fdcd81970e
Require Arel
2009-04-23 13:54:00 -03:00
Emilio Tagua
3b43d1801e
Added arel as a submodule. This is temporary and will make development/testing easier.
2009-04-23 13:50:18 -03:00
Pratik Naik
ae812c0a7b
Merge commit 'mainstream/master'
2009-04-23 14:34:37 +01:00
Pratik Naik
67f30fd963
String interpolation conditions
2009-04-23 14:25:35 +01:00
rick
3c4c6bd0df
* Add pluggable JSON backends with support for the JSON gem. [rick]
...
Example: ActiveSupport::JSON.backend = "JSONGem"
All internal Rails JSON encoding is now handled by ActiveSupport::JSON.encode(). Use of #to_json is not recommended, as it may clash with other libraries that overwrite it. However, you can recover Rails specific functionality
if you really want to use #to_json.
gem 'json'
ActiveSupport::JSON.backend = "JSONGem"
class ActiveRecord::Base
alias to_json rails_to_json
end
2009-04-23 00:08:40 -07:00
Jeremy Kemper
bab2bfa692
Removed rest of Symbol#to_proc from railties tests
2009-04-22 19:52:28 -07:00
Jeremy Kemper
236169e85e
Missed one
2009-04-22 19:50:24 -07:00
Jeremy Kemper
d23ab4fbb6
Remove Symbol#to_proc dependency
2009-04-22 19:35:58 -07:00
Jeremy Kemper
85b1a55f6d
Merge branch 'master' of git@github.com:rails/rails
2009-04-22 18:54:55 -07:00
Jeremy Kemper
f28bd9557c
Fix dependencies revealed by testing in isolation
2009-04-22 18:54:13 -07:00
Yehuda Katz + Carl Lerche
0a132c2fe1
Refactor ActionView::Path
...
* Decouple from ActionController and ActionMailer
* Bring back localization support.
* Prepare to decouple templates from the filesystem.
* Prepare to decouple localization from ActionView
* Fix ActionMailer to take advantage of ActionView::Path
2009-04-22 17:24:41 -07:00
Jeremy Kemper
5c4ba6e3fc
new_callbacks core extensions
2009-04-22 17:17:31 -07:00
Pratik Naik
5a1fe9039b
Merge commit 'mainstream/master'
2009-04-23 01:09:27 +01:00
Jeremy Kemper
b2d6fdae35
Fix tests on 1.9
2009-04-22 17:07:04 -07:00
Jeremy Kemper
7f6779c1d5
Merge branch 'master' into cherry
...
Conflicts:
activesupport/lib/active_support.rb
2009-04-22 16:53:58 -07:00
Jeremy Kemper
6fee981fa4
Opt in to JSON
2009-04-22 16:48:58 -07:00
Jeremy Kemper
f5d720fb96
Opt in to Dependencies
2009-04-22 16:42:14 -07:00
Jeremy Kemper
ab321268f8
No more free lunch
2009-04-22 16:10:49 -07:00
Xavier Noria
3384f073e3
initial skeleton for extensions in AS guide, just bootstrapping it may change
2009-04-23 00:16:42 +02:00
Sean Bryant
e8071d7c64
Fix my previous commit. Don't say it's been removed when it really
...
hasn't.
Also change the assert reference to be more consistent with the rest
of the documentation.
2009-04-22 13:58:14 -04:00
Jeremy Kemper
42a06d2d62
stdlib autoloads were hanging on 1.9.1
2009-04-22 09:10:48 -07:00
Sean Bryant
2d9c37d169
Add a note about assert_valid(record) being deprecated.
2009-04-22 11:07:41 -04:00
Pratik Naik
5f3f100ce2
Merge branch 'master' into active_model
...
Conflicts:
activeresource/lib/active_resource/validations.rb
2009-04-22 15:26:03 +01:00
Jeremy Kemper
ca49299434
Get Active Model in the mix
2009-04-22 01:02:54 -07:00
Jeremy Kemper
a27192f49a
Divert CoreExtensions mention in docs
2009-04-22 00:47:25 -07:00
Jeremy Kemper
b70239b0cf
Convert string extension modules to class reopens
2009-04-22 00:45:39 -07:00
Jeremy Kemper
35afad620b
ActiveSupport.core_ext bridge util no longer used
2009-04-22 00:34:24 -07:00
Jeremy Kemper
e6eb941d1b
Switch last module core extension to class reopen
2009-04-22 00:33:00 -07:00
Jeremy Kemper
e9ed44af88
Merge branch 'master' into cherry
2009-04-22 00:23:47 -07:00
Jeremy Kemper
6ee8329af6
Merge branch 'master' of git@github.com:rails/rails
2009-04-22 00:22:25 -07:00
Jeremy Kemper
70c544df71
Rack::Utils.body_to_s doesn't exist in 1.0
2009-04-22 00:22:07 -07:00
Joshua Peek
380431e4ed
Fix test_rescue_routing_exceptions when running with rake
2009-04-21 21:11:23 -05:00
Joshua Peek
0b92bb97c1
refactor some coupled rescue tests
2009-04-21 20:41:31 -05:00
Joshua Peek
fc5c1b0e90
Session tests belong under dispatch folder
2009-04-21 19:57:18 -05:00
Jeremy Kemper
5afc2abee6
Merge branch 'master' into cherry
2009-04-21 16:03:21 -07:00
Jeremy Kemper
f49e344128
Reinstate Base#render_to_string. Introduce AbstractController#render_to_string which stringifies render_to_body.
2009-04-21 16:02:30 -07:00
hardbap
4c21026da4
Update ActionMailer guide's '2.3 Complete List of Action Mailer User-Settable Attributes' to show that the attribute 'cc' and 'bcc' can take a string or an Array of strings.
2009-04-21 10:57:20 -07:00
Alex Pooley
504d16ccdf
Add microsecond support for sqlite adapter [ #1982 state:resolved]
...
Signed-off-by: Pratik Naik <pratiknaik@gmail.com >
2009-04-21 18:05:07 +01:00
Stephen Celis
7a99dc0ac2
Update rails:template task to expand file paths [ #2528 state:resolved]
...
Signed-off-by: Pratik Naik <pratiknaik@gmail.com >
2009-04-21 17:44:35 +01:00
Pratik Naik
d7d93cdb62
Fix nginx config in ci setup notes [Chad Woolley] [ #2290 state:resolved]
2009-04-21 17:31:26 +01:00
Mike Gunderloy
398b07e655
Remove excess mocking from polymorphic_url tests [ #2330 state:resolved]
...
Signed-off-by: Pratik Naik <pratiknaik@gmail.com >
2009-04-21 14:32:52 +01:00
Pratik Naik
2e6d1bf43e
Change table to prevent copying indexes on sqlite2
2009-04-21 13:28:49 +01:00
Pratik Naik
2381f6f3dc
Specify :group with the table name for it to work on sqlite3
2009-04-21 13:11:56 +01:00
Pratik Naik
6513dde490
Fix tests for sqlite3 3.6.xx
2009-04-21 13:06:26 +01:00
Max Lapshin
f3ac4f387d
Fixed dumping from postgresql columns in index in wrong order. [ #2515 state:resolved]
...
Signed-off-by: Tarmo Tänav <tarmo@itech.ee >
2009-04-21 11:44:13 +01:00
Scott Woods
64b33b6cf9
Quote table names when casting to regclass so that capitalized tables are supported. [ #2418 state:resolved]
...
Signed-off-by: Tarmo Tänav <tarmo@itech.ee >
2009-04-21 11:43:38 +01:00
Max Lapshin
cdcd638c2f
Fixed wrong quoting of index names in postgres [ #2402 state:resolved]
...
Signed-off-by: Tarmo Tänav <tarmo@itech.ee >
2009-04-21 11:42:40 +01:00
Jeremy Kemper
696375ac62
Merge branch 'master' into cherry
2009-04-20 20:06:30 -07:00
Jeremy Kemper
b10fb7e7bc
Merge branch 'master' of git@github.com:rails/rails
2009-04-20 18:34:43 -07:00
Jeremy Kemper
685a53a360
Merge branch 'master' into cherry
...
Conflicts:
activesupport/CHANGELOG
activesupport/lib/active_support/core_ext/class/delegating_attributes.rb
activesupport/lib/active_support/core_ext/hash/conversions.rb
activesupport/lib/active_support/core_ext/module/attribute_accessors.rb
activesupport/lib/active_support/core_ext/string/multibyte.rb
activesupport/lib/active_support/core_ext/time/calculations.rb
activesupport/lib/active_support/deprecation.rb
2009-04-20 18:31:40 -07:00
Jeremy Kemper
db05c73fb6
Move AS::Duration autoload to core/time/autoload
2009-04-20 18:14:39 -07:00
Barry Hess
81d595c6c0
Update ActionMailer guide's 'Sending Multipart Emails with Attachments' section to show explicitly which order text/plain and text/html parts must be in as well as the proper way to define the multipart/alternative part.
2009-04-20 12:54:45 -05:00
Pratik Naik
de0ea38663
Ensure :dependent => :delete_all works for association with hash conditions
2009-04-20 18:12:40 +01:00
Pratik Naik
489abfd3b2
Ensure JoinAssociation uses aliased table name when multiple associations have hash conditions on the same table
2009-04-20 13:51:11 +01:00
Jeremy Kemper
164a94d0bc
Clearer String#first and #last edge cases. Fix that 'foo'.first(0) == 'foo' instead of ''
2009-04-20 00:40:15 -07:00
Jeremy Kemper
5d84c732ee
Treating strings as enumerable is deprecated
2009-04-20 00:32:14 -07:00
Erica Kwan
20dba65eba
Formatted some symbols in Active Support Guide
2009-04-19 14:27:38 -07:00
Mike Gunderloy
0271d9bda7
Added touch to associations guide
2009-04-19 07:56:07 -05:00
Mike Gunderloy
5bc635b8cd
Remove named scopes from query guide contents, separate guide is coming
2009-04-19 06:44:46 -05:00
José Valim
845cef3e8b
Replaced TimeZone references by ActiveSupport::TimeZone
2009-04-18 22:30:30 +02:00
Xavier Noria
b82f3bcf39
fixes email/radio mismatch reported by Marek in LH
2009-04-18 16:26:36 +02:00
Xavier Noria
a8a5b17df0
adds a missing word
2009-04-18 11:52:14 +02:00
Xavier Noria
16740047de
Initial Active Support guide
2009-04-18 11:47:38 +02:00
Jeremy Kemper
4f63e84843
Autoload I18n simple backend
2009-04-17 22:24:36 -07:00
Jeremy Kemper
f40eb52566
Autoload YAML and StringScanner for JSON decoding
2009-04-17 22:24:08 -07:00
Jeremy Kemper
2c5c2717cb
Autoload StringScanner for pre-1.9 String#each_char
2009-04-17 21:58:18 -07:00
Jeremy Kemper
595e03336f
Remove rarely-used DRb cache store
2009-04-17 21:53:17 -07:00
Jeremy Kemper
bd84b82018
Eliminate Pathname extensions
2009-04-17 21:49:57 -07:00
Jeremy Kemper
727e9dc18a
Dice up ActiveSupport::Deprecation
2009-04-17 21:29:30 -07:00
Jeremy Kemper
3202671dc9
Fix core/all require of adjacent core features
2009-04-17 21:20:57 -07:00
Jeremy Kemper
151348824e
Fix core/time require of DateTime core extensions
2009-04-17 21:17:55 -07:00
Mislav Marohnić
7ce0778a15
Always buffer rack.input if it is not rewindable
...
Signed-off-by: Joshua Peek <josh@joshpeek.com >
2009-04-17 21:53:44 -05:00
Jeremy Kemper
a22a778f86
render_for_text pushes a body part instead of replacing the whole body
2009-04-17 21:33:09 -05:00
Jared Giles
9f8b99ba57
Updated migration section to mention that SQLite now supports transactional migrations
2009-04-17 21:06:16 -05:00
Mislav Marohnić
8423bb6a68
Improve rewindable input test coverage so tests fail when you remove the middleware
...
Signed-off-by: Joshua Peek <josh@joshpeek.com >
2009-04-17 19:35:03 -05:00
Jeremy Kemper
1414e2afbb
Don't set Content-Length in Base#response_body= since body may be any Rack-compatible body. Leave it up to the content length middleware.
2009-04-17 18:36:28 -05:00
Jeremy Kemper
df42d26f99
Rename render_to_string to render_to_body since it may return any Rack-compatible body, not just strings
2009-04-17 18:34:49 -05:00
Jeremy Kemper
ecdc0643f2
Merge branch 'master' of git@github.com:rails/rails
2009-04-17 13:45:18 -05:00
Jeremy Kemper
60896ca6f4
Clearer String#first and #last edge cases. Fix that foo.first(0) == instead of foo.
2009-04-17 13:44:59 -05:00
lifo
5b92dcb675
Merge docrails
2009-04-17 14:28:46 +01:00
lifo
938eb01c24
Initial template guide
2009-04-17 14:23:32 +01:00
lifo
20401783cf
Merge commit 'mainstream/master'
...
Conflicts:
actionpack/lib/action_controller/base.rb
railties/guides/source/caching_with_rails.textile
2009-04-17 14:06:26 +01:00
David Heinemeier Hansson
abb899c54e
Added :touch option to belongs_to associations that will touch the parent record when the current record is saved or destroyed [DHH]
2009-04-16 17:25:55 -05:00
David Heinemeier Hansson
fdb61f02c5
Added ActiveRecord::Base#touch to update the updated_at/on attributes with the current time [DHH]
2009-04-16 16:48:37 -05:00
Carl Lerche & Yehuda Katz
b49027e188
Make more Template methods public to make ActionMailer tests pass
2009-04-16 11:57:27 -07:00
Ross Kaffenburger and Bryan Helmkamp
256b0ee8e3
Don't check authenticity tokens for any AJAX requests
2009-04-15 16:04:21 -07:00
Carl Lerche & Yehuda Katz
3c1187699a
Makes rails-dev-boost work again
2009-04-14 18:32:31 -07:00
Joshua Peek
109a3876f0
Move middleware stack out of utils folder
2009-04-14 18:32:31 -07:00
Joshua Peek
c2511f936e
Make dispatcher instances immutable
2009-04-14 18:32:31 -07:00
Joshua Peek
d7751036fa
Final blow to CGI
2009-04-14 18:32:31 -07:00
Joshua Peek
cf44788b06
We aren't using UploadedStringIO and UploadedTempfile anymore
2009-04-14 18:32:31 -07:00
Carl Lerche & Yehuda Katz
d39f5f18bb
Move all Templates methods not used by other class into private to
...
define surface area of the class.
2009-04-14 18:32:31 -07:00
Joshua Peek
9954494397
Move MimeResponds into base folder
2009-04-14 17:08:38 -05:00
Joshua Peek
d7396b5ca9
Move reloader middleware in ActionDispatch
2009-04-14 17:06:32 -05:00
Joshua Peek
1d2686517c
Session management belongs in base folder
2009-04-14 17:02:38 -05:00
Joshua Peek
97a88a91cb
Move middleware stack out of utils folder
2009-04-14 16:56:45 -05:00
Joshua Peek
13bb6a9a99
Backwords compat alias for ActionController::Request and ActionController::Response
2009-04-14 16:55:10 -05:00
Joshua Peek
ef08aa45b1
Use rack's status code list as a base
2009-04-14 16:47:03 -05:00
Joshua Peek
c1b4a5eb56
Make dispatcher instances immutable
2009-04-14 16:21:06 -05:00
Joshua Peek
4a3afe0b4f
Final blow to CGI
2009-04-14 16:18:24 -05:00
Joshua Peek
11d4bfb18c
We aren't using UploadedStringIO and UploadedTempfile anymore
2009-04-14 15:56:13 -05:00
Joshua Peek
4839fe2e82
Move bundled rack into ActionDispatch
2009-04-14 15:52:23 -05:00
Jeremy Kemper
1120aaceae
Fix requires so tests run
2009-04-14 10:53:46 -05:00
Johan Andersson
f99e9f627b
Examples should be preceded with four equal signs.
2009-04-14 08:35:03 +00:00
Carl Lerche & Yehuda Katz
d9afc51391
Rails server boots again
2009-04-13 17:16:07 -07:00
Carl Lerche & Yehuda Katz
647b83d50c
Resurrecting 1.9 compatibility.
2009-04-13 16:56:04 -07:00
Carl Lerche & Yehuda Katz
906aebceed
Bring abstract_controller up to date with rails/master
...
Resolved all the conflicts since 2.3.0 -> HEAD. Following is a list
of commits that could not be applied cleanly or are obviated with the
abstract_controller refactor. They all need to be revisited to ensure
that fixes made in 2.3 do not reappear in 3.0:
2259ecf368
AR not available
* This will be reimplemented with ActionORM or equivalent
06182ea02e
implicitly rendering a js response should not use the default layout
[#1844 state:resolved]
* This will be handled generically
893e9eb995
Improve view rendering performance in development mode and reinstate
template recompiling in production [#1909 state:resolved]
* We will need to reimplement rails-dev-boost on top of the refactor;
the changes here are very implementation specific and cannot be
cleanly applied. The following commits are implicated:
199e750d46
3942cb406e
f8ea9f85d4
e3b166aab3
ae9f258e03
44423126c6
0cb020b4d6
workaround for picking layouts based on wrong view_paths
[#1974 state:resolved]
* The specifics of this commit no longer apply. Since it is a two-line
commit, we will reimplement this change.
8c5cc66a83
make action_controller/layouts pick templates from the current instance's
view_paths instead of the class view_paths [#1974 state:resolved]
* This does not apply at all. It should be trivial to apply the feature
to the reimplemented ActionController::Base.
87e8b16246
fix HTML fallback for explicit templates [#2052 state:resolved]
* There were a number of patches related to this that simply compounded
each other. Basically none of them apply cleanly, and the underlying
issue needs to be revisited. After discussing the underlying problem
with Koz, we will defer these fixes for further discussion.
2009-04-13 15:18:45 -07:00
Xavier Noria
3d06eca01e
in 2.3 release notes, fix name of a rake task
2009-04-13 23:49:38 +02:00
Mike Gunderloy
7649ef08a5
Fix typo in release notes
2009-04-11 18:57:30 -05:00
Carl Lerche & Yehuda Katz
2036d3ba75
Revert rspec-runner change. TODO: Add back support for the rspec T::U runner.
2009-04-09 12:33:39 -07:00
Yehuda Katz and Carl Lerche
1aadafda8d
Updated old AC::Base for small changes to AV
2009-04-08 17:33:41 -07:00
Yehuda Katz and Carl Lerche
6c05b5e938
Temporarily modifies setup to call super directly. This can support more T::U runners.
2009-04-08 17:33:41 -07:00
Kyle
192110544d
Fixed confusing wording in ActionCachePath
2009-04-08 16:31:04 -06:00
Yehuda Katz and Carl Lerche
91402bdd31
Reverts changes made to AS::TC
2009-04-08 10:10:06 -07:00
Mike Gunderloy
986b3f805d
Fix typos in date helper rdoc (via Mike Breen)
2009-04-08 06:11:20 -05:00
Mike Gunderloy
b064f6ace8
Fix grammar error in caching docs (via pblka)
2009-04-08 06:08:32 -05:00
Jeremy Kemper
9cc8a75d84
Insert in sorted order to avoid TimeZone sort
2009-04-07 21:03:40 -07:00
Jeremy Kemper
f093088433
autoload Pathname
2009-04-07 20:52:57 -07:00
Jeremy Kemper
4a5f89fa64
Unneeded require
2009-04-07 20:18:09 -07:00
Yehuda Katz and Carl Lerche
3cecbc21e3
Get Base2 layouts to work :)
2009-04-07 17:57:20 -07:00
Yehuda Katz and Carl Lerche
95c9718118
Layouts work in AbstractController. Add support for the rspec runner for T::U
2009-04-07 15:54:02 -07:00
Yehuda Katz and Carl Lerche
c1aa5b0e14
Add depends_on, use, and setup to abstract up ideas about module inheritance.
2009-04-07 14:57:18 -07:00
Doug McInnes
c877857d59
Fix for TestResponse.cookies returning cookies unescaped [ #1867 state:resolved]
...
Signed-off-by: David Heinemeier Hansson <david@loudthinking.com >
2009-04-07 13:21:41 -05:00
Mike Gunderloy
2e56ce8f8c
Revert "Changes to indicate release notes refer to most recent point releases,"
...
Rails numbering: 2.2.2 and 2.3.2 are the release versions, so original wording is fine. Release notes refer to the first *release* version, not the the earlier RC versions.
This reverts commit 858dbeb4fd .
2009-04-07 11:53:49 -05:00
Rick Moynihan
858dbeb4fd
Changes to indicate release notes refer to most recent point releases,
...
not the initial release.
It would be good to make this more explicit still.
The motivation for the change was that ActiveRecords find_in_batches
is documented to have been released in rails 2.3, but was actually
only released in 2.3.2.
2009-04-07 16:10:30 +01:00
Kenny Ortmann
f448c70b3f
added tests for session options being defaulted correctly to rack defaults [ #2403 state:resolved]
...
Signed-off-by: Joshua Peek <josh@joshpeek.com >
2009-04-07 09:18:42 -05:00
Manfred Stienstra
f209d3898f
Improve tests and code for Rails::InfoController and Rails::Info [ #2411 state:resolved]
...
- Refactor Rails::InfoController tests.
- Return forbidden status from the InfoController for remote requests instead of a 500.
- Add tests for displaying middleware in Rails::Info.
Signed-off-by: Joshua Peek <josh@joshpeek.com >
2009-04-07 09:16:48 -05:00
Yehuda Katz and Carl Lerche
9c8eaf8e25
Merge branch 'abstract_controller' of git@github.com:wycats/rails into abstract_controller
2009-04-06 12:35:44 -07:00
Yehuda Katz and Carl Lerche
4d3cd9b43f
Changes necessary to run the T::U tests with the rspec runner
2009-04-06 12:35:24 -07:00
Trevor Turk
1c583d07af
Starting work on Action View Overview guide
2009-04-05 18:29:03 -05:00
Pratik Naik
981d20e752
Supply fullfile name to the generator
2009-04-05 23:08:03 +01:00
Pratik Naik
32ca9a1338
Namespace under RailsGuides
2009-04-05 23:08:02 +01:00
Geoff Buesing
660fc93942
Test cleanup
2009-04-05 10:19:03 -05:00
Geoff Buesing
7685ea20b4
Hash::XML_TYPE_NAMES: no longer a need for a TimeWithZone entry; this class will now match "Time"
2009-04-05 10:15:54 -05:00
Geoff Buesing
c00f2d25de
TimeWithZone.name returns 'Time', to further thwart type checking
2009-04-05 10:08:54 -05:00
Max Lapshin
70de8e64e3
Support multiple schemas in table names for postgresql [ #390 state:resolved]
...
Signed-off-by: Pratik Naik <pratiknaik@gmail.com >
2009-04-05 12:36:36 +01:00
Pratik Naik
632bbbfe1c
Merge docrails
2009-04-05 12:36:36 +01:00
Xavier Noria
dda04f700e
fixes spelling of "JavaScript" and link to the complex form examples app
2009-04-05 11:48:53 +02:00
José Valim
1ab7c37671
Object names with underscore do the wrong lookup in I18n on error_messages_for.
...
Signed-off-by: Michael Koziarski <michael@koziarski.com >
[#2390 state:committed]
2009-04-05 21:08:14 +12:00
Luca Guidi
42cdc7571d
Ensure SqlBypass use ActiveRecord::Base connection
...
Signed-off-by: Michael Koziarski <michael@koziarski.com >
[#https://rails.lighthouseapp.com/attachments/106066/0001-Ensure-SqlBypass-use-ActiveRecord-Base-connection.patch state:committed]
2009-04-05 21:00:50 +12:00
Pratik Naik
c55507e8ce
Merge commit 'mainstream/master'
2009-04-04 17:31:11 +01:00
Pratik Naik
4fe6d43cab
No whitespaces please
2009-04-04 17:26:30 +01:00
Ryan Bigg
86a083d5ad
Document complete_request_uri and action_methods.
2009-04-04 16:23:18 +10:00
Ryan Bigg
e878c3e44a
Merge branch 'master' of git@github.com:lifo/docrails
...
* 'master' of git@github.com:lifo/docrails: (319 commits)
deletes screencast promo in prologue, its proper place is the References section
Typo fix
list -> index
in caching guide, RESTifies some examples, revised conventions here and there
Tech edit of caching guide from Gregg Pollack
Fix typo in comment: hide_actions -> hide_action
Fix two typos in a comment in config/initializers/backtrace_silencers.rb
With -> with in a title
Clear up a little confusing wording in Routing Guide.
copyedited minor details in the rack on rails guide
remove piece of UrlWriter documentation claiming that you can access named routes as its class methods
Add note about change to session options
TRUNCATE is also a MySQL DDL statement, so document this is a possible caveat when using transactions and savepoints.
Improve documentation for ActiveResource::Validations, fix typos
Fix typos in ActiveResource::Base documentation, use present tense, reword confusing sentences
Update ActiveResource::Connection documentation to use present tense
Fix typos in Active Resource README
Fix a small typo
ensure authors get warnings about broken links, and ensure end users don't
in guides generator, warn about duplicate header IDs only if WARN_DUPLICATE_HEADERS
...
2009-04-04 16:13:18 +10:00
Ryan Bigg
ab55ddcc4c
Documented performed?
2009-04-04 16:11:14 +10:00
Xavier Noria
9e9469e83f
Merge branch 'master' of git@github.com:lifo/docrails
2009-04-03 23:32:48 +02:00
Xavier Noria
a7e757f8af
deletes screencast promo in prologue, its proper place is the References section
2009-04-03 23:32:16 +02:00
Nathan Lloyd Smith
c910c45b9d
Typo fix
2009-04-03 13:44:09 -05:00
Xavier Noria
9488d583ee
list -> index
2009-04-03 15:52:16 +02:00
Xavier Noria
2e601d8da7
in caching guide, RESTifies some examples, revised conventions here and there
2009-04-03 15:50:55 +02:00
Mike Gunderloy
e4ea27fd2d
Tech edit of caching guide from Gregg Pollack
2009-04-03 08:15:41 -05:00
Jeffrey Hardy
4350e7fe2b
Fix typo in comment: hide_actions -> hide_action
2009-04-03 04:02:56 -04:00
Joshua Peek
0e9efae474
Nicer name for anonymous local cache middleware class
2009-04-02 12:05:21 -05:00
Cezary Baginski
44423126c6
Additional template render test for backup files [ #2367 state:resolved]
...
Signed-off-by: Joshua Peek <josh@joshpeek.com >
2009-04-02 11:58:29 -05:00
Michael Schuerig
cad3e8b261
Show installed middleware in builtin rails info (/rails/info/properties) [ #2396 state:resolved]
...
Signed-off-by: Joshua Peek <josh@joshpeek.com >
2009-04-02 11:54:52 -05:00
chrisk
19a158650b
Fix two typos in a comment in config/initializers/backtrace_silencers.rb
2009-03-31 15:41:37 -07:00
Jeremy Kemper
d848b7817f
Encapsulate date/time core extensions and constant autoloads in active_support/core/time
2009-03-31 10:03:35 -07:00
Xavier Noria
c6ff88a4d2
With -> with in a title
2009-03-30 10:14:37 +02:00
Geoff Buesing
ea8077c642
Enhance Time #since and #ago DST tests.
2009-03-29 16:43:26 -05:00
Michael Curtis
5a8b481f71
Time.local instances: Adding 24.hours across the DST boundary adds 24 hours instead of one day [ #2066 state:resolved]
2009-03-29 16:15:44 -05:00
Jeremy Kemper
48068bc1a4
Feature detection for Range#step extension
2009-03-29 02:43:13 -07:00
Jeremy Kemper
da8ade36b3
Convert Range step and include extension modules to class reopen
2009-03-29 02:31:08 -07:00
Jeremy Kemper
fe34d10f0c
JRuby doesn't have UnboundMethod#name
2009-03-29 00:24:18 -07:00
Jeremy Kemper
d8bdc4ed92
Explicit test dependencies
2009-03-29 00:12:17 -07:00
Jeremy Kemper
b90f7757ce
Explicit BigDecimal extension dependency
2009-03-29 00:11:20 -07:00
Jeremy Kemper
36e934a5ce
Fix require
2009-03-29 00:10:32 -07:00
Jeremy Kemper
2e4db78e6f
Explicit test dependencies
2009-03-29 00:08:35 -07:00
Jeremy Kemper
db214a1b5a
Explicit File#atomic_write dependency
2009-03-29 00:08:22 -07:00
Jeremy Kemper
7bcfff4457
Explicit test dependencies
2009-03-28 23:56:14 -07:00
Jeremy Kemper
e0f56fc96d
Distinguish missing memcache from missing memcache server
2009-03-28 23:55:43 -07:00
Jeremy Kemper
96af8b69a4
Avoid need for Enumerable#sum extension
2009-03-28 23:55:18 -07:00
Jeremy Kemper
fa5d5e0d16
Explicit dependency on Duration, numeric times, and date/time to_s extensions
2009-03-28 23:54:46 -07:00
Jeremy Kemper
148da357f0
Explicit dependency on Proc#bind extension
2009-03-28 23:54:00 -07:00
Jeremy Kemper
7269842080
Explicit dependency on OrderedHash
2009-03-28 23:53:04 -07:00
Jeremy Kemper
6f08440538
Explicit dependency on Hash#deep_merge extension
2009-03-28 23:52:46 -07:00
Jeremy Kemper
cb5b2ca5c1
Explicit dependency on Object#instance_values extension
2009-03-28 23:52:15 -07:00
Jeremy Kemper
b4af87317b
Explicit dependency on Array#wrap extension
2009-03-28 23:51:37 -07:00
Jeremy Kemper
d41387fde7
Explicit dependency on String#start_with? extension
2009-03-28 23:51:20 -07:00
Jeremy Kemper
4d46455244
Explicit dependency on multibyte String extension
2009-03-28 23:50:50 -07:00
Jeremy Kemper
e70a9b8cd9
Explicit dependency on Module extensions
2009-03-28 23:50:31 -07:00
Jeremy Kemper
9231e32a07
Convert Time conversions extension module to class reopen
2009-03-28 23:50:06 -07:00
Jeremy Kemper
f8bc0bcff1
Explicit dependency on Date calculations extensions
2009-03-28 23:49:47 -07:00
Jeremy Kemper
83a89b8e85
Convert String conversions, filters, starts/ends_with, and multibyte extension modules to class reopen
2009-03-28 23:49:05 -07:00
Jeremy Kemper
fce68161a4
Convert Range conversions extension module to class reopen
2009-03-28 23:48:27 -07:00
Jeremy Kemper
5d5cde4b02
Convert Numeric bytes and time extension modules to class reopen
2009-03-28 23:48:02 -07:00
Jeremy Kemper
dc0c91656f
Convert Module aliasing and introspection extension modules to class reopen
2009-03-28 23:47:42 -07:00
Jeremy Kemper
a1a040d3c8
Convert Integer time extension module to class reopen
2009-03-28 23:47:21 -07:00
Jeremy Kemper
9130c3147a
Convert Hash conversions extension module to class reopen
2009-03-28 23:46:54 -07:00
Jeremy Kemper
dad8dabd31
Convert DateTime extensions to class reopens
2009-03-28 23:46:23 -07:00
Jeremy Kemper
092b5d125c
Convert Date calculations and conversions extension modules to class reopens
2009-03-28 23:45:34 -07:00
Jeremy Kemper
609c1988d2
Tease out Object#acts_like? behaviors
2009-03-28 23:43:26 -07:00
Jeremy Kemper
389b081e37
Unneeded util require
2009-03-28 23:38:21 -07:00
Jeremy Kemper
699d2146fc
Explicit class attribute accessor, benchmark, and NameError extension dependencies
2009-03-28 23:37:56 -07:00
Jeremy Kemper
1321b37212
Explict class attribute accessor dependency
2009-03-28 23:37:32 -07:00
Mike Gunderloy
9635741b84
Clear up a little confusing wording in Routing Guide.
2009-03-27 05:21:33 -05:00
Jeremy Kemper
47c7177ef5
Explicit Time/DateTime dependencies
2009-03-26 19:10:37 -07:00
Jeremy Kemper
4b921a5bdf
Hack in env variable setting for Dependencies.mechanism
2009-03-26 19:10:13 -07:00
Jeremy Kemper
f3f5f40e44
Narrow dependencies
2009-03-26 19:08:40 -07:00
Jeremy Kemper
cf95f75695
Explicit NameError dependency
2009-03-26 19:08:13 -07:00
Jeremy Kemper
1c5a6944d3
Convert Time extension modules to class reopens
2009-03-26 19:07:44 -07:00
Jeremy Kemper
7985298948
Convert DateTime extension modules to class reopens
2009-03-26 19:03:37 -07:00
Jeremy Kemper
34929fed22
Fix timezone test
2009-03-26 19:02:11 -07:00
Xavier Noria
0ddeb6e8d6
copyedited minor details in the rack on rails guide
2009-03-26 18:41:38 +01:00
Mislav Marohnić
f15f1ba285
remove piece of UrlWriter documentation claiming that you can access named routes as its class methods
...
This never worked: ActionController::UrlWriter.users_path
2009-03-25 19:22:45 +01:00
Jeremy Kemper
2a1ae9e8a1
Extract time fixes into separate extensions
2009-03-24 23:03:36 -07:00
Jeremy Kemper
af4c2375a2
Remove core ext dependency from test
2009-03-24 23:02:23 -07:00
Jeremy Kemper
9ea840f568
Explicitly require core extension under test
2009-03-24 23:01:52 -07:00
Jeremy Kemper
cecac31170
Explicit dependency on Inflector and Object#blank?
2009-03-24 19:47:11 -07:00
Jeremy Kemper
f8dbd416b6
Explicit dependency on class_inheritable_accessor
2009-03-24 19:46:42 -07:00
Jeremy Kemper
712baccef5
Remove unnecessary use of Kernel#silence_warnings
2009-03-24 19:46:07 -07:00
Jeremy Kemper
a27ee86c38
Explicit dependency on Array#extract_options!
2009-03-24 19:45:35 -07:00
Mike Gunderloy
fab9d3b59d
Merge branch 'master' of git@github.com:lifo/docrails
...
Conflicts:
railties/guides/source/2_3_release_notes.textile
2009-03-24 20:06:59 -05:00
Mike Gunderloy
4e27ca4c28
Add note about change to session options
2009-03-24 20:02:08 -05:00
Jeremy Kemper
3f7130aed8
Document NameError extensions
2009-03-24 17:04:27 -07:00
Jeremy Kemper
614fccd8c4
Don't require out of load path
2009-03-24 17:03:47 -07:00
Jeremy Kemper
1e72610e76
Condense to Kernel#with_warnings
2009-03-24 17:03:27 -07:00
Jeremy Kemper
fe7d3dbb02
Indentation, superfluous self
2009-03-24 17:02:58 -07:00
Hongli Lai (Phusion)
0e6b9695af
TRUNCATE is also a MySQL DDL statement, so document this is a possible caveat when using transactions and savepoints.
2009-03-24 17:05:21 +01:00
Ryan Angilly
dd2eb1ea7c
adding session_options initialization and test [ #2303 state:resolved]
...
Signed-off-by: Joshua Peek <josh@joshpeek.com >
2009-03-24 10:54:19 -05:00
thedarkone
ae9f258e03
Fix template extension parsing. [ #2315 state:resolved] [ #2284 state:resolved]
...
Signed-off-by: Joshua Peek <josh@joshpeek.com >
2009-03-24 10:54:18 -05:00
thedarkone
e3b166aab3
Simplify handling of absolute path templates. [ #2276 state:resolved]
...
Signed-off-by: Joshua Peek <josh@joshpeek.com >
2009-03-24 10:54:17 -05:00
David Dollar
4c2f09f23a
Updates tests to cause the tests for the Request class not to proxy through a fake TestRequest object [ #2278 state:resolved]
...
Signed-off-by: Joshua Peek <josh@joshpeek.com >
2009-03-24 10:54:16 -05:00
Peter Marklund
8fa4275a72
Reset request_parameters in TestRequest#recycle! to avoid multiple posts clobbering each other [ #2271 state:resolved]
...
Signed-off-by: Joshua Peek <josh@joshpeek.com >
2009-03-24 10:54:15 -05:00
Joshua Peek
03700b4f01
just kill brittle test
2009-03-24 10:54:14 -05:00
Pratik Naik
f97832b1e4
Merge docrails
2009-03-24 12:15:43 +00:00
Pratik Naik
4687306c2c
Merge commit 'mainstream/master'
...
Conflicts:
railties/guides/images/fxn.jpg
railties/guides/rails_guides/generator.rb
2009-03-24 12:10:38 +00:00
Jeremy Kemper
e094940c2b
Move Numeric#to_utc_offset_s to TimeZone.seconds_to_utc_offset
2009-03-23 22:01:51 -07:00
Jeffrey Hardy
2f340d050b
Improve documentation for ActiveResource::Validations, fix typos
2009-03-24 00:37:04 -04:00
Jeffrey Hardy
c58c98d135
Fix typos in ActiveResource::Base documentation, use present tense, reword confusing sentences
2009-03-24 00:31:02 -04:00
Jeffrey Hardy
e64e4f82d3
Update ActiveResource::Connection documentation to use present tense
2009-03-24 00:27:37 -04:00
Jeffrey Hardy
87891de101
Fix typos in Active Resource README
2009-03-24 00:08:17 -04:00
Jeffrey Hardy
76556b08bb
Merge branch 'master' of git://github.com/lifo/docrails
...
* 'master' of git://github.com/lifo/docrails: (259 commits)
Fix a small typo
ensure authors get warnings about broken links, and ensure end users don't
in guides generator, warn about duplicate header IDs only if WARN_DUPLICATE_HEADERS
replace edit distance implementation with one written from scratch to avoid license issues
removes a wrong comment in the finders guide
updates fxn picture
thanks but release notes are mostly frozen once they are published, and provide only an overview of the new stuff
Added extra notes to nested model forms explanation in 2.3 release notes to cover has_one relationships
clarifies a bit more what's the issue with check boxes and arrays of parameters
be even more ambiguous about the order of generation of hidden input for check boxes in form helper guide
this page referred to an :href_options keyword hash, in fact the correct keyword (the one the code responds to) is :html
update explanation of check box generation according to f400209
Hidden field with check box goes first.
update rack fixture to be ruby 1.9 compat
Better error message to try to figure out why the CI build is failing
ruby 1.9 compat: Pathname doesn't support =~
update rack fixture to be ruby 1.9 compat
update metal fixtures to be ruby 1.9 compat
Fix brittle Time.now mock
Ensure our bundled version of rack is at the front of the load path
...
2009-03-23 23:15:47 -04:00
Yehuda Katz and Carl Lerche
1d3e2c2b73
In the middle of some refactoring... some fails due to changes in AbstractController not yet reflected in ActionController tests
2009-03-23 18:06:47 -07:00
Yehuda Katz and Carl Lerche
a501638e9d
Checkpoint
2009-03-23 15:45:01 -07:00
Yehuda Katz
34f058e082
Add a bunch of tests for various render :action, layout combinations
2009-03-23 12:07:34 -07:00
Carl Lerche
4a93148bfe
Adding render :layout tests
2009-03-23 10:23:14 -07:00
Carl Lerche
ab17ecfe5d
Finished implementing :layout for most of the render options
2009-03-23 10:23:14 -07:00
Carl Lerche
c6123c3703
Finished implementing layout for render :text
2009-03-23 10:23:14 -07:00
Carl Lerche
81e814adfa
Working on being able to render :text with layouts
2009-03-23 10:23:14 -07:00
Carl Lerche
90c079a781
Modified the action layout tests to use the new FixtureTemplate class
2009-03-23 10:23:14 -07:00
Pratik Naik
f7bdfe8bb7
Fix a small typo
2009-03-22 11:25:05 +00:00
Xavier Noria
1ff3ae3ed7
ensure authors get warnings about broken links, and ensure end users don't
2009-03-22 11:11:10 +01:00
Jeremy Kemper
0bd668fd88
Namespace HashWithIndifferentAccess
2009-03-21 18:45:09 -07:00
Jeremy Kemper
2133044fec
Hide XmlMini backend details from rdoc
2009-03-21 18:44:00 -07:00
Xavier Noria
dab7813ebc
in guides generator, warn about duplicate header IDs only if WARN_DUPLICATE_HEADERS
2009-03-22 00:43:56 +01:00
Xavier Noria
bf14453af9
replace edit distance implementation with one written from scratch to avoid license issues
2009-03-22 00:40:35 +01:00
Pratik Naik
d758d996d1
Deprecate Model#validate/validate_on_create/validate_on_update. Use Model.validate :method and likewise
2009-03-21 19:07:15 +00:00
Pratik Naik
320933205e
Deprecate Errors#on_base/add_to_base/invalid?/each_full
2009-03-21 18:34:05 +00:00
Xavier Noria
3aae3db170
removes a wrong comment in the finders guide
2009-03-21 16:00:33 +01:00
Jeremy Kemper
bca510cec2
try is an object extension
2009-03-21 04:39:54 -07:00
Jeremy Kemper
baf73e19a6
Convert Range extension module to a class reopen
2009-03-21 04:39:53 -07:00
Jeremy Kemper
b8d59b7f84
Convert Numeric extension module to a class reopen
2009-03-21 04:39:53 -07:00
Jeremy Kemper
d8cb94c75c
Fix dangling Inflector reference
2009-03-21 04:39:53 -07:00
Jeremy Kemper
21de164f8a
Convert LoadError extension modules to class reopens
2009-03-21 04:39:53 -07:00
Jeremy Kemper
54cf0fc476
Convert integer extension modules to class reopens
2009-03-21 04:39:53 -07:00
Jeremy Kemper
b4a1718832
Convert hash extension modules to class reopens
2009-03-21 04:39:53 -07:00
Jeremy Kemper
bc4e2aa931
Explicitly require set
2009-03-21 04:35:16 -07:00
Jeremy Kemper
8d1d813b66
Simplify Enumerable#each_with_object
2009-03-21 04:35:16 -07:00
Jeremy Kemper
051bab5bd2
Explicitly require pathname core extension
2009-03-21 04:35:16 -07:00
Jeremy Kemper
c43dec888a
Convert date extension modules to class reopens
2009-03-21 04:35:16 -07:00
Jeremy Kemper
bd28c7b1b8
blank? and duplicable? are Object extensions
2009-03-21 04:35:16 -07:00
Jeremy Kemper
005b40194e
Convert bigdecimal extension modules to class reopens
2009-03-21 04:35:16 -07:00
Jeremy Kemper
83fd1ae122
Convert array extension modules to class reopens
2009-03-21 04:35:16 -07:00
Jeremy Kemper
d5e87e3be0
Simple singleton. We don't need the full monty.
2009-03-21 04:35:16 -07:00
Jeremy Kemper
a970e32c91
Only require builder at startup if we need to monkey with its String#to_xs demands
2009-03-21 04:35:16 -07:00
Jeremy Kemper
dd15a3fee0
Prefer a less intrusive BlankSlate-alike that doesn't hook Object# and Kernel#method_added to remove future methods
2009-03-21 04:35:15 -07:00
Jeremy Kemper
a4e3aac40a
* Introduce ActiveSupport.core_ext Integer, %w(conversions time etc)
...
* Convert some extension modules to simply reopening the class
* Remove deprecated Float time extensions
* Fold Base64 extension into ActiveSupport::Base64 since stdlib Base64 is gone
2009-03-21 04:35:15 -07:00
Pratik Naik
2bc4189faf
Get rid of active_model/core and active_model/callbacks
2009-03-21 01:32:59 +00:00
Pratik Naik
e4b89b4680
Validation options dont need explicit :on => :save
2009-03-21 01:16:30 +00:00
Pratik Naik
379e468034
Remove DEFAULT_VALIDATION_OPTIONS from validations
2009-03-21 01:14:58 +00:00
Pratik Naik
22ad30ed60
Move validate_on_create and validate_on_update from ActiveModel to ActiveRecord
2009-03-21 01:11:38 +00:00
Xavier Noria
9fdbc11615
updates fxn picture
2009-03-21 01:30:22 +01:00
Pratik Naik
6173e5bfae
Add ActiveModel::Validations tests for regular ruby classes
2009-03-20 22:21:27 +00:00
Yehuda Katz
dc96ba8043
Temporary runner
2009-03-20 15:02:12 -07:00
Pratik Naik
08a99d0eac
Add I18n translations to ActiveModel and move more AR specific parts to ActiveRecord::Validations
2009-03-20 21:45:13 +00:00
Yehuda Katz
d1256f71d6
Hacked up fixture view paths to simplify tests for a bit
2009-03-20 14:05:10 -07:00
Pratik Naik
cc5e019f6b
Include ActiveModel::Validations from ActiveRecord::Validations
2009-03-20 19:12:18 +00:00
Pratik Naik
09afbfd47f
Fix ActiveResource::Errors deprecation messages
2009-03-20 18:51:01 +00:00
Pratik Naik
bc1dd0b82e
Improve the deprecation message for Errors#on
2009-03-20 18:12:21 +00:00
Pratik Naik
7d187c193c
Validation tests arent using any fixtures
2009-03-20 18:07:35 +00:00
Pratik Naik
78c9791729
ActiveModel.load_all! isn't really needed at this point
2009-03-20 18:02:50 +00:00
Pratik Naik
4a582aa7ca
Use mattr_accessor in TestsDatabase instead of setup method
2009-03-20 17:56:46 +00:00
Pratik Naik
37283a6aae
Deprecate Error#on(attribute) in favour of Errors#[attribute]
2009-03-20 17:36:22 +00:00
Pratik Naik
4367f39dea
TestDatabase -> TestsDatabase
2009-03-20 16:02:12 +00:00
Pratik Naik
d01e639daf
Remove unused columns from the ActiveModel test schema
2009-03-20 15:33:40 +00:00
Pratik Naik
cda984d314
Future deprecation message
2009-03-20 15:27:55 +00:00
Pratik Naik
60756ad4ec
Move relevant validation tests from Active Record to Active Model
2009-03-20 15:07:49 +00:00
Pratik Naik
e945bcfe4a
Add test sqlite3 db to .gitignore
2009-03-20 11:22:27 +00:00
Pratik Naik
5b1a1bf5bf
Make Active Model test suite similar to Active Record
2009-03-20 10:32:24 +00:00
Pratik Naik
93e2d378df
Autload ActiveModel::Observing
2009-03-20 01:13:24 +00:00
Pratik Naik
77acfefedf
Make Active Resource use ActiveModel::Errors
2009-03-19 23:45:08 +00:00
Pratik Naik
638333b7a1
Move uniqueness and association validations to Active Record
2009-03-19 23:44:30 +00:00
Pratik Naik
8828b2ca67
Move all the Active Record validations to Active Model
2009-03-19 23:28:59 +00:00
Yehuda Katz
7a86f8ea90
Test controller layout
2009-03-19 16:11:20 -07:00
Jeremy Kemper
6ed42ebdff
Merge branch 'master' into bodyparts
2009-03-19 16:03:41 -07:00
Yehuda Katz
890321e51e
Get very basic layouts working.
...
* Required small architecture change
2009-03-19 15:45:48 -07:00
Xavier Noria
0f87fd3069
thanks but release notes are mostly frozen once they are published, and provide only an overview of the new stuff
2009-03-19 23:23:05 +01:00
Yehuda Katz
8ab37c7660
Started implementing render :action
2009-03-19 13:35:39 -07:00
Anton Jenkins
3d3a74f07f
Added extra notes to nested model forms explanation in 2.3 release notes to cover has_one relationships
2009-03-19 16:23:14 +00:00
Jeremy Kemper
0d5b50ee3a
pluginize concurrent block body part
2009-03-19 03:31:55 -07:00
Yehuda Katz
e0447023db
Implemented basic template rendering in AC::Base2:
...
* Created several macros for writing simpler specs
* Finished making Rack::Test work right
* Implemented render_to_string
* Status Codes
* render :text => nil
2009-03-18 15:58:47 -07:00
Pratik Naik
93b98cb841
Ensure script/plugin doesn't show error message when svn externals are not there
2009-03-18 18:39:56 +00:00
Pratik Naik
11f53db216
Remove outdated script/plugin options
2009-03-18 18:33:44 +00:00
Jeremy Kemper
6335f5d518
Merge branch 'master' into bodyparts
2009-03-18 11:18:48 -07:00
Yehuda Katz
fb626ee390
Rework NewCallbacks to not require method_missing
2009-03-17 18:05:08 -07:00
Yehuda Katz
e6e3e3dfbc
Temporarily reraise to simplify debugging
2009-03-17 18:04:41 -07:00
Yehuda Katz
f55514125c
Working toward getting a basic AbstractController framework
2009-03-17 18:04:22 -07:00
Xavier Noria
e8501a15a8
clarifies a bit more what's the issue with check boxes and arrays of parameters
2009-03-17 21:01:50 +01:00
Xavier Noria
485cd69a7b
be even more ambiguous about the order of generation of hidden input for check boxes in form helper guide
2009-03-17 20:53:03 +01:00
Giles Bowkett
168e3958df
this page referred to an :href_options keyword hash, in fact the correct keyword (the one the code responds to) is :html
2009-03-17 12:41:15 -07:00
Xavier Noria
a8bf6fa308
update explanation of check box generation according to f400209
2009-03-17 18:50:50 +01:00
Clemens Kofler
d36df5e7a8
Hidden field with check box goes first.
2009-03-17 14:46:19 +01:00
Jeremy Kemper
70e3dfb2e9
Pare down unit test
2009-03-16 12:09:34 -07:00
Pratik Naik
fc123d189c
Merge commit 'mainstream/master'
2009-03-16 11:20:28 +00:00
Pratik Naik
6c688d000f
clients.id
2009-03-15 23:27:31 +00:00
Xavier Noria
804a304065
dasherize titles in a more predictable way, and update fragment identifiers accordingly
2009-03-15 23:22:04 +01:00
Xavier Noria
a19be732cd
guides generator warns about duplicate header IDs
2009-03-15 22:16:27 +01:00
Xavier Noria
a4b1ccec5c
revised links in guides according to W3C link checker report
2009-03-15 21:31:20 +01:00
Xavier Noria
20dc236bbd
update links in layout according to W3C link checker report
2009-03-15 20:41:35 +01:00
Xavier Noria
732d97a1b1
in guides generator, broken link warning now suggests the existing anchor with min Levenshtein distance
2009-03-15 20:03:37 +01:00
Eloy Duran
3b89aa605c
Added a collection association form example.
2009-03-15 16:22:14 +01:00
Pratik Naik
13cc934cc8
Fix generated sql
2009-03-15 14:13:03 +00:00
Xavier Noria
b47b9289eb
fixes broken links in association basics guide
2009-03-15 10:42:46 +01:00
Xavier Noria
a86be917b5
fixes broken links in security guide
2009-03-15 10:42:34 +01:00
Xavier Noria
1c53b5c71a
fixes broken links in security guide
2009-03-15 10:39:47 +01:00
Xavier Noria
df45413ea4
fixes broken links in migrations guide
2009-03-15 10:38:58 +01:00
Xavier Noria
32c07c4566
fixes broken links in i18n guide
2009-03-15 10:36:48 +01:00
Xavier Noria
393ece5687
fixes broken links in finders guide
2009-03-15 10:32:14 +01:00
Eloy Duran
0e12b554c9
Started on a Rails guide on nested model forms.
2009-03-15 00:40:59 +01:00
Xavier Noria
952d1cc75a
recommend rake guides instead of script in instructions for contributing to guides
2009-03-14 23:58:05 +01:00
Xavier Noria
e2a442c754
some minor details in finders guide
2009-03-14 23:41:20 +01:00
Mike Gunderloy
9ac0dade6d
Minor edits to I18n guide; publish guide
2009-03-14 17:04:41 -05:00
Xavier Noria
1bd5a64f5a
revised titles of caching guide
2009-03-14 22:59:16 +01:00
Xavier Noria
28167e793d
revised titles of the command line guide, and added changelog
2009-03-14 22:57:59 +01:00
Xavier Noria
1c820dde75
revised titles of plugins guide
2009-03-14 22:52:22 +01:00
Xavier Noria
3789f4b653
revised titles of testing guide
2009-03-14 22:48:07 +01:00
Xavier Noria
66f1a1101d
revised titles of action mailer guide, and added changelog
2009-03-14 22:44:39 +01:00
Xavier Noria
b724427641
revised titles in i18n guide
2009-03-14 22:44:38 +01:00
Mike Gunderloy
4216213f06
A few more changes for caching guide
2009-03-14 16:43:21 -05:00
Mike Gunderloy
3f631a3428
Some editorial cleanup on caching guide
2009-03-14 16:42:33 -05:00
Xavier Noria
3faed7980e
revised titles in form helpers guide
2009-03-14 22:20:05 +01:00
Xavier Noria
66f5502fcc
revised titles in validation and callbacks guide
2009-03-14 22:20:05 +01:00
Xavier Noria
abe921f81f
revised titles in performance guide
2009-03-14 22:20:05 +01:00
Xavier Noria
b0caa62cbf
revised titles in debugging guide
2009-03-14 22:20:04 +01:00
Xavier Noria
643ec33207
revised titles in security guide
2009-03-14 22:20:04 +01:00
Xavier Noria
4c426984e1
revised titles of rack guide
2009-03-14 22:20:04 +01:00
Xavier Noria
cd2475a5c8
revised typography in titles of the routing guide
2009-03-14 22:20:04 +01:00
Mike Gunderloy
79f165974f
Mark callbacks guide done
2009-03-14 16:13:47 -05:00
Mike Gunderloy
c50316347b
Minor cleanup to callbacks/validations guide
2009-03-14 16:12:09 -05:00
Xavier Noria
b8391e4018
fixes typo in finders guide
2009-03-14 21:43:56 +01:00
Xavier Noria
8867a636b3
revised case in titles of AC overview guide
2009-03-14 17:17:28 +01:00
Xavier Noria
41b4d3d899
revised typography in layouts and rendering guide
2009-03-14 17:14:32 +01:00
Xavier Noria
bdf3333519
revised case in titles of associations guide
2009-03-14 17:09:07 +01:00
Xavier Noria
0a88d42990
revised case in titles of AR basics guide
2009-03-14 17:03:10 +01:00
Xavier Noria
5b079a653e
revised case in titles of migrations guide
2009-03-14 16:59:26 +01:00
Xavier Noria
ac1068bc5b
revised capitalization of titles
2009-03-14 16:14:41 +01:00
Xavier Noria
5367434bdd
minor details in the querying guide
2009-03-14 16:05:51 +01:00
Pratik Naik
0e19ba6f20
Query guide is done
2009-03-14 14:38:32 +00:00
Pratik Naik
f60445940f
Fix the table name
2009-03-14 14:37:08 +00:00
Pratik Naik
f5efe1cf8c
Move find_each stuff to the top and change a bit
2009-03-14 14:30:49 +00:00
Pratik Naik
b8ad501c91
Merge commit 'mainstream/master'
2009-03-14 13:12:13 +00:00
Jeremy Kemper
4a7b11d5d8
Less ceremony
2009-03-13 18:49:53 -07:00
Rodrigo Rosenfeld Rosas
626221d17c
Extra spaces on list items were generating wrong output in Testing guide.
2009-03-13 10:10:00 -03:00
Rodrigo Rosenfeld Rosas
586ef2977b
Corrects minor spelling mistake (practises -> practices).
2009-03-13 09:54:09 -03:00
Mike Gunderloy
2885a9a8de
Update 2.3 relnotes through 3/13 AM, remove warning about RC to get ready for release.
2009-03-13 07:26:16 -05:00
Jeremy Kemper
2f998fc81f
Extract output buffer test
2009-03-13 03:23:13 -07:00
Jeremy Kemper
b2f98c13a3
Simplify parts and tests
2009-03-13 03:16:14 -07:00
Jeremy Kemper
d54d97b07c
Fix tests
2009-03-13 03:01:47 -07:00
Jeremy Kemper
5d76dee329
Example using an edge side include body part to fetch queued rendering results
2009-03-13 02:55:24 -07:00
Jeremy Kemper
7c1714cbd0
Body parts: future rendering, threaded future, queued future, open-uri example
2009-03-13 02:36:15 -07:00
Jeremy Kemper
79b0b1a0ef
Extract Response#string_body?
2009-03-13 02:15:51 -07:00
Xavier Noria
6064446752
explains the order in which records are fetched by find_each
2009-03-13 09:29:37 +01:00
Jeremy Kemper
7e6c310b05
Merge branch 'master' into bodyparts
...
Conflicts:
actionpack/lib/action_view/base.rb
2009-03-13 01:10:39 -07:00
Jeremy Kemper
3d260760f0
Introduce flush_output_buffer to append the buffer to the response body then start a new buffer. Useful for pushing custom parts to the response body without disrupting template rendering.
2009-03-13 00:25:05 -07:00
Jeremy Kemper
91d2740595
Return body parts directly to Rack rather than building a response string ourselves. Allows Rack middleware to orchestrate response building.
2009-03-12 21:47:34 -07:00
Xavier Noria
8ac0e63104
prevents the mini-bio of fxn to wrap below the picture
2009-03-13 02:00:54 +01:00
Xavier Noria
11906ec103
reword a paragraph in find_each explanation
2009-03-13 01:28:51 +01:00
Xavier Noria
952b340703
explains find_each and find_in_batches in the querying guide
2009-03-13 00:36:28 +01:00
Xavier Noria
655f95a8a6
in batches.rb, rewrap rdoc, and document options as symbols
2009-03-12 23:28:33 +01:00
Jeremy Kemper
c8c2b3820e
Eliminate internal render stack since we only need its head and tail
2009-03-12 12:34:22 -07:00
Yehuda Katz
a2637e9f1f
Try to build a new AC::Base on top of AbstractController
2009-03-12 13:19:13 -06:00
Yehuda Katz
67f9b39bd0
Use extlib accessor for new callbacks
2009-03-12 13:18:31 -06:00
Yehuda Katz
72b365ece9
Move Abstract stuff to autoload
2009-03-12 13:18:15 -06:00
Yehuda Katz
0c92a51dad
Handle nil QS
2009-03-12 13:17:57 -06:00
Eloy Duran
de55c8d745
Fixed some spelling errors in documentation about AssociationCollection::destroy and AssociationCollection::destroy_all.
...
This time without the whitespace fixes and move of the destroy_all method.
2009-03-12 16:50:10 +01:00
Eloy Duran
8e277f89cd
Revert "Fixed some spelling errors in documentation about AssociationCollection::destroy and AssociationCollection::destroy_all."
...
This reverts commit b304b0be01 .
2009-03-12 16:46:38 +01:00
Eloy Duran
b304b0be01
Fixed some spelling errors in documentation about AssociationCollection::destroy and AssociationCollection::destroy_all.
...
Also fixed some whitespace.
2009-03-12 16:42:41 +01:00
Pratik Naik
53744c5438
Merge commit 'mainstream/master'
...
Conflicts:
actionpack/lib/action_view/helpers/text_helper.rb
activesupport/lib/active_support/inflector.rb
2009-03-12 15:31:24 +00:00
CassioMarques
053afbe3bd
Changing :integer_only to :only_integer in the AR Validations and Callbacks guide
2009-03-12 10:37:16 -03:00
Xavier Noria
c351aec92f
each -> find_each in 2.3 release notes
2009-03-12 13:49:52 +01:00
Karel Minarik
b69f027ec1
Fixed invalid HTML in Credits
2009-03-12 11:32:23 +01:00
Matt Jones
4f7e2257fe
Fix several issues with code examples.
...
- "chaining" layouts with :only/:except removed. See #2162 for discussion.
- double render section now has working examples. Old version implied that calling render once and then falling through would give a DoubleRenderError.
- complete example for layout proc.
- cleaned up a few stray references to layouts ending in bare .erb (no format).
2009-03-12 03:07:17 -04:00
Henrik N
724eb9e612
Fix some typos, including a global "seperator" -> "separator".
2009-03-12 07:29:57 +01:00
Xavier Noria
aaacc999fd
finished proofreading of the validations guide
2009-03-12 00:29:34 +01:00
Xavier Noria
985ea6c121
and now even with the right dimensions
2009-03-11 23:19:43 +01:00
Xavier Noria
12aec1f5a4
updates fxn picture with better quality
2009-03-11 23:17:02 +01:00
Xavier Noria
73f649532b
uploads fxn picture, links to fxn's tweet account
2009-03-11 20:26:42 +01:00
Pratik Naik
40147f23de
Move JZ in the middle
2009-03-11 17:33:04 +00:00
Pratik Naik
e684597a81
Alphabetical ordering
2009-03-11 14:15:41 +00:00
Pratik Naik
cdb10c5ade
Add the team
2009-03-11 13:34:33 +00:00
Xavier Noria
4bf468cb8b
in validations guide, emphasize after_save runs always after more specific after_*s
2009-03-11 13:24:56 +01:00
CassioMarques
d088ce5653
Fixing image for error messages in the ActiveRecord Validations and Callbacks Guide
2009-03-11 09:24:21 -03:00
Xavier Noria
a99faa88eb
revised sections 9 to 14 of the validations guide
2009-03-11 00:15:57 +01:00
Xavier Noria
d02837401b
revised section 8 of validations guide
2009-03-10 21:37:49 +01:00
Pratik Naik
f8c573abc1
Remove duplicate text
2009-03-10 20:32:21 +00:00
Andreas Scherer
968a0ad502
Replace comma with full-stop in scoping chain.
2009-03-10 19:15:19 +01:00
Andreas Scherer
7ed698ed79
Revision of i18n guide, final sections.
2009-03-10 18:58:58 +01:00
Andreas Scherer
ffe2ddb7fb
Revision of i18n guide, chapter 4.
...
Major change: Scoped lookup in the form 'active_record.error_messages'
seems to have been deprecated at least in Rails 2.2. Instead, the form
'activerecord.errors.messages' is implemented and documented.
2009-03-10 18:21:43 +01:00
Pratik Naik
df4375d75a
Revert "Updated actionpack/CHANGELOG to include enhancements to form option helpers"
...
No CHANGELOG entries please.
This reverts commit 7fa0a8d7f3 .
2009-03-10 16:06:21 +00:00
Tekin Suleyman
803a6b171b
Slight tweak to 2.3 release notes
2009-03-10 15:34:18 +00:00
Tekin Suleyman
f1e903aa92
Merge branch 'master' of git://github.com/lifo/docrails
2009-03-10 15:26:59 +00:00
Mike Gunderloy
5739626031
Update 2.3 release notes with changes through March 6
2009-03-10 08:30:33 -05:00
Andreas Scherer
edd5d7f38c
Revision of i18n guide, chapter 3.
2009-03-10 13:42:25 +01:00
Mike Gunderloy
65309c57bb
Fix typo in Routing Guide
2009-03-10 07:19:30 -05:00
Xavier Noria
8db16e86c8
your dear missed typo, thank you
2009-03-10 10:42:09 +01:00
Xavier Noria
5c78693ea5
revised section 7 of validations guide
2009-03-10 10:38:52 +01:00
Pratik Naik
1ab84247ca
Merge commit 'mainstream/master'
...
Conflicts:
railties/guides/files/stylesheets/main.css
railties/guides/rails_guides/generator.rb
railties/guides/source/index.erb.textile
2009-03-10 00:33:32 +00:00
Xavier Noria
b6fb79c531
revision of validations guide, chapters 4 to 7
2009-03-10 00:55:33 +01:00
Jeffrey Hardy
4b6458bf4c
Improve documentation for ActiveRecord::Base.update_all. Document Array and Hash syntax for conditions, include usage examples.
2009-03-09 19:45:43 -04:00
Pratik Naik
8aabfadcb7
Add a note in release notes about using request.cookies["foo"]= instead of CGI::Cookie.new in tests
2009-03-09 18:13:05 +00:00
Andreas Scherer
c9806fe176
Touch-up the 'i18n' part while reading the first two sections.
2009-03-09 18:31:51 +01:00
Pratik Naik
36e9ae2603
Add some rack links
2009-03-09 11:45:14 +00:00
Xavier Noria
fc098e8de9
yet some more deprecated :message formats updated
2009-03-08 22:42:36 +01:00
Xavier Noria
f4b9de8abf
just a missing preposition
2009-03-08 22:25:41 +01:00
Xavier Noria
04042ce01e
important revision in (current) chapter 3 of validations guide
2009-03-08 22:23:08 +01:00
Trevor Turk
2bf922d056
Added information about the new Object#invalid? method just added to Edge.
2009-03-08 13:04:23 -05:00
Xavier Noria
336f0a2e63
proofread validations guide up to section 2
2009-03-08 17:07:34 +01:00
Xavier Noria
f3e4d14ab9
remove unneeded curlies in AR::Base.update example
2009-03-08 16:48:23 +01:00
Xavier Noria
3fbfb81aa0
harmonizes whitespace surrounding special boxes and their inner paragraphs, removes unused selectors as well
2009-03-08 16:28:34 +01:00
Trevor Turk
50e81d9bc4
Finish up callbacks section for Active Record Validations and Callbacks guide
2009-03-07 17:41:03 -06:00
Trevor Turk
61af46ca2a
Fix guide error: save(false) skips validations but does run callbacks
2009-03-07 15:29:28 -06:00
nachocab
2e8f910630
Added info on how to run rake with different database adapters
2009-03-07 11:15:51 -07:00
Mike Gunderloy
cafa3c0597
Fix bad link on index dropdown
2009-03-07 10:34:19 -06:00
Pratik Naik
aea80b402e
Move the warning down a lil in the relnotes
2009-03-07 12:02:25 +00:00
Xavier Noria
045bcd982f
get style for dd.warning back
2009-03-07 00:05:34 +01:00
Michael Erb
06cbc3dc90
added 'Sending multipart emails with attachments' section for ActionMailer guide
2009-03-06 16:27:52 -05:00
Xavier Noria
da242d4d09
fixes CSS rule for warning blocks in guides
2009-03-06 20:41:11 +01:00
Tekin Suleyman
7fa0a8d7f3
Updated actionpack/CHANGELOG to include enhancements to form option helpers
2009-03-06 16:46:06 +00:00
Pratik Naik
60023f52c0
Remove duplicate links from the index page
2009-03-06 15:21:21 +00:00
Pratik Naik
bd23496182
Add some more stuff to the rack guide
2009-03-06 15:19:20 +00:00
Pratik Naik
434fb7ef6b
I ate a word
2009-03-06 14:48:11 +00:00
Simon Jefford
3a5d922f67
Updated the Rails on Rack section concerning metal
...
- Explained how to override the default load order of metal apps
- Explained that metal apps within plugins will also be loaded
2009-03-06 14:44:46 +00:00
Niels Ganser
cb40c761b2
Minor spelling fix
2009-03-06 13:45:26 +01:00
Pratik Naik
9219c05f7c
Change the link on the index page
2009-03-05 13:47:42 +00:00
Pratik Naik
39d18c6aa4
Some changes to the doc section and renaming the guide
2009-03-05 13:44:11 +00:00
Xavier Noria
0cf49381d1
removes questionable :message examples (reported in Rails LH #2107 )
2009-03-04 23:38:17 +01:00
Yehuda Katz
f8088d7def
memoize correctly ;)
2009-03-03 17:20:57 -08:00
Yehuda Katz
6001cea5d7
Helpers with an initial test
2009-03-03 16:42:20 -08:00
Mike Gunderloy
6680bc898a
Reconcile index and layout for Guides.
2009-03-03 07:24:28 -06:00
Mike Gunderloy
be9445f430
Fix bad crossref in RDoc for ActiveSupport::CoreExtensions::Date::Calculations
2009-03-02 19:37:46 -06:00
Mike Gunderloy
a344934fe9
The missing guide.
2009-03-02 12:37:44 -06:00
Mike Gunderloy
901df601fc
Added "Contributing" Guide
2009-03-02 11:12:07 -06:00
Xavier Noria
1cbdab1c82
fix form builder example in form helpers guide (reported by JasonKing in LH)
2009-03-02 09:28:39 +01:00
Xavier Noria
eb472d6d21
do not assume code blocks have blank lines around, also nontextile -> notextile
2009-03-02 01:06:54 +01:00
Daniel Lopes
f6fbdf39d7
fix broken links in performance_testing.textile
2009-03-01 19:42:44 -03:00
John Trupiano
bee4bf1288
Merge branch 'master' of git@github.com:lifo/docrails
2009-03-01 14:48:27 -05:00
John Trupiano
a60d41af6b
Beefed up mass assignment coverage (section 6) in the security guide. Now includes nested mass assignment (and nested object forms) and adds another (paranoid) countermeasure.
2009-03-01 14:22:10 -05:00
Karel Minarik
61656cf770
Fixed incorrect examples of ActiveRecord error message lookup in the I18N guide [Thanks Alex Fortuna]
...
See http://www.ruby-forum.com/topic/179273
2009-03-01 13:03:26 +01:00
Karel Minarik
a6f1e42c09
Added information about "lazy lookup" inside views (t '.foo') in I18N guide
2009-03-01 12:51:18 +01:00
Karel Minarik
959b827e40
Clarified info about "pragmatic approach to locale codes" and removed speculation about "locale inheritance" in the I18N guide [thanks Kip]
...
See http://groups.google.com/group/rails-i18n/msg/7b4513b3ca8abbf5
2009-03-01 12:37:03 +01:00
Karel Minarik
92dd9b3e9f
Added information about "Localized views" into I18N guide
...
See:
* a98cd7ca9b
* http://afreshcup.com/2009/02/01/rails-23-localized-views/
2009-03-01 12:06:50 +01:00
Karel Minarik
48d4c0f011
Added note how to configure Rails loading mechanism to look for nested locale files (+config/locales/models/book/es.yml+, etc) to the I18N guide
2009-03-01 11:03:59 +01:00
Karel Minarik
e1c0763e47
Get rid of drop shadows in screenshots for the I18N guide
...
TODOS are in http://rails.lighthouseapp.com/projects/16213/tickets/23-rails-i18
2009-03-01 10:54:18 +01:00
Pratik Naik
c674d209e1
Fix some formatting in the caching guide
2009-02-28 19:40:52 +00:00
Mike Gunderloy
559c394ec4
Update 2.3 release notes.
2009-02-28 11:46:50 -06:00
Xavier Noria
f259cbd959
removes trailing whitespace
2009-02-28 17:13:45 +01:00
Xavier Noria
0d145d9b37
implements a temporary workaround for failing notextile
2009-02-28 17:07:46 +01:00
Xavier Noria
1108bd7fe9
in security guide, substitutes pre tags with appropriate custom code tags
2009-02-28 17:07:04 +01:00
Xavier Noria
5257ea7f44
in textile extensions, simplify regexp literal, and remove spurious extra newline in code blocks
2009-02-28 14:26:30 +01:00
Yehuda Katz
cde9aab823
Callbacks test
2009-02-27 20:49:44 -08:00
Yehuda Katz
9510070f78
Fixes multiple conditions
2009-02-27 19:37:09 -08:00
Yehuda Katz
c16c7a8de4
Add support for callbacks
2009-02-27 19:25:45 -08:00
Xavier Noria
da5549b83f
let the guides generator warn about broken links
2009-02-28 03:24:23 +01:00
Xavier Noria
626c724b62
fixes broken links in AR finders guide
2009-02-28 03:09:06 +01:00
Xavier Noria
8a4247a3ff
fixes broken links in associations guide
2009-02-28 03:06:33 +01:00
Xavier Noria
35263f93bf
complete pass on the associations guide, mostly typography and some minor bits here and there
2009-02-28 02:36:32 +01:00
Xavier Noria
120f16fc9d
unbox TT elements
2009-02-28 02:35:48 +01:00
Yehuda Katz
ee80dad680
Initial hooks
2009-02-27 15:11:02 -08:00
Xavier Noria
d4128cff22
fixes typo @customer -> customer
2009-02-27 23:36:05 +01:00
Matt Jones
69ad155c90
describe action of include_root_in_json in to_json docs
2009-02-27 17:03:05 -05:00
Yehuda Katz
d1157e7242
AbstractController now supports layouts and rendering
2009-02-27 11:42:13 -08:00
Mike Gunderloy
d0877508cb
Update release notes for 2.3 RC2
2009-02-27 08:30:51 -06:00
Mike Gunderloy
9fda6c5140
Added RC2 note to Release Notes for 2.3.
2009-02-25 11:46:03 -06:00
Xavier Noria
f0d44ec898
s:hbody:/body:g in layouts & rendering guide
2009-02-25 14:27:58 +01:00
Mike Gunderloy
9bb977db24
Updating release notes for 2.3.
2009-02-25 04:51:29 -06:00
Yehuda Katz
b1f078bddf
First, very early, AbstractController code. More to come
2009-02-24 17:25:21 -08:00
Xavier Noria
7d773a17a4
fixes scroll beyond the box in code blocks (fix suggested by toretore)
2009-02-25 00:59:37 +01:00
Xavier Noria
d5fb579143
added overflow: auto for code blocks in guides CSS
2009-02-25 00:28:27 +01:00
Pratik Naik
3e911045f9
Update with the new CSS from Jason and change the header logo
2009-02-24 13:27:21 +00:00
Pratik Naik
1248c6325b
Merge commit 'mainstream/master'
2009-02-24 12:30:37 +00:00
Aditya Chadha
346ac0bba7
Add references
2009-02-24 00:30:02 -05:00
Aditya Chadha
3e7015b796
Merge branch 'master' of git@github.com:lifo/docrails
2009-02-23 17:21:36 -05:00
Aditya Chadha
bb1ce5d199
Another strange character fix
2009-02-23 17:21:23 -05:00
Daniel Schierbeck
5cf7cbf6a6
Make the 'Guides Index' menu link point to index.html
2009-02-23 20:39:54 +01:00
Mike Gunderloy
35a120d5b1
Add ActiveRecord each and find_with_batches to release notes.
2009-02-23 06:37:25 -06:00
Aditya Chadha
8aec733048
More special character removal and added cache_money to the reference list
2009-02-23 01:35:15 -05:00
Aditya Chadha
77aa8a6b81
Take out some special characters that sneaked in
2009-02-23 01:29:13 -05:00
Aditya Chadha
9deb327daa
Added a changelog
2009-02-23 00:53:58 -05:00
Aditya Chadha
7cf3822c56
Updated with all the new cache_store stuff
2009-02-23 00:43:38 -05:00
Aditya Chadha
b9e87f4679
Added info about parameters passed to caches_action and removed More: blocks to clean up a little
2009-02-22 18:45:17 -05:00
Pratik Naik
21b80f8144
Merge commit 'mainstream/master'
2009-02-22 23:52:02 +01:00
Rodrigo Rosenfeld Rosas
91ab75373f
Merge branch 'master' of git://github.com/lifo/docrails
2009-02-22 18:04:00 -03:00
Mike Gunderloy
3e273a0329
Bring 2.3 release notes up to date.
2009-02-22 10:21:09 -06:00
Rodrigo Rosenfeld Rosas
966f86402a
Corrects information about subtemplates.
...
The note about incompatibilities between 2.2 and 2.3 was removed because on Rails 2.2.2, "render :file => 'layouts/application'" works.
2009-02-22 12:18:35 -03:00
Xavier Noria
247b9563ac
let the indexer pass element IDs to the guides generator to avoid coupling, links to sections whose title has textile markup are fixed as well
2009-02-22 00:29:11 +01:00
Andreas Scherer
bd45029f55
RedCloth 4.1.9 is OK.
2009-02-21 18:13:03 +01:00
George Ogata
650a4fd9c6
Document the return value of AR::Base#delete_all.
2009-02-21 23:46:40 +11:00
Daniel Schierbeck
c2a0624526
Fix code blocks inside info boxes
2009-02-20 15:23:31 +01:00
Andreas Scherer
58e064afd2
More spurious backticks replaced/removed.
2009-02-20 13:52:14 +01:00
Andreas Scherer
079eda9ba0
Don't use backticks for markup.
...
Use 'monospaced' for commands.
Separate headers from paragraphs.
2009-02-20 09:47:35 +01:00
Pratik Naik
8a9ef83372
Fix the fucking rake task
2009-02-20 08:57:09 +01:00
Colin Curtin
74fe58add5
Added Rake section to the command line guide.
2009-02-19 21:05:27 -08:00
Pratik Naik
d8f1ee4b41
Merge commit 'mainstream/master'
2009-02-19 21:20:15 +01:00
Andreas Scherer
8ba1fc18e1
Copyediting of the 'migrations' guide.
2009-02-19 19:28:42 +01:00
Andreas Scherer
07a1d645ee
Consistent UPCASE setting of 'SQL'.
...
(Maybe one should use the <acronym> tag for acronyms and apply CSS
'text-transform: uppercase' globally. ;-)
2009-02-19 18:42:41 +01:00
Trevor Turk
1eee0d41f9
Validation and Callbacks cleanup, finishing up Validations
2009-02-18 23:16:10 -06:00
Xavier Noria
a72b171588
Merge branch 'master' of git@github.com:lifo/docrails
2009-02-18 16:45:01 +01:00
Xavier Noria
4185c2b77c
#nil? is not a generated method in belongs_to and has_one associations
2009-02-18 16:43:59 +01:00
Andreas Scherer
d9f037ea1f
Sorry, wrong patch applied.
2009-02-18 16:13:48 +01:00
Andreas Scherer
791407d996
Fix typos and formatting in 'security' from chapter 8 to the end.
...
Without 'conversation'. (Apart from this comment. ;-)
2009-02-18 16:02:49 +01:00
Pratik Naik
07f43a10ff
Revert "Copyediting of the 'security' guide from chapter 8 to the end."
...
This reverts commit b64dd9cd13 .
REASON : Guides should not contain conversations. That should go to LH tickets. Thanks.
2009-02-18 13:39:36 +01:00
Andreas Scherer
b64dd9cd13
Copyediting of the 'security' guide from chapter 8 to the end.
2009-02-18 13:31:42 +01:00
Andreas Scherer
bec07bc5d2
Verbatim markup does not escape angle brackets.
...
If 'attribute' is to be marked as a variable part of a function name, use some
other form of visualization.
2009-02-18 11:38:57 +01:00
Andreas Scherer
4d4e78fe8b
Don't use underscore for emphasis around function containing underscores.
...
Obviously, it is not possible for textile to detect function names containing
underscore characters and ignore them in a '_(highlight) ... _' environment,
even when they're surrounded by '+' marks (which introduces a bunch of other
markup groups). Instead, use direct CSS markup.
2009-02-18 11:21:33 +01:00
Andreas Scherer
245c77666c
Remove superflous 'notextile'.
...
'+' already works as desired.
2009-02-17 23:22:15 +01:00
Xavier Noria
190984567e
textilize titles in ToC of guides
2009-02-17 23:14:58 +01:00
Xavier Noria
fefbddbfdb
added overflow: auto to style of code blocks
2009-02-17 22:37:25 +01:00
Xavier Noria
85d561c408
just nitpicking here and there
2009-02-17 22:22:45 +01:00
Andreas Scherer
fa6494dd5e
Formatting bugs corrected.
2009-02-17 18:06:05 +01:00
Andreas Scherer
16c82cb807
Copyediting the 'Security' guide up to chapter 8.
2009-02-17 17:47:46 +01:00
Xavier Noria
623b1b9669
document :checked => true in #radio_button.
2009-02-17 17:01:49 +01:00
Andreas Scherer
71947e30cc
Fix two errors.
...
Missing article added.
Consistent (at least in this file) use of abbreviation.
2009-02-17 15:05:28 +01:00
Andreas Scherer
48791dda34
Remove empty line that breaks 'code' formatting.
2009-02-17 14:11:59 +01:00
Andreas Scherer
5c4af59732
Use tables for object properties and their purposes.
...
Enumeration lists with bipartite entries could be harder to read than
two-column tables.
2009-02-17 14:04:42 +01:00
Andreas Scherer
d5376a247f
Fix a programming error.
...
Assignment and equality are not the same.
2009-02-17 11:56:18 +01:00
Xavier Noria
d04b8ee530
yet another pass on the action controller guide
2009-02-17 01:31:37 +01:00
Scott Parkerson
9f9f32d44d
Fix Rails LH 1825: better docs for using fixtured data in tests
2009-02-16 11:02:01 -05:00
Andreas Scherer
e8053435ac
Consistent monospaced markup for command options.
2009-02-16 12:07:55 +01:00
Andreas Scherer
ce49b7522a
Delete superfluous escape characters.
2009-02-16 12:00:47 +01:00
Andreas Scherer
f1f5de2efd
Fix two typos.
2009-02-16 11:59:10 +01:00
Andreas Scherer
74c8ff53e7
More tables headers formatted.
2009-02-16 11:47:23 +01:00
Andreas Scherer
e2aeccee94
Mark table headers.
2009-02-16 11:36:28 +01:00
Andreas Scherer
c2c08c15a9
Fix a typo.
2009-02-16 11:35:04 +01:00
Andreas Scherer
3a4f25fb63
Genitiv apostrophe added.
2009-02-16 11:29:41 +01:00
Xavier Noria
6408308aab
fixed example, closes LH ticket #59
2009-02-16 08:47:43 +01:00
Trevor Turk
bc1c856b21
Small improvements to Validations and Callbacks guide
2009-02-15 22:48:41 -06:00
Xavier Noria
a528eb19a6
copyedited the migrations guide
2009-02-15 21:01:31 +01:00
Xavier Noria
bbaf6b58d5
in main.css removed extra line-height and box for TT elements, and reformatted CSS
2009-02-15 20:35:36 +01:00
Xavier Noria
d50457c710
made a complete pass over the Action Mailer guide, it probably needs another one
2009-02-15 02:22:36 +01:00
Xavier Noria
b96ce7f946
small touches to the contribute page
2009-02-15 00:21:32 +01:00
Andreas Scherer
2c6fd1ba87
Merge branch 'master' of git@github.com:lifo/docrails
2009-02-14 15:45:58 +01:00
Andreas Scherer
8eb7ad21cc
Use the controller name 'Greetings' consistently.
...
Moreover, there seems to be a bug in Rails 2.3.0: After editing the view file
apps/views/greetings/hello.html.erb in Vim, WEBrick ships the outdated content
from the backup file apps/views/greetings/hello.html.erb~ instead of the
intended content. Only when the 'tilde backup' file is not present, the browser
shows the correct contents (both Konqueror and Firefox; you can even add a
_different_ hello.html.erb~ to show completely different stuff).
This bug does not occur in Rails 2.2.2.
2009-02-14 15:43:55 +01:00
Mike Gunderloy
dedb9d85d8
Fix AR callbacks sample code to actually make sense
2009-02-14 05:30:32 -06:00
Mike Gunderloy
98f1c4c6ec
Updates to 2.3 release notes.
2009-02-13 07:42:32 -06:00
Mike Gunderloy
11b15d2de2
Layout fixes for configuring guide.
2009-02-12 20:12:22 -06:00
Andreas Scherer
3bfbbeb79d
Improvements for Association Basics.
...
Add active links to internal sections.
Use textile markup for particular words.
Improve the indentation in code examples.
Fix some typos.
2009-02-12 11:21:19 +01:00
Andreas Scherer
d7a5db2885
Use ndash for numerical relations.
2009-02-12 09:09:57 +01:00
Andreas Scherer
115f352deb
Use n-dashes for ranges/relations.
2009-02-12 09:04:07 +01:00
Andreas Scherer
1ce05c5a36
<code> formatting and TIP: formatting improved.
2009-02-11 19:30:15 +01:00
Andreas Scherer
b6fcc471e2
Use explicit HTML charnames for textile-formatted <code/>.
2009-02-11 18:40:44 +01:00
Andreas Scherer
37411e9e57
Fix some formatting errors
...
for <code> elements
for (monospaced) displayed material
add some commas in enumerations.
2009-02-11 15:49:32 +01:00
Andreas Scherer
a088848200
More consistent use of 'an' in front of 'h'.
2009-02-11 14:13:03 +01:00
Andreas Scherer
36f33ef5f6
Improvements for the forms helper guide.
...
Change the wording at several places to improve the reading flow.
Sprinkle some commas into the text.
2009-02-11 11:58:37 +01:00
Andreas Scherer
2012650803
Mistyped HTML corrected.
2009-02-10 19:59:48 +01:00
Andreas Scherer
542e61849e
Fix more typos.
...
A second occurrence of unmatched 'code' markers.
Plain HTML tags are not rendered at all, so use named HTML elements instead.
2009-02-10 19:46:54 +01:00
Andreas Scherer
b42fb934d1
Missing 'code' marker added.
2009-02-10 18:12:30 +01:00
Trevor Turk
ad57d013d4
Removing self from credits - didn't know you needed to complete your own guide
2009-02-10 10:36:21 -06:00
Trevor Turk
447884112a
Revise Observers section, add myself to the credits
2009-02-10 00:43:48 -06:00
Mike Gunderloy
f363ad31b3
Layout cleanup and minor edits for layouts & rendering guide
2009-02-09 19:42:37 -06:00
Mike Gunderloy
662a3e8701
Warning about config.threadsafe! in the configuration guide.
2009-02-09 19:42:36 -06:00
Pratik Naik
6c7e1a9130
Add Model.exists?
2009-02-10 01:49:17 +01:00
Mike Gunderloy
52a650ed7b
Add some clarification of the side effects of threadsafe!
2009-02-09 14:47:42 -06:00
Bobby Wilson
7a1b62ef66
fixed a minor typo, needed an h in Neighborly
2009-02-09 13:32:43 -07:00
Pratik Naik
0108bd6fc7
Removed named scopes from the finders guide. Named scopes deserve it's own guide
2009-02-09 15:00:42 +01:00
Ahmed El-Daly
e297079ddd
Modifications to the first draft of active_mailer_basics
2009-02-09 01:37:07 -05:00
Mike Gunderloy
d4434eddc9
Fix code sample in Association Basics Guide
2009-02-08 05:58:38 -06:00
Hongli Lai (Phusion)
cce017bed5
Improve documentation for ActionController::Streaming. Document 'render :text => proc { ... }' as a way to stream on-the-fly generated data to the browser.
2009-02-08 11:52:58 +01:00
Mike Gunderloy
659ee09e9a
Update the contribute page
2009-02-07 17:00:39 -06:00
Pratik Naik
3b30f4b8ba
Rewrite eager loading and joins sections
2009-02-07 21:50:06 +00:00
Pratik Naik
93c6fc6ee8
Reorder find options under a same section
2009-02-07 18:22:28 +00:00
Pratik Naik
b23ac32959
Improve sections dealing with order, select, limit and locking
2009-02-07 18:10:46 +00:00
Pratik Naik
6929fe6d3e
Improve Conditions section
2009-02-07 16:41:29 +00:00
Pratik Naik
4cf21093e8
Add options to the arg list
2009-02-07 16:11:01 +00:00
Pratik Naik
9fd8538ca4
Improve structure at the beginning of the AR Finders guide
2009-02-07 16:05:38 +00:00
Xavier Noria
01f82d62dc
edged coverage of session storage configuration
2009-02-07 15:06:26 +01:00
Xavier Noria
f11616b521
removed spurious space in changelog of routing guide
2009-02-07 14:31:38 +01:00
Xavier Noria
bc793f58b0
added Changelog section
2009-02-07 14:03:42 +01:00
Ryan Bigg
b7d4d8d6ed
Merge branch 'master' of git@github.com:lifo/docrails
2009-02-07 13:16:09 +10:00
Pratik Naik
c85ce1bcc3
Minor fixes in layout and index
2009-02-07 03:15:24 +00:00
Ryan Bigg
a9b5655948
Fixed up bug reported by Darktatka in regards to :joins outside of lambda.
2009-02-07 13:15:10 +10:00
Pratik Naik
4cf3d4d9d5
Second version of the Rack guide
2009-02-07 02:55:38 +00:00
CassioMarques
b981ab4224
Fixing the description of the i18n guide in the index page
2009-02-06 22:54:47 -02:00
Tore Darell
38a2c4c91e
Add min-height to code,pre to prevent icon from being cut off
2009-02-07 00:40:25 +01:00
Tore Darell
ecc9e86e89
Remove <code> from inside <pre>
2009-02-07 00:38:40 +01:00
Tore Darell
858aaa963c
Reword the session section to reflect that CookieStore has an ID and that you can change they :key and :secret
2009-02-07 00:24:01 +01:00
Mike Gunderloy
1b60c31243
Some cleanup to Credits page
2009-02-06 16:09:06 -06:00
James Miller
715def6b54
Minor formatting fix to contribute page
2009-02-06 08:52:05 -08:00
James Miller
c5472e9238
Add new contribute page to replace existing Hackfest page
2009-02-06 08:45:21 -08:00
James Miller
3e56a38324
Fix spelling errors and references to application.rb in command line guide
2009-02-06 08:02:21 -08:00
James Miller
1a8226977f
Fix spelling errors in caching guide
2009-02-06 07:59:02 -08:00
James Miller
bf43166b92
Fix spelling error in association basics guide
2009-02-06 07:57:34 -08:00
James Miller
a44f613c5f
Fix some spelling erros in Active Record Querying guide
2009-02-06 07:51:11 -08:00
James Miller
ab8f87729e
Fix some spelling errors in the Active Record Basics guide
2009-02-06 07:48:22 -08:00
James Miller
984fbba5e8
Fix some spelling errors in Action Controller guide
2009-02-06 07:44:34 -08:00
Mike Gunderloy
0d92746eea
Update 2.3 release notes.
2009-02-06 07:59:22 -06:00
Pratik Naik
b9ba2fe550
Merge commit 'mainstream/master'
...
Conflicts:
railties/guides/files/javascripts/code_highlighter.js
railties/guides/files/javascripts/guides.js
railties/guides/files/javascripts/highlighters.js
railties/guides/files/stylesheets/main.css
railties/guides/files/stylesheets/print.css
railties/guides/files/stylesheets/reset.css
railties/guides/files/stylesheets/style.css
railties/guides/files/stylesheets/syntax.css
railties/guides/rails_guides/indexer.rb
railties/guides/source/2_2_release_notes.textile
railties/guides/source/2_3_release_notes.textile
railties/guides/source/action_controller_overview.textile
railties/guides/source/action_mailer_basics.textile
railties/guides/source/active_record_basics.textile
railties/guides/source/activerecord_validations_callbacks.textile
railties/guides/source/association_basics.textile
railties/guides/source/caching_with_rails.textile
railties/guides/source/command_line.textile
railties/guides/source/debugging_rails_applications.textile
railties/guides/source/form_helpers.textile
railties/guides/source/getting_started.textile
railties/guides/source/i18n.textile
railties/guides/source/layout.html.erb
railties/guides/source/layouts_and_rendering.textile
railties/guides/source/migrations.textile
railties/guides/source/performance_testing.textile
railties/guides/source/plugins.textile
railties/guides/source/rails_on_rack.textile
railties/guides/source/routing.textile
railties/guides/source/security.textile
railties/guides/source/testing.textile
2009-02-06 02:25:55 +00:00
Pratik Naik
9761239467
Remove whitespaces
2009-02-06 01:55:07 +00:00
Xavier Noria
72a865f793
added a convenience rake task for guides authors
2009-02-05 23:06:15 +01:00
Pratik Naik
ee4b5a4e07
Change the name of perf guide in index/navbar
2009-02-05 16:09:33 +00:00
Mike Gunderloy
e5a5ed5b29
Format and typo cleanup of 2.3 release notes
2009-02-05 07:44:15 -06:00
Mike Gunderloy
3e2bf06405
Add example of creating join table to habtm documentation
2009-02-05 05:16:46 -06:00
Trevor Turk
e7d56a563b
Active Record Validations and Callbacks TODOs added, spelling and small cleanup
2009-02-05 01:25:06 -06:00
Trevor Turk
1b31144961
Fix for validations docs, person.invalid?(:email) should be person.errors.invalid?(:email)
2009-02-05 00:27:52 -06:00
Trevor Turk
4ee9f7979b
Finish TODOs for Active Record Callbacks and Validations, will continue to review
2009-02-04 23:40:49 -06:00
Pratik Naik
4d590a820a
Fix links in performance guide
2009-02-05 01:21:36 +00:00
Trevor Turk
ffd0b1e330
Remove stray API link
2009-02-04 08:54:14 -06:00
Trevor Turk
edffab4112
Merge changes to Active Record Validations section
2009-02-04 08:52:14 -06:00
Trevor Turk
8c9f0ef35a
Formatting cleanup and fixes for Active Record Validations
2009-02-04 08:43:33 -06:00
Pratik Naik
d39290cf0e
Remove API links and add TODOs #26
2009-02-04 14:38:45 +00:00
Pratik Naik
ed1f67447d
Minor rewording on the index page
2009-02-04 13:57:14 +00:00
Mike Gunderloy
7b0a175137
Formatting fixes for Getting Started guide
2009-02-04 07:46:57 -06:00
karmi
e0d79fbf04
Fixed the wrong currency symbol in the i18n guide
2009-02-04 04:10:08 -07:00
Trevor Turk
1ca565a16a
Update Guides, Active Record Validations, better explanation of what methods bypass validations
2009-02-04 01:59:06 -06:00
Trevor Turk
3584d8c8a2
add link to machinist in testing guide under other testing approaches
2009-02-03 23:00:25 -06:00
Colin Curtin
cb6091a93a
Added advanced server command and a mini-generator tutorial.
2009-02-03 19:11:36 -08:00
Pratik Naik
03bb1ebec5
Convert the guides from asciidoc to textile and integrate with the new design.
...
If you're a guide writer and want to generate the guides, Run :
ruby railties/guides/rails_guides.rb
And guides HTML will get generated inside railties/guides/output directory.
2009-02-04 01:44:58 +00:00
Pratik Naik
e4094e23f9
Remove all the guides
2009-02-03 22:58:43 +00:00
Pratik Naik
c0eeb9f1e2
Merge commit 'mainstream/master'
...
Conflicts:
railties/doc/guides/html/action_mailer_basics.html
railties/doc/guides/html/getting_started_with_rails.html
railties/doc/guides/html/i18n.html
railties/doc/guides/source/action_mailer_basics.txt
railties/doc/guides/source/getting_started_with_rails.txt
railties/doc/guides/source/i18n.txt
2009-02-03 22:49:56 +00:00
Yehuda Katz
d6b9f8410c
Remove errant debug code
2009-02-03 08:04:14 -08:00
Xavier Noria
9f030acf22
regenerate guides HTML
2009-02-03 01:08:37 +01:00
Xavier Noria
44a97a769c
details and minor rewordings in Action Mailer guide up to section 2.2
2009-02-03 00:27:25 +01:00
Yehuda Katz
d4a817c066
Make tests pass
2009-02-02 14:01:29 -08:00
Yehuda Katz
ff68430077
Whoops.
2009-02-02 12:03:35 -08:00
Yehuda Katz
9744f687cc
Add support for pending
2009-02-02 11:49:32 -08:00
Yehuda Katz
6faff0223b
Merge commit 'rails/3-0-unstable'
2009-02-02 09:54:27 -08:00
Yehuda Katz
44cdf0c5fe
Some merge cleanup
2009-02-02 09:54:23 -08:00
Karel Minarik
074b501073
I18n guide: Correction -- Invalid .rb dictionaries will crash on first request, not on app startup, due to lazy loading. Thanks @darktatka.
2009-02-02 12:15:07 +01:00
Karel Minarik
8cdfca1b5d
I18n guide: Add warning about YAML sensitivity when storing translation in YAML files, add info about better debugging when using Ruby files for translations: they crash your app during start-up. {i18n}
...
Cf. http://groups.google.com/group/rails-i18n/browse_thread/thread/28f7aff5b8bd8c4d/002edd9466500302?hl=en and many many more other people wondering what's wrong with their YAML.
2009-02-02 11:57:31 +01:00
Karel Minarik
d96483dedf
Add link to Ryan Tomayko's "locale" Rack middleware to i18n guide
...
Part of rack-contrib suite:
http://github.com/rtomayko/rack-contrib/blob/master/lib/rack/locale.rb
2009-02-02 11:52:16 +01:00
Colin Curtin
b29972d1bf
Added the first part to the Rails Advanced Command Line
2009-02-02 00:23:36 -08:00
Mike Gunderloy
1ae0726ade
Regenerate Guides HTML
2009-02-01 13:46:57 -06:00
Mike Gunderloy
a2da53f6a8
Add missing changelog entry to getting started guide
2009-02-01 13:46:56 -06:00
Mike Gunderloy
403c7d46ee
Update associations guide for 2.3
2009-02-01 13:46:56 -06:00
Pratik Naik
2db4ec9a58
Reword the docs for association_foreign_key
2009-02-01 18:23:08 +00:00
Pratik Naik
898d838c7d
Revert "A small addition to the fragment caching documentation"
...
This reverts commit 37fac27cd9 .
REASON : Needs to be reworded and put in the documentation of cache() method
2009-02-01 18:09:18 +00:00
Pratik Naik
a390b2629a
Merge commit 'mainstream/master'
2009-02-01 17:54:45 +00:00
Mike Gunderloy
a4ff4fd2c3
Regenerate HTML
2009-02-01 10:21:17 -06:00
Mike Gunderloy
6a6c8b7759
Getting Started edit + 2.3 content
2009-02-01 10:19:35 -06:00
Mike Gunderloy
3c04448169
Additional links on 2.3 release notes
2009-02-01 10:19:16 -06:00
Mike Gunderloy
ddd5544d9f
Rebuild release note HTML
2009-01-31 20:56:57 -06:00
Mike Gunderloy
e0f48c1585
Update 2.3 release notes
2009-01-31 20:56:57 -06:00
Jeremy Kemper
4945d92b03
Remove dead cgi_ext require
2009-01-31 14:46:02 -08:00
Jeremy Kemper
8da52b13b5
Remove duplicate ConcurrentHash
2009-01-31 14:44:04 -08:00
Pratik Naik
cfddbcd8e7
Regenerate guides html
2009-01-31 21:25:15 +00:00
Ahmed El-Daly
9f097e3c83
Finalised first draft of Active Mailer Basics guide
2009-01-31 16:14:47 -05:00
CassioMarques
8e98b43db0
Getting rid of some of the pre-existent content in the AR basics guide, adding new stuff to it.
2009-01-31 15:12:49 -02:00
Mike Gunderloy
cbf4bef492
Rebuild guides + relnotes HTML
2009-01-31 10:33:29 -06:00
Mike Gunderloy
e4f36e0571
Update 2.3 release notes, plus one late change to 2.2 release notes
2009-01-31 10:33:11 -06:00
Yehuda Katz
3030bc90c9
Merge commit 'rails/3-0-unstable'
...
Conflicts:
actionpack/lib/action_controller/base.rb
actionpack/lib/action_dispatch/http/mime_type.rb
actionpack/lib/action_dispatch/http/request.rb
actionpack/lib/action_view/base.rb
actionpack/lib/action_view/paths.rb
actionpack/test/controller/session/cookie_store_test.rb
actionpack/test/dispatch/rack_test.rb
actionpack/test/dispatch/request_test.rb
2009-01-30 11:30:27 -08:00
Pratik Naik
130b96a9af
Make Partial example more clear
2009-01-30 19:28:23 +00:00
Pratik Naik
807f5f1fd2
Remove core ppl from lead contributors
2009-01-30 19:28:22 +00:00
Yehuda Katz
ae42163bf5
Merge branch 'master' of git@github.com:wycats/rails
2009-01-30 11:01:11 -08:00
Yehuda Katz
da10673e32
Sync 'rails/rails/master'
2009-01-30 10:53:19 -08:00
Ahmed El-Daly
43d63298f7
Merge branch 'master' of git@github.com:lifo/docrails
2009-01-29 23:04:49 -05:00
Ahmed El-Daly
6623e4f92a
Updated the Action Mailer Basics guide
2009-01-29 23:04:25 -05:00
CassioMarques
24b688d31d
More text added to the active record basics guide
2009-01-29 23:22:38 -02:00
Mike Gaffney
bbef826643
changed you to your
2009-01-29 17:15:29 -06:00
Pratik Naik
20d850dac7
Merge commit 'mainstream/master'
2009-01-29 22:33:09 +00:00
Pratik Naik
6932ae4b29
Add Digest authentication
2009-01-29 16:12:10 +00:00
Joshua Peek
85750f22c9
Move dispatch related tests into test/dispatch
2009-01-28 22:50:46 -06:00
Pratik Naik
fbd2cd64e2
Change the license to Creative Commons Attribution-Share Alike
2009-01-28 03:47:17 +00:00
Mike Gunderloy
4290b3cba0
First draft of Rails 2.3 release notes.
2009-01-27 21:04:43 -06:00
CassioMarques
f7a6bc87ab
Advancing in the Active Record Basics guide
2009-01-28 00:21:50 -02:00
Joshua Peek
319ae4628f
Move HTTP libs and middleware into ActionDispatch component
2009-01-27 18:54:01 -06:00
Joshua Peek
a0f2b1d95d
Reorganize ActionController folder structure
2009-01-27 18:17:39 -06:00
Pratik Naik
20e5975380
Remove caching guide for now
2009-01-27 15:35:21 +00:00
Pratik Naik
c06eecfbc2
Regenerate html
2009-01-27 15:12:21 +00:00
Frederick Cheung
94fde8c634
more corrections
2009-01-26 20:45:32 +00:00
Frederick Cheung
d28045fd87
corrections from Xavier
2009-01-26 20:43:43 +00:00
Frederick Cheung
9a5c2d3d5c
remove stray backslashes
2009-01-26 20:43:42 +00:00
Karel Minarik
41fbf746c2
Fixing stylistic issues in i18n guide
2009-01-26 19:52:53 +01:00
Karel Minarik
095c89baeb
Finished the tutorial part of i18n guide (organization of locale files)
2009-01-26 17:04:56 +01:00
Karel Minarik
b24f136fd4
Fixed grammar and formatting issues in i18n guide
2009-01-26 16:26:05 +01:00
Karel Minarik
1b8131bb94
Finished section about "Setting the locale from the client's information": 'Using Accept-Language' and 'Using GeoIP (or similar) database' {i18n guide}
2009-01-26 16:18:28 +01:00
Karel Minarik
6e32e369a9
First part of "Setting locale from the client supplied information" section (using HTTP Accept-Language) {i18n guide}
2009-01-26 15:24:41 +01:00
Karel Minarik
c73f17f379
Added note about Rails' i18n pragmatic to locale keys and differences between eg. en-US / en-UK.
...
Based on feedback from Matt Falkenhagen, http://groups.google.com/group/rails-i18n/browse_thread/thread/64ce98be0fe48388?hl=en
2009-01-26 14:23:52 +01:00
Karel Minarik
0b02e443a1
Clarifying the need and context of patching i18n in Rails 2.2, so we have "available_locales" available {i18n guide}
2009-01-26 13:40:35 +01:00
Karel Minarik
aae0bec4f6
Clarifications for the i18n guide: descriptions of working with URLs like "/en/books"
2009-01-26 13:35:54 +01:00
Karel Minarik
de7100dcb6
Re-wrote intro section w/r/t to i18n/L18n difference, more concrete description
2009-01-26 12:56:43 +01:00
Christos Zisopoulos
72bd7ed807
Updated Object#try doc to match lifo's "no code change" revert c9b8a26ba1
2009-01-26 10:18:58 +01:00
Dimitri Krassovski
37fac27cd9
A small addition to the fragment caching documentation
2009-01-26 10:36:31 +02:00
Christos Zisopoulos
6df580a0a8
An updated description of Object#try to better reflect changes documented at http://is.gd/hdmo and http://is.gd/hdmQ
...
Signed-off-by: Pratik Naik <pratiknaik@gmail.com >
2009-01-26 00:50:21 +00:00
Pratik Naik
c9b8a26ba1
We have a very strict NO code changes policy.
...
Revert "An updated description of Object#try to better reflect changes documented at http://is.gd/hdmo and http://is.gd/hdmQ "
This reverts commit 929088189d .
2009-01-26 00:40:37 +00:00
Christos Zisopoulos
929088189d
An updated description of Object#try to better reflect changes documented at http://is.gd/hdmo and http://is.gd/hdmQ
2009-01-26 01:37:37 +01:00
CassioMarques
68ad1547f9
Starting to work at the Active Record Basics guide
2009-01-25 22:33:11 -02:00
Frederick Cheung
a1fe722263
More minor corrections
2009-01-25 23:59:32 +00:00
Frederick Cheung
893d053fce
no to excessive capitalisation
2009-01-25 23:59:31 +00:00
Frederick Cheung
b3fd79d82d
Rails.root instead of RAILS_ROOT
2009-01-25 23:59:31 +00:00
Frederick Cheung
16f2215d29
AJAX => Ajax
2009-01-25 23:59:31 +00:00
Frederick Cheung
f4c7d42fd4
Some minor typos and corrections
2009-01-25 23:59:31 +00:00
Frederick Cheung
56be53f220
etc... => etc.
2009-01-25 23:59:31 +00:00
Pratik Naik
24ce639647
Regen form guide
2009-01-25 18:13:10 +00:00
Frederick Cheung
cbb6cfd204
point people in the direction of attr_accessible etc...
2009-01-25 12:50:38 +00:00
Frederick Cheung
c6dbd5f45b
some missing fixed width words
2009-01-25 12:43:33 +00:00
Frederick Cheung
098dc68f5c
don't use short form of form_for before it's been introduced
2009-01-25 12:41:11 +00:00
Frederick Cheung
279ec8116c
tweak section name
2009-01-25 12:38:05 +00:00
Frederick Cheung
14dd6c4d2f
add warning about options_from_collection_for_select
2009-01-25 12:36:56 +00:00
Frederick Cheung
13e4b02a5c
find :all -> .all
2009-01-25 12:31:46 +00:00
Frederick Cheung
bf26f42d77
clarify wording around second arg to options_for_select
2009-01-25 12:30:31 +00:00
Frederick Cheung
add4e878a8
lisabon -> lisbon
2009-01-25 12:29:08 +00:00
Pratik Naik
d941297900
Regenerate guides
2009-01-24 15:39:48 +00:00
Frederick Cheung
0aef499451
when mentionning csrf link to the security guide
2009-01-24 15:18:44 +00:00
Frederick Cheung
d40ed8e99e
tidy up dealing with model objects helpers section
2009-01-24 15:11:12 +00:00
Frederick Cheung
9b93620c17
could -> can when appropriate
2009-01-24 15:04:46 +00:00
Frederick Cheung
10dc4bf92c
tidyup section on select boxes
2009-01-24 15:03:57 +00:00
Frederick Cheung
fd10f7025a
Tidy up section on dates and times (and add brief blurb on select_year, select_day etc)
2009-01-24 14:21:47 +00:00
Frederick Cheung
dcb297146a
fix some typos in parameter names section
2009-01-24 13:41:29 +00:00
Frederick Cheung
ba3c9ba22b
attributions belong at the bottom
2009-01-24 13:41:29 +00:00
Karel Minarik
5b1fe6cdf9
Merge branch 'master' of git@github.com:lifo/docrails
2009-01-23 16:15:09 +01:00
Karel Minarik
c20e291b95
Clarified the difference between :foreign_key and :association_foreign_key options in HABTM association
2009-01-23 16:14:00 +01:00
Pratik Naik
7bcdb8a9e0
Add Mailer to the index page and regenerate
2009-01-23 15:11:40 +00:00
Frederick Cheung
231069e683
update with some of fxn's corrections
2009-01-23 01:03:27 +00:00
Yehuda Katz
eb9af20b7c
Begin unifying the interface between ActionController and ActionView
2009-01-22 16:18:10 -06:00
Joshua Peek
cc0b5fa993
Merge branch 'master' into 3-0-unstable
...
Conflicts:
ci/cruise_config.rb
2009-01-22 15:13:47 -06:00
Pratik Naik
741bf96a42
Regenerate guides
2009-01-22 16:07:57 +00:00
Karel Minarik
ca250bdce1
Basic formatting fixes for the rest of the i18n guide (+ some basic cleanups)
2009-01-22 14:44:00 +01:00
Karel Minarik
6cd4fed613
Finished section "Setting locale from the URL params" in i18n guide (+ various typos/formatting fixes)
2009-01-22 14:25:39 +01:00
Karel Minarik
97d9585efa
Complete "Setting locale from the domain name" in i18n guide
2009-01-22 12:31:20 +01:00
Karel Minarik
0eccdd9fb6
Extended and clarified intro section of i18n guide.
2009-01-22 11:47:06 +01:00
Rich Sturim
74fd2d34f2
fixed a few filenames and paths
2009-01-21 23:39:33 -05:00
Ahmed El-Daly
f08a78a057
Merge branch 'master' of git@github.com:lifo/docrails
2009-01-21 22:18:10 -05:00
Ahmed El-Daly
c5069bd495
Draft Action Mailer basics guide, now with section on testing
2009-01-21 22:17:25 -05:00
Rich Sturim
e8f7da6118
updated broken link
2009-01-21 21:12:26 -05:00
George Ogata
db8efc9048
Merge branch 'master' of git@github.com:lifo/docrails
2009-01-22 12:11:32 +11:00
George Ogata
e89138a31b
Update interpolations in i18n guide.
...
Value is available for all messages, and count for some of the
numericality ones.
2009-01-22 12:08:00 +11:00
lholden
19f8bb2808
Merge branch 'master' of git://github.com/rails/rails
2009-01-21 16:17:24 -08:00
Pratik Naik
8ad2f93a30
ActiveRecord => Active Record
2009-01-21 21:35:53 +00:00
Pratik Naik
de23a00776
Regenerate guides
2009-01-21 21:30:37 +00:00
Sven Fuchs
16909d3514
i18n guide: refer to section 'Error messages scopes'
2009-01-21 22:16:30 +01:00
Sven Fuchs
65ae0cc622
i18n guide: add section: overview of other built-in methods
2009-01-21 22:12:59 +01:00
Sven Fuchs
d9fd4c478c
i18n guide: added sections: conclusion, contributing to rails-i18n, resources, authors
2009-01-21 20:48:31 +01:00
Karel Minarik
cc2243dee5
Fixed bad path to image (demo_translated_en.png)
2009-01-21 18:22:55 +01:00
Karel Minarik
47b122468f
Added section about Setting locale from URL to i18n guide
2009-01-21 18:17:42 +01:00
Karel Minarik
b9a0c02820
Basic draft of section "Setting and passing the locale" for i18n guide
2009-01-21 14:35:04 +01:00
Frederick Cheung
41af666fb8
Fix asciidoc formating
2009-01-19 11:47:25 +00:00
Pratik Naik
1e550ccd0d
Regen guides
2009-01-19 02:17:38 +00:00
Frederick Cheung
0de89f8150
link to the validations guide
2009-01-19 02:04:45 +00:00
Frederick Cheung
b9efc8a0ce
rename some sections
2009-01-19 02:01:23 +00:00
Frederick Cheung
a0b2223740
rename section
2009-01-19 01:50:10 +00:00
Frederick Cheung
e8c50fcd5e
Rearrange sections on basic form helpers/form_for
2009-01-19 01:48:52 +00:00
Frederick Cheung
5ccc37e2d9
tidy up some wording
2009-01-19 00:23:21 +00:00
Frederick Cheung
e285ce828e
move section on uploads up
2009-01-19 00:18:51 +00:00
CassioMarques
72d2a64f63
Changed the 'guides' Rake task to ignore Vim swap files during the HTML generation, removed active_record_basics.txt from the ignore list and generated initial HTML of it with previous contents.
2009-01-18 21:56:10 -02:00
Pratik Naik
986a7c620c
Merge commit 'mainstream/master'
2009-01-18 18:13:33 +00:00
Pratik Naik
652ecd3bfa
Fix year in ARes license
2009-01-18 17:47:12 +00:00
Pratik Naik
aeafccf0ca
Merge commit 'mainstream/master'
2009-01-18 17:45:39 +00:00
Xavier Noria
e35e5ed2a4
quoted a couple of strings
2009-01-18 14:40:40 +01:00
Xavier Noria
01337e06dd
in depth revision of AssetTagHelper rdoc
2009-01-18 14:30:34 +01:00
George Ogata
dad45fa21b
Add missing validates_numericality_of message names to i18n guide.
2009-01-18 17:50:56 +11:00
Pratik Naik
69022dfd7b
Add links to lighthouse ticket for i18n guide
2009-01-18 00:31:42 +00:00
Pratik Naik
56152d8f60
Regenerate guides
2009-01-18 00:18:02 +00:00
Karel Minarik
4059f0477d
Add rake task for generating a subset of guides
...
rake guides ONLY='migrations i18n'
Signed-off-by: Pratik Naik <pratiknaik@gmail.com >
2009-01-18 00:07:07 +00:00
Ahmed El-Daly
fe01a13ac5
First go at the Action Mailer guide
2009-01-17 16:35:04 -05:00
Karel Minarik
4dd764207c
Clarifications and additions to the introduction part of Internationalization (I18n) guide
2009-01-17 19:12:13 +01:00
Pratik Naik
3ad392f6f9
Add command line to index and minor change in finders guide
2009-01-17 17:31:23 +00:00
Pratik Naik
e3fd533d03
Revert "Updated readme to include instructions on which dependencies to install before building guides."
...
This reverts commit ef3672ddda .
2009-01-17 16:11:27 +00:00
Xavier Noria
20e57c0276
removed colons from an Options header
2009-01-17 03:22:19 +01:00
Xavier Noria
deeec990ce
removed colons from a few Example headers
2009-01-17 03:20:58 +01:00
Xavier Noria
bb0db1a7cb
reworded docs of AssetTagHelper, Mike helped here
2009-01-17 03:12:54 +01:00
Pratik Naik
ea21b23b92
* Tabs -> Spaces in guides templates
...
* Move inline css to a file
2009-01-16 04:34:34 +00:00
Pratik Naik
7d2e3ef315
Remove version info
2009-01-16 04:19:44 +00:00
Andrew White
1da087ba53
Update route globbing documentation in routing guide
2009-01-15 23:36:33 +00:00
Andrew White
4cbf55344d
Update route globbing documention in RDoc
2009-01-15 23:34:25 +00:00
Cody Fauser
b8907d2e6e
Use :secure key in session_options example instead of :session_secure
2009-01-15 06:56:08 -05:00
CassioMarques
51460808cd
Small modifications in the text of the section about using the errors collection in the view, fixed a typo at the validates_numericality_of section
2009-01-15 00:50:47 -02:00
CassioMarques
301b2fefaa
Fixing mistake in code example with validates_numericality_of and :only_integer option
2009-01-15 00:15:02 -02:00
CassioMarques
9cc7a1e04d
Adding options for validates_numericality_of, adding author name with link at the end of the page
2009-01-14 23:51:07 -02:00
CassioMarques
baa0ce8745
Added Vim old swap files do .gitignore
2009-01-14 23:51:07 -02:00
Yehuda Katz
b8fadd708b
Sync 'rails/rails/master'
2009-01-14 16:48:57 -08:00
Xavier Noria
ed847ad4e6
revised rdoc of class_of_active_record_descendant
2009-01-15 01:01:59 +01:00
Pratik Naik
deb597d63d
Merge commit 'mainstream/master'
2009-01-14 15:36:27 +00:00
Yehuda Katz
f65333a4cf
Sync 'rails/rails/master'
2009-01-13 14:24:14 -08:00
Yehuda Katz
0932b012fa
Sync 'rails/rails/master'
2009-01-13 13:28:28 -08:00
Pratik Naik
e46c807655
Regenerate html
2009-01-13 05:15:07 +00:00
Pratik Naik
59b6ae373c
Update guide to say sessions are lazy loaded
2009-01-13 05:12:40 +00:00
Mike Gunderloy
fbfc54efdd
Edits to validation section
2009-01-12 17:17:44 -06:00
Pratik Naik
547e6d1c3d
Move rake middleware to the top
2009-01-12 21:03:01 +00:00
Pratik Naik
3bf2ee57b0
Update internal middlewares/purpose table.
2009-01-12 18:49:41 +00:00
Chris Kampmeier
2a00f72aca
Docs: in typical usage, "descendant" is the noun and "descendent" is the adjective
2009-01-11 20:47:01 -08:00
Chris Kampmeier
efce9aa71b
A little copyediting of 73db43527d
2009-01-11 20:33:58 -08:00
Chris Kampmeier
73db43527d
Add better docs for ActiveRecord::Base#attribute_for_inspect
2009-01-11 20:28:15 -08:00
Pratik Naik
10a35b0b1d
Add Pratik to authors page
2009-01-11 23:30:14 +00:00
Pratik Naik
24ecfc0041
- Approve performance guide for publication
...
- Rename AR finders guide
2009-01-11 23:30:14 +00:00
CassioMarques
de565b7e1d
Adding explanation about how the callback chain is wrapped in a transaction
2009-01-11 20:35:47 -02:00
Yehuda Katz
6fe739ad75
Sync 'rails/rails/master'
2009-01-11 13:02:44 -08:00
Pratik Naik
8b63abbb08
Add links
2009-01-11 19:51:39 +00:00
Pratik Naik
55c18cfb28
- Add 'Performance test environment' to Performance guide
...
- Add rake middleware and Josh's chat log to Rack guide
- Remove long changelog from Active Record Finders guides
2009-01-11 19:22:19 +00:00
Pratik Naik
bda787e9b1
Initial draft of the rack guide
2009-01-11 15:58:12 +00:00
Colin Law
55901d7d86
Merge branch 'master' of git@github.com:lifo/docrails
2009-01-11 12:13:50 +00:00
Colin Law
3e60ea6c23
Clarified use of assert_select with blocks in testing guide and rdoc text
2009-01-11 11:56:53 +00:00
CassioMarques
cf4b24407a
Getting rid of the example of callback registration by overrinding the callback method name
2009-01-10 17:49:12 -02:00
CassioMarques
32c3ce1d2b
Adding text about conditional callbacks
2009-01-10 17:38:48 -02:00
Pratik Naik
7c81a1ea93
Minor changes to AR#delete/destroy docs
2009-01-10 18:52:59 +00:00
Pratik Naik
b6f33d6bf8
Merge commit 'mainstream/master'
...
Conflicts:
activerecord/lib/active_record/base.rb
2009-01-10 18:43:27 +00:00
Pratik Naik
a5981517e6
Regen html
2009-01-10 16:55:42 +00:00
Mike Gunderloy
1ea5c489f3
Copy editing on performance test guide.
2009-01-10 10:49:33 -06:00
Pratik Naik
f16573afff
Add command line tools to perf guide
2009-01-10 16:26:10 +00:00
Pratik Naik
29664f582c
Fix typos
2009-01-10 04:43:14 +00:00
Pratik Naik
2b384df218
Add a note about tuning perf test runs
2009-01-10 04:37:14 +00:00
Pratik Naik
807c1e899d
Minor changes in performance guide
2009-01-10 03:28:23 +00:00
Yehuda Katz
e8980ad278
Sync 'rails/rails/master'
2009-01-09 18:58:47 -08:00
Pratik Naik
190eb9b07f
Some examples for perf testing
2009-01-10 02:56:14 +00:00
Pratik Naik
8342174b28
Keep movin stuff in perf guide
2009-01-10 01:10:34 +00:00
Pratik Naik
9cffd6f842
More refactoring in perf guide
2009-01-10 00:32:22 +00:00
Pratik Naik
a2a0b44a9a
Some more perf guide stuff
2009-01-09 18:58:27 +00:00
Jeremy Kemper
bb03719943
Fix test broken by test process changes
2009-01-09 00:14:28 -08:00
Jeremy Kemper
431e696b89
Remove Content-Length header from :no_content responses
2009-01-09 00:14:28 -08:00
Jeremy Kemper
72c9834666
Set assigns for integration tests also
2009-01-09 00:14:28 -08:00
Jeremy Kemper
d99b4ec57f
Take care not to mix in public methods
2009-01-09 00:14:28 -08:00
Jeremy Kemper
e3be52c1dd
Use instance_eval instead of adding an accessor to the class
2009-01-09 00:14:28 -08:00
Jeremy Kemper
cf09fa74f7
Include process methods in ActionController::TestCase only. No need to alias_method_chain :process either.
2009-01-09 00:14:27 -08:00
Jeremy Kemper
c2d23affad
Object#tap for Ruby < 1.8.7
2009-01-09 00:14:27 -08:00
Pratik Naik
b1530545d2
Fix JSON decoder date-converter regexp [ #1662 state:resolved] [Jonathan del Strother]
2009-01-09 00:14:27 -08:00
Michael Koziarski
84e6ad3fb9
Spam people with commit rights on test failures.
2009-01-09 00:14:27 -08:00
Mike Gunderloy
a08bbd6a4c
Update CI configuration to reflect latest gems.
2009-01-09 00:14:27 -08:00
CassioMarques
79eba81df8
Added :allow_blank to the common validation options section
2009-01-08 21:16:42 -02:00
CassioMarques
afdacd0857
Moved validates_each to the last position of it's section. Added VIM swap files to .gitignore
2009-01-08 21:00:16 -02:00
Pratik Naik
2c2824a967
Update performance testing guide stuff
2009-01-08 15:57:19 +00:00
Pratik Naik
582e7c115e
Regen guides
2009-01-07 23:56:02 +00:00
Chris Kampmeier
c4193d9f8e
Rewrite ActiveRecord::Base#destroy_all docs to remove incorrect info, mention return value, and improve clarity
...
(The incorrect information is "at least 2*N database queries" -- it's N+1 at best.)
2009-01-06 22:51:57 -08:00
Mike Gunderloy
e57cb2629a
Update CI configuration to reflect latest gems.
2009-01-07 16:59:06 +13:00
Yehuda Katz
dabf20d54b
Sync 'rails/rails/master'
2009-01-06 17:43:58 -08:00
Yehuda Katz
3027f9f918
Sync 'rails/rails/master'
2009-01-05 17:21:29 -08:00
Yehuda Katz
db619c4a41
Sync 'rails/rails/master'
2009-01-05 01:10:55 -08:00
Marc Chung
609a6cb762
Correctly formatted comment
2009-01-04 15:19:06 -07:00
Yehuda Katz
ca54cc5df7
Sync 'rails/rails/master'
2009-01-04 00:56:52 -08:00
Frederick Cheung
2518322197
Merge branch 'master' of git@github.com:lifo/docrails
...
* 'master' of git@github.com:lifo/docrails:
Complete draft of configuring guide; add configuring guide to index; regenerate HTML.
FIx bad date in Guide changelog.
Update table syntax in guides to fix deprecation warnings during build.
Regenarate html
2009-01-04 01:37:15 +00:00
Frederick Cheung
33fe26ef36
fix typos etc. picked up by Xavier
2009-01-04 01:36:08 +00:00
Mike Gunderloy
0230a3e002
Complete draft of configuring guide; add configuring guide to index; regenerate HTML.
2009-01-03 06:40:17 -06:00
Mike Gunderloy
884ae7f5e2
FIx bad date in Guide changelog.
2009-01-03 06:19:44 -06:00
Yehuda Katz
a38c749d8b
Sync 'rails/rails/master'
2009-01-02 22:16:48 -08:00
Mike Gunderloy
8259f06e47
Update table syntax in guides to fix deprecation warnings during build.
2009-01-02 20:04:37 -06:00
Pratik Naik
5a798f094f
Regenarate html
2009-01-01 21:34:12 +00:00
Frederick Cheung
ccae605bca
Mention another complex forms plugin
2009-01-01 20:30:59 +00:00
Frederick Cheung
527ee9b079
Add stub section on complex forms until a definitive solution makes it into core
2009-01-01 20:20:40 +00:00
Frederick Cheung
15b9cbb530
merge work on form helpers guide
...
Merge branch 'form_helpers'
* form_helpers: (30 commits)
claridy handling missing files
Bevy of typo corrections
first stab at the section on file uploads
Delete todo section
info on namespaces
Rearrange the date and form builder sections
Flesh out the section on parameter names
move the fields_for/form builder section higher up
waffle about parameter names and fields_for
Clarify fields_for and form builders
explain fields_for
First draft of section on parameter names
Added section on date/time helpers
country_select url
typos
minor clarifications
Warning about using select on associations
Fix one last remaining 'we'
ActiveRecord -> Active Record
put credits at end, consistent with other guides
...
2009-01-01 19:10:14 +00:00
Frederick Cheung
56634a1297
claridy handling missing files
2009-01-01 19:06:26 +00:00
Yaroslav Markin
1a858f8742
Update flash[] docs a bit.
2009-01-01 21:57:29 +03:00
Frederick Cheung
1dd3df3342
Bevy of typo corrections
2009-01-01 18:56:07 +00:00
CassioMarques
34a10b4242
Removed stuff about overriding validate_on_create on the AR Validations and Callbacks Guide, added new section to the Authors page
2009-01-01 16:51:58 -02:00
Frederick Cheung
d99fa392dd
first stab at the section on file uploads
2009-01-01 18:21:24 +00:00
CassioMarques
d5c7219222
Fix small typo on the 'The declarative validation helpers' section of AR Validations and Callbacks Guide
2009-01-01 15:44:49 -02:00
Frederick Cheung
68ddc72f6f
Delete todo section
2009-01-01 16:59:19 +00:00
Frederick Cheung
f7f1bb7088
info on namespaces
2009-01-01 16:58:55 +00:00
Frederick Cheung
2e1cd2e1fd
Rearrange the date and form builder sections
2009-01-01 16:43:07 +00:00
Frederick Cheung
e94dfb260c
Flesh out the section on parameter names
2009-01-01 16:40:04 +00:00
Frederick Cheung
ebfa76e3ac
move the fields_for/form builder section higher up
2009-01-01 10:39:22 +00:00
Frederick Cheung
2ea0c3d61b
waffle about parameter names and fields_for
2009-01-01 10:38:23 +00:00
Frederick Cheung
32fee815fa
Clarify fields_for and form builders
2009-01-01 10:32:22 +00:00
Frederick Cheung
d9e6413492
explain fields_for
2009-01-01 10:09:47 +00:00
Jeremy Kemper
42b32938d9
Only silence backtrace from plugin lib dirs
2009-01-01 00:13:12 -08:00
Jeremy Kemper
658cf556d2
Test that exceptions raised in filters are properly rescued
2009-01-01 00:13:11 -08:00
Jeremy Kemper
6b3c702bd7
Fix formatted_* deprecation message
2009-01-01 00:13:11 -08:00
Jeremy Kemper
724151d881
Clean trailing / after rails root from backtraces
2009-01-01 00:13:11 -08:00
Mike Gunderloy
feb807dda1
Fix named scope tests for sqlite3 [ #1667 state:resolved]
...
Signed-off-by: Pratik Naik <pratiknaik@gmail.com >
2009-01-01 00:13:11 -08:00
Mike Gunderloy
abfa46e3a6
Add transaction check to SQLite2 adapter to fix test_sqlite_add_column_in_transaction_raises_statement_invalid [ #1669 state:resolved]
...
Signed-off-by: Pratik Naik <pratiknaik@gmail.com >
2009-01-01 00:13:11 -08:00
Joshua Peek
ab7c25d511
Clean up view path cruft and split path implementations into Template::Path and Template::EagerPath
2009-01-01 00:13:11 -08:00
Mike Gunderloy
860dd77006
Fix failing gem dependency tests [ #1659 state:resolved]
...
Signed-off-by: Pratik Naik <pratiknaik@gmail.com >
2009-01-01 00:13:10 -08:00
Mike Gunderloy
c5e9aa0040
Fix FCGI dispatching tests
...
Signed-off-by: Pratik Naik <pratiknaik@gmail.com >
2009-01-01 00:13:10 -08:00
Mark Reginald James
ea20901764
Fixed incorrect parsing of query parameters with mixed-depth nesting inside an array [ #1622 state:resolved]
...
Signed-off-by: Frederick Cheung <frederick.cheung@gmail.com >
2009-01-01 00:13:10 -08:00
Frederick Cheung
373e94a03f
Fix to_sentence being used with options removed by 273c77
2009-01-01 00:13:10 -08:00
Roman Shterenzon
7276128fb4
Fix HasManyAssociation#create ignoring the :primary_key option [ #1633 state:resolved]
...
Signed-off-by: Frederick Cheung <frederick.cheung@gmail.com >
2009-01-01 00:13:10 -08:00
Frederick Cheung
27cfeb7cbc
Fix :include of has_one with :primary_key option
2009-01-01 00:13:10 -08:00
Frederick Cheung
3825f173d9
Fix :include of has_many associations with :primary_key option
2009-01-01 00:13:10 -08:00
Jeremy Kemper
15702104a5
Don't construct object deprecation proxy if unneeded
2009-01-01 00:13:09 -08:00
Chris Kampmeier
58646544ab
Fix grammar (it's -> its)
2008-12-31 15:44:17 -07:00
Chris Kampmeier
b2357d1b5b
Fix some spelling, grammar, and typography in the Validations and Callbacks guide
2008-12-31 15:40:24 -07:00
Frederick Cheung
f207129ac6
First draft of section on parameter names
2008-12-31 20:17:25 +00:00
Frederick Cheung
0ac7a936c9
Added section on date/time helpers
2008-12-31 19:25:05 +00:00
heavysixer
429ef9ce20
Removing topics that are covered in another guide.
2008-12-31 12:47:21 -06:00
Frederick Cheung
70ad0b590f
country_select url
2008-12-31 18:46:37 +00:00
Frederick Cheung
c525059a98
typos
2008-12-31 18:39:32 +00:00
Frederick Cheung
c3dae67b79
minor clarifications
2008-12-31 18:30:41 +00:00
Frederick Cheung
074b1138b6
Warning about using select on associations
2008-12-31 18:17:17 +00:00
Frederick Cheung
904b3d8fce
Fix one last remaining 'we'
2008-12-31 18:10:09 +00:00
Frederick Cheung
ddd1aa294a
ActiveRecord -> Active Record
2008-12-31 18:09:40 +00:00
Frederick Cheung
85b22f79ab
put credits at end, consistent with other guides
2008-12-31 18:08:38 +00:00
Frederick Cheung
a8ca7c051d
exorcise we/us/ours
2008-12-31 18:06:23 +00:00
Frederick Cheung
1f3db5a0b0
clarify option value
2008-12-31 17:55:57 +00:00
Frederick Cheung
8f9f3e6e29
fix mistakes from merge
2008-12-31 17:18:12 +00:00
Frederick Cheung
66b88129cc
Tidy up discussion of second hash passed to form_tag/html options for form_for
2008-12-31 17:13:12 +00:00
Frederick Cheung
6c8974e5db
Waffle about the difference between text_field and f.text_field
2008-12-31 17:13:11 +00:00
Frederick Cheung
7156d58381
Add warning
2008-12-31 17:13:11 +00:00
Frederick Cheung
092b1d8433
Stylistic tweak
2008-12-31 17:13:11 +00:00
Frederick Cheung
73ebb26ece
describe foo_tag versus foo
2008-12-31 17:13:11 +00:00
Frederick Cheung
d6c38f15d2
Describe options_from_collection_for_select
2008-12-31 17:13:11 +00:00
Frederick Cheung
b3f265ac2e
fix typo
2008-12-31 17:06:00 +00:00
Pratik Naik
2a37726958
Add validations guide to index
2008-12-31 15:28:16 +00:00
Xavier Noria
6260dee015
This example seems unnecessary. Note that the examples of form helpers depict just their traditional usage. The documentation of form_for is the one that makes the link with form builders. On the other hand, people are expected to know what's a hidden field in HTML forms.
2008-12-31 01:19:59 +01:00
bparanj
3dae667d8f
Simple example added for using hidden_field tag used in a form
2008-12-30 15:00:35 -08:00
Xavier Noria
9c3c88a894
document edge cases in AR calculations, and wrap some comments
2008-12-30 02:45:23 +01:00
Michael S. Klishin
31fb733bae
It was decided that Multibyte does not belong to as/mini.
2008-12-29 23:31:57 +03:00
Chris Kampmeier
477d37a0fb
Rewrite ActiveRecord::Base#delete docs to remove false information about callbacks, mention return value, and improve clarity
2008-12-29 03:05:05 -05:00
Ryan Bigg
377e72c700
James B. Byrne's suggestions
2008-12-29 14:19:09 +10:30
Daniel Schierbeck
bf95e5a802
Made code segments and method names have fixed-width fonts
2008-12-29 03:00:22 +01:00
CassioMarques
a1f22f520b
Added missing images for the AR validations and callbacks guide
2008-12-28 22:56:51 -02:00
CassioMarques
006a640fc4
Fixed error message that was written in portuguese instead of english...
2008-12-28 21:49:33 -02:00
CassioMarques
495c7109fe
New content for the AR Validations and Callbacks guide: Added a section about using error messages in view templates, added text about custom validation helpers
2008-12-28 21:27:31 -02:00
Michael S. Klishin
069534af4f
Sync with rails/rails/master
2008-12-29 00:50:18 +03:00
Michael S. Klishin
19208e7422
Pull up some other changes from rails/rails/master
2008-12-29 00:16:42 +03:00
Michael S. Klishin
bdba0b9a7a
Sync i18n update from rails/rails/master
2008-12-28 23:48:18 +03:00
Michael S. Klishin
2b8750eba4
Sync with rails/rails/master, merge two metaprogramming annotation efforts
2008-12-28 23:47:29 +03:00
Pratik Naik
d6c2285e31
Merge commit 'mainstream/master'
2008-12-28 20:00:29 +00:00
Michael S. Klishin
e523b43e20
Use active_support/mini instead of active_support/minimalistic
2008-12-28 22:18:03 +03:00
Michael S. Klishin
12bff2af40
Sync with wycats/rails/master
2008-12-28 22:05:43 +03:00
Michael S. Klishin
89e98955c7
active_support/minimalistic.rb => active_support/mini.rb
2008-12-28 21:41:48 +03:00
Pratik Naik
aaea12c497
Revert inline docs
2008-12-28 16:01:38 +00:00
Michael S. Klishin
d77deb89d5
Annotated metaprogramming code across ActiveSupport
2008-12-28 13:21:10 +03:00
Michael S. Klishin
133925804f
Introduce minimalistic package for ActiveSupport.
...
To simplify using of ActiveSupport in 3rd party libraries,
a simple way to require only minimum of commonly used extensions
(multibyte, inflections, array and hash extensions, #blank?, and a few
others) is needed. For exactly this reason some out-of-Rails-space
libraries adopted Extlib, originally from DataMapper.
To keep it 2067% backwards compatible, and still available
to everyone even in 2.x releases, active_support/minimalistic.rb
was added.
Use it like this:
gem 'active_support', '>=2.3'
require 'active_support/minimalistic'
instead of
require 'activesupport'
Right now this package with RubyGems uses about 10 megs of RAM
(10.01 or so). It can be further slimmed down though, once we simplify
multibyte implementation that right now uses advanced accessors
from Module extensions.
To compare RAM usage with previous ActiveSupport versions and Extlib,
at the time of writing, see http://gist.github.com/40401 .
2008-12-28 11:26:57 +03:00
Andrew Timberlake
297276b99c
Added documentation to gsub_file method
2008-12-28 01:25:23 -05:00
Chris Kampmeier
1ea13fce1a
Rewrite ActiveRecord::Base.delete docs for clarity, and mention return value
2008-12-27 18:03:19 -05:00
Mike Gunderloy
fa6218c923
Regenerate Guides HTML
2008-12-27 16:16:49 -06:00
Xavier Noria
8b1d69d197
adds more inline docs for dynamically created methods in Active Support
2008-12-27 20:49:28 +01:00
Xavier Noria
6adfbf2844
adds inline docs for dynamically created methods in Active Record
2008-12-27 20:25:41 +01:00
Xavier Noria
0ba8dcb444
adds inline docs for dynamically created methods in Action Pack
2008-12-27 20:06:45 +01:00
Xavier Noria
8cabcbd272
adds inline docs for dynamically created methods in Active Support
2008-12-27 19:28:32 +01:00
Mike Gunderloy
711512a42b
More formatting cleanup for testing guide
2008-12-27 09:34:56 -06:00
Mike Gunderloy
930b20678e
Fix typo in layout and rendering guide
2008-12-27 09:07:55 -06:00
Mike Gunderloy
6d0639c95e
Merge patch on subtemplates into layouts & rendering guide
2008-12-27 09:05:37 -06:00
Mike Gunderloy
e51b8e2036
Add information on new rendering syntax to layouts + rendering guide
2008-12-27 08:52:32 -06:00
Mike Gunderloy
d65a24c49e
Formatting changes on index and testing guide
2008-12-27 08:23:33 -06:00
Mike Gunderloy
8584922705
Add version links to index
2008-12-27 08:03:36 -06:00
Yaroslav Markin
fa0502494e
It is better to have this commented out to let locale-checking scripts perform better (rails-i18n)
2008-12-27 13:27:54 +03:00
Aditya Chadha
dce642f22a
Fixed typo
2008-12-27 02:50:30 -05:00
Yehuda Katz
5da3ba1215
Merge commit 'rails/master'
2008-12-26 23:16:52 -08:00
Chris Kampmeier
d49fa21a03
ActionController::Request docs: fix reference to nonexistent ACCEPTED_HTTP_METHODS constant, clean up #request_method and #method
2008-12-26 16:32:14 -05:00
Yehuda Katz
9b2da52914
Merge commit 'rails/master'
2008-12-26 12:29:44 -08:00
Pivotal Labs
fe9239e9c6
Documentation for merged joins
2008-12-26 17:29:45 +00:00
Pratik Naik
d9ca219e3e
Merge commit 'mainstream/master'
2008-12-26 17:29:35 +00:00
Pratik Naik
73e9f4e909
Merge commit 'mainstream/master'
2008-12-26 17:18:06 +00:00
Michael S. Klishin
e4314d4362
Inline the only call site of Mime::Type#browser_generated?
...
Signed-off-by: Michael S. Klishin <michael@novemberain.com >
2008-12-26 04:13:16 +03:00
Yehuda Katz
69e349f1bb
Initial work to merge several places with similar logic
2008-12-25 17:12:33 -08:00
Mislav Marohnić
2cd8d3b4c5
form helpers: twakes based on feedback; more content; set outline for remaining topics
2008-12-25 00:23:51 +01:00
Ryan Bigg
ee69bac14e
Xavier Noria suggestions added! Guides #16 , parts 27-29.
2008-12-23 21:28:10 +10:30
Ryan Bigg
d4a5c9c4ef
Added section on having.
2008-12-22 00:27:37 +10:30
Ryan Bigg
e691d486a9
Added section about using expressions as values for the lock option.
...
Added description of how to get hash conditions to use the in expression.
2008-12-22 00:15:59 +10:30
Colin Curtin
10e601bd91
Command Line Guide: Added short console/dbconsole/plugin/runner/destroy/about
2008-12-20 20:34:58 -08:00
Colin Curtin
0e121f9ed9
Merge branch 'master' of git@github.com:lifo/docrails
2008-12-20 20:21:20 -08:00
Ryan Bigg
a0d091a416
Fixed http://rails.lighthouseapp.com/projects/16213/tickets/16-activerecord-finders#ticket-16-22 minus two points.
2008-12-21 13:55:14 +10:30
Ryan Bigg
4fc9f69e54
Merge branch 'master' of git@github.com:lifo/docrails
2008-12-21 13:30:51 +10:30
Ryan Bigg
199f4c54ea
Added more to the hashn conditions section.
2008-12-21 13:28:11 +10:30
Pratik Naik
19939fd4c0
Merge commit 'mainstream/master'
...
Conflicts:
activerecord/lib/active_record/connection_adapters/abstract/connection_specification.rb
activerecord/lib/active_record/connection_adapters/abstract/schema_definitions.rb
2008-12-19 14:29:14 +00:00
Pratik Naik
2d78ee0de6
Revert "Fix example using wrong method name"
...
This reverts commit 5745b25c9f .
2008-12-19 14:25:58 +00:00
Pratik Naik
6c375d9505
Merge commit 'mainstream/master'
2008-12-19 14:10:42 +00:00
Ryan Bigg
46702e6a6d
Merge branch 'master' of git@github.com:lifo/docrails
2008-12-19 22:11:29 +10:30
Ryan Bigg
0021f5e655
Better documentation for options_from_collection_for_select.
2008-12-19 22:10:46 +10:30
Mike Gunderloy
17f3ab3b83
Fix bad link in Getting Started, rebuild HTML
2008-12-17 07:11:59 -06:00
Ryan Bigg
9b2dd332f1
Correct one instance of table syntax.
2008-12-17 22:21:05 +10:30
Colin Curtin
b0187434bd
Started working with the scaffold instead of model generator to teach models
2008-12-16 23:06:11 -08:00
Ryan Bigg
fd117c52fa
Fixed up syntax errors.
2008-12-17 09:33:10 +10:30
Sven Fuchs
76f87802a2
i18n guide: add note about #t and #l aliases
2008-12-16 18:11:32 +01:00
Sven Fuchs
d6e6754ebe
i18n guide: add screenshots and explain localize method
2008-12-16 18:10:02 +01:00
Sven Fuchs
d736327e7d
i18n guide: renumber footnotes (do i really need to do this manually?)
2008-12-16 18:08:41 +01:00
Sven Fuchs
b71c09f008
i18n guide: add link to rails-i18n wiki about "How to encode the current locale in the url"
2008-12-16 17:24:18 +01:00
Sven Fuchs
837e8da815
i18n guide: actually use footnotes
2008-12-16 16:48:13 +01:00
Sven Fuchs
99d16fa40e
add quote from wikipedia about I18n and L10n
2008-12-16 16:36:38 +01:00
Sven Fuchs
44a831940d
explain exceptions, exception_handler and :raise option
2008-12-16 16:31:15 +01:00
Sven Fuchs
f333661ec2
explain changes of pluralization feature
2008-12-16 15:52:28 +01:00
Sven Fuchs
f388babc72
explain purpose of interpolation feature
2008-12-16 15:52:02 +01:00
Sven Fuchs
26b7bd941d
use new asciidoc table syntax
2008-12-16 15:51:31 +01:00
Sven Fuchs
bf0ffc5486
note about #t helper vs I18n.t
2008-12-16 14:18:19 +01:00
Sven Fuchs
ab757d8d75
i18n guide: remove remaining references to en-US, use Symbols for locales
2008-12-16 13:52:18 +01:00
Pratik Naik
ce0e208410
Merge commit 'mainstream/master'
2008-12-16 12:05:27 +00:00
Ryan Bigg
016fffff6d
Documented some undocumented activerecord methods.
2008-12-16 13:54:26 +10:30
Ryan Bigg
a3161ff415
Updated finders guide to include hash conditionals.
2008-12-16 13:54:26 +10:30
Frederick Cheung
9952435cff
Fix formatting typo
2008-12-15 16:00:32 +00:00
Frederick Cheung
f2b69d56e4
Fix typo
2008-12-14 16:51:30 +00:00
CassioMarques
539fafc30c
Added some text about the possibility of observers' registration also at the config/environment files (AR Validations and Callbacks Guide)
2008-12-13 22:09:39 -02:00
CassioMarques
f06ea06297
Updated section about halting execution of operations when a before_xxx callback returns false (AR Validations and Callbacks Guide)
2008-12-13 21:41:52 -02:00
CassioMarques
596cd8317b
Some more info about the effect of calling the clear method upon a model's errors collection (AR Validations an Callbacks Guide)
2008-12-13 21:22:34 -02:00
Xavier Shay
7bf5fb07ad
ActionMailer::Base - add example of multiple recipients and make the format of addresses obvious
2008-12-12 12:32:55 -08:00
Pratik Naik
9b98362cda
Merge commit 'mainstream/master'
...
Conflicts:
railties/doc/guides/html/activerecord_validations_callbacks.html
railties/doc/guides/source/activerecord_validations_callbacks.txt
2008-12-11 12:40:22 +00:00
athonlab
ea12819adf
Minor asciidoc syntax fixes to the testing guide.[Luke Amdor]
2008-12-11 14:00:25 +05:30
Mike Gunderloy
1b6a828739
Fix bad RDoc markup on update_all.
2008-12-10 05:56:22 -06:00
Frederick Cheung
5745b25c9f
Fix example using wrong method name
2008-12-10 09:55:26 +00:00
CassioMarques
098cb8333c
Wrap code lines longer than 80 columns on AR validations and callbacks guide
2008-12-09 22:37:46 -02:00
CassioMarques
dce92e6d10
Fixed typos on validates_numericality_of all over AR validations and callbacks guide
2008-12-08 18:02:47 -02:00
Daniel Luz
c942eccfa0
Update documentation for default_scope
2008-12-08 16:50:56 -02:00
Daniel Luz
0f7207fff1
Fix method "exists?" name in documentation
2008-12-08 16:37:09 -02:00
Mike Gunderloy
067468b882
Remove bad markup on validation method placeholders
2008-12-08 08:34:08 -06:00
Pratik Naik
8f1c229571
Merge commit 'mainstream/master'
...
Conflicts:
actionmailer/lib/action_mailer/base.rb
actionpack/lib/action_controller/base.rb
actionpack/lib/action_controller/mime_type.rb
railties/doc/guides/html/activerecord_validations_callbacks.html
railties/doc/guides/html/caching_with_rails.html
railties/doc/guides/html/command_line.html
railties/doc/guides/html/configuring.html
railties/doc/guides/html/creating_plugins.html
railties/doc/guides/html/finders.html
railties/doc/guides/html/routing_outside_in.html
railties/doc/guides/source/activerecord_validations_callbacks.txt
railties/doc/guides/source/caching_with_rails.txt
railties/doc/guides/source/command_line.txt
railties/doc/guides/source/creating_plugins/acts_as_yaffle.txt
railties/doc/guides/source/creating_plugins/controllers.txt
railties/doc/guides/source/creating_plugins/core_ext.txt
railties/doc/guides/source/creating_plugins/helpers.txt
railties/doc/guides/source/creating_plugins/index.txt
railties/doc/guides/source/creating_plugins/migration_generator.txt
railties/doc/guides/source/creating_plugins/models.txt
railties/doc/guides/source/creating_plugins/odds_and_ends.txt
railties/doc/guides/source/creating_plugins/routes.txt
railties/doc/guides/source/finders.txt
railties/doc/guides/source/routing_outside_in.txt
railties/doc/guides/source/testing_rails_applications.txt
2008-12-07 03:05:03 +01:00
Felix Dominguez
601e40e744
Updated Actionpack README. Removed reference to examples that have long since been removed from the distribution. Examples were removed by David on 09-09-07 in subversion changset 7424 http://dev.rubyonrails.org/changeset/7424
2008-12-03 09:02:47 -06:00
Chris Kampmeier
ecf52ba9af
Update the Action Pack README a bit to use the current API and fix errors
2008-12-03 00:10:00 -08:00
Chris Kampmeier
7b52deca32
Remove old sections on pagination and components from Action Pack's README
2008-12-02 02:05:43 -08:00
CassioMarques
4d177a5939
Added documentation for Observers in the AR validations and callbacks guides
2008-12-01 22:00:01 -02:00
Chris Kampmeier
e264337c7b
ActiveRecord#to_param docs: fix a few singular/plural errors
2008-11-30 19:46:43 -08:00
Chris Kampmeier
e2380600d1
Improve ActiveRecord#exists? docs
2008-11-30 19:39:01 -08:00
Ryan Bigg
b3fd941874
Added using an SQL function example to Selecting Certain Fields section as per http://rails.lighthouseapp.com/projects/16213/tickets/36-adding-an-example-for-using-distinct-to-ar-finders
2008-12-01 00:24:52 +10:30
Mike Gunderloy
a92a43c648
Regenerate Guides HTML
2008-11-30 07:08:41 -06:00
Mike Gunderloy
2b0d345497
Typo fixes to various guides.
2008-11-30 07:08:41 -06:00
athonlab
ce2eadba59
Minor syntax fixes to the testing guide.
2008-11-30 17:43:14 +05:30
Chris Kampmeier
f204e515ae
Fix typo and cleanup docs for #expire_fragment [ #1398 state:resolved]
2008-11-29 18:10:54 -08:00
Colin Curtin
4812e350b9
Merge branch 'master' of git@github.com:lifo/docrails
2008-11-26 10:18:03 -08:00
Colin Curtin
78af01f80b
Next installment: more of the generate script, but should probably go
...
with explaining scaffolding instead of hacking an existing controller.
2008-11-26 10:15:17 -08:00
Vincent Woo
d18bfa2a41
Tiny doc example change for escape_once()
...
Signed-off-by: Pratik Naik <pratiknaik@gmail.com >
2008-11-26 14:34:47 +01:00
CassioMarques
55d70f3a98
Added some text about callbacks classes
2008-11-25 20:36:56 -02:00
Daniel Schierbeck
1f31ba7163
Made documentation of validates_presence_of use monospaced fonts correctly.
2008-11-25 20:48:29 +01:00
Yaroslav Markin
010cce6ad1
Fix an example of using Inflector's #parameterize.
2008-11-25 12:26:46 +03:00
Yaroslav Markin
c98bcfa55c
I18n guide: changed to reflect new i18n locale naming, added a link to rails-i18n.org
2008-11-24 12:28:29 +03:00
Aditya
d67adf1e33
Update with globally keyed fragments
2008-11-23 15:17:03 -05:00
Aditya
f3ac3fafbc
Updated with Conditional GET section lifted from Ryan's posts on the topic
2008-11-23 14:32:42 -05:00
Aditya
54f4be8303
Add config.cache_store blurb and note about Rails using the bundled memcached-client gem
2008-11-23 14:09:36 -05:00
Aditya
6e6c0f37ff
Merge branch 'master' of git@github.com:lifo/docrails
2008-11-23 13:37:39 -05:00
Aditya
5df4a67797
Fixed width font changes
2008-11-23 13:34:35 -05:00
CassioMarques
490e02b17d
Added some more text on Active Record callbacks
2008-11-23 16:31:44 -02:00
Ryan Bigg
e95f5417e8
Was very naughty and did not add changelog message to guide.
2008-11-23 22:28:05 +10:30
Ryan Bigg
e04abd5741
Updated finders guide to include newcomers find_last_by and find_by_bang!
2008-11-23 21:09:58 +10:30
Mike Gunderloy
76018a1658
Final changes for 2.2 release notes
2008-11-21 10:20:21 -06:00
Ryan Bigg
3e762e8a97
Updated finders guide based on: http://rails.lighthouseapp.com/projects/16213-rails-guides/tickets/16-activerecord-finders#ticket-16-13
2008-11-21 11:27:54 +10:30
Ryan Bigg
2b94b3437e
Fixed all points in http://rails.lighthouseapp.com/projects/16213-rails-guides/tickets/16-activerecord-finders#ticket-16-11
2008-11-19 22:46:37 +10:30
Ryan Bigg
70a983a6a7
Merge branch 'master' of git@github.com:lifo/docrails
2008-11-19 22:18:24 +10:30
CassioMarques
c6e5ffbc5c
Added some text about AR callbacks
2008-11-18 22:10:02 -02:00
CassioMarques
b60971ad6b
Added note about update_attribute not triggering validation
2008-11-18 19:16:01 -02:00
Mike Gunderloy
64e8f14058
Configuration options for Active Model, Active Resource, Active Support
2008-11-18 11:05:04 -06:00
Mike Gunderloy
b930d2f259
Finishing up RDoc 2.x markup for cattr_accessors
2008-11-18 11:03:31 -06:00
Mike Gunderloy
24bc0b267d
Regenerate Guide HTML
2008-11-18 10:50:42 -06:00
Mike Gunderloy
9707d1787d
FIx minor errors in Getting Started & Associations guides
2008-11-18 10:50:21 -06:00
Ryan Bigg
9dbb52d97e
Merge branch 'master' of git@github.com:lifo/docrails
2008-11-18 10:40:50 +10:30
Xavier Noria
c62f973c74
Merge branch 'master' of git@github.com:lifo/docrails
2008-11-18 00:41:52 +01:00
Xavier Noria
90a1a9a225
adding a config file for asciidoc, needs latest mizuho to take effect
2008-11-18 00:41:20 +01:00
Sven Fuchs
047657cdfb
initial draft for i18n guide
2008-11-18 00:41:06 +01:00
Tore Darell
e1e0c12617
Fix various typos, add note about X-Sendfile to AC guide
2008-11-17 22:16:42 +01:00
Mike Gunderloy
74569f3e20
Structure change to AR Associations Guide
2008-11-17 08:37:59 -06:00
Mike Gunderloy
896cff4ffb
Fix bad link in Getting Started guide
2008-11-17 06:41:32 -06:00
Jeff Dean
3fbd9acc5c
Plugin guide: Edits
2008-11-17 00:45:20 -05:00
Jeff Dean
f22b686ebb
Plugin guide: re-ran rake guides
2008-11-17 00:17:15 -05:00
Jeff Dean
236142d23e
Rails plugin: misc error fixes.
2008-11-17 00:15:20 -05:00
Jeff Dean
eda282f857
Re-ran rake guides
2008-11-16 23:11:40 -05:00
Jeff Dean
223ffb5fa5
Merge branch 'master' of git@github.com:lifo/docrails
2008-11-16 23:09:26 -05:00
Jeff Dean
e08af72197
Rails guide: Misc reorganization
2008-11-16 23:09:12 -05:00
Jeff Dean
6b8500ce48
Rails guide: Added PluginGem section, reorganized the odds and ends.
2008-11-16 22:27:08 -05:00
Mike Gunderloy
80f5f26547
Added Action View and Action Mailer documentation to the Config guide.
2008-11-16 20:46:36 -06:00
Mike Gunderloy
1d8c4cf6e0
Fix markup for cattr_accessors in Action View and Action Mailer to work better with RDoc 2+.
2008-11-16 20:46:36 -06:00
Jeff Dean
097b4678f6
Plugin Guide: added section on migrations, updated generator section, tightened up spacing of P's inside LI's
2008-11-16 20:30:42 -05:00
CassioMarques
b58d0a9447
Added 'Using the errors collection' to the AR validations and callbacks guide
2008-11-16 22:13:25 -02:00
Tom Stuart
3e026a73d2
Fix typo in routing guide
2008-11-16 19:17:52 +00:00
Mike Gunderloy
2f3867ad90
Added documentation of Action Controller configuration options to Configuration guide.
2008-11-16 06:57:16 -06:00
Mike Gunderloy
b9fdf60e72
Fix markup for cattr_accessors in Action Controller to work with RDoc 2+.
2008-11-16 06:56:44 -06:00
Trevor Turk
22a5acaa99
note that rake:db:migrate updates db/schema.rb by invoking db:schema:dump
2008-11-15 12:53:36 -06:00
Mike Gunderloy
1d910aac0a
Added documentation of ActiveRecord configuration options to Configuration Guide.
2008-11-15 10:48:16 -06:00
Mike Gunderloy
46afe7cfff
Fix markup for cattr_accessors in ActiveRecord to work with RDoc 2+.
2008-11-15 10:47:32 -06:00
Mike Gunderloy
7701b0611c
Additional details on config.gem processing for 2.2 release notes
2008-11-15 09:13:47 -06:00
Mike Gunderloy
b43ed561b1
Typo fix in 2.2 relnotes (core ticket #1378 )
2008-11-15 08:10:30 -06:00
Matt Jones
779df30087
Update info on routing parameter defaults, better example for :requirements in map.resource.
2008-11-14 11:46:19 -05:00
Mike Gunderloy
0a2d779e22
Getting a few recent changes into 2.2 release notes.
2008-11-14 07:00:43 -06:00
Pratik Naik
62f99d1c6b
Please dont change code. 4146efc380
2008-11-14 17:46:14 +05:30
Pratik Naik
17b1387646
Merge commit 'mainstream/master'
...
Conflicts:
railties/doc/guides/html/actioncontroller_basics.html
railties/doc/guides/html/activerecord_validations_callbacks.html
railties/doc/guides/html/debugging_rails_applications.html
railties/doc/guides/html/testing_rails_applications.html
railties/doc/guides/source/actioncontroller_basics/methods.txt
railties/doc/guides/source/actioncontroller_basics/params.txt
railties/doc/guides/source/actioncontroller_basics/request_response_objects.txt
railties/doc/guides/source/actioncontroller_basics/session.txt
railties/doc/guides/source/activerecord_validations_callbacks.txt
railties/doc/guides/source/debugging_rails_applications.txt
railties/doc/guides/source/testing_rails_applications.txt
2008-11-14 17:41:25 +05:30
Jeff Dean
fa9ea057d1
Plugin guide: updated to start working with GemPlugin
2008-11-14 03:14:09 -05:00
Jeff Dean
88a13fad4f
Rails plugin: Expanded helpers section
2008-11-14 03:02:05 -05:00
Jeff Dean
7eb249291d
Plugin guide: added model and controller sections
2008-11-14 02:29:12 -05:00
Jeff Dean
8a9bd56ca0
Plugin Guide: updated test setup and generator sections
2008-11-14 00:38:52 -05:00
Jeff Dean
4146efc380
Plugin guide: update generator guide to include tests
2008-11-13 23:29:46 -05:00
Jeff Dean
41d0dbcb86
Plugin guide: update acts_as section
2008-11-13 01:44:34 -05:00
Jeff Dean
bc75de8e4f
Plugin Guide: updated core_extensions section
2008-11-13 00:51:54 -05:00
Jeff Dean
c78c247c72
Merge branch 'master' of git@github.com:lifo/docrails
2008-11-13 00:06:27 -05:00
athonlab
1dff35063b
Merge branch 'master' of git@github.com:lifo/docrails
2008-11-13 09:31:58 +05:30
athonlab
ff359af865
Rails testing guide revised based on feedback from Pratik and few miscellaneous fixes. [ #8 ]
2008-11-13 09:31:10 +05:30
Colin Curtin
c874b3d44f
Merge branch 'master' of git@github.com:lifo/docrails
2008-11-12 16:01:28 -08:00
Colin Curtin
bb0fead1db
The beginnings of a command line tutorial
2008-11-12 16:00:27 -08:00
CassioMarques
0fbfd4fe0d
Fix typo on 'custom validations', at AR validation and callbacks guide
2008-11-12 21:42:52 -02:00
CassioMarques
fdd1ef5ca2
Added 'custom validations' to AR validations and callbacks guide
2008-11-12 21:41:35 -02:00
Mike Gunderloy
af320ef220
Fix typo in routing guide.
2008-11-12 10:45:29 -06:00
Mike Gunderloy
9655d6205f
Regenerate Guides HTML
2008-11-12 08:29:18 -06:00
Mike Gunderloy
e5d6b82efb
Add :except and :only documentation to the Routing Guide
2008-11-12 08:27:47 -06:00
Mike Gunderloy
c2794b4957
Add :except and :only for resource routes to 2.2 release notes.
2008-11-12 08:18:50 -06:00
Ryan Bigg
451969f57a
Merge branch 'master' of git@github.com:lifo/docrails
2008-11-12 21:45:51 +10:30
Ryan Bigg
7f023b5e3b
Updated finders guide
2008-11-12 21:45:42 +10:30
Jeff Dean
40bc386ed8
Plugin Guide: cleaned up file paths, made formatting more consistent
2008-11-12 02:05:19 -05:00
Jeff Dean
7f24653e7a
Plugins guide: Cleanup the intro
2008-11-12 01:48:02 -05:00
Jeff Dean
6b143ab86f
Plugins Guide: added example of how to run tests, including how to run with multiple databases
2008-11-12 01:33:53 -05:00
Jeff Dean
ccd9ef1589
Updated preparation section of plugins guide
2008-11-12 01:21:09 -05:00
Jeff Dean
ef3672ddda
Updated readme to include instructions on which dependencies to install before building guides.
2008-11-12 00:59:13 -05:00
CassioMarques
29e053979e
Changed conditional validation with Proc to use :unless instead of :if
2008-11-11 22:36:37 -02:00
CassioMarques
3645fd15db
Added 'Conditional Validations' to AR validations and callbacks guide
2008-11-11 22:34:24 -02:00
CassioMarques
fc714840fe
Added 'Common Validation Options'
2008-11-11 20:16:33 -02:00
CassioMarques
31dcce8c1c
Added documentation for validates_uniqueness_of
2008-11-10 21:02:40 -02:00
CassioMarques
6f944c06c8
Added info about validates_size_of, as being an alias for validates_length_of
2008-11-10 20:40:32 -02:00
CassioMarques
d0cb4d7258
Added note about testing booleans to validates_presence_of
2008-11-10 20:31:05 -02:00
CassioMarques
0668ab67bf
Added documentation for validates_presence_of
2008-11-10 20:24:51 -02:00
CassioMarques
5affa79f2a
Added documentation for validates_numericallity_of
2008-11-10 19:15:40 -02:00
Aditya
41f4a25857
Merge branch 'master' of git@github.com:lifo/docrails
2008-11-09 21:59:04 -05:00
Aditya
bb444e61ee
Updated as per Xavier's notes, still to do: Etags and globally keyed fragments
2008-11-09 21:58:49 -05:00
CassioMarques
23de31aae1
Added documentation for validates_length_of
2008-11-10 00:58:04 -02:00
CassioMarques
10c7c053a1
Added documentation for validates_inclusion_of
2008-11-10 00:03:16 -02:00
CassioMarques
0419efc1b9
Added documentation for validates_format_of
2008-11-09 23:02:01 -02:00
CassioMarques
561900fb67
Added documentation for validates_exclusion_of
2008-11-09 22:45:05 -02:00
Tore Darell
6831b4b033
Merge branch 'master' of git@github.com:lifo/docrails
2008-11-09 23:42:50 +01:00
Tore Darell
21bd7edb10
Be consistent with using symbols for options to methods
2008-11-09 23:41:55 +01:00
Tore Darell
c86e797070
Use SHA1 instead of MD5 in the HTTP basic example
2008-11-09 23:25:42 +01:00
Tore Darell
f599c5844e
Fix typo in section about request/response
2008-11-09 23:25:05 +01:00
CassioMarques
172f3ce350
Added documentation for validates_each
2008-11-09 19:31:47 -02:00
Mike Gunderloy
fb30b82bd0
Mention DB2 Adapter transactional migration support in 2.2 relnotes.
2008-11-09 12:54:27 -06:00
Mike Gunderloy
3baa44ab00
Add collection counters to layouts & rendering guide
2008-11-09 10:30:32 -06:00
Tore Darell
6babecf862
Make changes to AC guide as suggested by Xavier Noria
2008-11-09 15:42:08 +01:00
Mike Gunderloy
119a6397f5
Fix major gaffe about shallow routes in routing guide & release notes, regen guides html
2008-11-09 06:45:34 -06:00
Xavier Noria
759ace7e87
added a comma suggested by Brandon Zylstra in LH
2008-11-09 10:05:42 +01:00
Xavier Noria
2146b34ee7
fixed missing "you" reported by Brandon Zylstra in LH
2008-11-09 10:04:47 +01:00
Mike Gunderloy
367282a634
Rewrite start of Finders guide to be more consistent with other guides.
2008-11-08 06:25:21 -06:00
Mike Gunderloy
23adb6f7c7
Format & edit cleanup of named scope guide
2008-11-08 05:52:19 -06:00
Mike Gunderloy
89448b01aa
Amend description of SQLite in Getting Started guide ( #33 )
2008-11-08 05:06:04 -06:00
Mike Gunderloy
48e21793bf
Fix typo in Getting Started guide ( #34 )
2008-11-08 05:01:31 -06:00
Mike Gunderloy
0129f00a81
Fix typos in Debugging Guide (core LH #1388 )
2008-11-08 04:57:19 -06:00
CassioMarques
30a7894299
Some more text on validates_confirmation_of, added some more about validations helpers too
2008-11-07 23:59:36 -02:00
CassioMarques
4d122503bb
Added some aditional info to validates_confirmation_of
2008-11-07 23:51:45 -02:00
CassioMarques
2cefcef8fe
Added documentation for validates_confirmation_of
2008-11-07 23:28:21 -02:00
CassioMarques
879eba22f2
added doc for validates_associated
2008-11-07 21:17:57 -02:00
CassioMarques
0c3752390c
Added some more text about how validations work, included validates_acceptance_of
2008-11-07 20:51:27 -02:00
CassioMarques
414d482978
AR validations and callbacks - Chaper 2: When does validations happens?
2008-11-05 22:09:57 -02:00
Daniel Schierbeck
0306fe53ed
Improved the use of monospace fonts in the documentation of ActionController::Base.
2008-11-05 23:04:40 +01:00
CassioMarques
24ef23d0aa
AR validations and callbacks: Chapter 1 - Motivations to validate your Active Record objects
2008-11-05 19:47:39 -02:00
Pratik Naik
215122890b
Merge commit 'mainstream/master'
2008-11-06 01:07:10 +05:30
Mike Gunderloy
94f3a94b0b
Outline for Configuration Guide
2008-11-05 12:43:53 -06:00
Pratik Naik
09b2e3c555
Oops. Remove CAUTION from AC basics guide
2008-11-06 00:06:24 +05:30
Pratik Naik
366b7048d8
Regen html
2008-11-05 23:59:13 +05:30
Tore Darell
64060f2303
Adding myself to the authors page
2008-11-05 17:31:23 +01:00
Mike Gunderloy
0fe9f9eb2c
Add more documentation pointers to Getting Started Guide.
2008-11-05 08:55:58 -06:00
Mike Gunderloy
37ea9de5af
Copy edit on AC Basics Guide
2008-11-04 20:18:47 -06:00
CassioMarques
746fed22ff
Initial commit for Active Record validations and callbacks guide
2008-11-04 22:35:41 -02:00
Tore Darell
6eb128fde3
Clarify something in the session storage section
2008-11-05 00:39:30 +01:00
Tore Darell
4f48ab7544
Clarify the section mentioning session stores
2008-11-05 00:28:40 +01:00
Tore Darell
b8a9c4fa29
Add example using routing parameters
2008-11-05 00:25:31 +01:00
Tore Darell
9d08df5bd8
Use ApplicationController instead of AC::B in example
2008-11-05 00:17:56 +01:00
Tore Darell
ce66cc642a
Add example of using default_url_options
2008-11-05 00:13:24 +01:00
Tore Darell
6e48cd202c
Add example to show how to add additional headers using the response object
2008-11-05 00:04:40 +01:00
Tore Darell
4adbaadad3
Add section on CSRF to AC guide
2008-11-04 23:55:23 +01:00
Tore Darell
6d12daf5a7
Merge branch 'master' of git@github.com:lifo/docrails
2008-11-04 23:20:21 +01:00
Mike Gunderloy
e884f2b832
Regenerate recently-changed guides.
2008-11-04 10:00:40 -06:00
Mike Gunderloy
f7540e9b61
Typo fix in testing guide
2008-11-04 09:53:10 -06:00
Hongli Lai (Phusion)
851a4dce15
Remove invalid uses of [source, ...] in the guides.
2008-11-04 16:45:50 +01:00
Hongli Lai (Phusion)
bc0bc83b90
Remove invalid use of [source, log] in the 'Debugging Rails Applications' guide.
2008-11-04 16:05:47 +01:00
Hongli Lai (Phusion)
f22458ef85
Update guides generation task: make it compatible with the latest changes in Mizuho.
2008-11-04 15:32:28 +01:00
Mike Gunderloy
5b97ca95c5
Fix a typo in 2.2 release notes ( http://rails.lighthouseapp.com/projects/8994/tickets/1324 )
2008-11-04 06:20:59 -06:00
Tore Darell
5c1f4aa401
Remove API links
2008-11-04 12:18:44 +01:00
Mike Gunderloy
e025f94cbe
Formatting tweaks on Getting Started, regen Guides HTML
2008-11-03 14:23:29 -06:00
Tore Darell
a32be96753
Keys -> values
2008-11-03 21:08:46 +01:00
Tore Darell
2a4d808726
Link to Wikipedia page on HTTP Basic Auth
2008-11-03 21:05:37 +01:00
Tore Darell
eb9417139f
Fixed typo, removed TODO from AC guide
2008-11-03 21:04:30 +01:00
Mislav Marohnić
ebeebc8c93
update forms guide: tweaks from feedback, first half of select boxes chapter
...
commit d7bdbd791ab2ec38329a7d53e21c4f0f8c7f883b
Author: Mislav Marohnić <mislav.marohnic@gmail.com >
Date: Fri Oct 24 22:24:11 2008 +0200
mockup of the select tags section
commit 558926bc101960c1a96122bdbaa5389524bc265b
Author: Mislav Marohnić <mislav.marohnic@gmail.com >
Date: Fri Sep 19 11:16:15 2008 +0200
tweaks from the ticket
2008-11-03 19:02:47 +01:00
Mike Gunderloy
9b6cefe739
Finalized debugging guide.
2008-11-03 11:08:28 -06:00
miloops
77c6ba9fcd
Added RJS, memory leaks and plugins chapters to Debugging Rails Applications guide. Generated Guides.
2008-11-03 12:58:38 -03:00
miloops
6744a8b1bc
Added missing sidebar block closing delimiter.
2008-11-03 12:52:53 -03:00
George Ogata
dce9455f1b
Fix typo in AR Basics guide.
2008-11-03 04:36:21 +11:00
Heiko Webers
93b647ca7b
Updated guide authors.txt with Heiko's bio
2008-11-02 15:53:48 +01:00
Xavier Noria
86e14e3e2c
fixes a typo
2008-11-02 14:55:12 +01:00
Pratik Naik
09597f7140
Merge commit 'mainstream/master'
2008-11-02 18:45:08 +05:30
Pratik Naik
140a5c0d9d
Revert "Added information about @performed_redirect for redirect_to calls."
...
This reverts commit 712e8ed2aa .
REASON : No need to document internals
2008-11-02 17:58:18 +05:30
Pratik Naik
485bbc953d
Remove unnecessary files
2008-11-02 17:58:18 +05:30
Luca Guidi
27ec3ee009
Made more clear the case of ignored :limit option for eager loaded associations
2008-11-02 10:36:38 +01:00
Pratik Naik
1147453fce
Merge commit 'mainstream/master'
...
Conflicts:
railties/doc/guides/html/layouts_and_rendering.html
railties/doc/guides/source/active_record_basics.txt
railties/doc/guides/source/layouts_and_rendering.txt
2008-11-02 03:52:15 +05:30
Mike Gunderloy
a3aa0c17ef
Marking Getting Started and Security guides as finished.
2008-11-01 13:41:18 -05:00
Mike Gunderloy
4e801ee764
Error fix and some reformatting for Layouts/Rendering Guide
2008-11-01 10:00:32 -05:00
Mike Gunderloy
82f46da522
Add warning about deprecated partials behavior to Layout/Rendering Guide
2008-11-01 07:03:15 -05:00
Mike Gunderloy
1d84c158c1
Update 2.2 relnotes & Layouts/Rendering Guide to include render :js
2008-11-01 06:14:02 -05:00
Mike Gunderloy
4bb13a2bfb
Update release notes.
2008-10-31 04:40:29 -05:00
Ryan Bigg
3b2b77baae
Removed extra space from the array conditions section.
2008-10-31 11:15:12 +10:30
Tom Stuart
08d81fdc5c
Update auto_link documentation to use new API (overlooked in Rails commit 10d9fe4)
2008-10-30 11:53:57 +00:00
Mike Gunderloy
d83eda9b69
Clarify use of :select on :belongs_to in AR Associations Guide
2008-10-29 08:16:40 -05:00
Mike Gunderloy
40d049e981
Fix typo in routing guide, regenerate routing + actioncontroller guides
2008-10-29 06:15:34 -05:00
Tore Darell
d669e5585e
Remove TODO from filters part in AC guide
2008-10-28 22:41:52 +01:00
Mike Gunderloy
65145e3692
Typo fix for AR Associations Guide
2008-10-28 06:16:27 -05:00
Mike Gunderloy
92320985fa
Fix reference to StringQuestioneer (renamed to StringInquirer) in 2.2 release notes
2008-10-27 12:12:21 -05:00
Mike Gunderloy
f7b6e70b71
Fix bug in layout guide, regenerate guides html
2008-10-27 11:16:18 -05:00
Ryan Bigg
fbe1e32008
Added scoped section, added named params for conditions and added sub-section headers for conditions section.
2008-10-27 23:09:56 +10:30
Ryan Bigg
712e8ed2aa
Added information about @performed_redirect for redirect_to calls.
2008-10-27 14:59:10 +10:30
Ryan Bigg
8129057d9b
Fixed up according to this comment: http://rails.lighthouseapp.com/projects/16213-rails-guides/tickets/16-activerecord-finders#ticket-16-6 with exception of final point.
2008-10-27 11:16:29 +10:30
Hongli Lai (Phusion)
295195b707
Write documentation for the cache stores.
2008-10-26 22:25:52 +01:00
Mike Gunderloy
094a910653
Editing pass on AR Finders guide.
2008-10-26 11:56:44 -05:00
heavysixer
14f05140e5
Merge branch 'master' of git@github.com:lifo/docrails
2008-10-25 13:33:39 -05:00
heavysixer
35f29f7ea5
fixing some disjointed ADD style writing.
2008-10-25 13:33:09 -05:00
Mike Gunderloy
650aa01578
One more link for Release notes
2008-10-25 08:12:26 -05:00
Pratik Naik
1dcde46329
Update rn html
2008-10-25 18:11:18 +05:30
Mike Gunderloy
b0caf6c54b
Typo fixes in 2.2 release notes
2008-10-24 20:17:15 -05:00
Mike Gunderloy
8afe33b147
Fix a few more typos in 2.2 release notes.
2008-10-24 19:36:18 -05:00
Pratik Naik
14fb65ca16
Hey..generate html ;-)
2008-10-25 04:27:34 +05:30
Mike Gunderloy
164bdd6743
Tiny cleanup in layouts & rendering guide
2008-10-24 17:52:58 -05:00
Pratik Naik
0ea10019f7
Enum#many?
2008-10-25 04:18:49 +05:30
Pratik Naik
b62c164997
And html too
2008-10-25 03:10:00 +05:30
Mike Gunderloy
c0eb4d07ab
2.2 Relnotes: more info on association proxies
2008-10-24 16:28:35 -05:00
Pratik Naik
b02e010751
Regenerate guides again
2008-10-24 22:57:05 +05:30
Pratik Naik
e7f06a8d50
Fix release notes
2008-10-24 22:20:08 +05:30
Pratik Naik
ec5070c2e2
Generate new guides
2008-10-24 22:20:07 +05:30
Heiko Webers
190381ae95
new header injection section for security guide
2008-10-24 18:38:46 +02:00
Pratik Naik
6b41e0257a
Merge commit 'mainstream/master'
...
Conflicts:
railties/doc/guides/html/2_2_release_notes.html
railties/doc/guides/source/2_2_release_notes.txt
2008-10-24 21:39:04 +05:30
Mike Gunderloy
9ae15df21c
Updates to Getting Started: REST references, partials, filters, some cleanup.
2008-10-24 08:50:32 -05:00
Tore Darell
3e6686dc9e
Add link to Layouts & rendering guide
2008-10-24 15:42:26 +02:00
Mike Gunderloy
75320ac50a
Added details on how Rails locates layouts to Layouts & Rendering guide
2008-10-24 07:42:17 -05:00
Mike Gunderloy
1cf5eb39ae
Fix grids in AR guide
2008-10-23 14:25:27 -05:00
Mike Gunderloy
bb2ac1d40a
Fix minor formatting issues on AR guide
2008-10-23 14:18:47 -05:00
heavysixer
92937fbf9b
The _at / _on timestamp methods do the same things, I seemed to remember a distinction at some point but I guess that's changed.
2008-10-23 13:57:35 -05:00
heavysixer
67ed370d8e
adding some documentation of the Active Record conventions and reserved words.
2008-10-23 11:59:38 -05:00
heavysixer
e6b1674f03
More restructuring of this document. Trying to make the text less verbose and more to the point.
2008-10-23 11:19:48 -05:00
Pratik Naik
1662e297ee
Add release notes and stuff
2008-10-23 19:14:42 +05:30
Pratik Naik
079b5bf7a5
Merge commit 'mainstream/master'
2008-10-23 17:44:02 +05:30
Pratik Naik
50820a9de1
Dont copy images twice
2008-10-22 21:52:02 +05:30
Pratik Naik
c399e80e04
Fix icons
2008-10-22 21:47:16 +05:30
Ryan Bigg
4a53eb8a79
Merge branch 'master' of git@github.com:lifo/docrails
2008-10-22 21:46:49 +10:30
Ryan Bigg
a325010d6c
First "completed" version of the finders guide... and about time too!
2008-10-22 21:46:27 +10:30
Pratik Naik
303919c626
generate html too
2008-10-21 18:24:27 +01:00
Mike Gunderloy
85c1dff660
Add license to Guides.
2008-10-21 11:55:28 -05:00
Pratik Naik
a06990acac
Fix index
2008-10-21 17:44:25 +01:00
Pratik Naik
5dd10c881c
Add rake task to generate guides inside a rails app
2008-10-21 17:38:42 +01:00
Pratik Naik
e72a37a7ea
New html files
2008-10-21 17:29:12 +01:00
Pratik Naik
5ca4cacfd1
Dont fetch images from internet
2008-10-21 17:26:25 +01:00
Pratik Naik
4a73524018
Ignore images/stylesheets inside html dir
2008-10-21 17:11:48 +01:00
Pratik Naik
657476743e
Use custom templates and stuff
2008-10-21 17:10:21 +01:00
Mike Gunderloy
a0614cd225
Fix up broken links in Getting Started guide
2008-10-21 10:44:56 -05:00
Pratik Naik
facff42810
Fix that dir.html.html guide name
2008-10-21 16:38:42 +01:00
Pratik Naik
5265a8cd40
Rearrange guides
2008-10-21 16:04:38 +01:00
Pratik Naik
fa09de351c
Merge commit 'mainstream/master'
2008-10-21 14:29:41 +01:00
Pratik Naik
d2f3bddaeb
Minor change to generated perf tests
2008-10-21 14:16:46 +01:00
George Ogata
b3e812393e
Fix Japanese spelling in AS::Multibyte::Chars#slice documentation.
2008-10-21 04:09:07 +11:00
Ryan Bigg
e6d5fc1020
Merge branch 'master' of git@github.com:lifo/docrails
2008-10-21 00:04:51 +10:30
Ryan Bigg
a912148151
More work done on finders guide, extended named_scope sectionn
2008-10-21 00:04:22 +10:30
Mike Gunderloy
6937923d5a
Added note on route generation from arrays.
2008-10-20 06:15:24 -05:00
Mike Gunderloy
c3ea1054f7
Edit pass on security guide.
2008-10-19 20:32:12 -05:00
Mike Gunderloy
38c9048666
Typo fixes in Getting Started guide.
2008-10-19 19:36:32 -05:00
Mike Gunderloy
b99c475b21
Editing pass on debugging guide.
2008-10-19 19:26:46 -05:00
Mike Gunderloy
2e91fb84f0
Fixes to Getting Started guide
2008-10-19 16:57:02 -05:00
heavysixer
b4f7ef6577
Revisions to AR Basics Doc.
2008-10-18 17:13:30 -05:00
heavysixer
ac5962a98c
Added a brief overview of the intent of the guide and a high-level explanation of ORM and ActiveRecord.
...
Notice: there are some references from Wikipedia and RDOC and the Rails API that are directly pasted into this document, they are reference material and will not appear in the final draft.
2008-10-18 12:23:02 -05:00
heavysixer
05c3339b14
fleshing out the topics and removing some redundancy.
2008-10-18 10:24:27 -05:00
heavysixer
6ef78cca58
fleshing out some of the sub-topics of this guide.
2008-10-18 10:11:21 -05:00
Ryan Bigg
2139a1b681
Merge branch 'master' of git@github.com:lifo/docrails
2008-10-18 17:43:38 +10:30
Ryan Bigg
09b7e35131
Fixed obvious duplication of select_minute docs for select_hour [props to Zarathu in #rubyonrails]
2008-10-18 17:43:14 +10:30
Pratik Naik
095cafbcd7
Compiling rubies installing gems
2008-10-17 02:11:33 +02:00
Xavier Noria
4ab8c087e7
revised documentation of collection.delete
2008-10-17 02:04:50 +02:00
Mike Gunderloy
2636807dfb
More detail on partials.
2008-10-16 18:57:42 -05:00
Mike Gunderloy
03626f0c13
Additional detail on rendering partials
2008-10-16 18:57:42 -05:00
Pratik Naik
086c8c28c9
Add info about benchmark() helper and stuff
2008-10-17 01:27:43 +02:00
Pratik Naik
0ed341ebac
Remove fiveruns. And preamble->index
2008-10-16 22:51:23 +02:00
Pratik Naik
0242d81703
Merge with mainstream rails
2008-10-16 22:20:32 +02:00
heavysixer
7e2777348b
Adding a stub file for the guide i'll be writing.
2008-10-16 14:56:32 -05:00
Pratik Naik
6f0eb93f95
Mark layout/rendering guide as done
2008-10-16 21:31:15 +02:00
Mike Gunderloy
5c90c988f8
A few updates to Getting Started guide
2008-10-16 10:40:58 -05:00
Mike Gunderloy
ecfcb498d0
Marking layout guide completed
2008-10-16 10:34:09 -05:00
Mike Gunderloy
9d270e4b99
Minor formatting change in Getting Started guide.
2008-10-16 07:06:36 -05:00
Mike Gunderloy
7f744244e1
Revised draft of Getting Started guide.
2008-10-16 07:06:36 -05:00
Michael Hartl
27ad5c4bbb
Added example for hash-style argument to find conditions
2008-10-15 20:47:08 -07:00
Mike Gunderloy
98ccf7e862
Edit/formatting pass for the testing guide
2008-10-14 20:28:15 -05:00
Tore Darell
3677fa0a16
Sorry Pratik, typoed your name :)
2008-10-15 00:11:03 +02:00
Karel Minarik
99918a4c68
Merge branch 'master' of git@github.com:lifo/docrails
2008-10-14 11:24:53 +02:00
Mike Gunderloy
9768325def
First complete draft of "getting started" guide
2008-10-14 10:20:13 +02:00
Mike Gunderloy
0aeb2dcf13
Edits and rewrites (work in progress)
2008-10-14 10:20:13 +02:00
athonlab
5ba2fdf047
Adds examples of integration tests in the testing guide.
2008-10-14 10:20:12 +02:00
Mike Gunderloy
a00f9a649c
Fix egregious error in documenting :class_name
2008-10-14 10:20:12 +02:00
athonlab
5bd6f580cf
Updated to testing mailers section in the testing guide.
2008-10-14 10:20:12 +02:00
athonlab
46ecc7b086
Removes the 'Filtering emails in development' section from testing guide.
2008-10-14 10:20:12 +02:00
Heiko Webers
7f7083514b
small fixes in security guide
2008-10-14 10:20:12 +02:00
Tore Darell
53f5696613
Add description of flash.now
2008-10-14 10:20:12 +02:00
Mike Gunderloy
514239d599
First complete draft of "getting started" guide
2008-10-13 19:31:37 -05:00
Mike Gunderloy
800fbcce78
Edits and rewrites (work in progress)
2008-10-12 20:59:16 -05:00
athonlab
7a076a61ff
Adds examples of integration tests in the testing guide.
2008-10-12 18:39:01 +05:30
Mike Gunderloy
6e8496af38
Fix egregious error in documenting :class_name
2008-10-11 17:55:02 -05:00
athonlab
c02a70bdc3
Updated to testing mailers section in the testing guide.
2008-10-12 03:35:07 +05:30
athonlab
4d25326f1b
Removes the 'Filtering emails in development' section from testing guide.
2008-10-11 23:43:53 +05:30
Heiko Webers
cc5e6f5cc2
small fixes in security guide
2008-10-11 15:56:48 +02:00
Tore Darell
add1e42165
Add description of flash.now
2008-10-10 17:43:39 +02:00
Karel Minarik
b38a80323f
Stated the need to specify "config.gem" +:lib+ option for libraries where the Gem name (eg. "sqlite3-ruby") differs from the file itself (eg. "sqlite3")
...
This affects great number of popular gems and is *really* frustrating to get "you have to rake gems:install" permanently when you *know* you just did that.
See eg. http://groups.google.com/group/rubyonrails-talk/browse_thread/thread/afefb09908f36db/
2008-10-10 11:41:30 +02:00
Mike Gunderloy
efdad93542
Typo fix in routing guide
2008-10-09 19:54:02 -05:00
Tore Darell
9b109c9e66
Merge branch 'master' of git@github.com:lifo/docrails
2008-10-09 18:57:40 +02:00
Mike Gunderloy
eeb8d1cae3
Minor change on :name_prefix and :path_prefix documentation.
2008-10-09 05:01:35 -05:00
Tore Darell
272e70eb32
Remove part about Ruby's rescue
2008-10-08 19:07:20 +02:00
Tore Darell
49c0b127e6
Remove the bit about rescue_action
2008-10-08 19:02:04 +02:00
Ryan Bigg
3979d26752
Merge branch 'master' of git@github.com:lifo/docrails
2008-10-09 00:35:03 +10:30
Ryan Bigg
224060aa82
Did some more work on the finders guide tonight, lock and count sections addded.
2008-10-09 00:34:46 +10:30
Tore Darell
b4da5f6770
Fix links in AC guide
2008-10-07 22:16:28 +02:00
Tore Darell
dfc0b1a716
Add verification, rescue + fixes to AC basics
2008-10-07 20:51:00 +02:00
Mike Gunderloy
3da0c0a842
Additional detail on routes for namespaced controllers.
2008-10-07 06:03:53 -05:00
Mike Gunderloy
973bd54d83
Added some additional detail on asset caching syntax.
2008-10-07 05:43:44 -05:00
Mike Gunderloy
7a920bca4d
Clarify that the event sequence shown in the comments applies to new records only.
2008-10-06 07:53:09 -05:00
Ryan Bigg
a21d8f632f
Merge branch 'master' of git@github.com:lifo/docrails
2008-10-06 11:57:12 +10:30
Ryan Bigg
b340337aaf
Added a small section on using conditions on tables from eager loads.
2008-10-06 11:56:17 +10:30
Pratik Naik
6090513cfb
Merge commit 'mainstream/master'
...
Conflicts:
activerecord/lib/active_record/association_preload.rb
2008-10-05 19:46:48 +01:00
Ryan Bigg
1f4bed7b12
Updated guide, adding to the conditions section mostly.
2008-10-05 22:33:54 +10:30
Mike Gunderloy
01159a6431
Additional detail on specifying verbs for resource member and collection routes.
2008-10-04 09:06:57 -05:00
Mike Gunderloy
70d4cbb837
Additional detail on options for rendering partials.
2008-10-04 08:45:13 -05:00
Mike Gunderloy
1728b8bc91
Revise associations guide: no need to set default on counter_cache columns.
2008-10-04 08:31:50 -05:00
Mike Gunderloy
2fc835d646
Remove erroneous warning about counter_cache column defaults.
2008-10-04 08:30:20 -05:00
Chris Kampmeier
f2dee49153
Fix typography and punctuation in ActiveRecord#find_by_sql
2008-10-04 00:16:29 -07:00
Ryan Bigg
f2a713c473
Finders guide has no table of contents.
2008-10-01 21:48:19 +09:30
Ryan Bigg
dbbd757edd
Merge branch 'master' of git@github.com:lifo/docrails
2008-10-01 21:38:16 +09:30
Ryan Bigg
6aca4458e3
Updated finders guide.
2008-10-01 21:36:42 +09:30
Mike Gunderloy
8292c7dfce
Fix several typos in route names.
2008-09-30 09:48:59 -05:00
Mike Gunderloy
9922f03adf
Correct number of routes created by map.resource.
2008-09-29 20:42:50 -05:00
Mike Gunderloy
97b6383d85
Rework of Guides index page
2008-09-29 19:37:36 -05:00
Pratik Naik
e8ab3c0652
Move render/layout guide to the top
2008-09-29 01:54:44 +01:00
Pratik Naik
b826257dbd
Typooo
2008-09-28 23:50:35 +01:00
Mike Gunderloy
a79942542e
Layout & Rendering Guide
2008-09-28 17:28:45 -05:00
Simon Tokumine
2c04538b2d
Merge branch 'master' of git@github.com:lifo/docrails
2008-09-28 22:15:01 +01:00
Simon Tokumine
037eee1748
check_box form helper object must be an @instance object.
2008-09-28 22:14:45 +01:00
Mike Gunderloy
39607fa159
Back mentions of accessible out of Associations guide
2008-09-28 16:09:08 -05:00
athonlab
c492288d16
Syntax fixes plus some modification and additions in multiple sections of testing guide.
2008-09-28 19:33:10 +05:30
Mike Gunderloy
fd9d92a141
Image updates & reorganization. First release version.
2008-09-28 08:34:46 -05:00
Ryan Bigg
3c296387c6
Another revision of the finders guide.
2008-09-28 16:57:14 +09:30
Mike Gunderloy
106d147546
Change erroneous "unless" to "if" in documentation.
2008-09-27 20:41:43 -05:00
Mike Gunderloy
444fb3ec69
Finished rendering and redirecting section.
2008-09-27 20:38:49 -05:00
Pratik Naik
65c30e453e
Mark AR Associations guide as complete
2008-09-27 15:02:39 +01:00
Pratik Naik
fda846cf5d
Merge commit 'mainstream/master'
...
Conflicts:
activerecord/lib/active_record/base.rb
railties/Rakefile
railties/doc/guides/activerecord/association_basics.txt
railties/doc/guides/debugging/debugging_rails_applications.txt
railties/doc/guides/getting_started_with_rails/getting_started_with_rails.txt
railties/doc/guides/index.txt
railties/doc/guides/migrations/foreign_keys.txt
railties/doc/guides/migrations/migrations.txt
railties/doc/guides/migrations/writing_a_migration.txt
railties/doc/guides/routing/routing_outside_in.txt
2008-09-27 14:04:46 +01:00
Mike Gunderloy
df04629871
Fix substitution of path_prefix for name_prefix, some rewording.
2008-09-26 20:35:38 -05:00
Mike Gunderloy
204e0653bd
Finished section on :render
2008-09-26 20:35:38 -05:00
Mislav Marohnić
3eb0b00463
I wish people would add .DS_Store to their global gitignores
2008-09-27 01:13:57 +02:00
Pratik Naik
cd75947aad
Add stuff to index
2008-09-27 00:07:36 +01:00
Pratik Naik
a7e529191d
Change some more code -> source in code blocks
2008-09-26 23:53:27 +01:00
Pratik Naik
b8036e847a
Add Action Controller Basics guide to rake task. Remove testing for the time being ( it's borked )
2008-09-26 23:26:23 +01:00
Tore Darell
2ac20239c7
Change code -> source in code blocks
2008-09-27 00:24:40 +02:00
Tore Darell
118b0b607f
Add ActionController guide (draft, unfinished)
2008-09-26 22:56:50 +02:00
Ryan Bigg
2079763590
Add the first draft of the ActiveRecord Finders guide.
2008-09-26 15:49:46 +09:30
Aditya
6377dbf7d8
Add info about caching an action with or without the layout
2008-09-26 00:39:53 -04:00
Mike Gunderloy
3766f56a8e
Various fixes, section on self-joins, note on using hmt for hierarchies.
2008-09-25 11:31:30 -05:00
athonlab
d4379ca40a
Merge branch 'master' of git@github.com:lifo/docrails
2008-09-25 18:34:24 +05:30
athonlab
6ed136d243
Initial updates to Rails testing guide. Work in progress.
2008-09-25 18:20:43 +05:30
Mike Gunderloy
7a106af97f
Work in progress.
2008-09-23 20:56:17 -05:00
Mike Gunderloy
092628ad3a
Slight change to examples.
2008-09-23 17:12:12 -05:00
Xavier Noria
1915d7ccce
a leading slash in the :controller of url_for ensures you link to the root namespace
2008-09-23 21:29:26 +02:00
Mike Gunderloy
8a2820ada3
Added section on controller namespaces.
2008-09-23 14:10:34 -05:00
Aditya
4f294ced2c
Updated with cleanups; new sections still to come
2008-09-23 00:53:21 -04:00
Mike Gunderloy
25b24e3c4a
Added images to associations guide, cleaned up some typos and such.
2008-09-22 10:18:45 -05:00
Matthew Bergman
46fac72e4e
Merge branch 'master' of git@github.com:lifo/docrails
2008-09-22 06:55:12 -04:00
Matthew Bergman
13307e420f
fixed some small errors in formating. More to come
2008-09-22 06:54:30 -04:00
Pratik Naik
f6360ba196
Add profiling guide to the index page
2008-09-22 11:38:16 +01:00
Hongli Lai (Phusion)
63c7dcfeaa
Change 'racing condition' to 'race condition'.
2008-09-22 10:16:21 +02:00
Matthew Bergman
fb51ccd35f
clanup
2008-09-21 23:07:27 -04:00
Matthew Bergman
090603ea59
rmoved ds_store
2008-09-21 23:01:41 -04:00
Matthew Bergman
ae0e85d9ea
understood only for finished articles authors
2008-09-21 22:59:41 -04:00
Matthew Bergman
d64c9eaebe
fixed up benchmarking file names, fixed commits, truncated statistics section. Add real life example
2008-09-21 22:52:28 -04:00
Matthew Bergman
ea1eb57f56
Merge branch 'master' of git@github.com:lifo/docrails
2008-09-21 22:49:29 -04:00
Matthew Bergman
6664177b44
fixing commit
2008-09-21 22:44:14 -04:00
Matthew Bergman
3b4ca111d1
loss html file
2008-09-21 22:41:26 -04:00
Matthew Bergman
1eba6b549d
version 6 shortened satistics and fixed compiling. Also add real life example.
2008-09-21 22:40:39 -04:00
Cody Fauser
91871f25f0
Improve explanation of with_options
2008-09-21 19:01:48 -04:00
Cody Fauser
17aecd210d
Explain returning in a bit more detail
2008-09-21 18:38:57 -04:00
Hongli Lai (Phusion)
c1525e8bb0
Improve documentation for attributes= and document its 'guard_protected_attributes' parameter.
2008-09-22 00:30:09 +02:00
Cody Fauser
308456e5da
Change 'equals to' to 'equal to'
2008-09-21 18:01:27 -04:00
Cody Fauser
ce8fded9bb
Add some documentation and examples for Base64 encode64 and decode64, and encode64s.
2008-09-21 17:44:33 -04:00
Hongli Lai (Phusion)
7da89e9ae7
In ActiveRecord::Base#destroy's documention, also mention that before/after_delete callbacks and :dependent callbacks are run.
2008-09-21 22:39:17 +02:00
Hongli Lai (Phusion)
353dc9d389
Document some of the internals of associations handling.
2008-09-21 21:00:20 +02:00
Hongli Lai (Phusion)
6547e6897c
Improve various examples and API description texts.
2008-09-21 21:00:20 +02:00
Hongli Lai (Phusion)
e98dd54215
In some of ActiveRecord::Base's API documentation, replace 'Attributes' with 'Parameters' because that's more correct.
2008-09-21 21:00:20 +02:00
James Miller
f807b3cdc2
The flash
2008-09-21 08:42:45 -07:00
James Miller
860efecd8f
New and create actions
2008-09-21 08:32:34 -07:00
George Ogata
d9b67223e0
Add descriptions to doc:plugins:<plugin> tasks.
2008-09-21 22:11:47 +10:00
Hongli Lai (Phusion)
86b745654c
Fix another typo.
2008-09-20 14:20:28 +02:00
Hongli Lai (Phusion)
3efea3df4f
Fix typo.
2008-09-20 14:14:44 +02:00
Hongli Lai (Phusion)
0e8abd2d09
Fix minor formatting error.
2008-09-20 14:12:44 +02:00
Hongli Lai (Phusion)
adacd94518
Document concurrency issues in validates_uniqueness_of.
2008-09-20 14:10:32 +02:00
Hongli Lai (Phusion)
a866af0965
s/ActionPack/Action Pack/
2008-09-20 14:10:11 +02:00
Hongli Lai (Phusion)
bfa36d2f0b
Improve documentation for ActiveRecord::Base#to_param.
2008-09-20 13:37:15 +02:00
Hongli Lai (Phusion)
7a22f7abf3
Document ActiveRecord::AssociationPreload.
2008-09-20 12:58:22 +02:00
Mike Gunderloy
dc996ca971
Added a small section on defining multiple resources on a single line.
2008-09-18 11:07:12 -05:00
Pratik Naik
03968ef5be
Update index page
2008-09-18 15:00:02 +01:00
Hongli Lai (Phusion)
644dd0be32
Improve documentation for AbstractAdapter#add_limit_offset!
2008-09-18 13:36:36 +02:00
Hongli Lai (Phusion)
132185b0d3
Rename 'bechmarking and profiling' folder to 'benchmarking_and_profiling'
2008-09-18 13:08:08 +02:00
Hongli Lai (Phusion)
84784a114a
Remove .DS_Store files that were accidentally committed by someone else.
2008-09-18 13:05:28 +02:00
Hongli Lai (Phusion)
cedea3a04c
Improve documentation for create_table.
2008-09-18 13:03:49 +02:00
Mike Gunderloy
c2494a2948
Eradicate some stray colons.
2008-09-18 05:57:09 -05:00
Mike Gunderloy
bfe0cd379f
Added namespaced routes, added more on defaults, cleaned up miscellaneous typos and reworded a bit.
2008-09-17 20:03:02 -05:00
Matthew Bergman
40bc9f56fd
updated examples folder with real graph file
2008-09-17 20:33:55 -04:00
Matthew Bergman
9a514c9891
added benchmarking and profile documnetation v0.5
2008-09-17 20:04:31 -04:00
Hongli Lai (Phusion)
aa87c2019a
Document ActiveRecord::ConnectionAdapters::ConnectionHandler.
2008-09-17 17:07:00 +02:00
Heiko Webers
1b123babb3
Added introduction, highlighting and additional resources to security guide
2008-09-17 17:02:07 +02:00
Heiko Webers
f7056c5ce8
Merge branch 'master' of git@github.com:lifo/docrails
2008-09-17 16:59:43 +02:00
Heiko Webers
3642a8f5cc
Added introduction, highlighting and additional resources to security guide
2008-09-17 16:54:49 +02:00
Hongli Lai (Phusion)
f261cd2a94
Improve documentation for ConnectionPool, again.
2008-09-17 16:39:52 +02:00
Hongli Lai (Phusion)
5e4be17c3a
Improve documentation for ConnectionPool.
2008-09-17 16:24:10 +02:00
Hongli Lai (Phusion)
3b6743ea3f
Update documentation for AbstractAdapter#reset!
2008-09-17 15:49:33 +02:00
Hongli Lai (Phusion)
6782cb4e66
Improve the overview documentation for AbstractAdapter: explain what it is for.
2008-09-17 15:39:15 +02:00
Ryan Bigg
0788cdff19
Merge branch 'master' of git@github.com:lifo/docrails
2008-09-17 23:02:21 +09:30
Ryan Bigg
e025d4335a
Added partial first draft of finders guide.
2008-09-17 23:01:59 +09:30
Hongli Lai (Phusion)
161647ea89
Improve documentation for the connection methods in AbstractAdapter.
2008-09-17 15:28:52 +02:00
Hongli Lai (Phusion)
d0f7ec35a6
Document ActiveRecord::Base.configurations.
2008-09-17 15:17:32 +02:00
Hongli Lai (Phusion)
6941c98ec9
Improve documentation for ActiveRecord::Base#reset_column_information
2008-09-17 02:54:22 +02:00
miloops
606b62af5d
Updated Debugging Rails Applications: use title case in all headings, added changelog, some other small changes to the guide.
...
Added myself to authors.
2008-09-16 13:39:08 -03:00
Hongli Lai (Phusion)
df60f6c765
s/class/Model/
2008-09-16 13:17:58 +02:00
Hongli Lai (Phusion)
feacc377b7
Warn about statement errors causing a transaction to become unusable on PostgreSQL.
2008-09-16 13:15:00 +02:00
Hongli Lai (Phusion)
253259f391
Add more information about transactions.
2008-09-16 12:53:04 +02:00
Hongli Lai (Phusion)
86a0e98a79
Wrap overview documentation for ActiveRecord::Transactions::ClassMethods so that it's easier to read in a text editor with word wrapping enabled.
2008-09-16 12:50:50 +02:00
Hongli Lai (Phusion)
1fbae81e7f
Add overview description for ActiveRecord::Transactions, telling the reader to look at ClassMethods instead.
2008-09-16 12:41:21 +02:00
Mike Gunderloy
816348a339
Fix typo (see http://rails.lighthouseapp.com/projects/16213/tickets/13 )
2008-09-15 16:37:52 -05:00
Pratik Naik
3c1967ee71
Add a link back to hackfest page from the index
2008-09-15 21:38:02 +01:00
Mike Gunderloy
af0e88bd85
Typo fixes.
2008-09-15 08:03:13 -05:00
Pratik Naik
26b4fca46e
Fix security guide link
2008-09-15 12:11:38 +01:00
Pratik Naik
40f06f4c03
Add caching guide
2008-09-15 10:22:53 +01:00
Aditya
4edf14cd0a
Added first draft of caching guide; advanced caching is still being worked on
2008-09-15 00:01:10 -04:00
Daniel Schierbeck
51b5db1199
Fixed indentation error caused by the last commit.
2008-09-14 22:10:08 +02:00
Daniel Schierbeck
93a49c33cc
Fixed typo in ActiveRecord aggregations documentation.
2008-09-14 22:05:16 +02:00
Pratik Naik
4a9ddde0d3
Add new security guide to generate list
2008-09-14 20:00:55 +01:00
Heiko Webers
9b76a011c2
Removed old security guide
2008-09-14 19:02:54 +02:00
Heiko Webers
4705046045
Updated security guide
2008-09-14 18:51:32 +02:00
Pratik Naik
25db44b256
Generate authors file
2008-09-14 13:49:29 +01:00
Mike Gunderloy
5ca354133f
Add author info/changelogs for Routing & Associations guides
2008-09-14 07:48:31 -05:00
Frederick Cheung
5d95437abe
Add link to ticket
2008-09-14 13:41:59 +01:00
Frederick Cheung
e7c852f69b
Start authors section and link to it from migrations guide
2008-09-14 13:33:53 +01:00
Frederick Cheung
dd54f412c1
Use a better example
2008-09-14 13:10:59 +01:00
Pratik Naik
f6c0f68868
Merge commit 'mainstream/master'
2008-09-13 20:25:18 +01:00
Frederick Cheung
25fd841fe0
Final batch of corrections
2008-09-13 17:13:05 +01:00
Mike Gunderloy
7b9a5c112e
Merge branch 'master' of git@github.com:lifo/docrails
2008-09-13 06:59:08 -05:00
Mike Gunderloy
51f3085ac5
Added some additional text about default routes.
2008-09-13 06:58:37 -05:00
Clemens Kofler
89e600a83f
Merge branch 'master' of git@github.com:lifo/docrails
2008-09-13 13:53:18 +02:00
Clemens Kofler
a8f4cd36b0
Fixed a typo in the routing guide.
2008-09-13 13:52:48 +02:00
Mike Gunderloy
ae3dcd3de6
Changes for routing from the outside in guide
...
Fix some lingering typos.
Add a description to the index page.
2008-09-13 06:52:07 -05:00
Hongli Lai (Phusion)
837392132a
Add example for TableDefinition#column in combination wtih database-specific types.
2008-09-13 13:01:50 +02:00
Hongli Lai (Phusion)
f567a7f228
Write class overview for ColumnDefinition.
2008-09-13 13:01:26 +02:00
Hongli Lai (Phusion)
143fbbddbb
Clarify decimal precision and scale options.
2008-09-13 12:54:45 +02:00
Hongli Lai (Phusion)
b810349c8d
Improve class overview for TableDefinition.
2008-09-13 12:38:46 +02:00
Yaroslav Markin
867fc613b0
Improve ActiveRecord I18n translations documentation
2008-09-13 00:02:54 +04:00
bryan
4f33f1fff3
fixing typo in #sortable_element doc
2008-09-12 13:54:51 -04:00
Frederick Cheung
63b615cbc6
mention that innoDB is the default
2008-09-12 12:41:57 +01:00
Frederick Cheung
99acfb5b02
Revert "mention that InnoDB is actually the default"
...
This reverts commit c2f89513290a5e123d2e32231314dce9464bb810.
2008-09-12 12:40:36 +01:00
Frederick Cheung
194e972f7c
mention that InnoDB is actually the default
2008-09-12 12:40:25 +01:00
Hongli Lai (Phusion)
6160828b04
Add 'Getting Started with Rails' to guides index page.
2008-09-12 11:47:19 +02:00
James Miller
850daecc58
Some more typos
2008-09-11 08:10:34 -07:00
James Miller
02220e5bce
Fixing some typos
2008-09-11 07:58:15 -07:00
miloops
d551d9e68b
Merge branch 'master' of git@github.com:lifo/docrails
2008-09-11 10:04:25 -03:00
miloops
65c6e229bc
Updated Debugging Rails applications guide styles, use backticks instead asteriks in method/command names.
2008-09-11 10:04:06 -03:00
Frederick Cheung
5ad2bce12d
Add an example
2008-09-11 14:02:45 +01:00
Frederick Cheung
bb52108ce8
Fix typo
2008-09-11 11:50:31 +01:00
Frederick Cheung
c329a56752
Mention schema.rb as a place for seing model attributes
2008-09-11 11:47:07 +01:00
Frederick Cheung
c6da7c536c
Fixed many typos
2008-09-11 10:24:10 +01:00
James Miller
1a8edd303d
Details of the show action
2008-09-10 13:23:10 -07:00
Pratik Naik
faee12d5af
Fix a typo in guide and change assertion style in examples
2008-09-10 19:32:53 +01:00
James Miller
383467fb5d
Merge branch 'master' of git@github.com:lifo/docrails
2008-09-10 11:27:38 -07:00
James Miller
6704e90c90
Briefly discuss the reason for the respond_to block generated by the scaffold
2008-09-10 11:26:40 -07:00
Pratik Naik
6d1be5f1eb
Merge commit 'mainstream/master'
2008-09-10 19:06:59 +01:00
James Miller
6f1c274e3d
Fix some line spacing
2008-09-10 11:02:52 -07:00
James Miller
066766b641
Additions to the scaffold section
2008-09-10 11:01:26 -07:00
miloops
d0a2b849f4
Include tip for using ruby-debug in development mode without restarting the server.
2008-09-10 11:34:27 -03:00
miloops
33ee0e3e2d
Add the description of "Debugging Rails applications" guide to index.
2008-09-10 11:31:59 -03:00
Mike Gunderloy
3cebc1932b
Fix a bunch of singular-vs-plural mistakes in URLs
2008-09-10 06:55:06 -05:00
Mike Gunderloy
ea9176dc7b
Fix various AsciiDoc markup issues and a few typos.
2008-09-09 20:34:28 -05:00
Pratik Naik
926b96b632
Force generate guides
2008-09-09 17:44:36 +01:00
Pratik Naik
37356d165c
Add new guides to index page
2008-09-09 16:04:53 +01:00
Frederick Cheung
de96f92a55
Add some cross links
2008-09-09 14:07:21 +01:00
Hongli Lai (Phusion)
663bf4eea8
Change index title for the routing guide.
2008-09-09 14:55:06 +02:00
Hongli Lai (Phusion)
5acb39cfca
Make the index page look like manuals.rubyonrails.com's front page.
2008-09-09 14:10:21 +02:00
Hongli Lai (Phusion)
b1a767b57c
Layout enhancements for the guides.
...
- Make all guides link to index.html.
- Do not display the table of contents in index.html.
These changes require the latest version of Mizuho (2b7570b).
2008-09-09 12:04:25 +02:00
John D. Hume
88727f7ca6
Flesh out the ActiveRecord::Validations::ClassMethods RDoc
2008-09-08 23:57:21 -04:00
John D. Hume
3b22fb30b0
Move the orphaned method RDoc of ActiveRecord::Validations::ClassMethods#validate into the module RDoc and rewrite the first bit.
2008-09-08 23:42:34 -04:00
Mislav Marohnić
a849d1d926
resolve a few things asciidoc complained about
2008-09-09 04:15:00 +02:00
Mislav Marohnić
e5305e9fcb
initial commit of form helpers guide (halfway there)
2008-09-09 03:58:44 +02:00
Frederick Cheung
cbfeaa2563
add foreign keys section
2008-09-09 02:24:13 +01:00
Frederick Cheung
fd8c38435e
typo
2008-09-09 02:24:13 +01:00
Frederick Cheung
5e4aa0ca81
make more explicit benefits of migrations and ruby vs mysql
2008-09-09 02:24:13 +01:00
Mike Gunderloy
14c42b5d12
Merge branch 'master' of git@github.com:lifo/docrails
2008-09-08 14:57:09 -05:00
Mike Gunderloy
076347fc52
Add "A Guide to Active Record Associations"
2008-09-08 14:54:28 -05:00
James Miller
f173ead371
Continued work on the MVC/REST section
2008-09-08 12:36:04 -07:00
miloops
ba1e303705
Changes on Rails Debugging Guide: added the logger section, many changes to existing chapters and also a few improvements after feedback on LH ticket.
2008-09-08 12:05:54 -03:00
Frederick Cheung
d7c6812e58
Merge branch 'master' of git@github.com:lifo/docrails
...
* 'master' of git@github.com:lifo/docrails:
Updates to nested/shallow routes discussion in "Routing from the Outside In" guide.
Add an index file for the guides.
Get rid of the work-in-progress 'book' that's supposed to be based on Django's book.
Add migrations guide to guide HTML generation task.
Change over examples to use {{count}} and {{value}} instead of %d and %s.
2008-09-08 14:01:41 +01:00
Mike Gunderloy
0a9a80b2db
Updates to nested/shallow routes discussion in "Routing from the Outside In" guide.
...
Added guidance on avoiding deeply-nested routes, further explanation of :shallow, show example of :has_many and :shallow together.
2008-09-08 07:11:44 -05:00
Frederick Cheung
d24536b3a1
expand the schema section
2008-09-08 12:40:05 +01:00
Hongli Lai (Phusion)
310297e159
Add an index file for the guides.
2008-09-08 13:35:35 +02:00
Hongli Lai (Phusion)
4ba0df6cd2
Get rid of the work-in-progress 'book' that's supposed to be based on Django's book.
2008-09-08 13:23:01 +02:00
Hongli Lai (Phusion)
3bb00f5db3
Add migrations guide to guide HTML generation task.
2008-09-08 13:20:29 +02:00
John D. Hume
1d20e0cf81
Change over examples to use {{count}} and {{value}} instead of %d and %s.
2008-09-07 21:23:31 -04:00
Frederick Cheung
3be1601a0e
Style regular font for constants
2008-09-07 22:59:15 +01:00
Frederick Cheung
331f9fdb6e
Merge branch 'master' of git@github.com:lifo/docrails
...
* 'master' of git@github.com:lifo/docrails:
Initial draft of Getting Started With Rails guide, far from complete
2008-09-07 22:58:55 +01:00
Frederick Cheung
22c8ebedec
ActiveRecord -> Active Record
2008-09-07 22:53:49 +01:00
James Miller
3e48484ff1
Initial draft of Getting Started With Rails guide, far from complete
2008-09-07 14:14:28 -07:00
Frederick Cheung
5f45670f07
Add to the preamble
2008-09-07 19:43:59 +01:00
Frederick Cheung
e4167b8d0b
Stylistic cleanups
2008-09-07 19:18:40 +01:00
Frederick Cheung
67f50bd424
Fixed typo
2008-09-07 19:13:27 +01:00
Frederick Cheung
2643be0642
Merge branch 'mig_guide'
...
* mig_guide:
Initial draft
2008-09-07 18:17:13 +01:00
Frederick Cheung
87211fbfaf
Initial draft
2008-09-07 16:37:01 +01:00
Hongli Lai (Phusion)
c4e5ac4f76
Add 'Debugging Rails Applications' guide to guide HTML generation task.
2008-09-07 12:38:27 +02:00
miloops
c6acd2924e
Added View Helpers to the Rails debugging guide.
2008-09-05 20:19:23 -03:00
miloops
6c51c45a0a
Rails debugging guide updated.
2008-09-05 19:29:51 -03:00
miloops
e38fe94990
Debugging Guide updated after having some feedback on it, added breakpoints and catchpoints chapters.
2008-09-05 18:33:23 -03:00
Pratik Naik
0998331d86
Dont use multipage
2008-09-05 22:15:50 +01:00
miloops
4fd89343a5
Updates on Debugging Rails guide.
2008-09-05 18:06:36 -03:00
Pratik Naik
1990f815bc
Merge commit 'mainstream/master'
2008-09-05 21:32:38 +01:00
miloops
af04ea87de
Debugging Rails Applications guide updated.
2008-09-05 15:54:07 -03:00
Hongli Lai (Phusion)
c9cfa4fc6c
Add HTML generation task for the routing guide.
2008-09-05 16:49:27 +02:00
Hongli Lai (Phusion)
393410b97f
Merge branch 'master' of git@github.com:lifo/docrails
2008-09-05 16:35:05 +02:00
Mike Gunderloy
b867939ac4
Edits to the "Routing from the Outside In" guide.
...
Cleaned up a few parts, reworded coverage of classic vs. RESTful routing, added coverage of routing assertions.
2008-09-05 08:44:50 -05:00
miloops
df603e5bf5
More work on Rails debugging guide.
2008-09-04 22:34:24 -03:00
miloops
d6ff0654de
Merge branch 'master' of git@github.com:lifo/docrails
2008-09-04 20:12:58 -03:00
miloops
f25049613f
Added prompt, context and references to debugging Rails guide.
2008-09-04 20:12:28 -03:00
Alan Harper
8ef921fa3f
Merge branch 'master' of git://github.com/lifo/docrails
2008-09-05 08:11:31 +10:00
miloops
cb2f5de1f9
Merge branch 'master' of git@github.com:lifo/docrails
2008-09-04 18:16:30 -03:00
miloops
62cba9a96b
Initial commit of the Rails debugging guide.
2008-09-04 18:13:32 -03:00
Hongli Lai (Phusion)
c480c1db1f
Merge branch 'master' of git@github.com:lifo/docrails
2008-09-04 23:01:40 +02:00
Alan Harper
55902dede2
Changed variable names for in_groups_of to make more obvious
2008-09-04 10:25:39 +10:00
Pratik Naik
d7bd01f543
Merge commit 'mainstream/master'
2008-09-03 18:05:02 +01:00
Pratik Naik
2933f4481f
Merge commit 'mainstream/master'
...
Conflicts:
actionpack/lib/action_controller/resources.rb
2008-09-03 17:44:58 +01:00
Mike Gunderloy
36ee17d458
Added "Routing from the Outside In" guide.
2008-08-31 09:31:19 -05:00
Henrik N
1783cc0b8f
Typo in current_cycle example.
2008-08-28 12:39:24 +02:00
Pratik Naik
3e3945b2fa
Merge commit 'mainstream/master'
...
Conflicts:
activerecord/lib/active_record/associations/association_proxy.rb
activerecord/lib/active_record/callbacks.rb
activeresource/lib/active_resource/base.rb
2008-08-28 11:36:56 +01:00
Hongli Lai (Phusion)
08704c442d
Merge branch 'master' of git@github.com:lifo/docrails
2008-08-27 11:39:06 +02:00
Xavier Noria
5db2f199ab
Reworded and corrected docs of AR#save and AR#save!
2008-08-26 03:26:54 +02:00
Zach Inglis
eaa9c06439
fixed a silly mistake of not fixing a merge
2008-08-25 14:22:40 -04:00
Zach Inglis
4c86f074a7
Corrected interpolation in a model find
2008-08-25 14:21:21 -04:00
Xavier Noria
4e6f91402c
before_validation raises ActiveRecord::RecordInvalid instead of ActiveRecord::RecordNotSaved
2008-08-23 23:59:09 +02:00
Xavier Noria
69820504e0
added class rdoc for AssociationCollection and revised the rdoc of a few methods
2008-08-21 02:19:09 +02:00
Xavier Noria
2009fb5206
revised rdoc of join_table_name
2008-08-19 16:25:31 +02:00
Cody Fauser
03819e0a5a
Update listing of ActiveResource errors
2008-08-19 10:12:04 -04:00
Xavier Noria
2ee60b0f70
added a class rdoc and documented count_records in has_many_association.rb
2008-08-19 02:51:37 +02:00
Xavier Noria
48f56bf2be
escaped some otherwise autolinked words
2008-08-18 02:14:53 +02:00
Xavier Noria
cd2e535a8b
typo
2008-08-17 23:36:43 +02:00
Xavier Noria
f392a639fc
complete revision of the docs of association_proxy.rb
2008-08-17 23:34:22 +02:00
Sunny
ce40df20ec
Wrong default for validate_uniqueness_of's :case_sensitive
2008-08-17 19:26:54 +02:00
Cody Fauser
061923371c
Fix tiny typo in example
2008-08-15 09:31:01 -04:00
Cody Fauser
47e79cbf77
Remove incorrect Active Resource documentation regarding client side validation that does not exist. Update example to reflect server side validation
2008-08-15 09:28:10 -04:00
Pratik Naik
2ebe8d275e
Merge commit 'mainstream/master'
...
Conflicts:
actionpack/lib/action_controller/request.rb
actionpack/lib/action_controller/resources.rb
2008-08-14 16:31:14 +01:00
Xavier Noria
73ef94e967
in save! docs: added a note about what happens if AR::Rollback is raised somewhere in the callback chain
2008-08-14 01:44:42 +02:00
Xavier Noria
37054e6eb5
documented how to trigger rollbacks within the callback chain, and related gotchas
2008-08-14 01:22:44 +02:00
Tieg Zaharia
fcdf8e2988
Fixes file_field_tag docs by taking out deprecated end_form_tag and makes form_tag evaluated instead of output
2008-08-13 17:22:56 -04:00
Xavier Noria
3b8b7a78df
removed a wrong statement, I'll look into this to document it better
2008-08-12 21:52:38 +02:00
Xavier Noria
d7514c6daf
added a few docs about transactions
2008-08-12 21:09:54 +02:00
Xavier Noria
99352fc49a
An string -> A string
2008-08-12 20:47:48 +02:00
Xavier Noria
8c300ebde2
activerecord/lib/active_record/base.rb
2008-08-12 20:39:41 +02:00
Cheah Chu Yeow
52f88f09bc
Fix reference to incorrect block variable in :cache_path example for caches_action.
2008-08-12 15:03:55 +08:00
Hongli Lai (Phusion)
920ad94598
Merge branch 'master' of git@github.com:lifo/docrails
2008-08-08 13:48:30 +02:00
Henrik N
d2553c3409
Typo in comment.
2008-08-07 17:44:50 +02:00
miloops
3060715ea9
Added missing opening double quote to doc example in prototype helper.
2008-08-06 10:18:14 -03:00
Dave Rothlisberger
43334d6384
Corrected the command-line help text for script/dbconsole.
2008-08-04 14:48:47 -05:00
Ryan Bigg
c38dc3cd6d
Added a better explanation for config.active_record.observers when using it in tandem with script/generate observer.
...
Thanks to halogenandtoast from #rubyonrails for pointing this out.
2008-08-04 07:44:43 +09:30
Dave Rothlisberger
28546e84cd
Flesh out documentation for the :select option to AR#find
2008-08-03 13:57:07 +01:00
Pat Nakajima
e5fadfea8a
Added documentation for ActiveSupport::StringInquirer class
2008-08-03 13:55:10 +01:00
Pratik Naik
f6124c2b09
Merge commit 'mainstream/master'
2008-08-03 13:54:44 +01:00
Xavier Noria
acd0456fcf
escaped otherwise autoquoted words
2008-08-03 01:44:41 +02:00
Xavier Noria
31e226eeeb
say explicitily that after_* callbacks run within the save/destroy transaction
2008-08-03 01:32:55 +02:00
Xavier Noria
bd1c02fe4a
revised conventions, fixed an example, escaped autolinked words, and other assorted details in request.rb
2008-07-29 10:22:45 +02:00
Xavier Noria
6bf05cbb43
escaping otherwise autolinked "resource(s)" in resource.rb and assorted minor touches
2008-07-28 22:33:04 +02:00
Xavier Noria
5c9d1dbb5c
escaping otherwise autolinked "scopes" in named_scope.rb (we can now assume rdoc is v2.1)
2008-07-28 22:10:38 +02:00
Xavier Noria
7c509631f5
convention revision and typos
2008-07-28 22:05:24 +02:00
Evan Farrar
bf4c3361a7
The :conditions for calculations are not explained in the intro, there is no intro. This must have been copy/pasted from active_record/base.rb so link there instead.
2008-07-28 11:15:58 -05:00
Pratik Naik
5abe63c419
Merge commit 'mainstream/master'
...
Conflicts:
actionpack/lib/action_controller/response.rb
actionpack/lib/action_controller/test_case.rb
actionpack/lib/action_controller/url_rewriter.rb
activerecord/lib/active_record/associations.rb
activesupport/lib/active_support/core_ext/time/conversions.rb
railties/doc/guides/creating_plugins/acts_as_yaffle.txt
railties/doc/guides/creating_plugins/creating_plugins.txt
railties/doc/guides/creating_plugins/migration_generator.txt
railties/doc/guides/creating_plugins/odds_and_ends.txt
railties/doc/guides/creating_plugins/preparation.txt
railties/doc/guides/creating_plugins/string_to_squawk.txt
railties/doc/guides/creating_plugins/view_helper.txt
railties/doc/guides/securing_rails_applications/creating_records_directly_from_form_parameters.txt
railties/doc/guides/testing_rails_applications/testing_rails_applications.txt
2008-07-28 15:38:24 +01:00
Pratik Naik
de211914d8
Merge commit 'mainstream/master'
...
Conflicts:
actionpack/lib/action_controller/cookies.rb
actionpack/lib/action_controller/streaming.rb
actionpack/lib/action_controller/test_case.rb
actionpack/lib/action_view/base.rb
actionpack/lib/action_view/helpers/date_helper.rb
actionpack/lib/action_view/helpers/debug_helper.rb
actionpack/lib/action_view/helpers/form_options_helper.rb
actionpack/lib/action_view/helpers/javascript_helper.rb
activerecord/lib/active_record/associations.rb
activerecord/lib/active_record/validations.rb
activeresource/README
activesupport/lib/active_support/core_ext/hash/reverse_merge.rb
activesupport/lib/active_support/vendor/tzinfo-0.3.9/tzinfo/data_timezone_info.rb
activesupport/lib/active_support/vendor/tzinfo-0.3.9/tzinfo/timezone.rb
railties/doc/guides/actionview/helpers.markdown
railties/doc/guides/actionview/partials.markdown
railties/doc/guides/activerecord/basics.markdown
2008-07-28 12:03:16 +01:00
Hongli Lai (Phusion)
62d8a1c844
Begin working on a little Rails book.
2008-07-25 14:24:05 +02:00
Hongli Lai (Phusion)
6246a8e060
Improve documentation for ActionController::UrlWriter.
2008-07-24 22:29:53 +02:00
Hongli Lai (Phusion)
7e69c74749
Improve the plugin creation guide's title.
2008-07-21 13:28:06 +02:00
Hongli Lai (Phusion)
ec50757b72
Update guide generation task for latest Mizuho commandline options. Add admonition icons for the guides.
2008-07-20 23:38:28 +02:00
Hongli Lai (Phusion)
e2d283543f
Fix some layout/styiling problems.
2008-07-20 18:06:16 +02:00
Hongli Lai (Phusion)
90f8b192f7
Convert 'creating plugins' guide to asciidoc format.
2008-07-20 17:55:27 +02:00
Hongli Lai (Phusion)
48ab28299a
Revived two ancient manuals from manuals.rubyonrails.org: 'Securing Rails Applications' and 'Testing Rails Applications'. Now in Asciidoc format generated by Mizuho.
2008-07-20 04:40:19 +02:00
Xavier Noria
e28eee6f2f
in access.rb, documented edge cases of #from and #to and revised conventions
2008-07-20 02:27:31 +02:00
Hongli Lai (Phusion)
5bb973fe2e
Improve documentation for ActiveRecord transactions.
2008-07-19 12:19:56 +02:00
Hongli Lai (Phusion)
2fd540a266
Improve documentation of ActiveRecord::Rollback.
2008-07-19 12:19:20 +02:00
Hongli Lai (Phusion)
038c7fdeea
Improve readability of other ActiveRecord association methods' documentation.
2008-07-19 12:05:16 +02:00
Hongli Lai (Phusion)
4d719c185a
Improve readability of ActiveRecord::Assocations.has_many's documentation.
2008-07-18 22:15:02 +02:00
Hongli Lai (Phusion)
03afe79dd8
Improve overview for ActionController::TestCase.
2008-07-18 21:42:20 +02:00
Hongli Lai (Phusion)
5508bfd0ff
Fix markup.
2008-07-18 21:42:03 +02:00
Hongli Lai (Phusion)
3dbc1cfeb3
Write overviews for AbstractController::TestResponse and AbstractController::AbstractResponse.
2008-07-18 20:48:18 +02:00
Hongli Lai (Phusion)
632a4705b9
Improve documentation for ActionController::Session.get.
2008-07-18 20:47:45 +02:00
miloops
b32a24abc9
Include a :number option example inside Time conversions helper.
2008-07-17 11:34:04 -03:00
Pratik Naik
0cfa3574d5
Merge commit 'mainstream/master'
...
Conflicts:
actionpack/lib/action_controller/base.rb
railties/lib/rails_generator/commands.rb
2008-07-12 21:39:36 +01:00
Clemens Kofler
ef67bd481b
ActiveSupport::CoreExtensions::Hash: Slightly modified wording, plus example with reverse_merge vs. merge
2008-07-12 18:50:16 +02:00
Clemens Kofler
f5277eeb7e
ActionController::Streaming: Added missing documentation for :x_sendfile and :length options to send_file method. Added information that streaming can be turned off in a more prominent spot. Fixed a few typos. Consolidated wording in options descriptions of send_file/send_data.
2008-07-12 18:32:43 +02:00
Aaron Gibralter
115652cdcb
Added a small comment about deleting cookies set with a :domain key (in order to delete you must specify the domain again).
2008-07-08 09:56:14 -04:00
Diego Algorta
cb5ff1531d
Fix documentation typo (classic copy & paste error).
2008-07-07 05:01:41 -03:00
Pratik Naik
0a7923ea7a
Merge commit 'mainstream/master'
2008-07-04 00:33:56 +01:00
Jay Shepherd
5dba6c0242
Finished sentence in ActiveResource README
2008-06-27 11:02:32 -05:00
Chris O'Sullivan
7199a485fe
teeny tiny change that fixes a minor formating problem'
2008-06-26 17:29:20 +01:00
Adam Meehan
9f25ffdb3d
example output of content_tag block form was incorrectly wrapped in <p></p> tags
2008-06-26 08:03:00 +10:00
Pratik Naik
01571c0fd7
Merge commit 'mainstream/master'
...
Conflicts:
actionpack/lib/action_view/helpers/javascript_helper.rb
activesupport/lib/active_support/dependencies.rb
activesupport/lib/active_support/inflector.rb
activesupport/lib/active_support/values/time_zone.rb
2008-06-25 12:12:30 +01:00
Cheah Chu Yeow
b5e9badea2
It's select_date, not select_datetime - fix copy and paste doc error.
2008-06-23 21:32:21 +08:00
Cheah Chu Yeow
f9b48f36fa
Use consistent "takes precedence over" verbiage and remove some unnecessary words.
2008-06-23 12:15:09 +08:00
Sunny Ripert
45709aead0
ActiveRecord associations example on module scopes was illogic
...
Was using Company when it meant Client.
2008-06-20 23:51:26 +02:00
Xavier Noria
3088094084
tweaked a header
2008-06-17 22:00:55 +02:00
Xavier Noria
ea40dc09a5
provide a more complete explanation about why the check_box generates a hidden field, and document the problem with array-like parameters
2008-06-17 21:59:41 +02:00
TomK32
235cd218b6
note on increasing performance a bit when using restful urls
2008-06-11 19:29:01 +02:00
TomK32
6a5ac86207
Merge branch 'master' of git@github.com:lifo/docrails
2008-06-11 19:22:51 +02:00
Evan Farrar
d4b7cd99e8
Mass typo and misspelling fix.
2008-06-04 22:58:28 -05:00
Pratik Naik
719aa13b07
Merge commit 'mainstream/master'
2008-06-02 12:29:28 +01:00
Grant Hollingworth
ad3c97cea6
fixed typo: extra word
2008-06-02 12:25:51 +01:00
Chris Kampmeier
b6e529ef62
Fix spelling in deprecation warning (affect -> effect)
2008-05-31 14:12:50 -07:00
Cheah Chu Yeow
eb007e4197
Make a note about script/destroy in 'script/generate scaffold' usage description.
...
Make a note about 'script/generate scaffold' requiring a singular model name.
Remove :nodoc: for a documented method.
2008-05-31 13:46:02 -07:00
Jeff Dean
60e37868e4
added final tree structure, changed String to String.class_eval do
2008-05-30 10:13:29 -07:00
Jeff Dean
1b43884c72
made the headings more consistent
2008-05-30 10:03:57 -07:00
Jeff Dean
bf8defba08
added documentation for rake tasks to the plugin tutorial
2008-05-29 20:16:18 -07:00
Jeff Dean
8ea92f3cd4
Added a tutorial for how to create and test plugins
2008-05-29 18:32:18 -07:00
Bill Garr
569fe2d1fa
first draft on helpers
2008-05-29 17:02:00 -07:00
Nick Laiacona
8a090aa93d
First draft of the ActionView Partials guide.
2008-05-29 16:42:32 -07:00
Cheah Chu Yeow
377b2fdd08
Add examples for #to_json for Date, Time, DateTime, TimeWithZone for the case when ActiveSupport.use_standard_json_time_format = true (and also when it is false).
2008-05-29 12:15:12 -07:00
Jeremy McAnally
281a428f11
Merge branch 'master' of git@github.com:lifo/docrails
2008-05-29 13:30:37 -04:00
Jeremy McAnally
d2e2c02879
Start narrative documtentation
2008-05-29 13:29:51 -04:00
JD Huntington
305eb5b031
added useful example for actionview's debug()
2008-05-28 23:49:09 -07:00
Scott Willson
f49f3e40e9
Merge branch 'master' of git://github.com/lifo/docrails
2008-05-28 09:39:14 -07:00
Nick Plante
632c305cd0
Merge git@github.com:lifo/docrails into lifo
2008-05-28 11:52:50 -04:00
scottwillson
c75cfa0e54
Updated README example to ActionController::TestCase from Test::Unit::TestCase. Added usage example for ActionController::TestCase.
2008-05-28 07:38:20 -07:00
Jacqui Maher
5b69bcde07
fixed typo in url_helper & added comments on usage to js (link|button)_to_function helpers
2008-05-28 10:10:24 -04:00
Nick Plante
a8e32152fc
update language and use proper fonts for method names
2008-05-27 23:32:47 -04:00
Nick Plante
4be3c2c92f
fix spelling error
2008-05-27 23:21:34 -04:00
Xavier Noria
7ac4018786
Active Resource instance -> ActiveResource::Base instance
2008-05-28 00:01:21 +02:00
Xavier Noria
c5bd2318be
small fix in ActiveResource::Base docs
2008-05-28 00:01:21 +02:00
Balint Erdi
bb64660c30
a tiny, one-word change
...
Signed-off-by: Balint Erdi <balint.erdi@gmail.com >
2008-05-27 23:52:00 +02:00
Pratik Naik
f8b402c5d8
Merge commit 'mainstream/master'
2008-05-27 12:24:46 +01:00
Xavier Noria
9d9c96af56
revised some conventions in validations docs
2008-05-25 20:51:18 +02:00
Xavier Noria
80bc36d808
revised markup in dirty.rb docs
2008-05-25 20:39:45 +02:00
Henrik N
c82f317eaa
yaml -> YAML
2008-05-25 16:17:04 +02:00
Pratik Naik
b0ebabafa4
merge
2008-05-25 12:39:10 +01:00
Pratik Naik
8cad284403
Merge
2008-05-25 12:37:43 +01:00
Pratik Naik
dc6da2e370
Merge commit 'mainstream/master'
...
Conflicts:
railties/configs/initializers/new_rails_defaults.rb
2008-05-25 11:16:46 +01:00
Cody Fauser
11ea3e947a
Fixup weird RDoc markup that does not render correctly
2008-05-23 16:38:40 -04:00
Henrik N
8072ebcacc
Document Integer#even? and #odd? edge cases: zero and negative numbers.
2008-05-23 11:44:37 +02:00
Henrik N
88ef718361
Consistently use "rake foo:bar" instead of 'rake foo:bar', rake foo:bar or rake foo:bar.
2008-05-23 11:28:19 +02:00
Henrik N
4d276cfafb
environment.rb template 'rake gem:install' should be 'rake gems:install'.
2008-05-23 11:15:40 +02:00
Xavier Noria
63946cfb0e
overall cleanup of "#=>" and other minor details
2008-05-23 01:03:00 +02:00
Xavier Noria
22a47cb1ae
revision of inflector.rb docs
2008-05-23 00:40:20 +02:00
Xavier Noria
098c2104e2
fixed indentation in description lists
2008-05-23 00:28:22 +02:00
Xavier Noria
82601290cd
fixed indentation in description list
2008-05-23 00:21:35 +02:00
Pratik Naik
e32deb595f
Merge commit 'mainstream/master'
2008-05-22 15:16:12 +01:00
Xavier Noria
4617139bcc
regular font for a constant
2008-05-21 23:47:57 +02:00
Xavier Noria
e89b4bc0c7
gsub("ActionMailer", "Action Mailer")
2008-05-21 23:39:07 +02:00
Xavier Noria
291333d93a
gsub("ActiveResource", "Active Resource")
2008-05-21 23:39:07 +02:00
Xavier Noria
46f0836d60
gsub("ActionPack", "Action Pack")
2008-05-21 23:39:07 +02:00
Xavier Noria
11f0fd5c6f
gsub("ActionController", "Action Controller")
2008-05-21 23:39:07 +02:00
Xavier Noria
1edbdbbfa8
gsub("ActiveSupport", "Active Support")
2008-05-21 23:39:07 +02:00
Joshua French
981bb9bccc
Merge branch 'master' of git@github.com:lifo/docrails
2008-05-21 15:39:34 -05:00
Joshua French
066b56149c
Revised example conventions in active_record/base
2008-05-21 15:38:58 -05:00
Xavier Noria
49738f000b
gsub("ActiveRecord", "Active Record")
2008-05-21 22:34:18 +02:00
Xavier Noria
bc0e24040b
revised conventions in http_mock.rb docs
2008-05-21 21:49:45 +02:00
Alex Wayne
028a236f10
Added documentation for ActiveResource::HttpMock.
...
Special thanks to Clever Title Pending:
http://seangeo.blogspot.com/2007/09/testing-activeresource.html
2008-05-21 08:10:47 -07:00
Xavier Noria
d79becdf21
revised conventions and minor details in scriptaculous_helper.rb
2008-05-21 14:46:30 +02:00
Xavier Noria
7e8b2b6bf2
revised conventions in cookie.rb
2008-05-21 14:01:00 +02:00
Xavier Noria
08cac396cc
revised font of constants in Railties
2008-05-21 13:54:40 +02:00
Xavier Noria
fb1858d5ec
revised font of constants in Active Record
2008-05-21 13:53:11 +02:00
Xavier Noria
e5a74231d5
revised font of constants in Action View
2008-05-21 13:46:11 +02:00
Xavier Noria
8174d91273
revised font of constants in Action View
2008-05-21 13:39:50 +02:00
Xavier Noria
401690fea3
revised case of constants in Action Controller
2008-05-21 13:30:49 +02:00
Xavier Noria
964392f57a
revised docs of first/last in AR base and association collection
2008-05-20 16:56:22 +02:00
Pratik Naik
babd1e57e6
Merge commit 'mainstream/master'
2008-05-20 15:05:51 +01:00
Xavier Noria
02674a892b
details left in previous revision of time zone related docs
2008-05-20 12:41:50 +02:00
Xavier Noria
633e9b4c56
revised conventions in time zone related docs
2008-05-20 12:37:35 +02:00
Pratik Naik
1148af4b3f
Merge commit 'mainstream/master'
2008-05-20 10:37:30 +01:00
Xavier Noria
ecba27c970
revised markup in fixtures.rb
2008-05-19 22:11:04 +02:00
Xavier Noria
55b995ba6b
gsub("css", "CSS") and assorted improvements
2008-05-19 22:04:43 +02:00
Xavier Noria
69597df908
#method vs +method+ in Active Support
2008-05-19 21:37:08 +02:00
Xavier Noria
1855fd29e0
Class#method in regular font
2008-05-19 21:32:26 +02:00
Xavier Noria
78596747ba
#method vs +method+ in Active Record
2008-05-19 21:31:18 +02:00
Xavier Noria
67603693b5
#method vs +method+ in Action View
2008-05-19 21:00:29 +02:00
Xavier Noria
5ff769afc9
#method vs +method+ in Action Controller
2008-05-19 20:50:22 +02:00
Xavier Noria
411c675947
#method vs +method+ in Action Mailer
2008-05-19 20:34:38 +02:00
Xavier Noria
abc4292705
gsub("yaml", "YAML")
2008-05-19 19:34:07 +02:00
Xavier Noria
43d0200d94
gsub("xml", "XML")
2008-05-19 19:28:33 +02:00
Xavier Noria
0b580047fe
gsub("http", "HTTP")
2008-05-19 19:25:44 +02:00
Cody Fauser
ce63b2e5df
Markup inline code in ActiveRecord::Base docs
2008-05-19 11:01:09 -04:00
Xavier Noria
aa4a7a2989
gsub("sql", "SQL")
2008-05-18 22:11:15 +02:00
Xavier Noria
c40c17c986
fixed-width font for nil
2008-05-18 22:04:41 +02:00
Xavier Noria
bd57507e7f
added mention to Model.(first|last|all) in AR's find, and assorted tweaks
2008-05-18 22:02:07 +02:00
Xavier Noria
14bd01b9a9
revised description list convention in AR's find docs, and markup here and there
2008-05-18 21:51:54 +02:00
Xavier Noria
a50e747971
minor details in associations.rb
2008-05-18 21:44:15 +02:00
Frederick Cheung
c9c4f7baba
Update documentation on :include.
2008-05-18 20:24:48 +01:00
Xavier Noria
a49ebf6d79
revised documentation of attr_(protected|accessible)
...
Revised wording and coherence between both docs, avoided the term "hacker" to refer to a malicious user, revised markup and structure.
2008-05-17 17:33:44 +02:00
Xavier Noria
82a1b93c6a
small touches to the form_for docs revision
2008-05-17 12:44:48 +02:00
Xavier Noria
e535c037e3
major revision of form_for documentation
2008-05-17 12:37:39 +02:00
Pratik Naik
17c8cba3a0
Merge commit 'mainstream/master'
2008-05-16 23:44:28 +01:00
Xavier Noria
0fc3381aa5
revised docs of form_for
...
This revision encourages the modern resource-oriented form_for usage. In addition corrects some markup and other details.
2008-05-16 23:44:51 +02:00
Chris Kampmeier
70e4bcf5cb
Fix a couple spelling errors in docs
2008-05-16 13:45:28 -07:00
Chris O'Sullivan
6ea5e4208f
Added docs about source_type for has_one association
2008-05-16 16:09:11 +01:00
miloops
a01a0178be
Change migration generator USAGE to explain the timestamped migrations behaviour
2008-05-16 10:48:26 +00:00
TomK32
fa0cca368f
Merge branch 'master' of git@github.com:lifo/docrails
2008-05-16 11:13:32 +02:00
TomK32
f16c22040d
it looks a bit strange as code, and it's not that extremely important
2008-05-16 11:12:30 +02:00
Xavier Noria
4e2bc02163
minor revision in url_for docs
...
Made explicit that RESTful and controller/action styles are not interchangeable, and revised some markup.
2008-05-16 00:43:03 +02:00
Pratik Naik
879493c35f
Merge commit 'mainstream/master'
...
Conflicts:
actionmailer/lib/action_mailer/base.rb
2008-05-15 21:54:46 +01:00
Michael Hartl
d6ecce66f4
Expanded and updated the link_to documentation
...
link_to is the primary interface much of the Rails URL machinery, including
url_for and routes. The new examples (with explanations) are designed to
reflect this importance, and are especially designed to be friendly to
less experienced Rails programmers. The new docs are also updated to use
RESTful routes.
2008-05-15 11:07:53 -07:00
Cody Fauser
9226b3e835
Merge branch 'master' of git@github.com:lifo/docrails
2008-05-14 09:11:35 -04:00
Cody Fauser
b8c46c86f0
Improve and cleanup ActionMailer documentation
2008-05-14 09:10:02 -04:00
Yehuda Katz
9546ee2999
Add documentation for Inflector.inflections
2008-05-13 13:50:41 +01:00
Xavier Noria
654e77597b
minor details revised in attribute_methods.rb docs
2008-05-12 22:01:58 +02:00
Manik Juneja
cbd5db8f51
minor changes in railties/README. Added dbconsole introduction
2008-05-12 23:43:31 +05:30
TomK32
e9a0526d5b
Merge branch 'master' of git://github.com/lifo/docrails
2008-05-12 19:18:13 +02:00
Xavier Noria
9d0900c7df
revised doc conventions in attr_internal.rb
2008-05-12 18:39:47 +02:00
Gaurav Sharma
130a280dde
adding documentation for cached_attributes
2008-05-12 18:00:19 +05:30
TomK32
164c958648
proper heading for "Example:"
2008-05-12 10:59:33 +02:00
TomK32
d416e71229
fixed display of example
2008-05-12 10:49:30 +02:00
Pratik Naik
cb50a28807
Merge commit 'mainstream/master'
2008-05-11 23:50:08 +01:00
Matt Boehlig
35634feb47
Cleanup whitespace and change_table documentation
2008-05-11 16:46:07 -05:00
Xavier Noria
f4aaa2e99c
moved documentation header
2008-05-11 02:55:59 +02:00
Xavier Noria
80bba28a1a
documented the source annotation extractor
2008-05-11 02:54:02 +02:00
Mike Mondragon
e6823bb165
Added additional information about processing email with ActionMailer and the strategy one might want to employ to do so.
2008-05-09 13:49:56 -07:00
Pratik Naik
c99e54f4ec
Merge commit 'mainstream/master'
2008-05-09 10:51:57 +01:00
Xavier Noria
e6afd8b273
corrected and completed docs of increment/decrement/toggle in AR::Base
2008-05-08 23:49:36 +02:00
Xavier Noria
aa289d325b
removed spurious word
2008-05-08 17:55:06 +02:00
Xavier Noria
7bb437de3f
documented potential gotchas in increment and increment!
2008-05-08 17:51:55 +02:00
Austin Putman
00395c8780
Merge branch 'docs_commit'
2008-05-07 19:36:30 -07:00
Austin Putman
2fead68b31
Documented class methods on ActionController::Routing. These are dangerous, and mostly used for testing.
2008-05-07 19:35:46 -07:00
Xavier Noria
a904bc58ba
punctuation fix in fixtures.rb
2008-05-08 01:33:44 +02:00
Xavier Noria
42c5ca18a0
+ vs <tt> in ActiveResource::Base docs
2008-05-07 23:18:03 +02:00
Xavier Noria
b4d44d3ee7
+ vs <tt> in fixtures.rb docs
2008-05-07 23:15:59 +02:00
Xavier Noria
7a1225343b
+ vs <tt> fixes in abstract adapter docs
2008-05-07 23:14:07 +02:00
Xavier Noria
4308d871b6
several fixes and conventions revision in AR associations docs
2008-05-07 23:10:15 +02:00
Teflon Ted
ac3aea6383
Merge branch 'master' of git@github.com:trak3r/docrails into trak3r/master
2008-05-07 17:00:41 -04:00
Teflon Ted
f5b84182db
Added explanation about errant inflections not being patched in the future in order to avoid breaking legacy applications.
2008-05-07 16:08:49 -04:00
Xavier Noria
99bee8d240
fixed markup in AV::Base docs
2008-05-07 21:47:25 +02:00
Xavier Noria
1b663fdf2a
revised markup in AR session storage docs
2008-05-07 21:42:02 +02:00
Xavier Noria
aed099a5b9
markup fix, and conventions revision in routing docs
2008-05-07 21:36:25 +02:00
Xavier Noria
eef46a2e39
fix and conventions revision in page caching docs
2008-05-07 21:28:53 +02:00
Xavier Noria
c434d206f1
revised docs of hash with indiferent access
...
Includes addtional docs from http://rails.lighthouseapp.com/projects/8994/tickets/134
2008-05-07 20:32:02 +02:00
Pratik Naik
d9db501287
Merge commit 'mainstream/master'
2008-05-07 15:11:55 +01:00
Xavier Noria
acf5204574
applies patch in http://rails.lighthouseapp.com/projects/8994/tickets/132-document-clear_query_cache
2008-05-07 16:04:58 +02:00
Xavier Noria
408d5fd580
applied patch in http://rails.lighthouseapp.com/projects/8994/tickets/129-patch-doc-whitespace-fix
2008-05-07 16:00:27 +02:00
Xavier Noria
4bf5f67be9
applied patch in http://rails.lighthouseapp.com/projects/8994/tickets/133-patch-prototype-helper-doc-patch
2008-05-07 15:42:39 +02:00
Xavier Noria
8c937edca0
fixed markup
2008-05-07 15:36:54 +02:00
Xavier Noria
6507b2d62d
fixed markup
2008-05-07 15:32:08 +02:00
Sunny Ripert
370f4f5172
Applied list conventions in AR::Base
2008-05-07 14:00:59 +02:00
Sunny Ripert
5bd18429f0
Renamed Options list to Attributes list whenever they weren't option hashes in AR::Base
2008-05-07 13:53:35 +02:00
Xavier Noria
2fa628e34b
revised details in Exceptions section of AR::Base docs
2008-05-07 11:53:08 +02:00
Yaroslav Markin
d912bd5672
Add a filter_parameter_logging usage hint to generated ApplicationController.
...
This may help to remind the developer to filter sensitive information from application logs.
Closes #11578
2008-05-07 13:50:28 +04:00
Xavier Noria
88e4de5ab7
revised a few details in session docs
2008-05-07 11:23:54 +02:00
Jack Danger Canty
080d5b7acb
Fixing typo in association class name
2008-05-06 23:42:06 -07:00
Jack Danger Canty
b243de0db3
doc: disambiguating an example ActiveRecord class
2008-05-06 23:39:47 -07:00
Jack Danger Canty
f81d771f06
doc: ActiveRecord::Reflection::AssociationReflection#through_reflection
...
Added documentation demonstrating the use of #through_reflection for
finding intervening reflection objects for HasManyThrough
and HasOneThrough.
2008-05-06 23:35:05 -07:00
Cheah Chu Yeow
405de50af0
Merge branch 'master' of git@github.com:lifo/docrails
2008-05-07 13:48:01 +08:00
Cheah Chu Yeow
ae6b46f00b
Document AttributeAssignmentError and MultiparameterAssignmentErrors.
2008-05-07 13:47:41 +08:00
John Barnette
1851f5aca5
Merge branch 'master' of git@github.com:lifo/docrails
2008-05-06 22:47:25 -07:00
John Barnette
8f463550b5
Killing/fixing a bunch of outdated language in the AR README.
2008-05-06 22:46:44 -07:00
Cheah Chu Yeow
aca44bcd92
Make a note about ActiveResource::Timeouterror being raised when ARes calls timeout.
2008-05-07 13:34:52 +08:00
Xavier Noria
963d7caeee
fixed a misplaced closing tag
2008-05-07 02:25:45 +02:00
Xavier Noria
f168db4cc1
revised a few of filenames
2008-05-07 02:16:19 +02:00
Xavier Noria
8031ba1aee
revised a couple of filenames
2008-05-07 02:12:01 +02:00
Xavier Noria
ec1963a567
revised conventions in rails/plugin.rb
2008-05-07 01:50:55 +02:00
Xavier Noria
dc09a768c2
revised conventions in ActiveResource::Base
2008-05-07 01:41:51 +02:00
Jonathan Dance
284a930a93
improvements to the page caching docs
2008-05-06 15:17:48 -04:00
Pratik Naik
63e8bcaeb3
Merge commit 'mainstream/master'
2008-05-06 12:16:55 +01:00
Pratik Naik
4a0118d727
Merge commit 'mainstream/master'
2008-05-06 10:04:25 +01:00
Xavier Noria
2037cdda0e
revised conventions in AR's validations.rb
2008-05-05 22:58:52 +02:00
Xavier Noria
bc568a1a19
revised conventions in associations.rb
2008-05-05 22:57:15 +02:00
Xavier Noria
3521db70ce
revised list conventions in AM's numericality.rb
2008-05-05 22:50:48 +02:00
Xavier Noria
2979b1a143
revised list conventions in AM's validates_associated
2008-05-05 22:48:16 +02:00
Xavier Noria
c321830033
revised conventions in url_for docs
2008-05-05 22:47:07 +02:00
Xavier Noria
8d78ac598c
revised conventions in resources.rb
2008-05-05 22:45:27 +02:00
Xavier Noria
238acc81be
revised convention for lists in request_forgery_protection.rb
2008-05-05 22:41:11 +02:00
Xavier Noria
bc3aa6b65b
revised convention for lists in action_mailer/base.rb
2008-05-05 22:39:55 +02:00
Sunny Ripert
9482da6213
validates_numericality_of() "integer" option really is "only_integer"
2008-05-05 18:13:40 +02:00
Sunny Ripert
e9afd6790a
Harmonized hash notation in AR::Base
2008-05-05 12:11:59 +02:00
Sunny Ripert
67ebf14a91
Turned options into rdoc-lists in AR::Base
2008-05-05 12:06:19 +02:00
Marshall Huss
0ec7c0a41d
Added information of how to set element_name in the case the user has a name confliction with an existing model
2008-05-04 23:21:33 -04:00
Xavier Noria
aad45f920d
revised convention for lists of option in sqlite_adapter.rb
2008-05-04 23:36:21 +02:00
Xavier Noria
225212097e
mysql adapter port is an integer
2008-05-04 23:35:11 +02:00
Xavier Noria
8432415d59
revised some conventions in postgresql_adapter.rb
2008-05-04 23:34:25 +02:00
Xavier Noria
31144d9981
revised some conventions in mysql_adapter.rb
2008-05-04 23:32:13 +02:00
Xavier Noria
3e7bd63ec5
revised some conventions in url_helper.rb
2008-05-04 23:29:35 +02:00
Xavier Noria
17d22e933a
revised some conventions in form_tag_helper.rb
2008-05-04 23:24:20 +02:00
Xavier Noria
50c96f23df
revised some conventions in polymorphic_routes.rb
2008-05-04 23:12:58 +02:00
Xavier Noria
03e68ec80f
revised conventions for lists of options in action_controller/base.rb
2008-05-04 23:05:57 +02:00
Xavier Noria
19edc9116b
revised conventions for lists of options in selector_assertions.rb
2008-05-04 23:04:54 +02:00