f9530e77d1
Close #13973 This PR fixed two bugs. 1) `overhead_hashtable_lut` isn't updated correctly This bug was introduced by https://github.com/redis/redis/pull/12913 We only update `overhead_hashtable_lut` at the beginning and end of rehashing, but we forgot to update it when a dict is emptied or released. This PR introduces a new `bucketChanged` callback to track the change changes in the bucket size. Now, `rehashingStarted` and `rehashingCompleted` callbacks are no longer responsible for bucket changes, but are entirely handled by `bucketChanged`, this can also avoid that we need to register three callbacks to track the change of bucket size, now only one is needed. In most cases, it will be triggered together with `rehashingStarted` or `rehashingCompleted`, except when a dict is being emptied or released, in these cases, even if the dict is not rehashing, we still need to subtract its current size. On the other hand, `overhead_hashtable_lut` was duplicated with `bucket_count`, so we remove `overhead_hashtable_lut` and use `bucket_count` instead. Note that this bug only happens with cluster mode, because we don't use KVSTORE_FREE_EMPTY_DICTS without cluster. 2) The size of `dict_size_index` repeatedly counted in terms of memory usage. `dict_size_index` is created at startup, so its memory usage has been counted into `used_memory_startup`. However, when we want to count the overhead, we repeat the calculation, which may cause the overhead to exceed the total memory usage. --------- Co-authored-by: Yuan Wang <yuan.wang@redis.com>
Redis Test Suite
The normal execution mode of the test suite involves starting and manipulating
local redis-server instances, inspecting process state, log files, etc.
The test suite also supports execution against an external server, which is
enabled using the --host and --port parameters. When executing against an
external server, tests tagged external:skip are skipped.
There are additional runtime options that can further adjust the test suite to match different external server configurations:
| Option | Impact |
|---|---|
--singledb |
Only use database 0, don't assume others are supported. |
--ignore-encoding |
Skip all checks for specific encoding. |
--ignore-digest |
Skip key value digest validations. |
--cluster-mode |
Run in strict Redis Cluster compatibility mode. |
--large-memory |
Enables tests that consume more than 100mb |
Tags
Tags are applied to tests to classify them according to the subsystem they test, but also to indicate compatibility with different run modes and required capabilities.
Tags can be applied in different context levels:
start_servercontexttagscontext that bundles several tests together- A single test context.
The following compatibility and capability tags are currently used:
| Tag | Indicates |
|---|---|
external:skip |
Not compatible with external servers. |
cluster:skip |
Not compatible with --cluster-mode. |
large-memory |
Test that requires more than 100mb |
tls:skip |
Not compatible with --tls. |
needs:repl |
Uses replication and needs to be able to SYNC from server. |
needs:debug |
Uses the DEBUG command or other debugging focused commands (like OBJECT REFCOUNT). |
needs:pfdebug |
Uses the PFDEBUG command. |
needs:config-maxmemory |
Uses CONFIG SET to manipulate memory limit, eviction policies, etc. |
needs:config-resetstat |
Uses CONFIG RESETSTAT to reset statistics. |
needs:reset |
Uses RESET to reset client connections. |
needs:save |
Uses SAVE or BGSAVE to create an RDB file. |
When using an external server (--host and --port), filtering using the
external:skip tags is done automatically.
When using --cluster-mode, filtering using the cluster:skip tag is done
automatically.
When not using --large-memory, filtering using the largemem:skip tag is done
automatically.
In addition, it is possible to specify additional configuration. For example, to
run tests on a server that does not permit SYNC use:
./runtest --host <host> --port <port> --tags -needs:repl