mirror of
https://github.com/redis/redis.git
synced 2026-04-22 19:37:30 -04:00
f9530e77d1
Close #13973 This PR fixed two bugs. 1) `overhead_hashtable_lut` isn't updated correctly This bug was introduced by https://github.com/redis/redis/pull/12913 We only update `overhead_hashtable_lut` at the beginning and end of rehashing, but we forgot to update it when a dict is emptied or released. This PR introduces a new `bucketChanged` callback to track the change changes in the bucket size. Now, `rehashingStarted` and `rehashingCompleted` callbacks are no longer responsible for bucket changes, but are entirely handled by `bucketChanged`, this can also avoid that we need to register three callbacks to track the change of bucket size, now only one is needed. In most cases, it will be triggered together with `rehashingStarted` or `rehashingCompleted`, except when a dict is being emptied or released, in these cases, even if the dict is not rehashing, we still need to subtract its current size. On the other hand, `overhead_hashtable_lut` was duplicated with `bucket_count`, so we remove `overhead_hashtable_lut` and use `bucket_count` instead. Note that this bug only happens with cluster mode, because we don't use KVSTORE_FREE_EMPTY_DICTS without cluster. 2) The size of `dict_size_index` repeatedly counted in terms of memory usage. `dict_size_index` is created at startup, so its memory usage has been counted into `used_memory_startup`. However, when we want to count the overhead, we repeat the calculation, which may cause the overhead to exceed the total memory usage. --------- Co-authored-by: Yuan Wang <yuan.wang@redis.com>