lib: remove library hack (#2700)

* remove hack

* use deprecation instead of warning and shift text to render correctly

ix-dev/community/immich/app.yaml

@@ -43,4 +43,4 @@ sources:
 - https://github.com/immich-app/immich
 title: Immich
 train: community
-version: 1.9.6
+version: 1.9.7

ix-dev/community/immich/ix_values.yaml

@@ -34,15 +34,15 @@ consts:
 
   old_storage_warning: |
     The storage configuration you are using is deprecated and will be removed in a future version.
-    Please migrate to the new storage configuration format.
-    What you essentially have to do is to create a new dataset/directory,
-    move your data there and then update the configuration by unchecking the 'Use old storage config' option.
-    And pointing the 'Data Storage' to the new dataset/directory.
-    For example if you create a new dataset at '/mnt/tank/immich'
-    In this directory create 2 datasets/directories:
-    `/mnt/tank/immich/data` and `/mnt/tank/immich/postgres-data`
+      Please migrate to the new storage configuration format.
+      What you essentially have to do is to create a new dataset/directory,
+      move your data there and then update the configuration by unchecking the 'Use old storage config' option.
+      And pointing the 'Data Storage' to the new dataset/directory.
+      For example if you create a new dataset at '/mnt/tank/immich'
+      In this directory create 2 datasets/directories:
+      `/mnt/tank/immich/data` and `/mnt/tank/immich/postgres-data`
 
-    Now inside the `/mnt/tank/immich/data` directory create the following directories (**NOT** datasets):
-    `mkdir -p /mnt/tank/immich/data/{upload,thumbs,library,profile,backups,encoded-video}`
-    Then you have to move your data from the old separate dataset/directories to the new ones.
-    For example `/mnt/tank/old-immich-data/upload` to `/mnt/tank/immich/data/upload`.
+      Now inside the `/mnt/tank/immich/data` directory create the following directories (**NOT** datasets):
+      `mkdir -p /mnt/tank/immich/data/{upload,thumbs,library,profile,backups,encoded-video}`
+      Then you have to move your data from the old separate dataset/directories to the new ones.
+      For example `/mnt/tank/old-immich-data/upload` to `/mnt/tank/immich/data/upload`.

ix-dev/community/immich/templates/docker-compose.yaml

@@ -31,7 +31,7 @@
 {% if values.storage.use_old_storage_config %}
   {% set is_install = values.get("ix_context", {}).get("is_install", False) %}
   {% if is_install %}{% do tpl.funcs.fail("Old storage configuration is not supported in new installations.") %}{% endif %}
-  {% do tpl.notes.add_warning(values.consts.old_storage_warning) %}
+  {% do tpl.notes.add_deprecation(values.consts.old_storage_warning) %}
 
   {% do server_container.add_storage("%s/upload"|format(base_path), values.storage.uploads) %}
   {% do perm_container.add_or_skip_action("uploads", values.storage.uploads, perms_config) %}

library/2.1.40/volume_sources.py

@@ -32,9 +32,7 @@ class HostPathSource:
             path = valid_fs_path_or_raise(config.get("path", ""))
 
         path = path.rstrip("/")
-        # TODO: Hack for Nextcloud deprecated config. Remove once we remove support for it
-        allow_unsafe_ix_volume = config.get("allow_unsafe_ix_volume", False)
-        self.source = allowed_fs_host_path_or_raise(path, allow_unsafe_ix_volume)
+        self.source = allowed_fs_host_path_or_raise(path)
 
     def get(self):
         return self.source

library/hashes.yaml

@@ -1,2 +1,2 @@
 0.0.1: f074617a82a86d2a6cc78a4c8a4296fc9d168e456f12713e50c696557b302133
-2.1.39: b4a190a205f298a829d540fd643c903f0badc94a55fc6221fecff5c6460fca8d
+2.1.40: baa6944f150f7b186ce2a85a9a737b20b1d59486eac23cde1c77d49784a9337c