getwax/zk-account-abstraction
1
0
Fork 0
mirror of https://github.com/getwax/zk-account-abstraction.git synced 2026-01-08 20:18:05 -05:00
Code Issues Packages Projects Releases Wiki Activity

AA-137 N-06 Indexing aggregator in SignatureAggregatorChanged event (#202)

Browse Source 
* Indexing aggregator in SignatureAggregatorChanged event
This commit is contained in:
shahafn
2023-02-09 01:06:49 +02:00
committed by GitHub
parent 2600d7ef05
commit 1633c063c3
2 changed files with 12 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
contracts/interfaces/IEntryPoint.sol
View File

@@ -48,7 +48,7 @@ interface IEntryPoint is IStakeManager {
/**
* signature aggregator used by the following UserOperationEvents within this bundle.
*/
event SignatureAggregatorChanged(address aggregator);
event SignatureAggregatorChanged(address indexed aggregator);
/**
* a custom revert error of handleOps, to identify the offending op.

22
reports/gas-checker.txt
View File

@@ -1,35 +1,35 @@
== gas estimate of direct calling the account's "execFromEntryPoint" method
the destination is "account.nonce()", which is known to be "hot" address used by this account
it little higher than EOA call: its an exec from entrypoint (or account owner) into account contract, verifying msg.sender and exec to target)
- gas estimate "simple" - 31021
- gas estimate "simple" - 31045
- gas estimate "big tx 5k" - 127295
╔════════════════════════════════╤═══════╤═══════════════╤════════════════╤═════════════════════╗
║ handleOps description │ count │ total gasUsed │ per UserOp gas │ per UserOp overhead ║
║ │ │ │ (delta for │ (compared to ║
║ │ │ │ one UserOp) │ account.exec()) ║
╟────────────────────────────────┼───────┼───────────────┼────────────────┼─────────────────────╢
║ simple │ 1 │ 78099 │ │ ║
║ simple │ 1 │ 78111 │ │ ║
╟────────────────────────────────┼───────┼───────────────┼────────────────┼─────────────────────╢
║ simple - diff from previous │ 2 │ │ 43597 │ 12576 ║
║ simple - diff from previous │ 2 │ │ 43585 │ 12540 ║
╟────────────────────────────────┼───────┼───────────────┼────────────────┼─────────────────────╢
║ simple │ 10 │ 470509 │ │ ║
║ simple │ 10 │ 470521 │ │ ║
╟────────────────────────────────┼───────┼───────────────┼────────────────┼─────────────────────╢
║ simple - diff from previous │ 11 │ │ 43744 │ 12723 ║
║ simple - diff from previous │ 11 │ │ 43708 │ 12663 ║
╟────────────────────────────────┼───────┼───────────────┼────────────────┼─────────────────────╢
║ simple paymaster │ 1 │ 84411 │ │ ║
╟────────────────────────────────┼───────┼───────────────┼────────────────┼─────────────────────╢
║ simple paymaster with diff │ 2 │ │ 42598 │ 11577 ║
║ simple paymaster with diff │ 2 │ │ 42586 │ 11541 ║
╟────────────────────────────────┼───────┼───────────────┼────────────────┼─────────────────────╢
║ simple paymaster │ 10 │ 468002 │ │ ║
║ simple paymaster │ 10 │ 467990 │ │ ║
╟────────────────────────────────┼───────┼───────────────┼────────────────┼─────────────────────╢
║ simple paymaster with diff │ 11 │ │ 42710 │ 11689 ║
║ simple paymaster with diff │ 11 │ │ 42746 │ 11701 ║
╟────────────────────────────────┼───────┼───────────────┼────────────────┼─────────────────────╢
║ big tx 5k │ 1 │ 179834 │ │ ║
╟────────────────────────────────┼───────┼───────────────┼────────────────┼─────────────────────╢
║ big tx - diff from previous │ 2 │ │ 144910 │ 17615 ║
║ big tx - diff from previous │ 2 │ │ 144934 │ 17639 ║
╟────────────────────────────────┼───────┼───────────────┼────────────────┼─────────────────────╢
║ big tx 5k │ 10 │ 1489641 │ │ ║
║ big tx 5k │ 10 │ 1489629 │ │ ║
╟────────────────────────────────┼───────┼───────────────┼────────────────┼─────────────────────╢
║ big tx - diff from previous │ 11 │ │ 146391 │ 19096 ║
║ big tx - diff from previous │ 11 │ │ 146451 │ 19156 ║
╚════════════════════════════════╧═══════╧═══════════════╧════════════════╧═════════════════════╝