github/AutoGPT
1
1
Fork 0
mirror of https://github.com/Significant-Gravitas/AutoGPT.git synced 2026-04-08 03:00:28 -04:00
Code Issues Packages Projects Releases Wiki Activity

fix(backend): validate non-empty question in ask_question tool

Browse Source 
Reject empty/whitespace-only question strings with ValueError instead
of producing an empty clarification card.
This commit is contained in:
Zamil Majdy
2026-04-02 14:18:58 +02:00
parent 9990e9e841
commit 078e89f8a6
2 changed files with 15 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
autogpt_platform/backend/backend/copilot/tools/ask_question.py
View File

@@ -68,7 +68,10 @@ class AskQuestionTool(BaseTool):
**kwargs: Any,
) -> ToolResponseBase:
del user_id # unused; required by BaseTool contract
question: str = kwargs.get("question", "")
question_raw = kwargs.get("question")
if not isinstance(question_raw, str) or not question_raw.strip():
raise ValueError("ask_question requires a non-empty 'question' string")
question = question_raw.strip()
options: list[str] = kwargs.get("options", [])
keyword: str = kwargs.get("keyword", "")
session_id = session.session_id if session else None

11
autogpt_platform/backend/backend/copilot/tools/ask_question_test.py
View File

@@ -69,3 +69,14 @@ async def test_execute_with_keyword_only(tool: AskQuestionTool, session: ChatSes
q = result.questions[0]
assert q.keyword == "trigger"
assert q.example is None
@pytest.mark.asyncio
async def test_execute_rejects_empty_question(
tool: AskQuestionTool, session: ChatSession
):
with pytest.raises(ValueError, match="non-empty"):
await tool._execute(user_id=None, session=session, question="")
with pytest.raises(ValueError, match="non-empty"):
await tool._execute(user_id=None, session=session, question=" ")