feat: add clear error when Agent Generator service is not configured

- Add AgentGeneratorNotConfiguredError exception
- Check service configuration before calling external service
- Return helpful error message in create_agent and edit_agent tools
- Update tests to mock is_external_service_configured

Addresses Sentry review comment about unconditional external service calls

autogpt_platform/backend/backend/api/features/chat/tools/agent_generator/__init__.py

@@ -1,6 +1,7 @@
 """Agent generator package - Creates agents from natural language."""
 
 from .core import (
+    AgentGeneratorNotConfiguredError,
     decompose_goal,
     generate_agent,
     generate_agent_patch,
@@ -19,6 +20,8 @@ __all__ = [
     "save_agent_to_library",
     "get_agent_as_json",
     "json_to_graph",
+    # Exceptions
+    "AgentGeneratorNotConfiguredError",
     # Service
     "is_external_service_configured",
     "check_external_service_health",

autogpt_platform/backend/backend/api/features/chat/tools/agent_generator/core.py

@@ -11,11 +11,31 @@ from .service import (
     decompose_goal_external,
     generate_agent_external,
     generate_agent_patch_external,
+    is_external_service_configured,
 )
 
 logger = logging.getLogger(__name__)
 
 
+class AgentGeneratorNotConfiguredError(Exception):
+    """Raised when the external Agent Generator service is not configured."""
+
+    pass
+
+
+def _check_service_configured() -> None:
+    """Check if the external Agent Generator service is configured.
+
+    Raises:
+        AgentGeneratorNotConfiguredError: If the service is not configured.
+    """
+    if not is_external_service_configured():
+        raise AgentGeneratorNotConfiguredError(
+            "Agent Generator service is not configured. "
+            "Set AGENTGENERATOR_HOST environment variable to enable agent generation."
+        )
+
+
 async def decompose_goal(description: str, context: str = "") -> dict[str, Any] | None:
     """Break down a goal into steps or return clarifying questions.
 
@@ -28,7 +48,11 @@ async def decompose_goal(description: str, context: str = "") -> dict[str, Any]
         - {"type": "clarifying_questions", "questions": [...]}
         - {"type": "instructions", "steps": [...]}
         Or None on error
+
+    Raises:
+        AgentGeneratorNotConfiguredError: If the external service is not configured.
     """
+    _check_service_configured()
     logger.info("Calling external Agent Generator service for decompose_goal")
     return await decompose_goal_external(description, context)
 
@@ -41,7 +65,11 @@ async def generate_agent(instructions: dict[str, Any]) -> dict[str, Any] | None:
 
     Returns:
         Agent JSON dict or None on error
+
+    Raises:
+        AgentGeneratorNotConfiguredError: If the external service is not configured.
     """
+    _check_service_configured()
     logger.info("Calling external Agent Generator service for generate_agent")
     result = await generate_agent_external(instructions)
     if result:
@@ -240,6 +268,10 @@ async def generate_agent_patch(
 
     Returns:
         Updated agent JSON, clarifying questions dict, or None on error
+
+    Raises:
+        AgentGeneratorNotConfiguredError: If the external service is not configured.
     """
+    _check_service_configured()
     logger.info("Calling external Agent Generator service for generate_agent_patch")
     return await generate_agent_patch_external(update_request, current_agent)

autogpt_platform/backend/backend/api/features/chat/tools/create_agent.py

@@ -7,7 +7,12 @@ from langfuse import observe
 
 from backend.api.features.chat.model import ChatSession
 
-from .agent_generator import decompose_goal, generate_agent, save_agent_to_library
+from .agent_generator import (
+    AgentGeneratorNotConfiguredError,
+    decompose_goal,
+    generate_agent,
+    save_agent_to_library,
+)
 from .base import BaseTool
 from .models import (
     AgentPreviewResponse,
@@ -97,7 +102,17 @@ class CreateAgentTool(BaseTool):
             )
 
         # Step 1: Decompose goal into steps
-        decomposition_result = await decompose_goal(description, context)
+        try:
+            decomposition_result = await decompose_goal(description, context)
+        except AgentGeneratorNotConfiguredError:
+            return ErrorResponse(
+                message=(
+                    "Agent generation is not available. "
+                    "The Agent Generator service is not configured."
+                ),
+                error="service_not_configured",
+                session_id=session_id,
+            )
 
         if decomposition_result is None:
             return ErrorResponse(

autogpt_platform/backend/backend/api/features/chat/tools/edit_agent.py

@@ -8,6 +8,7 @@ from langfuse import observe
 from backend.api.features.chat.model import ChatSession
 
 from .agent_generator import (
+    AgentGeneratorNotConfiguredError,
     generate_agent_patch,
     get_agent_as_json,
     save_agent_to_library,
@@ -130,7 +131,17 @@ class EditAgentTool(BaseTool):
             update_request = f"{changes}\n\nAdditional context:\n{context}"
 
         # Step 2: Generate updated agent (external service handles fixing and validation)
-        result = await generate_agent_patch(update_request, current_agent)
+        try:
+            result = await generate_agent_patch(update_request, current_agent)
+        except AgentGeneratorNotConfiguredError:
+            return ErrorResponse(
+                message=(
+                    "Agent editing is not available. "
+                    "The Agent Generator service is not configured."
+                ),
+                error="service_not_configured",
+                session_id=session_id,
+            )
 
         if result is None:
             return ErrorResponse(

autogpt_platform/backend/test/agent_generator/test_core_integration.py

@@ -10,6 +10,34 @@ from unittest.mock import AsyncMock, patch
 import pytest
 
 from backend.api.features.chat.tools.agent_generator import core
+from backend.api.features.chat.tools.agent_generator.core import (
+    AgentGeneratorNotConfiguredError,
+)
+
+
+class TestServiceNotConfigured:
+    """Test that functions raise AgentGeneratorNotConfiguredError when service is not configured."""
+
+    @pytest.mark.asyncio
+    async def test_decompose_goal_raises_when_not_configured(self):
+        """Test that decompose_goal raises error when service not configured."""
+        with patch.object(core, "is_external_service_configured", return_value=False):
+            with pytest.raises(AgentGeneratorNotConfiguredError):
+                await core.decompose_goal("Build a chatbot")
+
+    @pytest.mark.asyncio
+    async def test_generate_agent_raises_when_not_configured(self):
+        """Test that generate_agent raises error when service not configured."""
+        with patch.object(core, "is_external_service_configured", return_value=False):
+            with pytest.raises(AgentGeneratorNotConfiguredError):
+                await core.generate_agent({"steps": []})
+
+    @pytest.mark.asyncio
+    async def test_generate_agent_patch_raises_when_not_configured(self):
+        """Test that generate_agent_patch raises error when service not configured."""
+        with patch.object(core, "is_external_service_configured", return_value=False):
+            with pytest.raises(AgentGeneratorNotConfiguredError):
+                await core.generate_agent_patch("Add a node", {"nodes": []})
 
 
 class TestDecomposeGoal:
@@ -21,6 +49,8 @@ class TestDecomposeGoal:
         expected_result = {"type": "instructions", "steps": ["Step 1"]}
 
         with patch.object(
+            core, "is_external_service_configured", return_value=True
+        ), patch.object(
             core, "decompose_goal_external", new_callable=AsyncMock
         ) as mock_external:
             mock_external.return_value = expected_result
@@ -36,6 +66,8 @@ class TestDecomposeGoal:
         expected_result = {"type": "instructions", "steps": ["Step 1"]}
 
         with patch.object(
+            core, "is_external_service_configured", return_value=True
+        ), patch.object(
             core, "decompose_goal_external", new_callable=AsyncMock
         ) as mock_external:
             mock_external.return_value = expected_result
@@ -48,6 +80,8 @@ class TestDecomposeGoal:
     async def test_returns_none_on_service_failure(self):
         """Test that decompose_goal returns None when external service fails."""
         with patch.object(
+            core, "is_external_service_configured", return_value=True
+        ), patch.object(
             core, "decompose_goal_external", new_callable=AsyncMock
         ) as mock_external:
             mock_external.return_value = None
@@ -66,6 +100,8 @@ class TestGenerateAgent:
         expected_result = {"name": "Test Agent", "nodes": [], "links": []}
 
         with patch.object(
+            core, "is_external_service_configured", return_value=True
+        ), patch.object(
             core, "generate_agent_external", new_callable=AsyncMock
         ) as mock_external:
             mock_external.return_value = expected_result
@@ -92,6 +128,8 @@ class TestGenerateAgent:
         }
 
         with patch.object(
+            core, "is_external_service_configured", return_value=True
+        ), patch.object(
             core, "generate_agent_external", new_callable=AsyncMock
         ) as mock_external:
             mock_external.return_value = expected_result.copy()
@@ -107,6 +145,8 @@ class TestGenerateAgent:
     async def test_returns_none_when_external_service_fails(self):
         """Test that generate_agent returns None when external service fails."""
         with patch.object(
+            core, "is_external_service_configured", return_value=True
+        ), patch.object(
             core, "generate_agent_external", new_callable=AsyncMock
         ) as mock_external:
             mock_external.return_value = None
@@ -125,6 +165,8 @@ class TestGenerateAgentPatch:
         expected_result = {"name": "Updated Agent", "nodes": [], "links": []}
 
         with patch.object(
+            core, "is_external_service_configured", return_value=True
+        ), patch.object(
             core, "generate_agent_patch_external", new_callable=AsyncMock
         ) as mock_external:
             mock_external.return_value = expected_result
@@ -144,6 +186,8 @@ class TestGenerateAgentPatch:
         }
 
         with patch.object(
+            core, "is_external_service_configured", return_value=True
+        ), patch.object(
             core, "generate_agent_patch_external", new_callable=AsyncMock
         ) as mock_external:
             mock_external.return_value = expected_result
@@ -156,6 +200,8 @@ class TestGenerateAgentPatch:
     async def test_returns_none_when_external_service_fails(self):
         """Test that generate_agent_patch returns None when service fails."""
         with patch.object(
+            core, "is_external_service_configured", return_value=True
+        ), patch.object(
             core, "generate_agent_patch_external", new_callable=AsyncMock
         ) as mock_external:
             mock_external.return_value = None