github/AutoGPT
1
1
Fork 0
mirror of https://github.com/Significant-Gravitas/AutoGPT.git synced 2026-02-15 01:05:13 -05:00
Code Issues Packages Projects Releases Wiki Activity

fix: prevent race condition where links load before nodes

Browse Source 
Combined the separate useEffect hooks for adding nodes and links into
a single effect that ensures nodes are added first. Previously, links
could be processed before nodes existed in the store, causing all
connections to be silently filtered out.

Fixes: Sentry bug prediction about race condition on graph load
This commit is contained in:
Otto
2026-02-15 05:49:59 +00:00
parent 79748ca7fa
commit 2be589c95f
1 changed files with 8 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
autogpt_platform/frontend/src/app/(platform)/build/components/FlowEditor/Flow/useFlow.ts
View File

@@ -133,22 +133,21 @@ export const useFlow = () => {
}
}, [availableGraphs, setAvailableSubGraphs]);
// adding nodes
// adding nodes and links together to avoid race condition
// Links depend on nodes existing, so we must add nodes first
useEffect(() => {
if (customNodes.length > 0) {
useNodeStore.getState().setNodes([]);
useNodeStore.getState().clearResolutionState();
addNodes(customNodes);
}
}, [customNodes, addNodes]);
// adding links
useEffect(() => {
if (graph?.links) {
useEdgeStore.getState().setEdges([]);
addLinks(graph.links);
// Only add links after nodes are in the store
if (graph?.links) {
useEdgeStore.getState().setEdges([]);
addLinks(graph.links);
}
}
}, [graph?.links, addLinks]);
}, [customNodes, graph?.links, addNodes, addLinks]);
useEffect(() => {
if (customNodes.length > 0 && graph?.links) {