github/AutoGPT
1
1
Fork 0
mirror of https://github.com/Significant-Gravitas/AutoGPT.git synced 2026-01-27 16:08:10 -05:00
Code Issues Packages Projects Releases Wiki Activity

fix(backend): roll back in-memory messages on upsert failure

Browse Source 
If upsert_chat_session fails, the appended messages are now removed
from the in-memory session to prevent data corruption on subsequent saves.
This commit is contained in:
Zamil Majdy
2026-01-27 12:39:06 -06:00
parent 3d6b42003b
commit 48e909b74f
1 changed files with 24 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

30
autogpt_platform/backend/backend/api/features/chat/service.py
View File

@@ -1222,13 +1222,13 @@ async def _stream_chat_chunks(
tool_calls[idx]["id"] = tc_chunk.id
if tc_chunk.function:
if tc_chunk.function.name:
tool_calls[idx]["function"]["name"] = (
tc_chunk.function.name
)
tool_calls[idx]["function"][
"name"
] = tc_chunk.function.name
if tc_chunk.function.arguments:
tool_calls[idx]["function"]["arguments"] += (
tc_chunk.function.arguments
)
tool_calls[idx]["function"][
"arguments"
] += tc_chunk.function.arguments
# Emit StreamToolInputStart only after we have the tool call ID
if (
@@ -1412,6 +1412,10 @@ async def _yield_tool_call(
"check back in a few minutes."
)
# Track appended messages for rollback on failure
assistant_message: ChatMessage | None = None
pending_message: ChatMessage | None = None
# Wrap session save and task creation in try-except to release lock on failure
try:
# Save assistant message with tool_call FIRST (required by LLM)
@@ -1450,6 +1454,20 @@ async def _yield_tool_call(
)
)
except Exception as e:
# Roll back appended messages to prevent data corruption on subsequent saves
if (
pending_message
and session.messages
and session.messages[-1] == pending_message
):
session.messages.pop()
if (
assistant_message
and session.messages
and session.messages[-1] == assistant_message
):
session.messages.pop()
# Release the Redis lock since the background task won't be spawned
await _mark_operation_completed(tool_call_id)
logger.error(