fix: make overlap check informational only (always green)

- Add continue-on-error: true to workflow
- Remove sys.exit(1) on conflicts
- Check is meant to inform contributors, not block merging
This commit is contained in:
Otto
2026-02-13 13:07:45 +00:00
parent db77f6ef77
commit aab33c4e14
2 changed files with 4 additions and 2 deletions

View File

@@ -216,17 +216,17 @@ def find_file_overlap_candidates(
def report_results(overlaps: list["Overlap"]):
"""Report results and exit with appropriate code."""
"""Report results (informational only, always exits 0)."""
conflicts = [o for o in overlaps if o.has_merge_conflict]
if conflicts:
print(f"\n⚠️ Found {len(conflicts)} merge conflict(s)")
sys.exit(1)
line_overlap_count = len([o for o in overlaps if o.line_overlaps])
if line_overlap_count:
print(f"\n⚠️ Found {line_overlap_count} PR(s) with line overlap")
print("\n✅ Done")
# Always exit 0 - this check is informational, not a merge blocker
# =============================================================================

View File

@@ -33,5 +33,7 @@ jobs:
- name: Run overlap detection
env:
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
# Always succeed - this check informs contributors, it shouldn't block merging
continue-on-error: true
run: |
python .github/scripts/detect_overlaps.py ${{ github.event.pull_request.number }}