github/AutoGPT
1
1
Fork 0
mirror of https://github.com/Significant-Gravitas/AutoGPT.git synced 2026-04-08 03:00:28 -04:00
Code Issues Packages Projects Releases Wiki Activity

fix(frontend): stabilize handleExecutionEvent ref and remove useMemo side effects

Browse Source 
Use a ref for combinedAgentInfoMap in the WebSocket callback to prevent
stale closures and unnecessary re-subscriptions. Replace ref mutations
inside useMemo with a pure key computation + useEffect for stabilization.
This commit is contained in:
abhi1992002
2026-04-01 16:49:54 +05:30
parent 130d0a268e
commit c8c1b56f30
1 changed files with 21 additions and 23 deletions
Download Patch File Download Diff File Expand all files Collapse all files

44
autogpt_platform/frontend/src/components/layout/Navbar/components/AgentActivityDropdown/useAgentActivityDropdown.ts
View File

@@ -45,9 +45,6 @@ export function useAgentActivityDropdown() {
Map<string, AgentInfo>
>(new Map());
const failedLookups = useRef<Map<string, number>>(new Map());
const prevMissingIdsKey = useRef<string>("");
const prevMissingIds = useRef<string[]>([]);
const [notifications, setNotifications] = useState<NotificationState>({
activeExecutions: [],
recentCompletions: [],
@@ -83,9 +80,9 @@ export function useAgentActivityDropdown() {
return merged;
}, [agentInfoMap, resolvedAgentInfoMap]);
const missingGraphIds = useMemo(() => {
const missingGraphIdsKey = useMemo(() => {
if (!executions) {
return [];
return "";
}
const cutoffTime = Date.now() - SEVENTY_TWO_HOURS_IN_MS;
@@ -109,31 +106,32 @@ export function useAgentActivityDropdown() {
}
}
const candidate = Array.from(ids).slice(0, MAX_AGENT_INFO_LOOKUPS);
const key = candidate.join(",");
// Stabilize reference: only return a new array when the actual IDs change
if (key === prevMissingIdsKey.current) {
return prevMissingIds.current;
}
prevMissingIdsKey.current = key;
prevMissingIds.current = candidate;
return candidate;
return Array.from(ids).slice(0, MAX_AGENT_INFO_LOOKUPS).join(",");
}, [combinedAgentInfoMap, executions]);
// Stabilize the array reference: only update when the computed key changes
const [missingGraphIds, setMissingGraphIds] = useState<string[]>([]);
useEffect(() => {
setMissingGraphIds(missingGraphIdsKey ? missingGraphIdsKey.split(",") : []);
}, [missingGraphIdsKey]);
const graphIds = useMemo(
() => Array.from(combinedAgentInfoMap.keys()),
[combinedAgentInfoMap],
);
const handleExecutionEvent = useCallback(
(execution: GraphExecution) => {
setNotifications((currentState) =>
handleExecutionUpdate(currentState, execution, combinedAgentInfoMap),
);
},
[combinedAgentInfoMap],
);
const combinedAgentInfoMapRef = useRef(combinedAgentInfoMap);
combinedAgentInfoMapRef.current = combinedAgentInfoMap;
const handleExecutionEvent = useCallback((execution: GraphExecution) => {
setNotifications((currentState) =>
handleExecutionUpdate(
currentState,
execution,
combinedAgentInfoMapRef.current,
),
);
}, []);
useEffect(() => {
if (!executions || !executionsSuccess) {