github/AutoGPT
1
1
Fork 0
mirror of https://github.com/Significant-Gravitas/AutoGPT.git synced 2026-04-30 03:00:41 -04:00
Code Issues Packages Projects Releases Wiki Activity

fix(frontend): prevent cross-graph session assignment in concurrent navigation

Browse Source 
Track effectFlowID at session creation start and compare against currentFlowIDRef
after the async postV2CreateSession resolves. If the user navigated to a different
graph before the response arrived, the old session ID is discarded instead of
being committed to the new graph's state, preventing chat history from being
crossed between graphs.
This commit is contained in:
majdyz
2026-04-09 12:06:33 +07:00
parent 6673972659
commit ebec9a11f9
1 changed files with 14 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
autogpt_platform/frontend/src/app/(platform)/build/components/BuilderChatPanel/useBuilderChatPanel.ts
View File

@@ -102,11 +102,17 @@ export function useBuilderChatPanel({
const processedToolCallsRef = useRef(new Set<string>());
// Guards against sending the seed message more than once per session.
const hasSentSeedMessageRef = useRef(false);
// Tracks the current flowID as a ref so in-flight session creation callbacks
// can verify the graph hasn't changed before committing the new sessionId.
const currentFlowIDRef = useRef<string | null>(null);
const [{ flowID }, setQueryStates] = useQueryStates({
flowID: parseAsString,
flowExecutionID: parseAsString,
});
// Keep ref in sync with the current flowID so in-flight session callbacks can
// detect stale graph context without closure staleness issues.
currentFlowIDRef.current = flowID;
const { toast } = useToast();
const nodes = useNodeStore(
@@ -145,6 +151,10 @@ export function useBuilderChatPanel({
// or the effect re-runs, avoiding stale state from async calls.
let cancelled = false;
isCreatingSessionRef.current = true;
// Snapshot the flowID at effect start so the result is rejected if the
// user navigates to a different graph before the request completes, preventing
// the old session from being assigned to the new graph.
const effectFlowID = flowID;
async function createSession() {
setIsCreatingSession(true);
@@ -153,7 +163,9 @@ export function useBuilderChatPanel({
// session before allowing any messages — session IDs alone are not
// sufficient for unauthorized access.
const res = await postV2CreateSession(null);
if (cancelled) return;
// Discard the result if the effect was cancelled (unmount or re-run) or
// if the user navigated to a different graph before the request completed.
if (cancelled || currentFlowIDRef.current !== effectFlowID) return;
if (res.status === 200) {
const id = res.data.id;
// Validate the session ID is a safe non-empty identifier before
@@ -165,7 +177,7 @@ export function useBuilderChatPanel({
}
setSessionId(id);
// Cache so this session is reused next time the same graph is opened.
if (flowID) graphSessionCache.set(flowID, id);
if (effectFlowID) graphSessionCache.set(effectFlowID, id);
} else {
setSessionError(true);
}