github/AutoGPT
1
1
Fork 0
mirror of https://github.com/Significant-Gravitas/AutoGPT.git synced 2026-02-08 22:05:08 -05:00
Code Issues Packages Projects Releases Wiki Activity

refactor(backend): Improve cleanup pattern per code review

Browse Source 
- Initialize synthetic_exec_id before try block instead of using locals()
- Replace anti-pattern `if "var" in locals()` with proper `if var:` check
- Add cleanup in credentials error path for consistency

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This commit is contained in:
Torantulino
2026-01-26 21:39:28 +01:00
parent d7b69bfabc
commit f4f48419dd
1 changed files with 5 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
autogpt_platform/backend/backend/api/features/chat/tools/run_block.py
View File

@@ -222,6 +222,7 @@ class RunBlockTool(BaseTool):
graph_version=None,
)
synthetic_exec_id = None
try:
# Generate synthetic execution context for standalone block execution
synthetic_exec_id = f"copilot-{session.session_id}-{uuid.uuid4().hex[:8]}"
@@ -253,6 +254,8 @@ class RunBlockTool(BaseTool):
if actual_credentials:
exec_kwargs[field_name] = actual_credentials
else:
if synthetic_exec_id:
clean_exec_files(synthetic_exec_id)
return ErrorResponse(
message=f"Failed to retrieve credentials for {field_name}",
session_id=session_id,
@@ -281,7 +284,7 @@ class RunBlockTool(BaseTool):
except BlockError as e:
logger.warning(f"Block execution failed: {e}")
# Clean up temporary files even on failure
if "synthetic_exec_id" in locals():
if synthetic_exec_id:
clean_exec_files(synthetic_exec_id)
return ErrorResponse(
message=f"Block execution failed: {e}",
@@ -291,7 +294,7 @@ class RunBlockTool(BaseTool):
except Exception as e:
logger.error(f"Unexpected error executing block: {e}", exc_info=True)
# Clean up temporary files even on failure
if "synthetic_exec_id" in locals():
if synthetic_exec_id:
clean_exec_files(synthetic_exec_id)
return ErrorResponse(
message=f"Failed to execute block: {str(e)}",