github/CoolProp
1
1
Fork 0
mirror of https://github.com/CoolProp/CoolProp.git synced 2026-04-23 03:00:17 -04:00
Code Issues Packages Projects Releases Wiki Activity

Start PT flash with Halley's method; closes #929

Browse Source
This commit is contained in:
Ian Bell
2016-01-17 16:48:29 -07:00
parent 053f912ba8
commit 6bcf0ecba1
1 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/Backends/Helmholtz/HelmholtzEOSMixtureBackend.cpp
View File

@@ -902,7 +902,7 @@ CoolPropDbl HelmholtzEOSMixtureBackend::calc_p_critical(void)
if (components.size() != 1){
std::vector<CriticalState> critpts = calc_all_critical_points();
if (critpts.size() == 1){
if (!critpts[0].stable){ throw ValueError(format("found one critical point but critical point is not stable")); }
//if (!critpts[0].stable){ throw ValueError(format("found one critical point but critical point is not stable")); }
return critpts[0].p;
}
else{
@@ -918,7 +918,7 @@ CoolPropDbl HelmholtzEOSMixtureBackend::calc_rhomolar_critical(void)
if (components.size() != 1){
std::vector<CriticalState> critpts = calc_all_critical_points();
if (critpts.size() == 1){
if (!critpts[0].stable){ throw ValueError(format("found one critical point but critical point is not stable")); }
//if (!critpts[0].stable){ throw ValueError(format("found one critical point but critical point is not stable")); }
return critpts[0].rhomolar;
}
else{
@@ -2038,8 +2038,8 @@ CoolPropDbl HelmholtzEOSMixtureBackend::solver_rho_Tp(CoolPropDbl T, CoolPropDbl
try{
// First we try with Newton's method with analytic derivative
double rhomolar = Newton(resid, rhomolar_guess, 1e-8, 100, errstring);
// First we try with Halley's method with analytic derivative
double rhomolar = Halley(resid, rhomolar_guess, 1e-8, 100, errstring);
if (!ValidNumber(rhomolar)){
throw ValueError();
}