github/ESPTimeCast
1
1
Fork 0
mirror of https://github.com/mfactory-osaka/ESPTimeCast.git synced 2026-02-19 11:54:56 -05:00
Code Issues Packages Projects Releases Wiki Activity

Security update

Browse Source 
Saved ssid and password are no longer visible when the device starts in AP mode
This commit is contained in:
M-Factory
2025-09-07 14:24:44 +09:00
parent 24b44bc95a
commit 8a790dbf4a
2 changed files with 82 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

41
ESPTimeCast_ESP32/ESPTimeCast_ESP32.ino
View File

@@ -326,6 +326,10 @@ void connectWiFi() {
Serial.println(WiFi.softAPIP());
isAPMode = true;
clearWiFiCredentialsInConfig();
strlcpy(ssid, "", sizeof(ssid));
strlcpy(password, "", sizeof(password));
WiFiMode_t mode = WiFi.getMode();
Serial.printf("[WIFI] WiFi mode after setting AP: %s\n",
mode == WIFI_OFF ? "OFF" : mode == WIFI_STA ? "STA ONLY"
@@ -384,6 +388,10 @@ void connectWiFi() {
dnsServer.start(DNS_PORT, "*", WiFi.softAPIP());
isAPMode = true;
clearWiFiCredentialsInConfig();
strlcpy(ssid, "", sizeof(ssid));
strlcpy(password, "", sizeof(password));
auto mode = WiFi.getMode();
Serial.printf("[WIFI] WiFi mode after STA failure and setting AP: %s\n",
mode == WIFI_OFF ? "OFF" : mode == WIFI_STA ? "STA ONLY"
@@ -409,6 +417,39 @@ void connectWiFi() {
}
}
void clearWiFiCredentialsInConfig() {
DynamicJsonDocument doc(2048);
// Open existing config, if present
File configFile = LittleFS.open("/config.json", "r");
if (configFile) {
DeserializationError err = deserializeJson(doc, configFile);
configFile.close();
if (err) {
Serial.print(F("[SECURITY] Error parsing config.json: "));
Serial.println(err.f_str());
return;
}
}
doc["ssid"] = "";
doc["password"] = "";
// Optionally backup previous config
if (LittleFS.exists("/config.json")) {
LittleFS.rename("/config.json", "/config.bak");
}
File f = LittleFS.open("/config.json", "w");
if (!f) {
Serial.println(F("[SECURITY] ERROR: Cannot write to /config.json to clear credentials!"));
return;
}
serializeJson(doc, f);
f.close();
Serial.println(F("[SECURITY] Cleared WiFi credentials in config.json."));
}
// -----------------------------------------------------------------------------
// Time / NTP Functions
// -----------------------------------------------------------------------------

41
ESPTimeCast_ESP8266/ESPTimeCast_ESP8266.ino
View File

@@ -327,6 +327,10 @@ void connectWiFi() {
Serial.println(WiFi.softAPIP());
isAPMode = true;
clearWiFiCredentialsInConfig();
strlcpy(ssid, "", sizeof(ssid));
strlcpy(password, "", sizeof(password));
WiFiMode_t mode = WiFi.getMode();
Serial.printf("[WIFI] WiFi mode after setting AP: %s\n",
mode == WIFI_OFF ? "OFF" : mode == WIFI_STA ? "STA ONLY"
@@ -385,6 +389,10 @@ void connectWiFi() {
dnsServer.start(DNS_PORT, "*", WiFi.softAPIP());
isAPMode = true;
clearWiFiCredentialsInConfig();
strlcpy(ssid, "", sizeof(ssid));
strlcpy(password, "", sizeof(password));
WiFiMode_t mode = WiFi.getMode();
Serial.printf("[WIFI] WiFi mode after STA failure and setting AP: %s\n",
mode == WIFI_OFF ? "OFF" : mode == WIFI_STA ? "STA ONLY"
@@ -410,6 +418,39 @@ void connectWiFi() {
}
}
void clearWiFiCredentialsInConfig() {
DynamicJsonDocument doc(2048);
// Open existing config, if present
File configFile = LittleFS.open("/config.json", "r");
if (configFile) {
DeserializationError err = deserializeJson(doc, configFile);
configFile.close();
if (err) {
Serial.print(F("[SECURITY] Error parsing config.json: "));
Serial.println(err.f_str());
return;
}
}
doc["ssid"] = "";
doc["password"] = "";
// Optionally backup previous config
if (LittleFS.exists("/config.json")) {
LittleFS.rename("/config.json", "/config.bak");
}
File f = LittleFS.open("/config.json", "w");
if (!f) {
Serial.println(F("[SECURITY] ERROR: Cannot write to /config.json to clear credentials!"));
return;
}
serializeJson(doc, f);
f.close();
Serial.println(F("[SECURITY] Cleared WiFi credentials in config.json."));
}
// -----------------------------------------------------------------------------
// Time / NTP Functions
// -----------------------------------------------------------------------------