fix: improve date parsing and prevent early return when PR numbers exist

## CHANGES

- Add SQLite datetime formats to version date parsing logic
- Loop through multiple date formats until one succeeds
- Include SQLite fractional seconds format support
- Prevent early return when version has PR numbers to output
- Simplify error handling for date parsing failures
This commit is contained in:
Kayvan Sylvan
2026-01-04 11:07:49 -08:00
parent a6ad1d77f9
commit 12b6cf4a0a
2 changed files with 17 additions and 7 deletions

View File

@@ -202,14 +202,23 @@ func (c *Cache) GetVersions() (map[string]*git.Version, error) {
}
if dateStr.Valid {
// Try RFC3339Nano first (for nanosecond precision), then fall back to RFC3339
v.Date, err = time.Parse(time.RFC3339Nano, dateStr.String)
if err != nil {
v.Date, err = time.Parse(time.RFC3339, dateStr.String)
if err != nil {
fmt.Fprintf(os.Stderr, "Error parsing date '%s' for version '%s': %v. Expected format: RFC3339 or RFC3339Nano.\n", dateStr.String, v.Name, err)
// Try multiple date formats: SQLite format, RFC3339Nano, and RFC3339
dateFormats := []string{
"2006-01-02 15:04:05-07:00", // SQLite DATETIME format
"2006-01-02 15:04:05.999999999-07:00", // SQLite with fractional seconds
time.RFC3339Nano,
time.RFC3339,
}
var parseErr error
for _, format := range dateFormats {
v.Date, parseErr = time.Parse(format, dateStr.String)
if parseErr == nil {
break // Successfully parsed
}
}
if parseErr != nil {
fmt.Fprintf(os.Stderr, "Error parsing date '%s' for version '%s': %v\n", dateStr.String, v.Name, parseErr)
}
}
if prNumbersJSON != "" {

View File

@@ -470,7 +470,8 @@ func (g *Generator) generateRawVersionContent(version *git.Version) string {
}
// There are occasionally no PRs or direct commits other than version bumps, so we handle that gracefully
if len(prCommits) == 0 && len(directCommits) == 0 {
// However, don't return early if we have PRs to output from version.PRNumbers
if len(prCommits) == 0 && len(directCommits) == 0 && len(version.PRNumbers) == 0 {
return ""
}