github/Fabric
1
1
Fork 0
mirror of https://github.com/danielmiessler/Fabric.git synced 2026-01-10 06:48:04 -05:00
Code Issues Packages Projects Releases Wiki Activity

chore: improve error message clarity in changelog generation and cache operations

Browse Source 
## CHANGES

- Clarify RFC3339Nano date parsing error message
- Improve PR batch cache save error description
- Add context for commit timestamp fallback warning
- Specify git index in file removal error message
This commit is contained in:
Kayvan Sylvan
2025-07-21 16:59:50 -07:00
parent 3cf2557af3
commit dd96014f9b
2 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
cmd/generate_changelog/internal/cache/cache.go vendored
View File

@@ -205,7 +205,7 @@ func (c *Cache) GetVersions() (map[string]*git.Version, error) {
// Try RFC3339Nano first (for nanosecond precision), then fall back to RFC3339
v.Date, err = time.Parse(time.RFC3339Nano, dateStr.String)
if err != nil {
fmt.Fprintf(os.Stderr, "Error parsing date '%s' with RFC3339Nano: %v\n", dateStr.String, err)
fmt.Fprintf(os.Stderr, "Failed to parse date with RFC3339Nano format, trying RFC3339 fallback: %v\n", err)
v.Date, err = time.Parse(time.RFC3339, dateStr.String)
if err != nil {
fmt.Fprintf(os.Stderr, "Error parsing date '%s' with RFC3339: %v\n", dateStr.String, err)

6
cmd/generate_changelog/internal/changelog/processing.go
View File

@@ -201,7 +201,7 @@ func (g *Generator) CreateNewChangelogEntry(version string) error {
if len(fetchedPRs) > 0 {
// Save PRs to cache
if err := g.cache.SavePRBatch(fetchedPRs); err != nil {
fmt.Fprintf(os.Stderr, "Warning: Failed to cache PRs: %v\n", err)
fmt.Fprintf(os.Stderr, "Warning: Failed to save PR batch to cache: %v\n", err)
}
// Save SHA→PR mappings for lightning-fast git operations
@@ -216,7 +216,7 @@ func (g *Generator) CreateNewChangelogEntry(version string) error {
commitDate := commit.Date
if commitDate.IsZero() {
commitDate = time.Now()
fmt.Fprintf(os.Stderr, "Warning: Commit %s has invalid timestamp, using current time\n", commit.SHA)
fmt.Fprintf(os.Stderr, "Warning: Commit %s has invalid timestamp (likely due to git history rewrite), using current time as fallback\n", commit.SHA)
}
// Convert github.PRCommit to git.Commit
@@ -262,7 +262,7 @@ func (g *Generator) CreateNewChangelogEntry(version string) error {
// Use git remove to handle both filesystem and git index
if err := g.gitWalker.RemoveFile(relativeFile); err != nil {
fmt.Fprintf(os.Stderr, "Warning: Failed to remove %s from git: %v\n", relativeFile, err)
fmt.Fprintf(os.Stderr, "Warning: Failed to remove %s from git index: %v\n", relativeFile, err)
// Fallback to filesystem-only removal
if err := os.Remove(file); err != nil {
fmt.Fprintf(os.Stderr, "Warning: Failed to remove %s from filesystem: %v\n", file, err)