Update version to v1.4.237 and commit

Merge pull request #1590 from ksylvan/0706-webui-topp-fix
Do not pass non-default TopP values
2026-01-09 22:38:10 -05:00 · 2025-07-07 03:05:51 +00:00 · 2025-07-06 20:04:16 -07:00 · 2025-07-06 19:53:21 -07:00 · 2025-07-06 19:39:24 +00:00 · 2025-07-06 12:37:56 -07:00
5 changed files with 60 additions and 11 deletions
--- a/.github/ISSUE_TEMPLATE/bug.yml
+++ b/.github/ISSUE_TEMPLATE/bug.yml
@@ -7,29 +7,74 @@ body:
    attributes:
      value: |
        Thanks for taking the time to fill out this bug report!
+        Please provide as much detail as possible to help us understand and reproduce the issue.
+
  - type: textarea
    id: what-happened
    attributes:
      label: What happened?
      description: Also tell us, what did you expect to happen?
      placeholder: Tell us what you see!
-      value: "I was doing THIS, when THAT happened. I was expecting THAT_OTHER_THING to happen instead."
+      value: "Please provide all the steps to reproduce the bug. I was doing THIS, when THAT happened. I was expecting THAT_OTHER_THING to happen instead."
    validations:
      required: true
-  - type: checkboxes
+
+  - type: dropdown
+    id: os
+    attributes:
+      label: Operating System
+      options:
+        - macOS - Silicon (arm64)
+        - macOS - Intel (amd64)
+        - Linux - amd64
+        - Linux - arm64
+        - Windows
+    validations:
+      required: true
+
+  - type: textarea
+    id: os-version
+    attributes:
+      label: OS Version
+      description: Please provide details about your OS version by running one of the following commands.
+      placeholder: |
+        macOS: `sw_vers`
+        Linux: `uname -a` or `cat /etc/os-release`
+        Windows: `ver`
+      render: shell
+
+  - type: dropdown
+    id: installation
+    attributes:
+      label: How did you install Fabric?
+      description: "Please select the method you used to install Fabric. You can find this information in the [Installation section of the README](https://github.com/ksylvan/fabric/blob/main/README.md#installation)."
+      options:
+        - Release Binary - Windows
+        - Release Binary - macOS (arm64)
+        - Release Binary - macOS (amd64)
+        - Release Binary - Linux (amd64)
+        - Release Binary - Linux (arm64)
+        - Package Manager - Homebrew (macOS)
+        - Package Manager - AUR (Arch Linux)
+        - From Source
+        - Other
+    validations:
+      required: true
+
+  - type: textarea
    id: version
    attributes:
-      label: Version check
-      description: Please make sure you were using the latest version of this project available in the `main` branch.
-      options:
-        - label: Yes I was.
-          required: true
+      label: Version
+      description: Please copy and paste the output of `fabric --version` (or `fabric-ai --version` if you installed it via brew) here.
+      render: text
+
  - type: textarea
    id: logs
    attributes:
      label: Relevant log output
      description: Please copy and paste any relevant log output. This will be automatically formatted into code, so no need for backticks.
      render: shell
+
  - type: textarea
    id: screens
    attributes:
--- a/nix/pkgs/fabric/version.nix
+++ b/nix/pkgs/fabric/version.nix
@@ -1 +1 @@
-"1.4.235"
+"1.4.237"
--- a/plugins/ai/openai/chat_completions.go
+++ b/plugins/ai/openai/chat_completions.go
@@ -69,7 +69,9 @@ func (o *Client) buildChatCompletionParams(

 	if !opts.Raw {
 		ret.Temperature = openai.Float(opts.Temperature)
-		ret.TopP = openai.Float(opts.TopP)
+		if opts.TopP != 0 {
+			ret.TopP = openai.Float(opts.TopP)
+		}
 		if opts.MaxTokens != 0 {
 			ret.MaxTokens = openai.Int(int64(opts.MaxTokens))
 		}
--- a/plugins/ai/openai/openai.go
+++ b/plugins/ai/openai/openai.go
@@ -221,7 +221,9 @@ func (o *Client) buildResponseParams(

 	if !opts.Raw {
 		ret.Temperature = openai.Float(opts.Temperature)
-		ret.TopP = openai.Float(opts.TopP)
+		if opts.TopP != 0 {
+			ret.TopP = openai.Float(opts.TopP)
+		}
 		if opts.MaxTokens != 0 {
 			ret.MaxOutputTokens = openai.Int(int64(opts.MaxTokens))
 		}
--- a/version.go
+++ b/version.go
@@ -1,3 +1,3 @@
 package main

-var version = "v1.4.235"
+var version = "v1.4.237"
Author	SHA1	Message	Date
github-actions[bot]	4cfe2375ab	Update version to v1.4.237 and commit	2025-07-07 03:05:51 +00:00
Kayvan Sylvan	2b371b69c7	Merge pull request #1590 from ksylvan/0706-webui-topp-fix Do not pass non-default TopP values	2025-07-06 20:04:16 -07:00
Kayvan Sylvan	6222a613e4	fix: add conditional check for TopP parameter in OpenAI client ## CHANGES - Add zero-value check before setting TopP parameter - Prevent sending TopP when value is zero - Apply fix to both chat completions method - Apply fix to response parameters method - Ensure consistent parameter handling across OpenAI calls	2025-07-06 19:53:21 -07:00
github-actions[bot]	0882c43532	Update version to v1.4.236 and commit	2025-07-06 19:39:24 +00:00
Kayvan Sylvan	f0e1a1b77f	Merge pull request #1587 from ksylvan/0705-enhance-bug-report-template Enhance bug report template	2025-07-06 12:37:56 -07:00
Kayvan Sylvan	a774f991ab	chore: enhance bug report template with detailed system info and installation method fields ## CHANGES - Add detailed instructions for bug reproduction steps - Include operating system dropdown with specific architectures - Add OS version textarea with command examples - Create installation method dropdown with all options - Replace version checkbox with proper version output field - Improve formatting and organization of form sections - Add helpful links to installation documentation	2025-07-06 11:01:53 -07:00