github/InvokeAI
1
1
Fork 0
mirror of https://github.com/invoke-ai/InvokeAI.git synced 2026-04-23 03:00:31 -04:00
Code Issues Packages Projects Releases Wiki Activity

fix(ui): image selected twice on invocation complete

Browse Source 
Selecting a board selects the image, and then we were selecting it again afterwards. So we programmatically select the newly generated image twice.

This can cause a race condition if the user changes image selection between when the two programmatic image selection actions. Their selection will be quickly overridden by the second programmatic selection action.
This commit is contained in:
psychedelicious
2024-09-24 10:55:02 +10:00
parent de809ec1d4
commit 6bbaaed8cb
1 changed files with 9 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
invokeai/frontend/web/src/services/events/onInvocationComplete.tsx
View File

@@ -34,7 +34,6 @@ export const buildOnInvocationComplete = (getState: () => RootState, dispatch: A
// update the total images for the board
dispatch(
boardsApi.util.updateQueryData('getBoardImagesTotal', imageDTO.board_id ?? 'none', (draft) => {
// eslint-disable-next-line @typescript-eslint/no-unused-vars
draft.total += 1;
})
);
@@ -52,15 +51,11 @@ export const buildOnInvocationComplete = (getState: () => RootState, dispatch: A
])
);
const { shouldAutoSwitch, galleryView, selectedBoardId } = getState().gallery;
const { shouldAutoSwitch, selectedBoardId } = getState().gallery;
// If auto-switch is enabled, select the new image
if (shouldAutoSwitch) {
// if auto-add is enabled, switch the gallery view and board if needed as the image comes in
if (galleryView !== 'images') {
dispatch(galleryViewChanged('images'));
}
// If the image is from a different board, switch to that board - this will also select the image
if (imageDTO.board_id && imageDTO.board_id !== selectedBoardId) {
dispatch(
boardIdSelected({
@@ -68,20 +63,21 @@ export const buildOnInvocationComplete = (getState: () => RootState, dispatch: A
selectedImageName: imageDTO.image_name,
})
);
}
dispatch(offsetChanged({ offset: 0 }));
if (!imageDTO.board_id && selectedBoardId !== 'none') {
} else if (!imageDTO.board_id && selectedBoardId !== 'none') {
dispatch(
boardIdSelected({
boardId: 'none',
selectedImageName: imageDTO.image_name,
})
);
} else {
// Else just select the image
dispatch(imageSelected(imageDTO));
}
dispatch(imageSelected(imageDTO));
// We also need to update the gallery view to images and reset the offset to 0
dispatch(galleryViewChanged('images'));
dispatch(offsetChanged({ offset: 0 }));
}
};