fix(ui): non-direct input field names do not block reactflow drag

This commit is contained in:
psychedelicious
2025-02-21 14:43:49 +10:00
committed by Kent Keirsey
parent 55aee034b0
commit c9b0307bcd
2 changed files with 4 additions and 4 deletions

View File

@@ -8,6 +8,7 @@ import { useNodeFieldDnd } from 'features/nodes/components/sidePanel/builder/dnd
import { useInputFieldIsConnected } from 'features/nodes/hooks/useInputFieldIsConnected';
import { useInputFieldIsInvalid } from 'features/nodes/hooks/useInputFieldIsInvalid';
import { useInputFieldTemplate } from 'features/nodes/hooks/useInputFieldTemplate';
import { NO_DRAG_CLASS } from 'features/nodes/types/constants';
import type { FieldInputTemplate } from 'features/nodes/types/field';
import { memo, useCallback, useRef, useState } from 'react';
@@ -112,7 +113,7 @@ const DirectField = memo(({ nodeId, fieldName, isInvalid, isConnected, fieldTemp
data-is-dragging={isDragging}
>
<Flex gap={1}>
<Flex ref={dragHandleRef}>
<Flex className={NO_DRAG_CLASS} ref={dragHandleRef}>
<InputFieldTitle nodeId={nodeId} fieldName={fieldName} isInvalid={isInvalid} isDragging={isDragging} />
</Flex>
<Spacer />

View File

@@ -12,7 +12,7 @@ import { useInputFieldIsConnected } from 'features/nodes/hooks/useInputFieldIsCo
import { useInputFieldLabel } from 'features/nodes/hooks/useInputFieldLabel';
import { useInputFieldTemplateTitle } from 'features/nodes/hooks/useInputFieldTemplateTitle';
import { fieldLabelChanged } from 'features/nodes/store/nodesSlice';
import { HANDLE_TOOLTIP_OPEN_DELAY, NO_DRAG_CLASS, NO_FIT_ON_DOUBLE_CLICK_CLASS } from 'features/nodes/types/constants';
import { HANDLE_TOOLTIP_OPEN_DELAY, NO_FIT_ON_DOUBLE_CLICK_CLASS } from 'features/nodes/types/constants';
import type { MouseEvent } from 'react';
import { memo, useCallback, useMemo, useRef } from 'react';
import { useTranslation } from 'react-i18next';
@@ -88,7 +88,7 @@ export const InputFieldTitle = memo((props: Props) => {
isDisabled={isDragging}
>
<Text
className={`${NO_DRAG_CLASS} ${NO_FIT_ON_DOUBLE_CLICK_CLASS}`}
className={NO_FIT_ON_DOUBLE_CLICK_CLASS}
sx={labelSx}
noOfLines={1}
data-is-invalid={isInvalid}
@@ -104,7 +104,6 @@ export const InputFieldTitle = memo((props: Props) => {
return (
<Input
ref={inputRef}
className={NO_DRAG_CLASS}
variant="outline"
{...editable.inputProps}
_focusVisible={{ borderRadius: 'base', h: 'unset', px: 2 }}