github/OpenHands
1
1
Fork 0
mirror of https://github.com/All-Hands-AI/OpenHands.git synced 2026-04-29 03:00:45 -04:00
Code Issues Packages Projects Releases Wiki Activity

fix: add return type annotation for ConversationMetadata conversion (SQLAlchemy typing PR7) (#14081)

Browse Source 
Co-authored-by: openhands <openhands@all-hands.dev>
This commit is contained in:
Rohit Malhotra
2026-04-22 16:37:18 -04:00
committed by GitHub
parent cd0175d83e
commit 3e0283796e
1 changed files with 10 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
enterprise/storage/saas_conversation_store.py
View File

@@ -68,7 +68,9 @@ class SaasConversationStore(ConversationStore):
return query
def _to_external_model(self, conversation_metadata: StoredConversationMetadata):
def _to_external_model(
self, conversation_metadata: StoredConversationMetadata
) -> ConversationMetadata:
kwargs = {
c.name: getattr(conversation_metadata, c.name)
for c in StoredConversationMetadata.__table__.columns
@@ -219,7 +221,7 @@ class SaasConversationStore(ConversationStore):
def _search():
with self.session_maker() as session:
conversations = (
stored_conversations = (
session.query(StoredConversationMetadata)
.join(
StoredConversationMetadataSaas,
@@ -236,13 +238,16 @@ class SaasConversationStore(ConversationStore):
.limit(limit + 1)
.all()
)
conversations = [self._to_external_model(c) for c in conversations]
conversations = [
self._to_external_model(c) for c in stored_conversations
]
current_page_size = len(conversations)
next_page_id = offset_to_page_id(
offset + limit, current_page_size > limit
)
conversations = conversations[:limit]
return ConversationMetadataResultSet(conversations, next_page_id)
return ConversationMetadataResultSet(
conversations[:limit], next_page_id
)
return await call_sync_from_async(_search)