Compare commits

...

4 Commits

Author SHA1 Message Date
Graham Neubig
7ef6824327 Merge branch 'main' into openhands/fix-websocket-warning-log-level 2025-10-15 16:06:37 -04:00
openhands
c325630920 Remove test for websocket log level
As requested, removing the test since the behavior is well-documented
and the change is simple (log level only).

Co-authored-by: openhands <openhands@all-hands.dev>
2025-10-15 20:05:27 +00:00
openhands
b466f61b98 Fix linting issues in test_session.py
Apply pre-commit formatting fixes:
- Remove trailing whitespace
- Fix line breaks and indentation
- Reformat list comprehensions per ruff style guide

Co-authored-by: openhands <openhands@all-hands.dev>
2025-10-15 20:03:44 +00:00
openhands
085c1ca591 fix: change websocket initialization log level from warning to debug
The message 'There is no listening client in the current room' was being
logged at WARNING level during normal websocket initialization. This was
generating 1000+ warnings per day in production DataDog logs.

This is expected behavior - the code intentionally waits up to 2 seconds
for the websocket client to join the room during initialization. Each
retry attempt (every 0.1s) was logging a warning, but this is not an
error condition.

Changes:
- Changed log level from logger.warning() to logger.debug() in session.py
- Added test to verify the log level is debug (not warning) during
  websocket initialization wait

Fixes #677

Co-authored-by: openhands <openhands@all-hands.dev>
2025-10-15 17:57:53 +00:00

View File

@@ -400,7 +400,7 @@ class WebSession:
)
):
break
self.logger.warning(
self.logger.debug(
f'There is no listening client in the current room,'
f' waiting for the {_waiting_times}th attempt: {self.sid}'
)