Add static TextEditor.viewForOverlayItem method to avoid using global

This commit is contained in:
Nathan Sobo
2017-03-22 12:31:51 -06:00
committed by Antonio Scandurra
parent 5297e7ab1a
commit 1676617218
5 changed files with 6 additions and 1 deletions

View File

@@ -58,6 +58,7 @@ if global.isGeneratingSnapshot
clipboard = new Clipboard
TextEditor.setClipboard(clipboard)
TextEditor.viewForOverlayItem = (item) -> atom.views.getView(item)
global.atom = new AtomEnvironment({
clipboard,

View File

@@ -54,6 +54,7 @@ export default async function () {
const clipboard = new Clipboard()
TextEditor.setClipboard(clipboard)
TextEditor.viewForOverlayItem = (item) -> atom.views.getView(item)
const applicationDelegate = new ApplicationDelegate()
const environmentParams = {

View File

@@ -70,6 +70,7 @@ module.exports = ({blobStore}) ->
clipboard = new Clipboard
TextEditor.setClipboard(clipboard)
TextEditor.viewForOverlayItem = (item) -> atom.views.getView(item)
testRunner = require(testRunnerPath)
legacyTestRunner = require(legacyTestRunnerPath)

View File

@@ -732,7 +732,7 @@ class TextEditorComponent {
addOverlayDecorationToRender (decoration, marker) {
const {class: className, item, position, avoidOverflow} = decoration
const element = atom.views.getView(item)
const element = TextEditor.viewForOverlayItem(item)
const screenPosition = (position === 'tail')
? marker.getTailScreenPosition()
: marker.getHeadScreenPosition()

View File

@@ -65,6 +65,8 @@ class TextEditor extends Model
TextEditorComponent ?= require './text-editor-component'
TextEditorComponent.didUpdateScrollbarStyles()
@viewForOverlayItem: (item) -> item
serializationVersion: 1
buffer: null