mirror of
https://github.com/atom/atom.git
synced 2026-01-23 05:48:10 -05:00
Merge pull request #7320 from atom/as-remove-gutter-from-view-registry
Fix TextEditorComponent Race Condition
This commit is contained in:
@@ -67,6 +67,15 @@ describe "TextEditorComponent", ->
|
||||
|
||||
expect(nextAnimationFrame).not.toThrow()
|
||||
|
||||
it "doesn't update when an animation frame was requested but the component got destroyed before its delivery", ->
|
||||
editor.setText("You shouldn't see this update.")
|
||||
expect(nextAnimationFrame).not.toBe(noAnimationFrame)
|
||||
|
||||
component.destroy()
|
||||
nextAnimationFrame()
|
||||
|
||||
expect(component.lineNodeForScreenRow(0).textContent).not.toBe("You shouldn't see this update.")
|
||||
|
||||
describe "line rendering", ->
|
||||
expectTileContainsRow = (tileNode, screenRow, {top}) ->
|
||||
lineNode = tileNode.querySelector("[data-screen-row='#{screenRow}']")
|
||||
|
||||
@@ -195,7 +195,7 @@ class TextEditorComponent
|
||||
@updateRequested = true
|
||||
atom.views.updateDocument =>
|
||||
@updateRequested = false
|
||||
@updateSync() if @editor.isAlive()
|
||||
@updateSync() if @canUpdate()
|
||||
atom.views.readDocument(@readAfterUpdateSync)
|
||||
|
||||
canUpdate: ->
|
||||
|
||||
Reference in New Issue
Block a user