Let's start with deprecations!

This commit is contained in:
Antonio Scandurra
2015-09-24 10:07:38 +02:00
parent c76525fc63
commit 3236c8f0f8
4 changed files with 27 additions and 2 deletions

View File

@@ -361,6 +361,12 @@ class TextEditorComponent
@scrollViewNode.scrollTop = 0
@scrollViewNode.scrollLeft = 0
onDidChangeScrollTop: (callback) ->
@presenter.onDidChangeScrollTop(callback)
onDidChangeScrollLeft: (callback) ->
@presenter.onDidChangeScrollLeft(callback)
setScrollLeft: (scrollLeft) ->
@presenter.setScrollLeft(scrollLeft)

View File

@@ -218,6 +218,12 @@ class TextEditorElement extends HTMLElement
onDidDetach: (callback) ->
@emitter.on("did-detach", callback)
onDidChangeScrollTop: (callback) ->
@component.onDidChangeScrollTop(callback)
onDidChangeScrollLeft: (callback) ->
@component.onDidChangeScrollLeft(callback)
setScrollLeft: (scrollLeft) ->
@component.setScrollLeft(scrollLeft)

View File

@@ -1561,6 +1561,8 @@ class TextEditorPresenter
@scrollColumn = Math.round(@scrollLeft / @baseCharacterWidth)
@model.setScrollColumn(@scrollColumn)
@emitter.emit 'did-change-scroll-top', @scrollLeft
@pendingScrollLeft = null
commitPendingScrollTopPosition: ->
@@ -1574,6 +1576,7 @@ class TextEditorPresenter
@model.setScrollRow(@scrollRow)
@didStartScrolling()
@emitter.emit 'did-change-scroll-top', @scrollTop
@pendingScrollTop = null
@@ -1590,3 +1593,9 @@ class TextEditorPresenter
@commitPendingLogicalScrollPosition()
@commitPendingScrollLeftPosition()
@commitPendingScrollTopPosition()
onDidChangeScrollTop: (callback) ->
@emitter.on 'did-change-scroll-top', callback
onDidChangeScrollLeft: (callback) ->
@emitter.on 'did-change-scroll-left', callback

View File

@@ -433,10 +433,14 @@ class TextEditor extends Model
@displayBuffer.onDidChangeCharacterWidths(callback)
onDidChangeScrollTop: (callback) ->
@emitter.on 'did-change-scroll-top', callback
Grim.deprecate("This is now a view method. Call TextEditorElement::onDidChangeScrollTop instead.")
atom.views.getView(this).onDidChangeScrollTop(callback)
onDidChangeScrollLeft: (callback) ->
@emitter.on 'did-change-scroll-left', callback
Grim.deprecate("This is now a view method. Call TextEditorElement::onDidChangeScrollLeft instead.")
atom.views.getView(this).onDidChangeScrollLeft(callback)
onDidChangeScrollPosition: (callback) ->
@displayBuffer.onDidChangeScrollPosition(callback)