github/atom
1
1
Fork 0
mirror of https://github.com/atom/atom.git synced 2026-04-06 03:02:13 -04:00
Code Issues Packages Projects Releases Wiki Activity

Use didDestroyPaneItem to remove item from item registry

Browse Source
This commit is contained in:
Nathan Sobo
2017-04-06 12:56:45 -06:00
parent 317428b58d
commit 326ae6bf32
1 changed files with 6 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
src/pane-container.js
View File

@@ -248,11 +248,17 @@ class PaneContainer {
for (let pane of this.getPanes()) { if (pane.items.length === 0) { pane.destroy() } }
}
didAddPaneItem (item, pane, index) {
this.itemRegistry.addItem(item)
this.emitter.emit('did-add-pane-item', {item, pane, index})
}
willDestroyPaneItem (event) {
this.emitter.emit('will-destroy-pane-item', event)
}
didDestroyPaneItem (event) {
this.itemRegistry.removeItem(event.item)
this.emitter.emit('did-destroy-pane-item', event)
}
@@ -308,19 +314,6 @@ class PaneContainer {
const item = iterable[index]
this.didAddPaneItem(item, pane, index)
}
pane.onDidRemoveItem(({item, moved}) => {
if (!moved) { this.removedPaneItem(item) }
})
}))
}
didAddPaneItem (item, pane, index) {
this.itemRegistry.addItem(item)
this.emitter.emit('did-add-pane-item', {item, pane, index})
}
removedPaneItem (item) {
this.itemRegistry.removeItem(item)
}
}